RE: [PATCH v8 15/18] NTB: Add support for EPF PCI-Express Non-Transparent Bridge

> -Original Message- > From: Kishon Vijay Abraham I > Sent: Wednesday, November 11, 2020 8:36 AM > To: Bjorn Helgaas ; Jonathan Corbet > ; Kishon Vijay Abraham I ; Lorenzo > Pieralisi ; Arnd Bergmann ; > Jon Mason ; Jiang, Dave ; > Allen Hubbe ; Tom Joseph ; &

RE: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or remote side of bridge

> -Original Message- > From: Kishon Vijay Abraham I > Sent: Wednesday, November 11, 2020 8:36 AM > To: Bjorn Helgaas ; Jonathan Corbet > ; Kishon Vijay Abraham I ; Lorenzo > Pieralisi ; Arnd Bergmann ; > Jon Mason ; Jiang, Dave ; > Allen Hubbe ; Tom Joseph ; &

Re: [PATCH v6 0/5] Add shared workqueue support for idxd driver

> On Sep 30, 2020, at 9:29 PM, Vinod Koul wrote: > > Hi Dave, > >> On 30-09-20, 15:19, Dave Jiang wrote: >> >> >>> On 9/24/2020 2:51 PM, Borislav Petkov wrote: >>> On Thu, Sep 24, 2020 at 02:32:35PM -0700, Dave Jiang wrote: Hi Vinod, Looks like we are cleared on the x86 patches

RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static

> -Original Message- > From: Yue Haibing [mailto:yuehaib...@huawei.com] > Sent: Wednesday, March 20, 2019 7:08 AM > To: Jiang, Dave ; jdma...@kudzu.us; > alle...@gmail.com > Cc: linux-kernel@vger.kernel.org; linux-...@googlegroups.com; YueHaibing > > Subject:

Re: linux-next: Signed-off-by missing for commits in the nvdimm tree

> On Jul 21, 2018, at 7:36 AM, Stephen Rothwell wrote: > > Hi Dan, > > Commits > > 212a28b4dae9 ("MAINTAINERS: Add Jan Kara for filesystem DAX") > 30153e5ba54d ("MAINTAINERS: update Ross Zwisler's email address") > > are missing a Signed-off-by from their committer. That’s my fault.

Re: linux-next: Signed-off-by missing for commits in the nvdimm tree

> On Jul 21, 2018, at 7:36 AM, Stephen Rothwell wrote: > > Hi Dan, > > Commits > > 212a28b4dae9 ("MAINTAINERS: Add Jan Kara for filesystem DAX") > 30153e5ba54d ("MAINTAINERS: update Ross Zwisler's email address") > > are missing a Signed-off-by from their committer. That’s my fault.

RE: [PATCH] libnvdimm, nfit: fix persistence domain reporting

> -Original Message- > From: Williams, Dan J > Sent: Wednesday, March 21, 2018 3:39 PM > To: linux-nvd...@lists.01.org > Cc: Jiang, Dave <dave.ji...@intel.com>; Rafael J. Wysocki > <r...@rjwysocki.net>; Ross Zwisler <ross.zwis...@linux.intel.com>;

RE: [PATCH] libnvdimm, nfit: fix persistence domain reporting

> -Original Message- > From: Williams, Dan J > Sent: Wednesday, March 21, 2018 3:39 PM > To: linux-nvd...@lists.01.org > Cc: Jiang, Dave ; Rafael J. Wysocki > ; Ross Zwisler ; linux- > a...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] libnvdim

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

> On Jul 20, 2017, at 11:28 PM, Koul, Vinod wrote: > >> On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote: >> >> >>> On 07/19/2017 03:16 PM, Christophe JAILLET wrote: >>> If the 'memcmp' fails, free allocated resources as done in all other >>> error handling

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

> On Jul 20, 2017, at 11:28 PM, Koul, Vinod wrote: > >> On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote: >> >> >>> On 07/19/2017 03:16 PM, Christophe JAILLET wrote: >>> If the 'memcmp' fails, free allocated resources as done in all other >>> error handling paths. >>> >>>

RE: [PATCH 5/7] ntb: ntb_hw_intel: remove ioread64 and iowrite64 hacks

<log...@deltatee.com>; Jon Mason <jdma...@kudzu.us>; Jiang, > Dave <dave.ji...@intel.com>; Allen Hubbe > <allen.hu...@emc.com> > Subject: [PATCH 5/7] ntb: ntb_hw_intel: remove ioread64 and iowrite64 hacks > > Now that ioread64 and iowrite64 are available gen

RE: [PATCH 5/7] ntb: ntb_hw_intel: remove ioread64 and iowrite64 hacks

..@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; linux-cry...@vger.kernel.org; > dri-de...@lists.freedesktop.org > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Stephen Bates ; > Logan Gunthorpe ; Jon Mason ; Jiang, > Dave ; Allen Hubbe > > Subject: [PATCH 5/7] ntb: n

Re: [PATCH] mm, x86: fix native_pud_clear build error

On Tue, Mar 14, 2017 at 01:12:53PM +0100, Arnd Bergmann wrote: > We still get a build error in random configurations, after this has been > modified a few times: > > In file included from include/linux/mm.h:68:0, > from include/linux/suspend.h:8, > from

Re: [PATCH] mm, x86: fix native_pud_clear build error

On Tue, Mar 14, 2017 at 01:12:53PM +0100, Arnd Bergmann wrote: > We still get a build error in random configurations, after this has been > modified a few times: > > In file included from include/linux/mm.h:68:0, > from include/linux/suspend.h:8, > from

Re: [PATCH 2/2] ntb: make DMA_OUT_RESOURCE_TO HZ independent

On Mon, 2016-08-22 at 18:51 +0200, Nicholas Mc Guire wrote: > schedule_timeout_* takes a timeout in jiffies but the code currently > is > passing in a constant which makes this timeout HZ dependent, so pass > it > through msecs_to_jiffies() to fix this up. > > Signed-off-by: Nicholas Mc Guire

Re: [PATCH 2/2] ntb: make DMA_OUT_RESOURCE_TO HZ independent

On Mon, 2016-08-22 at 18:51 +0200, Nicholas Mc Guire wrote: > schedule_timeout_* takes a timeout in jiffies but the code currently > is > passing in a constant which makes this timeout HZ dependent, so pass > it > through msecs_to_jiffies() to fix this up. > > Signed-off-by: Nicholas Mc Guire

Re: [PATCH v4 10/10] ntb_perf: clear link_is_up flag when the link goes down.

On Thu, 2016-06-16 at 14:17 -0600, Logan Gunthorpe wrote: > When the link goes down, the link_is_up flag did not return to > false. This could have caused some subtle corner case bugs > when the link goes up and down quickly. > > Once that was fixed, there was found to be a race if the link was >

Re: [PATCH v4 10/10] ntb_perf: clear link_is_up flag when the link goes down.

On Thu, 2016-06-16 at 14:17 -0600, Logan Gunthorpe wrote: > When the link goes down, the link_is_up flag did not return to > false. This could have caused some subtle corner case bugs > when the link goes up and down quickly. > > Once that was fixed, there was found to be a race if the link was >

Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.

never returns to false. > > I think the correct solution is to just remove the link_cleanup work > and > do those actions immediately on receipt of the event. If there's > agreement on this I can re-spin it again. I'm ok with that. This is not an issue with ntb_transport? > &g

Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.

never returns to false. > > I think the correct solution is to just remove the link_cleanup work > and > do those actions immediately on receipt of the event. If there's > agreement on this I can re-spin it again. I'm ok with that. This is not an issue with ntb_transport? > &g

Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.

On Wed, 2016-06-15 at 15:26 -0600, Logan Gunthorpe wrote: > When the link goes down, the link_is_up flag did not return to > false. This could have caused some subtle corner case bugs > when the link goes up and down quickly. > > Signed-off-by: Logan Gunthorpe Acked-by:

Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.

On Wed, 2016-06-15 at 15:26 -0600, Logan Gunthorpe wrote: > When the link goes down, the link_is_up flag did not return to > false. This could have caused some subtle corner case bugs > when the link goes up and down quickly. > > Signed-off-by: Logan Gunthorpe Acked-by: Dave Jiang And all the

Re: [PATCH 4/8] ntb_perf: Wait for link before running test

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > Instead of returning immediately with an error when the link is > down, wait for the link to come up (or the user sends a SIGINT). > > This is to make scripting ntb_perf easier. > > Signed-off-by: Logan Gunthorpe

Re: [PATCH 4/8] ntb_perf: Wait for link before running test

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > Instead of returning immediately with an error when the link is > down, wait for the link to come up (or the user sends a SIGINT). > > This is to make scripting ntb_perf easier. > > Signed-off-by: Logan Gunthorpe Acked-by: Dave Jiang

Re: [PATCH 3/8] ntb_perf: Return results by reading the run file

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > Instead of having to watch logs, allow the results to be retrieved > by reading back the run file. This file will return "running" when > the test is running and nothing if no tests have been run yet. > It returns 1 line per thread, and

Re: [PATCH 3/8] ntb_perf: Return results by reading the run file

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > Instead of having to watch logs, allow the results to be retrieved > by reading back the run file. This file will return "running" when > the test is running and nothing if no tests have been run yet. > It returns 1 line per thread, and

Re: [PATCH 2/8] ntb_perf: Improve thread handling to increase robustness

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > This commit accomplishes a few things: > > 1) Properly prevent multiple sets of threads from running at once > using > a mutex. Lots of race issues existed with the thread_cleanup. > > 2) The mutex allows us to ensure that threads are

Re: [PATCH 2/8] ntb_perf: Improve thread handling to increase robustness

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > This commit accomplishes a few things: > > 1) Properly prevent multiple sets of threads from running at once > using > a mutex. Lots of race issues existed with the thread_cleanup. > > 2) The mutex allows us to ensure that threads are

Re: [PATCH 1/8] ntb_perf: Schedule based on time not on performance

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > When debugging performance problems, if some issue causes the ntb > hardware to be significantly slower than expected, ntb_perf will > hang requiring a reboot because it only schedules once every 4GB. > > Instead, schedule based on

Re: [PATCH 1/8] ntb_perf: Schedule based on time not on performance

On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote: > When debugging performance problems, if some issue causes the ntb > hardware to be significantly slower than expected, ntb_perf will > hang requiring a reboot because it only schedules once every 4GB. > > Instead, schedule based on

Re: [PATCH v2 2/3] ntb_transport: Check the number of spads the hardware supports

On Tue, 2016-06-07 at 11:20 -0600, Logan Gunthorpe wrote: > I'm working on hardware that currently has a limited number of > scratchpad registers and ntb_ndev fails with no clue as to why. I > feel it is better to fail early and provide a reasonable error > message > then to fail later on. > >

Re: [PATCH v2 2/3] ntb_transport: Check the number of spads the hardware supports

On Tue, 2016-06-07 at 11:20 -0600, Logan Gunthorpe wrote: > I'm working on hardware that currently has a limited number of > scratchpad registers and ntb_ndev fails with no clue as to why. I > feel it is better to fail early and provide a reasonable error > message > then to fail later on. > >

Re: [PATCH 1/3] ntb_perf: Allow limiting the size of the memory windows

On Fri, 2016-06-03 at 14:50 -0600, Logan Gunthorpe wrote: > On my system, dma_alloc_coherent won't produce memory anywhere > near the size of the BAR. So I needed a way to limit this. > > It's pretty much copied straight from ntb_transport. > > Signed-off-by: Logan Gunthorpe

Re: [PATCH 1/3] ntb_perf: Allow limiting the size of the memory windows

On Fri, 2016-06-03 at 14:50 -0600, Logan Gunthorpe wrote: > On my system, dma_alloc_coherent won't produce memory anywhere > near the size of the BAR. So I needed a way to limit this. > > It's pretty much copied straight from ntb_transport. > > Signed-off-by: Logan Gunthorpe Acked-by: Dave

RE: ioatdma(Intel(R) I/OAT DMA Engine init failed)

> -Original Message- > From: Koul, Vinod > Sent: Thursday, May 19, 2016 10:23 AM > To: Jiang, Dave <dave.ji...@intel.com> > Cc: Gavin Guo <gavin@canonical.com>; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; Williams, Dan J > <dan

RE: ioatdma(Intel(R) I/OAT DMA Engine init failed)

> -Original Message- > From: Koul, Vinod > Sent: Thursday, May 19, 2016 10:23 AM > To: Jiang, Dave > Cc: Gavin Guo ; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; Williams, Dan J > > Subject: Re: ioatdma(Intel(R) I/OAT DMA Engine init failed) &

RE: ioatdma(Intel(R) I/OAT DMA Engine init failed)

> -Original Message- > From: Gavin Guo [mailto:gavin@canonical.com] > Sent: Wednesday, May 18, 2016 8:19 PM > To: Jiang, Dave <dave.ji...@intel.com> > Cc: Koul, Vinod <vinod.k...@intel.com>; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org;

RE: ioatdma(Intel(R) I/OAT DMA Engine init failed)

> -Original Message- > From: Gavin Guo [mailto:gavin@canonical.com] > Sent: Wednesday, May 18, 2016 8:19 PM > To: Jiang, Dave > Cc: Koul, Vinod ; dmaeng...@vger.kernel.org; > linux-kernel@vger.kernel.org; Williams, Dan J > > Subject: Re: ioatdma(Intel(R) I/OA

Re: ioatdma(Intel(R) I/OAT DMA Engine init failed)

On Wed, 2016-05-18 at 13:27 +, Gavin Guo wrote: > On Tue, May 17, 2016 at 6:06 PM, Vinod Koul > wrote: > > > > On Mon, May 16, 2016 at 06:08:20PM +0800, Gavin Guo wrote: > > > > > > The following error messages can be observed on the Intel > > > Haswell-E > > > chipset

Re: ioatdma(Intel(R) I/OAT DMA Engine init failed)

On Wed, 2016-05-18 at 13:27 +, Gavin Guo wrote: > On Tue, May 17, 2016 at 6:06 PM, Vinod Koul > wrote: > > > > On Mon, May 16, 2016 at 06:08:20PM +0800, Gavin Guo wrote: > > > > > > The following error messages can be observed on the Intel > > > Haswell-E > > > chipset with v3.13 kernel.

Re: [PATCH] ntb: test: fix pointer size warning

On Fri, 2016-03-18 at 10:11 -0700, Brian Norris wrote: > drivers/ntb/test/ntb_perf.c: In function ‘perf_copy’: > drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to > integer of different size [-Wpointer-to-int-cast] > drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to

Re: [PATCH] ntb: test: fix pointer size warning

On Fri, 2016-03-18 at 10:11 -0700, Brian Norris wrote: > drivers/ntb/test/ntb_perf.c: In function ‘perf_copy’: > drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to > integer of different size [-Wpointer-to-int-cast] > drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to

Re: [PATCH] ntb: fix possible NULL dereference

On Thu, 2016-03-10 at 17:51 +0530, Sudip Mukherjee wrote: > kmalloc can fail and we should check for NULL before using the > pointer > returned by kmalloc. > > Signed-off-by: Sudip Mukherjee Acked-by: Dave Jiang Thanks! > --- >  

Re: [PATCH] ntb: fix possible NULL dereference

On Thu, 2016-03-10 at 17:51 +0530, Sudip Mukherjee wrote: > kmalloc can fail and we should check for NULL before using the > pointer > returned by kmalloc. > > Signed-off-by: Sudip Mukherjee Acked-by: Dave Jiang Thanks! > --- >  drivers/ntb/test/ntb_perf.c | 2 ++ >  1 file changed, 2

Re: [PATCH] ntb: perf test: fix address space confusion

On Tue, 2016-01-26 at 10:31 +0100, Arnd Bergmann wrote: > The ntb driver assigns between pointers an __iomem tokens, and > also casts them to 64-bit integers, which results in compiler > warnings on 32-bit systems: > > drivers/ntb/test/ntb_perf.c: In function 'perf_copy': >

Re: [PATCH] ntb: perf test: fix address space confusion

On Tue, 2016-01-26 at 10:31 +0100, Arnd Bergmann wrote: > The ntb driver assigns between pointers an __iomem tokens, and > also casts them to 64-bit integers, which results in compiler > warnings on 32-bit systems: > > drivers/ntb/test/ntb_perf.c: In function 'perf_copy': >

Re: [RFC] User space to kernel space copy optimization

On Mon, 2015-11-16 at 23:19 +, Sinan Kaya wrote: > On 11/16/2015 5:57 PM, Jiang, Dave wrote: > > > One of the things I'm interested in is to use a memcpy capable > > > DMA > > > > engine HW to optimize user space and kernel space parameter > > > >

Re: [RFC] User space to kernel space copy optimization

On Mon, 2015-11-16 at 23:19 +, Sinan Kaya wrote: > On 11/16/2015 5:57 PM, Jiang, Dave wrote: > > > One of the things I'm interested in is to use a memcpy capable > > > DMA > > > > engine HW to optimize user space and kernel space parameter > > > >

Re: [RFC] User space to kernel space copy optimization

On Mon, 2015-11-16 at 21:53 +, Sinan Kaya wrote: > One of the things I'm interested in is to use a memcpy capable DMA > engine HW to optimize user space and kernel space parameter copying. Have you looked at why NET_DMA was deprecated and using DMA engine to do kernel->user copy could be a

Re: [RFC] User space to kernel space copy optimization

On Mon, 2015-11-16 at 21:53 +, Sinan Kaya wrote: > One of the things I'm interested in is to use a memcpy capable DMA > engine HW to optimize user space and kernel space parameter copying. Have you looked at why NET_DMA was deprecated and using DMA engine to do kernel->user copy could be a

Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps()

On Mon, 2015-08-17 at 17:31 -0500, Bjorn Helgaas wrote: > On Wed, Jul 29, 2015 at 04:18:55PM -0600, Keith Busch wrote: > > From: Dave Jiang > > > > The setting of PCIe MPS should be left to the PCI subsystem and not > > the driver. An ill configured MPS by the driver could cause the > > device

Re: [PATCH 2/3] QIB: Removing usage of pcie_set_mps()

On Mon, 2015-08-17 at 17:30 -0500, Bjorn Helgaas wrote: > [+cc Mike, linux-rdma] > > On Wed, Jul 29, 2015 at 04:18:54PM -0600, Keith Busch wrote: > > From: Dave Jiang > > > > This is in perperation of un-exporting the pcie_set_mps() function > > symbol. A driver should not be changing the MPS

Re: [PATCH 2/3] QIB: Removing usage of pcie_set_mps()

On Mon, 2015-08-17 at 17:30 -0500, Bjorn Helgaas wrote: [+cc Mike, linux-rdma] On Wed, Jul 29, 2015 at 04:18:54PM -0600, Keith Busch wrote: From: Dave Jiang dave.ji...@intel.com This is in perperation of un-exporting the pcie_set_mps() function symbol. A driver should not be changing

Re: [PATCH 3/3] PCIE: Remove symbol export for pcie_set_mps()

On Mon, 2015-08-17 at 17:31 -0500, Bjorn Helgaas wrote: On Wed, Jul 29, 2015 at 04:18:55PM -0600, Keith Busch wrote: From: Dave Jiang dave.ji...@intel.com The setting of PCIe MPS should be left to the PCI subsystem and not the driver. An ill configured MPS by the driver could cause the

Re: [RFC Patch V1] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

> On Jun 28, 2015, at 7:14 PM, Jiang Liu wrote: > > Hi Dave, >Gentle Ping:) Any suggestion about this patch? > Thanks! > Gerry I'm fine with it if Dan has no objections. >> On 2015/6/2 14:36, Jiang Liu wrote: >> The dmaengine core assumes that async DMA devices will only be removed >>

Re: [RFC Patch V1] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

On Jun 28, 2015, at 7:14 PM, Jiang Liu jiang@linux.intel.com wrote: Hi Dave, Gentle Ping:) Any suggestion about this patch? Thanks! Gerry I'm fine with it if Dan has no objections. On 2015/6/2 14:36, Jiang Liu wrote: The dmaengine core assumes that async DMA devices will only

Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k

On Tue, 2015-06-09 at 11:04 -0500, 'Bjorn Helgaas' via linux-ntb wrote: > On Tue, Jun 9, 2015 at 4:44 AM, Allen Hubbe > wrote: > > From: Dave Jiang > > > > Benchmarking showed significant performance increase going from MTU > > size > > of 64k from 16k. Changing the default. > > This

Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k

On Tue, 2015-06-09 at 11:04 -0500, 'Bjorn Helgaas' via linux-ntb wrote: On Tue, Jun 9, 2015 at 4:44 AM, Allen Hubbe allen.hu...@emc.com wrote: From: Dave Jiang dave.ji...@intel.com Benchmarking showed significant performance increase going from MTU size of 64k from 16k. Changing

Re: [PATCH 04/16] Check the DID for certain workaround error flags to be set.

On Wed, 2015-05-20 at 16:11 -0500, Bjorn Helgaas wrote: > On Wed, May 20, 2015 at 10:41 AM, Allen Hubbe wrote: > > From: Dave Jiang > > > > Signed-off-by: Dave Jiang > > Needs a topic in the subject line and a changelog. > > It also seems to do a lot more than just checking device ID (I

Re: [PATCH 04/16] Check the DID for certain workaround error flags to be set.

On Wed, 2015-05-20 at 16:11 -0500, Bjorn Helgaas wrote: On Wed, May 20, 2015 at 10:41 AM, Allen Hubbe allen.hu...@emc.com wrote: From: Dave Jiang dave.ji...@intel.com Signed-off-by: Dave Jiang dave.ji...@intel.com Needs a topic in the subject line and a changelog. It also seems to do

Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe

On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote: > pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Signed-off-by: Michael S. Tsirkin Acked-by: Dave Jiang > --- > drivers/ntb/ntb_hw.c

Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe

On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote: pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Dave Jiang

Re: [PATCH v2] ioat: fail self-test if wait_for_completion times out

On Thu, 2015-01-08 at 14:16 +, Nicholas Mc Guire wrote: > wait_for_completion_timeout reaching timeout was being ignored, > fail the self-test if timeout condition occurs. > > v2: fixup of coding style issues. > > Signed-off-by: Nicholas Mc Guire Acked-by: Dave Jiang > --- > > this

Re: [PATCH v2] ioat: fail self-test if wait_for_completion times out

On Thu, 2015-01-08 at 14:16 +, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, fail the self-test if timeout condition occurs. v2: fixup of coding style issues. Signed-off-by: Nicholas Mc Guire der.h...@hofr.at Acked-by: Dave Jiang

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Wed, 2015-01-07 at 13:09 +, Nicholas Mc Guire wrote: > On Wed, 07 Jan 2015, Prarit Bhargava wrote: > > > > > > > On 01/06/2015 10:38 AM, Jiang, Dave wrote: > > >>>> - if (dma->device_tx_status(dma_chan, cookie, NULL) != > > >&

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Wed, 2015-01-07 at 13:09 +, Nicholas Mc Guire wrote: On Wed, 07 Jan 2015, Prarit Bhargava wrote: On 01/06/2015 10:38 AM, Jiang, Dave wrote: - if (dma-device_tx_status(dma_chan, cookie, NULL) != DMA_COMPLETE) { + if (tmo == 0 || dma-device_tx_status(dma_chan

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Tue, 2015-01-06 at 00:42 +, Nicholas Mc Guire wrote: > On Mon, 05 Jan 2015, Jiang, Dave wrote: > > > > > > > > > On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: > > > wait_for_completion_timeout reaching timeout was being ignor

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Tue, 2015-01-06 at 00:42 +, Nicholas Mc Guire wrote: On Mon, 05 Jan 2015, Jiang, Dave wrote: On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, fail the self-test if timeout condition occurs

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: > wait_for_completion_timeout reaching timeout was being ignored, > fail the self-test if timeout condition occurs. > > Not sure about the indentations used (CodingStyle:Chapter 2) > > this was only compile tested with >

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, fail the self-test if timeout condition occurs. Not sure about the indentations used (CodingStyle:Chapter 2) this was only compile tested with x86_64_defconfig +

Re: [PATCH] DCA: fix over-warning in ioat3_dca_init

On Thu, 2014-05-08 at 08:57 -0700, Alexander Duyck wrote: > On 05/08/2014 08:28 AM, Jet Chen wrote: > > I agree with your option that it is a real BIOS bug and it puts pressure on > > the BIOS guys to get this fixed. However, this warning message interferes > > with our kernel booting tests and

Re: [PATCH] DCA: fix over-warning in ioat3_dca_init

On Thu, 2014-05-08 at 08:57 -0700, Alexander Duyck wrote: On 05/08/2014 08:28 AM, Jet Chen wrote: I agree with your option that it is a real BIOS bug and it puts pressure on the BIOS guys to get this fixed. However, this warning message interferes with our kernel booting tests and kernel

Re: [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page

On Fri, 2013-11-15 at 14:55 -0800, Dave Hansen wrote: > This took some of Mel's comments in to consideration. Dave > Jiang, could you retest this if you get a chance? These have > only been lightly compile-tested. > Everything looks good. Tested-by: Dave Jiang

Re: [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page

On Fri, 2013-11-15 at 14:55 -0800, Dave Hansen wrote: This took some of Mel's comments in to consideration. Dave Jiang, could you retest this if you get a chance? These have only been lightly compile-tested. Everything looks good. Tested-by: Dave Jiang dave.ji...@intel.com

Re: [PATCH] ioat: PM Support

Acked-by: Dave Jiang On Wed, 2013-08-21 at 16:42 -0700, Jon Mason wrote: > Add power management support in the IOAT driver. Adding this feature > resolves a known issue when attempting to suspend on systems with IOAT > enabled. On those systems, IOAT would experience a DMA channel error > when

Re: [PATCH] ioat: PM Support

Acked-by: Dave Jiang dave.ji...@intel.com On Wed, 2013-08-21 at 16:42 -0700, Jon Mason wrote: Add power management support in the IOAT driver. Adding this feature resolves a known issue when attempting to suspend on systems with IOAT enabled. On those systems, IOAT would experience a DMA

Re: ioatdma: add ioat_raid_enabled module parameter

On Fri, 2013-08-02 at 16:57 +, Dan Williams wrote: > > On 8/2/13 12:34 AM, "Brice Goglin" wrote: > > >Le 01/08/2013 19:15, Jiang, Dave a écrit : > >> On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >>> On Wed, Jul 31, 2013 at 03:1

Re: ioatdma: add ioat_raid_enabled module parameter

That looks fine. Acked-by: Dave Jiang On Fri, 2013-08-02 at 09:34 +0200, Brice Goglin wrote: > Le 01/08/2013 19:15, Jiang, Dave a écrit : > > On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > >> On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > >

Re: ioatdma: add ioat_raid_enabled module parameter

That looks fine. Acked-by: Dave Jiang dave.ji...@intel.com On Fri, 2013-08-02 at 09:34 +0200, Brice Goglin wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok

Re: ioatdma: add ioat_raid_enabled module parameter

On Fri, 2013-08-02 at 16:57 +, Dan Williams wrote: On 8/2/13 12:34 AM, Brice Goglin brice.gog...@inria.fr wrote: Le 01/08/2013 19:15, Jiang, Dave a écrit : On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok

Re: ioatdma: add ioat_raid_enabled module parameter

On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: > On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: > > I'm ok with enabling this for people that just want to use DMA and not > > RAID. > > I might be crazy, but I'd be in favor of disabling the RAID offload by

Re: ioatdma: add ioat_raid_enabled module parameter

On Thu, 2013-08-01 at 10:11 -0700, Jon Mason wrote: On Wed, Jul 31, 2013 at 03:14:07PM -0700, Jiang, Dave wrote: I'm ok with enabling this for people that just want to use DMA and not RAID. I might be crazy, but I'd be in favor of disabling the RAID offload by default on non-Atom

Re: ioatdma: add ioat_raid_enabled module parameter

I'm ok with enabling this for people that just want to use DMA and not RAID. Acked-by: Dave Jiang On Thu, 2013-08-01 at 00:05 +0200, Brice Goglin wrote: > ioatdma: add ioat_raid_enabled module parameter > > Commit f26df1a1 added a 64-byte alignment requirement for legacy > operations to work

Re: ioatdma: add ioat_raid_enabled module parameter

I'm ok with enabling this for people that just want to use DMA and not RAID. Acked-by: Dave Jiang dave.ji...@intel.com On Thu, 2013-08-01 at 00:05 +0200, Brice Goglin wrote: ioatdma: add ioat_raid_enabled module parameter Commit f26df1a1 added a 64-byte alignment requirement for legacy

Re: [PATCH v2] ioatdma: silence GCC warnings

On Sat, 2013-07-20 at 20:05 +0200, Paul Bolle wrote: > Building dma_v3.o triggers a GCC warning: > drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’: > drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array > bounds [-Warray-bounds] >

Re: [PATCH v2] ioatdma: silence GCC warnings

On Sat, 2013-07-20 at 20:05 +0200, Paul Bolle wrote: Building dma_v3.o triggers a GCC warning: drivers/dma/ioat/dma_v3.c: In function ‘__ioat3_prep_pq16_lock’: drivers/dma/ioat/dma_v3.c:264:11: warning: array subscript is below array bounds [-Warray-bounds]

Re: [PATCH 00/10] Add Intel Atom S1200 seris ioatdma support

On Apr 9, 2013, at 10:30 PM, "Koul, Vinod" wrote: > On Tue, Apr 09, 2013 at 05:53:59PM -0700, Dan Williams wrote: >> On Tue, Apr 9, 2013 at 12:28 AM, Vinod Koul wrote: >>> Are you okay with the series. Merge window is very close... >>> >>> >> Hi Vinod, thanks for the ping. >> >> Chatted

Re: [PATCH 00/10] Add Intel Atom S1200 seris ioatdma support

On Apr 9, 2013, at 10:30 PM, Koul, Vinod vinod.k...@intel.com wrote: On Tue, Apr 09, 2013 at 05:53:59PM -0700, Dan Williams wrote: On Tue, Apr 9, 2013 at 12:28 AM, Vinod Koul vinod.k...@intel.com wrote: Are you okay with the series. Merge window is very close... Hi Vinod, thanks for the

[PATCH 09/10 v2] ioatdma: Adding write back descriptor error status support for ioatdma 3.3

v3.3 provides support for write back descriptor error status. This allows reporting of errors in a descriptor field. In supporting this, certain errors such as P/Q validation errors no longer halts the channel. The DMA engine can continue to execute until the end of the chain and allow software to

[PATCH 09/10 v2] ioatdma: Adding write back descriptor error status support for ioatdma 3.3

v3.3 provides support for write back descriptor error status. This allows reporting of errors in a descriptor field. In supporting this, certain errors such as P/Q validation errors no longer halts the channel. The DMA engine can continue to execute until the end of the chain and allow software to

Re: [PATCH] ioat: remove chanerr mask setting for IOAT v3.x

On Nov 26, 2012, at 9:56 PM, "Dan Williams" wrote: > On Fri, Nov 16, 2012 at 3:26 PM, Dave Jiang wrote: >> The CHANERRMSK_INT register should be 0. The existing code set a value >> for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that >> has been fixed when the hardware

Re: [PATCH] ioat: remove chanerr mask setting for IOAT v3.x

On Nov 26, 2012, at 9:56 PM, Dan Williams d...@fb.com wrote: On Fri, Nov 16, 2012 at 3:26 PM, Dave Jiang dave.ji...@intel.com wrote: The CHANERRMSK_INT register should be 0. The existing code set a value for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that has been

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

On Jul 31, 2012, at 7:10 PM, "Jianbin Kang" wrote: >> Actually this is what I'm working on now, using async_tx to replace the >> memcpy. I believe the changes shouldn't be that significant. >> >> Is the "hardware that can setup dma" you refer to something that does >> not use this interface?

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

On Jul 31, 2012, at 7:10 PM, Jianbin Kang kjbm...@gmail.com wrote: Actually this is what I'm working on now, using async_tx to replace the memcpy. I believe the changes shouldn't be that significant. Is the hardware that can setup dma you refer to something that does not use this