Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

2018-05-15 Thread Jingoo Han
to use managed resource > allocation internally later on. > > CC: Jingoo Han <jingooh...@gmail.com> > CC: Joao Pinto <joao.pi...@synopsys.com> > CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> Ack

Re: [PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jingoo Han
requiring everyone to do this explicitly, convert the > existing function to a managed version. > > CC: Jingoo Han <jingooh...@gmail.com> > CC: Joao Pinto <joao.pi...@synopsys.com> > CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Signed-off-by: Jan Kiszka <jan.

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

2018-05-04 Thread Jingoo Han
person who have an experience to send patches to Linux mailing-list. Best regards, Jingoo Han > > pm8941-wled.c driver is supporting the WLED peripheral > on pm8941. Rename it to qcom-wled.c so that it can support > WLED on multiple PMICs. > > Signed-off-by: Kiran Gunda <

Re: [PATCH 2/2] backlight: Remove ld9040 driver

2018-04-30 Thread Jingoo Han
> -Original Message- > From: Krzysztof Kozlowski <k...@kernel.org> > Sent: Monday, April 30, 2018 1:30 PM > To: Lee Jones <lee.jo...@linaro.org>; Daniel Thompson > <daniel.thomp...@linaro.org>; Jingoo Han <jingooh...@gmail.com>; > Bartlomie

Re: [PATCH 1/2] backlight: Remove s6e63m0 driver

2018-04-30 Thread Jingoo Han
Makefile| 1 - > drivers/video/backlight/s6e63m0.c | 857 > Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han [.]

Re: [PATCH 4/6] PCI: Convert of_pci_get_host_bridge_resources users to devm variant

2018-04-25 Thread Jingoo Han
> -Original Message- > From: Jan Kiszka <jan.kis...@siemens.com> > Sent: Tuesday, April 24, 2018 11:14 AM > To: Bjorn Helgaas <bhelg...@google.com>; Linux Kernel Mailing List ker...@vger.kernel.org>; linux-...@vger.kernel.org; linux-arm- > ker...@lists.

Re: [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches

2018-04-25 Thread Jingoo Han
gned. And total activity in the backlight subsystem is miniscule > compared to drm overall. > > Cc: Lee Jones <lee.jo...@linaro.org> > Cc: Daniel Thompson <daniel.thomp...@linaro.org> > Cc: Jingoo Han <jingooh...@gmail.com> > Acked-by: Daniel Thompson <danie

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-25 Thread Jingoo Han
s. > > Cc: Lee Jones <lee.jo...@linaro.org> > Cc: Daniel Thompson <daniel.thomp...@linaro.org> > Cc: Jingoo Han <jingooh...@gmail.com> > Cc: Meghana Madhyastha <meghana.madhyas...@gmail.com> > Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> &g

Re: [PATCH v7 6/9] PCI: dwc: Define maximum number of vectors

2018-04-24 Thread Jingoo Han
ily visible to future modifications. > > The designware IP supports a maximum of 256 vectors. > > Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Ji

Re: [RESEND PATCH v6 22/27] drm/bridge: analogix_dp: Split the platform-specific poweron in two parts

2018-04-24 Thread Jingoo Han
com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 7 ++

Re: [RESEND PATCH v6 13/27] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-04-24 Thread Jingoo Han
y: Enric Balletbo i Serra <enric.balle...@collabora.com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Heiko Stuebner <he...@sntech.de> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com

Re: [RESEND PATCH v6 11/27] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-04-24 Thread Jingoo Han
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > >

Re: [RESEND PATCH v6 10/27] drm/bridge: analogix_dp: Check dpcd write/read status

2018-04-24 Thread Jingoo Han
@collabora.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: J

Re: [RESEND PATCH v6 16/27] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-04-23 Thread Jingoo Han
o i Serra <enric.balle...@collabora.com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > > .../gpu/drm/bridge/a

Re: [RESEND PATCH v6 14/27] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-04-23 Thread Jingoo Han
ajda <a.ha...@samsung.com> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best reg

Re: [PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Jingoo Han
good > practice whenever there is a division / multiplication by multiple of 2 > to replace it by the equivalent operation in this case, the shift > rotation. > > Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> &

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

2018-04-11 Thread Jingoo Han
On Wednesday, April 11, 2018 3:40 AM, Gustavo Pimentel wrote: > > Hi Jingoo, > > On 11/04/2018 01:01, Jingoo Han wrote: > > On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > >> > >> Replaces a simple division by 2 to a right shift rotation of 1

Re: [PATCH v2 9/9] PCI: dwc: Replace magic number by defines

2018-04-10 Thread Jingoo Han
On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > > Replace magic numbers by a well known define in order to make the code > human readable and also facilitate the code reusability. > > Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> Acked-by

Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters

2018-04-10 Thread Jingoo Han
function. > > Signed-off-by: Gustavo Pimentel <gustavo.pimen...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> > --- > Change v1->v2: > - Added an extra log description line about code style following Fabio > Estevam suggestion. > > drivers/pci

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

2018-04-10 Thread Jingoo Han
On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > > Replaces a simple division by 2 to a right shift rotation of 1 bit. It looks good. However, would you add a simple reason to the commit message? Best regards, Jingoo Han > > Signed-off-by: Gustavo Pimentel &l

Re: [PATCH] video: fbdev: s3c-fb: remove dead platform code for Exynos and S5PV210 platforms

2018-02-14 Thread Jingoo Han
On Wednesday, February 14, 2018 7:01 AM wrote: > > Exynos5, Exynos4 and S5PV210 platforms have been converted to > use Device Tree and Exynos DRM driver long time ago. Remove > dead platform code for these platforms and update Kconfig > s3c-fb entry accordingly. > > Cc

Re: [PATCH 3/3] PCI: designware-ep: Return an error when requesting a too large BAR size

2018-02-01 Thread Jingoo Han
t; #include > > if (size > SZ_4G) { I like this one for the readability. Thank you. Best regards, Jingoo Han > > ? > > -- > With Best Regards, > Andy Shevchenko

Re: [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches

2018-01-17 Thread Jingoo Han
makes sense to cross-post patches and keep > > aligned. And total activity in the backlight subsystem is miniscule > > compared to drm overall. > > > > Cc: Lee Jones <lee.jo...@linaro.org> > > Cc: Daniel Thompson <daniel.thomp...@linaro.org> > > C

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

2018-01-02 Thread Jingoo Han
++ > > drivers/pci/dwc/pci-exynos.c | 219 ++- > -- > > 2 files changed, 22 insertions(+), 255 deletions(-) > > I have updated the commit log to the patch below, please > check before I push it out. I think that the commit message looks good. Th

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

2017-12-27 Thread Jingoo Han
Modified the binding documentation. > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> (I resend my email, because Bjorn's address was wrong in the previous email.) Thank you for your patch. It looks good. Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

2017-12-27 Thread Jingoo Han
Modified the binding documentation. > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Thank you for your patch. It looks good. Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > .../bindings/pci/samsung,exynos5440-pcie.txt

Re: [PATCH v2] backlight: otm3225a: add support for ORISE OTM3225A LCD SoC

2017-12-27 Thread Jingoo Han
s SPI interface it switches to use 16-bib RGB as external > display interface. > > Signed-off-by: Felix Brack <f...@ltec.ch> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > > Changes in v2: > - use descriptive names for registers instead of hard

Re: [PATCH] backlight: otm3225a: add support for ORISE OTM3225A LCD SoC

2017-12-22 Thread Jingoo Han
;, > + .owner = THIS_MODULE, > + }, > + .probe = otm3225a_probe, > + .remove = otm3225a_remove, If you use devm_kzalloc() and devm_lcd_device_register(), you can remove otm3225a_remove() as below. +static struct spi_driver otm3225a_driver = { + .driver = { + .name = "otm3225a", + .owner = THIS_MODULE, + }, + .probe = otm3225a_probe, +}; Please refer to the following driver. ./drivers/video/backlight/tps65217_bl.c > +}; > + > +static __init int otm3225a_init(void) > +{ > + return (_driver); > +} > + > +static __exit void otm3225a_exit(void) > +{ > + spi_unregister_driver(_driver); > +} > + > +module_init(otm3225a_init); > +module_exit(otm3225a_exit); Instead of adding otm3225a_init(), otm3225a_exit(), please use module_spi_driver macro as below. This macro can reduce source code lines. module_spi_driver(otm3225a_driver); Best regards, Jingoo Han > + > +MODULE_AUTHOR("Felix Brack <f...@ltec.ch>"); > +MODULE_DESCRIPTION("OTM3225A TFT LCD driver"); > +MODULE_VERSION("1.0.0"); > +MODULE_LICENSE("GPL v2"); > -- > 2.7.4

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-21 Thread Jingoo Han
On Thursday, December 21, 2017 9:21 PM, Jaehoon Chung wrote: > On 12/22/2017 01:12 AM, Jingoo Han wrote: > > On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote: > >> > >> Exynos5433 has the PCIe for WiFi. > >> Added the codes relevant to PCIe for

Re: [PATCH v6 06/18] PCI: designware-ep: Add generic function for raising MSI irq

2017-12-21 Thread Jingoo Han
gt; > void dw_pcie_ep_exit(struct dw_pcie_ep *ep); > > +int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 interrupt_num); > > void dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar); > > #else > > static inline void dw_pcie_ep_linkup(struct dw_pcie_ep *ep) > > @@ -353,6 +356,12 @@ static inline void dw_pcie_ep_exit(struct > dw_pcie_ep *ep) > > { > > } > > > > +static inline int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, > > + u8 interrupt_num) > > +{ > > + return 0; > > +} > > + > > static inline void dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum > pci_barno bar) > > { > > } > > > > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han

Re: [PATCH v6 04/18] PCI: designware-ep: Pre-allocate memory for MSI in dw_pcie_ep_init

2017-12-21 Thread Jingoo Han
, ep); > > dw_pcie_setup(pci); > > diff --git a/drivers/pci/dwc/pcie-designware.h b/drivers/pci/dwc/pcie- > designware.h > > index 9aaf0cd04dd6..5a1da459eda5 100644 > > --- a/drivers/pci/dwc/pcie-designware.h > > +++ b/drivers/pci/dwc/pcie-designware.h > > @@ -198,6 +198,8 @@ s

Re: [PATCH v6 03/18] PCI: designware-ep: Read-only registers need DBI_RO_WR_EN to be writable

2017-12-21 Thread Jingoo Han
8 encode_int) > > val = dw_pcie_readw_dbi(pci, MSI_MESSAGE_CONTROL); > > val &= ~MSI_CAP_MMC_MASK; > > val |= (encode_int << MSI_CAP_MMC_SHIFT) & MSI_CAP_MMC_MASK; > > + dw_pcie_dbi_ro_wr_en(pci); > > dw_pcie_writew_dbi(pci, MSI_MESSAGE_CONTROL, val); > > + dw_pcie_dbi_ro_wr_dis(pci); > > > > return 0; > > } > > > > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han

Re: [PATCH v6 02/18] PCI: designware-ep: dw_pcie_ep_set_msi() should only set MMC bits

2017-12-21 Thread Jingoo Han
; > +++ b/drivers/pci/dwc/pcie-designware.h > > @@ -101,6 +101,7 @@ > > > > #define MSI_MESSAGE_CONTROL0x52 > > #define MSI_CAP_MMC_SHIFT 1 > > +#define MSI_CAP_MMC_MASK (7 << MSI_CAP_MMC_SHIFT) > > #define MSI_CAP_MME_SHIFT 4 > > #define MSI_CAP_MME_MASK (7 << MSI_CAP_MME_SHIFT) > > #define MSI_MESSAGE_ADDR_L32 0x54 > > > > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han

Re: [PATCH v6 01/18] PCI: dwc: Use the DMA-API to get the MSI address

2017-12-21 Thread Jingoo Han
_DESIGNWARE_H > > #define _PCIE_DESIGNWARE_H > > > > +#include > > #include > > #include > > #include > > @@ -168,7 +169,7 @@ struct pcie_port { > > const struct dw_pcie_host_ops *ops; > > int msi_irq; > > struct irq_domain *irq_domain; > > - unsigned long msi_data; > > + dma_addr_t msi_data; > > DECLARE_BITMAP(msi_irq_in_use, MAX_MSI_IRQS); > > }; > > > > > > Makes total sense! Thanks. > > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han

Re: [PATCH] PCI: dwc: designware: don't sleep in atomic context

2017-12-21 Thread Jingoo Han
Signed-off-by: Pankaj Dubey <pankaj.du...@samsung.com> Sorry for my late response. Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > drivers/pci/dwc/pcie-designware.c | 8 > drivers/pci/dwc/pcie-designware.h | 3 +-- > 2 files changed, 5 insert

Re: [PATCH] PCI: designware: move dw_pcie_iatu_unroll_enabled to pcie-designware.c

2017-12-21 Thread Jingoo Han
designware.c so that both pcie-designware-host.c and > pcie-designware-ep.c can use it. > > Signed-off-by: Pankaj Dubey <pankaj.du...@samsung.com> Sorry for my late response. Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > drivers/pci/dwc/pcie-

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-21 Thread Jingoo Han
On Thursday, December 21, 2017 11:13 AM, Jingoo Han wrote: > On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote: > > > > Exynos5433 has the PCIe for WiFi. > > Added the codes relevant to PCIe for supporting the exynos5433. > > Also changed the binding documen

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-21 Thread Jingoo Han
> @@ -513,9 +601,16 @@ static void exynos_pcie_msi_init(struct exynos_pcie > *ep) > exynos_pcie_writel(ep->mem_res->elbi_base, val, PCIE_IRQ_EN_LEVEL); > } > > -static void exynos_pcie_enable_interrupts(struct exynos_pcie *ep) > +static void exynos_pcie_enable

Re: [PATCH] PCI: dwc: Use {upper,lower}_32_bits() macros for clarity

2017-11-29 Thread Jingoo Han
On Tuesday, November 28, 2017 7:54 PM, Stephen Boyd wrote: > > We have macros for getting the upper or lower 32 bits of a > number. Use them here to shave a couple lines off the code. > > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> Acked-by: Jingoo Han <jin

Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot()

2017-11-27 Thread Jingoo Han
by: Daniel Thompson <daniel.thomp...@linaro.org> > Signed-off-by: Sinan Kaya <ok...@codeaurora.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > drivers/video/backlight/apple_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()

2017-11-27 Thread Jingoo Han
perator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Jing

Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe()

2017-11-27 Thread Jingoo Han
ted by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) &g

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

2017-11-17 Thread Jingoo Han
lighting > > solutions this is the preferred subsystem for Android. The Android OS > manages the led brightness based on ALS values and in > > turn calls into the driver to control the brightness register through > the vendor provided lighting HAL. > > > > Well

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

2017-11-16 Thread Jingoo Han
htness register through the > vendor provided lighting HAL. > > I am going to look at the backlight source to figure out how to get the > same functionality using the backlight subsystem. > Otherwise I will plug in this driver to the backlight subsystem through > the notifier. I also d

Re: [PATCH] backlight: ili922x: remove redundant variable len

2017-11-05 Thread Jingoo Han
76:2: warning: Value stored to 'len' > is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Thank you for sending the patch. It looks good. Best regards, Jingoo Han > --- > drivers/video/backlight/

Re: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata

2017-10-17 Thread Jingoo Han
e struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Jingoo

Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata

2017-10-17 Thread Jingoo Han
e struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Jingoo

Re: [PATCH 01/10] PCI: dwc: use DMA-API for allocating MSI data

2017-10-13 Thread Jingoo Han
> + msg.address_hi = upper_32_bits(msi_target); > > if (pp->ops->get_msi_data) > msg.data = pp->ops->get_msi_data(pp, pos); > diff --git a/drivers/pci/dwc/pcie-designware.h b/drivers/pci/dwc/pcie- > designware.h > index e5d9d77b778e..54735

Re: [PATCH 01/10] PCI: dwc: use DMA-API for allocating MSI data

2017-10-13 Thread Jingoo Han
on. However, did you test your patch? In my opinion, your company does not handle DWC PCIe controller, right? If so, you need to get tested-by from other people. Best regards, Jingoo Han > > Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> > --- &

Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check

2017-10-09 Thread Jingoo Han
On Sunday, October 8, 2017 5:57 PM, Christos Gkekas wrote: > > Variable val holds the default brightness and is unsigned, therefore > checking whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas <chris.ge...@gmail.com> It looks good. Acked-by

Re: [RFC 0/2] backlight: pwm_bl: support linear brightness to human eye

2017-09-05 Thread Jingoo Han
at I'm saying is that if we can > programmatically derive brightness curves then the number of steps is > not really a property of the hardware and doesn't belong in devicetree. Yep, I agree with Daniel's opinion. I cannot find the reason this feature can be added to the device tree. In my opinion, this feature can be handled by upper user level layer, not backlight framework level. However, we can discuss this topic to find how to handle it. Best regards, Jingoo Han > > > Daniel.

Re: [PATCH v4 3/5] pwm-backlight: add support for PWM delays proprieties.

2017-07-26 Thread Jingoo Han
clear the PWM signal and disable the backlight. Add support for > > the new post-pwm-on-delay-ms and pwm-off-delay-ms proprieties to meet > > the timings. > > > > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > > Acked-by: Daniel Thompson &l

Re: [PATCH v4 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.

2017-07-25 Thread Jingoo Han
101EAN0 (Auo) > >- B101AW03 (Auo) > >- LTN101NT05 (Samsung) > >- CLAA101WA01A (Chunghwa) > > > > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > > Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Acked-by: J

Re: [PATCH v2] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not

2017-07-18 Thread Jingoo Han
com> > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > Since v1: > - Add Joao's Ack > - Fix typo in commit msg, thank Jingoo > > drivers/pci/dwc/pcie-designware.c | 2 +- > 1

Re: [PATCH] PCI: dwc: designware: make dw_pcie_prog_*_atu_unroll() static

2017-07-17 Thread Jingoo Han
_prog_inbound_atu_unroll(struct dw_pcie *pci, int index, int > bar, > > +static int dw_pcie_prog_inbound_atu_unroll(struct dw_pcie *pci, int > index, int bar, > > u64 cpu_addr, enum dw_pcie_as_type as_type) > > { > > int type; > > -- > > 2.11.0 > > > > That indeed escaped in the refactoring :) Thanks! > > Acked-by: Joao Pinto <jpi...@synopsys.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han

Re: [PATCH] PCI: dwc: designware: test PCIE_ATU_ENABLE bit to check enabled or not

2017-07-17 Thread Jingoo Han
ould > > test the enable it. To Jisheng Zhang, typo s/it/bit "test the enable it." ---> "test the enable bit." Please fix this typo, and send it again. Type is confusing. Best regards, Jingoo Han > > > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> &g

Re: [PATCH 1/3] PCI: dwc: Handle host_init failures

2017-07-17 Thread Jingoo Han
dwc/pcie-spear13xx.c | 4 +++- > > 13 files changed, 47 insertions(+), 18 deletions(-) > > [.] > > A step in the right direction :). In the future we should add host init > validation in the specific SoC drivers, like Layerscape and Qcom have, to > assure &

Re: [PATCH] backlight: pwm_bl: make of_device_ids const

2017-06-20 Thread Jingoo Han
n-const structs as const. > > > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > > Acked-by: Daniel Thompson <daniel.thomp...@linaro.org> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > > > > --- > > drivers/vi

Re: [PATCH] PCI: dwc: Constify dw_pcie_host_ops structures

2017-06-05 Thread Jingoo Han
On Monday, June 5, 2017 4:54 AM, Jisheng Zhang wrote: > > The dw_pcie_host_ops structures are never modified. Constify these > structures such that these can be write-protected. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Acked-by: Jingoo Han <jingooh...@

Re: [PATCH v9 3/4] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-31 Thread Jingoo Han
te and Suspend/Resume), hotplug > and MSI feature are not supported currently. > > Cc: Guodong Xu <guodong...@linaro.org> > Signed-off-by: Xiaowei Song <songxiao...@hisilicon.com> Reviewed-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- >

Re: [PATCH v8 3/4] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-26 Thread Jingoo Han
te and Suspend/Resume), hotplug > and MSI feature are not supported currently. > > Cc: Guodong Xu <guodong...@linaro.org> > Signed-off-by: Xiaowei Song <songxiao...@hisilicon.com> It looks good. Reviewed-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jing

Re: [PATCH v6 0/4] DT and Driver review comments fix

2017-05-24 Thread Jingoo Han
ong, I think that you need to receive 'tested-by' from other people such as colleagues or other developers. Or, would you share the result of 'lspci' for your HiSilicon Kirin PCIe Host controller? That will help other maintainers to review your patches. Best regards, Jingoo Han >

Re: [PATCH v6 3/4] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-24 Thread Jingoo Han
lk is not stable\n"); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static void kirin_pcie_oe_enable(struct kirin_pcie *kirin_pcie) > +{ > + u32 val; > + > + regmap_read(kirin_pcie->sysctrl, SCTRL_PCIE_OE_OFFSET, ); > +

Re: [PATCH v4 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-18 Thread Jingoo Han
.rd_own_conf = kirin_pcie_rd_own_conf, > + .wr_own_conf = kirin_pcie_wr_own_conf, > + .host_init = kirin_pcie_host_init, > +}; > + > +static int __init kirin_add_pcie_port(struct dw_pcie *pci, > + struct platform_device *pdev) >

Re: [PATCH 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

2017-05-18 Thread Jingoo Han
; + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "pcie-designware.h" Please re-order these header files in alphabetical order for 'readability'. Best regards, Jingoo Han []

Re: [PATCH v10 1/3] DT add arctic to vendor prefix for ArcticSand

2017-05-09 Thread Jingoo Han
On Tuesday, May 9, 2017 8:50 AM, Olimpiu Dejeu wrote: > > dt-bindings: vendor-prefixes: add arctic to vendor prefix > > Acked-by: Rob Herring <r...@kernel.org> > Signed-off-by: Olimpiu Dejeu <olim...@arcticsand.com> I cannot find any reason to reject this patc

Re: [PATCH v8 1/3] backlight arcxcnn add arc to vendor prefix

2017-04-27 Thread Jingoo Han
On Thursday, April 27, 2017 8:37 AM, Geert Uytterhoeven wrote: > On Tue, Apr 25, 2017 at 6:36 PM, Jingoo Han <jingooh...@gmail.com> wrote: > > On Monday, April 24, 2017 1:56 PM, Olimpiu Dejeu wrote: > >> > >> On Mon, April 24, 2017 11:10 AM, Rob Herring < r...@k

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-26 Thread Jingoo Han
based PCIe controller. In my opinion, other Designware-based PCIe controller will work properly. To Dongdong Liu, Khuong Dinh, and other people, If possible, can you check the output of 'lspci -v'? If you find something different, please share it with us. Good luck. Best regards, Jingoo Han >

Re: [PATCH v8 1/3] backlight arcxcnn add arc to vendor prefix

2017-04-25 Thread Jingoo Han
nion, one of the purposes of DT is to describe hardware stuffs. So, please use more detailed words. > > >BTW, some reason your patches are not going to the DT list. > > > I'm emailing to devicet...@vger.kernel.org, I think this is the correct > list. Please advise. DT is

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-25 Thread Jingoo Han
heir platforms. Good! I really want to know the result of these patches on ARM serves. Please share it with us. Good luck. Best regards, Jingoo Han > > Jon.

Re: [PATCH v4 14/21] PCI: designware: update PCI config space remap function

2017-04-21 Thread Jingoo Han
ect > memory mappings for PCI configuration space are used. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Jingoo Han <jingooh...@gmail.com> Acked-by: Jingoo Han <jingooh...@gmail.com> B

Re: [PATCH] PCI: dwc/host: Mark PCIe/PCI (MSI) cascade ISR as IRQF_NO_THREAD

2017-04-20 Thread Jingoo Han
issue in pcie-designware-plat driver, then searched the code, I think > we should fix pcie-qcom and vmd as well. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> For pcie-designware-plat.c, Acked-by: Jingoo Han <jingooh...@gmail.com> Thank you. Best regards, Jingoo

Re: [PATCH] pci: dwc: hisi needs PCI_HOST_COMMON

2017-03-21 Thread Jingoo Han
fined reference to `pci_ecam_map_bus' > drivers/pci/dwc/built-in.o: In function `hisi_pcie_almost_ecam_probe': > pcie-hisi.c:(.text+0x88b4): undefined reference to `pci_host_common_probe' > > This adds an explicit 'select', as the other users have. > > Signed-off-by: Arnd Bergmann <

Re: [PATCH 01/10] PCI: dwc: designware: Move the register defines to designware header file

2017-02-16 Thread Jingoo Han
; specific file. > > While at that also fix a checkpatch warning. > > Reviewed-By: Joao Pinto <jpi...@synopsys.com> > Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han &

Re: [PATCH v3] PCI: exynos: refactor exynos pcie driver

2017-02-10 Thread Jingoo Han
gned-off-by: Niyas Ahmed S T <niyas.ah...@samsung.com> > > Signed-off-by: Pankaj Dubey <pankaj.du...@samsung.com> > > Acked-by: Krzysztof Kozlowski <k...@kernel.org> > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > > Reviewed-b

Re: [PATCH V3 0/5] PCI: exynos: cleans the minor things

2017-01-31 Thread Jingoo Han
exynos: Use the bitops API to operate the bit shifting > > PCI: exynos: remove the duplicated codes > > > > drivers/pci/host/pci-exynos.c | 392 +++ > --- > > Waiting for ack from Jingoom, per MAINTAINERS: > > Jingoo Han <jingooh...@gmail.com>

Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-01-04 Thread Jingoo Han
their own PCIe device drivers. > > Currently, there is an exynos5440 case to support the pcie. > So this driver is based on Exynos5440 PCIe. > In future, will support the Other exynos SoCs likes exynos5433, exynos7. > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.co

Re: [PATCH v3] PCI: add a new directory for designware core

2017-01-04 Thread Jingoo Han
ned-off-by: Kishon Vijay Abraham I <kis...@ti.com> Acked-by: Jingoo Han <jingooh...@gmail.com> However, I have two suggestion as below. 1. Please add dwc pci related people as possible. They should be noticed. So, they will prepare this changes when they will receive future

Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework

2017-01-04 Thread Jingoo Han
ed" message. > But it's still working fine with it. > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> It looks good! Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > Changelog on V2: > - This patch is split from previous P

Re: [PATCH v2] PCI: add a new directory for designware core

2017-01-04 Thread Jingoo Han
ned-off-by: Kishon Vijay Abraham I <kis...@ti.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > Changes from v1: > *) instead of renaming *host* directory to *controller* directory, >move all the dwc drivers to dwc/ directory. > Next S

Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie

2017-01-04 Thread Jingoo Han
t; > interrupts = , > > , > > ; > > @@ -326,9 +336,9 @@ > > #address-cells = <3>; > > #size-cells = <2>; > > device_type = "pci"; > > - ranges = <0x0800 0 0x6000 0x6000 0 0x1000 > /* configuration space */ > > - 0x8100 0 0 0x60001000 0 0x0001 /* > downstream I/O */ > > - 0x8200 0 0x60011000 0x60011000 0 0x1ffef000>; /* > non-prefetchable memory */ > > + phys = <_phy1>; > > + ranges = <0x8100 0 0 0x60001000 0 0x0001 > > + 0x8200 0 0x60011000 0x60011000 0 0x1ffef000>; > > I think the comments were useful. You can leave them. I think so, too. Please leave the comments Best regards, Jingoo Han > > This looks like depending on the changes in the driver, so I will need a > tag or stable branch from PCIe maintainers. > > Best regards, > Krzysztof

Re: [PATCH] backlight: da9052: Fix module autoload

2017-01-02 Thread Jingoo Han
backlight > > After this patch: > > $ modinfo drivers/video/backlight/da9052_bl.ko | grep alias > alias: platform:da9052-wled3 > alias: platform:da9052-wled2 > alias: platform:da9052-wled1 > > Signed-off-by: Javier Martinez Canillas <jav...@osg.sam

Re: [PATCH V2 2/2] backlight arcxcnn devicetree bindings for ArcticSand

2016-12-27 Thread Jingoo Han
On Friday, December 9, 2016 10:50 AM, Olimpiu Dejeu wrote: > Please add the commit message here. Best regards, Jingoo Han > Acked-by: Rob Herring <r...@kernel.org> > Signed-off-by: Olimpiu Dejeu <olim...@arcticsand.com> > --- > > v1 => v2: > - Version

Re: [PATCH v2 1/2] backlight arcxcnn add support for ArcticSand devices

2016-12-27 Thread Jingoo Han
t;failed to register backlight. err: %d\n", ret); > + return ret; > + } > + > + ret = sysfs_create_group(>dev->kobj, _attr_group); > + if (ret) { > + dev_err(lp->dev, "failed to register sysfs. err: %d\n", ret); > +

Re: [PATCH v4 3/5] backlight: lm3533: Support initialization from Device Tree

2016-12-27 Thread Jingoo Han
; Tree. > > > > Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > > Acked-by: Pavel Machek <pa...@ucw.cz> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo

Re: [PATCH] PCI: exynos: refactor exynos pcie driver

2016-12-26 Thread Jingoo Han
eneric framework is mandatory, as other PCIe host driver did. I think that we should use PHY generic framework for new SoCs. > > One more thing..Does anyone know what the usage of block base is? > Can i use that register as "syscon"? 'Block' is very specific registers for 544

Re: [PATCH 0/4] PCI: exynos: cleans the minor things

2016-12-26 Thread Jingoo Han
; > > > drivers/pci/host/pci-exynos.c | 260 +++ > --- > > 1 file changed, 116 insertions(+), 144 deletions(-) > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R Institute Poland > Samsung Electronics

Re: [PATCH] PCI: exynos: refactor exynos pcie driver

2016-12-23 Thread Jingoo Han
llow us to support the > differences in resources in different Exynos SoC. Good. I have no objection. Best regards, Jingoo Han > > No functional change intended. > > Signed-off-by: Niyas Ahmed S T <niyas.ah...@samsung.com> > Signed-off-by: Pankaj Dubey <pank

Re: [PATCH] video: backlight: pwm_bl: Initialize fb_bl_on[x] and use_count during pwm_backlight_probe()

2016-10-25 Thread Jingoo Han
f patch as below. The commit a55944ca82d2 ("backlight: update bd state & fb_blank properties when necessary ") has posted some extra. Best regards, Jingoo Han > > > > Please add the subject of the patch, in order to let people know > > which patch you mention exactly.

Re: [PATCH] video: backlight: pwm_bl: Initialize fb_bl_on[x] and use_count during pwm_backlight_probe()

2016-10-23 Thread Jingoo Han
On Saturday, October 22, 2016, Lukasz Majewski wrote: > > The commit: a55944ca82d287ca099ca90413af857af9086773 has posed some extra Please add the subject of the patch, in order to let people know which patch you mention exactly. Please loot at other commits that fixed bugs or behavior of other

Re: [PATCH] Decouple CFG and IO in Designware PCIe Driver

2016-06-28 Thread Jingoo Han
. > So assign one to memory and share other for CFG0 and CFG1. > > Please let me know your opnion. I agree with your opinion. The number of viewports should be passed through DT, because this number is designated by hardware configuration at the level of design. Anyway, I think that most So

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Jingoo Han
On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: > > Hi Jingoo > > On 13 April 2016 06:52, Jingoo Han wrote: > > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > > > > > Hi Bjorn > > > > > > [...] > > >

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-12 Thread Jingoo Han
s hisi driver to call the moved > > > code. > > > > > > Do you see anything wrong with it? > > > > Only that it makes the structure more complicated and we haven't > > identified a corresponding benefit yet. > > Finally I have checked that assigning .hos

Re: [PATCH v12 16/18] drm: bridge: analogix/dp: expand the wait time for looking AUX CH reply flag

2015-12-25 Thread Jingoo Han
On Thursday, December 24, 2015 10:23 AM, Yakir Yang wrote: > > Hi Jingoo, > > Okay, fine, I would drop this patch, until I found the the root cause. OK, I see. Best regards, Jingoo Han > > - Yakir > > On 12/23/2015 11:10 PM, Jingoo Han wrote: > > On Wednes

Re: [PATCH v12 16/18] drm: bridge: analogix/dp: expand the wait time for looking AUX CH reply flag

2015-12-23 Thread Jingoo Han
wait_time_aux = 10; > usleep_range(10, 11); If there is NO new wait time value from DT file, the default value '10' is used for sleep. But, if there is new wait time value from DT file, new wait time value can be used for sleep. usleep_range(dp->wait_time_aux

Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply

2015-12-23 Thread Jingoo Han
On Wednesday, December 23, 2015 3:01 PM, Yakir Yang wrote: > > Hi Jingoo, > > On 12/23/2015 12:24 PM, Yakir Yang wrote: > > Hi Jingoo, > > > > On 12/22/2015 08:26 PM, Jingoo Han wrote: > >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: &g

Re: [PATCH v11 02/19] drm: bridge: analogix/dp: fix some obvious code style

2015-12-22 Thread Jingoo Han
zysztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in

Re: [PATCH v11 09/19] phy: Add driver for rockchip Display Port PHY

2015-12-22 Thread Jingoo Han
+ * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License. > + */ > + > +#include > +#include > +#include > +#i

Re: [PATCH v4 1/5] PCI: designware: add memory barrier after enabling region

2015-12-22 Thread Jingoo Han
s driver. Most of the host controller > > has 4 or more viewpoints, and it is very easy to handle for them. But > > there are few which has only two viewpoints. Do not know how to solve > > it, so that it works for all. > > > > The default outbound iATU number is

Re: [PATCH v11 06/19] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver

2015-12-22 Thread Jingoo Han
ztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Jingoo Han < jingooh...@gmail.com > Best regards, Jingoo Han > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Chang

  1   2   3   4   5   6   7   8   9   10   >