Re: [PATCH] i2c: remove casting dma_alloc

2019-07-03 Thread Jochen Friedrich
From: Vasyl Generated by: alloc_cast.cocci Signed-off-by: Vasyl Acked-by: Jochen Friedrich --- drivers/i2c/busses/i2c-cpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index 187900594e3d

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-25 Thread Jochen Friedrich
Hi Olof, > And even if you DO decide to go that route, guess what? You need a > translation table just as with (3) anyway! True. 3. use a glue layer with a translation map. >>> In my opinion this is an OK solution since the same information has to >>> be added somewhere already anyway --

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-25 Thread Jochen Friedrich
Hi Olof, And even if you DO decide to go that route, guess what? You need a translation table just as with (3) anyway! True. 3. use a glue layer with a translation map. In my opinion this is an OK solution since the same information has to be added somewhere already anyway -- eiither to

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-24 Thread Jochen Friedrich
Hi Olof, >> 2. record the I2c name in the dts tree, either as seperate tag (like >> linux,i2c-name="") >>or as additional compatible entry (like compatible="...", >> "linux,"). > > I have to say no on this one. The device tree is not supposed to know > about how linux uses devices, there

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-24 Thread Jochen Friedrich
Hi Olof, 2. record the I2c name in the dts tree, either as seperate tag (like linux,i2c-name=i2c-name) or as additional compatible entry (like compatible=..., linux,i2c-name). I have to say no on this one. The device tree is not supposed to know about how linux uses devices, there

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-22 Thread Jochen Friedrich
Hi Jean, >> +/* >> + * Wait for patch from Jon Smirl >> + * #include "powerpc-common.h" >> + */ > > It doesn't make sense to merge this comment upstream. I know you don't like the patch from Jon Smirl and you also explained your reasons. Fortunately, I2c no longer uses numeric device IDs but

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-22 Thread Jochen Friedrich
Hi Jean, +/* + * Wait for patch from Jon Smirl + * #include powerpc-common.h + */ It doesn't make sense to merge this comment upstream. I know you don't like the patch from Jon Smirl and you also explained your reasons. Fortunately, I2c no longer uses numeric device IDs but names. So

[PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-31 Thread Jochen Friedrich
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-cpm.c | 759 ++ 3 files changed, 770 insertions(+), 0 deletions(-) create mode 100644 driver

[PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-31 Thread Jochen Friedrich
-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-cpm.c | 759 ++ 3 files changed, 770 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/busses/i2c

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Jochen Friedrich
Hi Bryan, >> + >> + /* register new adapter to i2c module... */ >> + >> + result = i2c_add_adapter(>adap); > > As I was pointed before, please use the new style i2c driver interface: >

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Jochen Friedrich
Hi Bryan, + + /* register new adapter to i2c module... */ + + result = i2c_add_adapter(cpm-adap); As I was pointed before, please use the new style i2c driver interface:

[PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-25 Thread Jochen Friedrich
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 + arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/bu

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
Hi Frans, > Jochen Friedrich wrote: >> +++ b/drivers/net/fec.c >> @@ -23,6 +23,9 @@ >> * >> * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED]) >> * Copyright (c) 2004-2006 Macq Electronique SA. >> + * >> + * This driver is

[PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- drivers/net/fec.c | 136 +--- 1 files changed, 3 insertions(+), 133 deletions(-) diff --git a/d

[PATCH for-2.6.25] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |1 + arch/p

Re: [PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Jochen Friedrich
Hi Kumar, >> drivers/net/fec.c |8 >> drivers/net/fec.h |2 +- > > asm-m68knommu/commproc.h ?? these are only built on coldfire. Yes. Here I just removed dead code (commented out using #ifdef on coldfire). Apparently the

Re: [PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Jochen Friedrich
Hi Kumar, drivers/net/fec.c |8 drivers/net/fec.h |2 +- asm-m68knommu/commproc.h ?? these are only built on coldfire. Yes. Here I just removed dead code (commented out using #ifdef on coldfire). Apparently the driver

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
Hi Frans, Jochen Friedrich wrote: +++ b/drivers/net/fec.c @@ -23,6 +23,9 @@ * * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED]) * Copyright (c) 2004-2006 Macq Electronique SA. + * + * This driver is now only used on ColdFire processors. Remove conditional

[PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-25 Thread Jochen Friedrich
fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/net/fec.c | 136 +--- 1 files changed, 3 insertions(+), 133 deletions(-) diff --git a/drivers

[PATCH for-2.6.25] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |1 + arch/powerpc/platforms

[PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-25 Thread Jochen Friedrich
-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 + arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/busses/Kconfig

[PATCHv3 7/7] [POWERPC] Move definition of buffer descriptor to cpm.h

2008-01-24 Thread Jochen Friedrich
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions from the cpm dependent include file to common cpm.h Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- include/asm-powerpc/cpm.h | 73 include/asm-powerpc/cpm1.h

[PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-24 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |1 + arch/p

[PATCHv3 5/7] [POWERPC] Get rid of conditional includes of board specific setup

2008-01-24 Thread Jochen Friedrich
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid of the arch dependent includes in mpc8xx.h. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/m8xx_setup.c |3 +-- arch/powerpc/platforms/8xx/mpc885ads_setup.c |1 + inclu

[PATCHv3 4/7] [POWERPC] Remove sysdev/commproc.h

2008-01-24 Thread Jochen Friedrich
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now unneeded sysdev/commproc.h. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |2 +- arch/p

[PATCHv3 3/7] [POWERPC] Remove unneeded and misspelled prototype m8xx_calibrate_decr

2008-01-24 Thread Jochen Friedrich
m8xx_calibrate_decr seems to be a misspelled prototype for mpc8xx_calibrate_decr. As it's not needed anyways, just remove it. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/m8xx_setup.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

[PATCHv3 2/7] [POWERPC] Rename m8xx_pic_init to mpc8xx_pics_init

2008-01-24 Thread Jochen Friedrich
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the function to use the same name space as the rest of the mpc8xx specific funtions and to be more meaningful. m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc tree. Remove it. Signed-off-by: Jochen

[PATCHv3 0/7] [POWERPC] 8xx cleanups

2008-01-24 Thread Jochen Friedrich
Hi, this is a series against paulus for-2.6.25 tree to clean up various 8xx related stuff. The series can be pulled from git://git.bocc.de/dbox2.git cleanup. Old patches 2+4 have been merged into Patch 2. Patch 4 has been modified to move the prototypes into a new platforms/8xx/mpc8xx.h. Patch

[PATCHv3 1/7] [POWERPC] Remove unused m8xx_cpm_hostalloc/free/dump()

2008-01-24 Thread Jochen Friedrich
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only defined in the headers. Remove this dead code. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/commproc.c

[PATCHv3 0/7] [POWERPC] 8xx cleanups

2008-01-24 Thread Jochen Friedrich
Hi, this is a series against paulus for-2.6.25 tree to clean up various 8xx related stuff. The series can be pulled from git://git.bocc.de/dbox2.git cleanup. Old patches 2+4 have been merged into Patch 2. Patch 4 has been modified to move the prototypes into a new platforms/8xx/mpc8xx.h. Patch

[PATCHv3 1/7] [POWERPC] Remove unused m8xx_cpm_hostalloc/free/dump()

2008-01-24 Thread Jochen Friedrich
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only defined in the headers. Remove this dead code. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/sysdev/commproc.c | 37

[PATCHv3 2/7] [POWERPC] Rename m8xx_pic_init to mpc8xx_pics_init

2008-01-24 Thread Jochen Friedrich
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the function to use the same name space as the rest of the mpc8xx specific funtions and to be more meaningful. m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc tree. Remove it. Signed-off-by: Jochen

[PATCHv3 3/7] [POWERPC] Remove unneeded and misspelled prototype m8xx_calibrate_decr

2008-01-24 Thread Jochen Friedrich
m8xx_calibrate_decr seems to be a misspelled prototype for mpc8xx_calibrate_decr. As it's not needed anyways, just remove it. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/m8xx_setup.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch

[PATCHv3 5/7] [POWERPC] Get rid of conditional includes of board specific setup

2008-01-24 Thread Jochen Friedrich
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid of the arch dependent includes in mpc8xx.h. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/m8xx_setup.c |3 +-- arch/powerpc/platforms/8xx/mpc885ads_setup.c |1 + include/asm

[PATCHv3 4/7] [POWERPC] Remove sysdev/commproc.h

2008-01-24 Thread Jochen Friedrich
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now unneeded sysdev/commproc.h. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |2 +- arch/powerpc/platforms

[PATCHv3 6/7] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-24 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |1 + arch/powerpc/platforms

[PATCHv3 7/7] [POWERPC] Move definition of buffer descriptor to cpm.h

2008-01-24 Thread Jochen Friedrich
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions from the cpm dependent include file to common cpm.h Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- include/asm-powerpc/cpm.h | 73 include/asm-powerpc/cpm1.h | 65

Re: [PATCHv2 5/8] [POWERPC] Remove sysdev/commproc.h

2008-01-23 Thread Jochen Friedrich
Hi Kumar, Do we really need the prototypes you moved into asm/mpc8xx.h here? can they just live in platforms/8xx/8xx.h or something like that? At least drivers/pcmcia/m8xx_pcmcia.c uses the symbol m8xx_pcmcia_ops which is conditionally defined in platforms/8xx/m8xx_setup.c. However, this

[PATCHv2 8/8] [POWERPC] Move definition of buffer descriptor to cpm.h

2008-01-23 Thread Jochen Friedrich
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions from the cpm dependent include file to common cpm.h Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- include/asm-powerpc/cpm.h | 73 include/asm-powerpc/cpm1.h

[PATCHv2 7/8] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-23 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |2 +- arch/p

[PATCHv2 5/8] [POWERPC] Remove sysdev/commproc.h

2008-01-23 Thread Jochen Friedrich
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now unneeded sysdev/commproc.h. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |3 +-- arch/p

[PATCHv2 6/8] [POWERPC] Get rid of conditional includes of board specific setup

2008-01-23 Thread Jochen Friedrich
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid of the arch dependent includes in mpc8xx.h. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/mpc885ads_setup.c |2 + include/asm-powerpc/mpc8xx.h

[PATCHv2 2/8] [POWERPC] Rename m8xx_pic_init to mpc8xx_pics_init

2008-01-23 Thread Jochen Friedrich
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the function to use the same name space as the rest of the mpc8xx specific funtions and to be more meaningful. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/ep88xc.c |2 +-

[PATCHv2 3/8] [POWERPC] Remove unneeded and misspelled prototype m8xx_calibrate_decr

2008-01-23 Thread Jochen Friedrich
m8xx_calibrate_decr seems to be a misspelled prototype for mpc8xx_calibrate_decr. As it's not needed anyways, just remove it. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/8xx/m8xx_setup.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

[PATCHv2 4/8] [POWERPC] Remove declaration of m8xx_pic_init.

2008-01-23 Thread Jochen Friedrich
m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc tree. Remove it. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/ppc/syslib/ppc8xx_pic.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/ppc/syslib/ppc8xx_pic.h b/arch/ppc/

[PATCHv2 1/8] [POWERPC] Remove unused m8xx_cpm_hostalloc/free/dump()

2008-01-23 Thread Jochen Friedrich
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only defined in the headers. Remove this dead code. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/commproc.c

[PATCHv2 0/8] [POWERPC] 8xx cleanups

2008-01-23 Thread Jochen Friedrich
Hi, this is a series against paulus for-2.6.25 tree to clean up various 8xx related stuff. The series can be pulled from git://git.bocc.de/dbox2.git cleanup. Patch 6 has been modified to remove the #ifdefs as suggested by Arndt Bergmann. Patch 8 is a new one. [POWERPC] Remove unused

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jochen Friedrich
Hi Jean, Do you have an updated patch addressing Stephen's comment? Note: you'd rather send updates of this patch to the i2c list rather than LKML. I'm currently looking at that last patches from Jon and try to make this driver fit in there (+ the class override stuff). Note: will do. I

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jochen Friedrich
Hi Jean, Do you have an updated patch addressing Stephen's comment? Note: you'd rather send updates of this patch to the i2c list rather than LKML. I'm currently looking at that last patches from Jon and try to make this driver fit in there (+ the class override stuff). Note: will do. I

[PATCHv2 0/8] [POWERPC] 8xx cleanups

2008-01-23 Thread Jochen Friedrich
Hi, this is a series against paulus for-2.6.25 tree to clean up various 8xx related stuff. The series can be pulled from git://git.bocc.de/dbox2.git cleanup. Patch 6 has been modified to remove the #ifdefs as suggested by Arndt Bergmann. Patch 8 is a new one. [POWERPC] Remove unused

[PATCHv2 1/8] [POWERPC] Remove unused m8xx_cpm_hostalloc/free/dump()

2008-01-23 Thread Jochen Friedrich
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only defined in the headers. Remove this dead code. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/sysdev/commproc.c | 37

[PATCHv2 3/8] [POWERPC] Remove unneeded and misspelled prototype m8xx_calibrate_decr

2008-01-23 Thread Jochen Friedrich
m8xx_calibrate_decr seems to be a misspelled prototype for mpc8xx_calibrate_decr. As it's not needed anyways, just remove it. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/m8xx_setup.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCHv2 4/8] [POWERPC] Remove declaration of m8xx_pic_init.

2008-01-23 Thread Jochen Friedrich
m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc tree. Remove it. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/ppc/syslib/ppc8xx_pic.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/ppc/syslib/ppc8xx_pic.h b/arch/ppc/syslib

[PATCHv2 2/8] [POWERPC] Rename m8xx_pic_init to mpc8xx_pics_init

2008-01-23 Thread Jochen Friedrich
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the function to use the same name space as the rest of the mpc8xx specific funtions and to be more meaningful. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |2 +- arch

[PATCHv2 5/8] [POWERPC] Remove sysdev/commproc.h

2008-01-23 Thread Jochen Friedrich
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now unneeded sysdev/commproc.h. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |3 +-- arch/powerpc

[PATCHv2 6/8] [POWERPC] Get rid of conditional includes of board specific setup

2008-01-23 Thread Jochen Friedrich
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid of the arch dependent includes in mpc8xx.h. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/mpc885ads_setup.c |2 + include/asm-powerpc/mpc8xx.h | 34

[PATCHv2 7/8] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-23 Thread Jochen Friedrich
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the includes accordingly. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/ep88xc.c |2 +- arch/powerpc

[PATCHv2 8/8] [POWERPC] Move definition of buffer descriptor to cpm.h

2008-01-23 Thread Jochen Friedrich
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions from the cpm dependent include file to common cpm.h Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- include/asm-powerpc/cpm.h | 73 include/asm-powerpc/cpm1.h | 65

[PATCH/RFCv3] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |2 +- arch/powerpc/boot/cpm-serial.c |6 +++ arch/powerpc/boot/cuboot-8xx.c |1 + arch/powerp

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Scott Wood schrieb: +void watchdog_poke(void) +{ +if (wdt) { +out_be16(>swsrr, 0x556c); +out_be16(>swsrr, 0xaa39); +} +} This should be a function pointer, to allow for other watchdog types. Thanks for the comments. Stephen Rothwell also asked if the filename

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. Thanks, Jochen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Scott Wood schrieb: +void watchdog_poke(void) +{ +if (wdt) { +out_be16(wdt-swsrr, 0x556c); +out_be16(wdt-swsrr, 0xaa39); +} +} This should be a function pointer, to allow for other watchdog types. Thanks for the comments. Stephen Rothwell also asked if the filename

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux

Re: [PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

2008-01-17 Thread Jochen Friedrich
Hi Kumar, Why are you commenting on mpc83xx_wdt with respect to pq1_wdt? Also, is this driver just for PQ1 platforms or PQ1 & PQ2? If its just pq1 we should probably call it pq1_wdt* It should be for pq1, pq2 and pq2pro. However, i only have the possibility to test this on pq1.

[PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

2008-01-17 Thread Jochen Friedrich
the watchdog in early board setup. Later, a kernel timer is used to reset the watchdog until the watchdog driver is opened from user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and mpc83xx_wdt.c (untested on this platform). Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --

[PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-17 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |2 +- arch/powerpc/boot/cpm-serial.c |6 arch/powerpc/boot/cuboot-8xx.c |1 + arch/powerp

[PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

2008-01-17 Thread Jochen Friedrich
the watchdog in early board setup. Later, a kernel timer is used to reset the watchdog until the watchdog driver is opened from user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and mpc83xx_wdt.c (untested on this platform). Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch

[PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-17 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/Makefile |2 +- arch/powerpc/boot/cpm-serial.c |6 arch/powerpc/boot/cuboot-8xx.c |1 + arch/powerpc/boot

Re: [PATCH/RFCv2] wdt: Add support for PowerQUICC watchdog

2008-01-17 Thread Jochen Friedrich
Hi Kumar, Why are you commenting on mpc83xx_wdt with respect to pq1_wdt? Also, is this driver just for PQ1 platforms or PQ1 PQ2? If its just pq1 we should probably call it pq1_wdt* It should be for pq1, pq2 and pq2pro. However, i only have the possibility to test this on pq1.

Re: [i2c] [PATCH 0/5] Version 17, series to add device tree naming to i2c

2008-01-11 Thread Jochen Friedrich
Hi Jon, >>> The following series implements standard linux module aliasing for i2c >>> modules on arch=powerpc. It then converts the mpc i2c driver from being a >>> platform driver to an open firmware one. I2C device names are picked up >>> from the device tree. Module aliasing is used to

Re: [i2c] [PATCH 0/5] Version 17, series to add device tree naming to i2c

2008-01-11 Thread Jochen Friedrich
Hi Jon, The following series implements standard linux module aliasing for i2c modules on arch=powerpc. It then converts the mpc i2c driver from being a platform driver to an open firmware one. I2C device names are picked up from the device tree. Module aliasing is used to translate from

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-03 Thread Jochen Friedrich
Hi David, +/ { + model = "unknown,dbox2"; // boot wrapper fills in correct manufacturer Probably better just to leave model out of the dts and let the bootwrapper add it. Unfortunately, dtc requires a model: $ dtc arch/powerpc/boot/dts/dbox2.dts DTC: dts->dts on file

Re: [PATCHv3] powerpc: DBox2 Board Support

2008-01-03 Thread Jochen Friedrich
Hi David, +/ { + model = unknown,dbox2; // boot wrapper fills in correct manufacturer Probably better just to leave model out of the dts and let the bootwrapper add it. Unfortunately, dtc requires a model: $ dtc arch/powerpc/boot/dts/dbox2.dts DTC: dts-dts on file

[PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-02 Thread Jochen Friedrich
driver. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 + arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/bu

[PATCHv3] powerpc: DBox2 Board Support

2007-12-28 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |4 +- arch/powerpc/boot/cuboot-dbox2.c | 280 arch/powerpc/boot/dts/dbox2.dts

[PATCH/RFC] Add support for freescale watchdog to CPM serial driver.

2007-12-28 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/cpm-serial.c | 33 - 1 files changed, 32 insertions(+), 1 deletions(-) diff --git

[PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Jochen Friedrich
the watchdog in early board setup. Later, a kernel timer is used to reset the watchdog until the watchdog driver is opened from user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and mpc83xx_wdt.c (untested on this platform). Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --

[PATCH/RFC] Add support for PowerQUICC watchdog

2007-12-28 Thread Jochen Friedrich
the watchdog in early board setup. Later, a kernel timer is used to reset the watchdog until the watchdog driver is opened from user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and mpc83xx_wdt.c (untested on this platform). Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch

[PATCH/RFC] Add support for freescale watchdog to CPM serial driver.

2007-12-28 Thread Jochen Friedrich
If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/cpm-serial.c | 33 - 1 files changed, 32 insertions(+), 1 deletions(-) diff --git a/arch

[PATCHv3] powerpc: DBox2 Board Support

2007-12-28 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/Makefile |4 +- arch/powerpc/boot/cuboot-dbox2.c | 280 arch/powerpc/boot/dts/dbox2.dts | 251

Re: [PATCHv2] powerpc: DBox2 Board Support

2007-12-26 Thread Jochen Friedrich
Hi Arnd, This patch adds device tree source, default config and setup code for DBox2 devices. ia > Cool stuff. I used to have one of these boxes myself, maybe I should get one again when it's hitting mainline. Is this already a complete port, or do you also need some device drivers or boot

Re: [PATCHv2] powerpc: DBox2 Board Support

2007-12-26 Thread Jochen Friedrich
Hi Arnd, This patch adds device tree source, default config and setup code for DBox2 devices. ia Cool stuff. I used to have one of these boxes myself, maybe I should get one again when it's hitting mainline. Is this already a complete port, or do you also need some device drivers or boot

[PATCH] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-23 Thread Jochen Friedrich
driver. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 + arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/bu

[PATCHv2] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/dbox2.dts | 263 arch/powerpc/configs/dbox2_defconfig | 1042 ++ arch/p

Re: [PATCH] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
Jochen Friedrich schrieb: This patch adds device tree source, default config and setup code for DBox2 devices. please ignore this posting. This patch doesn't compile cleanly, i'll repost a fixed patch. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/dbox2.dts | 263 arch/powerpc/configs/dbox2_defconfig | 1042 ++ arch/p

[PATCH] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/dbox2.dts | 263 arch/powerpc/configs/dbox2_defconfig | 1042 ++ arch/powerpc

Re: [PATCH] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
Jochen Friedrich schrieb: This patch adds device tree source, default config and setup code for DBox2 devices. please ignore this posting. This patch doesn't compile cleanly, i'll repost a fixed patch. Thanks, Jochen -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCHv2] powerpc: DBox2 Board Support

2007-12-23 Thread Jochen Friedrich
This patch adds device tree source, default config and setup code for DBox2 devices. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/dbox2.dts | 263 arch/powerpc/configs/dbox2_defconfig | 1042 ++ arch/powerpc

[PATCH] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-23 Thread Jochen Friedrich
-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8272ads.dts | 10 + arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/busses/Kconfig

Re: [PATCH POWERPC] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-22 Thread Jochen Friedrich
Hi Vitaly, I had an attempt a while ago to do this but haven't had enough time to get it completed, so I am glad to see it finally picked up. There was some sort of discussion that time, you seem to have some of those points addressed but something not, please check:

Re: [PATCH POWERPC] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-22 Thread Jochen Friedrich
Hi Vitaly, I had an attempt a while ago to do this but haven't had enough time to get it completed, so I am glad to see it finally picked up. There was some sort of discussion that time, you seem to have some of those points addressed but something not, please check:

[PATCH POWERPC] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-21 Thread Jochen Friedrich
driver. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/busses/Kconfig | 10 + drivers/i2c/bus

[PATCH POWERPC] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2007-12-21 Thread Jochen Friedrich
-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc866ads.dts | 10 + arch/powerpc/boot/dts/mpc885ads.dts | 10 + arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 + drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

[PATCH] [POWERPC] Add fixed-phy support for fs_enet

2007-12-18 Thread Jochen Friedrich
This patch adds support to use the fixed-link property of an ethernet node to fs_enet for the CONFIG_PPC_CPM_NEW_BINDING case. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> Acked-by: Jeff Garzik <[EMAIL PROTECTED]> Acked-by: Vitali Bordug <[EMAIL PROTECTED]> --- drivers/n

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-18 Thread Jochen Friedrich
Hi Jeff, > ACK, pass this through paulus? Yes, that's fine for me. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-18 Thread Jochen Friedrich
Hi Jeff, ACK, pass this through paulus? Yes, that's fine for me. Thanks, Jochen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH] [POWERPC] Add fixed-phy support for fs_enet

2007-12-18 Thread Jochen Friedrich
This patch adds support to use the fixed-link property of an ethernet node to fs_enet for the CONFIG_PPC_CPM_NEW_BINDING case. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Vitali Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet

  1   2   >