Re: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

2018-12-07 Thread Joe Perches
On Fri, 2018-12-07 at 02:50 +, Clark Wang wrote: > In order to enable the slave mode and make the code more readable, > replace all related structure names and object names which is > named "master" with "controller". In what sense does this make the code more readable?

Re: [PATCH 10/12] staging: rtl8188eu: correct indentation in update_wireless_mode()

2018-12-05 Thread Joe Perches
On Wed, 2018-12-05 at 18:02 +0100, Michael Straube wrote: > Correct indentation in update_wireless_mode() to clear a checkpatch > warning. WARNING: Statements should start on a tabstop [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c >

Re: [PATCH] staging: iio: ad5933: add binding doc for ad5933

2018-12-02 Thread Joe Perches
On Mon, 2018-12-03 at 00:20 +0530, Himanshu Jha wrote: > On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote: > > Add a devicetree documentation for the ad5933 and ad5934 impedance > > converter, network analyzer. > > > > Co-Developed-by: Gabriel Capella > > checkpatch spits out: >

Re: [PATCH] staging: wilc1000: correct inconsistent indenting

2018-11-28 Thread Joe Perches
On Wed, 2018-11-28 at 19:17 +0100, Michael Straube wrote: > Correct inconsistent indenting reported by smatch. [] > diff --git a/drivers/staging/wilc1000/wilc_spi.c > b/drivers/staging/wilc1000/wilc_spi.c [] > @@ -963,7 +963,7 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 > *int_status)

Re: [tip:timers/core] time: Add SPDX license identifiers

2018-11-28 Thread Joe Perches
On Fri, 2018-11-23 at 20:15 -0800, Joe Perches wrote: > On Fri, 2018-11-23 at 03:19 -0800, tip-bot for Thomas Gleixner wrote: > > The SPDX > > identifier is a legally binding shorthand, which can be used instead of the > > full boiler plate text. > > Is the "leg

Re: [PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused

2018-11-28 Thread Joe Perches
On Wed, 2018-11-28 at 21:05 +0200, Andy Shevchenko wrote: > Since we put static variable to a header file it's copied to each module > that includes the header. But not all of them are actually using it. > > Mark nvmem_type_str array with __maybe_unused to make a compiler happy: > > In file

Re: [PATCH v10 1/7] interconnect: Add generic on-chip interconnect API

2018-11-27 Thread Joe Perches
On Tue, 2018-11-27 at 20:03 +0200, Georgi Djakov wrote: > This patch introduces a new API to get requirements and configure the > interconnect buses across the entire chipset to fit with the current > demand. trivial notes: > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c

Re: RFC: script to convert vsprintf uses of %pf to %ps and %pF to %pS

2018-11-26 Thread Joe Perches
On Mon, 2018-11-26 at 15:08 +0900, Sergey Senozhatsky wrote: > > There are approximately these total uses of the symbolic > > lookup vsprintf extensions %p[SsFf]: > > > > $ git grep '".*[^%]%p[SsFf]' | \ > > grep -oh '%p[SsFf]' | sort | uniq -c | sort -rn > > 231 %pS > > 65 %ps > >

Re: [PATCH] staging: iio: adc: ad7280a: check for devm_kasprint() failure

2018-11-26 Thread Joe Perches
On Mon, 2018-11-26 at 16:26 +0300, Dan Carpenter wrote: > On Mon, Nov 26, 2018 at 02:10:09PM +0100, Nicholas Mc Guire wrote: > > On Mon, Nov 26, 2018 at 04:00:32PM +0300, Dan Carpenter wrote: > > > On Mon, Nov 26, 2018 at 10:39:04AM +0100, Nicholas Mc Guire wrote: > > > > devm_kasprintf() may

RFC: script to convert vsprintf uses of %pf to %ps and %pF to %pS

2018-11-25 Thread Joe Perches
commit 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()}" deprecated vsprintf extension %pf and %pF. There are approximately these total uses of the symbolic lookup vsprintf extensions %p[SsFf]: $ git grep '".*[^%]%p[SsFf]' | \ grep -oh '%p[SsFf]' | sort | uniq -c |

Re: [tip:timers/core] time: Add SPDX license identifiers

2018-11-23 Thread Joe Perches
On Fri, 2018-11-23 at 03:19 -0800, tip-bot for Thomas Gleixner wrote: > The SPDX > identifier is a legally binding shorthand, which can be used instead of the > full boiler plate text. Is the "legally binding shorthand" actually proven anywhere? I am not aware of any case law for this.

Re: [PATCH] hfs: do not free node before using

2018-11-23 Thread Joe Perches
On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote: > The function hfs_bmap_free frees node via hfs_bnode_put(node). However, > it then reads node->this when dumping error message on an error path, > which may result in a use-after-free bug. This patch frees node only > when it is never used. > >

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-21 Thread Joe Perches
On Wed, 2018-11-21 at 15:58 +1100, NeilBrown wrote: > On Sun, Nov 18 2018, Joe Perches wrote: > > > On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > > > Some parameters are aligned with parentheses. > > > Some parentheses are opened at end of line

Re: [PATCH v3] debugobjects: scale the static pool size

2018-11-20 Thread Joe Perches
On Wed, 2018-11-21 at 00:54 +0100, Qian Cai wrote: > On 11/20/18 at 6:38 PM, Waiman Long wrote: > > On 11/20/2018 06:28 PM, Qian Cai wrote: > > > The current value of the early boot static pool size is not big enough > > > for systems with large number of CPUs with timer or/and workqueue > > >

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-18 Thread Joe Perches
On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. Given the very long identifier lengths, I wouldn't consider many of these appropriate. 80 column line lengths and long identifiers don't play

Re: [PATCH 1/2] staging: emxx_udc: Split line and fix eol parenthesis

2018-11-17 Thread Joe Perches
On Sat, 2018-11-17 at 00:46 +0100, Cristian Sicilia wrote: > Fix some parenthesis opened at end of line. It looks like this is all guarded by #ifdef UDC_DEBUG_DUMP which is not ever set and this probably would not compile if it was. It's probably better to remove all the blocks guarded by that

Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile

2018-11-15 Thread Joe Perches
On Thu, 2018-11-15 at 19:40 +, Luck, Tony wrote: > > I would recommend to remove this section at all. > > New maintainers won't come out of blue, but will be come > > from existing community and such individuals for sure will see > > and judge by themselves to whom they trust and to whom not.

Re: [PATCH v3 01/20] lib/vsprintf: Print time and date in human readable format via %pt

2018-11-13 Thread Joe Perches
On Tue, 2018-11-13 at 19:17 +0200, Andy Shevchenko wrote: > There are users which print time and date represented by content of > struct rtc_time in human readable format. > > Instead of open coding that each time introduce %ptR[dt][rv] specifier. > > Note, users have to select

Re: [PATCH] xfs: Remove noinline from #define STATIC

2018-11-12 Thread Joe Perches
On Tue, 2018-11-13 at 16:26 +1100, Dave Chinner wrote: > On Mon, Nov 12, 2018 at 08:23:42PM -0800, Joe Perches wrote: > > On Tue, 2018-11-13 at 14:09 +1100, Dave Chinner wrote: > > > On Mon, Nov 12, 2018 at 08:54:10PM -0500, Theodore Y. Ts'o wrote: > > > > On Tue, No

Re: [PATCH] xfs: Remove noinline from #define STATIC

2018-11-12 Thread Joe Perches
On Tue, 2018-11-13 at 14:09 +1100, Dave Chinner wrote: > On Mon, Nov 12, 2018 at 08:54:10PM -0500, Theodore Y. Ts'o wrote: > > On Tue, Nov 13, 2018 at 12:18:05PM +1100, Dave Chinner wrote: > > > I'm not interested in making code fast if distro support engineers > > > can't debug problems on user

Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

2018-11-12 Thread Joe Perches
On Mon, 2018-11-12 at 19:45 -0500, Arnold Chand wrote: > Corrected warnings and checks provided by scripts/checkpatch.pl which > includes: alignment of parenthesis, lines over 80 characters and mutex > definition without comment. [] > diff --git

Re: [PATCH] xfs: Remove noinline from #define STATIC

2018-11-12 Thread Joe Perches
On Tue, 2018-11-13 at 08:45 +1100, Dave Chinner wrote: > On Mon, Nov 12, 2018 at 02:12:08PM -0600, Eric Sandeen wrote: > > On 11/10/18 7:21 PM, Joe Perches wrote: > > > Reduce total object size quite a bit (~32KB) and presumably > > > improve performance at the same time

Re: [PATCH] xfs: Remove noinline from #define STATIC

2018-11-12 Thread Joe Perches
On Mon, 2018-11-12 at 14:12 -0600, Eric Sandeen wrote: > On 11/10/18 7:21 PM, Joe Perches wrote: > > Reduce total object size quite a bit (~32KB) and presumably > > improve performance at the same time. > > > > Total object size old vs new (x86-64 defconfig with xfs) &

Re: [PATCH RFC] locking/lockdep: replace simple printk by pr_info

2018-11-12 Thread Joe Perches
On Mon, 2018-11-12 at 13:03 +, Corentin Labbe wrote: > While working on detector of new warn/err/crit/... messages, I found that the > following messages was printed with the warn loglevel: > [0.001607] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., > Ingo Molnar > [

[PATCH] xfs: Remove noinline from #define STATIC

2018-11-10 Thread Joe Perches
165669 632 1090984 10a5a8 (TOTALS) (new) Signed-off-by: Joe Perches --- fs/xfs/xfs_linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h index edbd5a210df2..f33c8b626bca 100644 --- a/fs/xfs/xfs_linux.h +++ b/fs/xfs/xfs_linux.h

Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread Joe Perches
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) This commit message makes no sense. Do say what you do to the code in the commit description. > Signed-off-by: hmsjwzb > --- > fs/xfs/xfs_acl.c | 4 +-- >

Re: [PATCH v3 04/23] linux/net.h: use unique identifier for each struct _ddebug

2018-11-09 Thread Joe Perches
On Sat, 2018-11-10 at 00:10 +0100, Rasmus Villemoes wrote: > Changes on x86-64 later in this series require that all struct _ddebug > descriptors in a translation unit uses distinct identifiers. Realize > that for net_dbg_ratelimited by generating such an identifier via > __UNIQUE_ID and pass that

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Joe Perches
On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > Signed-off-by: Bo YU > > First off, IMO, you should not change the existing code just in order > to make

[PATCH] checkpatch: Warn on const char foo[] = "bar"; declarations

2018-11-04 Thread Joe Perches
Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c883ec55654f..7789e13dac9d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3869,14 +3869,23

Re: [PATCH v4] mm/page_owner: clamp read count to PAGE_SIZE

2018-11-01 Thread Joe Perches
On Thu, 2018-11-01 at 14:47 -0700, Andrew Morton wrote: > On Fri, 2 Nov 2018 01:00:07 +0800 wrote: > > > From: Miles Chen > > > > The page owner read might allocate a large size of memory with > > a large read count. Allocation fails can easily occur when doing > > high order allocations. > >

Re: [PATCH] staging: vt6656: clean up few indentation issues

2018-10-31 Thread Joe Perches
On Tue, 2018-10-30 at 11:13 +, Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up indentation issues [] > diff --git a/drivers/staging/vt6656/main_usb.c > b/drivers/staging/vt6656/main_usb.c > index ccafcc2c87ac..b613a1d113bb 100644 > ---

Re: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

2018-10-31 Thread Joe Perches
On Tue, 2018-10-30 at 11:57 +, Colin Ian King wrote: > $SUBJECT should be: > > tlclk: clean an indentation issue, remove extraneous tabs Perhaps add missing braces for the last else uses as well? > On 30/10/2018 11:56, Colin King wrote: > > From: Colin Ian King [] > > diff --git

Re: [PATCH 17/28] tools include uapi: Update asound.h copy

2018-10-31 Thread Joe Perches
On Wed, 2018-10-31 at 18:00 +0100, Takashi Iwai wrote: > On Wed, 31 Oct 2018 17:44:57 +0100, > Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo > > > > To silence this perf build warning: > > > > Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs > >

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

2018-10-31 Thread Joe Perches
On Wed, 2018-10-31 at 09:41 -0400, YU Bo wrote: > Hi, > On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: > > On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: > > > Fix warning from checkpatch.pl use pr_* to replace printk > > > > If you look at msg, it

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

2018-10-30 Thread Joe Perches
On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: > Fix warning from checkpatch.pl use pr_* to replace printk If you look at msg, it can be unterminated with newline. > diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c [] > @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj,

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

2018-10-28 Thread Joe Perches
On Mon, 2018-10-29 at 03:02 +0100, Steffen Vogel wrote: > Hi Joe, > > v2 of this patch set is almost ready. > I reran checkpatch.pl with '--strict'. So more warnings will be fixed by > the second version. > > See my comments below. > > On Sun, Oct 28, 2018 at 06:52:23

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

2018-10-28 Thread Joe Perches
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > This fixes a warning raised by the checkpatch tool. checkpatch does not raise any whitespace errors on this file. It does suggest that braces could be moved. $ ./scripts/checkpatch.pl -f --strict drivers/w1/w1_netlink.h WARNING: Missing

Re: [PATCH 2/9] w1: improve coding style by following strict 80 column line limit

2018-10-28 Thread Joe Perches
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > This satisfies a checkpatch warning Perhaps run your patches through checkpatch with --strict > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c [] > @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev) >

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: > On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > > The function rtw_hal_xmit() returns true or false. > > Change the return type from s32 to bool. > [] > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > The function rtw_hal_xmit() returns true or false. > Change the return type from s32 to bool. [] > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c [] > @@ -598,7 +598,7 @@

Re: [PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 23:32 +0100, Jordan Borgner wrote: > Added missing parentheses to sizeof() function in detect_memory_e820(). > > Removed unnecessary braces in detect_memory_e801(). > > Replaced three if-statements with a ternary if-statement and > removed an unnecessary integer variable

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-27 Thread Joe Perches
On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote: > [Adding Joe Perches] > > On Fri, 26 Oct 2018, Sasha Levin wrote: > > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > > This change was suggested by checkpath.pl. Use unsigned int w

Re: Another HID problem this merge window..

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 11:13 -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most people

Re: [PATCH] mm/page_owner: use vmalloc instead of kmalloc

2018-10-25 Thread Joe Perches
On Fri, 2018-10-26 at 02:34 +0800, miles.c...@mediatek.com wrote: > From: Miles Chen > > The kbuf used by page owner is allocated by kmalloc(), > which means it can use only normal memory and there might > be a "out of memory" issue when we're out of normal memory. > > Use vmalloc() so we can

Re: [PATCH] staging: axis-fifo: Fix line over 80 characters error

2018-10-25 Thread Joe Perches
On Thu, 2018-10-25 at 09:05 +0300, Dan Carpenter wrote: > On Wed, Oct 24, 2018 at 05:05:53PM +0200, Aleksa Zdravkovic wrote: > > This patch fixes the checkpatch.pl warning: [] > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c > > b/drivers/staging/axis-fifo/axis-fifo.c [] > > @@ -482,10

Re: [PATCH v2 2/3] leds: upboard: Add LED support

2018-10-24 Thread Joe Perches
On Wed, 2018-10-24 at 13:13 +0300, Andy Shevchenko wrote: > On Tue, Oct 23, 2018 at 12:23:13PM -0700, Joe Perches wrote: > > Until such a time when either a local preferred style > > document or a treewide preferred style exists, please > > stop asking people to mod

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-10-24 Thread Joe Perches
On Wed, 2018-10-24 at 10:23 +0200, Michal Hocko wrote: > On Tue 23-10-18 23:26:16, Joe Perches wrote: > > On Wed, 2018-10-24 at 08:15 +0200, Michal Hocko wrote: > > > On Wed 24-10-18 10:47:52, Arun KS wrote: > > > > On 2018-10-24 01:34, Kees Cook wrote: > &

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-10-24 Thread Joe Perches
On Wed, 2018-10-24 at 08:15 +0200, Michal Hocko wrote: > On Wed 24-10-18 10:47:52, Arun KS wrote: > > On 2018-10-24 01:34, Kees Cook wrote: > [...] > > > Thank you -- I was struggling to figure out the best way to reply to > > > this. :) > > I'm sorry for the trouble caused. Sent the email using,

Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

2018-10-23 Thread Joe Perches
On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. The patch subject

Re: [PATCH v2 2/3] leds: upboard: Add LED support

2018-10-23 Thread Joe Perches
On Tue, 2018-10-23 at 20:50 +0200, Jacek Anaszewski wrote: > > diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c > > new file mode 100644 > > index 000..34a6973 > > --- /dev/null > > +++ b/drivers/leds/leds-upboard.c > > @@ -0,0 +1,104 @@ [] > > +#include > > +#include >

Re: [Ksummit-discuss] [GIT PULL] code of conduct fixes for 4.19-rc8

2018-10-23 Thread Joe Perches
On Mon, 2018-10-22 at 23:05 -0700, Randy Dunlap wrote: > On 10/22/18 9:16 PM, Joe Perches wrote: > > As James Bottomley has suggested multiple times, > > I'd much rather kernel development use the debian > > code of conduct verbatim than even this modified one. > >

Re: [Ksummit-discuss] [GIT PULL] code of conduct fixes for 4.19-rc8

2018-10-22 Thread Joe Perches
On Mon, 2018-10-22 at 22:10 +0100, Greg Kroah-Hartman wrote: > On Sat, Oct 20, 2018 at 01:15:14PM -0700, James Bottomley wrote: > > This is the series of patches which has been discussed on both ksummit- > > discuss and linux-kernel for the past few weeks. As Shuah said when > > kicking off the

Re: Linux 4.19

2018-10-22 Thread Joe Perches
On Mon, 2018-10-22 at 08:32 +0100, Greg KH wrote: > Greg Kroah-Hartman (7): > Code of Conduct Interpretation: Add document explaining how the Code of > Conduct is to be interpreted > Code of Conduct Interpretation: Properly reference the TAB correctly > Code of Conduct: Provide

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-21 Thread Joe Perches
he concept of describing a desire for pleasant interactions while developing the linux kernel is legitimate and useful. I do reject this process as well and I think the attempt to reform it via a private, non-public method is, at best, poor form. Joe Perches

Re: [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style

2018-10-21 Thread Joe Perches
On Sat, 2018-10-20 at 13:08 +0200, Michael Straube wrote: > Rename the variable isCCKrate to avoid CamelCase. > isCCKrate -> is_cck_rate [] > diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c > b/drivers/staging/rtl8188eu/hal/odm_hwconfig.c [] > @@ -71,19 +71,20 @@ static void

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 13:18 -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. > > Signed-off-by: Wenwen Wang > --- > include/uapi/linux/vfio.h | 1 + > 1

Re: [PATCH] pstore: Refactor compression initialization

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote: > With compression initialization now separated from pstore_register(), > there is no longer a good reason to do compression method selection > during fs init. Instead, merge everything together into the late init. > Additionally cleans up the

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-17 Thread Joe Perches
On Wed, 2018-10-17 at 12:29 +0100, Russell King - ARM Linux wrote: > On Tue, Oct 16, 2018 at 04:55:00PM +0300, Andy Shevchenko wrote: > > On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > > > On 16.10.2018 13:29, Andrzej Hajda wrote: > > > > On 16.10.2018 13:01, Andy Shevchenko wrote: > > >

Re: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-17 Thread Joe Perches
On Wed, 2018-10-17 at 02:13 -0700, Josh Triplett wrote: > On Wed, Oct 17, 2018 at 09:19:01AM +0200, Geert Uytterhoeven wrote: > > Providing an explicit list of discrimination factors may give the false > > impression that discrimination based on other unlisted factors would be > > allowed. > >

Re: Bad MAINTAINERS pattern in section 'USER-MODE LINUX (UML)'

2018-10-17 Thread Joe Perches
> Joe, Hi Richard. > On Sat, Sep 29, 2018 at 12:06 AM Joe Perches wrote: > > Please fix this defect appropriately. > > Care to send a patch? Not really. Because you are listed as the maintainer, you should be the person that fixes it as you are nominally and ac

Re: [RFC v1 12/31] checkpatch: added support for struct MOCK(foo) syntax

2018-10-16 Thread Joe Perches
On Tue, 2018-10-16 at 16:51 -0700, Brendan Higgins wrote: > This adds struct MOCK(foo) as a NonptrType so that it is recognized > correctly in declarations. I think this commit message is lacking context. > Signed-off-by: Brendan Higgins > --- > scripts/checkpatch.pl | 4 > 1 file

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Joe Perches
On Tue, 2018-10-16 at 20:29 -0300, Giuliano Augusto Faulin Belinassi wrote: > > (There is a linux-...@googlegroups.com mailing list > > that bounces when I reply, so I removed it from the > > cc list) > > Sorry. I think this may be because my HTML mode in gmail was enabled. No, it is because

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Joe Perches
(There is a linux-...@googlegroups.com mailing list that bounces when I reply, so I removed it from the cc list) On Tue, 2018-10-16 at 19:48 -0300, Giuliano Belinassi wrote: > Hello, > Thank you for your review :-). > Sorry, but I am a newbie on this, and now I am confused about my next >

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Joe Perches
On Tue, 2018-10-16 at 18:09 -0300, Giuliano Belinassi wrote: > A number of macro calls cause a checkpatch issue: > > "Lines should not end with a '('" > > This was fixed by moving the first '(' token to the line of the first > argument. Please try to make the code more readable instead of

Re: [PATCH] staging: iio: adc: Add comments to prevent checks corrections

2018-10-16 Thread Joe Perches
On Tue, 2018-10-16 at 20:06 +0200, Slawomir Stepien wrote: > On paź 15, 2018 18:25, Gabriel Capella wrote: > > This patch adds 3 comments in 2 different files. > > These comments warn to don't correct the checks of type: > > "CHECK: spaces preferred around that '-'" > > > > Signed-off-by: Gabriel

Re: patch "staging: MAINTAINERS: remove obsolete IPX staging directory" added to staging-testing

2018-10-16 Thread Joe Perches
On Tue, 2018-10-16 at 13:51 +0200, Greg KH wrote: > On Tue, Oct 16, 2018 at 04:43:30AM -0700, Joe Perches wrote: > > On Tue, 2018-10-16 at 12:46 +0200, gre...@linuxfoundation.org wrote: > > > This is a note to let you know that I've just added the patch titled > > > >

Re: [PATCH] staging: add nrf24 driver

2018-10-15 Thread Joe Perches
On Tue, 2018-10-16 at 01:17 +0200, Marcin Ciupak wrote: > This patch adds driver for Nordic Semiconductor nRF24L01+ radio module. [] > diff --git a/drivers/staging/nrf24/nrf24_hal.c > b/drivers/staging/nrf24/nrf24_hal.c [] > +static ssize_t nrf24_read_reg(struct spi_device *spi, u8 addr) > +{ >

Re: [PATCH 3.16 232/366] tracing: Deletion of an unnecessary check before iput()

2018-10-14 Thread Joe Perches
On Sun, 2018-10-14 at 16:25 +0100, Ben Hutchings wrote: > 3.16.60-rc1 review patch. If anyone has any objections, please let me know. I believe that no stable or backport kernel needs to apply patches like this unless it's needed for other real patches to be applied more easily. >

Re: [PATCH V3] MAINTAINERS: intel_telemetry: Update maintainers info

2018-10-12 Thread Joe Perches
On Fri, 2018-10-12 at 09:28 -0700, David E. Box wrote: > Remove Souvik who has left this role. Add Rajneesh and David who work > jointly on telemetry updates for new platforms. > > Signed-off-by: David E. Box > Signed-off-by: Rajneesh Bhardwaj [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@

Re: Question on FIELD_PREP() for static array

2018-10-10 Thread Joe Perches
On Wed, 2018-10-10 at 18:16 +0100, John Garry wrote: > (to: get_maintainers -f include/linux/bitfield.h) > > Hi, > > I would like to use FIELD_PREP() macro for assigning a static array, > like this: > function() > { > static u32 val[2] = {FIELD_PREP(GENMASK_ULL(10, 0), 5), 0}; > > } > >

Re: [Patch v2] MAINTAINERS: intel_telemetry: Update maintainers info

2018-10-09 Thread Joe Perches
On Tue, 2018-10-09 at 19:48 +0530, Rajneesh Bhardwaj wrote: > Add myself and David as the new maintainers for Intel Telemetry driver > since Souvik no longer works with Intel. David and I work on power > management and debug related drivers which are pretty close to this one > in terms of

Re: CHECKPATCH: strange warning on alignment modifier

2018-10-08 Thread Joe Perches
On Mon, 2018-10-08 at 10:56 +0300, Igor Stoppa wrote: > Hi, > > I have the following fragment of code: > > +struct my_struct { > + atomic_long_t l __aligned(sizeof(atomic_long_t)); > +} __aligned(sizeof(atomic_long_t)); > > > triggering this warning, when fed to checkpatch.pl: > >

Re: list iterator spacing: clang-format vs checkpatch

2018-10-08 Thread Joe Perches
On Mon, 2018-10-08 at 09:31 +0200, Miguel Ojeda wrote: > On Mon, Oct 8, 2018 at 4:01 AM Jason A. Donenfeld wrote: > > The shiny new .clang-format file lists a number of nice iterators in > > the ForEachMacros category, the consequence being that there is a > > space between the iterator name and

Re: [PATCH] staging/rtlwifi: Fixing formatting warnings from checkpatch.pl.

2018-10-05 Thread Joe Perches
On Fri, 2018-10-05 at 16:58 -0600, Scott Tracy wrote: > Fixing formatting warnings in rtlwifi found by checkpatch.pl > Changes include breaking up functions calls into multi line calls. > No functional/logical changes. I believe the code is better before most of these changes. There are various

Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

2018-10-04 Thread Joe Perches
On Thu, 2018-10-04 at 14:12 +0200, Michael Straube wrote: > On 10/3/18 11:30 PM, Joe Perches wrote: > > > > static struct mlme_handler mlme_sta_tbl[] = { > > > > Perhaps const here too, and as well, the struct > > declaration could use const char * i

Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier

2018-10-04 Thread Joe Perches
On Thu, 2018-10-04 at 10:40 +0200, Daniel Lezcano wrote: > On 04/10/2018 10:22, Rafael J. Wysocki wrote: > > On Thu, Oct 4, 2018 at 9:42 AM Daniel Lezcano > > wrote: > > > The function get_loadavg() returns almost always zero. To be more > > > precise, statistically speaking for a total of

Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

2018-10-03 Thread Joe Perches
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote: > Cleanup array declaration to clear two 'line over 80 characters' > checkpatch warnings and improve readability. [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c [] > @@

Re: [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters - style

2018-10-03 Thread Joe Perches
On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote: > Line break array declaration to clear a 'line over 80 characters' > checkpatch warning. For consistency replace 0x0 with 0x00. [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c >

Re: Bad MAINTAINERS pattern in section 'INTEL PMC CORE DRIVER'

2018-10-03 Thread Joe Perches
On Wed, 2018-10-03 at 11:00 +0300, Andy Shevchenko wrote: > On Sat, Sep 29, 2018 at 12:54 AM Joe Perches wrote: > > Please fix this defect appropriately. > > > > linux-next MAINTAINERS section: > > > > 7441INTEL PMC CORE DRIVER > >

Re: [PATCH] ARM: disable ARMv6 for Clang older than 8.0

2018-09-30 Thread Joe Perches
On Mon, 2018-10-01 at 00:22 +0200, Stefan Agner wrote: > The kernel passes the ArmV6K architecture to the compiler when > using the multi platform selection and enabling ARMv6. Clang > older than version 8.0 emit assembly with an non-existing CPU, > which then makes the assembler fail. Prevent the

Re: [PATCH 01/19] staging: rtl8188eu: cleanup inconsistent indenting

2018-09-30 Thread Joe Perches
On Sun, 2018-09-30 at 21:52 +0200, Michael Straube wrote: > Cleanup all inconsistent indenting reported by smatch. There are also some others like: drivers/staging/rtl8188eu/core/rtw_mlme.c:1752: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) 1750: if

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

2018-09-30 Thread Joe Perches
On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > The following: > bool efuse_re_pg_sec1flag; > u8 efuse_re_pg_data[8]; > are not referenced anywhere in the rtlwifi code. > > Signed-off-by: Rick Veens > --- > drivers/staging/rtlwifi/wifi.h | 4 Presumably the equivalent uses in

[PATCH] MAINTAINERS: MIPS/LOONGSON2 ARCHITECTURE - Use the normal wildcard style

2018-09-30 Thread Joe Perches
Neither git nor get_maintainer understands the curly brace style. Signed-off-by: Joe Perches --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1c62b724bb60..f6ab4f3bccfb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9770,7

Re: [PATCH] ASoC: wm8731: Fix a unused function gcc warning

2018-09-29 Thread Joe Perches
On Sun, 2018-09-30 at 09:45 +0800, zhong jiang wrote: > Fix the following compile warning: > > sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined > but not used [-Wunused-function] > sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not > used

Re: Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'

2018-09-28 Thread Joe Perches
On Fri, 2018-09-28 at 17:46 -0700, Greg Kroah-Hartman wrote: > On Fri, Sep 28, 2018 at 03:04:23PM -0700, Joe Perches wrote: > > Please fix this defect appropriately. > > > > linux-next MAINTAINERS section: > > > > 13899 STAGING - FLARION FT1000 DRIVERS >

Bad MAINTAINERS pattern in section 'SYNOPSYS DESIGNWARE AXI DMAC DRIVER'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 14171 SYNOPSYS DESIGNWARE AXI DMAC DRIVER 14172 M: Eugeniy Paltsev 14173 S: Maintained --> 14174 F: drivers/dma/dwi-axi-dmac/ 14175 F:

Bad MAINTAINERS pattern in section 'Texas Instruments' System Control Interface (TISCI) Protocol Driver'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 14531 Texas Instruments' System Control Interface (TISCI) Protocol Driver 14532 M: Nishanth Menon 14533 M: Tero Kristo 14534 M: Santosh Shilimkar 14535 L:

Bad MAINTAINERS pattern in section 'USER-MODE LINUX (UML)'

2018-09-28 Thread Joe Perches
502 F: fs/hppfs/ Commit that introduced this: commit 679655daffdd2725b66ba2c5a759bbcb316fca5a Author: Joe Perches Date: Tue Apr 7 20:44:32 2009 -0700 MAINTAINERS - Add file patterns Better description of file pattern tag "F:" Add file exclusion tag

Bad MAINTAINERS pattern in section 'STI CEC DRIVER'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 13992 STI CEC DRIVER 13993 M: Benjamin Gaignard 13994 S: Maintained --> 13995 F: drivers/staging/media/st-cec/ 13996 F:

Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'

2018-09-28 Thread Joe Perches
mit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4 Author: Joe Perches Date: Tue Jul 5 15:21:34 2011 -0700 MAINTAINERS: Add remaining staging entries Add the staging entries from various TODO files to MAINTAINERS. Add a few web links as well. Miscellaneous staging typo section header

Bad MAINTAINERS pattern in section 'SOFTWARE DELEGATED EXCEPTION INTERFACE (SDEI)'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 13609 SOFTWARE DELEGATED EXCEPTION INTERFACE (SDEI) 13610 M: James Morse 13611 L: linux-arm-ker...@lists.infradead.org 13612 S: Maintained 13613 F:

Bad MAINTAINERS pattern in section 'SOFTWARE DELEGATED EXCEPTION INTERFACE (SDEI)'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 13609 SOFTWARE DELEGATED EXCEPTION INTERFACE (SDEI) 13610 M: James Morse 13611 L: linux-arm-ker...@lists.infradead.org 13612 S: Maintained 13613 F:

Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER 12852 M: Łukasz Stelmach 12853 L: linux-samsung-...@vger.kernel.org 12854 S: Maintained 12855 F:

Bad MAINTAINERS pattern in section 'RENESAS R-CAR GYROADC DRIVER'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 12496 RENESAS R-CAR GYROADC DRIVER 12497 M: Marek Vasut 12498 L: linux-...@vger.kernel.org 12499 S: Supported --> 12500 F: drivers/iio/adc/rcar_gyro_adc.c

Bad MAINTAINERS pattern in section 'NCP FILESYSTEM'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 10052 NCP FILESYSTEM 10053 M: Petr Vandrovec 10054 S: Obsolete --> 10055 F: drivers/staging/ncpfs/ Commit that introduced this: commit

Bad MAINTAINERS pattern in section 'PARALLEL LCD/KEYPAD PANEL DRIVER'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 11056 PARALLEL LCD/KEYPAD PANEL DRIVER 11057 M: Willy Tarreau 11058 M: Ksenija Stanojevic 11059 S: Odd Fixes 11060 F:

Bad MAINTAINERS pattern in section 'MULTIPLEXER SUBSYSTEM'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 9976MULTIPLEXER SUBSYSTEM 9977M: Peter Rosin 9978S: Maintained 9979F: Documentation/ABI/testing/sysfs-class-mux* 9980F:

Bad MAINTAINERS pattern in section 'MIPS/LOONGSON3 ARCHITECTURE'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 9766MIPS/LOONGSON3 ARCHITECTURE 9767M: Huacai Chen 9768L: linux-m...@linux-mips.org 9769S: Maintained 9770F: arch/mips/loongson64/ 9771

Bad MAINTAINERS pattern in section 'MIPS/LOONGSON3 ARCHITECTURE'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 9766MIPS/LOONGSON3 ARCHITECTURE 9767M: Huacai Chen 9768L: linux-m...@linux-mips.org 9769S: Maintained 9770F: arch/mips/loongson64/ 9771

Bad MAINTAINERS pattern in section 'MIPS/LOONGSON2 ARCHITECTURE'

2018-09-28 Thread Joe Perches
Please fix this defect appropriately. linux-next MAINTAINERS section: 9757MIPS/LOONGSON2 ARCHITECTURE 9758M: Jiaxun Yang 9759L: linux-m...@linux-mips.org 9760S: Maintained 9761F: arch/mips/loongson64/*{2e/2f}*

  1   2   3   4   5   6   7   8   9   10   >