Re: [PATCH 3/4] configfs: implement committable items

2021-01-13 Thread Joel Becker
On Wed, Nov 25, 2020 at 04:22:46PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This implements configfs committable items. We mostly follow the > documentation except that we extend config_group_ops with uncommit_item() > callback for reverting the changes made by commit_ite

Re: [RESEND PATCH v3 0/4] configfs: implement committable items and add sample code

2021-01-13 Thread Joel Becker
On Mon, Jan 11, 2021 at 09:32:14AM +0100, Bartosz Golaszewski wrote: > On Tue, Dec 29, 2020 at 11:22 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > Committable items in configfs are well defined and documented but > > unfortunately > > so far never implemented. > > > > T

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-03-05 Thread Joel Becker
Acked-by: Joel Becker On Fri, Feb 26, 2016 at 01:33:51PM +0100, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're

Re: [PATCH 4/8] fs: configfs: Replace CURRENT_TIME by current_fs_time()

2016-02-24 Thread Joel Becker
Acked-by: Joel Becker On Mon, Feb 22, 2016 at 07:17:50AM -0800, Deepa Dinamani wrote: > CURRENT_TIME macro is not appropriate for filesystems as it > doesn't use the right granularity for filesystem timestamps. > Use current_fs_time() instead. > > Signed-off-by: Deepa

Re: a configfs update for 4.5, and the configfs tree question

2016-01-04 Thread Joel Becker
On Mon, Jan 04, 2016 at 12:51:01PM +0100, Christoph Hellwig wrote: > On Tue, Dec 29, 2015 at 03:05:30PM -0800, Joel Becker wrote: > > > > Hoi, > > > > I'm well aware that I've caught some reviews and missed some others. I > > support funneling through

Re: a configfs update for 4.5, and the configfs tree question

2015-12-29 Thread Joel Becker
On Thu, Dec 24, 2015 at 03:51:09PM +0100, Christoph Hellwig wrote: > Hi all, > > I really want the configfs change in this series to go into 4.5. Originally > both Pantelis and I had changes ontop that would require it in a stable > non-rebased branch, but one or both of those might not make the

Re: [PATCH] configfs: implement binary attributes

2015-12-29 Thread Joel Becker
On Thu, Dec 24, 2015 at 03:51:10PM +0100, Christoph Hellwig wrote: > From: Pantelis Antoniou > > ConfigFS lacked binary attributes up until now. This patch > introduces support for binary attributes in a somewhat similar > manner of sysfs binary attributes albeit with changes that > fit the confi

Re: [PATCH v10 1/5] configfs: Allow dynamic group creation

2015-11-11 Thread Joel Becker
; so I could start using it in patches for various trees in the next > > merge window. > > It's super late, but the configfs changes are obviously safe to > existing code. Loving this change, even if this is merely a drive-by: Acked-by: Joel Becker > > What about the

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Joel Becker
Acked-by: Joel Becker On Thu, Jul 30, 2015 at 03:59:57PM -0700, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > With well over 200+ users of this api, there are a mere 12 users that > actually cheked the return value of this function. And all of them > really didn

Re: [RFC 1/1] fs/configfs/dir.c: remove unused debugging functions

2014-06-25 Thread Joel Becker
On Tue, May 13, 2014 at 08:38:32PM +0200, Fabian Frederick wrote: > Joe Perches noticed it was not used anywhere. > If there's no plan to use it in the future, > we could simply remove both functions ... > > Cc: Joe Perches > Cc: Joel Becker > Cc: Andrew Morto

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-23 Thread Joel Becker
On Wed, Jan 22, 2014 at 10:47:01AM -0800, James Bottomley wrote: > On Wed, 2014-01-22 at 18:37 +, Chris Mason wrote: > > On Wed, 2014-01-22 at 10:13 -0800, James Bottomley wrote: > > > On Wed, 2014-01-22 at 18:02 +, Chris Mason wrote: > [agreement cut because it's boring for the reader] > >

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-23 Thread Joel Becker
On Thu, Jan 23, 2014 at 07:55:50AM -0500, Theodore Ts'o wrote: > On Thu, Jan 23, 2014 at 07:35:58PM +1100, Dave Chinner wrote: > > > > > > I expect it would be relatively simple to get large blocksizes working > > > on powerpc with 64k PAGE_SIZE. So before diving in and doing huge > > > amounts o

Re: [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-21 Thread Joel Becker
On Tue, Jan 21, 2014 at 10:04:29PM -0500, Ric Wheeler wrote: > One topic that has been lurking forever at the edges is the current > 4k limitation for file system block sizes. Some devices in > production today and others coming soon have larger sectors and it > would be interesting to see if it is

Re: [LSF/MM TOPIC] [ATTEND] persistent memory progress, management of storage & file systems

2014-01-07 Thread Joel Becker
On Mon, Jan 06, 2014 at 05:32:56PM -0500, faibish, sorin wrote: > Speaking of persistent memory I would like to discuss the PMFS as well as > RDMA aspects of the persistent memory model. Also I would like to discuss KV > stores and object stores on persistent memory. I was involved in the PMFS as

Re: [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to struct ctl_table

2013-11-07 Thread Joel Becker
On Tue, Oct 22, 2013 at 03:30:00PM -0700, Joe Perches wrote: > This typedef is unnecessary and should just be removed. > > Signed-off-by: Joe Perches Acked-by: Joel Becker > --- > fs/ocfs2/stackglue.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > &g

Re: [PATCH] ocfs2/refcounttree: add the missing NULL check of the return value of find_or_create_page()

2013-07-09 Thread Joel Becker
break; > + } > /* >* In case PAGE_CACHE_SIZE <= CLUSTER_SIZE, This page >* can't be dirtied before we CoW it out. Put a blank line between the closing brace and the comment. Otherwise, Acked-by: Joel Becker Joel

Re: [PATCH v3 22/25] ocfs2: Change how dentry's d_lock field is accessed

2013-07-03 Thread Joel Becker
On Wed, Jul 03, 2013 at 04:22:02PM -0400, Waiman Long wrote: > Because of the changes made in dcache.h header file, files that > use the d_lock field of the dentry structure need to be changed > accordingly. All the d_lock's spin_lock() and spin_unlock() calls > are replaced by the corresponding d_

Re: [PATCH] ocfs2: Cocci spatch "memdup.spatch"

2013-06-09 Thread Joel Becker
Acked-by: Joel Becker On Sat, Jun 01, 2013 at 11:41:12AM +0200, Thomas Meyer wrote: > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c > --- a/fs/ocfs2/localalloc.c > +++ b/fs/ocfs2/localalloc.c > @@

Re: [PATCH v3 06/18] ocfs2: use ->invalidatepage() length argument

2013-05-02 Thread Joel Becker
Acked-by: Joel Becker On Tue, Apr 23, 2013 at 10:16:04AM -0400, Theodore Ts'o wrote: > On Tue, Apr 09, 2013 at 11:14:15AM +0200, Lukas Czerner wrote: > > ->invalidatepage() aop now accepts range to invalidate so we can make > > use of it in ocfs2_invalidatepage(). > &

Re: [patch] configfs: use capped length for ->store_attribute()

2013-05-02 Thread Joel Becker
On Tue, Apr 30, 2013 at 10:28:14AM +0300, Dan Carpenter wrote: > The difference between "count" and "len" is that "len" is capped at > 4095. Changing it like this makes it match how sysfs_write_file() is > implemented. > > Signed-off-by: Dan Carpente

Re: New copyfile system call - discuss before LSF?

2013-03-11 Thread Joel Becker
On Mon, Feb 25, 2013 at 04:03:01PM -0800, Zach Brown wrote: > > > I think it would be neat if it couldn't > > > corrupt data. > > > > It would also be neat if the moon were made of cheese... > > And there we have the lsf2013 t-shirt slogan. I think we're done here! > > - z Hey Everyone,

Re: [PATCH] fs: fs2fs: Replaced calls to kmalloc and memcpy with kmemdup

2013-03-10 Thread Joel Becker
On Sat, Mar 09, 2013 at 01:49:37PM +0200, Alexandru Gheorghiu wrote: > Replaced calls to kmalloc followd by memcpy with a single call to kmemdup. > This patch was found using coccicheck. > > Signed-off-by: Alexandru Gheorghiu Acked-by: Joel Becker > --- > fs/ocfs2/l

Re: OCFS2 mainline state?

2013-03-02 Thread Joel Becker
On Mon, Feb 25, 2013 at 09:16:18PM +, Al Viro wrote: > On Mon, Feb 25, 2013 at 01:11:03PM -0800, Mark Fasheh wrote: > > > I've seen that patch actually and yes it should have been in mainline > > already. I didn't see whether it's in -mm (Andrew is pickup up some of the > > patches for us righ

Re: [PATCH review 26/85] ocfs2: Enable building with user namespaces enabled

2013-02-14 Thread Joel Becker
uilding and > using ocfs2 with user namespace support enabled. > > Cc: Mark Fasheh > Cc: Joel Becker > Signed-off-by: "Eric W. Biederman" > --- > init/Kconfig |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/init/Kconfig b/

Re: [PATCH review 25/85] ocfs2: Compare kuids and kgids using uid_eq and gid_eq

2013-02-14 Thread Joel Becker
On Wed, Feb 13, 2013 at 09:51:14AM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Cc: Mark Fasheh > Cc: Joel Becker > Signed-off-by: "Eric W. Biederman" > --- > fs/ocfs2/file.c |8 > fs/ocfs2/refcounttree.

Re: [PATCH review 23/85] ocfs2: Convert uid and gids between in core and on disk inodes

2013-02-14 Thread Joel Becker
iederman" > > Cc: Mark Fasheh > Cc: Joel Becker > Signed-off-by: "Eric W. Biederman" > --- > fs/ocfs2/inode.c | 12 ++-- > fs/ocfs2/namei.c |4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/fs/ocfs2/inode.c b/fs/

Re: [PATCH review 22/85] ocfs2: convert between kuids and kgids and DLM locks

2013-02-14 Thread Joel Becker
gid. > > Cc: Mark Fasheh > Cc: Joel Becker > Signed-off-by: "Eric W. Biederman" > --- > fs/ocfs2/dlmglue.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c > index 4f7795f..f99af1c 10

Re: [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages

2013-01-29 Thread Joel Becker
Acked-by: Joel Becker On Fri, Jan 18, 2013 at 05:13:08PM -0800, Darrick J. Wong wrote: > When stable pages are required, we have to wait if the page is just > going to disk and we want to modify it. Add proper callback to > ocfs2_grab_pages_for_write(). > > CC: ocfs2-de...@oss.

Re: [PATCH V6 19/30] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec

2013-01-29 Thread Joel Becker
Acked-by: Joel Becker On Tue, Jan 29, 2013 at 10:23:32AM -0600, Dave Kleikamp wrote: > From: Zach Brown > > ocfs2's .aio_read and .aio_write methods are changed to take > iov_iter and pass it to generic functions. Wrappers are made to pack > the iovecs into iters and call

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-11 Thread Joel Becker
On Mon, Dec 10, 2012 at 03:17:34PM +0100, Andrzej Pietrasiewicz wrote: > @Joel in particular: please see my comment in the bottom. > I forgot to mention, representing udcs (USB Device Controllers) in > configfs is similar to interfaces/endpoints: the user needs to guess > what name to use in mkd

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-11 Thread Joel Becker
On Mon, Dec 10, 2012 at 12:57:02PM +0100, Andrzej Pietrasiewicz wrote: > Hello Joel, > > So you are alive, I'm glad to hear from you ;) Thank you for your response. Yeah, sorry for missing the thread for so long. > On Saturday, December 08, 2012 12:18 AM Joel Becker w

Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI

2012-12-07 Thread Joel Becker
On Sat, Dec 08, 2012 at 11:39:36AM +1100, Dave Chinner wrote: > On Fri, Dec 07, 2012 at 05:02:32PM -0500, Ric Wheeler wrote: > > On 12/07/2012 04:57 PM, Theodore Ts'o wrote: > > >On Fri, Dec 07, 2012 at 04:42:06PM -0500, Ric Wheeler wrote: > > >>The other things that I think we should try would be

Re: question about configfs_attribute

2012-12-07 Thread Joel Becker
On Mon, Oct 15, 2012 at 01:45:56PM +0200, Constantine Shulyupin wrote: > Hi > > I wonder why show and store methods are not stored inside of > configfs_attribute but stored in wrapper struct defined with > CONFIGFS_ATTR_STRUCT ? If you created a custom attribute struct and methods for you

Re: [PATCH] fs/configfs: allow to create groups on demand

2012-12-07 Thread Joel Becker
On Thu, Nov 29, 2012 at 05:41:23PM +0100, Sebastian Andrzej Siewior wrote: > This patch adds a function add a group to an existing one and its > counterart. The newly created group behaves as it would be created via > default_groups[] which means the user can't rmdir it. > This should be used by th

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-07 Thread Joel Becker
Hey Guys, Sorry I missed this for a while. I'll make a couple of inline comments, and then I'll summarize my (incomplete) thoughts at the bottom. On Wed, Nov 28, 2012 at 02:50:13PM +0100, Sebastian Andrzej Siewior wrote: > On 11/28/2012 02:05 PM, Michal Nazarewicz wrote: > >>On 11/27/2012

Re: [PATCH RFC 09/12] userns: Convert ocfs2 to use kuid and kgid where appropriate

2012-11-21 Thread Joel Becker
On Tue, Nov 20, 2012 at 04:43:37AM -0800, Eric W. Biederman wrote: > diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c > index 260b162..8a40457 100644 > --- a/fs/ocfs2/acl.c > +++ b/fs/ocfs2/acl.c > @@ -65,7 +65,20 @@ static struct posix_acl *ocfs2_acl_from_xattr(const void > *value, size_t size) > >

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-21 Thread Joel Becker
On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > > index 2778258..3656b88 100644 > > --- a/fs/xfs/xfs_inode.c > > +++ b/fs/xfs/xfs_inode.c > > @@ -570,11 +570,12 @@ xfs_dinode_from_disk( > > to->di_version = from ->di_versi

Re: [PATCH RFC 09/12] userns: Convert ocfs2 to use kuid and kgid where appropriate

2012-11-21 Thread Joel Becker
On Tue, Nov 20, 2012 at 04:43:37AM -0800, Eric W. Biederman wrote: > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1116,7 +1116,8 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr > *attr) > (unsigned long long)OCFS2_I(inode)->ip_blkno, >

Re: [PATCH 7/9] ocfs2: Use generic handlers of O_SYNC AIO DIO

2012-11-21 Thread Joel Becker
On Mon, Nov 19, 2012 at 11:51:14PM -0800, Darrick J. Wong wrote: > Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC > file. > > From: Jan Kara > Signed-off-by: Jan Kara > Signed-off-by: Jeff Moyer Acked-by: Joel Becker > --- > fs/ocfs2/a

Re: [PATCH 06/21] ocfs2: drop vmtruncate

2012-10-24 Thread Joel Becker
On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote: > 2012/10/23 Joel Becker : > > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote: > >> 2012/10/23 Joel Becker : > >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wro

Re: [PATCH 06/21] ocfs2: drop vmtruncate

2012-10-24 Thread Joel Becker
On Tue, Oct 23, 2012 at 09:02:38AM -0400, Christoph Hellwig wrote: > On Tue, Oct 23, 2012 at 01:54:48AM -0700, Joel Becker wrote: > > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: > > > Removed vmtruncate > > > > > > Signed-off-by: Marc

Re: [PATCH 06/21] ocfs2: drop vmtruncate

2012-10-23 Thread Joel Becker
On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote: > 2012/10/23 Joel Becker : > > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: > >> Removed vmtruncate > >> > >> Signed-off-by: Marco Stornelli > > > > Acked-by: Joel

Re: [PATCH 06/21] ocfs2: drop vmtruncate

2012-10-23 Thread Joel Becker
On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: > Removed vmtruncate > > Signed-off-by: Marco Stornelli Acked-by: Joel Becker Do you want me to pull this, or are you going to send it with your set? Joel > --- > fs/ocfs2/file.c | 19 +-- >

Re: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Joel Becker
On Mon, Aug 20, 2012 at 01:01:03PM +0200, Sebastian Andrzej Siewior wrote: > On 08/20/2012 07:59 AM, Joel Becker wrote: > > I think what you want here is a symlink. Create a directory > >high in the tree called 'ready' or 'available', and when you want to &

Re: [RFC 0/2] USB gadget - configfs

2012-08-20 Thread Joel Becker
On Mon, Aug 20, 2012 at 10:53:42AM +0200, Andrzej Pietrasiewicz wrote: > Hello Joel, > > Thanks for your reply. > > On Monday, August 20, 2012 8:00 AM Joel Becker wrote: > > > > I think what you want here is a symlink. Create a directory > > high in the

Re: [RFC 0/2] USB gadget - configfs

2012-08-19 Thread Joel Becker
On Fri, Aug 17, 2012 at 12:34:11PM +0200, Sebastian Andrzej Siewior wrote: > On 08/17/2012 12:30 PM, Andrzej Pietrasiewicz wrote: > >>There is a separation between "setting myself up" and "seeing that a host > >>wants to talk to me". You are a woman. And if you not done yet done you > >ignore > >>t

Re: [RFC 0/2] USB gadget - configfs

2012-08-16 Thread Joel Becker
On Thu, Aug 16, 2012 at 03:47:15PM +0200, Sebastian Andrzej Siewior wrote: > On 08/16/2012 03:17 PM, Andrzej Pietrasiewicz wrote: > >A lun is "opened" on storing the "file" attribute of the lun, it is in > >fsg_lun_store_file, storage_common.c. So, again, this is a configfs > >callback. > > > >On s

Re: 3.5-rc6 configfs BUG_ON

2012-08-15 Thread Joel Becker
On Sun, Jul 15, 2012 at 07:58:31PM -0400, Dave Jones wrote: > On Sun, Jul 15, 2012 at 01:58:46PM -0700, Joel Becker wrote: > > > > Call Trace: > > > [] d_kill+0xaf/0x120 > > > [] dput+0xe2/0x1d0 > > > [] path_put+0x1a/0x30 > > > [] v

Re: [RFC 0/2] USB gadget - configfs

2012-08-15 Thread Joel Becker
On Tue, Jul 10, 2012 at 10:54:44AM +0200, Andrzej Pietrasiewicz wrote: > Dear Joel, > > Thank you for your review. > > @Sebastian, Alan, Felipe: Thank you, too. > > On Monday, July 02, 2012 11:09 AM Joel Becker wrote: > > > > > > > > As a prere

Re: crash in ocfs2_fast_symlink_readpage in kernel 3.5.0

2012-07-30 Thread Joel Becker
On Sun, Jul 22, 2012 at 01:16:21PM -0700, Bret Towe wrote: > just booted a fresh 3.5 kernel and got the following on login via gdm > on the client computer > didn't see any crashes yet on any other computer but didn't give it > long to try after seeing this > let me know if you need more info > thi

Re: kernel BUG at fs/buffer.c:2886! Linux 3.5.0

2012-07-30 Thread Joel Becker
On Mon, Jul 30, 2012 at 09:45:14AM +0200, Vincent ETIENNE wrote: > > HI, > > Le 30/07/2012 08:30, Joel Becker a écrit : > > On Sat, Jul 28, 2012 at 12:18:30AM +0200, Vincent ETIENNE wrote: > >> Hello > >> > >> Get this on first write made ( by deliv

Re: kernel BUG at fs/buffer.c:2886! Linux 3.5.0

2012-07-29 Thread Joel Becker
On Sat, Jul 28, 2012 at 12:18:30AM +0200, Vincent ETIENNE wrote: > Hello > > Get this on first write made ( by deliver sending mail to inform of the > restart of services ) > Home partition (the one receiving the mail) is based on ocfs2 created > from drbd block device in primary/primary mode > T

Re: 3.5-rc6 configfs BUG_ON

2012-07-15 Thread Joel Becker
On Wed, Jul 11, 2012 at 03:25:58PM -0400, Dave Jones wrote: > kernel BUG at fs/configfs/dir.c:59! > invalid opcode: [#1] PREEMPT SMP > CPU 4 > Modules linked in: > ebtable_nat > nf_tproxy_core > hfsplus > ppp_synctty > async_tx > raid6_pq raid10 shpchp fakephp aer_inject ptp pps_core t

Re: 2.6.25-rc1 xen pvops regression

2008-02-20 Thread Joel Becker
i code? Joel -- "The real reason GNU ls is 8-bit-clean is so that they can start using ISO-8859-1 option characters." - Christopher Davis ([EMAIL PROTECTED]) Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 -- To unsubscribe fr

Re: 2.6.25-rc1 xen pvops regression

2008-02-18 Thread Joel Becker
essfully. Thank you! If you have any furthur patches you'd like to test, I'd be happy to do so. Joel -- "And yet I find, And yet I find repeating in my head. If I can't be my own, I'd feel better dead." Joel Becker Principal Software Developer Oracle E-mail

Re: 2.6.25-rc1 xen pvops regression

2008-02-16 Thread Joel Becker
ss 0xc01687f0 0xc0417ab6 <__set_fixmap+326>: pop%ecx 0xc040288f : lock btsl $0x8,(%eax) 0xc040299a : lock incb 0xc0766148 0xc0403270 : lock cmpxchg8b (%edi) Joel -- Life's Little Instruction Book #139 "Never deprive someone of hope; it might be all they ha

Re: 2.6.25-rc2-mm1

2008-02-16 Thread Joel Becker
On Sat, Feb 16, 2008 at 10:25:40PM -0800, Joel Becker wrote: > On Sat, Feb 16, 2008 at 12:25:22AM -0800, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ > ... > > +avoid-divides-in-bits_to_longs.patch &

Re: 2.6.25-rc1 xen pvops regression

2008-02-16 Thread Joel Becker
On Sat, Feb 16, 2008 at 10:46:23PM +1100, Jeremy Fitzhardinge wrote: > Joel Becker wrote: >> ksymoops is no help at all, but I got these from objdump of >> vmlinux: >> >> c04040bd xen_set_pte >> c0417ab6 set_pte_present >> c040288f set_bit >> c0402

Re: 2.6.25-rc2-mm1

2008-02-16 Thread Joel Becker
l -- There are morethings in heaven and earth, Horatio, Than are dreamt of in your philosophy. Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: 2.6.25-rc1 xen pvops regression

2008-02-16 Thread Joel Becker
On Sat, Feb 16, 2008 at 01:44:26PM +1100, Jeremy Fitzhardinge wrote: > Joel Becker wrote: > >> (XEN) mm.c:1825:d109 Bad type (saw 2801 != exp >> e000) for mfn 3a2f0f (pfn f0) >> (XEN) mm.c:649:d109 Error getting mfn 3a2f0f (pfn f0) from L1 entry

[GIT PATCH 0/2] ocfs2: Fix endian bug in o2dlm negotiation

2008-02-15 Thread Joel Becker
These patches fix up two outstanding issues from commit d24fbcda0c4988322949df3d759f1cfb32b32953 (ocfs2: Negotiate locking protocol versions). The first patch cleans up the comparison functions based on Andrew's review. The second fixes a byte-order bug in heterogeneous clusters. I've tested th

[PATCH 1/2] ocfs2: Clean up locking protocol negotiation.

2008-02-15 Thread Joel Becker
The comparison functions for protocol negotiation (introduced in commit d24fbcda0c4988322949df3d759f1cfb32b32953) were confusing. Separate out the comparison and value update parts. Signed-off-by: Joel Becker <[EMAIL PROTECTED]> --- fs/ocfs2/dlm/dlmdomain.c

[PATCH 2/2] ocfs2: Fix endian bug in o2dlm protocol negotiation.

2008-02-15 Thread Joel Becker
Thus, a big-endian and little-endian machines will treat this structure differently. The solution is to have little-endian machines swap the structure when converting from the structure to the u32 representation. Signed-off-by: Joel Becker <[EMAIL PROTECTED]> --- fs/ocfs2/dlm/dlmcomm

Re: 2.6.25-rc1 xen pvops regression

2008-02-15 Thread Joel Becker
e c040d278 (XEN) c040d280 c040d297 c040d29f c040d2c4 c040ddad c040de24 c040de33 c040de67 (XEN) c040dea1 c040deaa c040deb3 c05f2a94 c05f2bfb c05f2c4a c05f2c65 c05f2ddc -- Life's Little Instruction Book #24 "Drink champagne for no reason at all." Joel Becker Principal

Re: 2.6.25-rc1 xen pvops regression

2008-02-13 Thread Joel Becker
l reason GNU ls is 8-bit-clean is so that they can start using ISO-8859-1 option characters." - Christopher Davis ([EMAIL PROTECTED]) Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 # # Automatically generated make config: don't

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-13 Thread Joel Becker
On Wed, Feb 13, 2008 at 10:06:16AM -0500, John W. Linville wrote: > On Tue, Feb 12, 2008 at 06:47:30PM -0800, Joel Becker wrote: > > Make the distinction earlier. With ocfs2 and configfs (we got > > this scheme from Jeff), we keep the topic branches as "unsafe"

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Joel Becker
that topic going forward will stay in the history. Since that topic was pulled into ALL for testing, we are using the identical commits that got tested. Joel -- "I have never let my schooling interfere with my education." - Mark Twain Joel Becker Principal Software Develop

Re: [git patches] ocfs2 update

2008-02-07 Thread Joel Becker
the things which it is allegedly comparing. > > Yeah, a better name would probably help with readability. Joel, how about > dlm_protocol_compare_and_set()? Even better is to move the update outside the function. What do we think of the following? >From d667a08d73cd6659219d21cc57f678

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Joel Becker
On Tue, Jan 29, 2008 at 02:18:58PM -0800, Joel Becker wrote: > But I'm still not understanding what you mean by "1 kobject for > the directory". We have one kobject for the "logmask" directory, and > then attributes for each log type. I don't see h

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Joel Becker
t;interface_revision" isn't a log mask :-) Or do you mean something else? Joel -- "To announce that there must be no criticism of them president, or that we are to stand by the president, right or wrong, is not only unpatriotic and servile, but is morally treasonable to

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-28 Thread Joel Becker
l free to ask! Joel -- "Also, all of life's big problems include the words 'indictment' or 'inoperable.' Everything else is small stuff." - Alton Brown Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506

Re: [PATCH 1/2] configfs: dir.c fix possible recursive locking

2007-12-31 Thread Joel Becker
I_MUTEX_PARENT); > > name.name = group->cg_item.ci_name; > name.len = strlen(name.name); > --- > > Thanks. > Joonwoo > -- "One of the symptoms of an approaching nervous breakdown is the belief that one's work is terribly important."

dev_ifname32() fails on 32->64bit calls in copy_in_user().

2007-10-30 Thread Joel Becker
if (rc) bail(1, "Unable to get name: %s\n", strerror(errno)); fprintf(stdout, "Interface %d, %s\n", ifr.ifr_ifindex, ifr.ifr_ifrn.ifrn_name); } } return 0; } -- "What no boss of a programmer can ever understand is

Re: [PATCH][RFC] network splice receive v3

2007-07-11 Thread Joel Becker
l, has not heart; and any man who is over 30, and is not a conservative, has no brains." - Sir Winston Churchill Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

2007-07-10 Thread Joel Becker
thic kernel I compile it in. That doesn't mean I always have a server, let alone a netconsole= option :-) Joel -- "When choosing between two evils, I always like to try the one I've never tried before." - Mae West Joel Becker Principal Software Developer Oracle E-mai

Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation

2007-07-10 Thread Joel Becker
t require a > reboot either. I'll send out an updated patch shortly. Why not dmesg -n? We've been using that for years. Or is there some extra change in /proc/sys/kernel/printk? Joel -- "Against stupidity the Gods themselves contend in vain." - Frie

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-07 Thread Joel Becker
Joel -- "I have never let my schooling interfere with my education." - Mark Twain Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

[PATCH] configfs: Convert subsystem semaphore to mutex

2007-07-06 Thread Joel Becker
ation/configfs_example.c accordingly. Inspired-by: Satyam Sharma <[EMAIL PROTECTED]> Signed-off-by: Joel Becker <[EMAIL PROTECTED]> --- Documentation/filesystems/configfs/configfs.txt| 18 +- .../filesystems/configfs/configfs_example.c|2 +-

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

2007-07-06 Thread Joel Becker
ONFIG_NETCONSOLE_DYNAMIC */ > + and this to an dynamic_fini() function. Basically, do what you did with _get()/_put(). This keeps the ifdef up above and out of the functions themselves. #ifdef CONFIG_NETCONSOLE_DYNAMIC static int __init dynamic_netconsole_init(void) { config_group_in

Re: [PATCH -mm 0/3] configfs: Miscellaneous cleanups

2007-07-06 Thread Joel Becker
On Wed, Jul 04, 2007 at 11:30:08PM -0700, Joel Becker wrote: > > [1/3] configfs+dlm: Separate out __CONFIGFS_ATTR into configfs.h > > I thought I had this already. If someone is using it (and > fs/dlm obviously is), we should provide it for the general case. Ok, thi

Re: [ANNOUNCE] util-linux-ng 2.13-rc1

2007-07-06 Thread Joel Becker
behavior of your build system. What about futexes? Older systems don't have them. Gotta detect that. Joel -- "I'm drifting and drifting Just like a ship out on the sea. Cause I ain't got nobody, baby, In this world to care for me." Joel Becker Principal Software D

Re: [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-05 Thread Joel Becker
e should be responding with "Acked-by:", not "Signed-off-by:". Then Satyam submits the patches upstream with the Acked-by: line and his own Signed-off-by: Joel -- "Anything that is too stupid to be spoken is sung." - Voltaire Joel Becker Principal Softwar

Re: [PATCH -mm 8/9] netconsole: Update documentation for dynamic reconfigurability

2007-07-04 Thread Joel Becker
uld probably be consistent with that. Joel -- "Also, all of life's big problems include the words 'indictment' or 'inoperable.' Everything else is small stuff." - Alton Brown Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED]

Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

2007-07-04 Thread Joel Becker
on Book #396 "Never give anyone a fruitcake." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

Re: [PATCH -mm 0/3] configfs: Miscellaneous cleanups

2007-07-04 Thread Joel Becker
h (I'm currently on vacation :-) Joel -- "Well-timed silence hath more eloquence than speech." - Martin Fraquhar Tupper Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "un

Re: ThinkPad T41 - Strange USB 2.0 behaviour

2007-06-07 Thread Joel Becker
gt; suitable warning). Oh, I see. I thought you were saying "I suspect it is hardware, but maybe it isn't?" The sure workaround is a USB 1.1 hub, but having linux detect would be cool. Joel -- "Vote early and vote often." - Al Capone Joel Becker Princ

Re: ThinkPad T41 - Strange USB 2.0 behaviour

2007-06-07 Thread Joel Becker
works just fine. Joel -- Life's Little Instruction Book #274 "Leave everything a little better than you found it." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscr

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Joel Becker
folks care about file->private_data, etc. A good example is nfs_updatepage() from nfs_commit_write(). There's a context on the filp. Mapping can get back to the inode via ->host, but not to the struct file. Joel -- Life's Little Instruction Book #157 "Take time to sme

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Joel Becker
rspace<->kernel interface before you've even provided a release of the tool that detects the change! Joel -- "When ideas fail, words come in very handy." - Goethe Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To un

Re: [PATCH] configfs: add missing mutex_unlock()

2007-03-05 Thread Joel Becker
} return err; -- "Nobody loves me, Nobody seems to care. Troubles and worries, people, You know I've had my share." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line &qu

Re: [PATCH] ocfs2: fix module_init error handling

2007-03-05 Thread Joel Becker
mlog_exit(status); Also, this change suppresses some paths to mlog_exit(), which impacts people tracing. If there is an actual bug you are fixing, please tell us. We'll work with you to correct it. Joel -- Life's Little Instruction Book #451 "Don

Re: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.

2007-02-23 Thread Joel Becker
uction Book #451 "Don't be afraid to say, 'I'm sorry.'" Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

[PATCH] mm/mincore: Return EFAULT when passed an invalid address.

2007-02-23 Thread Joel Becker
The locking fix to sys_mincore in commit 2f77d107050abc14bc393b34bdb7b91cf670c250 returns -ENOMEM when given a bad userspace address. It should return -EFAULT. Signed-off-by: Joel Becker <[EMAIL PROTECTED]> diff --git a/mm/mincore.c b/mm/mincore.c index 8aca6f7..4af963c 100644 --

mincore returning -ENOMEM instead of -EFAULT

2007-02-23 Thread Joel Becker
and worries, people, You know I've had my share." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: A quick fio test (was Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3)

2007-02-23 Thread Joel Becker
s doing 1000s of blocking I/Os, I'd really be interested to see how that plays out. Joel -- Joel's Second Law: If a code change requires additional user setup, it is wrong. Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To

Re: [Linux-fbdev-devel] no backlight on radeon after recent kernel "upgrade"s

2007-02-21 Thread Joel Becker
enable the backlight. How are people supposed to Just Know that the kernel defaults to a black LCD? Joel -- Life's Little Instruction Book #407 "Every once in a while, take the scenic route." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phon

Re: [PATCH 2 of 4] Introduce i386 fibril scheduling

2007-02-06 Thread Joel Becker
"Think big thoughts, but relish small pleasures." Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 2 of 4] Introduce i386 fibril scheduling

2007-02-06 Thread Joel Becker
API, they *have* to. If there's an efficient way to get "just the ones that didn't block", then it's not a problem. Joel -- "The real reason GNU ls is 8-bit-clean is so that they can start using ISO-8859-1 option characters." - Christopher Davis ([EM

Re: [PATCH 2 of 4] Introduce i386 fibril scheduling

2007-02-06 Thread Joel Becker
quot; is inherently wrong or not a good idea. I'm saying that we need a way to flag them efficiently. Joel -- Life's Little Instruction Book #80 "Slow dance" Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To uns

Re: [PATCH 2 of 4] Introduce i386 fibril scheduling

2007-02-06 Thread Joel Becker
, and once to check if they actually went async. For longer lists of I/Os, this is expensive. Joel -- "Too much walking shoes worn thin. Too much trippin' and my soul's worn thin. Time to catch a ride it leaves today Her name is what it means. Too much walking shoes worn

  1   2   >