Re: [PATCH] rbtree: fix the red root

_color(node, NULL, RB_BLACK); break; } else if (rb_is_black(parent)) break; - gparent = rb_parent(parent); + gparent = rb_red_parent(parent); -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v4] coding-style: Clarify the expectations around bool

-- Ack from me after those two corrections. Reviewed-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] rbtree: fix the red root

reated properly a few lines above. Good catch, acked. After thinking through the logic a bit your solution seems like the simplest fix. Now, I didn't do _extensive_ testing but a quick compile and bootup of the patch with CONFIG_KASAN_INLINE enabled has yet to throw any GFPs, so take that as you

Re: [PATCH 3/4] rcutorture/nolibc: add a bit of documentation to explain how to use nolibc

On Mon, Dec 31, 2018 at 12:08:54PM -0800, Paul E. McKenney wrote: > On Sat, Dec 29, 2018 at 09:40:20PM -1000, Joey Pabalinas wrote: > > On Sun, Dec 30, 2018 at 08:08:46AM +0100, Willy Tarreau wrote: > > > Definitely! Same, I won't emit a patch just for this, P

Re: [PATCH 3/4] rcutorture/nolibc: add a bit of documentation to explain how to use nolibc

On Sun, Dec 30, 2018 at 08:08:46AM +0100, Willy Tarreau wrote: > Definitely! Same, I won't emit a patch just for this, Paul already queued it. Yeah, not that big a deal :) Reviewed-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 3/4] rcutorture/nolibc: add a bit of documentation to explain how to use nolibc

a capitalized "The" for consistency? > /* some archs (at least aarch64) don't expose the regular syscalls anymore by > * default, either because they have an "_at" replacement, or because there > are > * more modern alternatives. For now we'd rather still use them.

Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and alignment

r10", "r11", "memory", "cc" \ > );\ > _ret; \ > }) > @@ -290,7 +290,7 @@ struct stat { > : "=a" (_ret) \ > : "r"(_arg1), "r"(_arg2), "r"(_arg3), \ > "0"(_num) \ > - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" > \ > + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \ > );\ > _ret; \ > }) > -- > 2.9.0 > -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] KVM: X86: Fix scan ioapic use-before-initialization

, it requires a lot of up front work. I don't think it's realistic to expect others to be doing this instead of just subscribing to the topic lists. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [RFC] LKML Archive in Maildir Format

I'm just going to give it another go with the public-inbox conversion. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] CIFS: use the correct length when pinning memory for direct I/O for write

actually needed. > > Fix this by only pinning what are needed for doing this write I/O. > > Signed-off-by: Long Li > Cc: sta...@vger.kernel.org Looks sane to me. Reviewed-by: Joey Pabalinas > --- > fs/cifs/file.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [PATCH] Staging: nvec: nvec: fixed check style issues

incomplete messages with this delay than without >* it, but we don't know why. Help is appreciated. >*/ > - udelay(100); > + usleep_range(0, 100); > > return IRQ_HANDLED; > } > -- > 2.7.4 > -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [RFC] LKML Archive in Maildir Format

On Sun, Dec 16, 2018 at 02:55:05PM -0500, Konstantin Ryabitsev wrote: > On Sun, Dec 16, 2018 at 09:21:35AM -1000, Joey Pabalinas wrote: > > That was my first attempt, but the ducumentation for the public-inbox > > format is sort of terrible, > > I'm surprised you think so, b

Re: [RFC] LKML Archive in Maildir Format

On Sun, Dec 16, 2018 at 02:46:49PM -0500, Konstantin Ryabitsev wrote: > On Sun, Dec 16, 2018 at 09:06:39AM -1000, Joey Pabalinas wrote: > > I spent a lot of time trying to find an LKML archive in Maildir format > > that I could use for local searches with nutmuch or som

Re: [RFC] LKML Archive in Maildir Format

On Sun, Dec 16, 2018 at 11:17:34AM -0800, Joe Perches wrote: > On Sun, 2018-12-16 at 09:06 -1000, Joey Pabalinas wrote: > > I spent a lot of time trying to find an LKML archive in Maildir format > > that I could use for local searches with nutmuch or something, but all > >

[RFC] LKML Archive in Maildir Format

. Open to suggestions, thanks! -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3 0/7] zram idle page writeback

zram idle page writeback feature. Revisions look good to me. Will also try to give it some testing this week. Reviewed-by: Joey Pabalinas > * Admin can define what is idle page "no access since X time ago" > * Admin can define when zram should writeback them > * Admin can defi

Re: [PATCH v3 0/7] zram idle page writeback

zram idle page writeback feature. Revisions look good to me. Will also try to give it some testing this week. Reviewed-by: Joey Pabalinas > * Admin can define what is idle page "no access since X time ago" > * Admin can define when zram should writeback them > * Admin can defi

Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()

On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote: > Empty function will be inlined so asmlinkage doesn't do anything. Yes, that is an example of a perfect explanation to have in the commit message :) Ack from me after that addition. Acked-by: Joey Pabalinas -- Cheers, J

Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()

On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote: > Empty function will be inlined so asmlinkage doesn't do anything. Yes, that is an example of a perfect explanation to have in the commit message :) Ack from me after that addition. Acked-by: Joey Pabalinas -- Cheers, J

Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()

ine asmlinkage void dump_stack(void) > +static inline void dump_stack(void) > { > } > -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()

ine asmlinkage void dump_stack(void) > +static inline void dump_stack(void) > { > } > -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] sched/fair: Fix assignment of boolean variables

> CC: Peter Zijlstra > CC: linux-kernel@vger.kernel.org Ack, earlier assignments in the function like: if (nr_running > 1) *overload = true; use `= true`, so this change keeps things consistent. Reviewed-by: Joey Pabalinas > --- > kernel/sched/fair.c |

Re: [PATCH] sched/fair: Fix assignment of boolean variables

> CC: Peter Zijlstra > CC: linux-kernel@vger.kernel.org Ack, earlier assignments in the function like: if (nr_running > 1) *overload = true; use `= true`, so this change keeps things consistent. Reviewed-by: Joey Pabalinas > --- > kernel/sched/fair.c |

Re: [PATCH] binder: remove BINDER_DEBUG_ENTRY()

On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define > such a macro,so remove BINDER_DEBUG_ENTRY. > > Signed-off-by: Yangtao Li Good catch. Reviewed-by: Joey Pabalinas On Fri, Nov 30, 2018 at 08:2

Re: [PATCH] binder: remove BINDER_DEBUG_ENTRY()

On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define > such a macro,so remove BINDER_DEBUG_ENTRY. > > Signed-off-by: Yangtao Li Good catch. Reviewed-by: Joey Pabalinas On Fri, Nov 30, 2018 at 08:2

Re: [PATCH 26/29] x86/fpu: Inline copy_user_to_fpregs_zeroing()

On Wed, Nov 28, 2018 at 11:20:32PM +0100, Sebastian Andrzej Siewior wrote: > Start refactoring __fpu__restore_sig() by inlining > copy_user_to_fpregs_zeroing(). > > Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Desc

Re: [PATCH 26/29] x86/fpu: Inline copy_user_to_fpregs_zeroing()

On Wed, Nov 28, 2018 at 11:20:32PM +0100, Sebastian Andrzej Siewior wrote: > Start refactoring __fpu__restore_sig() by inlining > copy_user_to_fpregs_zeroing(). > > Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Desc

Re: [PATCH v1 2/2] signal: add procfd_signal() syscall

On Wed, Nov 28, 2018 at 11:05:49PM +0100, Christian Brauner wrote: > On Wed, Nov 28, 2018 at 11:45:34AM -1000, Joey Pabalinas wrote: > > On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote: > > > + if (info) { > > > + ret = __copy_si

Re: [PATCH v1 2/2] signal: add procfd_signal() syscall

On Wed, Nov 28, 2018 at 11:05:49PM +0100, Christian Brauner wrote: > On Wed, Nov 28, 2018 at 11:45:34AM -1000, Joey Pabalinas wrote: > > On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote: > > > + if (info) { > > > + ret = __copy_si

Re: [PATCH v1 2/2] signal: add procfd_signal() syscall

errors from __copy_siginfo_from_user()? Granted, I admit that -E2BIG is kind of weird to return, but -EFAULT seems like a fairly sane error. Or is there some reason it's more useful to just return -EINVAL for all of the failure cases here? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v1 2/2] signal: add procfd_signal() syscall

errors from __copy_siginfo_from_user()? Granted, I admit that -E2BIG is kind of weird to return, but -EFAULT seems like a fairly sane error. Or is there some reason it's more useful to just return -EINVAL for all of the failure cases here? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] Little memset_explicit optimisation

On Wed, Nov 28, 2018 at 06:32:27AM +, David CARLIER wrote: > Bad entrance with bad idea I m afraid :-) sorry for the noise. We all start somewhere, no worries :) -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] Little memset_explicit optimisation

On Wed, Nov 28, 2018 at 06:32:27AM +, David CARLIER wrote: > Bad entrance with bad idea I m afraid :-) sorry for the noise. We all start somewhere, no worries :) -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] selftests: add TPM 2.0 tests

On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote: > > +def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1): > > +fmt = '>HII IIH16sHBHH' > > +cmd = struct.pack(fmt, > > +

Re: [PATCH] selftests: add TPM 2.0 tests

On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote: > > +def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1): > > +fmt = '>HII IIH16sHBHH' > > +cmd = struct.pack(fmt, > > +

Re: [PATCH] selftests: add TPM 2.0 tests

_ALG_SHA1, > + digest_alg = TPM2_ALG_SHA1): > + x = [] Is there a reason for using `'\0' * 16` there instead of just 0? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] selftests: add TPM 2.0 tests

_ALG_SHA1, > + digest_alg = TPM2_ALG_SHA1): > + x = [] Is there a reason for using `'\0' * 16` there instead of just 0? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

DROP, > > }; > > I'm with Matthew, I'd prefer not: the first looks a more readable, > less cluttered comment to me than the second: this is just an arg > to an internal helper in mm/filemap.c, itself not kernel-doc'ed. > > But the comment is not there for me: if consensus is that the > second is preferable, then sure, we can change it over. For something which is internal to a single file I strongly prefer the first as well. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

DROP, > > }; > > I'm with Matthew, I'd prefer not: the first looks a more readable, > less cluttered comment to me than the second: this is just an arg > to an internal helper in mm/filemap.c, itself not kernel-doc'ed. > > But the comment is not there for me: if consensus is that the > second is preferable, then sure, we can change it over. For something which is internal to a single file I strongly prefer the first as well. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

On Tue, Nov 27, 2018 at 11:13:27AM +0900, Minchan Kim wrote: > On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote: > > On Mon, Nov 26, 2018 at 05:28:11PM +0900, Minchan Kim wrote: > > > + strlcpy(mode_buf, buf, sizeof(mode_buf)); > > > + /* ignore tra

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

On Tue, Nov 27, 2018 at 11:13:27AM +0900, Minchan Kim wrote: > On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote: > > On Mon, Nov 26, 2018 at 05:28:11PM +0900, Minchan Kim wrote: > > > + strlcpy(mode_buf, buf, sizeof(mode_buf)); > > > + /* ignore tra

Re: Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote: > On Mon, 26 Nov 2018 00:02:07 -1000 > Joey Pabalinas wrote: > > > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote: > > > The static inline function task_curr_ret_stack() is unused, remove it.

Re: Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote: > On Mon, 26 Nov 2018 00:02:07 -1000 > Joey Pabalinas wrote: > > > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote: > > > The static inline function task_curr_ret_stack() is unused, remove it.

Re: Re: [PATCH] Little memset_explicit optimisation

h -O1 (making sure to use the target variable so it isn't optimized out) and compare the assembly generated with and without that assignment. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Re: [PATCH] Little memset_explicit optimisation

h -O1 (making sure to use the target variable so it isn't optimized out) and compare the assembly generated with and without that assignment. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote: > > + if ((mode & IDLE_WRITEBACK && > > + !zram_test_flag(zram, index, ZRAM_IDLE)) && > > + (mode & HUGE_WRITEBACK && > > +

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote: > > + if ((mode & IDLE_WRITEBACK && > > + !zram_test_flag(zram, index, ZRAM_IDLE)) && > > + (mode & HUGE_WRITEBACK && > > +

Re: [PATCH] Little memset_explicit optimisation

arrier_data(s); > } > EXPORT_SYMBOL(memzero_explicit); Could you elaborate on the optimization that this patch performs? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] Little memset_explicit optimisation

arrier_data(s); > } > EXPORT_SYMBOL(memzero_explicit); Could you elaborate on the optimization that this patch performs? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

= -1`? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

= -1`? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

her useful information which could be passed back to the caller instead. I can't immediately think of any such information, though, so it's possible I'm just daydreaming :) -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2 5/7] zram: support idle/huge page writeback

her useful information which could be passed back to the caller instead. I can't immediately think of any such information, though, so it's possible I'm just daydreaming :) -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

that definitely makes sense. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

that definitely makes sense. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

t; from syscall-exit-stops using PTRACE_GETEVENTMSG request. Is there an advantage to using two constants instead of a single sys_exit bit (set/unset for syscall-exit-stop/syscall-enter-stop)? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

t; from syscall-exit-stops using PTRACE_GETEVENTMSG request. Is there an advantage to using two constants instead of a single sys_exit bit (set/unset for syscall-exit-stop/syscall-enter-stop)? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH AUTOSEL 4.14 27/30] powerpc/selftests: Wait all threads to join

ichael Ellerman > Signed-off-by: Sasha Levin Acked-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH AUTOSEL 4.14 27/30] powerpc/selftests: Wait all threads to join

ichael Ellerman > Signed-off-by: Sasha Levin Acked-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

urce code is definitely intended for the public as well. If I post an ad targeted at dog owners in my local town hall, it doesn't mean it's not intended for the public. Even though it is only for dog owners (or those who wish to be), it is still available freely to the general public. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

urce code is definitely intended for the public as well. If I post an ad targeted at dog owners in my local town hall, it doesn't mean it's not intended for the public. Even though it is only for dog owners (or those who wish to be), it is still available freely to the general public. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

vate information". > How do you reconcile working on a public project while keeping email > address secret? This is a little more delicate, and I admit that I can't really think of any real solutions for this part... -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

vate information". > How do you reconcile working on a public project while keeping email > address secret? This is a little more delicate, and I admit that I can't really think of any real solutions for this part... -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

> escalate the rhetoric --- either in the pro- or anti- CoC direction, > and whether on mailing lists, github comment threads, Twitter, or > Reddit --- is not helpful. I completely agree with this; very eagerly seconded. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

> escalate the rhetoric --- either in the pro- or anti- CoC direction, > and whether on mailing lists, github comment threads, Twitter, or > Reddit --- is not helpful. I completely agree with this; very eagerly seconded. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed

Re: [PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed

Re: [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

devices, but I don't > think it should be done for all devices. > > All in all, it won't change much. Hm, that sounds sane. I'll do a bit more research on this and see if restricting it to just Win8 devices is simple enough to be worthwhile. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

devices, but I don't > think it should be done for all devices. > > All in all, it won't change much. Hm, that sounds sane. I'll do a bit more research on this and see if restricting it to just Win8 devices is simple enough to be worthwhile. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 3/4] HID: multitouch: drop reports containing invalid values

a device that required this, so you are probably > the lucky one :) Ah, you are completely right. After giving that pdf a read over I will definitely be dropping this patch from the v2. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 3/4] HID: multitouch: drop reports containing invalid values

a device that required this, so you are probably > the lucky one :) Ah, you are completely right. After giving that pdf a read over I will definitely be dropping this patch from the v2. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

hich series on top of the other, but someone between us will > have to do it :) Somehow also missed this reply... I guess I messed up my LKML filters somewhere. Noted, thanks for the review; I'll check your trees for the refactor when (if) I do my v2. -- Cheers, Joey Pabalinas signature

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

hich series on top of the other, but someone between us will > have to do it :) Somehow also missed this reply... I guess I messed up my LKML filters somewhere. Noted, thanks for the review; I'll check your trees for the refactor when (if) I do my v2. -- Cheers, Joey Pabalinas signature

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

pecial case would be a better way to handle it, so I'll do a bit more research on the quirk thing and then revise my patches (assuming they end up as something still worth sending). Appreciate the comments, thanks. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

pecial case would be a better way to handle it, so I'll do a bit more research on the quirk thing and then revise my patches (assuming they end up as something still worth sending). Appreciate the comments, thanks. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

for a couple months without any problems, as well as being run in my Arch Linux AUR kernel package [1] without a single complaint so far. [1] https://aur.archlinux.org/packages/linux-surfacepro3-git Joey Pabalinas (4): HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks HID

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

for a couple months without any problems, as well as being run in my Arch Linux AUR kernel package [1] without a single complaint so far. [1] https://aur.archlinux.org/packages/linux-surfacepro3-git Joey Pabalinas (4): HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks HID

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

On Thu, Jul 26, 2018 at 02:55:11PM -1000, Joey Pabalinas wrote: > I thought the exact same thing; opened the thread and was a bit confused > at first. In my opinion the name feels slightly misleading. Oooh, reading more of the thread I see there is some fun wordplay going on which I didn't

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

On Thu, Jul 26, 2018 at 02:55:11PM -1000, Joey Pabalinas wrote: > I thought the exact same thing; opened the thread and was a bit confused > at first. In my opinion the name feels slightly misleading. Oooh, reading more of the thread I see there is some fun wordplay going on which I didn't

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

ot;error fs". ;-) I thought the exact same thing; opened the thread and was a bit confused at first. In my opinion the name feels slightly misleading. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

ot;error fs". ;-) I thought the exact same thing; opened the thread and was a bit confused at first. In my opinion the name feels slightly misleading. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

[PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

[PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH 0/4] reduce Surface Pro 3 multitouch jitter

The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Joey Pabalinas (4): HID: multitouch: add

[PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH 0/4] reduce Surface Pro 3 multitouch jitter

The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Joey Pabalinas (4): HID: multitouch: add

[PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --

  1   2   3   >