Re: [PATCH] timers: Make the lower-level timer function first call than higher-level

2018-11-19 Thread John Stultz
On Mon, Nov 19, 2018 at 6:10 AM, Muchun Song wrote: > The elements of the heads array are a linked list of timer events that > expire at the current time. And it can contain up to LVL_DEPTH levels > and the lower the level represents the smaller the time granularity. > > Now the result is that

Re: [PATCH] softirq: don't push timer softirq handling to ksoftirqd

2018-11-15 Thread John Stultz
On Thu, Nov 15, 2018 at 9:07 AM, Michael Zhivich wrote: > Require TIMER_SOFTIRQ to be handled immediately instead of delaying until > ksoftirqd runs, thus preventing problems with reading clocksources that > wrap often (e.g. acpi_pm). > > If acpi_pm is used as the clocksource watchdog, and

Re: [PATCH] Revert "clocksource: Make clocksource validation work for all clocksources"

2018-11-12 Thread John Stultz
On Mon, Nov 12, 2018 at 10:56 AM, Michael Zhivich wrote: > Revert commit 1f45f1f33c8c ("clocksource: Make clocksource validation work > for all clocksources") to restore correct clocksource_delta() computation > for clocksources that wrap frequently, while retaining the check for tsc > drifting.

Re: TSC to Mono-raw Drift

2018-11-01 Thread John Stultz
On Thu, Nov 1, 2018 at 10:44 AM, Thomas Gleixner wrote: > On Tue, 23 Oct 2018, John Stultz wrote: >> On Fri, Oct 19, 2018 at 3:36 PM, John Stultz wrote: >> I spent a little bit of time thinking this out. Unfortunately I don't >> think its a simple matter of calculating

Re: [patch 0/9] time: Add SPDX identifiers and cleanup boilerplates

2018-10-31 Thread John Stultz
ay by this work. > > This work is based on a script and data from Philippe Ombredanne, Kate > Stewart and myself. The data has been created with two independent license > scanners and manual inspection. Looks ok by me. Acked-by: John Stultz thanks -john

Re: [PATCH] proc: use ns_capable instead of capable for timerslack_ns

2018-10-25 Thread John Stultz
ss is > allowed to do other activities controlled by CAP_SYS_NICE inside a > namespace, it should also be able to adjust timerslack_ns. > > Signed-off-by: Benjamin Gordon > Cc: John Stultz > Cc: Kees Cook > Cc: "Serge E. Hallyn" > Cc: Thomas Gleixner >

Re: Regression: OOPs on boot due to "wlcore: Add support for optional wakeirq"

2018-10-25 Thread John Stultz
On Thu, Oct 25, 2018 at 10:04 AM, John Stultz wrote: > Hey Tony, > In testing linus/master on my hikey board, I'm hitting the following > OOPS on bootup: > > [1.870279] Unable to handle kernel read from unreadable memory at > virtual address 0010 > [1.8

Regression: OOPs on boot due to "wlcore: Add support for optional wakeirq"

2018-10-25 Thread John Stultz
Hey Tony, In testing linus/master on my hikey board, I'm hitting the following OOPS on bootup: [1.870279] Unable to handle kernel read from unreadable memory at virtual address 0010 [1.870283] Mem abort info: [1.870287] ESR = 0x9605 [1.870292] Exception class

Re: TSC to Mono-raw Drift

2018-10-23 Thread John Stultz
On Fri, Oct 19, 2018 at 3:36 PM, John Stultz wrote: > On Fri, Oct 19, 2018 at 1:50 PM, Thomas Gleixner wrote: >> John, >> >> On Fri, 19 Oct 2018, John Stultz wrote: >>> On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner >>> wrote: >>&

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 1:50 PM, Thomas Gleixner wrote: > John, > > On Fri, 19 Oct 2018, John Stultz wrote: >> On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner wrote: >> > I don't think you need complex oscillation for that. The error is constant >> > and sma

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner wrote: > On Fri, 19 Oct 2018, John Stultz wrote: >> On Fri, Oct 19, 2018 at 11:37 AM, Thomas Gleixner wrote: >> > On Fri, 19 Oct 2018, Thomas Gleixner wrote: >> >> On Mon, 15 Oct 2018, Christopher Hall wrote: >

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 11:37 AM, Thomas Gleixner wrote: > On Fri, 19 Oct 2018, Thomas Gleixner wrote: >> On Mon, 15 Oct 2018, Christopher Hall wrote: >> > TSC kHz used to calculate mult/shift value: 3312000 >> >> Now the most interesting information here would be the resulting mult/shift >>

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 11:34 AM, John Stultz wrote: > On Fri, Oct 19, 2018 at 8:25 AM, Thomas Gleixner wrote: >> Christopher, >> >> Please Cc LKML on such issues in the future. >> >> On Mon, 15 Oct 2018, Christopher Hall wrote: >> >> Leaving c

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 8:25 AM, Thomas Gleixner wrote: > Christopher, > > Please Cc LKML on such issues in the future. > > On Mon, 15 Oct 2018, Christopher Hall wrote: > > Leaving context around for new readers: > >> Problem Statement: >> >> The TSC clocksource mult/shift values are derived from

Re: [RESEND][PATCH] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-10-16 Thread John Stultz
On Tue, Oct 16, 2018 at 3:48 PM, John Stultz wrote: > On Mon, Oct 15, 2018 at 8:41 PM, Martin K. Petersen > wrote: >> >> John, >> >>> Hynix ufs has deviations on hi36xx platform which will result in ufs >>> bursts transfer failures. >> >

Re: [PATCH v2 1/2] mm: Add an F_SEAL_FS_WRITE seal to memfd

2018-10-16 Thread John Stultz
te failed as expected due to seal > : Permission denied > map 3 prot-read passed as expected > > Note: This seal will also prevent growing and shrinking of the memfd. > This is not something we do in Android so it does not affect us, however > I have mentioned this behavior of the seal in the manpage. > > Cc: jr...@google.com > Cc: john.stu...@linaro.org > Cc: tk...@google.com > Cc: gre...@linuxfoundation.org > Signed-off-by: Joel Fernandes (Google) Reviewed-by: John Stultz thanks -john

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-01 Thread John Stultz
iles for legacy devices, but I did not finish that > for this kernel cycle. > > Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor > only") > Reported-by: Leonard Crestez > Reported-by: Fabio Estevam > Reported-by: John Stultz > Reported-by: Anders Roxell > Signed-off-by: Linus Walleij This seems to solve it! Tested-by: John Stultz

Re: RESEND and REBASE arm+arm64+aarch32 vdso rewrite

2018-10-01 Thread John Stultz
On Mon, Oct 1, 2018 at 1:44 PM, Mark Salyzyn wrote: > On 10/01/2018 11:49 AM, John Stultz wrote: >> It seems the patchset is already somewhat broken up into separate >> sets, so I might recommend picking just one area and focus on >> upstreaming that first. Maybe the in-

Re: RESEND and REBASE arm+arm64+aarch32 vdso rewrite

2018-10-01 Thread John Stultz
On Mon, Oct 1, 2018 at 10:58 AM, Mark Salyzyn wrote: > Last sent 23 Nov 2016. > > The following 23 patches are rebased and resent, and represent a > rewrite of the arm and arm64 vDSO into C, adding support for arch32 > (32-bit user space hosted 64-bit kernels) and into a common library > that

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-28 Thread John Stultz
On Thu, Sep 6, 2018 at 6:01 AM Linus Walleij wrote: > > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. > >

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-09-25 Thread John Stultz
On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan wrote: > Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey > regression caused by power_down feature" > https://marc.info/?l=linux-usb=152669095513248=2 > > the power_down is disabled setting "p->power_down = false;" in >

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-09-24 Thread John Stultz
On Sun, Sep 23, 2018 at 10:57 PM, Artur Petrosyan wrote: > Hi John, > > On 9/21/2018 05:05, John Stultz wrote: >> On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan >> wrote: >>> On 5/23/2018 01:57, John Stultz wrote: >>>> Its done automatically,

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

2018-09-17 Thread John Stultz
On Mon, Sep 17, 2018 at 12:25 PM, Andy Lutomirski wrote: > On Fri, Sep 14, 2018 at 5:50 AM, Thomas Gleixner wrote: >> The code flow for the vclocks is convoluted as it requires the vclocks >> which can be invalidated separately from the vsyscall_gtod_data sequence to >> store the fact in a

Re: [RESEND PATCH] x86/vdso: Handle clock_gettime(CLOCK_TAI) in vDSO

2018-08-24 Thread John Stultz
On Fri, Aug 24, 2018 at 10:47 AM, Andy Lutomirski wrote: > Minor nit: if it's not literally a resend, don't call it "RESEND" in > $SUBJECT. Call it v2, please. > > Also, I added LKML and relevant maintainers to cc. John and Stephen: > this is a purely x86 patch, but it digs into the core

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

2018-08-16 Thread John Stultz
On Thu, Aug 16, 2018 at 11:37 AM, Tuomas Tynkkynen wrote: > Hi, > > On 08/16/2018 08:57 PM, John Stultz wrote: >> >> On Thu, Aug 16, 2018 at 3:22 AM, Will Deacon wrote: >>> >>> Hi Tuomas, [+John] > > ... >>> >>> >>> Out of i

Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"

2018-08-16 Thread John Stultz
y, > insn = aarch64_insn_gen_nop(); > } > > - aarch64_insn_patch_text(, , 1); > + aarch64_insn_patch_text_nosync(addr, insn); > } > > void arch_jump_label_transform_static(struct jump_entry *entry, Yes, this works for me as well. Tested-by: John Stultz thanks so much! -john

Re: [GIT PULL] arm64: updates for 4.19

2018-08-15 Thread John Stultz
On Tue, Aug 14, 2018 at 4:36 AM, Will Deacon wrote: > > Please pull these arm64 updates for 4.19. Details in the tag, but please be > aware that we've pulled in the x86/mm branch from -tip so that we can make > use of the core ioremap changes which allow us to put down huge mappings > in the

Re: Linux 4.18-rc7

2018-08-02 Thread John Stultz
On Wed, Aug 1, 2018 at 2:55 PM, Hugh Dickins wrote: > On Wed, 1 Aug 2018, Kirill A. Shutemov wrote: >> On Wed, Aug 01, 2018 at 11:31:52AM -0700, Hugh Dickins wrote: >> > On Wed, 1 Aug 2018, Linus Torvalds wrote: >> > > >> > > Anyway, the upshot of all this is that I think I know what the ia64 >>

[PATCH] staging: ashmem: Fix SIGBUS crash when traversing mmaped ashmem pages

2018-07-31 Thread John Stultz
fix vma_is_anonymous() false-positives") Reported-by: Amit Pundir Reported-by: Youling 257 Signed-off-by: John Stultz --- Hopefully my explanation make sense here. Please let me know if it needs corrections. thanks -john --- drivers/staging/android/ashmem.c | 2 ++ 1 file changed, 2

Re: Linux 4.18-rc7

2018-07-31 Thread John Stultz
On Tue, Jul 31, 2018 at 9:29 AM, Linus Torvalds wrote: > On Mon, Jul 30, 2018 at 11:40 PM Amit Pundir wrote: >> >> This ashmem change ^^ worked too. > > Ok, let's go for that one and hope it's the only one. > > John, can I get a proper commit message and sign-off for that ashmem change? Will

Re: Linux 4.18-rc7

2018-07-30 Thread John Stultz
On Mon, Jul 30, 2018 at 8:26 PM, Hugh Dickins wrote: > On Mon, 30 Jul 2018, Linus Torvalds wrote: >> On Mon, Jul 30, 2018 at 2:53 PM Hugh Dickins wrote: >> > >> > I have no problem with reverting -rc7's vma_is_anonymous() series. >> >> I don't think we need to revert the whole series: I think

[PATCH 4/5] time: Fix extra sleeptime injection when suspend fails

2018-07-19 Thread John Stultz
gic properly. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Originally-by: Thomas Gleixner Signed-off-by: Mukesh Ojha Signed-off-by: John Stultz --- kernel/time/timekeeping.c | 32 +--- 1 file

[PATCH 5/5] time: Introduce one suspend clocksource to compensate the suspend time

2018-07-19 Thread John Stultz
Boyd Cc: Daniel Lezcano Reviewed-by: Thomas Gleixner Reviewed-by: Daniel Lezcano Suggested-by: Thomas Gleixner Signed-off-by: Baolin Wang [jstultz: minor tweaks to merge with previous resume changes] Signed-off-by: John Stultz --- include/linux/clocksource.h | 3 + kernel/time/clocksource.c

[PATCH 3/5] timekeeping/ntp: Constify some function arguments

2018-07-19 Thread John Stultz
-existing checkpatch warnings for prototype arguments with no variable name] Signed-off-by: John Stultz --- include/linux/timekeeping.h| 2 +- kernel/time/ntp.c | 6 +++--- kernel/time/ntp_internal.h | 4 ++-- kernel/time/timekeeping.c | 29

[PATCH 2/5] ntp: Use kstrtos64 for s64 variable

2018-07-19 Thread John Stultz
From: Ondrej Mosnacek ...instead of kstrtol with a dirty cast. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Signed-off-by: Ondrej Mosnacek Signed-off-by: John Stultz --- kernel/time/ntp.c | 5 ++--- 1 file changed, 2

[GIT PULL][PATCH 0/5] A few more timekeeping items for 4.19

2018-07-19 Thread John Stultz
The following changes since commit c6bb11147eb09bd39f316c6062455b88c905ab6e: Merge branch 'fortglx/4.19/time' of https://git.linaro.org/people/john.stultz/linux into timers/core (2018-07-12 22:19:58 +0200) are available in the git repository at:

[PATCH 1/5] ntp: Remove redundant arguments

2018-07-19 Thread John Stultz
-by: John Stultz --- kernel/time/ntp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c index 10a7905..3eddac2 100644 --- a/kernel/time/ntp.c +++ b/kernel/time/ntp.c @@ -642,7 +642,7 @@ void ntp_notify_cmos_timer(void

Re: [PATCH 1/2] time: Introduce one suspend clocksource to compensate the suspend time

2018-07-17 Thread John Stultz
On Tue, Jul 17, 2018 at 12:55 AM, Baolin Wang wrote: > On some hardware with multiple clocksources, we have coarse grained > clocksources that support the CLOCK_SOURCE_SUSPEND_NONSTOP flag, but > which are less than ideal for timekeeping whereas other clocksources > can be better candidates but

Re: [PATCH v5] time: Fix extra sleeptime injection when suspend fails

2018-07-17 Thread John Stultz
On Mon, Jul 16, 2018 at 11:31 PM, Mukesh Ojha wrote: > Currently, there exists a corner case assuming when there is > only one clocksource e.g RTC, and system failed to go to > suspend mode. While resume rtc_resume() injects the sleeptime > as timekeeping_rtc_skipresume() returned 'false'

Re: [PATCH v4] time: Fix extra sleeptime injection when suspend fails

2018-07-16 Thread John Stultz
On Mon, Jul 16, 2018 at 1:40 PM, Mukesh Ojha wrote: > Currently, there exists a corner case assuming when there is > only one clocksource e.g RTC, and system failed to go to > suspend mode. While resume rtc_resume() injects the sleeptime > as timekeeping_rtc_skipresume() returned 'false' (default

Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

2018-07-16 Thread John Stultz
On Mon, Jul 16, 2018 at 11:30 AM, Mukesh Ojha wrote: > > > On 7/16/2018 10:44 PM, John Stultz wrote: >> >> On Mon, Jul 16, 2018 at 9:30 AM, John Stultz >> wrote: >>> >>> On Mon, Jul 16, 2018 at 9:17 AM, Mukesh Ojha >>> wro

Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

2018-07-16 Thread John Stultz
On Mon, Jul 16, 2018 at 9:30 AM, John Stultz wrote: > On Mon, Jul 16, 2018 at 9:17 AM, Mukesh Ojha wrote: >> On 7/13/2018 10:50 PM, John Stultz wrote: >>> On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha >>>> On 7/11/2018 1:43 AM, John Stultz wrote: >>>&

Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

2018-07-16 Thread John Stultz
On Mon, Jul 16, 2018 at 9:17 AM, Mukesh Ojha wrote: > On 7/13/2018 10:50 PM, John Stultz wrote: >> On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha >>> On 7/11/2018 1:43 AM, John Stultz wrote: >>>> I worry this upside-down logic is too subtle to be easily reasoned

Re: [PATCH 1/3] ntp: Remove redundant arguments

2018-07-13 Thread John Stultz
On Fri, Jul 13, 2018 at 5:06 AM, Ondrej Mosnacek wrote: > The 'ts' argument of process_adj_status() and process_adjtimex_modes() > is unused and can be safely removed. > > Signed-off-by: Ondrej Mosnacek Thanks for sending this set along. I'll queue them up for closer review and testing. thanks

Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

2018-07-13 Thread John Stultz
On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha wrote: > Hi John, > > Thanks for your response > Please find my comments inline. > > > On 7/11/2018 1:43 AM, John Stultz wrote: >> >> On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote: >>> >>>

Re: [GIT PULL][PATCH 0/2] Few timekeeping items for 4.19

2018-07-12 Thread John Stultz
On Thu, Jul 12, 2018 at 1:26 PM, Thomas Gleixner wrote: > On Thu, 12 Jul 2018, John Stultz wrote: > >> I had a few other items in my stack here, but you've already >> queued them in -tip, so here's what I have left. > > Did I miss you replying on them that you picked

[PATCH 2/2] timekeeping: Update multiplier when NTP frequency is set directly

2018-07-12 Thread John Stultz
: Stephen Boyd Signed-off-by: Miroslav Lichvar Signed-off-by: John Stultz --- kernel/time/timekeeping.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 4786df9..6772011 100644

[PATCH 1/2] selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress

2018-07-12 Thread John Stultz
cause false negatives. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Cc: Shuah Khan Cc: linux-kselft...@vger.kernel.org Suggested-by: Miroslav Lichvar Signed-off-by: John Stultz --- v2: Widened the checks to look for other

[GIT PULL][PATCH 0/2] Few timekeeping items for 4.19

2018-07-12 Thread John Stultz
fortglx/4.19/time for you to fetch changes up to b061c7a513afe14a68af41cec7c3476befc40e95: timekeeping: Update multiplier when NTP frequency is set directly (2018-07-10 12:44:25 -0700) John Stultz (1): selftest: timers: Tweak

Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

2018-07-10 Thread John Stultz
On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote: > Currently, there exists a corner case assuming when there is > only one clocksource e.g RTC, and system failed to go to > suspend mode. While resume rtc_resume() injects the sleeptime > as timekeeping_rtc_skipresume() returned 'false' (default

[RFC][PATCH v2] selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress

2018-07-05 Thread John Stultz
that we don't cause false negatives. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Cc: Shuah Khan Cc: linux-kselft...@vger.kernel.org Suggested-by: Miroslav Lichvar Signed-off-by: John Stultz --- v2: Widened the checks to look

[RFC][PATCH] selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET is in progress

2018-07-03 Thread John Stultz
. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit Bhargava Cc: Stephen Boyd Cc: Shuah Khan Cc: linux-kselft...@vger.kernel.org Suggested-by: Miroslav Lichvar Signed-off-by: John Stultz --- tools/testing/selftests/timers/raw_skew.c | 9 - 1 file

Re: hrtimer become inaccurate with RT patch

2018-07-02 Thread John Stultz
On Mon, Jul 2, 2018 at 2:34 AM, gengdongjiu wrote: > Hi Thomas/Anna/John, > > Recently I found that the hrtimer become inaccurate when there is a RT > process runs on the same cpu core, and the kernel has applied preempt_rt > patch. > The Linux kernel version is v4.1.46, and the preempt_rt

Re: [patch 1/2] posix-timers: Make forward callback return s64

2018-06-28 Thread John Stultz
; Reported-by: air icy > Signed-off-by: Thomas Gleixner Looks ok, and doesn't trip any regressions in testing so far. Acked-by: John Stultz thanks -john

Re: [patch 2/2] posix-timers: Sanitize overrun handling

2018-06-28 Thread John Stultz
d doesn't trip any regressions in testing so far. Acked-by: John Stultz thanks -john

Re: [PATCH 1/8] time: Add persistent clock support

2018-06-25 Thread John Stultz
On Sat, Jun 23, 2018 at 5:14 PM, Thomas Gleixner wrote: > On Wed, 13 Jun 2018, Baolin Wang wrote: >> Moreover we can register the clocksource with CLOCK_SOURCE_SUSPEND_NONSTOP >> to be one persistent clock, then we can simplify the suspend/resume >> accounting by removing

Re: [PATCHv2] timekeeping: Update multiplier when NTP frequency is set directly

2018-06-22 Thread John Stultz
On Fri, Jun 22, 2018 at 2:09 PM, Thomas Gleixner wrote: > On Mon, 4 Jun 2018, Miroslav Lichvar wrote: > >> When the NTP frequency is set directly from userspace using the >> ADJ_FREQUENCY or ADJ_TICK timex mode, immediately update the >> timekeeper's multiplier instead of waiting for the next

Re: OOPSes in mem_cgroup_protected

2018-06-13 Thread John Stultz
On Tue, Jun 12, 2018 at 9:33 PM, Roman Gushchin wrote: > On Tue, Jun 12, 2018 at 09:08:27PM -0700, John Stultz wrote: >> On Tue, Jun 12, 2018 at 6:02 PM, John Stultz wrote: >> > Hey Tejun, >> > With the current linus/master, I'm able to fairly regularly trip >

Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities

2018-06-13 Thread John Stultz
neously fail with -EACCES. > > Signed-off-by: Ryan Grachek Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power") Tested-by: John Stultz Acked-by: John Stultz Wei Xu: This fixes a functional regression with wifi on the HiKey board that was introduced in 4.18-rc with

Re: REGRESSION: "wlcore: sdio: allow pm to handle sdio power" breaks wifi on HiKey960

2018-06-13 Thread John Stultz
On Wed, Jun 13, 2018 at 7:42 AM, Valentin Schneider wrote: > On 13/06/18 05:13, Tony Lindgren wrote: >> * John Stultz [180612 22:15]: >>> Hey Folks, >>> I noticed with linus/master wifi wasn't coming up on HiKey960. I >>> bisected it down and it seem

Re: OOPSes in mem_cgroup_protected

2018-06-12 Thread John Stultz
On Tue, Jun 12, 2018 at 6:02 PM, John Stultz wrote: > Hey Tejun, > With the current linus/master, I'm able to fairly regularly trip > OOPSes (two examples below) in mem_cgroup_protected(), which seems to > be new. I haven't managed to trigger this sort of thing with v4.17. >

Re: REGRESSION: "wlcore: sdio: allow pm to handle sdio power" breaks wifi on HiKey960

2018-06-12 Thread John Stultz
On Tue, Jun 12, 2018 at 3:12 PM, John Stultz wrote: > Hey Folks, > I noticed with linus/master wifi wasn't coming up on HiKey960. I > bisected it down and it seems to be due to: > > 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power") and > 728a9dc61f13 (&q

OOPSes in mem_cgroup_protected

2018-06-12 Thread John Stultz
Hey Tejun, With the current linus/master, I'm able to fairly regularly trip OOPSes (two examples below) in mem_cgroup_protected(), which seems to be new. I haven't managed to trigger this sort of thing with v4.17. I've not had much time to dig in or bisect it - I only know that enabling most

Re: REGRESSION?: debugfs: inode: debugfs_create_dir uses mode permission from parent

2018-06-12 Thread John Stultz
On Tue, Jun 12, 2018 at 3:52 PM, Kees Cook wrote: > On Tue, Jun 12, 2018 at 3:40 PM, John Stultz wrote: >> Hey all, >> I noticed recently that linus/master (plus patches) stopped booting >> to UI on HiKey960, and I bisected the issue down to: >> 92

REGRESSION?: debugfs: inode: debugfs_create_dir uses mode permission from parent

2018-06-12 Thread John Stultz
Hey all, I noticed recently that linus/master (plus patches) stopped booting to UI on HiKey960, and I bisected the issue down to: 92170b62f1c1 ("debugfs: inode: debugfs_create_dir uses mode permission from parent") On the HiKey960 board, we mount debugfs via: mount debugfs /sys/kernel/debug

REGRESSION: "wlcore: sdio: allow pm to handle sdio power" breaks wifi on HiKey960

2018-06-12 Thread John Stultz
Hey Folks, I noticed with linus/master wifi wasn't coming up on HiKey960. I bisected it down and it seems to be due to: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power") and 728a9dc61f13 ("wlcore: sdio: Fix flakey SDIO runtime PM handling") When wifi fails to load, the only useful

Re: Userland breakage from "Modify the device name as devfreq(X) for sysfs"

2018-05-30 Thread John Stultz
On Wed, May 30, 2018 at 12:31 AM, Greg KH wrote: > On Tue, May 29, 2018 at 11:52:37PM -0700, John Stultz wrote: >> On Tue, May 29, 2018 at 10:33 PM, Greg KH wrote: >> > On Tue, May 29, 2018 at 10:14:35PM -0700, John Stultz wrote: >> >> On Tue, May 8, 2018 at 7:28

Re: Userland breakage from "Modify the device name as devfreq(X) for sysfs"

2018-05-30 Thread John Stultz
On Tue, May 29, 2018 at 10:33 PM, Greg KH wrote: > On Tue, May 29, 2018 at 10:14:35PM -0700, John Stultz wrote: >> On Tue, May 8, 2018 at 7:28 PM, Chanwoo Choi wrote: >> > On 2018년 05월 09일 08:17, John Stultz wrote: >> >> Hey folks, >> >> I wanted t

Re: Userland breakage from "Modify the device name as devfreq(X) for sysfs"

2018-05-29 Thread John Stultz
On Tue, May 8, 2018 at 7:28 PM, Chanwoo Choi wrote: > On 2018년 05월 09일 08:17, John Stultz wrote: >> Hey folks, >> I wanted to bring up an issue we've recently tripped over, which was >> caused by 4585fbcb5331f ("PM / devfreq: Modify the device name as >> devfreq

Re: [PATCH RESEND] time: Fix sleeptime injection for non-stop clocksource & persistent clock

2018-05-29 Thread John Stultz
On Tue, May 29, 2018 at 2:49 AM, Mukesh Ojha wrote: > Currently, for both non-stop clocksource and persistent clock > there is a corner case, when a driver failed to go suspend mode > rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume() > returned 'false' due to which we can see

Re: [PATCHv1] timekeeping: Update multiplier when NTP frequency is set directly

2018-05-29 Thread John Stultz
n-deterministic delay in setting of the > frequency and allows an extremely tight control of the system clock > with update rates close to or even exceeding the kernel HZ. > > Cc: Thomas Gleixner > Cc: John Stultz > Cc: Richard Cochran > Cc: Prarit Bhargava > Signed-of

[PATCH] arm64: dts: hikey: Fix eMMC corruption regression

2018-05-25 Thread John Stultz
ergmann <a...@arndb.de> Cc: Ulf Hansson <ulf.hans...@linaro.org> Cc: YongQin Liu <yongqin@linaro.org> Cc: Leo Yan <leo@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - 1 file changed, 1 del

Re: [PATCH RFC] timekeeping: Update multiplier when NTP frequency is set directly

2018-05-23 Thread John Stultz
On Wed, May 23, 2018 at 4:33 AM, Miroslav Lichvar wrote: > When the NTP frequency is set directly from userspace using the > ADJ_FREQUENCY or ADJ_TICK timex mode, immediately update the > timekeeper's multiplier instead of waiting for the next tick. > > This removes a hidden

Re: [PATCH] misc: st_core: Fix skb double free corruption

2018-05-22 Thread John Stultz
On Tue, May 22, 2018 at 7:39 PM, Pengcheng Li wrote: > St_gdata->list[chnl_id]->recv function pointer to hci_recv_frame interface, > hci_recv_frame interface releases skb buffer in case of exception. Thanks for sending out this patch! However, you could probably use a

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-22 Thread John Stultz
d, but I didn't wait long enough for the reset to complete and the mouse to be detected before re-plugging in the OTG port. > On 5/21/2018 11:41 PM, John Stultz wrote: >> On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan >> <minas.harutyun...@synopsys.com> wrote: >>>

[PATCH v2] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-21 Thread John Stultz
gets thing working again. Cc: John Youn <johny...@synopsys.com> Cc: Minas Harutyunyan <minas.harutyun...@synopsys.com> Cc: Artur Petrosyan <art...@synopsys.com> Cc: Grigor Tovmasyan <tovma...@synopsys.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: linux-...@vg

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-21 Thread John Stultz
On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan <minas.harutyun...@synopsys.com> wrote: > Hi John, > > On 5/19/2018 4:49 AM, John Stultz wrote: >> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down") >> caused the HiKey board to not correctly h

Re: REGRESSION: HiKey eMMC corruption

2018-05-21 Thread John Stultz
On Mon, May 21, 2018 at 1:34 AM, Wei Xu <xuw...@hisilicon.com> wrote: > On 2018/5/18 23:59, John Stultz wrote: >> The last few months have been busy and I've not been ontop of my >> upstream testing as well as I'd like, but today I did manage to chase >> down an issue

Re: REGRESSION: HiKey eMMC corruption

2018-05-21 Thread John Stultz
On Mon, May 21, 2018 at 2:03 AM, Leo Yan <leo@linaro.org> wrote: > Hi Wei, John, > > On Mon, May 21, 2018 at 09:34:04AM +0100, Wei Xu wrote: >> Hi John, >> >> On 2018/5/18 23:59, John Stultz wrote: >> > The last few months have been busy and I've

[PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

2018-05-18 Thread John Stultz
gets thing working again. Cc: John Youn <johny...@synopsys.com> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Artur Petrosyan <art...@synopsys.com> Cc: Grigor Tovmasyan <tovma...@synopsys.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: linux-...@vger.kernel.

REGRESSION: HiKey eMMC corruption

2018-05-18 Thread John Stultz
The last few months have been busy and I've not been ontop of my upstream testing as well as I'd like, but today I did manage to chase down an issue I've been seeing since 4.17-rc1 on the HiKey board, which was causing emmc corruption and stopping the board from booting. Symptoms usually looked

Userland breakage from "Modify the device name as devfreq(X) for sysfs"

2018-05-08 Thread John Stultz
Hey folks, I wanted to bring up an issue we've recently tripped over, which was caused by 4585fbcb5331f ("PM / devfreq: Modify the device name as devfreq(X) for sysfs"). https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=4585fbcb5331fc910b7e553ad3efd0dd7b320d14

Re: possible BUG: selftest about raw_skew failed

2018-04-26 Thread John Stultz
On Sat, Apr 21, 2018 at 7:47 AM, Jeffrin Thalakkottoor wrote: > hello, > > failure of a test in selftest:timers > > selftests: raw_skew > > WARNING: ADJ_OFFSET in progress, this will cause inaccurate results > Estimating clock

Re: [RFC/RFT patch 0/7] timekeeping: Unify clock MONOTONIC and clock BOOTTIME

2018-04-23 Thread John Stultz
On Mon, Apr 23, 2018 at 7:45 PM, Genki Sky wrote: > Quoting Genki Sky (2018/04/23 20:40:36 -0400) >> I came across this thread for same reason as [0]: Daemons getting >> killed by systemd on resume (after >WatchdogSec seconds of >> suspending). I'm using master branch of systemd

Re: [RFC/RFT patch 0/7] timekeeping: Unify clock MONOTONIC and clock BOOTTIME

2018-03-13 Thread John Stultz
On Mon, Mar 12, 2018 at 11:36 PM, Ingo Molnar wrote: > > * Linus Torvalds wrote: > >> On Thu, Mar 1, 2018 at 8:33 AM, Thomas Gleixner wrote: >> > >> > This really needs lot of testing, documentation updates and more input from

[PATCH 1/4] timekeeping: Don't align frequency adjustments to ticks

2018-03-09 Thread John Stultz
ich...@redhat.com> Cc: Richard Cochran <richardcoch...@gmail.com> Cc: Prarit Bhargava <pra...@redhat.com> Cc: Stephen Boyd <stephen.b...@linaro.org> Signed-off-by: Miroslav Lichvar <mlich...@redhat.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- kernel/t

[PATCH 4/4] x86: rtc: Stop using rtc deprecated functions

2018-03-09 Thread John Stultz
t; Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com> Signed-off-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> --- arch/x86/kernel/rtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ar

[PATCH 3/4] y2038: time: Introduce struct __kernel_old_timeval

2018-03-09 Thread John Stultz
a...@redhat.com> Cc: Stephen Boyd <stephen.b...@linaro.org> Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: John Stultz <john.stu...@linaro.org> --- include/linux/time32.h| 1 + include/uapi/linux/time.h | 12 kernel/time/time.c| 12 +

[GIT PULL][PATCH 0/4] Timekeeping queue for 4.17

2018-03-09 Thread John Stultz
Hey Thomas, Just wanted to send along my timekeeping queue for 4.17. Its a bit short, and I want to apologize as I've not had much time for maintanance and review work. I worry if my current workload levels persist, I might need to downgrade my status in the maintainers file, as I'm not

[PATCH 2/4] timekeeping: Determine multiplier directly from NTP tick length

2018-03-09 Thread John Stultz
...@linaro.org> Signed-off-by: Miroslav Lichvar <mlich...@redhat.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- include/linux/timekeeper_internal.h | 2 + kernel/time/timekeeping.c | 138 2 files changed, 49 inse

Re: [PATCH] Bluetooth: hci_serdev: Init hci_uart proto_lock to avoid oops

2018-01-02 Thread John Stultz
On Mon, Dec 11, 2017 at 1:49 PM, John Stultz <john.stu...@linaro.org> wrote: > On Thu, Nov 16, 2017 at 10:07 PM, Marcel Holtmann <mar...@holtmann.org> wrote: >> Hi Lukas, >> >>> John Stultz reports a boot time crash with the HiKey board (which uses >>>

[PATCH v3] staging: ion: Fix ion_cma_heap allocations

2017-12-15 Thread John Stultz
.@codeaurora.org> Cc: Greg KH <gre...@linuxfoundation.org> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Todd Kjos <tk...@google.com> Cc: Amit Pundir <amit.pun...@linaro.org> Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly&

[PATCH v2] staging: ion: Fix ion_cma_heap allocations

2017-12-13 Thread John Stultz
.@codeaurora.org> Cc: Greg KH <gre...@linuxfoundation.org> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Todd Kjos <tk...@google.com> Cc: Amit Pundir <amit.pun...@linaro.org> Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly&

Re: [PATCH] Bluetooth: hci_serdev: Init hci_uart proto_lock to avoid oops

2017-12-11 Thread John Stultz
On Thu, Nov 16, 2017 at 10:07 PM, Marcel Holtmann <mar...@holtmann.org> wrote: > Hi Lukas, > >> John Stultz reports a boot time crash with the HiKey board (which uses >> hci_serdev) occurring in hci_uart_tx_wakeup(). That function is >> contained in hci_ldisc.c,

[PATCH] staging: ion: Fix ion_cma_heap allocations

2017-12-08 Thread John Stultz
.@codeaurora.org> Cc: Greg KH <gre...@linuxfoundation.org> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Todd Kjos <tk...@google.com> Cc: Amit Pundir <amit.pun...@linaro.org> Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly&

Re: [RFC][PATCH] staging: ion: Fix ion_cma_heap allocations

2017-12-07 Thread John Stultz
On Thu, Dec 7, 2017 at 4:55 PM, Laura Abbott <labb...@redhat.com> wrote: > On 12/07/2017 03:42 PM, John Stultz wrote: >> >> In trying to add support for drm_hwcomposer to HiKey, >> I've needed to utilize the ION CMA heap, and I've noticed >> problems with all

[RFC][PATCH] staging: ion: Fix ion_cma_heap allocations

2017-12-07 Thread John Stultz
inaro.org> Cc: Archit Taneja <arch...@codeaurora.org> Cc: Greg KH <gre...@linuxfoundation.org> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Todd Kjos <tk...@google.com> Cc: Amit Pundir <amit.pun...@linaro.org> Signed-off-by

Re: [RFC][PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-28 Thread John Stultz
On Sun, Nov 26, 2017 at 4:56 AM, Archit Taneja <arch...@codeaurora.org> wrote: > > On 11/17/2017 04:29 AM, John Stultz wrote: >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> index 0e14f15..939c3b9 1

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-22 Thread John Stultz
t; Based on earlier patches from Arnd and John. > > Reported-by: Naresh Kamboju <naresh.kamb...@linaro.org> > Cc: Xinliang Liu <xinliang@linaro.org> > Cc: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Sean Paul <seanp...@chromium.org> > Cc: Archit Taneja &l

Re: [PATCHv2] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-20 Thread John Stultz
t; Based on earlier patches from Arnd and John. > > Reported-by: Naresh Kamboju <naresh.kamb...@linaro.org> > Cc: Xinliang Liu <xinliang@linaro.org> > Cc: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Sean Paul <seanp...@chromium.org> > Cc: Archit Taneja &l

  1   2   3   4   5   6   7   8   9   10   >