Re: [GIT PULL] NTB bug fixes for v5.11

2021-01-04 Thread Jon Mason
On Mon, Jan 4, 2021 at 3:31 AM Dan Carpenter wrote: > > On Sun, Dec 27, 2020 at 09:38:23AM -0800, Linus Torvalds wrote: > > On Sun, Dec 27, 2020 at 6:16 AM Jon Mason wrote: > > > > > > Wang Qing (1): > > > ntb: idt: fix error check in ntb_hw_idt.c >

[GIT PULL] NTB bug fixes for v5.11

2020-12-27 Thread Jon Mason
Hello Linus, Here are a few NTB bug fixes for v5.11. Please consider pulling them. Thanks, Jon The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://github.com/jonmason/ntb tags

Re: [PATCH] ntb: idt: fix error check in ntb_hw_idt.c

2020-12-06 Thread Jon Mason
On Tue, Nov 10, 2020 at 09:33:40PM +0300, Serge Semin wrote: > Hello Wang > > On Fri, Nov 06, 2020 at 05:43:31PM +0800, Wang Qing wrote: > > idt_create_dev never return NULL and fix smatch warning. > > Thanks for submitting this. For the both changes > Acked-by: Serge Semin Applied to the ntb b

[GIT PULL] NTB bug fixes for v5.10

2020-10-25 Thread Jon Mason
Hello Linus, Here are a few NTB bug fixes for v5.10. Please consider pulling them. Thanks, Jon The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd: Linux 5.9-rc2 (2020-08-23 14:08:43 -0700) are available in the Git repository at: git://github.com/jonmason/ntb tags/

Re: [PATCH][next] NTB: Use struct_size() helper in devm_kzalloc()

2020-08-24 Thread Jon Mason
On Fri, Jun 19, 2020 at 01:10:55PM -0600, Logan Gunthorpe wrote: > > > On 2020-06-19 11:25 a.m., Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > > in order to avoid any potential type mistakes. Also, remove unnecessary > > variable _struct_si

Re: [RESEND] NTB: hw: amd: fix an issue about leak system resources

2020-08-24 Thread Jon Mason
On Tue, Aug 11, 2020 at 09:59:57AM +0800, Kaige Li wrote: > The related system resources were not released when pci_set_dma_mask(), > pci_set_consistent_dma_mask(), or pci_iomap() return error in the > amd_ntb_init_pci() function. Add pci_release_regions() to fix it. > > Signed-off-by: Kaige Li

Re: [PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe

2020-08-24 Thread Jon Mason
On Mon, Aug 24, 2020 at 07:37:56AM -0700, Dave Jiang wrote: > > > On 8/22/2020 11:55 PM, Dinghao Liu wrote: > > The default error branch of a series of pdev_is_gen calls > > should free ndev just like what we've done in these calls. > > > > Signed-off-by: Dinghao Liu > > Thanks Dinghao > Acked

[GIT PULL] NTB patches for v5.8

2020-06-07 Thread Jon Mason
Hello Linus, Here are a lot of NTB bug fixes and Intel Icelake for v5.8. Please consider pulling them. Thanks, Jon The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at: git://github.

Re: [PATCH] NTB: correct ntb_peer_spad_addr and ntb_peer_spad_read comment typos

2020-05-31 Thread Jon Mason
On Tue, May 26, 2020 at 03:59:43PM +0800, Wesley Sheng wrote: > The comment for ntb_peer_spad_addr and ntb_peer_spad_read > incorrectly referred to peer doorbell register and local > scratchpad register. > > Signed-off-by: Wesley Sheng Pulled into the ntb branch Thanks, Jon > --- > include/li

Re: [PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

2020-05-31 Thread Jon Mason
On Tue, May 05, 2020 at 11:21:47PM -0500, Sanjay R Mehta wrote: > v3: > - Increased ntb_perf command re-try sleep time > - avoid false dma unmap of dst address. > > v2: Incorporated improvements suggested by Logan Gunthorpe Pulled into the ntb branch. Thanks, Jon > > Links of the review comme

[GIT PULL] NTB changes for v5.4

2019-09-26 Thread Jon Mason
Hello Linus, Here are a few NTB bug fixes and a new AMD device support for v5.4. Please consider pulling them. Thanks, Jon The following changes since commit 4d856f72c10ecb060868ed10ff1b1453943fc6c8: Linux 5.3 (2019-09-15 14:19:32 -0700) are available in the Git repository at: git://gi

Re: [PATCH] NTB: fix IDT Kconfig typos/spellos

2019-09-23 Thread Jon Mason
On Wed, Sep 18, 2019 at 1:58 PM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix typos in drivers/ntb/hw/idt/Kconfig. > Use consistent spelling and capitalization. > > Fixes: bf2a952d31d2 ("NTB: Add IDT 89HPESxNTx PCIe-switches support") > Signed-off-by: R

Re: [PATCH 2/2] ntb_hw_amd: Add memory window support for new AMD hardware

2019-09-23 Thread Jon Mason
On Sun, Sep 15, 2019 at 10:08 AM Mehta, Sanju wrote: > > From: Sanjay R Mehta > > The AMD new hardware uses BAR23 and BAR45 as memory windows > as compared to previos where BAR1, BAR23 and BAR45 is used > for memory windows. > > This patch add support for both AMD hardwares. I pulled both of the

Re: [PATCH] NTB: ntb_transport: remove redundant assignment to rc

2019-09-10 Thread Jon Mason
On Sun, Aug 18, 2019 at 7:53 PM Colin King wrote: > > From: Colin Ian King > > Variable rc is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can be > removed. Applied to ntb-next, thanks > Addresses-Coverity: ("Unused value") > Signe

Re: [PATCH] point to right memory window index

2019-09-10 Thread Jon Mason
On Wed, Apr 10, 2019 at 11:24 AM Mehta, Sanju wrote: > > Hi All, > > Any comments on below patch? I wasn't cc'ed, so this one missed my inbox. Applied to ntb-next, thanks. > > Thanks & Regards, > Sanjay Mehta > > -Original Message- > From: Mehta, Sanju > Sent: Friday, March 29, 2019 5:

[GIT PULL] NTB bug fixes for v5.3

2019-08-11 Thread Jon Mason
Hello Linus, Here is a trivial NTB bug fix for v5.3. Please consider pulling it. Thanks, Jon The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) are available in the Git repository at: git://github.com/jonmason/ntb tags/

[GIT PULL] NTB changes for v5.3

2019-07-20 Thread Jon Mason
Hello Linus, Here are the NTB changes for v5.3. The big change is adding the virtual MSI interface for NTB (reviewed and acked by Bjorn). Also, there are some bug fixes. Please consider pulling them. Thanks, Jon The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:

Re: [PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec

2019-06-13 Thread Jon Mason
On Thu, Jun 06, 2019 at 03:09:41PM +0800, Kelvin Cao wrote: > Hi, Everyone, > > This patch series remove redundant steps and fix one bug of the > ntb_hw_switchtec module. > > When a re-initialization is caused by a link event, the driver will > re-setup the shared memory windows. But at that tim

Re: [PATCH] NTB: correct ntb_dev_ops and ntb_dev comment typos

2019-06-13 Thread Jon Mason
On Tue, Apr 30, 2019 at 06:04:29PM +0800, Wesley Sheng wrote: > The comment for ntb_dev_ops and ntb_dev incorrectly referred to > ntb_ctx_ops and ntb_device. > > Signed-off-by: Wesley Sheng > Reviewed-by: Logan Gunthorpe Sorry for the delay. The series is now in the ntb branch. We've missed w

Re: [PATCH v5 00/10] Support using MSI interrupts in ntb_transport

2019-06-13 Thread Jon Mason
On Thu, May 23, 2019 at 04:30:50PM -0600, Logan Gunthorpe wrote: > This is another resend as there has been no feedback since v4. > Seems Jon has been MIA this past cycle so hopefully he appears on the > list soon. > > I've addressed the feedback so far and rebased on the latest kernel > and would

Re: [PATCH v2] drivers: ntb: Kconfig: pedantic cleanups

2019-03-28 Thread Jon Mason
On Wed, Mar 20, 2019 at 9:15 PM Bjorn Helgaas wrote: > > [+cc Jon, Dave, Allen] > > On Wed, Mar 06, 2019 at 11:02:54PM +0100, Enrico Weigelt, metux IT consult > wrote: > > Formatting of Kconfig files doesn't look so pretty, so just > > take damp cloth and clean it up. > > Oops, I didn't notice th

Re: linux-next: Fixes tag needs some work in the ntb tree

2019-03-22 Thread Jon Mason
On Thu, Mar 21, 2019 at 4:28 PM Stephen Rothwell wrote: > > Hi Jon, > > On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason wrote: > > > > Is there an existing set of tools/scripts I should run to prevent > > things like this from happening? > > I have attached t

Re: linux-next: Fixes tag needs some work in the ntb tree

2019-03-21 Thread Jon Mason
On Wed, Mar 20, 2019 at 5:00 PM Logan Gunthorpe wrote: > > > > On 2019-03-20 2:58 p.m., Stephen Rothwell wrote: > > Hi all, > > > > In commit > > > > f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is > > initaliazed") > > > > Fixes tag > > > > Fixes: c27ccb899219 ("NTB: ntb_tran

Re: [PATCH 1/4] NTB: ntb_perf: Increased the number of message retries to 1000

2019-03-20 Thread Jon Mason
On Fri, Feb 15, 2019 at 09:20:07AM +, Mehta, Sanju wrote: > From: Sanjay R Mehta > > while waiting for the peer ntb_perf to initialize scratchpad > registers, local side ntb_perf might have already exhausted the > maximum number of retries which is currently set to 500. To avoid > this and t

Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static

2019-03-20 Thread Jon Mason
On Wed, Mar 20, 2019 at 10:08:12PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning: > symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static? > > Signed-off-by: YueHaibing Looks good to me. Added to t

[GIT PULL] NTB bug fixes for v5.1

2019-03-15 Thread Jon Mason
Hello Linus, Here are a few NTB fixes for v5.1. While the tag is new, the patches have been in my tree (and thus linux-next) for weeks now. Please consider pulling them. Thanks, Jon The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08

Re: [PATCH] NTB: ntb_transport: Free MWs in ntb_transport_link_cleanup()

2019-02-11 Thread Jon Mason
On Mon, Jan 07, 2019 at 06:16:02PM -0700, Logan Gunthorpe wrote: > > > On 06/01/19 08:12 PM, Joey Zhang wrote: > > If NTB peer host crashes or reboots, the NTB transport link will be > > down and the MWs of NTB transport will be invalid. But the > > ntb_transport_link_cleanup() does not free thes

Re: [PATCH] NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA

2019-02-11 Thread Jon Mason
the entire MW region for each QP after we assign > > the DMA channel. This prevents needing an extra DMA map in the fast > > path. > > > > Link: > > https://lore.kernel.org/linux-pci/499934e7-3734-1aee-37dd-b42a5d2a2...@intel.com/ > > Signed-off-by: Logan Gunth

Re: [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset

2019-02-11 Thread Jon Mason
On Wed, Jan 09, 2019 at 12:22:25PM -0700, Logan Gunthorpe wrote: > Hey, > > I'm resending this because I've recently found out that the change we > made to use the NTB struct device in DMA allocations is wrong and > needs to be reverted. Turns out that, when running with an IOMMU, > dma_alloc_cohe

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

2018-12-12 Thread Jon Mason
On Wed, Dec 12, 2018 at 7:01 PM Logan Gunthorpe wrote: > > > > On 2018-12-12 4:57 p.m., Jon Mason wrote: > > On Wed, Dec 12, 2018 at 6:42 PM Logan Gunthorpe wrote: > >> > >> > >> > >> On 2018-12-12 4:00 p.m., Jon Mason wrote: > >>

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

2018-12-12 Thread Jon Mason
On Wed, Dec 12, 2018 at 6:42 PM Logan Gunthorpe wrote: > > > > On 2018-12-12 4:00 p.m., Jon Mason wrote: > > So, you based your patches on a series of patches not in the > > ntb/ntb-next branch? Please don't do this. I see nothing in these > > patches whic

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

2018-12-12 Thread Jon Mason
On Thu, Dec 6, 2018 at 1:47 AM Wesley Sheng wrote: > > Hi, Everyone, > > This patch series adds support of >=4G memory windows. > > Current Switchtec's BAR setup registers are limited to 32bits, > corresponding to the maximum MW (memory window) size is <4G. > Increase the MW sizes with the additio

Re: [PATCH 2/3] ntb_hw_switchtec: Added support of >=4G memory windows

2018-11-27 Thread Jon Mason
On Wed, Nov 21, 2018 at 9:19 PM Wesley Sheng wrote: > > From: Paul Selles > > Current Switchtec's BAR setup registers are limited to 32bits, > corresponding to the maximum MW (memory window) size is <4G. > > Increase the MW sizes with the addition of the BAR Setup Extension > Register for the upp

[GIT PULL] NTB patches for v4.20

2018-11-03 Thread Jon Mason
: intel: fix return value for ndev_vec_mask() Gustavo A. R. Silva (2): NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks ntb: ntb_transport: Mark expected switch fall-throughs Jon Mason (1): ntb_netdev: fix sleep time mismatch Serge Semin (5): ntb: idt: Set

Re: [PATCH v2 0/4] ntb: idt: Add hwmon temperature sensor interface

2018-11-01 Thread Jon Mason
On Tue, Jul 17, 2018 at 12:24:33PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible overheati

Re: [PATCH 0/4] ntb: idt: Add hwmon temperature sensor interface

2018-10-31 Thread Jon Mason
On Sat, Jul 14, 2018 at 02:58:30PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible overheati

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

2018-10-31 Thread Jon Mason
On Fri, Oct 05, 2018 at 01:03:01PM -0400, Allen Hubbe wrote: > On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Addresses-Coverity-ID: 1373888 ("Missing break in

Re: [PATCH] NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks

2018-10-31 Thread Jon Mason
On Mon, Aug 27, 2018 at 05:13:06PM -0500, Gustavo A. R. Silva wrote: > Both devm_kcalloc() and devm_kzalloc() return NULL on error. They > never return error pointers. > > The use of IS_ERR_OR_NULL is currently applied to the wrong > context. > > Fix this by replacing IS_ERR_OR_NULL with regular

[PATCH] MAINTAINERS: Remove self from Broadcom SoCs

2018-09-19 Thread Jon Mason
I'm leaving Broadcom, and will no longer have access to hardware and documentation necessary to be effective in a maintainership role. Signed-off-by: Jon Mason --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ece30f15777..d063c605074e 1

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later (ntb_pingpong)

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the monoli

[GIT PULL] NTB changes for v4.18

2018-06-11 Thread Jon Mason
Hello Linus, Here are a few NTB changes for v4.18. They were tested earlier today by Dave Jiang, and have been in linux-next for some time. Please consider pulling them. Thanks, Jon The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4: Linux 4.17 (2018-06-03 14:15:21

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-05-21 Thread Jon Mason
On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/ntb/ntb_transport.c | 2 +- >

Re: [PATCH 2/2] ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue

2018-05-21 Thread Jon Mason
On Tue, Apr 10, 2018 at 09:17:54PM +0800, Jia-Ju Bai wrote: > ntb_transport_create_queue() is never called in atomic context. > > ntb_transport_create_queue() is only called by ntb_netdev_probe(), > which is set as ".probe" in struct ntb_transport_client. > > Despite never getting called from ato

Re: [PATCH 6/9] NTB: ntb_hw_idt: fix typo 'can by' to 'can be'

2018-05-21 Thread Jon Mason
On Fri, May 11, 2018 at 04:12:36PM +0300, Serge Semin wrote: > On Sun, May 06, 2018 at 01:23:50PM +0200, Wolfram Sang > wrote: > > Signed-off-by: Wolfram Sang > > --- > > drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ntb/

Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

2018-02-27 Thread Jon Mason
> > Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR > board") > Signed-off-by: Florian Fainelli Acked-by: Jon Mason > --- > arch/arm/boot/dts/bcm958625hr.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/a

[GIT PULL] NTB bug fixes for v4.16

2018-02-04 Thread Jon Mason
ntb: remove unneeded DRIVER_LICENSE #defines Jon Mason (1): NTB: switchtec_ntb: Add new line on appropriate printks Kelvin Cao (1): ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups Logan Gunthorpe (9): ntb_hw_switchtec: Keep track of the num

Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32

2018-01-24 Thread Jon Mason
On Wed, Jan 24, 2018 at 09:07:26AM +0100, Arnd Bergmann wrote: > On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin wrote: > > Sparse is whining about the u32 and __le32 mixed usage in the driver > > > > drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32 > > drivers/ntb/test/ntb_perf

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

2018-01-23 Thread Jon Mason
On Fri, Jan 19, 2018 at 10:26:37PM +0100, Arnd Bergmann wrote: > On Fri, Jan 19, 2018 at 10:03 PM, Serge Semin wrote: > > > > Actually the provided patch is the best solution I could come up with. > > The thing is, that the methods can't be changed. Those functions are > > the part of the NTB API

Re: [PATCH][next] NTB: ntb_tool: fix memory leak on 'buf' on error exit path

2018-01-23 Thread Jon Mason
On Mon, Jan 22, 2018 at 01:02:39PM +0300, Serge Semin wrote: > On Mon, Jan 22, 2018 at 09:38:57AM +, Colin King > wrote: > > From: Colin Ian King > > > > Currently there is a memory leak on buf when the call to ntb_mw_get_align > > fails. Add an exit err label and jump to this so that kfre

Re: [PATCH] NTB: ntb_perf: fix printing of resource_size_t

2018-01-19 Thread Jon Mason
On Fri, Jan 19, 2018 at 03:55:28PM +0100, Arnd Bergmann wrote: > On 32-bit architectures, resource_size_t is usually 'unsigned int' or > 'unsigned long' but not 'unsigned long long', so we get a warning > about printing the wrong data: > > drivers/ntb/test/ntb_perf.c: In function 'perf_setup_peer_

Re: [PATCH] [RESEND] ntb_hw_switchtec: fix logic error

2018-01-18 Thread Jon Mason
On Tue, Jan 16, 2018 at 02:50:51PM +0100, Arnd Bergmann wrote: > Newer gcc (version 7 and 8 presumably) warn about a statement mixing > the << operator with logical and: > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function > 'switchtec_ntb_init_sndev': > drivers/ntb/hw/mscc/ntb_hw_switchtec.c:

Re: [PATCH v2 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

2018-01-18 Thread Jon Mason
Jon > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > --- > > v2: Use IS_ALIGNED macro as suggested by Allen > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switch

Re: [PATCH v2 1/2] ntb_transport: Fix bug with max_mw_size parameter

2018-01-18 Thread Jon Mason
ly fixed by applying the same limit to tx_size in > ntb_transport_init_queue(). Applied to ntb-next. Thanks, Jon > > Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") > Signed-off-by: Logan Gunthorpe > Acked-by: Allen Hubbe > Cc: Jon Mason &

Re: [PATCH] MAINTAINERS: NTB: Update contact info

2018-01-18 Thread Jon Mason
d-off-by: Allen Hubbe > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 82ad0eabce4f..cb7344e37fc5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9712,7 +9712,7 @@ F: drivers/ntb/hw

Re: [PATCH v4 00/15] NTB: Add full multi-port API support to the test drivers

2018-01-18 Thread Jon Mason
On Wed, Dec 06, 2017 at 05:31:51PM +0300, Serge Semin wrote: > The multi-port NTB API was introduced in kernel 4.13 as well as the > first driver for the true multi-port devices of IDT PCIe-switches > series. But the test drivers still were left almost unchanged. Yes, > they didn't fail being used

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 2:40 PM, Logan Gunthorpe wrote: > > > On 05/12/17 12:12 PM, Jon Mason wrote: >> >> It sucks that we don't already have a struct for PCI config space we >> can reuse here. If you find the time, it would be good to add in the >> futur

Re: [PATCH 0/7] Switchtec NTB Crosslink Support

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:58 PM, Logan Gunthorpe wrote: > Also, I forgot to mention, this patch set is based on today's ntb-next. All of these look sane to me. Assuming they apply cleanly, adding to ntb-next. Thanks, Jon > > Logan > > > On 29/11/17 10:55 AM, Logan Gunthorpe wrote: >> >> Hi, >

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an host-less centre partit

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the predefined mask, which may b

Re: [PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > Link Up and Down methods are used to change NTB link settings on > local side only for multi-port devices. Link is considered up > only if both sides local and peer set it up. Intel/AMD hardware > acts a bit different by assigning the Primary an

Re: [PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got > whitespaces, the script may fail with syntax error. > > Signed-off-by: Serge Semin > Acked-by: Logan Gunthorpe > Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB

Re: [PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well te

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > Simple (1 << pidx) operation causes undefined behaviour when >> > pidx >= 32. It must

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > There is a common methods signature form used over all the NTB API >> > like functions naming

Re: [PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well te

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 12:01 PM, Logan Gunthorpe wrote: > > > On 05/12/17 09:52 AM, Jon Mason wrote: >> >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin >> wrote: >>> >>> Simple (1 << pidx) operation causes undefined behaviour when >>&

Re: [PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well te

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > Simple (1 << pidx) operation causes undefined behaviour when > pidx >= 32. It must be casted to u64 to match the actual return > value of ntb_link_is_up() method, so to have all the possible > peer indexes covered and to get rid of undefined beh

Re: [PATCH v2 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > The dma_mask and dma_coherent_mask fields of the NTB struct device > weren't initialized in hardware drivers. In fact it should be done > instead of PCIe interface usage, since NTB clients are supposed to > use NTB API only and left unaware of r

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > There is a common methods signature form used over all the NTB API > like functions naming scheme, arguments names and order, etc. > Recently added NTB messaging API IO callbacks were named a bit > different so should be renamed to be in complia

Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines

2017-11-27 Thread Jon Mason
lows tools that check that the module license matches the source >> code license to work properly, as there is no need to unwind the >> unneeded dereference, especially when the string is defined just a few >> lines above the usage of it. >> >> Cc: Jon Mason >> Cc

Re: [PATCH] NTB: switchtec_ntb: fix spelling mistake: "peforming" -> "performing"

2017-11-27 Thread Jon Mason
On Tue, Nov 21, 2017 at 10:13 PM, Joe Perches wrote: > On Tue, 2017-11-21 at 22:59 +, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in dev_err error message >> >> Signed-off-by: Colin Ian King >> --- >> drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +- >> 1 fi

Re: [PATCH] NTB: switchtec_ntb: fix spelling mistake: "peforming" -> "performing"

2017-11-27 Thread Jon Mason
On Tue, Nov 21, 2017 at 6:06 PM, Logan Gunthorpe wrote: > Thanks Colin! > > Reviewed-By: Logan Gunthorpe > > On 21/11/17 03:59 PM, Colin King wrote: >> >> From: Colin Ian King >> >> Trivial fix to spelling mistake in dev_err error message >> >> Signed-off-by: Colin Ian King Applied to my ntb-n

Re: [GIT PULL] NTB bug fixes for v4.15

2017-11-27 Thread Jon Mason
as a >> > MAINTAINER, so I am not sure what part he would play. >> > >> >> The branch you would want to automatically fetch is >> >> https://github.com/jonmason/ntb.git ntb-next >> >> Jon's probably the contact you want for merge conflict

[GIT PULL] NTB bug fixes for v4.15

2017-11-19 Thread Jon Mason
Hello Linus, Here is a new Switchtec NTB driver and a few NTB bug fixes for 4.15. It's been sitting in my ntb-next branch for some time and should be throughly tested. Please consider pulling them. Thanks, Jon The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4: Linu

Re: [PATCH 1/2] ARM: dts: NSP: Disable AHCI controller for HR NSP boards

2017-11-07 Thread Jon Mason
disable the AHCI controller for now until this gets resolved. > > Fixes: 70725d6e97ac ("ARM: dts: NSP: Enable SATA on bcm958625hr") > Fixes: d454c3762437 ("ARM: dts: NSP: Add new DT file for bcm958623hr") > Signed-off-by: Florian Fainelli Acked-by: Jon Mason &g

Re: [PATCH 2/2] ARM: dts: NSP: Fix PPI interrupt types

2017-11-07 Thread Jon Mason
an fix that up while applying unless > there are other comments. > >> Fixes: 1a9d53cabaf4 ("ARM: dts: NSP: Add TWD Support to DT") >> Signed-off-by: Florian Fainelli Acked-by: Jon Mason >> --- >> arch/arm/boot/dts/bcm-nsp.dtsi | 4 ++-- >> 1 file change

Re: [PATCH] NTB: ntb_hw_switchtec: Fix peer BAR bug in switchtec_ntb_init_shared_mw

2017-10-17 Thread Jon Mason
On Tue, Oct 17, 2017 at 4:22 PM, wrote: > From: Doug Meyer > > This resolves a bug which may incorrectly configure the peer host's > LUT for shared memory window access. The code was using the local > host's first BAR number, rather than the peer hosts's first BAR > number, to determine what pee

Re: [PATCH 00/10] ARM: bcm: Add support for Broadcom Hurricane 2 SoC

2017-09-26 Thread Jon Mason
changed, 569 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,hr2.txt > create mode 100644 arch/arm/boot/dts/bcm-hr2.dtsi > create mode 100644 arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dts > create mode 100644 arch/arm/mach-bcm/bcm_hr2.c

Re: [PATCH 05/10] clk: bcm: Add Broadcom Hurricane 2 clock support

2017-09-26 Thread Jon Mason
On Mon, Sep 25, 2017 at 8:09 PM, Florian Fainelli wrote: > Add support for the Broadcom Hurricane 2 SoC clock controller. We can > re-use the existing iProc clock library since the SoC's architecture is > largely the same as its predecessors. > > Signed-off-by: Florian Fainelli > --- > drivers/c

Re: [PATCH] NTB: make idt_89hpes_cfg const

2017-08-31 Thread Jon Mason
On Fri, Aug 11, 2017 at 11:17:43PM +0530, Bhumika Goyal wrote: > Make these const as they are only used during a copy operation. > Done using Coccinelle. Pulled into my ntb-next branch Thanks, Jon > > Signed-off-by: Bhumika Goyal > --- > drivers/ntb/hw/idt/ntb_hw_idt.c | 16 >

Re: [PATCH v4 00/15] Switchtec NTB Support

2017-08-31 Thread Jon Mason
On Wed, Aug 30, 2017 at 01:18:28PM -0600, Logan Gunthorpe wrote: > Hey Jon, > > Any update on this? The merge window is likely very soon and it would be > good to know where we stand. As far as I know I've addressed all the > feedback I've been given. Let me know if there's anything I can do to >

[GIT PULL] NTB bug fixes for v4.13

2017-08-26 Thread Jon Mason
Hello Linus, Here are a few NTB bug fixes for 4.13. Please consider pulling them. Thanks, Jon The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://github.com/jonmason/ntb ta

Re: [PATCH v2 5/6] phy: Add USB3 PHY support for Broadcom NS2 SoC

2017-08-03 Thread Jon Mason
On Wed, Aug 2, 2017 at 2:36 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 27 July 2017 04:26 AM, Jon Mason wrote: >> From: Yendapally Reddy Dhananjaya Reddy >> >> This patch adds support for Broadcom NS2 USB3 PHY >> >> Signed-off-by: Yendapally Re

Re: [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers

2017-08-02 Thread Jon Mason
On Wed, Aug 2, 2017 at 9:06 AM, Allen Hubbe wrote: > From: Logan Gunthorpe >> On 01/08/17 01:10 PM, Jon Mason wrote: >> > It would probaly be better if I remarked about the SPADs in the actual >> > patch about the SPADS :) >> > >> > The whole poin

Re: [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:51PM -0600, Logan Gunthorpe wrote: > Seeing there is no dedicated hardware for this, we simply add > these as entries in the shared memory window. Thus, we could support > any number of them but 128 seems like enough, for now. It would probaly be better if I remarked

Re: [PATCH v3 13/16] switchtec_ntb: implement doorbell registers

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:50PM -0600, Logan Gunthorpe wrote: > Pretty straightforward implementation of doorbell registers. > The shift and mask were setup in an earlier patch and this just hooks > up the appropriate portion of the IDB register as the local doorbells > and the opposite portion

Re: [PATCH v3 09/16] switchtec_ntb: initialize hardware for memory windows

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:46PM -0600, Logan Gunthorpe wrote: > Add the code to initialize the memory windows in the hardware. > This includes setting up the requester ID table, and figuring out > which bar corresponds to which memory window. (Seeing the switch > can be configured with any numbe

Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up

2017-08-01 Thread Jon Mason
On Tue, Aug 01, 2017 at 12:17:47PM -0600, Logan Gunthorpe wrote: > Hey, > > On 01/08/17 12:14 PM, Jon Mason wrote: > > This also looks like a bug fix. However, given that it is a little more > > invasive and no one reporting any problems with it, I'm less apt to >

Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws

2017-08-01 Thread Jon Mason
On Tue, Aug 01, 2017 at 12:09:18PM -0600, Logan Gunthorpe wrote: > > On 01/08/17 12:07 PM, Jon Mason wrote: > > On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote: > >> After the link tests, there is a race on one side of the test for > >> the link com

Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:43PM -0600, Logan Gunthorpe wrote: > With Switchtec hardware it's impossible to get the alignment parameters > for a peer's memory window until the peer's driver has configured it's > windows. Strictly speaking, the link doesn't have to be up for this, > but the link b

Re: [PATCH v3 07/16] ntb: add check and comment for link up to mw_count() and mw_get_align()

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:44PM -0600, Logan Gunthorpe wrote: > Adds a comment and a check to ntb_mw_get_align() so that it always fails > if the function is called before the link is up. > > Also adds a comment to ntb_mw_count() to note that it may return 0 if > it is called before the link is

Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws

2017-08-01 Thread Jon Mason
On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote: > After the link tests, there is a race on one side of the test for > the link coming up. It's possible, in some cases, for the test script > to write to the 'peer_trans' files before the link has come up. > > To fix this, we simply

Re: [PATCH v5 5/6] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

2017-08-01 Thread Jon Mason
On Wed, Jul 26, 2017 at 05:19:16PM -0600, Logan Gunthorpe wrote: > Now that ioread64 and iowrite64 are available in io-64-nonatomic, > we can remove the hack at the top of ntb_hw_intel.c and replace it > with an include. > > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason

[PATCH v2 3/3] ARM: dts: NSP: Add USB3 and USB3 PHY to NSP

2017-07-31 Thread Jon Mason
This uses the existing Northstar USB3 PHY driver to enable the USB3 ports on NSP. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 19 +++ arch/arm/boot/dts/bcm958522er.dts | 8 arch/arm/boot/dts/bcm958525er.dts | 8 arch/arm/boot/dts

[PATCH v2 2/3] ARM: dts: NSP: Rearrage USB entries

2017-07-31 Thread Jon Mason
The rest of the DTSI file is in incrementing addresses, but the USB OHCI/ECHI entries are out of sequence. Move them to put them in the proper place. Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 32 1 file changed, 16 insertions(+), 16

[PATCH v2 1/3] ARM: dts: NSP: Add dma-coherent to relevant DT entries

2017-07-31 Thread Jon Mason
Cache related issues with DMA rings and performance issues related to caching are being caused by not properly setting the "dma-coherent" flag in the device tree entries. Adding it here to correct the issue. Signed-off-by: Jon Mason Fixes: 3107fa5bcfb2 ("ARM: dts: NSP: Add

[PATCH v2 0/3] ARM: dts: NSP: dma-coherent and USB3 changes

2017-07-31 Thread Jon Mason
Changes in v2: * Removed pl330 and srab dma-coherent entries due to concerns that they were invalid Add dma-coherent to the relevant DT entries, and add USB3 support Jon Mason (3): ARM: dts: NSP: Add dma-coherent to relevant DT entries ARM: dts: NSP: Rearrage USB entries ARM: dts: NSP

Re: [PATCH 1/3] ARM: dts: NSP: Add dma-coherent to relevant DT entries

2017-07-31 Thread Jon Mason
On Fri, Jul 28, 2017 at 8:03 PM, Florian Fainelli wrote: > On 07/25/2017 03:06 PM, Jon Mason wrote: >> Cache related issues with DMA rings and performance issues related to >> caching are being caused by not properly setting the "dma-coherent" flag >> in the devic

  1   2   3   4   5   6   7   8   >