Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

On 03/29/2017 01:25 AM, Masami Hiramatsu wrote: > On Wed, 29 Mar 2017 08:30:05 +0200 > Ingo Molnar wrote: >> >> * Masami Hiramatsu wrote: >> >>> @@ -1824,6 +1823,30 @@ void unregister_jprobes(struct jprobe **jps, int num) >>>

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

On 03/29/2017 01:25 AM, Masami Hiramatsu wrote: > On Wed, 29 Mar 2017 08:30:05 +0200 > Ingo Molnar wrote: >> >> * Masami Hiramatsu wrote: >> >>> @@ -1824,6 +1823,30 @@ void unregister_jprobes(struct jprobe **jps, int num) >>> EXPORT_SYMBOL_GPL(unregister_jprobes); >>> >>> #ifdef

Re: [PATCH] Yama: allow access for the current ptrace parent

On 12/02/2016 03:27 PM, Kees Cook wrote: >> + /* If there's already an active tracing relationship, then make an > > I'll adjust the comment style here and add it to my tree for -next. Thanks! I guess the tweak is that it should have an empty "/*" line? FWIW, checkpatch.pl doesn't warn

Re: [PATCH] Yama: allow access for the current ptrace parent

On 12/02/2016 03:27 PM, Kees Cook wrote: >> + /* If there's already an active tracing relationship, then make an > > I'll adjust the comment style here and add it to my tree for -next. Thanks! I guess the tweak is that it should have an empty "/*" line? FWIW, checkpatch.pl doesn't warn

[PATCH] Yama: allow access for the current ptrace parent

group as the current ptrace parent. Signed-off-by: Josh Stone <jist...@redhat.com> Cc: Kees Cook <keesc...@chromium.org> Cc: James Morris <james.l.mor...@oracle.com> Cc: "Serge E. Hallyn" <se...@hallyn.com> Cc: linux-security-mod...@vger.kernel.org

[PATCH] Yama: allow access for the current ptrace parent

group as the current ptrace parent. Signed-off-by: Josh Stone Cc: Kees Cook Cc: James Morris Cc: "Serge E. Hallyn" Cc: linux-security-mod...@vger.kernel.org --- security/yama/yama_lsm.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/security/yama/

Re: [PATCH 4.0 108/148] ARM: fix missing syscall trace exit

ell? > -- > > From: Russell King > > commit 1b97937246d8b97c0760d16d8992c7937bdf5e6a upstream. > > Josh Stone reports: > > I've discovered a case where both arm and arm64 will miss a ptrace > syscall-exit that they should report. If the syscall is entered > without

Re: [PATCH 4.0 108/148] ARM: fix missing syscall trace exit

: Russell King rmk+ker...@arm.linux.org.uk commit 1b97937246d8b97c0760d16d8992c7937bdf5e6a upstream. Josh Stone reports: I've discovered a case where both arm and arm64 will miss a ptrace syscall-exit that they should report. If the syscall is entered without TIF_SYSCALL_TRACE set

Re: [PATCH] Docs: SubmittingPatches: Clarify convention for git commit references

On 05/21/2015 10:04 AM, Joe Perches wrote: > On Thu, 2015-05-21 at 11:44 -0500, Bjorn Helgaas wrote: >> My git-fu isn't awesome > > Yeah, mine either. > >> (git log --oneline --abbrev-commit --abbrev=10 >> | cut -f1 -d" " | grep ...), but I *think* we have three git >> SHA-1s so far

Re: [PATCH] Docs: SubmittingPatches: Clarify convention for git commit references

On 05/21/2015 10:04 AM, Joe Perches wrote: On Thu, 2015-05-21 at 11:44 -0500, Bjorn Helgaas wrote: My git-fu isn't awesome Yeah, mine either. (git log --oneline --abbrev-commit --abbrev=10 | cut -f1 -d | grep ...), but I *think* we have three git SHA-1s so far that aren't

Re: [PATCH RESEND] Kbuild: Add an option to enable GCC VTA

On 11/24/2014 01:46 PM, Michal Marek wrote: > Dne 21.11.2014 v 19:40 Josh Stone napsal(a): >> Due to recent codegen issues, gcc -fvar-tracking-assignments was >> unconditionally disabled in commit 2062afb4f804a ("Fix gcc-4.9.0 >> miscompilation of load_balance(

Re: [PATCH RESEND] Kbuild: Add an option to enable GCC VTA

On 11/24/2014 01:46 PM, Michal Marek wrote: Dne 21.11.2014 v 19:40 Josh Stone napsal(a): Due to recent codegen issues, gcc -fvar-tracking-assignments was unconditionally disabled in commit 2062afb4f804a (Fix gcc-4.9.0 miscompilation of load_balance() in scheduler). However, this reduces

[PATCH RESEND] Kbuild: Add an option to enable GCC VTA

v3.18-rc5 with Fedora's i686 and x86_64 configs, and this is completely clean with GCC_COMPARE_DEBUG. Cc: Frank Ch. Eigler Cc: Jakub Jelinek Cc: Josh Boyer Cc: Greg Kroah-Hartman Cc: Linus Torvalds Cc: Andrew Morton Cc: Markus Trippelsdorf Cc: Michel Dänzer Signed-off-by: Josh Stone ---

[PATCH RESEND] Kbuild: Add an option to enable GCC VTA

: Andrew Morton a...@linux-foundation.org Cc: Markus Trippelsdorf mar...@trippelsdorf.de Cc: Michel Dänzer mic...@daenzer.net Signed-off-by: Josh Stone jist...@redhat.com --- Makefile | 4 lib/Kconfig.debug | 18 +- 2 files changed, 21 insertions(+), 1 deletion

Re: [PATCH v4 5/5] perf/sdt: Add support to perf record to trace SDT events

On 11/05/2014 01:05 AM, Masami Hiramatsu wrote: > [Off topic] I really don't like that the current SDT's semaphore. If the user > apps > see the instruction at the probe point, it is easy to check whether the event > is > enabled or not. Thus I recommend to change its implementation and update

Re: [PATCH v4 5/5] perf/sdt: Add support to perf record to trace SDT events

On 11/05/2014 01:05 AM, Masami Hiramatsu wrote: [Off topic] I really don't like that the current SDT's semaphore. If the user apps see the instruction at the probe point, it is easy to check whether the event is enabled or not. Thus I recommend to change its implementation and update

[PATCH] Kbuild: Add an option to enable GCC VTA

build 3.17 with Fedora's i686 and x86_64 configs, and this is completely clean with GCC_COMPARE_DEBUG. Cc: Frank Ch. Eigler Cc: Greg Kroah-Hartman Cc: Jakub Jelinek Cc: Josh Boyer Cc: Linus Torvalds Cc: Markus Trippelsdorf Cc: Michel Dänzer Signed-off-by: Josh Stone --- Makefile | 4

[PATCH] Kbuild: Add an option to enable GCC VTA

: Markus Trippelsdorf mar...@trippelsdorf.de Cc: Michel Dänzer mic...@daenzer.net Signed-off-by: Josh Stone jist...@redhat.com --- Makefile | 4 lib/Kconfig.debug | 18 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b77de27e58fc

SystemTap 2.6 release

ters are made available on 32-bit x86 (PR15136) See dyninst/README and the systemtap/dyninst Bugzilla component (http://tinyurl.com/stapdyn-PR-list) if you want all the gory details about the state of the feature. = Contributors for this release Abegail Jakop*, Brian Chrisman*, David Smith,

SystemTap 2.6 release

for this release Abegail Jakop*, Brian Chrisman*, David Smith, Frank Ch. Eigler, Honggyu Kim*, Jonathan Lebon, Josh Stone, Lukas Berk, Mark Wielaard, Martin Cermak, Stan Cox, Stefan Hajnoczi*, Tetsuo Handa*, William Cohen, Yaakov Selkowitz* Special thanks to new contributors, marked

Re: [PATCH -tip v4 0/6] kprobes: introduce NOKPROBE_SYMBOL() and fixes crash bugs

On 12/12/2013 06:03 AM, Ingo Molnar wrote: >> No, because the int3 already changes the original instruction. >> This means that you cannot skip singlestep(or emulate) the >> instruction which is copied to execution buffer (ainsn->insn), >> even if you have such the flag. >> So, kprobe requires the

Re: [PATCH -tip v4 0/6] kprobes: introduce NOKPROBE_SYMBOL() and fixes crash bugs

On 12/12/2013 06:03 AM, Ingo Molnar wrote: No, because the int3 already changes the original instruction. This means that you cannot skip singlestep(or emulate) the instruction which is copied to execution buffer (ainsn-insn), even if you have such the flag. So, kprobe requires the

Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist

On 11/20/2013 09:56 AM, Steven Rostedt wrote: > On Wed, 20 Nov 2013 12:36:00 -0500 > "Frank Ch. Eigler" wrote: > >> Hi - >> Does this new blacklist cover enough that the kernel now survives a broadly wildcarded perf-probe, e.g. over e.g. all of its kallsyms? >>> >>> That's generally

Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist

On 11/20/2013 09:56 AM, Steven Rostedt wrote: On Wed, 20 Nov 2013 12:36:00 -0500 Frank Ch. Eigler f...@redhat.com wrote: Hi - Does this new blacklist cover enough that the kernel now survives a broadly wildcarded perf-probe, e.g. over e.g. all of its kallsyms? That's generally the

Re: systemtap broken by removal of register_timer_hook

On 04/03/2013 07:44 AM, Frank Ch. Eigler wrote: > Hi - > > On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > >> Sounds good, would you like to propose a version? We are also >> interested in a timer tick event tracepoint for dynticks debugging. > > How about this? > >

Re: systemtap broken by removal of register_timer_hook

On 04/03/2013 07:44 AM, Frank Ch. Eigler wrote: Hi - On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: Sounds good, would you like to propose a version? We are also interested in a timer tick event tracepoint for dynticks debugging. How about this? Author: Frank

Re: [PATCH 0/7] uretprobes: return probes implementation

On 03/22/2013 08:10 AM, Oleg Nesterov wrote: > This looks simple, but probably we need to add the additional "ulong bp_vaddr" > argument for rp_handler(). FWIW, in SystemTap we don't currently do anything that would need bp_vaddr. The uprobe_consumer already gives the context, so I'm not sure

Re: [PATCH 0/7] uretprobes: return probes implementation

On 03/22/2013 08:10 AM, Oleg Nesterov wrote: This looks simple, but probably we need to add the additional ulong bp_vaddr argument for rp_handler(). FWIW, in SystemTap we don't currently do anything that would need bp_vaddr. The uprobe_consumer already gives the context, so I'm not sure what

Re: [GIT PULL] uprobes: pre-filtering

On 01/24/2013 07:40 AM, Oleg Nesterov wrote: > I'll try to implement the pid-base filtering at least for > tracing/uprobe_events, but this needs a time. Not only I am not familiar > with this code, I am not sure how this interface should actually look. > And I agree, perf should be able to use it

Re: [GIT PULL] uprobes: pre-filtering

On 01/24/2013 07:40 AM, Oleg Nesterov wrote: I'll try to implement the pid-base filtering at least for tracing/uprobe_events, but this needs a time. Not only I am not familiar with this code, I am not sure how this interface should actually look. And I agree, perf should be able to use it

Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler

On 01/12/2013 09:06 AM, Oleg Nesterov wrote: > On 01/10, Josh Stone wrote: >> and for uretprobes we want the original return address. > > Yes, Anton's v2 does this. > > But. Don't you also need to know the address of function we are going > to return fr

Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler

On 01/12/2013 09:06 AM, Oleg Nesterov wrote: On 01/10, Josh Stone wrote: and for uretprobes we want the original return address. Yes, Anton's v2 does this. But. Don't you also need to know the address of function we are going to return from? Probably you do not, uprobe_consumer should

Re: [PATCH] uprobes: Add exports for module use

Hi Christoph, On 01/11/2013 01:32 AM, Christoph Hellwig wrote: > On Thu, Jan 10, 2013 at 03:01:46PM -0800, Josh Stone wrote: >> The original pull message for uprobes (commit 654443e2) noted: >> >> This tree includes uprobes support in 'perf probe' - but SystemTap >>

Re: [PATCH] uprobes: Add exports for module use

Hi Christoph, On 01/11/2013 01:32 AM, Christoph Hellwig wrote: On Thu, Jan 10, 2013 at 03:01:46PM -0800, Josh Stone wrote: The original pull message for uprobes (commit 654443e2) noted: This tree includes uprobes support in 'perf probe' - but SystemTap (and other tools) can take

[PATCH] uprobes: Add exports for module use

to be exported. This patch first adds the obvious exports for uprobe_register and uprobe_unregister. Then it also adds one for task_user_regset_view, which is necessary to get the correct state of userspace registers. Signed-off-by: Josh Stone --- kernel/events/uprobes.c | 3 +++ kernel/ptrace.c

Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler

On 01/08/2013 06:27 AM, Anton Arapov wrote: > On Sun, Dec 23, 2012 at 04:49:10PM +0100, Oleg Nesterov wrote: >> On 12/22, Oleg Nesterov wrote: Just change regs->ip before calling ->handler(). >>> >>> Josh, Frank, will it work for you? >> >> Wait, probably I was confused by this patch and

Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler

On 01/08/2013 06:27 AM, Anton Arapov wrote: On Sun, Dec 23, 2012 at 04:49:10PM +0100, Oleg Nesterov wrote: On 12/22, Oleg Nesterov wrote: Just change regs-ip before calling -handler(). Josh, Frank, will it work for you? Wait, probably I was confused by this patch and 4/6... To simplify,

[PATCH] uprobes: Add exports for module use

to be exported. This patch first adds the obvious exports for uprobe_register and uprobe_unregister. Then it also adds one for task_user_regset_view, which is necessary to get the correct state of userspace registers. Signed-off-by: Josh Stone jist...@redhat.com --- kernel/events/uprobes.c | 3

Re: uprobes && pre-filtering

On 11/06/2012 09:02 AM, Oleg Nesterov wrote: > On 11/06, Srikar Dronamraju wrote: >> Another reason for having the filters in the current way was to have a >> set of standard filters in uprobes code so that all users dont need to >> recreate these filters. > > IOW, you mean that both

Re: uprobes pre-filtering

On 11/06/2012 09:02 AM, Oleg Nesterov wrote: On 11/06, Srikar Dronamraju wrote: Another reason for having the filters in the current way was to have a set of standard filters in uprobes code so that all users dont need to recreate these filters. IOW, you mean that both

systemtap release 2.0

e dyninst/README and the systemtap/dyninst Bugzilla component (http://tinyurl.com/stapdyn-PR-list) if you want all the gory details about the state of the feature. = Contributors for this release Alexander Lochmann*, Bryn M. Reeves, Chris Meek, Dave Brolley, David Smith, Dennis Gil

systemtap release 2.0

, Dennis Gilmore*, Frank Ch. Eigler, Jiri Slaby*, Josh Stone, Mark Wielaard, Peter Robinson, Robin Lee*, Serguei Makarov, Stan Cox, Torsten Polle*, William Cohen Special thanks to new contributors, marked with '*' above. Special thanks to Serguei Makarov for drafting these notes. = Bugs