Re: [PATCH 2/2] add some safety checks for label store interface of flash dev in sysfs

2018-09-14 Thread Junhui Tang
Seems something wrong when size = SB_LABEL_SIZE and u->label[size - 1] != '\n' please check again. --- Tang Junhui Forever me is me --- Dongbo Cao

Re: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-10 Thread Junhui Tang
This patch is NOT OK to me,maybe many cache in a cache_set, and some cache are not registered yet, so ca is possible NULL. zhong jiang 于2018年9月8日周六 下午7:52写道: > > The iterator in for_each_cache is never null, therefore, remove > the redundant null pointer check. > > Signed-off-by: zhong jiang >

Re: [PATCH] bcache: remove redundant condition before debugfs_remove

2018-09-09 Thread Junhui Tang
LGTM Reviewed-by: tang.junhui.li...@gmail.com zhong jiang 于2018年9月8日周六 下午9:08写道: > > debugfs_remove has taken the IS_ERR_OR_NULL into account. Just > remove the unnecessary condition. > > Signed-off-by: zhong jiang > --- > drivers/md/bcache/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] bcache: remove unecessary condition check before debugfs_remove_recursive

2018-09-09 Thread Junhui Tang
LGTM Reviewed-by: tang.junhui.li...@gmail.com zhong jiang 于2018年9月8日周六 下午9:41写道: > > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang > --- > drivers/md/bcache/debug.c | 3 +-- >