RE: [PATCH v2] RDMA/qedr: Remove enumerated type qed_roce_ll2_tx_dest

> From: Nick Desaulniers > Sent: Friday, September 28, 2018 1:30 AM > > External Email > > On Thu, Sep 27, 2018 at 1:57 PM Nathan Chancellor > wrote: > > > > Clang warns when one enumerated type is explicitly converted to another. > > > > drivers/infiniband/hw/qedr/qedr_roce_cm.c:198:28:

RE: [PATCH v2] RDMA/qedr: Remove enumerated type qed_roce_ll2_tx_dest

> From: Nick Desaulniers > Sent: Friday, September 28, 2018 1:30 AM > > External Email > > On Thu, Sep 27, 2018 at 1:57 PM Nathan Chancellor > wrote: > > > > Clang warns when one enumerated type is explicitly converted to another. > > > > drivers/infiniband/hw/qedr/qedr_roce_cm.c:198:28:

RE: [PATCH v5 3/3] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Tuesday, April 03, 2018 11:04 PM > > On Tue, Apr 03, 2018 at 07:42:28AM +0000, Kalderon, Michal wrote: > > > From: Sinan Kaya [mailto:ok...@codeaurora.org] > > > Sent: Tuesday, April 03, 2018 5:30 AM > >

RE: [PATCH v5 3/3] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Tuesday, April 03, 2018 11:04 PM > > On Tue, Apr 03, 2018 at 07:42:28AM +0000, Kalderon, Michal wrote: > > > From: Sinan Kaya [mailto:ok...@codeaurora.org] > > > Sent: Tuesday, April 03, 2018 5:30 AM > >

RE: [PATCH v5 3/3] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Sinan Kaya [mailto:ok...@codeaurora.org] > Sent: Tuesday, April 03, 2018 5:30 AM > To: linux-r...@vger.kernel.org; ti...@codeaurora.org; > sulr...@codeaurora.org > Cc: linux-arm-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Kalderon, Michal <micha

RE: [PATCH v5 3/3] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Sinan Kaya [mailto:ok...@codeaurora.org] > Sent: Tuesday, April 03, 2018 5:30 AM > To: linux-r...@vger.kernel.org; ti...@codeaurora.org; > sulr...@codeaurora.org > Cc: linux-arm-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Kalderon, Michal ; Elior, Arie

RE: [PATCH v4 6/6] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Sinan Kaya [mailto:ok...@codeaurora.org] > Sent: Tuesday, March 20, 2018 4:48 AM > > Code includes wmb() followed by writel() in multiple places. writel() already > has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing

RE: [PATCH v4 6/6] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2

> From: Sinan Kaya [mailto:ok...@codeaurora.org] > Sent: Tuesday, March 20, 2018 4:48 AM > > Code includes wmb() followed by writel() in multiple places. writel() already > has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing

RE: [PATCH] qlogic/qed: Constify *pkt_type_str[]

> From: Hernán Gonzalez [mailto:her...@vanguardiasur.com.ar] > Sent: Wednesday, February 28, 2018 12:32 AM > > Note: This is compile only tested as I have no access to the hw. > Constifying and declaring as static saves 24 bytes. > > add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24) >

RE: [PATCH] qlogic/qed: Constify *pkt_type_str[]

> From: Hernán Gonzalez [mailto:her...@vanguardiasur.com.ar] > Sent: Wednesday, February 28, 2018 12:32 AM > > Note: This is compile only tested as I have no access to the hw. > Constifying and declaring as static saves 24 bytes. > > add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24) >

RE: [PATCH] qed: code indent should use tabs where possible

> From: Rohit Visavalia [mailto:rohit.visava...@softnautics.com] > Sent: Thursday, January 25, 2018 12:26 PM > To: Elior, Ariel ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Rohit Visavalia >

RE: [PATCH] qed: code indent should use tabs where possible

> From: Rohit Visavalia [mailto:rohit.visava...@softnautics.com] > Sent: Thursday, January 25, 2018 12:26 PM > To: Elior, Ariel ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Rohit Visavalia > > Subject: [PATCH] qed: code

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> > goto err; >> > >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan Carpenter > > diff --git

RE: [PATCH] RDMA/qedr: fix build error without ipv6

> From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, September 05, 2017 5:59 PM > To: Amrani, Ram <ram.amr...@cavium.com>; Kalderon, Michal > <michal.kalde...@cavium.com>; Elior, Ariel <ariel.el...@cavium.com>; > Doug Ledford <dledf...@redhat.com>; S

RE: [PATCH] RDMA/qedr: fix build error without ipv6

> From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, September 05, 2017 5:59 PM > To: Amrani, Ram ; Kalderon, Michal > ; Elior, Ariel ; > Doug Ledford ; Sean Hefty > ; Hal Rosenstock > Cc: Arnd Bergmann ; David S. Miller > ; Mintz, Yuval ; linux- > r...@vg

Re: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr

From: Ismail, Mustafa Sent: Wednesday, July 19, 2017 5:38 PM > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > > > Cc: # v2.6.14+ > > > > Reviewed-by: Steve Wise > > > > Signed-off-by:

Re: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr

From: Ismail, Mustafa Sent: Wednesday, July 19, 2017 5:38 PM > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > > > Cc: # v2.6.14+ > > > > Reviewed-by: Steve Wise > > > > Signed-off-by: Mustafa Ismail > > > > > Why is the second patch required if you only

RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr

> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Marciniszyn, Mike > > Initialize the port_num for iWARP in rdma_init_qp_attr. > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > Cc: # v2.6.14+

RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr

> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Marciniszyn, Mike > > Initialize the port_num for iWARP in rdma_init_qp_attr. > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > Cc: # v2.6.14+ > > Reviewed-by: Steve

RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

> From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the macro, > the > value of variable rc is

RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

> From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the macro, > the > value of variable rc is 0. Because 0 means no