Re: [Patch v5 12/12] Documention: v4l: Documentation for HEVC CIDs

2017-06-28 Thread Kamil Debski
Hi, Please find my comments inline. On 19 June 2017 at 07:10, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > Documentation/media/uapi/v4l/extended-controls.rst | 364 > + > 1 file changed, 364 insertions(+) > > diff

Re: [Patch v5 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements

2017-06-27 Thread Kamil Debski
x->luma_dpb_size + > ctx->chroma_dpb_size > + + ctx->me_buffer_size); > + } > } > > writel(buf_addr1, mfc_regs->e_scratch_buffer_addr); > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > index 021b8db..975bbc5 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > @@ -26,6 +26,8 @@ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 128) > #define S5P_MFC_DEC_MV_SIZE_V10(x, y) (MB_WIDTH(x) * \ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 512) > +#define enc_lcu_width(x_size) DIV_ROUND_UP(x_size, 32) > +#define enc_lcu_height(y_size) DIV_ROUND_UP(y_size, 32) Why is this in lower case? Maybe S5P_MFC_LCU_WIDTH/HEIGHT would be better? > > /* Definition */ > #define ENC_MULTI_SLICE_MB_MAX ((1 << 30) - 1) > -- > 2.7.4 > Apart from the above, it looks good to me. Acked-by: Kamil Debski Best wishes, Kamil Debski

[PATCH] MAINTAINERS: update email and list of Samsung HW driver maintainers

2016-08-01 Thread Kamil Debski
Change my email address in the MAINTAINERS file. Add new maintainers of selected Samsung HW drivers. Signed-off-by: Kamil Debski Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Guenter Roeck Cc: Kishon Vijay Abraham I Cc: Mauro Carvalho Chehab Cc: linux-hw...@vger.kernel.org Cc: Andrzej Hajda

RE: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()

2016-06-28 Thread Kamil Debski
of linuxtv/master is : "commit 0db5c79989de2c68d5abb7ba891bfdb3cd3b7e05 Author: Mauro Carvalho Chehab Date: Thu Jun 16 08:04:40 2016 -0300 [media] media-devnode.h: Fix documentation" Could you please rebase the two patches mentioned above to the linuxtv/master? Best wishes, -- Ka

RE: [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

2016-04-01 Thread Kamil Debski
dout and expose real PWM state even when the PWM has just been > requested (before the user calls pwm_config/enable/disable()). > > Signed-off-by: Boris Brezillon Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland

RE: [PATCH v5 35/46] hwmon: pwm-fan: switch to the atomic API

2016-04-01 Thread Kamil Debski
t; > Signed-off-by: Boris Brezillon Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland

RE: [PATCH 1/1] mtd: nand_bbt: separate struct nand_chip from nand_bbt.c

2015-06-25 Thread Kamil Debski
find it below. Best wishes, Kamil Debski From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf Of Peter Pan ?? (peterpandong) Sent: 15 May 2015 08:32 > Currently nand_bbt.c is tied with struct nand_chip, and it makes other > NAND family chips hard to use nand_bbt.c. Mayb

RE: [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array

2015-03-04 Thread Kamil Debski
d-off-by: Axel Lin Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland > --- > drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12- > usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 - > 3 files changed, 3 deletions(-) > >

RE: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

2014-12-11 Thread Kamil Debski
Hi, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Thursday, December 11, 2014 7:30 AM > To: Kishon Vijay Abraham I; Kamil Debski > Cc: linux-kernel@vger.kernel.org; Linux USB Mailing List; Vivek Gautam > Subject: Re: [PATCH] phy: phy-samsung-usb2: Don'

RE: [PATCH] media / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-03 Thread Kamil Debski
Hi, > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Wednesday, December 03, 2014 3:14 AM > To: linux-me...@vger.kernel.org > Cc: Kyungmin Park; Sylwester Nawrocki; Mauro Carvalho Chehab; Kukjin > Kim; linux-samsung-...@vger.kernel.org; Kamil Debski; Philipp Zabel;

RE: [PATCH 09/12] media: s5p-mfc: use vb2_ops_wait_prepare/finish helper

2014-11-25 Thread Kamil Debski
Hi, Please provide a commit description. No matter how obvious the commit seems. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Lad, Prabhakar [mailto:prabhakar.cse...@gmail.com] > Sent: Tuesday, November 18, 2014 12:24 PM >

[PATCH v2] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2014-11-04 Thread Kamil Debski
Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the "pwm" label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski --- Changes since v1: - added pwm label to the pwm@139D node in exynos4.dtsi - u

[PATCH] hwmon: (pwm-fan) Fix suspend/resume behavior

2014-11-03 Thread Kamil Debski
The state of a PWM output is not clearly defined after resume. Some PWM drivers do not restore the duty cycle upon resume, thus it is necessary to manually restore the correct value. Signed-off-by: Kamil Debski --- drivers/hwmon/pwm-fan.c | 13 ++--- 1 file changed, 10 insertions

[PATCH] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2014-11-03 Thread Kamil Debski
Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts

RE: [PATCH] [media] s5p-mfc: Use decode status instead of display status on MFCv5

2014-09-23 Thread Kamil Debski
Hi Sjoerd, > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sjoerd Simons > Sent: Monday, September 22, 2014 2:52 PM > To: Kyungmin Park; Kamil Debski; Arun Kumar K > Cc: Mauro Carvalho Chehab; linux-arm-ker...@lists.infradead.o

[PATCH v2] MAINTAINERS: add entry for the Samsung USB2 PHY driver

2014-08-21 Thread Kamil Debski
Add MAINTAINERS entry for the Samsung USB2 PHY driver. Signed-off-by: Kamil Debski --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6 +7873,19 @@ S

[PATCH] MAINTAINERS: add entry for the Samsung USB2 PHY driver

2014-08-20 Thread Kamil Debski
Signed-off-by: Kamil Debski --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6 +7873,19 @@ S: Supported L: net...@vger.kernel.org F: drivers

[PATCH] MAINTAINERS: add entry for the PWM fan driver

2014-08-20 Thread Kamil Debski
Signed-off-by: Kamil Debski --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 548602f..38e4765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7244,6 +7244,14 @@ T: git git://linuxtv.org/media_tree.git S: Maintained F

RE: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Kamil Debski
Hi Guenter, > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: Wednesday, July 16, 2014 3:53 PM > To: Kamil Debski; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; lm-sens...@lm-sensors.org > Cc: t.f...@samsung.com; m.szyprow...@samsung.com; tklau...@dist

[PATCH v5] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Kamil Debski
The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski Reviewed-by: Varka Bhadram Reviewed-by: Tobias Klauser --- Changes since

RE: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Kamil Debski
Hi Varka, Thank you for the review. I agree with your comments in this and your second email. I have just sent an updated version 4 of the patch. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Varka Bhadram [mailto:varkabhad...@gmail.c

[PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Kamil Debski
The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v3: - fix missing "\n" in error message

[PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Kamil Debski
The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v2: - add CONFIG_PM_SLEEP around pwm_fan_suspend and

[PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

2014-07-14 Thread Kamil Debski
The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v1: - added documentation to Documentation/hwmon - fix

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

2014-07-14 Thread Kamil Debski
Hi, I forgot to address one of the comments. > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: Wednesday, July 09, 2014 6:58 PM > To: Kamil Debski > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; lm- > sens...@lm-sensors.org;

RE: [PATCH] hwmon: pwm-fan: Add pwm-fan driver

2014-07-10 Thread Kamil Debski
Hi Tobias, Thank you for your review. > From: Tobias Klauser [mailto:tklau...@distanz.ch] > Sent: Wednesday, July 09, 2014 7:50 PM > > On 2014-07-09 at 16:53:20 +0200, Kamil Debski > wrote: > > The pwm-fan driver enables control of fans connected to PWM lines. > &g

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

2014-07-10 Thread Kamil Debski
Hi Guenter, Thank you for your review. > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: Wednesday, July 09, 2014 6:58 PM > > On Wed, Jul 09, 2014 at 04:53:20PM +0200, Kamil Debski wrote: > > The pwm-fan driver enables control of fans c

[PATCH] hwmon: gpio-fan: Change name passed to hwmon_device_register_with_groups

2014-07-09 Thread Kamil Debski
Commit 648cd48c9e566f53c5df30d79857e0937ae13b09 (hwmon: Do not accept invalid name attributes) added check for "-" in the name of hwmon device. This patch changes the name supplied by gpio-fan so that it is accepted by hwmon. Signed-off-by: Kamil Debski --- drivers/hwmon/gpio-fan.c |

[PATCH] hwmon: pwm-fan: Add pwm-fan driver

2014-07-09 Thread Kamil Debski
The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- .../devicetree/bindings/hwmon/pwm-fan.txt | 12 ++ drivers

[PATCH v2] phy: phy-samsung-usb2: Change phy power on/power off sequence

2014-07-01 Thread Kamil Debski
The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski --- drivers/phy/phy

RE: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

2014-06-24 Thread Kamil Debski
Hi Daniel, > From: Daniel Drake [mailto:dr...@endlessm.com] > Sent: Tuesday, June 24, 2014 5:09 PM > > On Tue, Jun 24, 2014 at 1:54 PM, Kamil Debski > wrote: > > The Exynos4412 USB 2.0 PHY hardware differs from the description > > provided in the documentation. Some r

[PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

2014-06-24 Thread Kamil Debski
The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski --- drivers/phy/phy

RE: [PATCH] phy: exynos: fix building as a module

2014-03-13 Thread Kamil Debski
spotting this error. Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index > 2faf78e..7728518 100644 > --- a/drivers/phy/Makefile

[PATCH v10 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v10 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-06 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v10 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-06 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v10 1/4] phy: core: Add an exported of_phy_get function

2014-03-06 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v10 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kamil Debski
Hi, This is the tenth version of this patchset. The only difference since v9 is correction in the documentation. Best wishes, Kamil Debski -- Changes from v9: 1) phy: core: Add an exported of_phy_get function - No changes since v9. 2) phy: core: Add devm_of_phy_get to phy-core

RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kamil Debski
msung-usb2.c > > @@ -0,0 +1,222 @@ > > +/* > > + * Samsung SoC USB 1.1/2.0 PHY driver > > + * > > + * Copyright (C) 2013 Samsung Electronics Co., Ltd. > > + * Author: Kamil Debski > > + * > > + * This program is free software; you can redistribute it and/

RE: [PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-06 Thread Kamil Debski
onsider adding a "Tested-by" tag? I am planning to send v10 soon, which will address comments to v9. > > With best wishes, > Tobias Best wishes, -- Kamil Debski Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

[PATCH v9 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-05 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. v9 brings whitespace corrections compared to v8. Best wishes, Kamil Debski -- Changes from v8: 1) phy: core: Add an exported of_phy_get function - No changes since

[PATCH v9 1/4] phy: core: Add an exported of_phy_get function

2014-03-05 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v8 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v8 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v8 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-05 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v8 1/4] phy: core: Add an exported of_phy_get function

2014-03-05 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v8 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. Best wishes, Kamil Debski -- Changes from v7: 1) phy: core: Add an exported of_phy_get function - No changes since v7. 2) phy: core: Add devm_of_phy_get to phy

RE: [PATCH v7 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-05 Thread Kamil Debski
Hi Sander, > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Tuesday, March 04, 2014 4:24 PM > > Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the > generic PHY framework. The driver includes support for the Exynos 4210 > and 4x12 SoC families.

[PATCH v7 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4210 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v7 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v7 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-04 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v7 1/4] phy: core: Add an exported of_phy_get function

2014-03-04 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v7 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
testing. Thank you to everyone who joined the discussion, reviewed the patched and contributed to making the code and consequently the Linux Kernel better. Best wishes, Kamil Debski -- Changes from v6: (not including the change that controller patches were removed form this patchset, also

RE: [PATCH v6 5/8] phy: Add new Exynos USB PHY driver

2014-03-03 Thread Kamil Debski
Hi Kishon, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, March 03, 2014 3:28 PM > > Hi, > > On Wednesday 29 January 2014 10:59 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the > > generic PHY

RE: [PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-02-05 Thread Kamil Debski
Hi Alan, Thank you for your review. > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Wednesday, January 29, 2014 9:43 PM > > On Wed, 29 Jan 2014, Kamil Debski wrote: > > > Change the phy provider used from the old one using the USB phy > > framework to

RE: [PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-02-05 Thread Kamil Debski
Hi Olof, Thank you for your review. > From: Olof Johansson [mailto:o...@lixom.net] > Sent: Wednesday, January 29, 2014 9:55 PM > > Hi, > > On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski > wrote: > > Change the phy provider used from the old one using the USB phy

RE: [PATCH v6 3/8] dts: Add usb2phy to Exynos 4

2014-02-05 Thread Kamil Debski
Hi Olof, > From: Olof Johansson [mailto:o...@lixom.net] > Sent: Wednesday, January 29, 2014 9:51 PM > > On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski > wrote: > > Add support to PHY of USB2 of the Exynos 4 SoC. > > > > Signed-off-by: Kamil Debski > &g

RE: [PATCH v2 1/2] drivers/media: v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-01-30 Thread Kamil Debski
dex 1666aab..80e1def 100644 > > --- a/include/uapi/linux/v4l2-controls.h > > +++ b/include/uapi/linux/v4l2-controls.h > > @@ -372,6 +372,8 @@ enum v4l2_mpeg_video_multi_slice_mode { > > #define V4L2_CID_MPEG_VIDEO_DEC_FRAME > (V4L2_CID_MPEG_BASE+224) > > #define V4L2

[PATCH v6 7/8] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-01-29 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v6 8/8] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-01-29 Thread Kamil Debski
Change the phy provider used from the old one using the USB phy framework to a new one using the Generic phy framework. Signed-off-by: Kamil Debski --- .../devicetree/bindings/usb/exynos-usb.txt | 13 +++ drivers/usb/host/ehci-exynos.c | 97

[PATCH v6 3/8] dts: Add usb2phy to Exynos 4

2014-01-29 Thread Kamil Debski
Add support to PHY of USB2 of the Exynos 4 SoC. Signed-off-by: Kamil Debski --- .../devicetree/bindings/arm/samsung/pmu.txt|2 ++ arch/arm/boot/dts/exynos4.dtsi | 31 arch/arm/boot/dts/exynos4210.dtsi | 17

[PATCH v6 2/8] phy: core: Add devm_of_phy_get to phy-core

2014-01-29 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v6 4/8] dts: Add usb2phy to Exynos 5250

2014-01-29 Thread Kamil Debski
Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos5250.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index c4480a1..efeaf87

[PATCH v6 5/8] phy: Add new Exynos USB PHY driver

2014-01-29 Thread Kamil Debski
Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 55 Documentation/phy/samsung-usb2.txt

[PATCH v6 6/8] phy: Add support for S5PV210 to the Exynos USB PHY driver

2014-01-29 Thread Kamil Debski
x bug with setting of clk register] Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 10 + drivers/phy/Makefile |1 + drivers/phy/phy-s5pv210-u

[PATCH v6 0/8] phy: Add new Exynos USB 2.0 PHY driver

2014-01-29 Thread Kamil Debski
V11 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files [1]. Best wishes, Kamil Debski [1] - http://www.spinics.net/lists/linux-samsung-soc/msg24528.html Changes from v5: 1) phy: core: Add an exported of_phy_get function - corrected behaviour of the

[PATCH v6 1/8] phy: core: Add an exported of_phy_get function

2014-01-29 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

RE: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-23 Thread Kamil Debski
V4L2_CID_PAN_RESET: > case V4L2_CID_TILT_RESET: > case V4L2_CID_FLASH_STROBE: > diff --git a/include/uapi/linux/v4l2-controls.h > b/include/uapi/linux/v4l2-controls.h > index 1666aab..bcce536 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/

RE: [PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-08 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, January 06, 2014 11:12 AM > > Hi, > > On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the > > generic PHY

RE: [PATCH RFC alternative ver 1] phy: Exynos 421x USB 2.0 PHY support

2014-01-08 Thread Kamil Debski
Hi Kishon, Thank you for your review. > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, January 06, 2014 11:24 AM > > Hi, > > On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: > > This the alternative version of the support for Exynos 421

RE: [PATCH v5 0/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-02 Thread Kamil Debski
year! -- Kamil Debski Samsung R&D Institute Poland > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Friday, December 20, 2013 2:24 PM > > Hi, > > This is the fifth version of the patchset. It adds a new Exynos USB 2.0 > PHY driver. The driver uses the Generic PH

RE: [PATCH v2 9/9] dts: Add usb2phy to Exynos 5250

2013-12-30 Thread Kamil Debski
Hi, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Thursday, December 26, 2013 11:32 AM > > Hi Kamil, > > > On Fri, Dec 20, 2013 at 6:54 PM, Kamil Debski > wrote: > > Add support to PHY of USB2 of the Exynos 5250 SoC. > > > > Signed-o

RE: [PATCH v5 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-30 Thread Kamil Debski
Hi Vivek, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Thursday, December 26, 2013 11:14 AM > > Hi Kamil, > > > On Fri, Dec 20, 2013 at 6:54 PM, Kamil Debski > wrote: > > Change the phy provider used from the old one using the USB phy > &

[PATCH v4 1/9] phy: core: Add an exported of_phy_get function

2013-12-20 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |1 + 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a

[PATCH v5 6/9] phy: Add support for S5PV210 to the Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
From: Mateusz Krawczuk Add support for the Samsung's S5PV210 SoC to the Exynos USB 2.0 PHY driver. Signed-off-by: Mateusz Krawczuk [k.deb...@samsung.com: cleanup and commit description] [k.deb...@samsung.com: make changes accordingly to the mailing list comments] Signed-off-by: Kamil D

[PATCH v5 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-20 Thread Kamil Debski
Change the phy provider used from the old one using the USB phy framework to a new one using the Generic phy framework. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 35 +++ drivers/usb/host/ehci-exynos.c

[PATCH v2 8/9] dts: Add usb2phy to Exynos 4

2013-12-20 Thread Kamil Debski
Add support to PHY of USB2 of the Exynos 4 SoC. Signed-off-by: Kamil Debski --- .../devicetree/bindings/arm/samsung/pmu.txt|2 ++ arch/arm/boot/dts/exynos4.dtsi | 31 arch/arm/boot/dts/exynos4210.dtsi | 17

[PATCH RFC alternative ver 2] phy: Exynos 421x USB 2.0 PHY support

2013-12-20 Thread Kamil Debski
This the alternative version of the support for Exynos 421x USB 2.0 PHY in the Generic PHY framework. In this version the support for Exynos 4210 and 4212 was joined into one file. Signed-off-by: Kamil Debski --- Hi, This is the second alternative version. Please look at "[PATCH RFC altern

[PATCH RFC alternative ver 1] phy: Exynos 421x USB 2.0 PHY support

2013-12-20 Thread Kamil Debski
This the alternative version of the support for Exynos 421x USB 2.0 PHY in the Generic PHY framework. In this version the support for Exynos 4210 and 4212 was joined into one file. Signed-off-by: Kamil Debski --- Hi, Me and Kishon were discussing for quite a long time the way how Exynos 4

[PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/phy/samsung-phy.txt| 55

[PATCH v5 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-20 Thread Kamil Debski
Change the used phy driver to the new Exynos USB phy driver that uses the generic phy framework. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/usb/samsung-hsotg.txt |4 drivers/usb/gadget/s3c-hsotg.c | 11 ++- 2

[PATCH v5 7/9] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile

[PATCH v2 9/9] dts: Add usb2phy to Exynos 5250

2013-12-20 Thread Kamil Debski
Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos5250.dtsi | 33 --- drivers/phy/phy-exynos5250-usb2.c | 64 + 2 files changed, 78 insertions(+), 19 deletions(-) diff --git a/arch

[PATCH v4 2/9] phy: core: Add devm_of_phy_get to phy-core

2013-12-20 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |2 ++ 2 files changed, 33 insertions(+) diff

[PATCH v5 0/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
ich I will send soon after this patchset. Just like the fourth version this patch depends on: [PATCH V11 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files [1]. Best wishes, Kamil Debski [1] - http://www.spinics.net/lists/linux-samsung-soc/msg24528.html Ch

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-17 Thread Kamil Debski
ons. I understand that after both EHCI and OHCI power on the phy, the usage count is 2. So powering off one of them (EHCI for instance) the usage count is still 1, so the OHCI should still work properly. [snip] Best wishes, -- Kamil Debski Samsung R&D Institute Poland -- To unsu

RE: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-17 Thread Kamil Debski
post an alternative version - integrating as much as possible in a single file. This way it would be possible to have a hands-on comparison of the two approaches we were discussing with Kishon. I estimate that I post it this week. Best wishes, -- Kamil Debski Samsung R&D Institute Po

RE: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, December 16, 2013 10:01 AM > > On Friday 13 December 2013 08:56 PM, Kamil Debski wrote: > > Hi Kishon, > > > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >> Sent: Frid

[PATCH v3 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |1 + 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a

[PATCH v3 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-16 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/phy/phy

RE: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kamil Debski
Hi Kishon, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Friday, December 13, 2013 3:45 PM > > Hi, > > On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: > > Previously the of_phy_get function took a struct device * and was > > declared static

RE: [PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-13 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, December 09, 2013 8:23 AM > > On Friday 06 December 2013 04:22 PM, Kamil Debski wrote: > > Hi, > > > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >> Sent: Frid

[PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-13 Thread Kamil Debski
added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- It seems that my git send-email is playing up and sent the previous emails without from. This is a resend. Sorry for any confusion. --- drivers/phy/phy-core.c | 41

[PATCH v2 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-13 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski --- It seems that my git send-email is playing up and sent the previous emails without from. This is a resend. Sorry for any confusion. --- drivers/phy/phy-core.c | 31

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-09 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, December 09, 2013 8:56 AM > > Hi, > > On Friday 06 December 2013 09:58 PM, Kamil Debski wrote: > > Hi Kishon, > > > > Thank you for the review. > > > >> From: Kish

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-06 Thread Kamil Debski
Hi, > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Friday, December 06, 2013 5:28 PM > > Hi Kishon, > > Thank you for the review. > > > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > > Sent: Friday, December 06, 2013 11:59 AM > > >

RE: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-06 Thread Kamil Debski
Hi, > From: Matt Porter [mailto:matt.por...@linaro.org] > Sent: Friday, December 06, 2013 4:01 PM > > On Fri, Dec 06, 2013 at 04:41:51PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: > > >

  1   2   >