Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Kay Sievers
On Wed, Jun 3, 2015 at 7:30 PM, Lucas De Marchi wrote: > On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell wrote: >> Andreas Mohr writes: >>> Hi, >>> >>> I just had a not so nice experience >>> when finally upgrading to a new 4.1-rc5 >>> with CONFIG_MODULE_COMPRESS newly enabled - >>> userspace

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Kay Sievers
On Wed, Jun 3, 2015 at 7:30 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell ru...@rustcorp.com.au wrote: Andreas Mohr a...@lisas.de writes: Hi, I just had a not so nice experience when finally upgrading to a new 4.1-rc5 with

Re: How to fix CDROM/DVD eject mess?

2015-02-02 Thread Kay Sievers
On Mon, Feb 2, 2015 at 8:34 PM, Maciej W. Rozycki wrote: > On Mon, 2 Feb 2015, Kay Sievers wrote: > >> > I thought that fixing the udev behavior would solve the problem. But >> > it turned out that I was too naive. A bigger problem is that all >> &g

Re: How to fix CDROM/DVD eject mess?

2015-02-02 Thread Kay Sievers
On Mon, Feb 2, 2015 at 2:20 PM, Takashi Iwai wrote: > we've got a bug report about the mishandling of DVD/CDROM media eject > button, and it seems indeed broken since some time ago. In short: > when the eject button is pressed, the media is forcibly ejected no > matter whether it's mounted or in

Re: How to fix CDROM/DVD eject mess?

2015-02-02 Thread Kay Sievers
On Mon, Feb 2, 2015 at 8:34 PM, Maciej W. Rozycki ma...@linux-mips.org wrote: On Mon, 2 Feb 2015, Kay Sievers wrote: I thought that fixing the udev behavior would solve the problem. But it turned out that I was too naive. A bigger problem is that all user-space stuff misinterprets

Re: How to fix CDROM/DVD eject mess?

2015-02-02 Thread Kay Sievers
On Mon, Feb 2, 2015 at 2:20 PM, Takashi Iwai ti...@suse.de wrote: we've got a bug report about the mishandling of DVD/CDROM media eject button, and it seems indeed broken since some time ago. In short: when the eject button is pressed, the media is forcibly ejected no matter whether it's

Re: [PATCH v3 03/11] drivers: base: add new class "cpu" to group cpu devices

2014-08-22 Thread Kay Sievers
On Thu, Aug 21, 2014 at 2:30 PM, Sudeep Holla wrote: > On 21/08/14 12:20, David Herrmann wrote: >> On Thu, Aug 21, 2014 at 12:59 PM, Sudeep Holla >> wrote: >>> >>> From: Sudeep Holla >>> >>> This patch creates a new class called "cpu" and assigns it to all the >>> cpu devices. This helps in

Re: [PATCH v3 03/11] drivers: base: add new class cpu to group cpu devices

2014-08-22 Thread Kay Sievers
On Thu, Aug 21, 2014 at 2:30 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 21/08/14 12:20, David Herrmann wrote: On Thu, Aug 21, 2014 at 12:59 PM, Sudeep Holla sudeep.ho...@arm.com wrote: From: Sudeep Holla sudeep.ho...@arm.com This patch creates a new class called cpu and assigns it to

Re: [PATCH 0/5] printk: more log flag simplification

2014-07-17 Thread Kay Sievers
On Thu, Jul 17, 2014 at 7:59 PM, Alex Elder wrote: > This series rearranges the log code in such a way that the LOG_CONT > and LOG_PREFIX log record flags can be eliminated entirely. The > result should be considerably easier to understand than before. It > builds on another recently-posted

Re: [PATCH 0/5] printk: more log flag simplification

2014-07-17 Thread Kay Sievers
On Thu, Jul 17, 2014 at 7:59 PM, Alex Elder el...@linaro.org wrote: This series rearranges the log code in such a way that the LOG_CONT and LOG_PREFIX log record flags can be eliminated entirely. The result should be considerably easier to understand than before. It builds on another

Re: [RFC PATCH 1/2] printk: Add context information to the header of /dev/kmsg

2014-05-19 Thread Kay Sievers
On Mon, May 19, 2014 at 7:28 PM, Yoshihiro YUNOMAE wrote: > Add context information to the header of /dev/kmsg. > > Two printk messages connected with KERN_CONT can be divided in multiple lines > by a different process context message. If the different context message seems > like the 1st divided

Re: [RFC PATCH 1/2] printk: Add context information to the header of /dev/kmsg

2014-05-19 Thread Kay Sievers
On Mon, May 19, 2014 at 7:28 PM, Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: Add context information to the header of /dev/kmsg. Two printk messages connected with KERN_CONT can be divided in multiple lines by a different process context message. If the different context message

Re: [PATCH 3/3] cgroup: implement cgroup.subtree_populated for the default hierarchy

2014-04-15 Thread Kay Sievers
On Tue, Apr 15, 2014 at 8:50 PM, Eric W. Biederman wrote: > Kay Sievers writes: > >> On Tue, Apr 15, 2014 at 7:48 PM, Li Zefan wrote: >>> On 2014/4/15 5:44, Tejun Heo wrote: >>>> cgroup users often need a way to determine when a cgroup's >>>> subhier

Re: [PATCH 3/3] cgroup: implement cgroup.subtree_populated for the default hierarchy

2014-04-15 Thread Kay Sievers
On Tue, Apr 15, 2014 at 7:48 PM, Li Zefan wrote: > On 2014/4/15 5:44, Tejun Heo wrote: >> cgroup users often need a way to determine when a cgroup's >> subhierarchy becomes empty so that it can be cleaned up. cgroup >> currently provides release_agent for it; unfortunately, this mechanism >> is

Re: [PATCH 3/3] cgroup: implement cgroup.subtree_populated for the default hierarchy

2014-04-15 Thread Kay Sievers
On Tue, Apr 15, 2014 at 7:48 PM, Li Zefan lize...@huawei.com wrote: On 2014/4/15 5:44, Tejun Heo wrote: cgroup users often need a way to determine when a cgroup's subhierarchy becomes empty so that it can be cleaned up. cgroup currently provides release_agent for it; unfortunately, this

Re: [PATCH 3/3] cgroup: implement cgroup.subtree_populated for the default hierarchy

2014-04-15 Thread Kay Sievers
On Tue, Apr 15, 2014 at 8:50 PM, Eric W. Biederman ebied...@xmission.com wrote: Kay Sievers k...@vrfy.org writes: On Tue, Apr 15, 2014 at 7:48 PM, Li Zefan lize...@huawei.com wrote: On 2014/4/15 5:44, Tejun Heo wrote: cgroup users often need a way to determine when a cgroup's subhierarchy

Re: [PATCH v5 0/4] Provide netdev naming-policy via sysfs

2014-03-29 Thread Kay Sievers
On Sat, Mar 29, 2014 at 8:37 PM, David Miller wrote: > From: Tom Gundersen > Date: Sat, 29 Mar 2014 10:46:02 +0100 > >> The issue I see with that is that there are several ways to generate >> predictable names, and the user may want to chose between them, so >> this is arguably policy that

Re: [PATCH v5 0/4] Provide netdev naming-policy via sysfs

2014-03-29 Thread Kay Sievers
On Sat, Mar 29, 2014 at 8:37 PM, David Miller da...@davemloft.net wrote: From: Tom Gundersen t...@jklm.no Date: Sat, 29 Mar 2014 10:46:02 +0100 The issue I see with that is that there are several ways to generate predictable names, and the user may want to chose between them, so this is

Re: [PATCH] tty: Add sysfs symlink for console name->tty device

2014-02-27 Thread Kay Sievers
On Thu, Feb 27, 2014 at 2:31 PM, Peter Hurley wrote: > On 02/27/2014 06:13 AM, Kay Sievers wrote: >> >> On Wed, Feb 26, 2014 at 3:40 PM, Peter Hurley >> wrote: >>> >>> Enable a user-space process to discover the underlying tty device >>> for a

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread Kay Sievers
On Tue, Feb 25, 2014 at 10:38 AM, David Herrmann wrote: > On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke wrote: >> Positive? >> I thought this was precisely the problem, ->device() changing the >> index '0' into something non-zero. >> The reports we had were that the line 'tty0' changed into

Re: [PATCH] tty: Add sysfs symlink for console name->tty device

2014-02-27 Thread Kay Sievers
On Wed, Feb 26, 2014 at 3:40 PM, Peter Hurley wrote: > Enable a user-space process to discover the underlying tty device > for a console, if one exists, and when the tty device is later > created or destroyed. > > Add sysfs symlinks for registered consoles to their respective > devices in

Re: [PATCH] tty: Add sysfs symlink for console name-tty device

2014-02-27 Thread Kay Sievers
On Wed, Feb 26, 2014 at 3:40 PM, Peter Hurley pe...@hurleysoftware.com wrote: Enable a user-space process to discover the underlying tty device for a console, if one exists, and when the tty device is later created or destroyed. Add sysfs symlinks for registered consoles to their respective

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread Kay Sievers
On Tue, Feb 25, 2014 at 10:38 AM, David Herrmann dh.herrm...@gmail.com wrote: On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke h...@suse.de wrote: Positive? I thought this was precisely the problem, -device() changing the index '0' into something non-zero. The reports we had were that the

Re: [PATCH] tty: Add sysfs symlink for console name-tty device

2014-02-27 Thread Kay Sievers
On Thu, Feb 27, 2014 at 2:31 PM, Peter Hurley pe...@hurleysoftware.com wrote: On 02/27/2014 06:13 AM, Kay Sievers wrote: On Wed, Feb 26, 2014 at 3:40 PM, Peter Hurley pe...@hurleysoftware.com wrote: Enable a user-space process to discover the underlying tty device for a console, if one

Re: [PATCH] ksm: Expose configuration via sysctl

2014-02-25 Thread Kay Sievers
On Tue, Feb 25, 2014 at 6:34 PM, Dave Hansen wrote: > On 02/24/2014 03:28 PM, Alexander Graf wrote: >> Configuration of tunables and Linux virtual memory settings has traditionally >> happened via sysctl. Thanks to that there are well established ways to make >> sysctl configuration bits

Re: [PATCH] ksm: Expose configuration via sysctl

2014-02-25 Thread Kay Sievers
On Wed, Feb 26, 2014 at 12:16 AM, Alexander Graf wrote: > > >>> Am 26.02.2014 um 01:19 schrieb Peter Zijlstra : >>> On Tue, Feb 25, 2014 at 12:15:28PM -0500, Johannes Weiner wrote: On Tue, Feb 25, 2014 at 12:28:04AM +0100, Alexander Graf wrote: Configuration of tunables and Linux

Re: [PATCH] ksm: Expose configuration via sysctl

2014-02-25 Thread Kay Sievers
On Wed, Feb 26, 2014 at 12:16 AM, Alexander Graf ag...@suse.de wrote: Am 26.02.2014 um 01:19 schrieb Peter Zijlstra pet...@infradead.org: On Tue, Feb 25, 2014 at 12:15:28PM -0500, Johannes Weiner wrote: On Tue, Feb 25, 2014 at 12:28:04AM +0100, Alexander Graf wrote: Configuration of

Re: [PATCH] ksm: Expose configuration via sysctl

2014-02-25 Thread Kay Sievers
On Tue, Feb 25, 2014 at 6:34 PM, Dave Hansen dave.han...@intel.com wrote: On 02/24/2014 03:28 PM, Alexander Graf wrote: Configuration of tunables and Linux virtual memory settings has traditionally happened via sysctl. Thanks to that there are well established ways to make sysctl configuration

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Kay Sievers
On Fri, Feb 21, 2014 at 3:56 PM, Josh Boyer wrote: > On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke wrote: >> On 02/21/2014 03:48 PM, Josh Boyer wrote: >>> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >>> wrote: 3.13-stable review patch. If anyone has any objections, please let

Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

2014-02-21 Thread Kay Sievers
On Fri, Feb 21, 2014 at 3:56 PM, Josh Boyer jwbo...@fedoraproject.org wrote: On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke h...@suse.de wrote: On 02/21/2014 03:48 PM, Josh Boyer wrote: On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: 3.13-stable review

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 2:19 AM, Kay Sievers wrote: > On Mon, Feb 17, 2014 at 1:57 AM, Linus Torvalds > wrote: >> On Sun, Feb 16, 2014 at 4:50 PM, Kay Sievers wrote: >>> >>> That should avoid the overflow, yes. I expect it will not print the >>> firs

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 1:57 AM, Linus Torvalds wrote: > On Sun, Feb 16, 2014 at 4:50 PM, Kay Sievers wrote: >> >> That should avoid the overflow, yes. I expect it will not print the >> first line with a prefix, which we probably should.? > > Well, it's not printing ou

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 1:41 AM, Linus Torvalds wrote: > On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata > wrote: > The third loop does *not* start again from the first line! It > *continues* from where the second loop ended. Which is exactly why > clearing "prev" is *wrong*. Because the

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Sun, Feb 16, 2014 at 9:47 PM, Greg Kroah-Hartman wrote: > On Sun, Feb 16, 2014 at 11:28:36AM -0800, Linus Torvalds wrote: >> Adding Kay and Greg, since the original code is from commit >> 7ff9554bb578 ("printk: convert byte-buffer to variable-length record >> buffer") and all the "prev" flag

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Sun, Feb 16, 2014 at 9:47 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sun, Feb 16, 2014 at 11:28:36AM -0800, Linus Torvalds wrote: Adding Kay and Greg, since the original code is from commit 7ff9554bb578 (printk: convert byte-buffer to variable-length record buffer) and all

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 1:41 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata dbane...@akamai.com wrote: The third loop does *not* start again from the first line! It *continues* from where the second loop ended. Which is exactly why

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 1:57 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Feb 16, 2014 at 4:50 PM, Kay Sievers k...@vrfy.org wrote: That should avoid the overflow, yes. I expect it will not print the first line with a prefix, which we probably should.? Well, it's

Re: [PATCH] printk: Fix discarding of records

2014-02-16 Thread Kay Sievers
On Mon, Feb 17, 2014 at 2:19 AM, Kay Sievers k...@vrfy.org wrote: On Mon, Feb 17, 2014 at 1:57 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Feb 16, 2014 at 4:50 PM, Kay Sievers k...@vrfy.org wrote: That should avoid the overflow, yes. I expect it will not print the first

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-07 Thread Kay Sievers
On Thu, Feb 6, 2014 at 5:29 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 06, 2014 at 04:44:20PM +0100, Hannes Reinecke wrote: >> On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: >> > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: >> >> The 'active' sysfs attribute should refer

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-07 Thread Kay Sievers
On Thu, Feb 6, 2014 at 5:29 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Feb 06, 2014 at 04:44:20PM +0100, Hannes Reinecke wrote: On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: The 'active' sysfs

Re: [PATCH v4 0/3] Send audit/procinfo/cgroup data in socket-level control message

2014-01-23 Thread Kay Sievers
On Thu, Jan 16, 2014 at 10:29 AM, Jan Kaluža wrote: > On 01/16/2014 12:23 AM, Tejun Heo wrote: >> On Wed, Jan 15, 2014 at 06:21:43PM -0500, Eric Paris wrote: >>> >>> Reliably being able to audit what process requested an action is >>> extremely useful. And I like the audit patch, as it is a

Re: [PATCH v4 0/3] Send audit/procinfo/cgroup data in socket-level control message

2014-01-23 Thread Kay Sievers
On Thu, Jan 16, 2014 at 10:29 AM, Jan Kaluža jkal...@redhat.com wrote: On 01/16/2014 12:23 AM, Tejun Heo wrote: On Wed, Jan 15, 2014 at 06:21:43PM -0500, Eric Paris wrote: Reliably being able to audit what process requested an action is extremely useful. And I like the audit patch, as it is

Re: [PATCH] printk: flush conflicting continuation line

2014-01-02 Thread Kay Sievers
On Fri, Jan 3, 2014 at 1:57 AM, Joe Perches wrote: > (Adding Kay to cc's) > > Kay? any opinion on correctness? Sounds fine by looking at it. Did not test anything though. >> > --- a/kernel/printk/printk.c >> > +++ b/kernel/printk/printk.c >> > @@ -1604,7 +1604,10 @@ asmlinkage int

Re: [PATCH] printk: flush conflicting continuation line

2014-01-02 Thread Kay Sievers
On Fri, Jan 3, 2014 at 1:57 AM, Joe Perches j...@perches.com wrote: (Adding Kay to cc's) Kay? any opinion on correctness? Sounds fine by looking at it. Did not test anything though. --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -1604,7 +1604,10 @@ asmlinkage int

Re: Re: [PATCH 0/2] [BUGFIX] printk: Fix message continuation breakage involved with structured printk

2013-12-23 Thread Kay Sievers
On Tue, Dec 24, 2013 at 3:50 AM, Yoshihiro YUNOMAE wrote: > (2013/12/20 20:29), Kay Sievers wrote: >> >> On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE >> wrote: >> >>> This patch set fixes message continuation breakage involved with >>> struct

Re: Re: [PATCH 0/2] [BUGFIX] printk: Fix message continuation breakage involved with structured printk

2013-12-23 Thread Kay Sievers
On Tue, Dec 24, 2013 at 3:50 AM, Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: (2013/12/20 20:29), Kay Sievers wrote: On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: This patch set fixes message continuation breakage involved

Re: [PATCH 2/2] printk: Delete LOG_NEWLINE flag for structured printk

2013-12-20 Thread Kay Sievers
On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE wrote: > Delete LOG_NEWLINE flag for structured printk. > When structured printk is used, the next printk message is output in a new > line > from patch c313af145b9bc4fb8e8e0c83b8cfc10e1b894a50. However, in a following > pseudo SCSI error test,

Re: [PATCH 1/2] printk: Add dictionary information in structure cont

2013-12-20 Thread Kay Sievers
. This patch stores the dict information in structure > cont > first, then the information in cont is stored to log_buf. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Kay Sievers > Cc: Andrew Morton > Cc: Joe Perches > Cc: Tejun Heo > Cc: Frederic Weisbecker > Cc: l

Re: [PATCH 0/2] [BUGFIX] printk: Fix message continuation breakage involved with structured printk

2013-12-20 Thread Kay Sievers
On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE wrote: > This patch set fixes message continuation breakage involved with structured > printk. A SCSI driver may output two continuation error messages like > scmd_printk("foo"); > printf("bar\n"); Which is the absolutely wrong thing

Re: [PATCH 0/2] [BUGFIX] printk: Fix message continuation breakage involved with structured printk

2013-12-20 Thread Kay Sievers
On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: This patch set fixes message continuation breakage involved with structured printk. A SCSI driver may output two continuation error messages like scmd_printk(foo); printf(bar\n); Which is the

Re: [PATCH 1/2] printk: Add dictionary information in structure cont

2013-12-20 Thread Kay Sievers
the information to log_buf. This patch stores the dict information in structure cont first, then the information in cont is stored to log_buf. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Kay Sievers k...@vrfy.org Cc: Andrew Morton a...@linux-foundation.org Cc: Joe Perches j

Re: [PATCH 2/2] printk: Delete LOG_NEWLINE flag for structured printk

2013-12-20 Thread Kay Sievers
On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: Delete LOG_NEWLINE flag for structured printk. When structured printk is used, the next printk message is output in a new line from patch c313af145b9bc4fb8e8e0c83b8cfc10e1b894a50. However, in a

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-15 Thread Kay Sievers
On Sun, Dec 15, 2013 at 12:33 PM, Martin Mares wrote: >> It does that per process doing that, and that's the problem for how >> udev works/worked. The binary hwdb is on-disk and can be mmaped, and >> there is no difference between initialization, first, or subsequent >> queries. > > OK, point

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-15 Thread Kay Sievers
On Sun, Dec 15, 2013 at 10:18 AM, Martin Mares wrote: > Hello Kay, > >> Libpci and its linear search through megabytes of text files for evey >> new query is too inefficient, that we cannot afford to use it during >> early bootup. It was the largest hit left in bootup profiling on >> machines

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-15 Thread Kay Sievers
On Sun, Dec 15, 2013 at 10:18 AM, Martin Mares m...@ucw.cz wrote: Hello Kay, Libpci and its linear search through megabytes of text files for evey new query is too inefficient, that we cannot afford to use it during early bootup. It was the largest hit left in bootup profiling on machines

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-15 Thread Kay Sievers
On Sun, Dec 15, 2013 at 12:33 PM, Martin Mares m...@ucw.cz wrote: It does that per process doing that, and that's the problem for how udev works/worked. The binary hwdb is on-disk and can be mmaped, and there is no difference between initialization, first, or subsequent queries. OK, point

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-14 Thread Kay Sievers
On Sun, Dec 15, 2013 at 1:23 AM, Tom Gundersen wrote: >> Also, did you consider the opposite, that is making hwdb call libpci >> to resolve PCI IDs? What are the downsides? > > Well, part of the reason for introducing the hwdb was to avoid libpci for > performance reasons (I added Kay in cc who

Re: [PATCH RESEND][pciutils] libpci: pci_id_lookup - add udev/hwdb support

2013-12-14 Thread Kay Sievers
On Sun, Dec 15, 2013 at 1:23 AM, Tom Gundersen t...@jklm.no wrote: Also, did you consider the opposite, that is making hwdb call libpci to resolve PCI IDs? What are the downsides? Well, part of the reason for introducing the hwdb was to avoid libpci for performance reasons (I added Kay in cc

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 3:08 AM, Kyungmin Park wrote: > On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers wrote: >> On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh >> wrote: >>> On Tue, 12 Nov 2013, Jingoo Han wrote: >>>> On Tuesday, November 1

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh wrote: > On Tue, 12 Nov 2013, Jingoo Han wrote: >> On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: >> > From: Kyungmin Park >> > >> > The most mobile phones have Ambient Light Sensors and it changes >> > brightness

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and it

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 3:08 AM, Kyungmin Park kmp...@infradead.org wrote: On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12

Re: [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd

2013-09-10 Thread Kay Sievers
On Tue, Sep 10, 2013 at 7:02 PM, Alan Stern wrote: > Where is MODULE_SOFTDEP defined? It isn't mentioned in any .h files in > my kernel tree. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7cb14ba75d57910cc4b62115dd5db7bd83c93684 Kay -- To unsubscribe from this

Re: [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd

2013-09-10 Thread Kay Sievers
On Tue, Sep 10, 2013 at 7:02 PM, Alan Stern st...@rowland.harvard.edu wrote: Where is MODULE_SOFTDEP defined? It isn't mentioned in any .h files in my kernel tree. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7cb14ba75d57910cc4b62115dd5db7bd83c93684 Kay -- To

Re: [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.

2013-09-09 Thread Kay Sievers
On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen wrote: > Hi Konrad, > > The above commit (c70bda9 in mainline) doesn't appear to work for me. > I.e., depmod does not create an entry in modules.devname and hence no > device node is created on boot. > > If I understand correctly, you'd also need to

Re: [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.

2013-09-09 Thread Kay Sievers
On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen t...@jklm.no wrote: Hi Konrad, The above commit (c70bda9 in mainline) doesn't appear to work for me. I.e., depmod does not create an entry in modules.devname and hence no device node is created on boot. If I understand correctly, you'd also need

Re: [PATCH v2 3/3] Send cgroup_path in SCM_CGROUP

2013-09-02 Thread Kay Sievers
On Thu, Aug 29, 2013 at 4:13 PM, Jan Kaluza wrote: > Add new SCM type called SCM_CGROUP to send "cgroup_path" in SCM. > This is useful for journald (systemd logging daemon) to get additional context > with each log line received using UNIX socket. > > Signed-off-by: Jan Kaluza In many cases

Re: [PATCH v2 3/3] Send cgroup_path in SCM_CGROUP

2013-09-02 Thread Kay Sievers
On Thu, Aug 29, 2013 at 4:13 PM, Jan Kaluza jkal...@redhat.com wrote: Add new SCM type called SCM_CGROUP to send cgroup_path in SCM. This is useful for journald (systemd logging daemon) to get additional context with each log line received using UNIX socket. Signed-off-by: Jan Kaluza

Re: [PATCH] udev: fail firmware loading immediately if no search path is defined

2013-08-10 Thread Kay Sievers
On Sat, Aug 10, 2013 at 11:00 PM, Tom Gundersen wrote: > It would be simple enough to add an udev rule to just print 'ignoring > firmware event' to the logs. This and I guess: SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1" would also just cancel the request at the same time without

Re: [PATCH] udev: fail firmware loading immediately if no search path is defined

2013-08-10 Thread Kay Sievers
On Sat, Aug 10, 2013 at 11:00 PM, Tom Gundersen t...@jklm.no wrote: It would be simple enough to add an udev rule to just print 'ignoring firmware event' to the logs. This and I guess: SUBSYSTEM==firmware, ACTION==add, ATTR{loading}=-1 would also just cancel the request at the same time

Re: [systemd-devel] Slow firmware timeouts again (Re: [3.11 regression?] iwlwifi firmware takes two minutes to load)

2013-08-05 Thread Kay Sievers
On Fri, Aug 2, 2013 at 6:28 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Aug 02, 2013 at 09:04:44AM -0700, Andy Lutomirski wrote: >> CONFIG_FW_LOADER_USER_HELPER=y > Do you need this? Unsetting this should help. > > """This option enables / disables the invocation of user-helper > (e.g. udev)

Re: [systemd-devel] Slow firmware timeouts again (Re: [3.11 regression?] iwlwifi firmware takes two minutes to load)

2013-08-05 Thread Kay Sievers
On Fri, Aug 2, 2013 at 6:28 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Aug 02, 2013 at 09:04:44AM -0700, Andy Lutomirski wrote: CONFIG_FW_LOADER_USER_HELPER=y Do you need this? Unsetting this should help. This option enables / disables the invocation of user-helper

Re: Re: [RFC PATCH 0/5] Add a hash value for each line in /dev/kmsg

2013-07-29 Thread Kay Sievers
On Mon, Jul 29, 2013 at 1:54 PM, Hidehiro Kawai wrote: > Also, I heard about the discussion > at the kernel summit 2 years ago. According to the article of LWN, > it seems that Linus objected your approach (i.e. adding random bit as > message ID). Were there some agreements on this issue at

Re: Re: [RFC PATCH 0/5] Add a hash value for each line in /dev/kmsg

2013-07-29 Thread Kay Sievers
On Mon, Jul 29, 2013 at 1:54 PM, Hidehiro Kawai hidehiro.kawai...@hitachi.com wrote: Also, I heard about the discussion at the kernel summit 2 years ago. According to the article of LWN, it seems that Linus objected your approach (i.e. adding random bit as message ID). Were there some

Re: [RFC PATCH 0/5] Add a hash value for each line in /dev/kmsg

2013-07-26 Thread Kay Sievers
On Wed, Jul 3, 2013 at 3:46 AM, Hidehiro Kawai wrote: > This patch series adds hash values of printk format strings into > each line of /dev/kmsg outputs as follows: > > 6,154,325061,-,b7db707c@kernel/smp.c:554;Brought up 4 CPUs /dev/kmsg is to a certain degree a kernel ABI. Having

Re: [RFC PATCH 0/5] Add a hash value for each line in /dev/kmsg

2013-07-26 Thread Kay Sievers
On Wed, Jul 3, 2013 at 3:46 AM, Hidehiro Kawai hidehiro.kawai...@hitachi.com wrote: This patch series adds hash values of printk format strings into each line of /dev/kmsg outputs as follows: 6,154,325061,-,b7db707c@kernel/smp.c:554;Brought up 4 CPUs /dev/kmsg is to a certain degree

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Kay Sievers
On Thu, Jul 25, 2013 at 5:03 PM, Dave Hansen wrote: > On 07/25/2013 04:14 AM, KY Srinivasan wrote: >> As promised, I have sent out the patches for (a) an implementation of an >> in-kernel API >> for onlining and a consumer for this API. While I don't know the exact >> reason why the >> user

Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining memory blocks

2013-07-25 Thread Kay Sievers
On Thu, Jul 25, 2013 at 5:03 PM, Dave Hansen d...@sr71.net wrote: On 07/25/2013 04:14 AM, KY Srinivasan wrote: As promised, I have sent out the patches for (a) an implementation of an in-kernel API for onlining and a consumer for this API. While I don't know the exact reason why the user

Re: udev: New default rule for autoloading kernel modules matching CPU modalias

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 1:47 PM, Kay Sievers wrote: > On Sat, Jul 20, 2013 at 12:56 PM, Rafael J. Wysocki wrote: > >> After a recent change present in 3.11-rc1 there is a driver, called >> processor, >> that can be bound to the CPU devices whose sysfs directories are l

Re: udev: New default rule for autoloading kernel modules matching CPU modalias

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 12:56 PM, Rafael J. Wysocki wrote: > After a recent change present in 3.11-rc1 there is a driver, called processor, > that can be bound to the CPU devices whose sysfs directories are located under > /sys/devices/system/cpu/. A side effect of this is that, after the

Re: udev: New default rule for autoloading kernel modules matching CPU modalias

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 12:56 PM, Rafael J. Wysocki r...@sisk.pl wrote: After a recent change present in 3.11-rc1 there is a driver, called processor, that can be bound to the CPU devices whose sysfs directories are located under /sys/devices/system/cpu/. A side effect of this is that, after

Re: udev: New default rule for autoloading kernel modules matching CPU modalias

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 1:47 PM, Kay Sievers k...@vrfy.org wrote: On Sat, Jul 20, 2013 at 12:56 PM, Rafael J. Wysocki r...@sisk.pl wrote: After a recent change present in 3.11-rc1 there is a driver, called processor, that can be bound to the CPU devices whose sysfs directories are located

Re: cgroup: status-quo and userland efforts

2013-07-02 Thread Kay Sievers
On Wed, Jul 3, 2013 at 1:57 AM, Thomas Gleixner wrote: > On Sun, 30 Jun 2013, Lennart Poettering wrote: >> On 29.06.2013 05:05, Tim Hockin wrote: >> > But that's not my point. It seems pretty easy to make this cgroup >> > management (in "native mode") a library that can have either a thin >> >

Re: cgroup: status-quo and userland efforts

2013-07-02 Thread Kay Sievers
On Wed, Jul 3, 2013 at 1:57 AM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 30 Jun 2013, Lennart Poettering wrote: On 29.06.2013 05:05, Tim Hockin wrote: But that's not my point. It seems pretty easy to make this cgroup management (in native mode) a library that can have either a thin

Re: [PATCH] proc: make high precision system boot time available

2013-06-30 Thread Kay Sievers
On Sat, Jun 29, 2013 at 10:53 PM, Sami Kerola wrote: > BTW having a way to measure effect of suspend/resume could lead to a > way to fix time time distortion. > Perhaps there is better alternative to fix user space programs. > Unfortunately I do not have either knowledge, or imagination, to

Re: [PATCH] proc: make high precision system boot time available

2013-06-30 Thread Kay Sievers
On Sat, Jun 29, 2013 at 10:53 PM, Sami Kerola kerol...@iki.fi wrote: BTW having a way to measure effect of suspend/resume could lead to a way to fix time time distortion. Perhaps there is better alternative to fix user space programs. Unfortunately I do not have either knowledge, or

Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown

2013-05-08 Thread Kay Sievers
On Wed, May 8, 2013 at 6:26 PM, Takashi Iwai wrote: > At Thu, 9 May 2013 00:07:17 +0800, > Ming Lei wrote: >> On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai wrote: >> > Hi, >> > >> > this is a series of patches for the issue we faced in the firmware >> > loader code during debugging the problem

Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown

2013-05-08 Thread Kay Sievers
On Wed, May 8, 2013 at 6:26 PM, Takashi Iwai ti...@suse.de wrote: At Thu, 9 May 2013 00:07:17 +0800, Ming Lei wrote: On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai ti...@suse.de wrote: Hi, this is a series of patches for the issue we faced in the firmware loader code during debugging the

Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons

2013-04-25 Thread Kay Sievers
On Wed, Apr 24, 2013 at 8:55 PM, John Stultz wrote: >> FWIW, in the light of the original change, I've just removed the >> /dev/rtc creation from the default udev rules now, so that thing will >> be phased out in the future. > > Is that actually wanted? What happens to applications that use

Re: CONFIG_RTC_HCTOSYS lost on x86 with ALWAYS_USE_PERSISTENT_CLOCK changes?

2013-04-25 Thread Kay Sievers
On Thu, Apr 25, 2013 at 8:33 PM, Jason Gunthorpe wrote: > So, my conclusion is nobody with a RTC looking for space savings, will > disable CONFIG_RTC, which means we can safely rely on > CONFIG_RTC_SYSTOHC to do this work. To that end, I would encourage > everyone who sets

Re: CONFIG_RTC_HCTOSYS lost on x86 with ALWAYS_USE_PERSISTENT_CLOCK changes?

2013-04-25 Thread Kay Sievers
On Thu, Apr 25, 2013 at 9:11 AM, Alexander Holler wrote: > Hmm, I thought RTC_SYSTOHC was there to update the used RTC clock with the > time from NTP (and liked that). That seems to have the nice self-explaining name CONFIG_GENERIC_CMOS_UPDATE. :) > Therefor I don't understand why it is >

Re: CONFIG_RTC_HCTOSYS lost on x86 with ALWAYS_USE_PERSISTENT_CLOCK changes?

2013-04-25 Thread Kay Sievers
On Thu, Apr 25, 2013 at 9:11 AM, Alexander Holler hol...@ahsoftware.de wrote: Hmm, I thought RTC_SYSTOHC was there to update the used RTC clock with the time from NTP (and liked that). That seems to have the nice self-explaining name CONFIG_GENERIC_CMOS_UPDATE. :) Therefor I don't understand

Re: CONFIG_RTC_HCTOSYS lost on x86 with ALWAYS_USE_PERSISTENT_CLOCK changes?

2013-04-25 Thread Kay Sievers
On Thu, Apr 25, 2013 at 8:33 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: So, my conclusion is nobody with a RTC looking for space savings, will disable CONFIG_RTC, which means we can safely rely on CONFIG_RTC_SYSTOHC to do this work. To that end, I would encourage everyone who

Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons

2013-04-25 Thread Kay Sievers
On Wed, Apr 24, 2013 at 8:55 PM, John Stultz john.stu...@linaro.org wrote: FWIW, in the light of the original change, I've just removed the /dev/rtc creation from the default udev rules now, so that thing will be phased out in the future. Is that actually wanted? What happens to applications

Re: [PATCH v2] kmsg: Honor dmesg_restrict sysctl on /dev/kmsg

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 11:51 PM, Josh Boyer wrote: >> In the daemon case, it's nice to be able to drop privileges after >> setting up resources. The past was open /proc/kmsg with CAP_SYS_ADMIN, >> then drop CAP_SYS_ADMIN and keep reading. Then later CAP_SYS_LOG was >> introduced. So if a daemon

Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 8:32 PM, John Stultz wrote: > Kay Sievers noted that the ALWAYS_USE_PERSISTENT_CLOCK config, > which enables some minor compile time optimization to avoid > uncessary code in mostly the suspend/resume path could cause > problems for userland. >

Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 8:55 PM, John Stultz wrote: > On 04/24/2013 11:41 AM, Kay Sievers wrote: >> >> On Wed, Apr 24, 2013 at 8:32 PM, John Stultz >> wrote: >>> >>> Kay Sievers noted that the ALWAYS_USE_PERSISTENT_CLOCK config, >>> which enabl

Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 8:32 PM, John Stultz wrote: > Kay Sievers noted that the ALWAYS_USE_PERSISTENT_CLOCK config, > which enables some minor compile time optimization to avoid > uncessary code in mostly the suspend/resume path could cause > problems for userland. >

Re: [PATCH v2] kmsg: Honor dmesg_restrict sysctl on /dev/kmsg

2013-04-24 Thread Kay Sievers
On Tue, Apr 9, 2013 at 6:33 PM, Kees Cook wrote: > On Tue, Apr 9, 2013 at 8:48 AM, Josh Boyer wrote: >> The dmesg_restrict sysctl currently covers the syslog method for access >> dmesg, however /dev/kmsg isn't covered by the same protections. Most >> people haven't noticed because util-linux

Re: CONFIG_RTC_HCTOSYS lost on x86 with ALWAYS_USE_PERSISTENT_CLOCK changes?

2013-04-24 Thread Kay Sievers
On Wed, Apr 24, 2013 at 6:30 PM, John Stultz wrote: >> Until the above commits we always needed: >>CONFIG_RTC_HCTOSYS=y >>CONFIG_RTC_HCTOSYS_DEVICE="rtc0" >> to get the system time correctly initialized at bootup on x86. > So... always needed to get system time correctly initialized?

  1   2   3   4   5   6   7   8   9   >