[Question] Race between pcie hot plug and pcie aer report?

2017-08-22 Thread Kefeng Wang
Hi Bjorn and all, Is there some mechanism to prevent the race between pcie hot plug and pcie aer report, I am unfamiliar with them, so correct me if I am wrong. We met a Null pointer dereference, when inject a uncorrect error[UNCOR_STATUS RX_OVER] to a mlx , see the detail in attachment.

Re: [PATCH] mtd: nand: convert to unified device property interface

2017-08-17 Thread Kefeng Wang
On 2017/8/18 5:55, Boris Brezillon wrote: > Le Wed, 16 Aug 2017 15:29:05 +0800, > Kefeng Wang <wangkefeng.w...@huawei.com> a écrit : > >> Changing from of_* to device_* interface, then we can also extract >> the properties from ACPI tables as well as from DT. >&

[PATCH] mtd: nand: convert to unified device property interface

2017-08-16 Thread Kefeng Wang
Changing from of_* to device_* interface, then we can also extract the properties from ACPI tables as well as from DT. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- - APCI will be supported in hisi504_nand.c, and it will use nand_scan_ident(). drivers/mtd/nand/nand_base.

[PATCH] pid: kill pidhash_size in pidhash_init

2017-07-18 Thread Kefeng Wang
After commit 3d375d78593c ("mm: update callers to use HASH_ZERO flag"), drop unused pidhash_size in pidhash_init(). Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- kernel/pid.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/pid.c b/kernel/pid.c index

Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-14 Thread Kefeng Wang
On 2017/7/14 18:06, Ilya Dryomov wrote: > On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang <wangkefeng.w...@huawei.com> > wrote: >> drivers/block/rbd.c: In function 'rbd_acquire_lock': >> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this &g

[PATCH] nbd: kill unused ret in recv_work

2017-07-13 Thread Kefeng Wang
No need to return value in queue work, kill ret variable. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/block/nbd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index dea7d85..87a0a29 100644 --- a/drivers/block/nbd.c

[PATCH] pci: remove unused res in pci_resource_io

2017-07-13 Thread Kefeng Wang
After commit dca40b186b75 ("PCI: Use BAR index in sysfs attr->private instead of resource pointer"), no need res variable, kill it. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/pci/pci-sysfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

[PATCH] libata: remove unused rc in ata_eh_handle_port_resume

2017-07-13 Thread Kefeng Wang
Remove unused variable ‘rc’. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/ata/libata-eh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index b70bcf6..7d79d20 100644 --- a/drivers/ata/libat

[PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-13 Thread Kefeng Wang
drivers/block/rbd.c: In function 'rbd_acquire_lock': drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] Silence the warning, found it when built old kernel(3.10) with OBS(opensuse build service). Signed-off-by: Kefeng Wang

[PATCH] kernel/watchdog: use better pr_fmt prefix

2017-07-13 Thread Kefeng Wang
After commit 73ce0511c436("kernel/watchdog.c: move hardlockup detector to separate file"), 'NMI watchdog' is inappropriate in kernel/watchdog.c, using 'watchdog' only. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- kernel/watchdog.c | 2 +- 1 file changed, 1 insertio

[PATCH] bpf: fix return in bpf_skb_adjust_net

2017-07-13 Thread Kefeng Wang
The bpf_skb_adjust_net() ignores the return value of bpf_skb_net_shrink/grow, and always return 0, fix it by return 'ret'. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c

[PATCH resend] scsi: fc: drop residual tsk_mgmt_response and it_nexus_response

2017-06-20 Thread Kefeng Wang
After commit 556e26a70b64 ("scsi: remove tsk_mgmt_response and it_nexus_response transport methods"), the target driver support was removed totally. Drop the residua. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- include/scsi/scsi_transport_fc.h | 4 1

Re: [Question] Mlocked count will not be decreased

2017-05-24 Thread Kefeng Wang
we ClearPageMlock but isolation_failed in race > condition, and we do not count these page into delta_munlocked, which cause > mlock > counter incorrect for we had Clear the PageMlock and cannot count down > the number in the feture. > > Fix it by count the number of page wh

[Question] Mlocked count will not be decreased

2017-05-23 Thread Kefeng Wang
Hi All, Mlocked in meminfo will be increasing with an small testcase, and never be released in mainline, here is a testcase[1] to reproduce the issue, but the centos7.2/7.3 will not increase. Is it normal? Thanks, Kefeng [1] testcase linux:~ # cat test_mlockall.sh grep Mlocked

[tip:perf/core] perf probe: Return errno when not hitting any event

2017-03-24 Thread tip-bot for Kefeng Wang
Commit-ID: 70946723eeb859466f026274b29c6196e39149c4 Gitweb: http://git.kernel.org/tip/70946723eeb859466f026274b29c6196e39149c4 Author: Kefeng Wang <wangkefeng.w...@huawei.com> AuthorDate: Fri, 17 Mar 2017 16:16:32 +0800 Committer: Arnaldo Carvalho de Melo <a...@redhat.com>

Re: [PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-20 Thread Kefeng Wang
On 2017/3/20 22:29, Martin K. Petersen wrote: > Kefeng Wang <wangkefeng.w...@huawei.com> writes: > > Kefeng, > >> The issue still exists, the patch return zero in scsi_mode_sense(), but zero >> means >> SAM_STAT_GOOD in scsi_status_is_good(), so n will

Re: [PATCH] arm64: add dump_stack to show_regs

2017-03-20 Thread Kefeng Wang
On 2017/3/20 19:02, Mark Rutland wrote: > On Sun, Mar 19, 2017 at 03:15:25PM +0800, Ding Tianhong wrote: >> Recently I found that when the system trigger a soft lockup in interrupt, >> there is only showing the regs, but no stack trace, it is very difficult >> to locate the problem: >> >>

Re: [PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-20 Thread Kefeng Wang
On 2017/3/18 7:29, Martin K. Petersen wrote: > Kefeng Wang <wangkefeng.w...@huawei.com> writes: > > Kefeng, > >> root@localhost ~]# sg_modes -p 0x2a /dev/sr0 >> QEMU QEMU DVD-ROM 0.15 peripheral_type: cd/dvd [0x5] >> Mode parameter header f

[PATCH v2] perf probe: Return errno when does not hit any event

2017-03-17 Thread Kefeng Wang
g> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Jiri Olsa <jo...@kernel.org> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Wang Nan <wangn...@huawei.com> Fixes: dddc7ee32fa1 ("perf probe: Fix an error when deleting probes successfully") Signed-off-by: K

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Kefeng Wang
On 2017/3/16 17:39, Masami Hiramatsu wrote: > On Tue, 14 Mar 2017 10:30:56 -0300 > Arnaldo Carvalho de Melo <a...@kernel.org> wrote: > >> Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: >>> Hi all, any comments, thanks. >> >> For 'perf

Re: [PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-15 Thread Kefeng Wang
On 2017/3/16 8:07, Martin K. Petersen wrote: > Kefeng Wang <wangkefeng.w...@huawei.com> writes: > > Kefeng, > >> 'n = header_length + block_descriptor_length' could be greater than 512, >> and will lead to oob access, so enlarge transfer buffer to fix it.

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-14 Thread Kefeng Wang
Hi all, any comments, thanks. On 2017/3/7 15:33, Kefeng Wang wrote: > + Arnaldo Carvalho de Melo <a...@kernel.org> > > On 2017/3/6 17:34, Kefeng Wang wrote: >> On old perf, when using perf probe -d to delete an inexistent event, >> it return errno, eg, >> >>

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
+ Arnaldo Carvalho de Melo <a...@kernel.org> On 2017/3/6 17:34, Kefeng Wang wrote: > On old perf, when using perf probe -d to delete an inexistent event, > it return errno, eg, > > -bash-4.3# perf probe -d xxx || echo $? > Info: Event "*:xxx" does not exist. >

[PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
m previous del_perf_probe_events(). After this, it return errno again, eg, -bash-4.3# ./perf probe -d xxx || echo $? Error: Failed to delete events. 254 And it is more appropriate to return -ENOENT instead of -EPERM. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- tools/perf/builtin-pr

Re: [PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-05 Thread Kefeng Wang
Hi all, On 2017/3/3 18:17, Kefeng Wang wrote: > 'n = header_length + block_descriptor_length' could be greater than 512, > and will lead to oob access, so enlarge transfer buffer to fix it. I am not familiar with scsi protocol,so the patch may be wrong. Question, is it reas

[PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-03 Thread Kefeng Wang
'n = header_length + block_descriptor_length' could be greater than 512, and will lead to oob access, so enlarge transfer buffer to fix it. === BUG: KASAN: slab-out-of-bounds in sr_probe+0x570/0xcc0 at addr 8809020e Read of size 1 by task kworker/u48:2/188 Signed-off-by: Kefeng Wang

Re: [PATCH] sched/isolcpus: Show isolated cpu map

2017-02-13 Thread Kefeng Wang
On 2017/2/13 21:32, Peter Zijlstra wrote: > On Mon, Feb 13, 2017 at 09:07:02PM +0800, Kefeng Wang wrote: >> Hi Peter >> >> +Tejun >> >> On 2017/2/13 20:06, Peter Zijlstra wrote: >>> On Mon, Feb 13, 2017 at 05:43:59PM +0800, Kefeng Wang wrote: >>>

Re: [PATCH] sched/isolcpus: Show isolated cpu map

2017-02-13 Thread Kefeng Wang
Hi Peter +Tejun On 2017/2/13 20:06, Peter Zijlstra wrote: > On Mon, Feb 13, 2017 at 05:43:59PM +0800, Kefeng Wang wrote: >> The commit a6e4491c682a ("sched/isolcpus: Output warning when the >> 'isolcpus=' kernel parameter is invalid") adds an error message >>

[PATCH] sched/isolcpus: Show isolated cpu map

2017-02-13 Thread Kefeng Wang
list_parse() won't return -ERANGE if isolcpus=1-10; Let's show the isolated cpu map and drop the improper error message. Cc: Prarit Bhargava <pra...@redhat.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ingo Molnar <mi...@kernel.org> Signed-off-by: Kefeng Wang <wangkefe

[PATCH] ata: pata_of_platform: using of_property_read_u32() helper

2017-01-24 Thread Kefeng Wang
Using better of_property_read_u32() than generic of_get_property(). Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Cc: Hans de Goede <hdego...@redhat.com> Cc: Tejun Heo <t...@kernel.org> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/at

Re: [PATCH 3/3] dts: hisi: add dts files for Hi3516CV300 demo board

2017-01-22 Thread Kefeng Wang
On 2016/10/17 20:07, Pan Wen wrote: > Add dts files for Hi3516CV300 demo board. > > Signed-off-by: Pan Wen > --- > arch/arm/boot/dts/Makefile | 1 + [...] > diff --git a/arch/arm/boot/dts/hi3516cv300.dtsi > b/arch/arm/boot/dts/hi3516cv300.dtsi > new file

[PATCH] ipv6: addrconf: Avoid addrconf_disable_change() using RCU read-side lock

2017-01-19 Thread Kefeng Wang
read-side critical section. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- net/ipv6/addrconf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index c1e124b..f60e88e 100644 --- a/net/ipv6/addrconf.c +++ b/net

Re: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-01-12 Thread Kefeng Wang
viewed-by: Scott Branden <scott.bran...@broadcom.com> > Reviewed-by: Ray Jui <ray@broadcom.com> > Signed-off-by: Jason Uy <jason...@broadcom.com> Reviewed-by: Kefeng Wang <wangkefeng.w...@huawei.com> > --- > drivers/tty/serial/8250/8250_dw.c | 5 ++--- > 1 file ch

Re: Linux 4.10-rc1

2016-12-26 Thread Kefeng Wang
On 2016/12/26 16:38, Hanjun Guo wrote: > Hi Linus, > > On 2016/12/26 8:41, Linus Torvalds wrote: >> It's Christmas Day, and it's two weeks since the merge window opened. >> Thus, the merge window is now closed. >> >> I did a few final pulls today, but I also rejected a couple of pulls >> that

Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

2016-12-21 Thread Kefeng Wang
On 2016/12/21 10:20, Alexander Duyck wrote: > I find it curious that only the last 4 bytes have data in them. I'm > wondering if the NIC/driver in the Windows/Nessus system is > interpreting the 4 byte CRC on the end of the frame as padding instead > of stripping it. > > Is there any chance

Re: [PATCH] firmware: dmi_scan: Always show system identification string

2016-12-11 Thread Kefeng Wang
On 2016/12/9 22:55, Ard Biesheuvel wrote: > On 9 December 2016 at 06:54, Kefeng Wang <wangkefeng.w...@huawei.com> wrote: >> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x >> and SMBIOS 3.x, and always show the system identification string, >> like

[PATCH] firmware: dmi_scan: Always show system identification string

2016-12-08 Thread Kefeng Wang
Let's keep consistent when print dmi_ids_string between SMBIOS 2.x and SMBIOS 3.x, and always show the system identification string, like Vendor, Product/Board name and BIOS infos. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/firmware/dmi_scan.c | 4 ++-- 1 file chan

[PATCH] kcov: add more missing include

2016-12-07 Thread Kefeng Wang
ed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- kernel/kcov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/kcov.c b/kernel/kcov.c index 3cbb0c8..cc2fa35ca 100644 --- a/kernel/kcov.c +++ b/kernel/kcov.c @@ -1,11 +1,16 @@ #define pr_fmt(fmt) "kcov:

[PATCH] kcov: add missing #include

2016-12-05 Thread Kefeng Wang
Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- note: - Build error occurred when I backported kcov to an old kernel version with an old gcc kernel/kcov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/kcov.c b/kernel/kcov.c index 30e6d05..3cbb0c8 100644 --- a/

Re: kernel BUG at arch/x86/kernel/traps.c:643! when run Redhat7(v3.10) in kvm guest

2016-11-06 Thread Kefeng Wang
Hi all, any ideas, thanks. + gonglei, haibin On 2016/10/17 15:51, Kefeng Wang wrote: > > > On 2016/10/15 2:36, Andy Lutomirski wrote: >> On Thu, Oct 13, 2016 at 11:14 PM, Kefeng Wang >> <wangkefeng.w...@huawei.com> wrote: >>> Hi all, >>> >

[PATCH RESEND] tty: amba-pl011: Add earlycon support for SBSA UART

2016-10-30 Thread Kefeng Wang
Declare an OF early console for SBSA UART so that the early console device can be specified via the "stdout-path" property in device-tree. Cc: Russell King <li...@armlinux.org.uk> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Kefeng Wang <w

Re: [PATCH 5/5] tty: amba-pl011: Add earlycon support for SBSA UART

2016-10-30 Thread Kefeng Wang
On 2016/10/27 23:18, Greg Kroah-Hartman wrote: > On Mon, Oct 24, 2016 at 11:59:20AM +0800, Kefeng Wang wrote: >> Hi Greg, any more comments, thanks. > > Never wait, just resend if you have comments and you know you have to > fix them up... > Hi Greg, as I menti

Re: [PATCH 5/5] tty: amba-pl011: Add earlycon support for SBSA UART

2016-10-23 Thread Kefeng Wang
Hi Greg, any more comments, thanks. On 2016/9/27 21:15, Kefeng Wang wrote: > > > On 2016/9/27 18:57, Greg Kroah-Hartman wrote: >> On Sat, Sep 24, 2016 at 05:14:25PM +0800, Kefeng Wang wrote: >>> Declare an OF early console for SBSA UART so that the early console device

Re: kernel BUG at arch/x86/kernel/traps.c:643! when run Redhat7(v3.10) in kvm guest

2016-10-17 Thread Kefeng Wang
On 2016/10/15 2:36, Andy Lutomirski wrote: > On Thu, Oct 13, 2016 at 11:14 PM, Kefeng Wang > <wangkefeng.w...@huawei.com> wrote: >> Hi all, >> >> We met BUG_ON in do_device_not_available(fpu exception handler) when run >> redhat7 in kvm guest, >> and th

kernel BUG at arch/x86/kernel/traps.c:643! when run Redhat7(v3.10) in kvm guest

2016-10-14 Thread Kefeng Wang
Hi all, We met BUG_ON in do_device_not_available(fpu exception handler) when run redhat7 in kvm guest, and there is no special test on this guest, only some network packet receipt and transmission. I checked the new kernel version, found this commit 4ecd16ec7059390b430af34bd8bc3ca2b5dcef9a

Re: [PATCH 5/5] tty: amba-pl011: Add earlycon support for SBSA UART

2016-09-27 Thread Kefeng Wang
On 2016/9/27 18:57, Greg Kroah-Hartman wrote: > On Sat, Sep 24, 2016 at 05:14:25PM +0800, Kefeng Wang wrote: >> Declare an OF early console for SBSA UART so that the early console device >> can be specified via the "stdout-path" property in device-tree. &

[PATCH 5/5] tty: amba-pl011: Add earlycon support for SBSA UART

2016-09-24 Thread Kefeng Wang
Declare an OF early console for SBSA UART so that the early console device can be specified via the "stdout-path" property in device-tree. Cc: Russell King <li...@armlinux.org.uk> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Kefeng Wang <w

[PATCH 4/5] tty: amba-pl011: Don't complain on -EPROBE_DEFER when no irq

2016-09-24 Thread Kefeng Wang
Don't complain on -EPROBE_DEFER when attempting to get the irq. the driver probe will be retried later. Cc: Russell King <li...@armlinux.org.uk> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/seria

[PATCH 3/5] arm64: dts: hisilicon: Add initial dts for Hip07 D05 board

2016-09-24 Thread Kefeng Wang
, there are four numa nodes(one node with sixteen core) on Hip07 SoC. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm64/boot/dts/hisilicon/Makefile |1 + arch/arm64/boot/dts/hisilicon/hip07-d05.dts | 66 ++ arch/arm64/boot/dts/hisilicon/hip07.dtsi

[PATCH 1/5] arm64: dts: hip06: Correct hardware pin number of usb node

2016-09-24 Thread Kefeng Wang
The ohci/ehci hardware pin number should be 640/641, correct them. Fixes: commit aa8d3e74f54d ("arm64: dts: Add initial dts for Hisilicon Hip06 D03 board") Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++-- 1 file chang

[PATCH 2/5] Documentation: arm64: Add Hisilicon Hip07 D05 dts binding

2016-09-24 Thread Kefeng Wang
This patch adds documentation for the devicetree bindings used by the DT files of Hisilicon Hip07 D05 board. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff

[PATCH 0/5] arm64: dts: hisilicon: Hip06 fix and support Hip07 D05 board

2016-09-24 Thread Kefeng Wang
. - Add earlycon support for SBSA UART. Kefeng Wang (5): arm64: dts: hip06: Correct hardware pin number of usb node Documentation: arm64: Add Hisilicon Hip07 D05 dts binding arm64: dts: hisilicon: Add initial dts for Hip07 D05 board tty: amba-pl011: Don't complain on -EPROBE_DEFER when

Re: [PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
On 2016/9/7 7:20, David Miller wrote: > From: Kefeng Wang <wangkefeng.w...@huawei.com> > Date: Tue, 6 Sep 2016 19:53:11 +0800 > >> Declare function as static to kill warning about missing-prototypes. >> >> Cc: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
Declare function as static to kill warning about missing-prototypes. Cc: Yisen Zhuang <yisen.zhu...@huawei.com> Cc: Kejian Yan <yankej...@huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- The warning is shown when make with W=1. drivers/net/ethe

Re: [PATCH v4 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-09-04 Thread Kefeng Wang
On 2016/9/2 19:21, Heikki Krogerus wrote: > On Wed, Aug 31, 2016 at 03:07:56PM +0300, Heikki Krogerus wrote: >> Hi, >> >> On Wed, Aug 31, 2016 at 11:29:11AM +0800, Kefeng Wang wrote: >>> Make dw8250_set_termios() handle all cases of dw8250_data->clk pro

[PATCH v2] serial: 8250_dw: Use an unified new dev variable in probe

2016-08-31 Thread Kefeng Wang
Use an unified new dev variable instead of >dev and p->dev in probe function. Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- Hi Greg, updated, based on tty-testing branch :) v1->v2: 1) Add Heikki's

Re: [PATCH] serial: 8250_dw: Use an unified new dev variable in probe

2016-08-31 Thread Kefeng Wang
Sorry, please ignore, send wrong patch. On 2016/9/1 9:34, Kefeng Wang wrote: > Use an unified new dev variable instead of >dev and p->dev > in probe function. > > Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> > --- > drivers/

[PATCH] serial: 8250_dw: Use an unified new dev variable in probe

2016-08-31 Thread Kefeng Wang
Use an unified new dev variable instead of >dev and p->dev in probe function. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 45 --- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a

[PATCH v4 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 SoC

2016-08-30 Thread Kefeng Wang
device being probed and not a global search for whole DSDT (pointed by graeme.greg...@linaro.org) [1] http://www.spinics.net/lists/linux-acpi/msg68519.html Kefeng Wang (2): serial: 8250_dw: make dw8250_set_termios as default set_termios callback serial: 8250_dw: add ACPI support for uart

[PATCH v4 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 SoC

2016-08-30 Thread Kefeng Wang
Add ACPI identifier for UART on Hisilicon Hip05 SoC, be careful that it is not 16550 compatible, and "reg-io-width" and "reg-shift" need be set properly by _DSD method in DSDT. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.

[PATCH] serial: 8250_dw: Use an unified new dev variable in probe

2016-08-30 Thread Kefeng Wang
Use an unified new dev variable instead of >dev and p->dev in probe function. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 45 --- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a

[PATCH v4 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-08-30 Thread Kefeng Wang
Make dw8250_set_termios() handle all cases of dw8250_data->clk properly, then we can safely use dw8250_set_termios() as the default set_termios callback instead of serial8250_do_set_termios(), so do it. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/

Re: [PATCH v3 3/3] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-08-24 Thread Kefeng Wang
On 2016/8/22 22:05, Heikki Krogerus wrote: > Hi, > > On Mon, Aug 22, 2016 at 02:24:14PM +0300, Andy Shevchenko wrote: >> On Fri, 2016-07-15 at 19:01 +0800, Kefeng Wang wrote: >>> Use built-in device properties to set device parameters for the >>> existing

[PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk

2016-08-24 Thread Kefeng Wang
It should check the data->pclk, not data->clk when get apb_pclk. Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred probing") Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v3 3/3] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-08-08 Thread Kefeng Wang
+ kernel malilist Hi Andriy and all, any comments, thanks. On 2016/7/15 19:01, Kefeng Wang wrote: > Use built-in device properties to set device parameters for the > existing device probed by acpi. > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > that

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

2016-07-27 Thread Kefeng Wang
of_clk_init() caused changes >> in the initialization order breaking booting. >> >> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with >> default match table") >> Cc: Kefeng Wang <wangkefeng.w...@huawei.com> >> Cc: G

[PATCH] mpt3sas: Fix panic when aer correct error occured

2016-07-12 Thread Kefeng Wang
hen read ioc->chip in mpt3sas_base_get_iocstate from _base_fault_reset_work. Cc: Sathya Prakash <sathya.prak...@broadcom.com> Cc: Chaitra P B <chaitra.basa...@broadcom.com> Cc: Suganath Prabu Subramani <suganath-prabu.subram...@broadcom.com> Signed-off-by: Kefeng Wang <

Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-06-30 Thread Kefeng Wang
On 2016/6/30 17:54, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: >> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: >>> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful >>> that it is not 16550 compati

[PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread Kefeng Wang
in ACPI. Change since v1: - Use acpi_match_device() instead of acpi_dev_found(), limit the check to the device being probed and not a global search for whole DSDT (pointed by graeme.greg...@linaro.org) Kefeng Wang (2): serial: 8250_dw: make dw8250_set_termios as default set_termios

[PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread Kefeng Wang
Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful that it is not 16550 compatibal. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.

[PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-06-29 Thread Kefeng Wang
We can safely use dw8250_set_termios() as the default set_termios callback instead of serial8250_do_set_termios(), so do it. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

Re: [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread Kefeng Wang
On 2016/6/29 20:52, Andy Shevchenko wrote: > On Tue, 2016-06-28 at 11:17 +0800, Kefeng Wang wrote: >> Make dw8250_set_termios() as the default set_termios callback for 8250 >> dw uart, correct me >> if I am wrong. >> >> Then add ACPI support for uart o

Re: [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread Kefeng Wang
+cc linux-a...@vger.kernel.org On 2016/6/28 11:17, Kefeng Wang wrote: > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > that it is not 16550 compatibal. > > Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out > and serial_in in ACPI.

[PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

2016-06-27 Thread Kefeng Wang
was already accepted in net-next. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Kefeng Wang (2): serial: 8250_dw: make dw8250_set_termios as default set_termios callback serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

[PATCH 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback

2016-06-27 Thread Kefeng Wang
We can safely use dw8250_set_termios() as the default set_termios callback instead of serial8250_do_set_termios(), so do it. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

[PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc

2016-06-27 Thread Kefeng Wang
Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful that it is not 16550 compatibal. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/tty/serial/8250/8250_dw

Re: [PATCH] serial: 8250_early: Add earlycon support for Synopsys DesignWare ABP UART

2016-06-11 Thread Kefeng Wang
On 2016/5/20 5:35, Jon Mason wrote: > On Thu, May 19, 2016 at 09:45:33AM +0800, Kefeng Wang wrote: >> +Cc Jon and arm-kernel mailist >> >> Any comments, thanks. > > It works for me. Please feel free to add > > Tested-by: Jon Mason <jon.ma...@broadcom.com

[PATCH 2/3] of_numa: Use pr_fmt()

2016-06-02 Thread Kefeng Wang
Use pr_fmt to prefix kernel output. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/of/of_numa.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c index ed7bd22..019738f 100644 --- a/d

[PATCH 0/3] of: numa: cleanup

2016-06-02 Thread Kefeng Wang
1) Use of_get_next_parent in of_node_to_nid. 2) Use pr_fmt to prefix kernel output. and drop duplicated message of NUMA turned off. Based of Zhen Lei 's patchset v3 "fix some type infos and bugs for arm64/of num" in http://www.spinics.net/lists/arm-kernel/msg507650.html. Kefe

[PATCH 1/3] of_numa: Use of_get_next_parent to simplify code

2016-06-02 Thread Kefeng Wang
Use of_get_next_parent() instead of open-code. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/of/of_numa.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c index 3157130..ed7bd22 100644 --- a/d

[PATCH 3/3] arm64: numa: Use pr_fmt()

2016-06-02 Thread Kefeng Wang
Use pr_fmt to prefix kernel output, and remove duplicated msg of NUMA turned off. Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm64/mm/numa.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/arch/arm64/mm/

[PATCH v5 05/18] c6x: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
After patch "of/platform: Add common method to populate default bus", it is possible for arch code to remove unnecessary callers of of_platform_populate with default match table. Cc: Mikael Starvik <star...@axis.com> Cc: Jesper Nilsson <jesper.nils...@axis.com> Sign

[PATCH v5 03/18] arm: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
prisktech.co.nz> Cc: Arnd Bergmann <a...@arndb.de> Cc: Russell King <li...@arm.linux.org.uk> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm/kernel/setup.c | 6 +- arch/arm/mach-artpec/board-artpec6.c| 3 --- arch/arm/mach-bcm/

[PATCH v5 11/18] xtensa: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
ankel.net> Cc: Max Filippov <jcmvb...@gmail.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/xtensa/kernel/setup.c | 11 --- arch/xtensa/kernel/time.c | 2 ++ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/xtensa/kernel/setup.c b/arch

[PATCH v5 10/18] sh: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
After patch "of/platform: Add common method to populate default bus", it is possible for arch code to remove unnecessary callers of of_platform_populate with default match table. Cc: Yoshinori Sato <ys...@users.sourceforge.jp> Cc: Rich Felker <dal...@libc.org> Sign

[PATCH v5 14/18] bus: imx-weim: use of_platform_default_populate() to populate default bus

2016-06-01 Thread Kefeng Wang
org> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/bus/imx-weim.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 1827fc4..4bd361d 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx

[PATCH v5 15/18] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus

2016-06-01 Thread Kefeng Wang
Use helper of_platform_default_populate() in linux/of_platform when possible, instead of calling of_platform_populate() with the default match table. Acked-by: Masahiro Yamada <yamada.masah...@socionext.com> Cc: Masahiro Yamada <yamada.masah...@socionext.com> Signed-off-by:

[PATCH v5 00/18] Cleanup for populate default bus

2016-06-01 Thread Kefeng Wang
://lkml.org/lkml/2016/6/1/43 Kefeng Wang (18): of/platform: Add common method to populate default bus arc: Remove unnecessary of_platform_populate with default match table arm: Remove unnecessary of_platform_populate with default match table arm64: Remove unnecessary of_platform_populate

[PATCH v5 08/18] mips: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
aul.bur...@imgtec.com> Cc: James Hogan <james.ho...@imgtec.com> Cc: Joshua Henderson <joshua.hender...@microchip.com> Cc: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/mips/ath79/setup.c

[PATCH v5 09/18] nios2: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
After patch "of/platform: Add common method to populate default bus", it is possible for arch code to remove unnecessary callers of of_platform_populate with default match table. Cc: Ley Foon Tan <lf...@altera.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --

[PATCH v5 12/18] arm: use of_platform_default_populate() to populate

2016-06-01 Thread Kefeng Wang
..@broadcom.com> Cc: Viresh Kumar <vire...@kernel.org> Cc: Stephen Warren <swar...@wwwdotorg.org> Cc: Rob Herring <r...@kernel.org> Cc: Michal Simek <michal.si...@xilinx.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm/mach-at91/at91rm9200.c

[PATCH v5 18/18] Revert "of/platform: export of_default_bus_match_table"

2016-06-01 Thread Kefeng Wang
Yamada <yamada.masah...@socionext.com> Cc: Rob Herring <robh...@kernel.org> Cc: Frank Rowand <frowand.l...@gmail.com> Cc: Grant Likely <grant.lik...@linaro.org> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- drivers/of/platform.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v5 17/18] of: unittest: use of_platform_default_populate() to populate default bus

2016-06-01 Thread Kefeng Wang
Use helper of_platform_default_populate() in linux/of_platform when possible, instead of calling of_platform_populate() with the default match table. Cc: Rob Herring <robh...@kernel.org> Cc: Frank Rowand <frowand.l...@gmail.com> Cc: Grant Likely <grant.lik...@linaro.org> Sig

[PATCH v5 04/18] arm64: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
ergmann <a...@arndb.de> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/arm64/kernel/setup.c | 13 - 1 file changed, 13 deletions(-) diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 8412520..c907e2f 100644 --- a/arch/arm64/kernel/setup

[PATCH v5 02/18] arc: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
After patch "of/platform: Add common method to populate default bus", it is possible for arch code to remove unnecessary callers of of_platform_populate with default match table. Acked-by: Vineet Gupta <vgu...@synopsys.com> Cc: Vineet Gupta <vgu...@synopsys.com> Sign

[PATCH v5 07/18] metag: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
After patch "of/platform: Add common method to populate default bus", it is possible for arch code to remove unnecessary callers of of_platform_populate with default match table. Cc: James Hogan <james.ho...@imgtec.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.c

[PATCH v5 13/18] mips: use of_platform_default_populate() to populate default bus

2016-06-01 Thread Kefeng Wang
Use helper of_platform_default_populate() in linux/of_platform when possible, instead of calling of_platform_populate() with the default match table. Cc: Joshua Henderson <joshua.hender...@microchip.com> Cc: Ralf Baechle <r...@linux-mips.org> Signed-off-by: Kefeng Wang <wangkefeng.

[PATCH v5 01/18] of/platform: Add common method to populate default bus

2016-06-01 Thread Kefeng Wang
(), and use __func__ to print function's name of of_platform_bus_create(). Cc: Rob Herring <robh...@kernel.org> Cc: Frank Rowand <frowand.l...@gmail.com> Cc: Grant Likely <grant.lik...@linaro.org> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- dr

[PATCH v5 06/18] cris: Remove unnecessary of_platform_populate with default match table

2016-06-01 Thread Kefeng Wang
gt; Cc: Jesper Nilsson <jesper.nils...@axis.com> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> --- arch/cris/kernel/setup.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c index bb12aa9..4b4853d 100644 --- a/arch/cris/ker

[PATCH v5 16/18] memory: omap-gpmc: use of_platform_default_populate() to populate default bus

2016-06-01 Thread Kefeng Wang
Use helper of_platform_default_populate() in linux/of_platform when possible, instead of calling of_platform_populate() with the default match table. Acked-by: Roger Quadros <rog...@ti.com> Cc: Roger Quadros <rog...@ti.com> Cc: Tony Lindgren <t...@atomide.com> Signed-o

  1   2   3   4   >