[REGRESSION] ACPI / EC: Events not being cleared on Samsung series 9 laptop

2014-10-04 Thread Kieran Clancy
need to modify the patches above to do something different in case EC_FLAGS_CLEAR_ON_RESUME is set? Regards, Kieran Clancy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

[REGRESSION] ACPI / EC: Events not being cleared on Samsung series 9 laptop

2014-10-04 Thread Kieran Clancy
different in case EC_FLAGS_CLEAR_ON_RESUME is set? Regards, Kieran Clancy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH] ACPI / EC: Process rather than discard events in acpi_ec_clear

2014-04-29 Thread Kieran Clancy
new patch on affected systems. References: https://lkml.kernel.org/r/532fe3b2.9060...@biereigel-wb.de References: https://bugzilla.kernel.org/show_bug.cgi?id=44161#c173 Reported-by: Stefan Biereigel Signed-off-by: Kieran Clancy Tested-by: Stefan Biereigel Tested-by: Dennis Jansen Tested-by: Nico

[PATCH] ACPI / EC: Process rather than discard events in acpi_ec_clear

2014-04-29 Thread Kieran Clancy
on affected systems. References: https://lkml.kernel.org/r/532fe3b2.9060...@biereigel-wb.de References: https://bugzilla.kernel.org/show_bug.cgi?id=44161#c173 Reported-by: Stefan Biereigel ste...@biereigel.de Signed-off-by: Kieran Clancy clancy.kie...@gmail.com Tested-by: Stefan Biereigel ste

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM.

2014-04-01 Thread Kieran Clancy
On Tue, Apr 1, 2014 at 10:06 PM, Nicolas Porcel wrote: > Do you have any idea of how much time will it take to merge it to the > mainline ? Apologies for the breakage. The key here is that we want a patch which works 100% on all Samsung systems. If we rush a fix for this regression, we may risk

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM.

2014-04-01 Thread Kieran Clancy
On Sat, Mar 29, 2014 at 1:51 AM, D. G. Jansen wrote: > > This patch (processing events) works for me on Samsung 535. Hi Dennis and others, Thank you for testing. I have also been testing this patch for a couple of days, and have not encountered any problems. I have now submitted a request for

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not open after suspend to RAM.

2014-04-01 Thread Kieran Clancy
On Sat, Mar 29, 2014 at 1:51 AM, D. G. Jansen d.g.jan...@gmail.com wrote: This patch (processing events) works for me on Samsung 535. Hi Dennis and others, Thank you for testing. I have also been testing this patch for a couple of days, and have not encountered any problems. I have now

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not open after suspend to RAM.

2014-04-01 Thread Kieran Clancy
On Tue, Apr 1, 2014 at 10:06 PM, Nicolas Porcel nicolasporce...@gmail.com wrote: Do you have any idea of how much time will it take to merge it to the mainline ? Apologies for the breakage. The key here is that we want a patch which works 100% on all Samsung systems. If we rush a fix for this

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM.

2014-03-26 Thread Kieran Clancy
On Thu, Mar 27, 2014 at 6:26 AM, Stefan Biereigel wrote: > I tested both of your patches. The processing of events works well on my > N150, the lid is reported open correctly after resume. > For the second patch (the whitelisting-approach), I had to change the > Product Name to "N150/N210/N220"

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM.

2014-03-26 Thread Kieran Clancy
On Wed, Mar 26, 2014 at 9:12 PM, Stefan Biereigel wrote: > > I don't know if it is a valid idea, but maybe it would be ok to process > events after resume in general, and only throw away events on those > platforms that continue to log events while in standby (Samsung 5/7/9)? We can give it a

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not open after suspend to RAM.

2014-03-26 Thread Kieran Clancy
On Wed, Mar 26, 2014 at 9:12 PM, Stefan Biereigel ste...@biereigel.de wrote: I don't know if it is a valid idea, but maybe it would be ok to process events after resume in general, and only throw away events on those platforms that continue to log events while in standby (Samsung 5/7/9)? We

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not open after suspend to RAM.

2014-03-26 Thread Kieran Clancy
On Thu, Mar 27, 2014 at 6:26 AM, Stefan Biereigel ste...@biereigel.de wrote: I tested both of your patches. The processing of events works well on my N150, the lid is reported open correctly after resume. For the second patch (the whitelisting-approach), I had to change the Product Name to

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not "open" after suspend to RAM.

2014-03-25 Thread Kieran Clancy
On Tue, Mar 25, 2014 at 8:04 PM, Lan Tianyu wrote: > 2014-03-24 19:19 GMT+08:00 Stefan Biereigel : >> Hi, >> thank you for the suggestion. The patch resolves the issue on my N150 >> when applied to a clean 3.14-rc7. Anyways I'm wondering if similar >> problems to mine now exist on the Samsung

Re: [REGRESSION 3.14-rc6] Samsung N150 lid does not open after suspend to RAM.

2014-03-25 Thread Kieran Clancy
On Tue, Mar 25, 2014 at 8:04 PM, Lan Tianyu lantianyu1...@gmail.com wrote: 2014-03-24 19:19 GMT+08:00 Stefan Biereigel secur...@biereigel-wb.de: Hi, thank you for the suggestion. The patch resolves the issue on my N150 when applied to a clean 3.14-rc7. Anyways I'm wondering if similar

Re: [PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-03-05 Thread Kieran Clancy
On Thu, Mar 6, 2014 at 11:22 AM, Rafael J. Wysocki wrote: > On Thursday, March 06, 2014 11:04:14 AM Kieran Clancy wrote: >> >> Rafael, is it a separate process to get this in the stable tree or >> will it naturally happen after being merged into the mainline? > > I need

Re: [PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-03-05 Thread Kieran Clancy
On Thu, Mar 6, 2014 at 5:00 AM, Joseph Salisbury wrote: > I notice there was no cc to stable. Were you also planning on > submitting this for inclusion in the upstream stable kernels? I don't really know the process for stable kernels (Documentation/SubmittingPatches mentions nothing), but of

Re: [PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-03-05 Thread Kieran Clancy
On Thu, Mar 6, 2014 at 5:00 AM, Joseph Salisbury joseph.salisb...@canonical.com wrote: I notice there was no cc to stable. Were you also planning on submitting this for inclusion in the upstream stable kernels? I don't really know the process for stable kernels (Documentation/SubmittingPatches

Re: [PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-03-05 Thread Kieran Clancy
On Thu, Mar 6, 2014 at 11:22 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, March 06, 2014 11:04:14 AM Kieran Clancy wrote: Rafael, is it a separate process to get this in the stable tree or will it naturally happen after being merged into the mainline? I need to add a proper

[PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-28 Thread Kieran Clancy
/show_bug.cgi?id=45461 References: https://bugzilla.kernel.org/show_bug.cgi?id=57271 References: https://bugzilla.kernel.org/attachment.cgi?id=126801 Signed-off-by: Kieran Clancy Suggested-by: Juan Manuel Cabo Reviewed-by: Lan Tianyu Reviewed-by: Dennis Jansen Tested-by: Kieran Clancy Tested

[PATCH v2] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-28 Thread Kieran Clancy
/show_bug.cgi?id=45461 References: https://bugzilla.kernel.org/show_bug.cgi?id=57271 References: https://bugzilla.kernel.org/attachment.cgi?id=126801 Signed-off-by: Kieran Clancy clancy.kie...@gmail.com Suggested-by: Juan Manuel Cabo juanmanuel.c...@gmail.com Reviewed-by: Lan Tianyu tianyu@intel.com

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 12:29 PM, Li Guang wrote: >> +#define ACPI_EC_CLEAR_MAX 20 /* Maximum number of events to >> query >> +* when trying to clear the EC */ >> > > > 20 is enough? > the query index is length of a byte. On my machine, 8 seems

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 11:46 AM, Rafael J. Wysocki wrote: > On Thursday, February 27, 2014 11:29:53 AM Kieran Clancy wrote: >> >> Oh, and I should add that Juan and Dennis both helped to test the >> patch extensively. > > You can use Tested-by or Reported-and-test

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 11:15 AM, Kieran Clancy wrote: > > I am the primary author, but I based the loop which calls > acpi_ec_query_unlocked() on a patch by Lan Tianyu. Juan provided the > initial idea (userspace workaround), and Dennis and Lan Tianyu > reviewed and suggest

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 10:15 AM, Rafael J. Wysocki wrote: > On Thursday, February 27, 2014 02:12:40 AM Kieran Clancy wrote: >> Signed-off-by: Kieran Clancy >> Signed-off-by: Lan Tianyu >> Signed-off-by: Juan Manuel Cabo >> Signed-off-by: Dennis Jansen > > T

[PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
acpi_ec_clear() on wake, from acpi_ec_unblock_transactions() References: https://bugzilla.kernel.org/show_bug.cgi?id=44161 References: https://bugzilla.kernel.org/show_bug.cgi?id=45461 References: https://bugzilla.kernel.org/show_bug.cgi?id=57271 Signed-off-by: Kieran Clancy Signed-off-by: Lan Tianyu Signed

[PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
acpi_ec_clear() on wake, from acpi_ec_unblock_transactions() References: https://bugzilla.kernel.org/show_bug.cgi?id=44161 References: https://bugzilla.kernel.org/show_bug.cgi?id=45461 References: https://bugzilla.kernel.org/show_bug.cgi?id=57271 Signed-off-by: Kieran Clancy clancy.kie...@gmail.com Signed-off

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 10:15 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, February 27, 2014 02:12:40 AM Kieran Clancy wrote: Signed-off-by: Kieran Clancy clancy.kie...@gmail.com Signed-off-by: Lan Tianyu tianyu@intel.com Signed-off-by: Juan Manuel Cabo juanmanuel.c

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 11:15 AM, Kieran Clancy clancy.kie...@gmail.com wrote: I am the primary author, but I based the loop which calls acpi_ec_query_unlocked() on a patch by Lan Tianyu. Juan provided the initial idea (userspace workaround), and Dennis and Lan Tianyu reviewed and suggested

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 11:46 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, February 27, 2014 11:29:53 AM Kieran Clancy wrote: Oh, and I should add that Juan and Dennis both helped to test the patch extensively. You can use Tested-by or Reported-and-tested

Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

2014-02-26 Thread Kieran Clancy
On Thu, Feb 27, 2014 at 12:29 PM, Li Guang lig.f...@cn.fujitsu.com wrote: +#define ACPI_EC_CLEAR_MAX 20 /* Maximum number of events to query +* when trying to clear the EC */ 20 is enough? the query index is length of a byte. On my