Re: [PATCH v6 2/5] phy: qcom-qmp: Utilize fully-specified DT registers

2018-12-07 Thread Kishon Vijay Abraham I
Hi, On 07/12/18 2:16 PM, Vivek Gautam wrote: > On Fri, Dec 7, 2018 at 5:06 AM Evan Green wrote: >> >> Utilize the newly fixed up DT bindings to get the tx2 and rx2 register >> regions for the second lane of dual-lane PHYs. Before this change, >> the driver was simply using lane one's register

Re: [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider

2018-12-06 Thread Kishon Vijay Abraham I
Vivek, On 04/12/18 6:07 PM, Vivek Gautam wrote: > Hi Kishon, > > On Tue, Dec 4, 2018 at 1:44 PM Kishon Vijay Abraham I wrote: >> >> Hi Andy Gross, David Brown, Vivek, >> >> On 30/11/18 3:43 AM, Evan Green wrote: >>> This series fixes the QMP PHY

Re: [PATCH v10 0/6] Support for Qualcomm UFS QMP PHY on SDM845

2018-12-06 Thread Kishon Vijay Abraham I
Hi, On 05/12/18 12:31 PM, Vivek Gautam wrote: > On Tue, Oct 23, 2018 at 10:07 AM Can Guo wrote: >> >> This patch series adds support for UFS QMP PHY on SDM845 and the >> compatible string for it. This patch series depends on the current >> proposed QMP V3 USB3 UNI PHY support for sdm845 driver

Re: [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider

2018-12-04 Thread Kishon Vijay Abraham I
Hi Andy Gross, David Brown, Vivek, On 30/11/18 3:43 AM, Evan Green wrote: > This series fixes the QMP PHY bindings, which had specified #clock-cells > in the parent node, and had set it to 1. Putting it in the parent node is > wrong because the clock providers are the child nodes, so this change

Re: [PATCH v2 2/3] phy: sr-usb: Add stingray usb phy driver

2018-12-03 Thread Kishon Vijay Abraham I
Hi, On 03/12/18 2:06 PM, Srinath Mannam wrote: > This driver supports all versions of stingray SS and HS > USB phys. > In version 1 is combo phy contain both SS and HS phys > in a common IO space. > In version 2 a single HS phy. > These phys support both xHCI host driver and > BDC Broadcom device

Re: [PATCH v5 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver

2018-12-03 Thread Kishon Vijay Abraham I
Hi, On 27/11/18 3:37 PM, Shawn Guo wrote: > It adds Synopsys 28nm Femto High-Speed USB PHY driver support, which > is usually paired with Synopsys DWC3 USB controllers on Qualcomm SoCs. Is this Synopsys PHY specific to Qualcomm or could it be used by other vendors (with just changing tuning

Re: [PATCH] mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)

2018-11-29 Thread Kishon Vijay Abraham I
Hi Faiz, On 30/11/18 12:35 AM, Faiz Abbas wrote: > Errata i929 in certain OMAP5/DRA7XX/AM57XX silicon revisions > (SPRZ426D - November 2014 - Revised February 2018 [1]) mentions > unexpected tuning pattern errors. A small failure band may be present > in the tuning range which may be missed by

Re: [PATCH 2/3] phy: sr-usb: Add stingray usb phy driver

2018-11-29 Thread Kishon Vijay Abraham I
Hi, On 29/11/18 6:31 PM, Srinath Mannam wrote: > Hi Kishon, > > Thank you for review.. Please find my answers below in line. > > > On Thu, Nov 29, 2018 at 3:55 PM Kishon Vijay Abraham I wrote: >> >> Hi, >> >> On 13/11/18 9:43 AM, Srinath Mannam wr

Re: [PATCH 2/3] phy: sr-usb: Add stingray usb phy driver

2018-11-29 Thread Kishon Vijay Abraham I
Hi, On 13/11/18 9:43 AM, Srinath Mannam wrote: > This driver supports all versions of stingray SS and HS > USB phys. > In version 1 is combo phy contain both SS and HS phys > in a common IO space. > In version 2 a single HS phy. > These phys support both xHCI host driver and > BDC Broadcom device

[GIT PULL] PHY: for 4.20 -rc

2018-11-23 Thread Kishon Vijay Abraham I
*) Add "Depend on HAS_IOMEM" uniphier-pcie to avoid randconfig errors Signed-off-by: Kishon Vijay Abraham I Douglas Anderson (1): dt-bindings: phy-qcom-qmp: Fix several mistakes from prior commits Kunihiko

Re: [PATCH v4 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver

2018-11-23 Thread Kishon Vijay Abraham I
Hi, On 19/11/18 4:38 PM, Shawn Guo wrote: > It adds Synopsys 28nm Femto High-Speed USB PHY driver support, which > is usually paired with Synopsys DWC3 USB controllers on Qualcomm SoCs. > > Signed-off-by: Shawn Guo > --- > drivers/phy/qualcomm/Kconfig | 10 + >

Re: [PATCH] MAINTAINERS: Add Kishon as maintainer of PHY bindings

2018-11-19 Thread Kishon Vijay Abraham I
Hi Rob, On 17/11/18 1:50 AM, Rob Herring wrote: On Thu, Oct 18, 2018 at 8:31 AM Rob Herring wrote: DT bindings normally go in via subsystem maintainers, so add PHY bindings under generic PHY framework. Reported-by: Gustavo A. R. Silva Cc: Kishon Vijay Abraham I Signed-off-by: Rob Herring

Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments

2018-11-19 Thread Kishon Vijay Abraham I
On 19/11/18 4:46 PM, Faiz Abbas wrote: The sdhci_execute_tuning() function has assignment of private pointers multiple times. Remove the redundant assignment. Signed-off-by: Faiz Abbas Acked-by: Kishon Vijay Abraham I --- drivers/mmc/host/sdhci-omap.c | 4 1 file changed, 4

Re: [PATCH 3/4] mmc: sdhci-omap: Add platform specific reset callback

2018-11-19 Thread Kishon Vijay Abraham I
Signed-off-by: Faiz Abbas Once patch 2 is merged with this patch, you can add Acked-by: Kishon Vijay Abraham I --- drivers/mmc/host/sdhci-omap.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index

Re: [PATCH 1/4] mmc: sdhci-omap: Fix DCRC error handling during tuning

2018-11-19 Thread Kishon Vijay Abraham I
Hi, On 19/11/18 4:46 PM, Faiz Abbas wrote: Commit 7d33c3581536 ("mmc: sdhci-omap: Workaround for Errata i802") disabled DCRC interrupts during tuning. This write to the interrupt enable register gets overwritten in sdhci_prepare_data() and the interrupt is not in fact disabled. Fix this by

Re: [PATCH v2 0/2] phy: cadence: Add driver and dt-bindings for Sierra PHY

2018-11-12 Thread Kishon Vijay Abraham I
Hi Alan, On 31/10/18 10:03 PM, Alan Douglas wrote: > The Cadence Sierra PHY supports a number of different protocols. This > series adds a driver with support for USB3 and PCIe modes. > > Only one clock frequency is currently supported, so the value of clock > provided in device tree is

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-11-12 Thread Kishon Vijay Abraham I
Hi, On 17/10/18 9:07 PM, Gustavo A. R. Silva wrote: > Hi Kishon, > > On 10/16/18 10:48 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 16 October 2018 02:16 PM, Gustavo A. R. Silva wrote: >>> Hi, >>> >>> On 10/9/18 9:28 AM, Quenti

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-08 Thread Kishon Vijay Abraham I
Hi Arnd, On 06/11/18 6:21 PM, Arnd Bergmann wrote: > On 11/5/18, Kishon Vijay Abraham I wrote: >> On 05/11/18 8:46 AM, Chunyan Zhang wrote: >>> >>> + sdhci_switch_extdma(host, true); >> >> A number of devices using sdhci-omap supports ADMA. So sw

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-04 Thread Kishon Vijay Abraham I
Hi, On 05/11/18 8:46 AM, Chunyan Zhang wrote: > sdhci-omap can support both external dma controllers via dmaengine > framework as well as ADMA in which the controller acts as DMA master. > > Signed-off-by: Chunyan Zhang > --- > drivers/mmc/host/sdhci-omap.c | 7 +++ > 1 file changed, 7

Re: [RFC PATCH 13/40] dt-bindings: PCI: keystone: Add "reg-names" binding information

2018-11-02 Thread Kishon Vijay Abraham I
Hi Rob, On 25/09/18 4:30 AM, Rob Herring wrote: > On Fri, Sep 21, 2018 at 03:51:28PM +0530, Kishon Vijay Abraham I wrote: >> Add "reg-names" binding information in order for device tree node >> to be populated with the correct register strings. >> >>

[PATCH v2 08/21] PCI: keystone: Use uniform function naming convention

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Some function names begin with ks_dw_pcie_* and some function names begin with ks_pcie_*. Modify it so that all function names begin with ks_pcie_*. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 221 +++--- 1 file

[PATCH v2 12/21] PCI: keystone: Invoke pm_runtime APIs to enable clock

2018-10-17 Thread Kishon Vijay Abraham I
Invoke pm_runtime APIs to enable clocks and remove explicit clock enabling using clk_prepare_enable(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 28 ++- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/pci

[PATCH v2 10/21] PCI: keystone: Use SYSCON APIs to get device ID from control module

2018-10-17 Thread Kishon Vijay Abraham I
Control module registers should be read using syscon APIs. pci-keystone.c uses platform_get_resource to get control module registers. Fix it here by using syscon APIs to get device id from control module. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 45

[PATCH v2 15/21] PCI: keystone: Cleanup outbound window configuration

2018-10-17 Thread Kishon Vijay Abraham I
region. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 32 --- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 608e40c4b991

[PATCH v2 03/21] PCI: keystone: Move dw_pcie_setup_rc out of ks_pcie_establish_link()

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Move dw_pcie_setup_rc out of ks_pcie_establish_link() so that ks_pcie_establish_link can be used only to start the link. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH v2 18/21] PCI: keystone: Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt status

2018-10-17 Thread Kishon Vijay Abraham I
Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index e181e6277323..c0bba7b604fa 100644 --- a/drivers/pci/controller/dwc/pci

[PATCH v2 02/21] PCI: keystone: Use quirk to set MRRS for PCI host bridge

2018-10-17 Thread Kishon Vijay Abraham I
Reuse the already existing quirk to set MRRS for PCI host bridge instead of explicitly setting MRRS in ks_pcie_host_init. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 37 +-- 1 file changed, 15 insertions(+), 22 deletions(-) diff

[PATCH v2 00/21] PCI: Cleanup pci-keystone driver

2018-10-17 Thread Kishon Vijay Abraham I
AM654 support *) Add a separate patch for using ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW *) Split outbound window configuration into two patches. One which gets the number of outbound windows from DT and the other cleansup outbound window configuration. Kishon Vijay Abraham I (21

[PATCH v2 17/21] PCI: keystone: Cleanup ks_pcie_link_up()

2018-10-17 Thread Kishon Vijay Abraham I
ks_pcie_link_up() uses registers from the designware core to get the status of the link. Move the register defines to pcie-designware.h and cleanup ks_pcie_link_up(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c| 11 +++ drivers/pci/controller

[PATCH v2 19/21] PCI: keystone: Add debug error message for all errors

2018-10-17 Thread Kishon Vijay Abraham I
d. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 32 --- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index c0bba7b604fa..e9e646acc

[PATCH v2 20/21] PCI: keystone: Reorder header file in alphabetical order

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Reorder header file in alphabetical order. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller

[PATCH v2 14/21] PCI: keystone: Get number of outbound windows from DT

2018-10-17 Thread Kishon Vijay Abraham I
Instead of having a fixed outbound window count, get the number of outbound windows from device tree. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc

[PATCH v2 16/21] PCI: keystone: Cleanup set_dbi_mode and get_dbi_mode

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Use BIT() macro for DBI_CS2 and cleanup set_dbimode and get_dbi_mode Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci

[PATCH v2 21/21] PCI: keystone: Cleanup macros defined in pci-keystone.c

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Cleanup macros defined in pci-keystone.c by removing unused macros, grouping the macros and aligning it properly. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 41 +-- 1 file changed, 16 insertions(+), 25

[PATCH v2 05/21] PCI: keystone: Remove unused argument from ks_dw_pcie_host_init()

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Remove unused "msi_intc_np" argument from ks_dw_pcie_host_init(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone-dw.c | 3 +-- drivers/pci/controller/dwc/pci-keystone.c| 2 +- drivers/pci/controller/dwc/pci-keystone.h

[PATCH v2 04/21] PCI: keystone: Do not initiate link training multiple times

2018-10-17 Thread Kishon Vijay Abraham I
g for more time to establish the link even when no PCI device is connected. Remove it and make it look similar to other dwc based PCIe drivers. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[PATCH v2 06/21] PCI: keystone: Merge pci-keystone-dw.c and pci-keystone.c

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Having two different files for keystone PCI driver doesn't serve any purpose. Merge pci-keystone-dw.c and pci-keystone.c into a single pci-keystone.c file and remove pci-keystone.h Signed-off-by: Kishon Vijay Abraham I --- MAINTAINERS | 2

[PATCH v2 07/21] PCI: keystone: Remove redundant platform_set_drvdata

2018-10-17 Thread Kishon Vijay Abraham I
No functional change. Remove redundant platform_set_drvdata invocation in ks_pcie_probe(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller

[PATCH v2 11/21] PCI: keystone: Cleanup PHY handling

2018-10-17 Thread Kishon Vijay Abraham I
Cleanup PHY handling by using devm_phy_optional_get to get PHYs if the PHYs are optional, creating a device link between the PHY device and the controller device and disable PHY on error cases here. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 122

[PATCH v2 13/21] PCI: keystone: Cleanup configuration space access

2018-10-17 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 70 +++ 1 file changed, 20 insertions(+), 50 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 4f764ec49a4c..1f14de0ef

[PATCH v2 01/21] PCI: keystone: Use quirk to limit MRRS for K2G

2018-10-17 Thread Kishon Vijay Abraham I
PCI controller in K2G also has a limitation that memory read request size (MRRS) must not exceed 256 bytes. Use the quirk to limit MRRS (added for K2HK, K2L and K2E) for K2G as well. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 3 +++ 1 file changed, 3

[PATCH v2 09/21] dt-bindings: PCI: keystone: Add bindings to get device control module

2018-10-17 Thread Kishon Vijay Abraham I
Add bindings to get device control module which has the device id and vendor id to be configured in the keystone PCIe controller. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/pci-keystone.txt | 3 +++ 1 file changed, 3 insertions

Re: [PATCH 11/19] PCI: keystone: Cleanup PHY handling

2018-10-16 Thread Kishon Vijay Abraham I
Lorenzo, On Tuesday 16 October 2018 10:36 PM, Lorenzo Pieralisi wrote: > On Mon, Oct 15, 2018 at 06:37:13PM +0530, Kishon Vijay Abraham I wrote: >> Cleanup PHY handling by using devm_phy_optional_get to get PHYs if >> the PHYs are optional, creating a device link between

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-10-16 Thread Kishon Vijay Abraham I
Hi, On Tuesday 16 October 2018 02:16 PM, Gustavo A. R. Silva wrote: > Hi, > > On 10/9/18 9:28 AM, Quentin Schulz wrote: >> Hi Gustavo, >> >> On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote: >>> Currently, there is an out-of-bounds read on array ctrl->phys, >>> once variable i

[PATCH 16/19] PCI: keystone: Cleanup ks_pcie_link_up()

2018-10-15 Thread Kishon Vijay Abraham I
ks_pcie_link_up() uses registers from the designware core to get the status of the link. Move the register defines to pcie-designware.h and cleanup ks_pcie_link_up(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c| 11 +++ drivers/pci/controller

[PATCH 18/19] PCI: keystone: Reorder header file in alphabetical order

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Reorder header file in alphabetical order. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller

[PATCH 00/19] PCI: Cleanup pci-keystone driver

2018-10-15 Thread Kishon Vijay Abraham I
will be sent separately. [1] -> https://lore.kernel.org/patchwork/cover/989487/ Kishon Vijay Abraham I (19): PCI: keystone: Use quirk to limit MRRS for K2G PCI: keystone: Use quirk to set MRRS for PCI host bridge PCI: keystone: Move dw_pcie_setup_rc out of ks_pcie_establish_link() PCI: keyst

[PATCH 14/19] PCI: keystone: Get number of OB windows from DT and cleanup MEM space configuration

2018-10-15 Thread Kishon Vijay Abraham I
Instead of having a fixed outbound window count, get the number of outbound windows from device tree. Also cleanup memory space configuration here by adding macros for constants. While at that also use BIT() macro for OB_XLAT_EN_VAL. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci

[PATCH 15/19] PCI: keystone: Cleanup set_dbi_mode and get_dbi_mode

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Use BIT() macro for DBI_CS2 and cleanup set_dbimode and get_dbi_mode Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci

[PATCH 06/19] PCI: keystone: Merge pci-keystone-dw.c and pci-keystone.c

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Having two different files for keystone PCI driver doesn't serve any purpose. Merge pci-keystone-dw.c and pci-keystone.c into a single pci-keystone.c file and remove pci-keystone.h Signed-off-by: Kishon Vijay Abraham I --- MAINTAINERS | 2

[PATCH 13/19] PCI: keystone: Cleanup configuration space access

2018-10-15 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 70 +++ 1 file changed, 20 insertions(+), 50 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 891bdfc5921c..adf98dc00

[PATCH 19/19] PCI: keystone: Cleanup macros defined in pci-keystone.c

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Cleanup macros defined in pci-keystone.c by removing unused macros, grouping the macros and aligning it properly. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 41 +-- 1 file changed, 16 insertions(+), 25

[PATCH 04/19] PCI: keystone: Do not initiate link training multiple times

2018-10-15 Thread Kishon Vijay Abraham I
g for more time to establish the link even when no PCI device is connected. Remove it and make it look similar to other dwc based PCIe drivers. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[PATCH 11/19] PCI: keystone: Cleanup PHY handling

2018-10-15 Thread Kishon Vijay Abraham I
Cleanup PHY handling by using devm_phy_optional_get to get PHYs if the PHYs are optional, creating a device link between the PHY device and the controller device and disable PHY on error cases here. Also invoke phy_reset() as part of initializing PHY. Signed-off-by: Kishon Vijay Abraham I

[PATCH 08/19] PCI: keystone: Use uniform function naming convention

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Some function names begin with ks_dw_pcie_* and some function names begin with ks_pcie_*. Modify it so that all function names begin with ks_pcie_*. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 221 +++--- 1 file

[PATCH 10/19] PCI: keystone: Use syscon APIs to get device id from control module

2018-10-15 Thread Kishon Vijay Abraham I
Control module registers should be read using syscon APIs. pci-keystone.c uses platform_get_resource to get control module registers. Fix it here by using syscon APIs to get device id from control module. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 45

[PATCH 12/19] PCI: keystone: Invoke pm_runtime APIs to enable clock

2018-10-15 Thread Kishon Vijay Abraham I
Invoke pm_runtime APIs to enable clocks and remove explicit clock enabling using clk_prepare_enable(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 28 ++- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/pci

[PATCH 17/19] PCI: keystone: Add debug error message for all errors

2018-10-15 Thread Kishon Vijay Abraham I
d. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 33 +++ 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 67646a64c895..35ad3686d

[PATCH 09/19] dt-bindings: PCI: keystone: Add bindings to get device control module

2018-10-15 Thread Kishon Vijay Abraham I
Add bindings to get device control module which has the device id and vendor id to be configured in the keystone PCIe controller. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/pci-keystone.txt | 3 +++ 1 file changed, 3 insertions

[PATCH 02/19] PCI: keystone: Use quirk to set MRRS for PCI host bridge

2018-10-15 Thread Kishon Vijay Abraham I
Reuse the already existing quirk to set MRRS for PCI host bridge instead of explicitly setting MRRS in ks_pcie_host_init. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 37 +-- 1 file changed, 15 insertions(+), 22 deletions(-) diff

[PATCH 03/19] PCI: keystone: Move dw_pcie_setup_rc out of ks_pcie_establish_link()

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Move dw_pcie_setup_rc out of ks_pcie_establish_link() so that ks_pcie_establish_link can be used only to start the link. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 07/19] PCI: keystone: Remove redundant platform_set_drvdata

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Remove redundant platform_set_drvdata invocation in ks_pcie_probe(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller

[PATCH 05/19] PCI: keystone: Remove unused argument from ks_dw_pcie_host_init()

2018-10-15 Thread Kishon Vijay Abraham I
No functional change. Remove unused "msi_intc_np" argument from ks_dw_pcie_host_init(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone-dw.c | 3 +-- drivers/pci/controller/dwc/pci-keystone.c| 2 +- drivers/pci/controller/dwc/pci-keystone.h

[PATCH 01/19] PCI: keystone: Use quirk to limit MRRS for K2G

2018-10-15 Thread Kishon Vijay Abraham I
PCI controller in K2G also has a limitation that memory read request size (MRRS) must not exceed 256 bytes. Use the quirk to limit MRRS (added for K2HK, K2L and K2E) for K2G as well. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 3 +++ 1 file changed, 3

Re: [PATCH v4 2/2] phy: zynqmp: Add phy driver for xilinx zynqmp phy core

2018-10-09 Thread Kishon Vijay Abraham I
Hi Anurag, On Wednesday 12 September 2018 09:52 PM, Anurag Kumar Vulisha wrote: > ZynqMP SoC has a Gigabit Transceiver with four lanes. All the high speed > peripherals such as USB, SATA, PCIE, Display Port and Ethernet SGMII can > rely on any of the four GT lanes for PHY layer. This patch adds

Re: [PATCH 2/6] phy: am654-mmc-phy: Add Support for MMC PHY on AM654 Devices

2018-10-08 Thread Kishon Vijay Abraham I
Hi Uffe, On Monday 08 October 2018 05:02 PM, Ulf Hansson wrote: > On 4 October 2018 at 13:14, Faiz Abbas wrote: >> Add driver support for the MMC physical layer present >> on TI's AM654 devices. >> >> Signed-off-by: Faiz Abbas >> Signed-off-by: Sekhar Nori > > I assume Kishon would like to

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-10-07 Thread Kishon Vijay Abraham I
Hi Lorenzo, On Friday 28 September 2018 09:13 PM, Lorenzo Pieralisi wrote: > On Fri, Sep 28, 2018 at 02:17:16PM +0100, Marc Zyngier wrote: >> On 28/09/18 12:06, Lorenzo Pieralisi wrote: >>> [+Murali, Marc] >>> >>> On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: Hi Lorenzo,

Re: [PATCH] tools/pci: Fix compilation warnings

2018-10-03 Thread Kishon Vijay Abraham I
On Thursday 23 August 2018 05:04 PM, Gustavo Pimentel wrote: > Fix compilation warnings: > - remove unused variables > - change function return from int to void, since it's not used > > Signed-off-by: Gustavo Pimentel Reviewed-by: Kishon Vijay Abraham I > --- > to

[GIT PULL] PHY: for 4.20

2018-10-01 Thread Kishon Vijay Abraham I
*) Re-design R-Car Gen3 USB PHY w.r.t support for OTG *) Cleanup Qualcomm's UFS PHY, QMP PHY (for PCIe and USB3) and QUSB2 PHY *) A preparation patch to remove the node name pointer from struct device_node *) Minor cleanups in some of the other PHY drivers. Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH 0/9] AHCI and SATA PHY support for BCM63138

2018-09-25 Thread Kishon Vijay Abraham I
On Friday 21 September 2018 12:49 AM, Florian Fainelli wrote: > On 09/20/2018 12:16 PM, Florian Fainelli wrote: >> Hi Kishon, Tejun, >> >> This patch series adds support for the SATA AHCI and PHY found on the >> ARM-basd BCM63138 DSL SoCs. >> >> It would probably make sense for patches 1-3 to

Re: [PATCH 1/2] phy: zynqmp: Add phy driver for xilinx zynqmp phy core

2018-09-24 Thread Kishon Vijay Abraham I
Hi, On Wednesday 29 August 2018 07:37 PM, Anurag Kumar Vulisha wrote: > ZynqMP SoC has a Gigabit Transceiver with four lanes. All the high speed > peripherals such as USB, SATA, PCIE, Display Port and Ethernet SGMII can > rely on any of the four GT lanes for PHY layer. This patch adds driver >

[RFC PATCH 14/40] PCI: keystone: Use platform_get_resource_byname to get memory resources

2018-09-21 Thread Kishon Vijay Abraham I
has never worked out of the box in mainline kernel, dt backward compatibility is ignored. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pci

[RFC PATCH 21/40] PCI: keystone: Add debug error message for all errors

2018-09-21 Thread Kishon Vijay Abraham I
d. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 45 +-- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 240c39c58b0f..a3dec74da

[RFC PATCH 08/40] PCI: keystone: Cleanup MSI/legacy interrupt configuration and handling

2018-09-21 Thread Kishon Vijay Abraham I
*) Move request_irq of error irq from ks_add_pcie_port to ks_pcie_probe as error_irq is common to both host mode and device mode Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 392 +- 1 file changed, 150 insertions(+), 242 deletions

[RFC PATCH 18/40] PCI: keystone: Get number of OB windows from DT and cleanup MEM space configuration

2018-09-21 Thread Kishon Vijay Abraham I
Instead of having a fixed outbound window count, get the number of outbound windows from device tree. Also cleanup memory space configuration here by adding macros for constants. While at that also use BIT() macro for OB_XLAT_EN_VAL. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci

[RFC PATCH 17/40] PCI: keystone: Cleanup configuration space access

2018-09-21 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 70 +++ 1 file changed, 20 insertions(+), 50 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index f230344e1f4e..3ead11622

[RFC PATCH 39/40] arm64: dts: k3-am6: Add SERDES DT node

2018-09-21 Thread Kishon Vijay Abraham I
Add DT node for SERDES0 and SERDES1. Signed-off-by: Kishon Vijay Abraham I --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index

[RFC PATCH 35/40] ARM: dts: keystone-k2e: Use the updated binding to describe PCIe in k2e

2018-09-21 Thread Kishon Vijay Abraham I
Use the updated binding to describe PCIe in k2e. (The older binding has never worked in upstream kernel since serdes driver was never upstreamed). Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Sekhar Nori --- arch/arm/boot/dts/keystone-k2e.dtsi | 15 --- arch/arm/boot/dts

[RFC PATCH 38/40] arm64: dts: k3-am6: Add mux-controller dt node required for muxing SERDES

2018-09-21 Thread Kishon Vijay Abraham I
Add mux-controller dt node as a child node of scm_conf. This is required for muxing SERDES between USB, PCIe and ICSS2 SGMII. While at that also add "simple-mfd" compatible string to scm_conf dt node so that mux-controller device gets created. Signed-off-by: Kishon Vijay Abraham I

[RFC PATCH 40/40] arm64: dts: k3-am6: Add Root Complex PCIe dt node

2018-09-21 Thread Kishon Vijay Abraham I
Add Root Complex PCIe dt node. Signed-off-by: Kishon Vijay Abraham I --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 83 arch/arm64/boot/dts/ti/k3-am65.dtsi | 1 + 2 files changed, 84 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch

[RFC PATCH 30/40] dt-bindings: PCI: Add PCI RC dt binding documentation for AM654

2018-09-21 Thread Kishon Vijay Abraham I
Add devicetree binding documentation for PCIe in RC mode present in AM654 SoC. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/pci/pci-keystone.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/pci

[RFC PATCH 19/40] PCI: keystone: Cleanup set_dbi_mode and get_dbi_mode

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Use BIT() macro for DBI_CS2 and cleanup set_dbimode and get_dbi_mode Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci

[RFC PATCH 31/40] PCI: keystone: Add support for PCIe in AM654x Platforms

2018-09-21 Thread Kishon Vijay Abraham I
Add PCIe RC support for AM654x Platforms in pci-keystone.c Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/Kconfig| 2 +- drivers/pci/controller/dwc/pci-keystone.c | 118 +++--- 2 files changed, 107 insertions(+), 13 deletions(-) diff --git

[RFC PATCH 09/40] PCI: keystone: Remove redundant platform_set_drvdata

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Remove redundant platform_set_drvdata invocation in ks_pcie_probe(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller

[RFC PATCH 29/40] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64

2018-09-21 Thread Kishon Vijay Abraham I
hook_fault_code is an ARM32 specific API for hooking into data abort. Since pci-keystone.c will be used for AM65X platforms which is an ARM64 platform, allow hook_fault_code to be compiled only for ARM32. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 4

[RFC PATCH 32/40] phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback

2018-09-21 Thread Kishon Vijay Abraham I
PHY drivers may try to access PHY registers in the ->reset() callback. Invoke phy_pm_runtime_get_sync() before invoking the ->reset() callback so that the PHY drivers don't have to enable clocks by themselves before accessing PHY registers. Signed-off-by: Kishon Vijay Abraham I --- drive

[RFC PATCH 34/40] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2018-09-21 Thread Kishon Vijay Abraham I
. The driver has support to select PLL mux and left/right output mux as specified in device tree. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/Kconfig| 11 + drivers/phy/ti/Makefile | 1 + drivers/phy/ti/phy-am654-serdes.c | 513 ++ 3

[RFC PATCH 33/40] dt-bindings: phy: ti: Add dt binding documentation for SERDES in AM654x SoC

2018-09-21 Thread Kishon Vijay Abraham I
umentation in order to represent all these different configurations in device tree. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/phy/ti-phy.txt| 77 +++ include/dt-bindings/phy/phy-am654-serdes.h| 13 2 files changed, 90 insertions(+) create m

[RFC PATCH 10/40] PCI: keystone: Use uniform function naming convention

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Some function names begin with ks_dw_pcie_* and some function names begin with ks_pcie_*. Modify it so that all function names begin with ks_pcie_*. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 267 ++ 1 file

[RFC PATCH 37/40] arm64: dts: k3-am6: Add Main System Control Module node

2018-09-21 Thread Kishon Vijay Abraham I
From: Benoit Parrot Main System control module support is added to the device tree to allow driver to access to their control module registers. Signed-off-by: Benoit Parrot Signed-off-by: Kishon Vijay Abraham I --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 + 1 file changed, 5

[RFC PATCH 11/40] dt-bindings: PCI: keystone: Add bindings to get device control module

2018-09-21 Thread Kishon Vijay Abraham I
Add bindings to get device control module which has the device id and vendor id to be configured in the keystone PCIe controller. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/pci/pci-keystone.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

[RFC PATCH 36/40] arm64: dts: k3-am6: Add "socionext,synquacer-pre-its" property to gic_its

2018-09-21 Thread Kishon Vijay Abraham I
GIC_ITS used in AM65x platform has the same configuration as that of GIC_ITS used in Socionext SoCs. Add "socionext,synquacer-pre-its" property to get PCI MSI working. Signed-off-by: Kishon Vijay Abraham I --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 + 1 file changed, 1 insertio

[RFC PATCH 25/40] dt-bindings: PCI: Add dt-binding to configure PCIe mode

2018-09-21 Thread Kishon Vijay Abraham I
Add "ti,syscon-pcie-mode" dt-binding to hold phandle to the syscon register that should be used to configure PCIe in RC mode or EP mode. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/pci/pci-keystone.txt | 2 ++ 1 file changed, 2 insertions(+)

[RFC PATCH 26/40] PCI: keystone: Explicitly set the PCIe mode

2018-09-21 Thread Kishon Vijay Abraham I
Explicitly set the PCIe mode to BOOTCFG_DEVCFG instead of always relying on the default values. This is required when EP mode has to be explicitly written to BOOTCFG_DEVCFG register. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 37

[RFC PATCH 07/40] PCI: keystone: Merge pci-keystone-dw.c and pci-keystone.c

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Having two different files for keystone PCI driver doesn't serve any purpose. Merge pci-keystone-dw.c and pci-keystone.c into a single pci-keystone.c file and remove pci-keystone.h Signed-off-by: Kishon Vijay Abraham I --- The "CHECK:" warnings here by che

[RFC PATCH 24/40] PCI: keystone: Move initializations to appropriate places

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Move host specific platform_get_resource to ks_add_pcie_port and the common platform_get_resource (applicable to both host and endpoint) to probe. This is in preparation for adding endpoint support to pci-keystone driver. Signed-off-by: Kishon Vijay Abraham I --- drivers

[RFC PATCH 28/40] PCI: dwc: Fix ATU identification for designware version >= 4.80

2018-09-21 Thread Kishon Vijay Abraham I
which hasn't populated atu register space, use the existing hard coded address. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/dwc/pcie-designware-host.c | 16 -- drivers/pci/controller/dwc/pcie-designware.c | 50 +-- drivers/pci/controller/dwc/pcie-designware.h | 9

[RFC PATCH 23/40] PCI: keystone: Cleanup macros defined in pci-keystone.c

2018-09-21 Thread Kishon Vijay Abraham I
No functional change. Cleanup macros defined in pci-keystone.c by removing unused macros, grouping the macros and aligning it properly. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 41 +-- 1 file changed, 16 insertions(+), 25

[RFC PATCH 27/40] dt-bindings: PCI: Document "atu" reg-names

2018-09-21 Thread Kishon Vijay Abraham I
Document "atu" reg-names required to get the register space for ATU in Synopsys designware core version >= 4.80. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/pci/designware-pcie.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-

[RFC PATCH 20/40] PCI: keystone: Cleanup ks_pcie_link_up()

2018-09-21 Thread Kishon Vijay Abraham I
ks_pcie_link_up() uses registers from the designware core to get the status of the link. Move the register defines to pcie-designware.h and cleanup ks_pcie_link_up(). Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c| 10 +++--- drivers/pci/controller

  1   2   3   4   5   6   7   8   9   10   >