RE: [RESEND PATCH v3] scsi: ufshcd: fix possible unclocked register access

2016-10-07 Thread Kiwoong Kim
Reviewed-by: Kiwoong Kim <kwmad@samsung.com> > Vendor specific setup_clocks callback may require the clocks managed > by ufshcd driver to be ON. So if the vendor specific setup_clocks callback > is called while the required clocks are turned off, it could result into >

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Kiwoong Kim
Hi, Subhash. > Thanks Kim for the response. > > On 2016-10-06 03:28, Kiwoong Kim wrote: > > Hi, Subhash. > > > > Some UFS host controllers may need to call the vendor specific > > callback before and after controlling by clock control framework, > >

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

2016-10-06 Thread Kiwoong Kim
Hi, Subhash. Some UFS host controllers may need to call the vendor specific callback before and after controlling by clock control framework, regardless of whether available clocks are turned on or off. Is there any special reason to limit to invoke the callback only when the clocks are turned

RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-27 Thread Kiwoong Kim
Hi, Martin. I think that the patch is correct. UFS spec says "The Data Segment area is empty" for Read Descriptor. I have been using similar code with it and it works. That have been already applied in Android kernel. Reviewed-by: Kiwoong Kim <kwmad@samsung.com> Regards.

RE: UFS API in the kernel

2016-09-26 Thread Kiwoong Kim
Hi. If you want to declare some things for user interface, is it be better to put those thing include/uapi/linux/ than include/linux? Agreed with Mr. Pinto's opinion with respect to implementing additional ioctls. Regards. > -Original Message- > From: linux-scsi-ow...@vger.kernel.org