[PATCH 4/4] leds: trigger: Add pattern initialization from Device Tree

2018-12-07 Thread Krzysztof Kozlowski
user-space is brought up and sets its own pattern, indicating the boot status is for example finished. Signed-off-by: Krzysztof Kozlowski --- drivers/leds/trigger/ledtrig-pattern.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/leds/trigger/ledtrig-pattern.c b

[PATCH 3/4] dt-bindings: leds: Add pattern initialization from Device Tree

2018-12-07 Thread Krzysztof Kozlowski
Document new linux,trigger-pattern property for initialization of LED pattern trigger. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/leds/common.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/common.txt b

[PATCH 1/4] leds: pwm: Simplify with resource-managed devm_led_classdev_register()

2018-12-07 Thread Krzysztof Kozlowski
Simplify the exit path with resource-managed version of registering LED class device. The code should be functionally the same, except that on device removal the led_pwm_priv->num_leds is not decremented to zero (which should not have any effect as device is going away). Signed-off-by: Krzysz

[PATCH 2/4] leds: pwm: Use OF variant of LED registering function

2018-12-07 Thread Krzysztof Kozlowski
The PWM leds can be instantiated from Device Tree so pass the respective device node to LED core. This provides the LED system with proper device node and exposes it through uevent. Signed-off-by: Krzysztof Kozlowski --- drivers/leds/leds-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] leds: gpio: Drop unneeded manual of_node assignment

2018-12-07 Thread Krzysztof Kozlowski
he of_node with same value. No functional change expected. Signed-off-by: Krzysztof Kozlowski --- drivers/leds/leds-gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 45e012093865..998f2ff6914d 100644 --- a/drivers/leds/leds-gpio.

Re: [PATCH 7/8] clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC

2018-12-07 Thread Krzysztof Kozlowski
On Thu, 6 Dec 2018 at 22:59, Stephen Boyd wrote: > > This flag doesn't look to be used by any code, just set in the clk init > structure and then never tested again. Remove it from this drivers as it > doesn't provide any benefit. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlo

Re: [PATCH] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB

2018-12-06 Thread Krzysztof Kozlowski
On Thu, 6 Dec 2018 at 12:55, Linus Walleij wrote: > > On Thu, Dec 6, 2018 at 10:45 AM Krzysztof Kozlowski wrote: > > > If CONFIG_GPOILIB is not set, the stub of gpio_to_desc() should return > > the same type of error as regular version: NULL. All the callers > &g

[PATCH stable v4.4+ 2/3] leds: turn off the LED and wait for completion on unregistering LED class device

2018-12-06 Thread Krzysztof Kozlowski
dev, LED_OFF) flush_work(_cdev->set_brightness_work) It guarantees that LED driver turns off the brightness prior to resource management. Cc: linux-l...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim Signed-off-by: Jacek Anaszewski Signed-off-by: Krzysztof Koz

[PATCH] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB

2018-12-06 Thread Krzysztof Kozlowski
: 79a9becda894 ("gpiolib: export descriptor-based GPIO interface") Cc: Signed-off-by: Krzysztof Kozlowski --- include/linux/gpio/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index ed

Re: dmapool regression in next

2018-12-06 Thread Krzysztof Kozlowski
On Thu, 6 Dec 2018 at 02:31, Tony Lindgren wrote: > > Hi, > > Looks like with commit 26abe88e830d ("mm/dmapool.c: improve scalability > of dma_pool_free()") I'm now getting spammed with lots of "(bad vaddr)" > on at least omap4 pandaboard, see below. > > Any ideas what might be going wrong? > >

Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons

2018-12-05 Thread Krzysztof Kozlowski
On Wed, 5 Dec 2018 at 20:51, Rob Herring wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Tomasz Figa > Cc: Krzysztof Kozlowski > Cc: Sylwester Nawrocki > Cc: Linus

Re: [PATCH] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3

2018-12-05 Thread Krzysztof Kozlowski
On Wed, 5 Dec 2018 at 17:11, Anand Moon wrote: > > Hi Krzysztof, > > Thanks for your review. > . > On Wed, 5 Dec 2018 at 19:36, Krzysztof Kozlowski wrote: > > > > On Tue, 4 Dec 2018 at 20:40, Anand Moon wrote: > > > > > > Add suspend-to-mem

Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

2018-12-05 Thread Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:15, Krzysztof Kozlowski wrote: > > On Tue, 20 Nov 2018 at 13:09, Boris Brezillon > wrote: > > > > On Tue, 20 Nov 2018 12:48:46 +0100 > > Krzysztof Kozlowski wrote: > > > > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal

Re: [PATCH] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3

2018-12-05 Thread Krzysztof Kozlowski
On Tue, 4 Dec 2018 at 20:40, Anand Moon wrote: > > Add suspend-to-mem node to regulator core to be enabled or disabled > during system suspend and also support changing the regulator operating > mode during runtime and when the system enter sleep mode. > > Signed-off-by: Anand Moon > --- >

Re: [PATCH v3 5/5] arm: dts: exynos4: opp-suspend in DMC and leftbus

2018-12-05 Thread Krzysztof Kozlowski
On Wed, 5 Dec 2018 at 12:06, Lukasz Luba wrote: > > Mark the state for devfreq device while entring suspend/resume process. > > Suggested-by: Tobias Jakobi > Suggested-by: Chanwoo Choi > Reviewed-by: Chanwoo Choi > Signed-off-by: Lukasz Luba I already applied v2:

Re: [PATCH v2 5/5] arm: dts: exynos4: opp-suspend in DMC and leftbus

2018-12-03 Thread Krzysztof Kozlowski
On Mon, Dec 03, 2018 at 03:31:15PM +0100, Lukasz Luba wrote: > Mark the state for devfreq device while entring suspend/resume process. > > The patch is based on earlier work by Tobias Jakobi. > > Suggested-by: Tobias Jakobi > Suggested-by: Chanwoo Choi > Reviewed-by: Chanwoo Choi >

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-11-28 Thread Krzysztof Kozlowski
On Wed, 28 Nov 2018 at 18:53, Matheus Tavares wrote: > > From: Lucas Santos > > This patch removes all license boilerplate texts from the .c and .h > files at drivers/iio/adc/ and, instead, adds the proper SPDX license > identifiers. > > Signed-off-by: Lucas Santos > Signed-off-by: Matheus

Re: [PATCH] regulator: s2mps11: Fix GPIO descriptor initialization

2018-11-20 Thread Krzysztof Kozlowski
ad of GPIO > number") > Signed-off-by: Marek Szyprowski > --- > This fixes broken eMMC boot on Artik, Rinato and Odroid XU3/XU4/HC1 > boards. I missed that on my review. Now it looks fine, thanks for fixing it! Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > --- &g

Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

2018-11-20 Thread Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:09, Boris Brezillon wrote: > > On Tue, 20 Nov 2018 12:48:46 +0100 > Krzysztof Kozlowski wrote: > > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal > > wrote: > > > > > > Hi Krzysztof, > > > > > > Krzyszt

Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

2018-11-20 Thread Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 11:33, Miquel Raynal wrote: > > Hi Krzysztof, > > Krzysztof Kozłowski wrote on Tue, 20 Nov 2018 > 10:46:33 +0100: > > > Hi all, > > > > Since few days linux-next has problem on Freescale VF500 - MTD seems > > to be broken. > > > > Bisect pointed me to commit

[PATCH] MIPS: defconfigs: Remove obsolete ATH_CARDS

2018-11-19 Thread Krzysztof Kozlowski
CONFIG_ATH_CARDS was replaced with CONFIG_WLAN_VENDOR_ATH in commit b5c9b4f91a6f ("ath: unify Kconfig with other vendors"). Anyway it is being selected automatically as dependency on chosen Atheros driver. Signed-off-by: Krzysztof Kozlowski --- arch/mips/configs/bcm47xx_defconfig |

Re: [PATCH 02/10] ARM64: dts: exynos: Add all CPUs in cooling maps

2018-11-18 Thread Krzysztof Kozlowski
On Fri, Nov 16, 2018 at 03:34:25PM +0530, Viresh Kumar wrote: > Each CPU can (and does) participate in cooling down the system but the > DT only captures a handful of them, normally CPU0, in the cooling maps. > Things work by chance currently as under normal circumstances its the > first CPU of

Re: [PATCH 1/6] ARM: dts: exynos: Add all CPUs in cooling maps

2018-11-18 Thread Krzysztof Kozlowski
On Fri, Nov 16, 2018 at 03:31:10PM +0530, Viresh Kumar wrote: > Each CPU can (and does) participate in cooling down the system but the > DT only captures a handful of them, normally CPU0, in the cooling maps. > Things work by chance currently as under normal circumstances its the > first CPU of

Re: [PATCH 1/9] ARM: EXYNOS: remove secondary startup initialization from smp_prepare_cpus

2018-11-18 Thread Krzysztof Kozlowski
mp_prepare_cpus. > > Signed-off-by: Pankaj Dubey > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-exynos/platsmp.c | 26 -- Thanks, applied. Best regards, Krzysztof

Re: [PATCH v4] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-11-18 Thread Krzysztof Kozlowski
On Wed, Nov 14, 2018 at 04:30:58PM +0100, Bartlomiej Zolnierkiewicz wrote: > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not

Re: [PATCH 9/9] ARM: EXYNOS: remove include

2018-11-16 Thread Krzysztof Kozlowski
On Thu, 15 Nov 2018 at 16:12, Bartlomiej Zolnierkiewicz wrote: > > Remove no longer needed include. If I understand correctly, header is not needed because of previous commit so it should be squashed there. Best regards, Krzysztof

Re: [PATCH 2/9] soc: samsung: add exynos chipid driver support

2018-11-16 Thread Krzysztof Kozlowski
On Thu, 15 Nov 2018 at 16:12, Bartlomiej Zolnierkiewicz wrote: > > From: Pankaj Dubey > > Exynos SoCs have Chipid, for identification of product IDs and SoC > revisions. This patch intends to provide initialization code for all > these functionalities, at the same time it provides some sysfs

Re: [PATCH 5/9] ARM: EXYNOS: use chipid driver

2018-11-16 Thread Krzysztof Kozlowski
On Thu, 15 Nov 2018 at 16:12, Bartlomiej Zolnierkiewicz wrote: > > Add soc_dev_is_exynos*() helpers and use them instead of > soc_is_exynos*() ones. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-exynos/common.h | 6 ++ > arch/arm/mach-exynos/exynos.c | 39

Re: [PATCHv5 4/6] ARM: dts: exynos: Add pin configuration for SD write protect on Odroid XU3/XU4

2018-11-13 Thread Krzysztof Kozlowski
On Thu, Sep 27, 2018 at 02:07:36PM +, Anand Moon wrote: > Add SD card write-protect pin configuration to be sure that it will be > properly pulled down to indicate write access. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Anand Moon > --- > Changes since v4:

Re: [PATCHv5 5/6] ARM: dts: exynos: update maximum frequency for emmc to 200MHz

2018-11-13 Thread Krzysztof Kozlowski
On Thu, Sep 27, 2018 at 02:07:37PM +, Anand Moon wrote: > Set the max-frequency to 200MHz for optimal performace of eMMC. > Thanks, applied. Best regards, Krzysztof

[PATCH] ARM: dts: exynos: Clarify comment explaining purpose of Odroid XU3 DTSI

2018-11-13 Thread Krzysztof Kozlowski
There are two common DTSI files for Exynos5422 Odroid XU3 family of boards. One is shared between all of them (XU3, XU3-Lite, XU4 and HC1) and the second skips HC1. Document this in the files. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2

Re: [PATCHv5 3/6] ARM: dts: exynos: update maximum frequency for sdcard to 200MHz

2018-11-13 Thread Krzysztof Kozlowski
On Thu, Sep 27, 2018 at 02:07:35PM +, Anand Moon wrote: > set the max-frequency to 200MHz for optimal performace. > Thanks, applied. Best regards, Krzysztof

Re: [PATCHv5 2/6] ARM: dts: exynos: fix regulator min values of LDO13 for Odroid XU3/XU4

2018-11-13 Thread Krzysztof Kozlowski
On Thu, Sep 27, 2018 at 02:07:34PM +, Anand Moon wrote: > Looking at the schematic sd_2 min/max range from 1.8V/2.8V so fix the > regulator min value to 1.8V. Without these changes sdcard will failed > to detect on booting when UHS-I tuning is enabled. > Thanks, applied. Best regards,

Re: [PATCHv5 1/6] ARM: dts: exynos: Added UHS-I bus speed support

2018-11-13 Thread Krzysztof Kozlowski
On Thu, Sep 27, 2018 at 02:07:33PM +, Anand Moon wrote: > Added support for UHS-I bus speed tuning for SDR50, DDR50 SDR104. > Thanks, applied. Best regards, Krzysztof

Re: [PATCH v3] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-11-12 Thread Krzysztof Kozlowski
On Tue, Oct 16, 2018 at 03:04:52PM +0200, Krzysztof Kozlowski wrote: > On Mon, 15 Oct 2018 at 17:50, Bartlomiej Zolnierkiewicz > wrote: > > > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > > config option) is not working properly (debug me

Re: [PATCH] ARM: EXYNOS: remove no longer needed s3c_pm_check_*() calls

2018-11-12 Thread Krzysztof Kozlowski
On Mon, Oct 15, 2018 at 03:48:27PM +0200, Bartlomiej Zolnierkiewicz wrote: > Since commit 6862fdf2201a ("ARM: samsung: Limit SAMSUNG_PM_CHECK > config option to non-Exynos platforms") s3c_pm_check_*() calls > are redundant and can be removed. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- >

[BISECT] NFSv4 root boot failures on next (Merge remote-tracking branch 'vfs/for-next)

2018-10-30 Thread Krzysztof Kozlowski
Hi all, Since yesterdays next, all my boards booting from NFS root (NFSv4) experience infinite warnings: [ 210.199561] [ cut here ] [ 210.204169] WARNING: CPU: 1 PID: 191 at ../lib/iov_iter.c:1082 iov_iter_kvec+0x54/0x5c [ 210.212048] Modules linked in: [ 210.215094] CPU:

Re: [PATCH 1/8] clk: max77686: constify clk_ops structure

2018-10-29 Thread Krzysztof Kozlowski
ned-off-by: Julia Lawall > > --- > drivers/clk/clk-max77686.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 4/6] clocksource: exynos_mct: Add arch_timer cooperation mode for ARM64

2018-10-19 Thread Krzysztof Kozlowski
igned-off-by: Marek Szyprowski > Reviewed-by: Chanwoo Choi > Tested-by: Chanwoo Choi > --- > drivers/clocksource/exynos_mct.c | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 3/6] clocksource: exynos_mct: Refactor resources allocation

2018-10-19 Thread Krzysztof Kozlowski
changed, 30 insertions(+), 20 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH stable v4.4+] usb: gadget: serial: fix oops when data rx'd after close

2018-10-18 Thread Krzysztof Kozlowski
, which will then crash in e.g. gs_write_room() due to lack of gadget serial device to TTY association (i.e. a NULL pointer dereference). Signed-off-by: Stephen Warren Signed-off-by: Felipe Balbi Signed-off-by: Krzysztof Kozlowski --- This is necessary for v4.4+ to fix: [ 134.015750] Unable

Re: [PATCH v3 3/6] clocksource: exynos_mct: Refactor resources allocation

2018-10-17 Thread Krzysztof Kozlowski
On Wed, 17 Oct 2018 at 15:42, Marek Szyprowski wrote: > > Move interrupts allocation from exynos4_timer_resources() into separate > function together with the interrupt number parsing code from > mct_init_dt(), so the code for managing interrupts is kept together. > While touching

Re: [PATCH v2 3/6] clocksource: exynos_mct: Add arch_timer cooperation mode for ARM64

2018-10-16 Thread Krzysztof Kozlowski
d by > arch_timer driver. > > Signed-off-by: Marek Szyprowski > --- > drivers/clocksource/exynos_mct.c | 52 +--- > 1 file changed, 35 insertions(+), 17 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 6/6] arm64: platform: Add enable Exynos Multi-Core Timer driver

2018-10-16 Thread Krzysztof Kozlowski
fig.platforms | 1 + > 1 file changed, 1 insertion(+) Looks okay, I'll take it after this merge window. In case this was applied directly to arm-soc: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 5/6] arm64: dts: exynos: Move arch-timer node to right place

2018-10-16 Thread Krzysztof Kozlowski
On Mon, 15 Oct 2018 at 14:31, Marek Szyprowski wrote: > > Move ARM architected timer device-tree node to the beginning of 'soc' > node, to group it together with other ARM CPU core devices (like PMU). > > Signed-off-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 23

Re: [PATCH v3] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-10-16 Thread Krzysztof Kozlowski
On Mon, 15 Oct 2018 at 17:50, Bartlomiej Zolnierkiewicz wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented. > >

Re: [PATCH v2 2/6] clocksource: exynos_mct: Fix error path in timer resources initialization

2018-10-15 Thread Krzysztof Kozlowski
On Mon, 15 Oct 2018 at 14:31, Marek Szyprowski wrote: > > While freeing interrupt handlers in error path, don't assume that all > requested interrupts are per-processor interrupts and properly release > standard interrupts too. Thanks for fixing! > Suggested-by: Krzy

Re: [PATCH v2] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-10-15 Thread Krzysztof Kozlowski
On Mon, 15 Oct 2018 at 15:50, Bartlomiej Zolnierkiewicz wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented. > >

[PATCH / PULL 4/4] arm64: exynos: Enable generic power domain support

2018-10-10 Thread Krzysztof Kozlowski
From: Marek Szyprowski Generic power domains are needed to enable support for Exynos power domains. Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch

[GIT PULL 3/4] ARM: exynos: soc/mach for v4.20, second round

2018-10-10 Thread Krzysztof Kozlowski
Hi, On top of previous pull request. Best regards, Krzysztof The following changes since commit f30858439e7db9ce9847eaedf440635fc6349c6e: ARM: s3c24xx: Restore proper usage of pr_info/pr_cont (2018-09-19 19:11:17 +0200) are available in the Git repository at:

[GIT PULL 2/4] arm64: dts: exynos: Stuff for v4.20

2018-10-10 Thread Krzysztof Kozlowski
detect pin level. Andrzej Hajda (1): arm64: dts: exynos: Add OF graph between USB-PHY and MUIC Krzysztof Kozlowski (1): arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2 arch/arm64/boot/dts

[GIT PULL 0/4] arm: exynos: Last round for v4.20

2018-10-10 Thread Krzysztof Kozlowski
Hi, I just few left-overs. The last mail (4/4) is a patch directly, not a pull request. Best regards, Krzysztof

[GIT PULL 1/4] ARM: dts: exynos: Second round for v4.20

2018-10-10 Thread Krzysztof Kozlowski
) Samsung DTS ARM changes for v4.20, second round Add proper configuration for Odroid XU SD write-protect pin. Krzysztof Kozlowski (1): ARM: dts: exynos: Add pin configuration for SD write protect

Re: [PATCH] config: arm: exynos: remove PROVE_LOCKING from defconfig

2018-10-10 Thread Krzysztof Kozlowski
On Wed, 10 Oct 2018 at 11:56, Lukasz Luba wrote: > > Hi Krzysztof, > > Is it still valid that the Exynos has locking issues? The prepare lock of clocks was not solved entirely. We just implemented a set of workarounds. > Or is it enabled 'just-in-case'? Yes, all debugging features are

Re: [PATCH] config: arm: exynos: remove PROVE_LOCKING from defconfig

2018-10-10 Thread Krzysztof Kozlowski
On Tue, 9 Oct 2018 at 17:34, Lukasz Luba wrote: > > PROVE_LOCKING enables LOCKDEP, which causes big overhead on cache and > bus transactions. > > On some ARM big.LITTLE architecutres (Exynos 5433) the overhead is really big. > The overhead can be measures using hackbench test which will speed up

Re: [PATCH 3/7] clocksource: Change CPU hotplug priority of exynos_mct driver

2018-10-09 Thread Krzysztof Kozlowski
orking properly. > > Signed-off-by: Marek Szyprowski > --- > include/linux/cpuhotplug.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/7] clocksource: exynos_mct: Add arch_timer cooperation mode for ARM64

2018-10-09 Thread Krzysztof Kozlowski
On Mon, 8 Oct 2018 at 14:50, Marek Szyprowski wrote: > > To get ARM Architected Timers working on Samsung Exynos SoCs, one has to > first configure and enable Exynos Multi-Core Timer, because they both > share some common hardware blocks. This patch adds a mode of cooperation > with arch_timer

Re: [PATCH 1/7] clocksource: exynos_mct: Remove dead code

2018-10-09 Thread Krzysztof Kozlowski
Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2018-10-02 Thread Krzysztof Kozlowski
> 1 file changed, 17 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt Mine and Rob's tags disappeared already once (v2->v3) and... now again (from v3 to here). Just amend the commit in your local repo and add them permanently.

Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_CHECK config option to non-Exynos platforms

2018-10-01 Thread Krzysztof Kozlowski
On Fri, Sep 28, 2018 at 03:32:46PM +0200, Bartlomiej Zolnierkiewicz wrote: > "S3C2410 PM Suspend Memory CRC" feature (controlled by > SAMSUNG_PM_CHECK config option) is incompatible with highmem > (uses phys_to_virt() instead of proper mapping) which is used by > the majority of Exynos boards. The

Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-09-30 Thread Krzysztof Kozlowski
On Fri, Sep 28, 2018 at 06:34:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > > wrote: > >> > >> "Samsung PM Suspend debug" fe

Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms

2018-09-28 Thread Krzysztof Kozlowski
On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented.

[RESEND] dt-bindings: clock: samsung: Add SPDX license identifiers

2018-09-27 Thread Krzysztof Kozlowski
Replace GPL license statements with SPDX license identifiers (GPL-2.0). Signed-off-by: Krzysztof Kozlowski Acked-by: Chanwoo Choi Reviewed-by: Rob Herring --- include/dt-bindings/clock/exynos3250.h | 5 + include/dt-bindings/clock/exynos4.h| 7 ++- include/dt-bindings

[RESEND] dt-bindings: thermal: samsung: Add SPDX license identifier

2018-09-27 Thread Krzysztof Kozlowski
Replace GPL license statement with SPDX license identifier (GPL-2.0+). Signed-off-by: Krzysztof Kozlowski --- We postponed this patch because in previous discussion [1] Bartlomiej expressed willingness to change the license... which did not happen since July 2018. In such case let's take

[RESEND v2 1/2] backlight: Remove s6e63m0 driver

2018-09-27 Thread Krzysztof Kozlowski
The driver for S6E63M0 AMOLED LCD panel is not used. It does not support DeviceTree and respective possible users (S5Pv210 Aquila and Goni boards) are DeviceTree-only. Suggested-by: Marek Szyprowski Cc: Marek Szyprowski Cc: Inki Dae Signed-off-by: Krzysztof Kozlowski Acked-by: Jingoo Han

[RESEND v2 2/2] backlight: Remove ld9040 driver

2018-09-27 Thread Krzysztof Kozlowski
Dae Signed-off-by: Krzysztof Kozlowski Acked-by: Jingoo Han Acked-by: Daniel Thompson --- Changes since v1: 1. Add Jingoo's and Daniel's acks. --- drivers/video/backlight/Kconfig| 8 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/ld9040.c | 811

Re: [PATCHv4 4/6] ARM: dts: exynos: Add CD and WP pins to Odroid XU3/XU4 SD card

2018-09-27 Thread Krzysztof Kozlowski
On Thu, 27 Sep 2018 at 05:45, Anand Moon wrote: > > Hi Krzysztof, > On Thu, 27 Sep 2018 at 00:36, Krzysztof Kozlowski wrote: > > > > On Sat, Sep 22, 2018 at 07:52:36AM +, Anand Moon wrote: > > > Add the card-detect and write-protect GPIO pins for OdroidXU3/XU4 &

Re: [PATCHv4 0/6] Add support for UHS-I on Exynos5422 odroid boards

2018-09-26 Thread Krzysztof Kozlowski
On Sat, Sep 22, 2018 at 07:52:32AM +, Anand Moon wrote: > This is series v4 since my previous patches were incomplete with driver > changes missing. > > v4 changes. > squash cd-gpios and wp-gpio changes into single patch. > change the subject prefix to "ARM: dts: exynos:" > > These changes

Re: [PATCHv4 4/6] ARM: dts: exynos: Add CD and WP pins to Odroid XU3/XU4 SD card

2018-09-26 Thread Krzysztof Kozlowski
: No GPIO consumer cd found > dwmmc_exynos 1222.mmc: No GPIO consumer wp found > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Anand Moon > --- > Fix the commit message and squash it with cd-gpios and wp-gpio > patches into single patch as suggested by Krzys

[PATCH v2] ARM: dts: exynos: Add pin configuration for SD write protect on Odroid XU

2018-09-26 Thread Krzysztof Kozlowski
Add SD card write-protect pin configuration to be sure that it will be properly pulled down to indicate write access. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Remove cd-gpios and wp-gpios leaving only WP pin configuration (after Marek Szyprowski feedback). 2. Pull pin

Re: [PATCH] ARM: dts: exynos: Add CD and WP pins to Odroid XU SD card

2018-09-26 Thread Krzysztof Kozlowski
On Mon, Sep 24, 2018 at 12:04:52PM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2018-09-21 23:03, Krzysztof Kozlowski wrote: > > Defining card-detect and write-protect GPIO pins in Odroid XU SD Card > > does not change anything from functional point of

[GIT PULL] ARM: dts: exynos: DT for v4.20 (or 5.0) (revised)

2018-09-24 Thread Krzysztof Kozlowski
: Add DSI and panel nodes on Arndale ARM: dts: exynos: Use i2c-gpio for HDMI-DDC on Arndale ARM: dts: exynos: Fix HDMI-HPD line handling on Arndale Krzysztof Kozlowski (6): ARM: dts: s5pv210: Switch to S5Pv210 specific pinctrl wakeup compatible ARM: dts: exynos: Add missing

Re: [GIT PULL 2/2] ARM: dts: exynos: DT for v4.20 (or 5.0)

2018-09-24 Thread Krzysztof Kozlowski
On Sun, Sep 23, 2018 at 06:47:42AM -0700, Olof Johansson wrote: > Hi, > > On Fri, Sep 21, 2018 at 07:45:19PM +0200, Krzysztof Kozlowski wrote: > > Hi, > > > > Nothing special, description in tag. > > Hmm. Point 12 is special, I'd say. > > I commented

Re: [PATCH v3] dt-bindings: arm: Explicitly mark Samsung Exynos SoC as unstable

2018-09-24 Thread Krzysztof Kozlowski
On Sun, Sep 23, 2018 at 02:46:20PM +0100, Olof Johansson wrote: > On Thu, Aug 30, 2018 at 7:02 PM, Krzysztof Kozlowski wrote: > > Samsung Exynos SoCs and boards related bindings evolved since the initial > > introduction, but initially the bindings were minimal and a

Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card

2018-09-21 Thread Krzysztof Kozlowski
On Fri, Sep 21, 2018 at 06:01:07PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On Fri, 21 Sep 2018 at 16:42, Krzysztof Kozlowski wrote: > > > > On Thu, 20 Sep 2018 at 19:59, Anand Moon wrote: > > > > > > add the Write Protect GPIO property for sdcard,

[PATCH] ARM: dts: exynos: Add CD and WP pins to Odroid XU SD card

2018-09-21 Thread Krzysztof Kozlowski
.mmc: No GPIO consumer wp found Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index a2046f5f998c

[RFT] arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2

2018-09-21 Thread Krzysztof Kozlowski
The SDHCI standard, MMC host controller bindings and MMC core defines card detect pin as active low. Therefore there is no point to invert it twice. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[GIT PULL 1/2] ARM: exynos: mach/soc for v4.20 (or 5.0)

2018-09-21 Thread Krzysztof Kozlowski
ARM: s3c24xx: Correct SD card write protect detection on Mini2440 ARM: s3c24xx: Restore proper usage of pr_info/pr_cont Krzysztof Kozlowski (4): ARM: exynos: Store Exynos5420 register state in one variable ARM: exynos: Fix imprecise abort during Exynos5422 suspend to RAM

[GIT PULL 2/2] ARM: dts: exynos: DT for v4.20 (or 5.0)

2018-09-21 Thread Krzysztof Kozlowski
: exynos: Add DSI and panel nodes on Arndale ARM: dts: exynos: Use i2c-gpio for HDMI-DDC on Arndale ARM: dts: exynos: Fix HDMI-HPD line handling on Arndale Krzysztof Kozlowski (7): ARM: dts: s5pv210: Switch to S5Pv210 specific pinctrl wakeup compatible ARM: dts: exynos: Add

Re: [PATCH] ARM: dts: exynos: ordering wrong order tmu_cpu on Odroid-XU3/4 thermal-zones definition

2018-09-21 Thread Krzysztof Kozlowski
On Fri, 21 Sep 2018 at 13:33, Willy Wolff wrote: > > This patch is to open a discussion about wrong order of tmu_cpu. > > It seems that tmu_cpu1 correspond to cpu3, and tmu_cpu3 match cpu1. > Note, cpu{0|3} in dtsi correspond to cpu{3|7} in linux and are the big > cores. Hi, I do not understand

Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card

2018-09-21 Thread Krzysztof Kozlowski
On Thu, 20 Sep 2018 at 19:59, Anand Moon wrote: > > add the Write Protect GPIO property for sdcard, to fix > the warning message during boot time. > of_get_named_gpiod_flags: can't parse 'wp-gpios' property of node > '/soc/mmc@1222[0]' > > Signed-off-by: Anand Moon > --- > New patch to this

Re: [PATCHv3 0/7] Add support for UHS-I on Exynos5422 odroid boards

2018-09-21 Thread Krzysztof Kozlowski
On Thu, 20 Sep 2018 at 19:58, Anand Moon wrote: > > This is series v3 since my previous patches we incomplete with driver > changes missing. > > These changes add UHS-I tuning for dw_mmc-exynos driver. > Some new patches are added to enhance the performace. Patches look like based on some older

Re: [PATCH] ARM: s3c24xx: fix usage of pr_info/pr_cont

2018-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 17, 2018 at 10:43:50PM +0200, Cedric Roux wrote: > This commit fixes the wrong usage of pr_info introduced by the > commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in > mach-mini2440.c"). > > Since the idea is to print on a single line, pr_cont has to be used. > >

Re: arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error: linux/crc32poly.h: No such file or directory

2018-09-19 Thread Krzysztof Kozlowski
On Wed, 19 Sep 2018 at 05:57, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5211da9ca526a5adddee1ccd078e6e33a583ab36 > commit: faa16bc404d72a5afb857c924c83a5f691f83386 lib: Use existing define > with polynomial > date:

Re: [PATCH v3] dt-bindings: arm: Explicitly mark Samsung Exynos SoC as unstable

2018-09-17 Thread Krzysztof Kozlowski
On Thu, Aug 30, 2018 at 08:02:05PM +0200, Krzysztof Kozlowski wrote: > Samsung Exynos SoCs and boards related bindings evolved since the initial > introduction, but initially the bindings were minimal and a bit incomplete > (they never described all the hardware modules available in

Re: [PATCH v3 3/3] dt-bindings: mfd: max8998: Add charger subnode binding

2018-09-17 Thread Krzysztof Kozlowski
On Thu, 13 Sep 2018 at 16:56, Paweł Chmiel wrote: > > On Tuesday, August 7, 2018 11:57:42 AM CEST Rob Herring wrote: > > On Tue, Jul 17, 2018 at 06:05:09PM +0200, Paweł Chmiel wrote: > > > This patch adds devicetree bindings documentation for > > > battery charging controller as the subnode of

Re: [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes

2018-09-17 Thread Krzysztof Kozlowski
On Sun, 16 Sep 2018 at 22:03, Sebastian Reichel wrote: > > Hi Matheus, > > Did I miss a v2 of this patchset, that solves the issues > found by Krzysztof? I did not see v2. This patchset brings nice feature so it would be a pity if it were discontinued. Best regards, Krzysztof

Re: [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

2018-09-17 Thread Krzysztof Kozlowski
On Thu, 13 Sep 2018 at 22:24, Cedric Roux wrote: > > Hi, > > On 09/12/2018 09:21 PM, Joe Perches wrote: > > On Fri, 2018-09-07 at 23:54 +0200, Cedric Roux wrote: > >> Running: > >> scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c > >> revealed several errors and warnings. > >> >

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, Sep 07, 2018 at 11:54:46PM +0200, Cedric Roux wrote: > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use >

Re: [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

2018-09-10 Thread Krzysztof Kozlowski
On Fri, Sep 07, 2018 at 11:54:45PM +0200, Cedric Roux wrote: > Running: > scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c > revealed several errors and warnings. > > They were all removed, except one which is an #if 0 around the declaration > of a gpio pin. This needs some more

[PATCH] ARM: s3c24xx: Consistently use tab for indenting member assignments

2018-09-10 Thread Krzysztof Kozlowski
Code was mixing spaces and tabs for indenting members in structures. Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-s3c24xx/mach-mini2440.c | 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Mon, Sep 10, 2018 at 06:55:09PM +0200, Cedric Roux wrote: > On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: > >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { > >> - .gpio_detect = S3C2410_GPG(8), > >> -

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-10 Thread Krzysztof Kozlowski
On Fri, 7 Sep 2018 at 23:53, Cedric Roux wrote: > > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use > ".wprotect_invert =

Re: [BUG BISECT] NFS root failure (NULL pointer)

2018-09-10 Thread Krzysztof Kozlowski
On Mon, 10 Sep 2018 at 08:44, Krzysztof Kozlowski wrote: > > On Thu, 6 Sep 2018 at 09:10, Krzysztof Kozlowski wrote: > > > > Hi, > > > > Today's next fails to mount NFS root under my ARM targets and fails to > > mount root from file image under QMU. > >

Re: [BUG BISECT] NFS root failure (NULL pointer)

2018-09-10 Thread Krzysztof Kozlowski
On Thu, 6 Sep 2018 at 09:10, Krzysztof Kozlowski wrote: > > Hi, > > Today's next fails to mount NFS root under my ARM targets and fails to > mount root from file image under QMU. > > [ 21.512866] Unable to handle kernel NULL pointer dereference at > virtual addres

Re: [PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-07 Thread Krzysztof Kozlowski
On Thu, 6 Sep 2018 at 23:27, Cedric Roux wrote: > > The mini2440 computer uses "active high" to signal that the "write protect" > of the inserted MMC is set. The current code uses the opposite, leading to > a wrong detection of write protection. The solution is simply to use > ".wprotect_invert =

Re: [PATCH AUTOSEL 4.14 27/67] ARM: exynos: Define EINT_WAKEUP_MASK registers for S5Pv210 and Exynos5433

2018-09-07 Thread Krzysztof Kozlowski
On Fri, 7 Sep 2018 at 02:54, Sasha Levin wrote: > > From: Krzysztof Kozlowski > > [ Upstream commit e5cda42c16d89720c29678f51d95a119490ef7d8 ] > > S5Pv210 and Exynos5433/Exynos7 have different address of > EINT_WAKEUP_MASK register. Rename existing S5P_EINT_WAKEUP_MASK

[BUG BISECT] NFS root failure (NULL pointer)

2018-09-06 Thread Krzysztof Kozlowski
Hi, Today's next fails to mount NFS root under my ARM targets and fails to mount root from file image under QMU. [ 21.512866] Unable to handle kernel NULL pointer dereference at virtual address [ 21.695484] [] (nfs_fs_mount) from [] (legacy_get_tree+0x34/0xec) [ 21.703225] []

[RFT] ARM: dts: exynos: Remove double SD card detect pin inversion

2018-09-05 Thread Krzysztof Kozlowski
The SDHCI standard, MMC host controller bindings and MMC core defines card detect pin as active low. Therefore there is no point to invert it twice. Signed-off-by: Krzysztof Kozlowski --- Tested only on Odroid U3. Tests on other platforms would be appreciated. --- arch/arm/boot/dts

Re: [PATCH v2] mfd: max8997: Disable interrupt handling for suspend/resume cycle

2018-09-05 Thread Krzysztof Kozlowski
t; also used in other MAX PMIC MFD drivers. > > Signed-off-by: Marek Szyprowski > --- > changelog: > v2: > - reordered the sequence of operation as suggested by Krzysztof Kozlowski > --- > drivers/mfd/max8997.c | 2 ++ > 1 file changed, 2 insertions(+) > Revie

  1   2   3   4   5   6   7   8   9   10   >