Process for severe early stable bugs?

2018-12-07 Thread Laura Abbott
The latest file system corruption issue (Nominally fixed by ffe81d45322c ("blk-mq: fix corruption with direct issue") later fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch list")) brought a lot of rightfully concerned users asking about release schedules. 4.18 went EOL on Nov

Re: [PATCH] Revert "HID: uhid: use strlcpy() instead of strncpy()"

2018-11-14 Thread Laura Abbott
On 11/14/18 5:16 AM, David Herrmann wrote: This reverts commit 336fd4f5f25157e9e8bd50e898a1bbcd99eaea46. Please note that `strlcpy()` does *NOT* do what you think it does. strlcpy() *ALWAYS* reads the full input string, regardless of the 'length' parameter. That is, if the input is not

Re: [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-05 Thread Laura Abbott
On 11/5/18 6:32 AM, Yangtao Li wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Acked-by: Laura Abbott Signed-off-by: Yangtao Li --- arch/arm/mm/ptdump_debugfs.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/arch/arm/mm/ptdump_debugfs.c b

Re: Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-24 Thread Laura Abbott
On 10/21/2018 02:20 PM, NeilBrown wrote: I call on the community to consider what *does* need to be said, about conduct, to people outside the community and who have recently joined. What is the document that you would have liked to have read as you were starting out? It is all too long ago

Re: [PATCH] arm64: kprobe: make page to RO mode when allocate it

2018-10-22 Thread Laura Abbott
Reviewed-by: Laura Abbott Cc: Arnd Bergmann Cc: Ard Biesheuvel Cc: Laura Abbott Cc: Catalin Marinas Co-developed-by: Arnd Bergmann Co-developed-by: Ard Biesheuvel Signed-off-by: Anders Roxell --- arch/arm64/kernel/probes/kprobes.c | 27 --- 1 file changed,

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-22 Thread Laura Abbott
. Instead, we can just cast the label (as done with the size calculations earlier) to avoid the problem. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1639397 Acked-by: Laura Abbott Reported-by: William Cohen Fixes: 6974f0c4555e ("include/linux/string.h: add the option of fort

[PATCH] kgdboc: Fix warning with module build

2018-09-19 Thread Laura Abbott
tion_setup(char *opt) ^~~ Move the function under the appropriate ifdef for builtin only. Fixes: 2dd453168643 ("kgdboc: Fix restrict error") Signed-off-by: Laura Abbott --- drivers/tty/serial/kgdboc.c | 37 +++-- 1 file ch

Re: [PATCH] proc: restrict kernel stack dumps to root

2018-09-12 Thread Laura Abbott
On 09/12/2018 03:27 PM, Kees Cook wrote: On Wed, Sep 12, 2018 at 8:29 AM, Jann Horn wrote: +linux-api, I guess On Tue, Sep 11, 2018 at 8:39 PM Jann Horn wrote: Restrict the ability to inspect kernel stacks of arbitrary tasks to root in order to prevent a local attacker from exploiting racy

[PATCH] misc: kgdbts: Fix restrict error

2018-09-10 Thread Laura Abbott
used in both the source and destination. Refactor the code to only do the copy when needed. Signed-off-by: Laura Abbott --- drivers/misc/kgdbts.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c index

[PATCHv3] iscsi-target: Don't use stack buffer for scatterlist

2018-09-04 Thread Laura Abbott
. There are two cases that trigger this bug. Switch to using a dynamically allocated buffer for one case and do not assign a NULL buffer in another case. Signed-off-by: Laura Abbott --- v3: Switched to kcalloc to drop an extra memset call. I was asked offline about kmalloc vs. kmalloc_array and ended up

Re: [PATCH v2] staging: android: ion: fix ION_IOC_{MAP,SHARE} use-after-free

2018-09-04 Thread Laura Abbott
to use it safely. This patch is applied on top of 4.4.y, and applies to older kernels too. 4.9.y was fixed separately. Kernels 4.12 and later are unaffected, since all the underlying ion_handle infrastructure has been ripped out. Acked-by: Laura Abbott Cc: sta...@vger.kernel.org # v4.4-

[PATCHv2] iscsi-target: Don't use stack buffer for scatterlist

2018-08-23 Thread Laura Abbott
. There are two cases that trigger this bug. Switch to using a dynamically allocated buffer for one case and do not assign a NULL buffer in another case. Signed-off-by: Laura Abbott --- v2: Change the returns to breaks to avoid leaking memory --- drivers/target/iscsi/iscsi_target.c | 21

[PATCH] iscsi-target: Don't use stack buffer for scatterlist

2018-08-22 Thread Laura Abbott
. There are two cases that trigger this bug. Switch to using a dynamically allocated buffer for one case and do not assign a NULL buffer in another case. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1615258 Signed-off-by: Laura Abbott --- drivers/target/iscsi/iscsi_target.c | 11 +-- 1

[PATCH] efi/libstub: Only disable stackleak plugin for arm64

2018-07-30 Thread Laura Abbott
plugin for arm64 only. Signed-off-by: Laura Abbott --- drivers/firmware/efi/libstub/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile index 25dd2a14560d..88c322d7c71e 100644

Re: linux-next: build failure after merge of the kspp tree

2018-07-30 Thread Laura Abbott
On 07/30/2018 12:33 AM, Stephen Rothwell wrote: Hi all, On Fri, 27 Jul 2018 13:55:22 +0100 Will Deacon wrote: On Fri, Jul 27, 2018 at 08:55:11PM +1000, Stephen Rothwell wrote: On Fri, 27 Jul 2018 19:06:47 +1000 Stephen Rothwell wrote: On Fri, 27 Jul 2018 19:02:07 +1000 Stephen Rothwell

Re: [PATCHv3 0/2] Stackleak for arm64

2018-07-25 Thread Laura Abbott
On 07/25/2018 04:49 AM, Will Deacon wrote: Hi Laura, On Tue, Jul 24, 2018 at 05:38:07PM +0100, Will Deacon wrote: On Fri, Jul 20, 2018 at 02:41:52PM -0700, Laura Abbott wrote: This is the version of stackleak for arm64, hopefully ready for queueing Thanks. I'll push these into linux-next

[PATCHv3 2/2] arm64: Add support for STACKLEAK gcc plugin

2018-07-20 Thread Laura Abbott
. Additionally, this disables the plugin in hypervisor and EFI stub code, which are out of scope for the protection. Reviewed-by: Mark Rutland Reviewed-by: Kees Cook Signed-off-by: Laura Abbott --- v3: Actual commit text courtesy of Kees. A comment explaining why we panic --- arch/arm64/Kconfig

[PATCHv3 1/2] arm64: Add stack information to on_accessible_stack

2018-07-20 Thread Laura Abbott
In preparation for enabling the stackleak plugin on arm64, we need a way to get the bounds of the current stack. Extend on_accessible_stack to get this information. Reviewed-by: Mark Rutland Signed-off-by: Laura Abbott --- v3: Switched some logic to reduce if nesting --- arch/arm64/include

[PATCHv3 0/2] Stackleak for arm64

2018-07-20 Thread Laura Abbott
Hi, This is the version of stackleak for arm64, hopefully ready for queueing Laura Abbott (2): arm64: Add stack information to on_accessible_stack arm64: Add support for STACKLEAK gcc plugin arch/arm64/Kconfig| 1 + arch/arm64/include/asm/processor.h| 15

[PATCHv2 1/2] arm64: Add stack information to on_accessible_stack

2018-07-19 Thread Laura Abbott
In preparation for enabling the stackleak plugin on arm64, we need a way to get the bounds of the current stack. Extend on_accessible_stack to get this information. Signed-off-by: Laura Abbott --- v2: Switched to using struct stack_info for argument passing. on_accessible_stack is now

[PATCHv2 2/2] arm64: Clear the stack

2018-07-19 Thread Laura Abbott
Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- v2: Convert to adjusted on_acessible_stack APIs. Fixed alloca check to just panic. Dropped the extra include per Kees. I also didn't add the Reviewed-by since the APIs did change and I wanted another

[PATCHv2 0/2] Stackleak for arm64

2018-07-19 Thread Laura Abbott
Hi, This is hopefully the final version of the stackleak plugin for arm64. Acks are appreciated! Laura Abbott (2): arm64: Add stack information to on_accessible_stack arm64: Clear the stack arch/arm64/Kconfig| 1 + arch/arm64/include/asm/processor.h| 15

[PATCH 0/2] Stackleak for arm64

2018-07-18 Thread Laura Abbott
and not actually put a version on it. I negelcted to do that last time but as mentioned this is inteded to go with v14. Laura Abbott (2): arm64: Introduce current_stack_type arm64: Clear the stack arch/arm64/Kconfig| 1 + arch/arm64/include/asm/processor.h| 17

[PATCH 1/2] arm64: Introduce current_stack_type

2018-07-18 Thread Laura Abbott
In preparation for enabling the stackleak plugin on arm64, we need a way to get the bounds of the current stack. Introduce a new primitive current_stack_type which is similar to x86's get_stack_info. Utilize that to rework on_accessible_stack slightly as well. Signed-off-by: Laura Abbott

[PATCH 2/2] arm64: Clear the stack

2018-07-18 Thread Laura Abbott
Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- Since last time: Minor style cleanups. Re-wrote check_alloca to correctly handle all stack types. While doing that, I also realized current_top_of_stack was incorrect so I fixed that as well. --- arch

Re: [PATCH] arm64: Clear the stack

2018-07-17 Thread Laura Abbott
On 07/03/2018 05:14 AM, Mark Rutland wrote: It might be cleaner just to use on_accessible_stack and then another function to get the top of stack. This also might just be reimplementing what x86 already has? (Mark, Ard?) It looks like we could build a get_stack_info() as they have. We could

compliation error with aio_abi.h

2018-07-16 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1601529 with 4.18-rc4: Steps to Reproduce: 1.echo 'int f;' | gcc -include linux/aio_abi.h -xc -c - -o /dev/null Actual results: /usr/include/asm/signal.h:127:2: error: unknown type name ‘size_t’ size_t ss_size; ^~

Re: [PATCH] arm64: build with baremetal linker target instead of Linux when available

2018-07-13 Thread Laura Abbott
On 07/13/2018 08:30 AM, Olof Johansson wrote: Not all toolchains have the baremetal elf targets, RedHat/Fedora ones in particular. So, probe for whether it's available and use the previous (linux) targets if it isn't. For the Fedora toolchains: Tested-by: Laura Abbott Reported-by: Laura

Re: [PATCH] arm64: Add support for STACKLEAK gcc plugin

2018-07-11 Thread Laura Abbott
On 07/11/2018 05:03 PM, Kees Cook wrote: From: Laura Abbott This adds support for the STACKLEAK gcc plugin to arm64 by implementing stackleak_check_alloca(), based heavily on the x86 version, and adding the two helpers used by the stackleak common code: current_top_of_stack

[PATCHv2] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"

2018-07-09 Thread Laura Abbott
ently fall into this category so just revert it. Fixes: 38fc42486775 ("arm64: Use aarch64elf and aarch64elfb emulation mode variants") Tested-by: Kevin Hilman Signed-off-by: Laura Abbott --- v2: Tweaked the commit text to be a bit clearer about what the underlying problem is. --- arch/arm64/Makef

[PATCHv2 1/7] tools: build: Fixup host c flags

2018-07-09 Thread Laura Abbott
Commit 0c3b7e42616f ("tools build: Add support for host programs format") introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the variable is HOSTCFLAGS. Fix this up. Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") Signed-off-by:

[PATCHv2 4/7] treewide: Rename HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS

2018-07-09 Thread Laura Abbott
In preparation for enabling command line CXXFLAGS, re-name HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- v2: Dropped name change for individual files (still HOSTCXXFLAGS_foo) --- Makefile

[PATCHv2] treewide: Rename HOSTCFLAGS -> KBUILD_HOSTCFLAGS

2018-07-09 Thread Laura Abbott
In preparation for enabling command line CFLAGS, re-name HOSTCFLAGS to KBUILD_HOSTCFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- v2: Dropped name change for individual files (still CHOSTFLAGS_foo) --- Makefile

[PATCHv2 5/7] treewide: Rename HOSTLDFLAGS to KBUILD_HOSTLDFLAGS

2018-07-09 Thread Laura Abbott
In preparation for enabling command line LDFLAGS, re-name HOSTLDFLAGS to KBUILD_HOSTLDFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- v2: No change --- Makefile | 4 ++-- net/bpfilter/Makefile | 2 +- scripts

[PATCHv2 6/7] treewide: Rename HOST_LOADLIBES to KBUILD_HOSTLDLIBS

2018-07-09 Thread Laura Abbott
In preparation for enabling command line LDLIBS, re-name HOST_LOADLIBES to KBUILD_HOSTLDLIBS as the internal use only flags. Also rename existing usage to HOSTLDLIBS for consistency. This should not have any visible effects. Signed-off-by: Laura Abbott --- v2: Rename existing HOSTLOADLIBES

[PATCHv2 2/7] tools: build: Use HOSTLDFLAGS with fixdep

2018-07-09 Thread Laura Abbott
The final link of fixdep uses LDFLAGS but not the existing HOSTLDFLAGS. Fix this. Signed-off-by: Laura Abbott --- v2: Switch to just using HOSTLDFLAGS instead of both LDFLAGS and HOSTLDFLAGS. --- tools/build/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

Re: [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"

2018-07-09 Thread Laura Abbott
On 07/09/2018 01:09 PM, Laura Abbott wrote: This reverts commit 38fc4248677552ce35efc09902fdcb06b61d7ef9. This breaks compilation with Fedora gcc-8 tool chains: CHK include/generated/compile.h LD [M] arch/arm64/crypto/sha512-ce.o aarch64-linux-gnu-ld: cannot open linker script file

[PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"

2018-07-09 Thread Laura Abbott
or directory make[1]: *** [scripts/Makefile.build:530: arch/arm64/crypto/sha512-ce.o] Error 1 make: *** [Makefile:1029: arch/arm64/crypto] Error 2 Fixes: 38fc42486775 ("arm64: Use aarch64elf and aarch64elfb emulation mode variants") Signed-off-by: Laura Abbott --- A bit rushed and I'm still

[PATCH 0/7] HOSTFLAGS and HOSTLDFLAGS from the environment (new approach)

2018-07-06 Thread Laura Abbott
dhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection" HOSTLDFLAGS="-Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld" Thanks, Laura Laura Abbott (7): tools: build: Fixup host c flags tools: build: U

[PATCH 3/7] treewide: Rename HOSTCFLAGS -> KBUILD_HOSTCFLAGS

2018-07-06 Thread Laura Abbott
In preparation for enabling command line CFLAGS, re-name HOSTCFLAGS to KBUILD_HOSTCFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- Makefile | 4 ++-- arch/alpha/boot/Makefile | 2 +- arch/s390/tools/Makefile

[PATCH 5/7] treewide: Rename HOSTLDFLAGS to KBUILD_HOSTLDFLAGS

2018-07-06 Thread Laura Abbott
In preparation for enabling command line LDFLAGS, re-name HOSTLDFLAGS to KBUILD_HOSTLDFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- Makefile | 4 ++-- net/bpfilter/Makefile | 2 +- scripts/Makefile.host | 10

[PATCH 1/7] tools: build: Fixup host c flags

2018-07-06 Thread Laura Abbott
Commit 0c3b7e42616f ("tools build: Add support for host programs format") introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the variable is HOSTCFLAGS. Fix this up. Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") Signed-

[PATCH 4/7] treewide: Rename HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS

2018-07-06 Thread Laura Abbott
In preparation for enabling command line CXXFLAGS, re-name HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- Makefile | 4 ++-- scripts/Makefile.host| 4 ++-- scripts/kconfig

[PATCH 7/7] Kbuild: Use HOST*FLAGS options from the command line

2018-07-06 Thread Laura Abbott
Now that we have the rename in place, reuse the HOST*FLAGS options as something that can be set from the command line and included with the rest of the flags. Signed-off-by: Laura Abbott --- Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b

[PATCH 2/7] tools: build: Use HOSTLDFLAGS with fixdep

2018-07-06 Thread Laura Abbott
The final link of fixdep uses LDFLAGS but not the existing HOSTLDFLAGS. Fix this. Signed-off-by: Laura Abbott --- This was another one where I couldn't tell of the use of LDFLAGS was a typo or intentional, hence keeping both. --- tools/build/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 6/7] treewide: Rename HOST_LOADLIBES to KBUILD_HOSTLDLIBS

2018-07-06 Thread Laura Abbott
In preparation for enabling command line LDLIBS, re-name HOST_LOADLIBES to KBUILD_HOSTLDLIBS as the internal use only flags. This should not have any visible effects. Signed-off-by: Laura Abbott --- Makefile | 4 ++-- samples/bpf/Makefile | 2 +- scripts/Makefile.host | 10

Re: [PATCH] arm64: Clear the stack

2018-07-02 Thread Laura Abbott
On 07/02/2018 06:02 AM, Alexander Popov wrote: Hello Laura, Thanks for your work! Please see my comments below. On 29.06.2018 22:05, Laura Abbott wrote: Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- Changes since last time: - Minor name change

Re: [PATCH] arm64: Clear the stack

2018-06-29 Thread Laura Abbott
On 06/29/2018 01:19 PM, Kees Cook wrote: On Fri, Jun 29, 2018 at 12:05 PM, Laura Abbott wrote: Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott [...] +#define current_top_of_stack() (task_stack_page(current) + THREAD_SIZE) +#define on_thread_stack

[PATCH] arm64: Clear the stack

2018-06-29 Thread Laura Abbott
Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- Changes since last time: - Minor name change in entry.S - Converted to use the generic interfaces so there's minimal additions. - Added the fast syscall path. - Addition of on_thread_stack

F_OFD_GETLK implemented wrong with CIFS protocol version 2.0+

2018-06-25 Thread Laura Abbott
Hi, A while back, someone reported a failure on Fedora when trying to boot a QEMU image off of a CIFS share. The issue was reduced down to a test case (https://bugzilla.redhat.com/show_bug.cgi?id=1484130#c8) # cat test-ofd-lock.c #define _GNU_SOURCE #include #include #include #include int

Re: [PATCH] add param that allows bootline control of hardened usercopy

2018-06-25 Thread Laura Abbott
On 06/25/2018 08:22 AM, Christoph von Recklinghausen wrote: Add correct address for linux-mm On 06/25/2018 11:08 AM, Chris von Recklinghausen wrote: Enabling HARDENED_USER_COPY causes measurable regressions in the networking performances, up to 8% under UDP flood. A generic distro may want to

Re: [PATCHv4 3/3] x86: Add build salt to the vDSO and kernel linker scripts

2018-06-21 Thread Laura Abbott
On 06/21/2018 05:43 AM, Ingo Molnar wrote: * Laura Abbott wrote: Both the kernel and the vDSO need to have unique build ids. Insert the build salt section to make the build ids unique. Signed-off-by: Laura Abbott --- arch/x86/entry/vdso/vdso-layout.lds.S | 3 ++- arch/x86/kernel

Re: [PATCHv4 2/3] kbuild: Introduce build-salt linker section and config option

2018-06-14 Thread Laura Abbott
On 06/12/2018 11:06 PM, Masahiro Yamada wrote: Hi. 2018-06-12 9:32 GMT+09:00 Laura Abbott : The build id generated from --build-id can be generated in several different ways, with the default being the sha1 on the output of the linked file. For distributions, it can be useful to make sure

Re: [PATCHv4 1/3] scripts: Preprocess module-common.lds

2018-06-12 Thread Laura Abbott
to help improve the system] url: https://github.com/0day-ci/linux/commits/Laura-Abbott/scripts-Preprocess-module-common-lds/20180612-083632 config: i386-randconfig-a1-201823 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux

[PATCHv4 3/3] x86: Add build salt to the vDSO and kernel linker scripts

2018-06-11 Thread Laura Abbott
Both the kernel and the vDSO need to have unique build ids. Insert the build salt section to make the build ids unique. Signed-off-by: Laura Abbott --- arch/x86/entry/vdso/vdso-layout.lds.S | 3 ++- arch/x86/kernel/vmlinux.lds.S | 1 + 2 files changed, 3 insertions(+), 1 deletion

[PATCHv4 0/3] Salted build ids via linker sections

2018-06-11 Thread Laura Abbott
ripped automatically. This is pretty small but I also know people can be picky so I'm open to opinions or suggestions here. Laura Abbott (3): scripts: Preprocess module-common.lds kbuild: Introduce build-salt linker section and config option x86: Add build salt to the vDSO and kernel linker scri

[PATCHv4 2/3] kbuild: Introduce build-salt linker section and config option

2018-06-11 Thread Laura Abbott
Torvalds Signed-off-by: Laura Abbott --- include/asm-generic/vmlinux.lds.h | 6 ++ init/Kconfig | 9 + scripts/module-common.lds.S | 4 3 files changed, 19 insertions(+) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h

[PATCHv4 1/3] scripts: Preprocess module-common.lds

2018-06-11 Thread Laura Abbott
In preparation for some upcoming work, allow module-common.lds to be run through the preprocessor. Signed-off-by: Laura Abbott --- scripts/.gitignore | 1 + scripts/Makefile | 2 +- scripts/{module-common.lds => mod

Re: [PATCH] Revert "debugfs: inode: debugfs_create_dir uses mode permission from parent"

2018-06-11 Thread Laura Abbott
On 06/11/2018 02:28 AM, Thomas Richter wrote: This reverts commit 95cde3c59966f6371b6bcd9e4e2da2ba64ee9775. It breaks the ioctl(KVM_CREATE_VM) interface. Can you elaborate a little more on how this breaks? Fedora has gotten at least one report of a failure in this ioctl and I'd like know if

Re: [PATCH v2 1/3] arm64/mm: pass swapper_pg_dir as an argument to __enable_mmu()

2018-06-05 Thread Laura Abbott
On 06/05/2018 02:33 AM, Jun Yao wrote: Introduce __pa_swapper_pg_dir to save physical address of swapper_pg_dir. And pass it as an argument to __enable_mmu(). Signed-off-by: Jun Yao --- arch/arm64/include/asm/mmu_context.h | 4 +--- arch/arm64/include/asm/pgtable.h | 1 +

Re: [RFC PATCH 0/5] kmalloc-reclaimable caches

2018-05-24 Thread Laura Abbott
On 05/24/2018 08:52 AM, Vlastimil Babka wrote: On 05/24/2018 02:13 PM, Roman Gushchin wrote: On Thu, May 24, 2018 at 01:00:06PM +0200, Vlastimil Babka wrote: Hi, - I haven't find any other obvious users for reclaimable kmalloc (yet) As I remember, ION memory allocator was discussed related

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/23/2018 06:43 PM, Masahiro Yamada wrote: 2018-05-24 9:11 GMT+09:00 Masahiro Yamada <yamada.masah...@socionext.com>: 2018-05-24 7:53 GMT+09:00 Laura Abbott <labb...@redhat.com>: On 05/22/2018 05:33 PM, Andy Lutomirski wrote: On Tue, May 22, 2018 at 5:19 PM Laura

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/23/2018 05:06 PM, Linus Torvalds wrote: On Wed, May 23, 2018, 17:01 Andy Lutomirski > wrote: I don’t know whether I’m missing something obvious, but can’t this be in C? Yes, but I thought Laura wanted to limit it to linker file

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/22/2018 05:33 PM, Andy Lutomirski wrote: On Tue, May 22, 2018 at 5:19 PM Laura Abbott <labb...@redhat.com> wrote: The vDSO is linked separately from the kernel and modules. Ensure it picks up the comment section, if available. Did you end up preferring this to just sticking the

Re: [PATCH] dma-buf: simplified calling conventions for dma_buf_fd()

2018-05-23 Thread Laura Abbott
ccount. For the Ion portion, Acked-by: Laura Abbott <labb...@redhat.com> Signed-off-by: Al Viro <v...@zeniv.linux.org.uk> [jw: rebased and updated commit message] Signed-off-by: Jens Wiklander <jens.wiklan...@linaro.org> --- I received this patch as a response to what has become bb76

Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

2018-05-23 Thread Laura Abbott
de to reverting the series. Acked-by: Laura Abbott <labb...@redhat.com> Reported-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Joonsoo Kim <iamjoonsoo@lge.com> --- arch/arm/mm/dma-mapping.c | 16 +--- include/linux/memory_hotplug.h | 3

[PATCHv2] arm64: Make sure permission updates happen for pmd/pud

2018-05-23 Thread Laura Abbott
fe instead of p*d_present for determining if the change is permitted. Reported-by: Peter Robinson <pbrobin...@gmail.com> Fixes: 15122ee2c515 ("arm64: Enforce BBM for huge IO/VMAP mappings") Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: Switch to using pgat

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-22 Thread Laura Abbott
On 05/22/2018 05:33 PM, Andy Lutomirski wrote: On Tue, May 22, 2018 at 5:19 PM Laura Abbott <labb...@redhat.com> wrote: The vDSO is linked separately from the kernel and modules. Ensure it picks up the comment section, if available. Did you end up preferring this to just sticking the

[PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-22 Thread Laura Abbott
The vDSO is linked separately from the kernel and modules. Ensure it picks up the comment section, if available. Signed-off-by: Laura Abbott <labb...@redhat.com> --- v3: Invoke the generated linker script. The ".." nightmare is pretty ugly but I didn't see an easier way to pick

[PATCHv3 0/2] Salted build ids via linker sections

2018-05-22 Thread Laura Abbott
to want all the time). I've also dropped the RFC tag since it's well formed enough at this point. Laura Abbott (2): kbuild: Introduce build-salt linker script x86/vdso: Add build salt to the vDSO Makefile | 4 +++- arch/x86/entry/vdso/Makefile | 4 +++- scripts/.giti

[PATCHv3 1/2] kbuild: Introduce build-salt linker script

2018-05-22 Thread Laura Abbott
this is to insert a comment section with some data. Introduce a generated linker script to link against the kernel/modules. This puts the kernel version in a .comment section which will generate a unique build id if the kernel version changes. Signed-off-by: Laura Abbott <labb...@redhat.com> --- v3: Ge

[PATCH] arm64: Make sure permission updates happen for pmd/pud

2018-05-22 Thread Laura Abbott
op level p*d_set_huge APIs but using separate functions for the update APIs. Reported-by: Peter Robinson <pbrobin...@gmail.com> Fixes: 15122ee2c515 ("arm64: Enforce BBM for huge IO/VMAP mappings") Signed-off-by: Laura Abbott <labb...@redhat.com> --- arch/arm64/mm/mmu.c | 28

[PATCHv9] gpio: Remove VLA from gpiolib

2018-05-21 Thread Laura Abbott
lu...@wunner.de> Signed-off-by: Lukas Wunner <lu...@wunner.de> Signed-off-by: Laura Abbott <labb...@redhat.com> --- v9: switch to bitmap_zero --- drivers/gpio/Kconfig | 12 ++ drivers/gpio/gpiolib.c| 76 +++ drivers/gpio/gpiolib.h

Re: [PATCHv8] gpio: Remove VLA from gpiolib

2018-05-21 Thread Laura Abbott
On 05/18/2018 02:12 PM, Andy Shevchenko wrote: On Sat, May 19, 2018 at 12:05 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: On Fri, May 18, 2018 at 10:07 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: On Fri, May 18, 2018 at 8:53 PM, Laura Abbott <labb...@re

[PATCHv8] gpio: Remove VLA from gpiolib

2018-05-18 Thread Laura Abbott
lu...@wunner.de> Signed-off-by: Lukas Wunner <lu...@wunner.de> Signed-off-by: Laura Abbott <labb...@redhat.com> --- v8: Adjust lower bound --- drivers/gpio/Kconfig | 12 ++ drivers/gpio/gpiolib.c| 76 +++ drivers/gpio/gpiolib.h

Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

2018-05-18 Thread Laura Abbott
On 05/17/2018 09:01 PM, Joonsoo Kim wrote: On Thu, May 17, 2018 at 10:53:32AM -0700, Laura Abbott wrote: On 05/17/2018 10:08 AM, Michal Hocko wrote: On Thu 17-05-18 18:49:47, Michal Hocko wrote: On Thu 17-05-18 16:58:32, Ville Syrjälä wrote: On Thu, May 17, 2018 at 04:36:29PM +0300, Ville

[PATCHv7] gpio: Remove VLA from gpiolib

2018-05-17 Thread Laura Abbott
.de> Signed-off-by: Laura Abbott <labb...@redhat.com> --- v7: Tweaked the Kconfig text to clarify the wording. Also fixed a few other comments from Geert, including the earlier suggestion to reduce the zeroing since I was wrong about that. I've kept most of the existing Tested/Reviewed-b

Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

2018-05-17 Thread Laura Abbott
On 05/17/2018 10:08 AM, Michal Hocko wrote: On Thu 17-05-18 18:49:47, Michal Hocko wrote: On Thu 17-05-18 16:58:32, Ville Syrjälä wrote: On Thu, May 17, 2018 at 04:36:29PM +0300, Ville Syrjälä wrote: On Thu, May 17, 2018 at 03:21:09PM +0200, Michal Hocko wrote: On Thu 17-05-18 15:59:59,

[PATCHv6] gpio: Remove VLA from gpiolib

2018-05-16 Thread Laura Abbott
chip with gpios below some fixed amount. The slow path dynamically allocates an array to cover those chips with a large number of gpios. Reviewed-and-tested-by: Lukas Wunner <lu...@wunner.de> Signed-off-by: Lukas Wunner <lu...@wunner.de> Signed-off-by: Laura Abbott <labb...@red

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-05-14 Thread Laura Abbott
On 04/20/2018 02:02 AM, Geert Uytterhoeven wrote: Hi Laura, Thanks for your patch! On Fri, Apr 13, 2018 at 11:24 PM, Laura Abbott <labb...@redhat.com> wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla.

[PATCH] staging: android: ion: Switch to pr_warn_once in ion_buffer_destroy

2018-05-14 Thread Laura Abbott
-by: syzbot <syzkal...@googlegroups.com> Signed-off-by: Laura Abbott <labb...@redhat.com> --- drivers/staging/android/ion/ion.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index e74db7902549..

Re: [RFCv2 PATCH 0/3] Salted build ids via linker sections

2018-05-14 Thread Laura Abbott
On 05/06/2018 11:28 PM, Masahiro Yamada wrote: 2018-03-30 3:01 GMT+09:00 Laura Abbott <labb...@redhat.com>: Hi, This is v2 of my proposal to allow unique build-ids in the kernel. from last time: "" In Fedora, the debug information is packaged separately (foo-debuginfo) and

Re: [RFCv2 PATCH 0/3] Salted build ids via linker sections

2018-05-14 Thread Laura Abbott
On 05/07/2018 07:49 PM, Andy Lutomirski wrote: On Sun, May 6, 2018 at 11:59 PM Masahiro Yamada < yamada.masah...@socionext.com> wrote: 2018-03-30 21:40 GMT+09:00 Mark Wielaard <m...@fedoraproject.org>: On Thu, 2018-03-29 at 11:01 -0700, Laura Abbott wrote: I'm still mo

Re: WARNING in ion_buffer_destroy

2018-05-14 Thread Laura Abbott
On 05/09/2018 11:59 PM, Dmitry Vyukov wrote: On Wed, Jan 10, 2018 at 7:14 PM, Laura Abbott <labb...@redhat.com> wrote: On 01/09/2018 02:58 PM, syzbot wrote: Hello, syzkaller hit the following crash on 06d41862286aa7bc634a1dd9e6e7e96f925ef30a git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [RFC][PATCH 00/13] Provide saturating helpers for allocation

2018-05-09 Thread Laura Abbott
On 05/08/2018 05:42 PM, Kees Cook wrote: This is a stab at providing three new helpers for allocation size calculation: struct_size(), array_size(), and array3_size(). These are implemented on top of Rasmus's overflow checking functions, and the last 8 patches are all treewide conversions of

Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format

2018-05-07 Thread Laura Abbott
On 05/07/2018 07:40 AM, Nathan Chancellor wrote: On Mon, May 07, 2018 at 06:37:52AM -0700, Laura Abbott wrote: On 05/06/2018 06:18 PM, Nathan Chancellor wrote: checkpatch.pl complains these are invalid because the rules in Documentation/process/license-rules.rst state that C headers should

Re: [PATCH 2/2] staging: android: ion: Remove unnecessary blank line

2018-05-07 Thread Laura Abbott
tachments); mutex_init(>lock); mutex_lock(>buffer_lock); Acked-by: Laura Abbott <labb...@redhat.com>

Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format

2018-05-07 Thread Laura Abbott
On 05/06/2018 06:18 PM, Nathan Chancellor wrote: checkpatch.pl complains these are invalid because the rules in Documentation/process/license-rules.rst state that C headers should have "/* */" style comments. The SPDX markings are special, but I don't see anything from a quick read of the

Re: [PATCH 2/2] arm64: Clear the stack

2018-05-03 Thread Laura Abbott
On 05/03/2018 10:33 AM, Alexander Popov wrote: Hello Mark and Laura, Let me join the discussion. Mark, thanks for your feedback! On 03.05.2018 10:19, Mark Rutland wrote: Hi Laura, On Wed, May 02, 2018 at 01:33:26PM -0700, Laura Abbott wrote: Implementation of stackleak based heavily

Re: [PATCH 2/2] arm64: Clear the stack

2018-05-03 Thread Laura Abbott
On 05/03/2018 12:19 AM, Mark Rutland wrote: Hi Laura, On Wed, May 02, 2018 at 01:33:26PM -0700, Laura Abbott wrote: Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott <labb...@redhat.com> --- Now written in C instead of a bunch of assembly. This

Re: [PATCH 2/2] arm64: Clear the stack

2018-05-02 Thread Laura Abbott
On 05/02/2018 02:31 PM, Kees Cook wrote: On Wed, May 2, 2018 at 1:33 PM, Laura Abbott <labb...@redhat.com> wrote: Implementation of stackleak based heavily on the x86 version Awesome! Notes below for both you and Alexander, since I think we can create a common code base instead of

[PATCH 1/2] stackleak: Update for arm64

2018-05-02 Thread Laura Abbott
arm64 has another layer of indirection in the RTL. Account for this in the plugin. Signed-off-by: Laura Abbott <labb...@redhat.com> --- Fixed from previous version to be a vector expression. --- scripts/gcc-plugins/stackleak_plugin.c | 4 1 file changed, 4 insertions(+) diff

[PATCH 0/2] Stackleak for arm64

2018-05-02 Thread Laura Abbott
like Kees to start carrying in his tree for -next. Laura Abbott (2): stackleak: Update for arm64 arm64: Clear the stack arch/arm64/Kconfig | 1 + arch/arm64/include/asm/processor.h | 6 arch/arm64/kernel/Makefile | 3 ++ arch/arm64/kernel/entry.S

[PATCH 2/2] arm64: Clear the stack

2018-05-02 Thread Laura Abbott
Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott <labb...@redhat.com> --- Now written in C instead of a bunch of assembly. --- arch/arm64/Kconfig| 1 + arch/arm64/include/asm/processor.h| 6 arch/arm64/kernel/Ma

Re: Linux messages full of `random: get_random_u32 called from`

2018-05-02 Thread Laura Abbott
On 05/02/2018 09:26 AM, Theodore Y. Ts'o wrote: On Wed, May 02, 2018 at 07:09:11AM -0500, Justin Forbes wrote: Yes, Fedora libgcrypt is carrying a patch which makes it particularly painful for us, we have reached out to the libgcrypt maintainer to follow up on that end. But as I said before,

New patchwork instance for linux-mm

2018-05-02 Thread Laura Abbott
I went ahead and requested a patchwork instance on patchwork.kernel.org and it's up and running https://patchwork.kernel.org/project/linux-mm/list/ Hopefully someone else will find this useful. It's a nice way to view Acks/Tested-by for those who pay attention to such things. Thanks, Laura P.S.

Re: [PATCH] proc/kcore: Don't bounds check against address 0

2018-05-01 Thread Laura Abbott
On 05/01/2018 02:46 PM, Andrew Morton wrote: On Tue, 1 May 2018 13:11:43 -0700 Laura Abbott <labb...@redhat.com> wrote: The existing kcore code checks for bad addresses against __va(0) with the assumption that this is the lowest address on the system. This may not hold true on some s

[PATCH] proc/kcore: Don't bounds check against address 0

2018-05-01 Thread Laura Abbott
Anderson <ander...@redhat.com> Signed-off-by: Laura Abbott <labb...@redhat.com> --- I took your previous comments as a tested by, please let me know if that was wrong. This should probably just go through -mm. I don't think this is necessary for stable but I can request it later

Re: [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock

2018-04-30 Thread Laura Abbott
initrd) + if (!keep_initrd) { free_reserved_area((void *)start, (void *)end, 0, "initrd"); + memblock_free(__virt_to_phys(start), end - start); + } } static int __init keepinitrd_setup(char *__unused) Acked-by: Laura Abbott <labb...@redhat.com>

Re: [PATCH v3] init: Fix false positives in W+X checking

2018-04-30 Thread Laura Abbott
.@kernel.org> Acked-by: Will Deacon <will.dea...@arm.com> --- Acked-by: Laura Abbott <labb...@redhat.com> If you don't have a tree for this to go through, I might suggest having Kees take it. v3: -added comment to module code to establish matching connection -added acks by Kees, I

  1   2   3   4   5   6   7   8   9   10   >