write' was not declared. Should it be static?
warning: symbol 'visorchannel_get_header' was not declared. Should it be static?
warning: symbol 'visorchannel_create' was not declared. Should it be static?
warning: symbol 'visorchannel_create_with_lock' was not declared.
No need to be be, just be should be sufficient.
Signed-off-by: Laurent Navet
---
Documentation/driver-model/device.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/driver-model/device.txt
b/Documentation/driver-model/device.txt
index 1e70220..2403eb8 100644
why not directly ?
struct region_devres *dr = devres_alloc(devm_region_release,
sizeof(struct region_devres),..
2015-12-29 14:24 UTC+01:00, Bojan Prtvar :
> Few lines below dr is reinitialized by devres_alloc()
> so we don't need to init it by NULL in the beginning of
> __devm_request_region()
in i2c_s3c_irq_nextbyte() ret is assigned zero and just used to return.
Remove it and make i2c_s3c_irq_nextbyte() a void function.
Found by using coccinelle.
Signed-off-by: Laurent Navet
---
drivers/i2c/busses/i2c-s3c2410.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
ret is assigned zero and just used to return. remove it.
Found by using coccinelle.
Signed-off-by: Laurent Navet
---
drivers/i2c/busses/i2c-s3c2410.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index
derivatio -> derivation.
Signed-off-by: Laurent Navet
---
fs/ext4/crypto_key.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
index ce75bc8..1d510c1 100644
--- a/fs/ext4/crypto_key.c
+++ b/fs/ext4/crypto_key.c
@@ -30,7 +3
Return value of ext4_derive_key_aes() is stored but not used.
Add test to exit cleanly if ext4_derive_key_aes() fail.
Also fix coverity CID 1309760.
Signed-off-by: Laurent Navet
---
fs/ext4/crypto_key.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ext4/crypto_key.c b/fs/ext4
Make sense,
I send a v2, thank's
2015-07-08 22:01 UTC+02:00, Darrick J. Wong :
> On Wed, Jul 08, 2015 at 09:51:15PM +0200, Laurent Navet wrote:
>> Return value of ext4_derive_key_aes() is stored but never used before
>> being overwritten.
>> Also fix coverity CID 13
Return value of ext4_derive_key_aes() is stored but never used before
being overwritten.
Also fix coverity CID 1309760.
Signed-off-by: Laurent Navet
---
fs/ext4/crypto_key.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
index
Calling ktime_add_us() seems useless as is only useful for it's return
value which is ignored.
Also fix coverity CID 1309761.
Signed-off-by: Laurent Navet
---
drivers/media/dvb-core/dvb_frontend.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/dvb-core/dvb_frontend
ret is assigned value from of_property_read_string_index but is
overwritten before being used so remove it.
Also fix coverity CID 1309759
Signed-off-by: Laurent Navet
---
drivers/gpio/gpiolib-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b
The same code is executed regardless ret value, so this test
can be removed.
Also fix coverity scan CID 1268786.
Signed-off-by: Laurent Navet
---
drivers/iio/industrialio-buffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iio/industrialio-buffer.c
b/drivers/iio/industrialio
The same code is executed regardless ret value, so this test can be
removed.
Signed-off-by: Laurent Navet
---
drivers/staging/gdm72xx/usb_boot.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx/usb_boot.c
index 3ccc447..7f80553
The same code is executed regardless ret_code value, so these tests can
be removed.
Fix Coverity CID 1268789 and 1268791
Signed-off-by: Laurent Navet
---
drivers/net/ethernet/intel/i40e/i40e_hmc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c
@emulex.com addresses respond to use @avagotech.com.
Signed-off-by: Laurent Navet
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f8e0afb..05766f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8846,9 +8846,9 @@ S
The same code is executed regardless status value, so these tests can
be removed.
Fix Coverity CID 1271151 and 1268788
Signed-off-by: Laurent Navet
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
b
The same code is executed if ret is true or false, so this test can
be removed.
Fix Coverity CID 1268782.
Signed-off-by: Laurent Navet
---
drivers/media/tuners/fc0013.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/tuners/fc0013.c b/drivers/media/tuners/fc0013.c
index
reak the driver
> completely and make it unusable.
>
>>
>> As a side note I'm not sure if pod_try_init from
>> drivers/staging/line6/pod.c
>> cleans up properly after failed line6_init_audio.
>
> Yeah. It doesn't seem to clean up at all.
>
Laurent Navet.
-
The strcpy operation may write past the end of the fixed-size destination
buffer if the source buffer is too large.
Found by coverity scan : CID 144979
Signed-off-by: Laurent Navet
---
build tested only
drivers/staging/line6/audio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
if slic_card_locate failed, memmapped_ioaddr is not unmapped.
Signed-off-by: Laurent Navet
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 652272b..ab7206d
Mac address validity is already checked in of_get_mac_address().
No need to do it twice.
Signed-off-by: Laurent Navet
---
drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c
b/drivers/net
Mac address validity is already checked in of_get_mac_address().
No need to do it twice.
Signed-off-by: Laurent Navet
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet
use ERR_CAST() function instead of ERR_PTR() and PTR_ERR()
found using coccinelle and err_cast.cocci
Signed-off-by: Laurent Navet
---
drivers/staging/lustre/lustre/llite/llite_nfs.c|2 +-
drivers/staging/lustre/lustre/llite/rw.c |2 +-
drivers/staging/lustre/lustre
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource,
so no need to do them twice.
Signed-off-by: Laurent Navet
---
drivers/video/mxsfb.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxs
2013/5/16, Jingoo Han :
> It makes build warning as below:
>
> drivers/video/mxsfb.c:887:13: warning: 'host' is used uninitialized in this
> function [-Wuninitialized]
> drivers/video/mxsfb.c:965:21: warning: 'fb_info' may be used uninitialized
> in this function [-Wuninitialized]
>
> It breaks the
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/mmc/host/mvsdio.c |6 +++---
1 file changed, 3 insertions(+), 3
This second version fix a typo in commit message reported by Jingoo Han
Regards,
Laurent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
> Oh is that deprecated? I had no clue :-/
> Can you point to some rationale about this so I'm not
> totally misguided in my world..?
>
Yes: https://lkml.org/lkml/2013/1/21/360
>
> Grant is just going to *not* love this type of patches replacing
> nullchecks with IS_ERR() stuff all over the kernel
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-msm-v1.c | 12 ++--
1 file changed, 6 insertions(+), 6
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/dma/sh/sudmac.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions
Check of 'r' and calls to dev_err are already done in devm_ioremap_resource,
so no need to do them twice.
Signed-off-by: Laurent Navet
---
drivers/spi/spi-tegra114.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/spi/spi-tegra114.c b/drive
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource,
so no need to do them twice.
Signed-off-by: Laurent Navet
---
drivers/video/mxsfb.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/vid
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -1843,8 +1843,6 @@ fec_probe(struct platform_device *pdev)
>> pdev->id_entry = of_id->data;
>>
>> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!r
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
also remove tests on 'r' since devm_ioremap_resource() checks for it
in a better way.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Lau
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
dev_err() message is no more needed since it's already displayed in
devm_ioremap_resource().
Signed-off-by: Laurent Navet
---
drivers/net/can/grcan.c |7 +++
1 file changed, 3 insertions(+), 4 dele
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.
also remove tests on 'res' since devm_ioremap_resource() checks for it
in a better form.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Lau
May 12, 2013 at 04:10:07PM +0200, Laurent Navet wrote:
>> Replace a call to deprecated devm_request_and_ioremap by
>> devm_ioremap_resource.
>>
>> Found with coccicheck and this semantic patch:
>> scripts/coccinelle/api/devm_request_and_ioremap.cocci.
>>
>>
Please, don't take this one
I'll send a more complete one later,
Sorry,
2013/5/12, Laurent Navet :
> Replace a call to deprecated devm_request_and_ioremap by
> devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/de
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c |6 +++---
1 file changed, 3
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/pinctrl/vt8500/pinctrl-wmt.c |6 +++---
1 file changed, 3 insertions
eplace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet
---
drivers/mmc/host/mvsdio.c |6 +++---
1 file changed, 3 insertions(+), 3
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
arch/sparc/kernel/leon_pci_grpci1.c |8 +++-
1 file changed, 3
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/iio/adc/exynos_adc.c | 12 ++--
1 file changed, 6 insertions
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/mtd/devices/elm.c |6 +++---
1 file changed, 3 insertions(+), 3
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/mtd/nand/davinci_nand.c | 13 -
1 file changed, 8
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/mtd/nand/davinci_nand.c | 13 -
1 file changed, 8
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/misc/sram.c |7 ---
1 file changed, 4 insertions(+), 3
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/spi/spi-bcm2835.c |7 +++
1 file changed, 3 insertions(+), 4
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/crypto/omap-aes.c |7 +++
drivers/crypto/omap-sham.c |7
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/staging/imx-drm/imx-tve.c |8 +++-
1 file changed, 3
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_request_and_ioremap.cocci.
Signed-off-by: Laurent Navet
---
drivers/staging/dwc2/pci.c |6 +++---
1 file changed, 3 insertions(+), 3
Fix :
gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-omap.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 159f5c5..7e8f
Fix :
gpio/gpio-pxa.c:605: ERROR: space required after that ',' (ctx:VxV)
gpio/gpio-pxa.c:672: ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-pxa.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Fix :
gpio/gpio-stp-xway.c:220: ERROR: trailing whitespace
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-stp-xway.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-stp-xway.c b/drivers/gpio/gpio-stp-xway.c
index c20e051..04882a9 100644
--- a
Fix :
gpio/gpio-sch.c:206: ERROR: switch and case should be at the same indent
Also remove blank lines
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-sch.c | 74 ++-
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/drivers/gpio
Fix :
gpio/gpio-timberdale.c:171: ERROR: else should follow close brace '}'
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-timberdale.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
ind
where possible
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-tc3589x.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index c0595bb..d34d80d 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio
Fix :
gpio/gpio-tps65910.c:136: ERROR: space required before the open parenthesis '('
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-tps65910.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
ind
ter that '!' (ctx:BxW)
gpio/gpio-mvebu.c:570: ERROR: trailing whitespace
gpio/gpio-mvebu.c:577: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:635: ERROR: space prohibited after that '!' (ctx:BxW)
Signed-off-by: Laurent Navet
---
drivers/gp
Fix :
gpio/gpio-pca953x.c:150: ERROR: else should follow close brace '}'
Signed-off-by: Laurent Navet
---
drivers/gpio/gpio-pca953x.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 2405946..15db
files changed, 60 insertions(+), 66 deletions(-)
Regards,
Laurent Navet.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FA
Fix :
gpio/gpiolib-of.c:64: ERROR: code indent should use tabs where possible
Signed-off-by: Laurent Navet
---
drivers/gpio/gpiolib-of.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index a71a54a..8940793 100644
fix this warning :
sparse: symbol 'nv10_fence_context_new' was not declared. Should it be static?
Signed-off-by: Laurent Navet
---
drivers/gpu/drm/nouveau/nouveau_fence.h |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.h
b/drivers/gpu/d
- WARNING: Avoid CamelCase:
Signed-off-by: Laurent Navet
---
drivers/thermal/cpu_cooling.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 8dc44cb..be2e6b0 100644
--- a/drivers/thermal
> why not fix the code in cpufreq_get_max_state() as well, in one patch?
>
> thanks,
> rui
right, will do that and re-send.
Laurent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
- WARNING: Avoid CamelCase:
Signed-off-by: Laurent Navet
---
drivers/thermal/cpu_cooling.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 836828e..47b7d32 100644
--- a/drivers/thermal
- WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Laurent Navet
---
drivers/staging/line6/pod.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 74898c3..699b217 100644
--- a
fix these checkpatch errors :
- ERROR: spaces required around that '<' (ctx:VxW)
- ERROR: "foo * bar" should be "foo *bar"
- WARNING: please, no space before tabs
Signed-off-by: Laurent Navet
---
drivers/pcmcia/ds.c | 17 +
1 file changed, 9 in
fix this checkpatch error:
- ERROR: switch and case should be at the same indent
Signed-off-by: Laurent Navet
---
drivers/pcmcia/at91_cf.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
index 01463c7
[PATCH 1/3] drivers: pcmcia: at91_cf.c fix checkpatch error
[PATCH 2/3] drivers: pcmcia: ds.c fix checkpatch errors
[PATCH 3/3] drivers: pcmcia: electra_cf.c fix checkpatch error and
There is a lot of checkpatch issues in drivers/pcmcia directory
this fix some of them, if this kind of work is appr
fix these checkpatch errors and warning:
- ERROR: "foo * bar" should be "foo *bar"
- WARNING: please, no space before tabs
- WARNING: sizeof *cf should be sizeof(*cf)
- WARNING: space prohibited between function name and open parenthesis '('i
Signed-off-b
parenthesis '('
- WARNING: suspect code indent for conditional statements
- WARNING: quoted string split across lines
- WARNING: space prohibited between function name and open parenthesis '('
- WARNING: line over 80 characters
also add spaces around some "+", "=
Hi Jean,
>
> Unfortunately your patch also add one new checkpatch.pl warning:
>
> WARNING: line over 80 characters
> #245: FILE: drivers/i2c/busses/i2c-nforce2.c:272:
> + data->word = inb_p(NVIDIA_SMB_DATA) | (inb_p(NVIDIA_SMB_DATA +
> 1) << 8);
>
> Please fix.
>
> As mentioned previo
parenthesis '('
- WARNING: suspect code indent for conditional statements
- WARNING: quoted string split across lines
- WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Laurent Navet
---
drivers/i2c/busses/i2c-nforce2.c | 153 +
This is not really a bug as mux->busses is a multilevel pointer, so
the result of sizeof(ptr) is the same as sizeof(*ptr).
But I think this is more logical and according to CodingStyle rules like this.
This is also what is done for mux->states a few lines above.
Regards,
2013/1/8, Laurent
sizeof when applied to a pointer typed expression gives the size of
the pointer
The semantic patch that makes this output is available
in scripts/coccinelle/misc/noderef.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Laurent Navet
parenthesis '('
- WARNING: suspect code indent for conditional statements
- WARNING: quoted string split across lines
- WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Laurent Navet
---
drivers/i2c/busses/i2c-nforce2.c | 149 +
>> > Are you also able to build-test the changes?
Yes,
> Me too :) I just wanted to express that I would love to see a compile
> test before submission, even for checkpatch thingies. Can save some
> hazzle for all of us.
>
I agree,
thanks for your comments, i'll send new patch in a few days.
--
T
Hi guys,
> This is correct, however there are several other checkpatch errors and
> warnings in this file and I would appreciate if you could fix them as
> well. I'm not asking that you fix them all, but please consider fixing
> the following:
>
> WARNING: space prohibited between function name an
fix these errors reported by checkpatch.pl
- drivers/i2c/busses/i2c-nforce2.c:191
- drivers/i2c/busses/i2c-nforce2.c:193
ERROR: "foo * bar" should be "foo *bar"
- drivers/i2c/busses/i2c-nforce2.c:302:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: La
antic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Laurent Navet
---
drivers/platform/x86/thinkpad_acpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 75dd651..cb46b6a 1
ching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Laurent Navet
---
drivers/gpu/drm/nouveau/core/subdev/timer/base.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
b/drivers/gpu/drm/nouveau/core/subdev/timer/b
antic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Laurent Navet
---
drivers/gpu/drm/nouveau/core/subdev/timer/base.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
b/drivers/gpu/drm/nouveau/core/s
Ping ?
2012/11/30, Stefan Hajnoczi :
> Changes are fine.
>
> In the future, please split changes into individual patches. For example:
> Patch 1 - Rename 'rv' to 'ret'
> Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in
> pcm_set_impulse_period()
> Patch 3 - Realign comment in li
staging: line6: driver.c
The semantic patch that makes this output is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Laurent Navet
---
drivers/staging/line6/driver.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/line6/driver.c b
> 2012/11/30, Greg KH :
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list. I'll be glad to respond if you
> resend it to everyone.
Sorry, seem's i've reply instead of reply to all.
Anyway, it's maybe not the better idea i've had this day, but i
realigns comments
Signed-off-by: Laurent Navet
---
drivers/staging/line6/pcm.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 6c1e313..17969c6 100644
--- a/drivers/staging/line6
v2 of my previously sended patches, corrected following
dan carpenter and greg kh comments.
Regards,
Laurent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
From: "Laurent Navet [Mali]"
staging: line6: pcm.c
call to obsolete simple_strtoul() function is replaced
by kstrtoint() in pcm_set_impulse_period().
Also check the return code.
Signed-off-by: Laurent Navet [Mali]
---
drivers/staging/line6/pcm.c |8 ++
From: "Laurent Navet [Mali]"
delete old commentted code to avoid this checkpatch error :
line6/pcm.c:423: ERROR: switch and case should be at the same indent
Signed-off-by: Laurent Navet [Mali]
---
drivers/staging/line6/pcm.c |8
1 file changed, 8 deletions(-)
di
90 matches
Mail list logo
