On 3/24/21 3:41 PM, Joe Perches wrote:
> On Tue, 2021-03-23 at 10:27 -0700, ldun...@suse.com wrote:
>> From: Lee Duncan
>>
>> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid
>> looding when vlan is not set by the switch.i") added
>> print
On 3/24/21 3:41 PM, Joe Perches wrote:
> On Tue, 2021-03-23 at 10:27 -0700, ldun...@suse.com wrote:
>> From: Lee Duncan
>>
>> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid
>> looding when vlan is not set by the switch.i") added
>> print
On 3/5/21 2:42 PM, Pavel Machek wrote:
> Hi!
>
>> From: Lee Duncan
>>
>> commit 688e8128b7a92df982709a4137ea4588d16f24aa upstream.
>>
>> Protect the iSCSI transport handle, available in sysfs, by requiring
>> CAP_SYS_ADMIN to read it. Also protect the
On 1/26/21 11:46 PM, Greg KH wrote:
> On Tue, Jan 26, 2021 at 05:21:24PM -0800, Lee Duncan wrote:
>> From: Hannes Reinecke
>>
>> Commit 42ec15ceaea7 fixed a gcc issue with unused variables, but
>> introduced errors since it allocated an array of two u64-s but
>&
On 1/26/21 5:21 PM, Lee Duncan wrote:
> From: Hannes Reinecke
>
> Commit 42ec15ceaea7 fixed a gcc issue with unused variables, but
> introduced errors since it allocated an array of two u64-s but
> then used more than that. Set the arrays to the proper s
-off-by: Hannes Reinecke
Signed-off-by: Lee Duncan
---
drivers/scsi/fnic/vnic_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c
index 5988c300cc82..d2064b89 100644
--- a/drivers/scsi/fnic/vnic_dev.c
+++ b
On 10/8/20 1:54 PM, Mike Christie wrote:
> On 10/8/20 12:11 PM, Mike Christie wrote:
>> On 9/25/20 1:41 PM, ldun...@suse.com wrote:
>>> From: Lee Duncan
>>>
>>> iSCSI NOPs are sometimes "lost", mistakenly sent to the
>>> user-land iscsid daem
On 9/25/20 11:41 AM, ldun...@suse.com wrote:
> From: Lee Duncan
>
> iSCSI NOPs are sometimes "lost", mistakenly sent to the
> user-land iscsid daemon instead of handled in the kernel,
> as they should be, resulting in a message from the daemon like:
>
>> iscsi
l open coded checks.
>
> Signed-off-by: Coly Li
> Acked-by: Martin K. Petersen
> Cc: Vasily Averin
> Cc: Cong Wang
> Cc: Mike Christie
> Cc: Lee Duncan
> Cc: Chris Leech
> Cc: Christoph Hellwig
> Cc: Hannes Reinecke
> ---
> drivers/scsi/libiscsi_tcp
obj(struct iscsi_boot_kset *boot_kset,
> boot_kobj->kobj.kset = boot_kset->kset;
> if (kobject_init_and_add(_kobj->kobj, _boot_ktype,
>NULL, name, index)) {
> - kfree(boot_kobj);
> + kobject_put(_kobj->kobj);
> return NULL;
> }
> boot_kobj->data = data;
>
Reviewed-by: Lee Duncan
= qedi->udev;
> - uctrl = udev->uctrl;
> -
> work = kzalloc(sizeof(*work), GFP_ATOMIC);
> if (!work) {
> QEDI_WARN(>dbg_ctx,
>
Reviewed-by: Lee Duncan
--
Lee
On 3/6/19 10:23 AM, Chris Leech wrote:
> On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote:
>> From: Lee Duncan
>>
>> If there is an error queueing an iscsi command in
>> iscsi_queuecommand(), for example if the transport fails
>> to take the
From: Lee Duncan
If there is an error queueing an iscsi command in
iscsi_queuecommand(), for example if the transport fails
to take the command in sessuin->tt->xmit_task(), then
the error path can call iscsi_complete_task() without
first aquiring the back_lock as required. This ca
On 2/25/19 2:02 AM, Johannes Thumshirn wrote:
> On 22/02/2019 17:29, Lee Duncan wrote:
>> From: Lee Duncan
>>
>> If there is an error queueing an iscsi command in
>> iscsi_queuecommand(), for example if the transport fails
>> to take the command in sessuin->tt-
From: Lee Duncan
If there is an error queueing an iscsi command in
iscsi_queuecommand(), for example if the transport fails
to take the command in sessuin->tt->xmit_task(), then
the error path can call iscsi_complete_task() without
first aquiring the back_lock as required. This ca
From: Lee Duncan
If there is an error queueing an iscsi command in
iscsi_queuecommand(), for example if the transport fails
to take the command in sessuin->tt->xmit_task(), then
the error path can call iscsi_complete_task() without
first aquiring the back_lock as required. This ca
I reviewed this several days before but mistakenly replied only to the
open-iscsi list.
Signed-off-by: Lee Duncan <ldun...@suse.com>
--
Lee-Man Duncan
Sent from my iPhone, dude
> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen <martin.peter...@oracle.com>
> wrote:
I reviewed this several days before but mistakenly replied only to the
open-iscsi list.
Signed-off-by: Lee Duncan
--
Lee-Man Duncan
Sent from my iPhone, dude
> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen
> wrote:
>
>
>> iscsi tcp will first send out data, then
765 ("[SCSI] libiscsi, bnx2i: make bound ep check common")
> Cc: Lee Duncan <ldun...@suse.com>
> Cc: Hannes Reinecke <h...@suse.de>
> Cc: Bart Van Assche <bart.vanass...@sandisk.com>
> Cc: Chris Leech <cle...@redhat.com>
> ---
> drivers/scsi/libiscsi.
bnx2i: make bound ep check common")
> Cc: Lee Duncan
> Cc: Hannes Reinecke
> Cc: Bart Van Assche
> Cc: Chris Leech
> ---
> drivers/scsi/libiscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/
X_UIO_H
> #define _UAPI__LINUX_UIO_H
>
> +#include
> #include
> #include
>
>
> +#if __UAPI_DEF_IOVEC
> struct iovec
> {
> void __user *iov_base; /* BSD uses caddr_t (1003.1g requires void *) */
> __kernel_size_t iov_len; /* Must be size_t (1003.1g) */
> };
> +#endif /* __UAPI_DEF_IOVEC */
>
> /*
> * UIO_MAXIOV shall be at least 16 1003.1g (5.4.1.1)
> --
> ldv
--
Lee Duncan
SUSE Labs
INUX_UIO_H
>
> +#include
> #include
> #include
>
>
> +#if __UAPI_DEF_IOVEC
> struct iovec
> {
> void __user *iov_base; /* BSD uses caddr_t (1003.1g requires void *) */
> __kernel_size_t iov_len; /* Must be size_t (1003.1g) */
> };
> +#endif /* __UAPI_DEF_IOVEC */
>
> /*
> * UIO_MAXIOV shall be at least 16 1003.1g (5.4.1.1)
> --
> ldv
--
Lee Duncan
SUSE Labs
t iscsi_cls_session *session);
> -extern int iscsi_destroy_session(struct iscsi_cls_session *session);
> extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session
> *sess,
> int dd_size, uint32_t cid);
> extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn);
>
--
Lee Duncan
SUSE Labs
sion);
> -extern int iscsi_destroy_session(struct iscsi_cls_session *session);
> extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session
> *sess,
> int dd_size, uint32_t cid);
> extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn);
>
--
Lee Duncan
SUSE Labs
On 06/16/2017 05:41 PM, Jason A. Donenfeld wrote:
> Hi Lee,
>
> On Fri, Jun 16, 2017 at 11:58 PM, Lee Duncan <ldun...@suse.com> wrote:
>> It seems like what you are doing is basically "good", i.e. if there is
>> not enough random data, don't
On 06/16/2017 05:41 PM, Jason A. Donenfeld wrote:
> Hi Lee,
>
> On Fri, Jun 16, 2017 at 11:58 PM, Lee Duncan wrote:
>> It seems like what you are doing is basically "good", i.e. if there is
>> not enough random data, don't use it. But what happens in that case? T
ey'll have a look (patch
> reattached).
>
> Jason
>
It seems like what you are doing is basically "good", i.e. if there is
not enough random data, don't use it. But what happens in that case? The
authentication fails? How does the user know to wait and try again?
--
Lee Duncan
SUSE Labs
attached).
>
> Jason
>
It seems like what you are doing is basically "good", i.e. if there is
not enough random data, don't use it. But what happens in that case? The
authentication fails? How does the user know to wait and try again?
--
Lee Duncan
SUSE Labs
> -typedef unsigned __bitwise__ ieee80211_tx_result;
> +typedef unsigned __bitwise ieee80211_tx_result;
> #define TX_CONTINUE ((__force ieee80211_tx_result) 0u)
> #define TX_DROP ((__force ieee80211_tx_result) 1u)
> #define TX_QUEUED((__force ieee80211_tx_result) 2u)
> @@ -180,7 +180,7 @@ struct ieee80211_tx_data {
> };
>
>
> -typedef unsigned __bitwise__ ieee80211_rx_result;
> +typedef unsigned __bitwise ieee80211_rx_result;
> #define RX_CONTINUE ((__force ieee80211_rx_result) 0u)
> #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u)
> #define RX_DROP_MONITOR ((__force ieee80211_rx_result) 2u)
>
For iscsi initiator, looks good.
Akced-by: Lee Duncan <ldun...@suse.com>
--
Lee Duncan
itwise__ ieee80211_tx_result;
> +typedef unsigned __bitwise ieee80211_tx_result;
> #define TX_CONTINUE ((__force ieee80211_tx_result) 0u)
> #define TX_DROP ((__force ieee80211_tx_result) 1u)
> #define TX_QUEUED((__force ieee80211_tx_result) 2u)
> @@ -180,7 +180,7 @@ struct ieee80211_tx_data {
> };
>
>
> -typedef unsigned __bitwise__ ieee80211_rx_result;
> +typedef unsigned __bitwise ieee80211_rx_result;
> #define RX_CONTINUE ((__force ieee80211_rx_result) 0u)
> #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u)
> #define RX_DROP_MONITOR ((__force ieee80211_rx_result) 2u)
>
For iscsi initiator, looks good.
Akced-by: Lee Duncan
--
Lee Duncan
Hello Martin:
On 09/26/2016 06:26 PM, Martin K. Petersen wrote:
>>>>>> "Lee" == Lee Duncan <ldun...@suse.com> writes:
>
> Lee,
>
> Lee> Chris Leech and I are taking over as open-iscsi maintainers.
>
> Do you want me to queue the
Hello Martin:
On 09/26/2016 06:26 PM, Martin K. Petersen wrote:
>>>>>> "Lee" == Lee Duncan writes:
>
> Lee,
>
> Lee> Chris Leech and I are taking over as open-iscsi maintainers.
>
> Do you want me to queue the MAINTAINER update?
Yes, that wou
..81384a2562e7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6448,10 +6448,10 @@ S: Maintained
F: drivers/firmware/iscsi_ibft*
ISCSI
-M: Mike Christie <micha...@cs.wisc.edu>
+M: Lee Duncan <ldun...@suse.com>
+M: Chris Leech <cle...@redhat.co
..81384a2562e7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6448,10 +6448,10 @@ S: Maintained
F: drivers/firmware/iscsi_ibft*
ISCSI
-M: Mike Christie
+M: Lee Duncan
+M: Chris Leech
L: open-is...@googlegroups.com
-W: www.open-iscsi.org
-T: git
git
[Added linux-scsi to the cc list.]
I will resubmit an updated version of this patch.
On 09/23/2016 02:34 PM, Lee Duncan wrote:
> Chris Leech and I are taking over open-iscsi
> maintenance from Mike Christie.
>
> Signed-off-by: Lee Duncan <ldun...@suse.com>
> ---
> MAINT
[Added linux-scsi to the cc list.]
I will resubmit an updated version of this patch.
On 09/23/2016 02:34 PM, Lee Duncan wrote:
> Chris Leech and I are taking over open-iscsi
> maintenance from Mike Christie.
>
> Signed-off-by: Lee Duncan
> ---
> MAINTAINERS | 3 ++-
&g
Chris Leech and I are taking over open-iscsi
maintenance from Mike Christie.
Signed-off-by: Lee Duncan <ldun...@suse.com>
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01bff8ea28d8..0afaf42d5416 100644
--- a/MAINT
Chris Leech and I are taking over open-iscsi
maintenance from Mike Christie.
Signed-off-by: Lee Duncan
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01bff8ea28d8..0afaf42d5416 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Ping?
We really need to move the target database out of /var/target
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database d
Ping?
We really need to move the target database out of /var/target
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database d
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database directory" can only be changed
> after the target_core_mod loads but bef
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database directory" can only be changed
> after the target_core_mod loads but bef
B root before it
can be used by others
* Validate that new DB root is a valid directory
Lee Duncan (2):
target: make target db location configurable
target: use new "dbroot" target attribute
drivers/target/target_core_alua.c | 6 ++--
drivers/target/target_core_configfs.c | 62
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan <ldun...@suse.com>
---
drivers/target/t
B root before it
can be used by others
* Validate that new DB root is a valid directory
Lee Duncan (2):
target: make target db location configurable
target: use new "dbroot" target attribute
drivers/target/target_core_alua.c | 6 ++--
drivers/target/target_core_configfs.c | 62
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan
---
drivers/target/target_
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan <ldun...@suse.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drive
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/ta
On 04/13/2016 11:10 PM, Hannes Reinecke wrote:
> On 04/13/2016 10:25 PM, Lee Duncan wrote:
>> This commit adds the read-write attribute "dbroot",
>> in the top-level CONFIGFS (core) target directory,
>> normally /sys/kernel/config/target. This attribute
>&
On 04/13/2016 11:10 PM, Hannes Reinecke wrote:
> On 04/13/2016 10:25 PM, Lee Duncan wrote:
>> This commit adds the read-write attribute "dbroot",
>> in the top-level CONFIGFS (core) target directory,
>> normally /sys/kernel/config/target. This attribute
>&
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan <ldun...@suse.com>
---
drivers/target/t
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan
---
drivers/target/target_
target database.
The first patch creates this configurable value for
the "dbroot", and the second patch modifies users
of this directory to use this new attribute.
Changes from v1:
* Only allow changing target DB root before it
can be used by others
* Validate that new DB root i
target database.
The first patch creates this configurable value for
the "dbroot", and the second patch modifies users
of this directory to use this new attribute.
Changes from v1:
* Only allow changing target DB root before it
can be used by others
* Validate that new DB root i
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan <ldun...@suse.com>
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/target_c
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/target_core_pr.c | 2 +-
On 02/12/2016 09:54 AM, James Bottomley wrote:
> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote:
>> The scsi_transport_iscsi module already uses the ida_simple
>> routines for managing the target ID, if requested to do
>> so. This change replaces an ever-incr
On 02/12/2016 09:54 AM, James Bottomley wrote:
> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote:
>> The scsi_transport_iscsi module already uses the ida_simple
>> routines for managing the target ID, if requested to do
>> so. This change replaces an ever-incr
and can be reused when the session
is freed.
Note that no maximum is placed on this value, though
user-space currently only seems to use the lower 24-bits.
It seems better to handle this in user space, though,
than to limit the value range for the session ID here.
Signed-off-by: Lee Duncan
and can be reused when the session
is freed.
Note that no maximum is placed on this value, though
user-space currently only seems to use the lower 24-bits.
It seems better to handle this in user space, though,
than to limit the value range for the session ID here.
Signed-off-by: Lee Duncan <l
On 01/05/2016 03:53 PM, Martin K. Petersen wrote:
"Lee" == Lee Duncan writes:
Lee> Do you need me to resubmit this patch now that it's accepted?
Please resend.
Thanks!
Done, submitted against scsi tree, misc branch.
--
Lee Duncan
dr because the hosts module already has its
own instance and locking mechanisms that aren't easily
changed.
Changes from v1:
* First version used regular ida routines
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
Signed-off-by: Lee Duncan
---
drivers/scsi/ho
On 01/05/2016 03:53 PM, Martin K. Petersen wrote:
"Lee" == Lee Duncan <ldun...@suse.com> writes:
Lee> Do you need me to resubmit this patch now that it's accepted?
Please resend.
Thanks!
Done, submitted against scsi tree, misc branch.
--
Lee Duncan
dr because the hosts module already has its
own instance and locking mechanisms that aren't easily
changed.
Changes from v1:
* First version used regular ida routines
Reviewed-by: Hannes Reinecke <h...@suse.de>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
Signed-off-by: Lee Du
On 12/17/2015 11:24 AM, Lee Duncan wrote:
> On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>>>>>> "Hannes" == Hannes Reinecke writes:
>>
>>>> I'm not opposed to having the module option if others (Martin?) feel
>>>> they need it,
On 12/17/2015 11:24 AM, Lee Duncan wrote:
> On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes:
>>
>>>> I'm not opposed to having the module option if others (Martin?) feel
>>&
fan but since the most people seem to be in favor of
> this I guess I'll have to bite the bullet.
>
> I don't see much value in the module parameter since it will require
> customers to tweak their configs and reproduce. Not worth the hassle.
>
Thank you Martin. I'll look at furt
ill not a big ida fan but since the most people seem to be in favor of
> this I guess I'll have to bite the bullet.
>
> I don't see much value in the module parameter since it will require
> customers to tweak their configs and reproduce. Not worth the hassle.
>
Thank you Martin. I'll
On 12/11/2015 07:31 AM, Ewan Milne wrote:
> On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote:
>> On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>>>> "Lee" == Lee Duncan writes:
>>>
>>> Lee> Martin: I will be glad to updat
On 12/11/2015 07:31 AM, Ewan Milne wrote:
> On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote:
>> On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>>>> "Lee" == Lee Duncan <ldun...@suse.com> writes:
>>>
>>> Lee> M
On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>> "Lee" == Lee Duncan writes:
>
> Lee> Martin: I will be glad to update the patch, creating a modprobe
> Lee> parameter as suggested, if you find this acceptable.
>
> For development use a m
On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>> "Lee" == Lee Duncan <ldun...@suse.com> writes:
>
> Lee> Martin: I will be glad to update the patch, creating a modprobe
> Lee> parameter as suggested, if you find this acceptable.
>
&g
On 11/16/2015 04:10 AM, Hannes Reinecke wrote:
> On 11/13/2015 10:54 PM, Martin K. Petersen wrote:
>>>>>>> "Lee" == Lee Duncan writes:
>>
>>>> Well, I'm a bit worried about the loss of a monotonically increasing
>>>> host number fro
On 11/16/2015 04:10 AM, Hannes Reinecke wrote:
> On 11/13/2015 10:54 PM, Martin K. Petersen wrote:
>>>>>>> "Lee" == Lee Duncan <ldun...@suse.com> writes:
>>
>>>> Well, I'm a bit worried about the loss of a monotonically increasing
>>&
On 10/14/2015 08:53 PM, James Bottomley wrote:
> On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*
On 10/14/2015 08:53 PM, James Bottomley wrote:
> On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*
:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*() routines
>>>> to manage its host_no index instead of an ATOMIC i
:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*() routines
>>>> to manage its host_no index instead of an ATOMIC i
On 10/14/2015 11:53 AM, James Bottomley wrote:
> On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*
On 10/14/2015 06:55 AM, James Bottomley wrote:
> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>> Update the SCSI hosts module to use the ida_simple*() routines
>> to manage its host_no index instead of an ATOMIC integer. This
>> means that the SCSI host number wi
On 10/14/2015 11:53 AM, James Bottomley wrote:
> On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote:
>> On 10/14/2015 06:55 AM, James Bottomley wrote:
>>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>>>> Update the SCSI hosts module to use the ida_simple*
On 10/14/2015 06:55 AM, James Bottomley wrote:
> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote:
>> Update the SCSI hosts module to use the ida_simple*() routines
>> to manage its host_no index instead of an ATOMIC integer. This
>> means that the SCSI host number wi
Duplicate email, please ignore
On 10/07/2015 04:47 PM, Lee Duncan wrote:
> This patch updates the SCSI hosts module to use the idr
> index-management routines to manage its host_no index instead
> of using an ATOMIC integer. This means that host numbers
> can now be reclaimed
Update the SCSI hosts module to use the ida_simple*() routines
to manage its host_no index instead of an ATOMIC integer. This
means that the SCSI host number will now be reclaimable.
Signed-off-by: Lee Duncan
---
drivers/scsi/hosts.c | 22 ++
1 file changed, 14 insertions
Changes from v2 and v1:
- First two version used idr instead of ida
Lee Duncan (1):
SCSI: hosts: update to use ida_simple for host_no management
drivers/scsi/hosts.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
--
2.1.4
--
To unsubscribe from this list: send
Duplicate email, please ignore
On 10/07/2015 04:47 PM, Lee Duncan wrote:
> This patch updates the SCSI hosts module to use the idr
> index-management routines to manage its host_no index instead
> of using an ATOMIC integer. This means that host numbers
> can now be reclaimed
Update the SCSI hosts module to use the ida_simple*() routines
to manage its host_no index instead of an ATOMIC integer. This
means that the SCSI host number will now be reclaimable.
Signed-off-by: Lee Duncan <ldun...@suse.com>
---
drivers/scsi/hosts.c | 22 ++
1 file c
Changes from v2 and v1:
- First two version used idr instead of ida
Lee Duncan (1):
SCSI: hosts: update to use ida_simple for host_no management
drivers/scsi/hosts.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
--
2.1.4
--
To unsubscribe from this list: send
On 10/06/2015 12:19 PM, James Bottomley wrote:
> On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote:
>> Update the SCSI hosts module to use idr to manage
>> its host_no index instead of an ATOMIC integer. This
>> also allows using idr_find() to look up the SCSI
>> ho
gave up on
this approach (as suggested by Tejon -- thank you).
Changes from v1:
- no longer using helper routines
Changes from v2:
- added back missing scsi_host_get() in scsi_host_lookup()
Lee Duncan (1):
SCSI: update hosts module to use idr index management
drivers/scsi/hosts.c | 61
Update the SCSI hosts module to use idr to manage
its host_no index instead of an ATOMIC integer. This
also allows using idr_find() to look up the SCSI
host structure given the host number.
This means that the SCSI host number will now
be reclaimable.
Signed-off-by: Lee Duncan
Reviewed
idr_find(_index_idr, hostnum);
>> +spin_unlock(_index_lock);
>> +
>> return shost;
>
> How does this actually grab a reference to the host?
Good catch -- I should have noticed that.
I will resubmit the patch.
--
Lee Duncan
--
To unsubscribe from this list:
gave up on
this approach (as suggested by Tejon -- thank you).
Changes from v1:
- no longer using helper routines
Changes from v2:
- added back missing scsi_host_get() in scsi_host_lookup()
Lee Duncan (1):
SCSI: update hosts module to use idr index management
drivers/scsi/hosts.c | 61
Update the SCSI hosts module to use idr to manage
its host_no index instead of an ATOMIC integer. This
also allows using idr_find() to look up the SCSI
host structure given the host number.
This means that the SCSI host number will now
be reclaimable.
Signed-off-by: Lee Duncan <ldun...@suse.
On 10/06/2015 12:19 PM, James Bottomley wrote:
> On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote:
>> Update the SCSI hosts module to use idr to manage
>> its host_no index instead of an ATOMIC integer. This
>> also allows using idr_find() to look up the SCSI
>> ho
idr_find(_index_idr, hostnum);
>> +spin_unlock(_index_lock);
>> +
>> return shost;
>
> How does this actually grab a reference to the host?
Good catch -- I should have noticed that.
I will resubmit the patch.
--
Lee Duncan
--
To unsubscribe from this list:
gave up on
this approach (as suggested by Tejon -- thank you).
Lee Duncan (1):
SCSI: update hosts module to use idr index management
drivers/scsi/hosts.c | 60 +---
1 file changed, 29 insertions(+), 31 deletions(-)
--
2.1.4
--
To unsubscribe from
Update the SCSI hosts module to use idr to manage
its host_no index instead of an ATOMIC integer. This
also allows using idr_find() to look up the SCSI
host structure given the host number.
This means that the SCSI host number will now
be reclaimable.
Signed-off-by: Lee Duncan
---
drivers/scsi
Update the SCSI hosts module to use idr to manage
its host_no index instead of an ATOMIC integer. This
also allows using idr_find() to look up the SCSI
host structure given the host number.
This means that the SCSI host number will now
be reclaimable.
Signed-off-by: Lee Duncan <ldun...@suse.
gave up on
this approach (as suggested by Tejon -- thank you).
Lee Duncan (1):
SCSI: update hosts module to use idr index management
drivers/scsi/hosts.c | 60 +---
1 file changed, 29 insertions(+), 31 deletions(-)
--
2.1.4
--
To unsubscribe from
1 - 100 of 190 matches
Mail list logo
