[PATCH] perf svghelper: fix memory leak in svg_build_topology_map

2020-06-02 Thread Li Bin
Fix leak of memory pointed to by t.sib_thr and t.sib_core in svg_build_topology_map in the non-error path. Signed-off-by: Li Bin --- tools/perf/util/svghelper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c

[PATCH] sched: fix typo in error message

2018-04-24 Thread Li Bin
Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 64cc564..cf15c1c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -

[PATCH] sched: fix typo in error message

2018-04-24 Thread Li Bin
Signed-off-by: Li Bin --- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 64cc564..cf15c1c 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1618,7 +1618,7 @@ static struct

[PATCH v2] prctl: fix compat handling for prctl

2018-04-18 Thread Li Bin
The member auxv in prctl_mm_map structure which be shared with userspace is pointer type, but the kernel supporting COMPAT didn't handle it. This patch fix the compat handling for prctl syscall. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/sys.

[PATCH v2] prctl: fix compat handling for prctl

2018-04-18 Thread Li Bin
The member auxv in prctl_mm_map structure which be shared with userspace is pointer type, but the kernel supporting COMPAT didn't handle it. This patch fix the compat handling for prctl syscall. Signed-off-by: Li Bin --- kernel/sys.c | 42 ++ 1 file

[PATCH] prctl: fix compat handling for prctl

2018-04-17 Thread Li Bin
The member auxv in prctl_mm_map structure which be shared with userspace is pointer type, but the kernel supporting COMPAT didn't handle it. This patch fix the compat handling for prctl syscall. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/sys.

[PATCH] prctl: fix compat handling for prctl

2018-04-17 Thread Li Bin
The member auxv in prctl_mm_map structure which be shared with userspace is pointer type, but the kernel supporting COMPAT didn't handle it. This patch fix the compat handling for prctl syscall. Signed-off-by: Li Bin --- kernel/sys.c | 41 + 1 file

[PATCH v2 1/2] sched/rt.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
q0 So we can't rely on these checks of task_A to make sure the task_A is still on the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Zhou Chengming <zhouchengmi...@huawei.com> Signed-o

[PATCH v2 1/2] sched/rt.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
se checks of task_A to make sure the task_A is still on the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Zhou Chengming Signed-off-by: Li Bin Acked-by: Peter Zijlstra (Intel) Reviewed-by: Steven Ros

[PATCH v2 2/2] sched/deadline.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
n the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Li Bin <huawei.li...@huawei.com> Acked-by: Peter Zijlstra (Intel) <pet...@infradead.org> Reviewed-by: Steven Rostedt (VMware) <rost.

[PATCH v2 2/2] sched/deadline.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
n the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Li Bin Acked-by: Peter Zijlstra (Intel) Reviewed-by: Steven Rostedt (VMware) --- kernel/sched/dea

[PATCH v2 0/2] sched: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
Changes in v2: * Only change the comment and coding style as suggested by Steve Li Bin (1): sched/deadline.c: pick and check task if double_lock_balance() unlock the rq Zhou Chengming (1): sched/rt.c: pick and check task if double_lock_balance() unlock the rq kernel/sched

[PATCH v2 0/2] sched: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
Changes in v2: * Only change the comment and coding style as suggested by Steve Li Bin (1): sched/deadline.c: pick and check task if double_lock_balance() unlock the rq Zhou Chengming (1): sched/rt.c: pick and check task if double_lock_balance() unlock the rq kernel/sched

[PATCH 2/2] sched/deadline.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
n the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/sched/deadline.c | 48 +++- 1 file changed, 23

[PATCH 1/2] sched/rt.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
q0 So we can't rely on these checks of task_A to make sure the task_A is still on the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Zhou Chengming <zhouchengmi...@huawei.com> Signed-o

[PATCH 2/2] sched/deadline.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
n the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Li Bin --- kernel/sched/deadline.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-)

[PATCH 1/2] sched/rt.c: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
se checks of task_A to make sure the task_A is still on the rq1, even though we hold the rq1->lock. This patch will repick the first pushable task to be sure the task is still on the rq. Signed-off-by: Zhou Chengming Signed-off-by: Li Bin --- kernel/sch

[PATCH 0/2] sched: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
Li Bin (1): sched/deadline.c: pick and check task if double_lock_balance() unlock the rq Zhou Chengming (1): sched/rt.c: pick and check task if double_lock_balance() unlock the rq kernel/sched/deadline.c | 48 +++- kernel/sched/rt.c

[PATCH 0/2] sched: pick and check task if double_lock_balance() unlock the rq

2018-04-12 Thread Li Bin
Li Bin (1): sched/deadline.c: pick and check task if double_lock_balance() unlock the rq Zhou Chengming (1): sched/rt.c: pick and check task if double_lock_balance() unlock the rq kernel/sched/deadline.c | 48 +++- kernel/sched/rt.c

[PATCH v2] workqueue: Fix NULL pointer dereference

2017-10-27 Thread Li Bin
we shouldn't use the 'current' to check the condition. Reported-by: Xiaofei Tan <tanxiao...@huawei.com> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/workqueue_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/workqueue_internal.h b/ker

[PATCH v2] workqueue: Fix NULL pointer dereference

2017-10-27 Thread Li Bin
we shouldn't use the 'current' to check the condition. Reported-by: Xiaofei Tan Signed-off-by: Li Bin --- kernel/workqueue_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/workqueue_internal.h b/kernel/workqueue_internal.h index 8635417..29fa81f 100644

Re: [PATCH] workqueue: Fix NULL pointer dereference

2017-10-26 Thread Li Bin
Hi, Jiangshan on 2017/10/26 23:55, Lai Jiangshan wrote: > On Tue, Oct 24, 2017 at 9:18 AM, Li Bin <huawei.li...@huawei.com> wrote: > > I remember that softirq can be invoked when irq_eixt(), > and in this case the current->current_pwq is also NULL > if __queue_work() i

Re: [PATCH] workqueue: Fix NULL pointer dereference

2017-10-26 Thread Li Bin
Hi, Jiangshan on 2017/10/26 23:55, Lai Jiangshan wrote: > On Tue, Oct 24, 2017 at 9:18 AM, Li Bin wrote: > > I remember that softirq can be invoked when irq_eixt(), > and in this case the current->current_pwq is also NULL > if __queue_work() is called in the soft irq. >

[PATCH] workqueue: Fix NULL pointer dereference

2017-10-23 Thread Li Bin
the 'current' to check the condition. Reported-by: Xiaofei Tan <tanxiao...@huawei.com> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/workqueue_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/workqueue_internal.h b/kernel/workqueue_

[PATCH] workqueue: Fix NULL pointer dereference

2017-10-23 Thread Li Bin
the 'current' to check the condition. Reported-by: Xiaofei Tan Signed-off-by: Li Bin --- kernel/workqueue_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/workqueue_internal.h b/kernel/workqueue_internal.h index 8635417..d81cb9b 100644 --- a/kernel/workqueue_inte

Re: [Question] null pointer risk of kernel workqueue

2017-10-23 Thread Li Bin
WQ_WORKER)) >> return kthread_data(current); >> return NULL; >> } > > Yeah, that makes sense to me. Can you please resend the patch with > patch description and SOB? Ok, I will resend the patch soon. Thanks, Li Bin > > Thanks. >

Re: [Question] null pointer risk of kernel workqueue

2017-10-23 Thread Li Bin
WQ_WORKER)) >> return kthread_data(current); >> return NULL; >> } > > Yeah, that makes sense to me. Can you please resend the patch with > patch description and SOB? Ok, I will resend the patch soon. Thanks, Li Bin > > Thanks. >

Re: [Question] null pointer risk of kernel workqueue

2017-10-22 Thread Li Bin
r *current_wq_worker(void) { - if (current->flags & PF_WQ_WORKER) + if (!in_irq() && (current->flags & PF_WQ_WORKER)) return kthread_data(current); return NULL; } Thanks, Li Bin > Thanks. >

Re: [Question] null pointer risk of kernel workqueue

2017-10-22 Thread Li Bin
r *current_wq_worker(void) { - if (current->flags & PF_WQ_WORKER) + if (!in_irq() && (current->flags & PF_WQ_WORKER)) return kthread_data(current); return NULL; } Thanks, Li Bin > Thanks. >

[tip:perf/core] perf symbols: Fix plt entry calculation for ARM and AARCH64

2017-08-29 Thread tip-bot for Li Bin
Commit-ID: b2f7605076d6cdd68162c42c34caadafbbe4c69f Gitweb: http://git.kernel.org/tip/b2f7605076d6cdd68162c42c34caadafbbe4c69f Author: Li Bin <huawei.li...@huawei.com> AuthorDate: Mon, 5 Jun 2017 08:34:09 +0800 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate:

[tip:perf/core] perf symbols: Fix plt entry calculation for ARM and AARCH64

2017-08-29 Thread tip-bot for Li Bin
Commit-ID: b2f7605076d6cdd68162c42c34caadafbbe4c69f Gitweb: http://git.kernel.org/tip/b2f7605076d6cdd68162c42c34caadafbbe4c69f Author: Li Bin AuthorDate: Mon, 5 Jun 2017 08:34:09 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 29 Aug 2017 11:41:27 -0300 perf symbols: Fix

[tip:perf/core] perf probe: Fix kprobe blacklist checking condition

2017-08-29 Thread tip-bot for Li Bin
Commit-ID: 2c29461e273abaf149cf8220c3403e9d67dd8b61 Gitweb: http://git.kernel.org/tip/2c29461e273abaf149cf8220c3403e9d67dd8b61 Author: Li Bin <huawei.li...@huawei.com> AuthorDate: Tue, 29 Aug 2017 20:57:23 +0800 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf probe: Fix kprobe blacklist checking condition

2017-08-29 Thread tip-bot for Li Bin
Commit-ID: 2c29461e273abaf149cf8220c3403e9d67dd8b61 Gitweb: http://git.kernel.org/tip/2c29461e273abaf149cf8220c3403e9d67dd8b61 Author: Li Bin AuthorDate: Tue, 29 Aug 2017 20:57:23 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 29 Aug 2017 11:14:12 -0300 perf probe: Fix

[PATCH] perf probe: Fix kprobe blacklist checking condition

2017-08-29 Thread Li Bin
e included. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index a2670e9..bf7c928 100644 --- a/tools/perf/util/probe-event.c +++ b

[PATCH] perf probe: Fix kprobe blacklist checking condition

2017-08-29 Thread Li Bin
e included. Signed-off-by: Li Bin --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index a2670e9..bf7c928 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c

[PATCH] perf symbols: Fix plt entry calculation for ARM and AARCH64

2017-06-04 Thread Li Bin
adrpx16, 1 <__FRAME_END__+0xf8a8> 594: f944c611ldr x17, [x16,#2440] 598: 91262210add x16, x16, #0x988 59c: d61f0220br x17 NOTES: In addition to ARM and AARCH64, other architectures, such as s390/alpha/mips/parisc/poperpc/sh/sparc/xte

[PATCH] perf symbols: Fix plt entry calculation for ARM and AARCH64

2017-06-04 Thread Li Bin
6, 1 <__FRAME_END__+0xf8a8> 594: f944c611ldr x17, [x16,#2440] 598: 91262210add x16, x16, #0x988 59c: d61f0220br x17 NOTES: In addition to ARM and AARCH64, other architectures, such as s390/alpha/mips/parisc/poperpc/sh/sparc/xtensa also need to c

Re: [PATCH] reduce the time of finding symbols for module

2017-03-28 Thread Li Bin
arch64 based on aarch64 mfentry feature. When the community has a clear plan, we are happy to make adaptation and contribute our related work to the community, including the kpatch-build support :-) [1] livepatch: add support on arm64 https://lkml.org/lkml/2015/5/28/54 [2] [AArch64] support -mfentry feature for arm64 https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00756.html [3] Kernel livepatching support in GCC https://gcc.gnu.org/ml/gcc/2015-05/msg00267.html [4] arm64: ftrace with regs for livepatch support http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401352.html Thanks, Li Bin > > Jessica > > . >

Re: [PATCH] reduce the time of finding symbols for module

2017-03-28 Thread Li Bin
arch64 based on aarch64 mfentry feature. When the community has a clear plan, we are happy to make adaptation and contribute our related work to the community, including the kpatch-build support :-) [1] livepatch: add support on arm64 https://lkml.org/lkml/2015/5/28/54 [2] [AArch64] support -mfentry feature for arm64 https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00756.html [3] Kernel livepatching support in GCC https://gcc.gnu.org/ml/gcc/2015-05/msg00267.html [4] arm64: ftrace with regs for livepatch support http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/401352.html Thanks, Li Bin > > Jessica > > . >

Re: [PATCH v13 01/10] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature

2016-06-19 Thread Li Bin
right shifted. So, > + switch (offset) { > + case0 ... 30: > + val = regs->regs[offset]; > + break; > + case offsetof(struct pt_regs, sp): here should be shifted too, as case offsetof(struct pt_regs, sp) >> 3: > +

Re: [PATCH v13 01/10] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature

2016-06-19 Thread Li Bin
0 ... 30: > + val = regs->regs[offset]; > + break; > + case offsetof(struct pt_regs, sp): here should be shifted too, as case offsetof(struct pt_regs, sp) >> 3: > + val = regs->sp; > + break; >

Re: [PATCH v12 00/10] arm64: Add kernel probes (kprobes) support

2016-05-11 Thread Li Bin
ruction_pointer_set(regs, (long)jp->entry); preempt_disable(); + pause_graph_tracing(); return 1; } @@ -757,6 +758,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs) show_regs(regs); BUG();

Re: [PATCH v12 00/10] arm64: Add kernel probes (kprobes) support

2016-05-11 Thread Li Bin
(long)jp->entry); preempt_disable(); + pause_graph_tracing(); return 1; } @@ -757,6 +758,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs) show_regs(regs); BUG(); } +

Re: [PATCH v11 5/9] arm64: Kprobes with single stepping support

2016-04-19 Thread Li Bin
Hi David, on 2016/3/9 13:32, David Long wrote: > +int __kprobes arch_prepare_kprobe(struct kprobe *p) > +{ > + unsigned long probe_addr = (unsigned long)p->addr; Here should verify the addr alignment: if (probe_addr & 0x3) return -EINVAL;

Re: [PATCH v11 5/9] arm64: Kprobes with single stepping support

2016-04-19 Thread Li Bin
Hi David, on 2016/3/9 13:32, David Long wrote: > +int __kprobes arch_prepare_kprobe(struct kprobe *p) > +{ > + unsigned long probe_addr = (unsigned long)p->addr; Here should verify the addr alignment: if (probe_addr & 0x3) return -EINVAL;

[PATCH] kprobes: fix race condition in __unregister_kprobe_top

2016-04-19 Thread Li Bin
, in exception handler, because the break_handler has been set NULL, it will not setup_singlestep, and will return to the original instrucion... To fix this bug, __unregister_kprobe_top call the synchronize_sched() before clearing the handler. Signed-off-by: Li Bin <huawei.li...@huawei.

[PATCH] kprobes: fix race condition in __unregister_kprobe_top

2016-04-19 Thread Li Bin
, in exception handler, because the break_handler has been set NULL, it will not setup_singlestep, and will return to the original instrucion... To fix this bug, __unregister_kprobe_top call the synchronize_sched() before clearing the handler. Signed-off-by: Li Bin --- kernel/kprobes.c |1

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-04-08 Thread Li Bin
on 2016/4/8 13:14, Pratyush Anand wrote: > Hi Li, > > On 07/04/2016:07:34:37 PM, Li Bin wrote: >> Hi Pratyush, >> >> on 2016/4/4 13:17, Pratyush Anand wrote: >>> Hi Li, >>> >>> On 31/03/2016:08:45:05 PM, Li Bin wrote: >>>&g

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-04-08 Thread Li Bin
on 2016/4/8 13:14, Pratyush Anand wrote: > Hi Li, > > On 07/04/2016:07:34:37 PM, Li Bin wrote: >> Hi Pratyush, >> >> on 2016/4/4 13:17, Pratyush Anand wrote: >>> Hi Li, >>> >>> On 31/03/2016:08:45:05 PM, Li Bin wrote: >>>&g

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-04-07 Thread Li Bin
Hi Pratyush, on 2016/4/4 13:17, Pratyush Anand wrote: > Hi Li, > > On 31/03/2016:08:45:05 PM, Li Bin wrote: >> Hi Pratyush, >> >> on 2016/3/21 18:24, Pratyush Anand wrote: >>> On 21/03/2016:08:37:50 AM, He Kuang wrote: >>>> On arm64, watchpoin

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-04-07 Thread Li Bin
Hi Pratyush, on 2016/4/4 13:17, Pratyush Anand wrote: > Hi Li, > > On 31/03/2016:08:45:05 PM, Li Bin wrote: >> Hi Pratyush, >> >> on 2016/3/21 18:24, Pratyush Anand wrote: >>> On 21/03/2016:08:37:50 AM, He Kuang wrote: >>>> On arm64, watchpoin

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-03-31 Thread Li Bin
> > ~Pratyush > > [1] > https://github.com/pratyushanand/linux/commit/7623c8099ac22eaa00e7e0f52430f7a4bd154652 This patch did not consider that, when excetpion return, the singlestep flag should be restored, otherwise the right singlestep will not triggered. Right? Thanks, Li Bin

Re: [PATCH 2/2] arm64: Fix watchpoint recursion when single-step is wrongly triggered in irq

2016-03-31 Thread Li Bin
> > ~Pratyush > > [1] > https://github.com/pratyushanand/linux/commit/7623c8099ac22eaa00e7e0f52430f7a4bd154652 This patch did not consider that, when excetpion return, the singlestep flag should be restored, otherwise the right singlestep will not triggered. Right? Thanks, Li Bin

[PATCH] kernel/Makefile: remove the useless CFLAGS_REMOVE_cgroup-debug.o

2016-01-29 Thread Li Bin
The file cgroup-debug.c had been removed from commit fe6934354f8e (cgroups: move the cgroup debug subsys into cgroup.c to access internal state). Remain the CFLAGS_REMOVE_cgroup-debug.o = $(CC_FLAGS_FTRACE) useless in kernel/Makefile. Signed-off-by: Li Bin --- kernel/Makefile |3 +-- 1

[PATCH] kernel/Makefile: remove the useless CFLAGS_REMOVE_cgroup-debug.o

2016-01-29 Thread Li Bin
The file cgroup-debug.c had been removed from commit fe6934354f8e (cgroups: move the cgroup debug subsys into cgroup.c to access internal state). Remain the CFLAGS_REMOVE_cgroup-debug.o = $(CC_FLAGS_FTRACE) useless in kernel/Makefile. Signed-off-by: Li Bin <huawei.li...@huawei.com> ---

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
on 2015/12/6 6:52, Steven Rostedt wrote: > On Sat, 5 Dec 2015 18:12:57 +0100 (CET) > Thomas Gleixner wrote: > >> On Fri, 4 Dec 2015, Li Bin wrote: >>> --- a/arch/x86/kernel/ftrace.c >>> +++ b/arch/x86/kernel/ftrace.c >>> @@ -106,13 +106,12 @@ ftrace_mod

[PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
: Thomas Gleixner Cc: "H. Peter Anvin" Cc: x...@kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/x86/kernel/ftrace.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 311bcf

[PATCH v2 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/powerpc/kernel/ftrace.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/ftrace.c b

[PATCH v2 4/5] sh: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: linux...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/sh/kernel/ftrace.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c index 079d70e..38993e0 100644 --- a/arch/sh/kernel/ftrace.c

[PATCH v2 1/5] ia64: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/ia64/kernel/ftrace.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/ia64/kernel/ftrace.c b/arch/ia64/kernel/ftrace.c index 3b0c2aa..cee411e

[PATCH v2 0/5] ftrace: fix ftrace misleading comments for arch using it

2015-12-05 Thread Li Bin
...@vger.kernel.org Cc: Thomas Gleixner "Cc: H. Peter Anvin" Cc: x...@kernel.org Li Bin (5): ia64: ftrace: fix the comments for ftrace_modify_code metag: ftrace: fix the comments for ftrace_modify_code powerpc: ftrace: fix the comments for ftrace_modify_code sh: ftrace: fix th

[PATCH v2 2/5] metag: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: James Hogan Cc: linux-me...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/metag/kernel/ftrace.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/metag/kernel/ftrace.c b/arch/metag/kernel/ftrace.c index ed1d685..ac8c039 100644

[PATCH v2 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-...@lists.ozlabs.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> ---

Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
on 2015/12/6 6:52, Steven Rostedt wrote: > On Sat, 5 Dec 2015 18:12:57 +0100 (CET) > Thomas Gleixner <t...@linutronix.de> wrote: > >> On Fri, 4 Dec 2015, Li Bin wrote: >>> --- a/arch/x86/kernel/ftrace.c >>> +++ b/arch/x86/kernel/ftrace.c >>>

[PATCH v2 4/5] sh: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: linux...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/sh/kernel/ftrace.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c i

[PATCH v2 2/5] metag: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: James Hogan <james.ho...@imgtec.com> Cc: linux-me...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/metag/kernel/ftrace.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 1/5] ia64: ftrace: fix the comments for ftrace_modify_code

2015-12-05 Thread Li Bin
: Tony Luck <tony.l...@intel.com> Cc: Fenghua Yu <fenghua...@intel.com> Cc: linux-i...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/ia64/kernel/ftrace.c | 12 +--- 1 files changed, 5 in

[PATCH v2 0/5] ftrace: fix ftrace misleading comments for arch using it

2015-12-05 Thread Li Bin
rnel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-...@lists.ozlabs.org Cc: linux...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> "Cc: H. Peter Anvin" <h...@zytor.com> Cc: x..

[PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
: Thomas Gleixner <t...@linutronix.de> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: x...@kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/x86/kernel/ftrace.c | 12 +--- 1 files changed, 5 i

[PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-03 Thread Li Bin
: Thomas Gleixner Cc: "H. Peter Anvin" Cc: x...@kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/x86/kernel/ftrace.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 311bcf

[PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/powerpc/kernel/ftrace.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/ftrace.c b

[PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: linux...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/sh/kernel/ftrace.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c index 079d70e..b696f92 100644 --- a/arch/sh/kernel/ftrace.c

[PATCH 2/5] metag: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: James Hogan Cc: linux-me...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/metag/kernel/ftrace.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/metag/kernel/ftrace.c b/arch/metag/kernel/ftrace.c index ed1d685..e5d71b1 100644

[PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it

2015-12-03 Thread Li Bin
...@vger.kernel.org Cc: Thomas Gleixner "Cc: H. Peter Anvin" Cc: x...@kernel.org Li Bin (5): ia64: ftrace: fix the comments for ftrace_modify_code metag: ftrace: fix the comments for ftrace_modify_code powerpc: ftrace: fix the comments for ftrace_modify_code sh: ftrace: fix th

[PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/ia64/kernel/ftrace.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/ia64/kernel/ftrace.c b/arch/ia64/kernel/ftrace.c index 3b0c2aa..a48a3f4

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
I will also update the comment for the other arch that using the similar description, such as ia64/metag/powerpc/sh/x86. Thanks, Li Bin on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about module te

[PATCH v3 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing

2015-12-03 Thread Li Bin
tions", that can be executed by one thread of execution as they are being modified by another thread of execution without requiring explicit synchronization. Signed-off-by: Li Bin Reviewed-by: Steven Rostedt --- arch/arm64/kernel/ftrace.c |5 + 1 files changed, 5 insertions(+), 0 deletion

[PATCH v3 0/2] arm64: stop using kstop_machine for ftrace

2015-12-03 Thread Li Bin
v2: Based on the comments from Will and Steve, 1. Modify the commit message 2. Fix the misleading comments for ftrace_modify_code v3: Modify the comments again based on the comment from Steve. Link: https://lkml.org/lkml/2015/12/3/422 Li Bin (2): arm64: ftrace: stop using kstop_machine

[PATCH v3 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
. Suggested-by: Steven Rostedt Signed-off-by: Li Bin --- arch/arm64/kernel/ftrace.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c index 9669b33..8f7005b 100644 --- a/arch/arm64/kernel/ftrace.c +++ b/arch/arm64

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about module text disappearing case, >> because that ftrace has a module notifier that is called when >> a module is being unloaded an

[PATCH v2 0/2] arm64: stop using kstop_machine for ftrace

2015-12-03 Thread Li Bin
v2: Based on the comments from Will and Steve, 1. Modify the commit message 2. Fix the misleading comments for ftrace_modify_code Link: https://lkml.org/lkml/2015/12/3/422 Li Bin (2): arm64: ftrace: stop using kstop_machine to enable/disable tracing arm64: ftrace: fix the comments

[PATCH v2 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing

2015-12-03 Thread Li Bin
tions", that can be executed by one thread of execution as they are being modified by another thread of execution without requiring explicit synchronization. Signed-off-by: Li Bin --- arch/arm64/kernel/ftrace.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/ar

[PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
, such that it will no longer do any modifications to that module's text. The update to make functions be traced or not is done under the ftrace_lock mutex as well. Signed-off-by: Li Bin --- arch/arm64/kernel/ftrace.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kernel

[PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it

2015-12-03 Thread Li Bin
rnel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-...@lists.ozlabs.org Cc: linux...@vger.kernel.org Cc: Thomas Gleixner <t...@linutronix.de> "Cc: H. Peter Anvin" <h...@zytor.com> Cc: x..

[PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: Tony Luck <tony.l...@intel.com> Cc: Fenghua Yu <fenghua...@intel.com> Cc: linux-i...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/ia64/kernel/ftrace.c | 13 ++--- 1 files changed, 6 in

[PATCH 2/5] metag: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: James Hogan <james.ho...@imgtec.com> Cc: linux-me...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/metag/kernel/ftrace.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-03 Thread Li Bin
: Thomas Gleixner <t...@linutronix.de> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: x...@kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/x86/kernel/ftrace.c | 13 ++--- 1 files changed, 6 i

[PATCH v3 0/2] arm64: stop using kstop_machine for ftrace

2015-12-03 Thread Li Bin
v2: Based on the comments from Will and Steve, 1. Modify the commit message 2. Fix the misleading comments for ftrace_modify_code v3: Modify the comments again based on the comment from Steve. Link: https://lkml.org/lkml/2015/12/3/422 Li Bin (2): arm64: ftrace: stop using kstop_machine

[PATCH v3 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing

2015-12-03 Thread Li Bin
tions", that can be executed by one thread of execution as they are being modified by another thread of execution without requiring explicit synchronization. Signed-off-by: Li Bin <huawei.li...@huawei.com> Reviewed-by: Steven Rostedt <rost...@goodmis.org> --- arch/arm64/kernel/ftrace.c

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
I will also update the comment for the other arch that using the similar description, such as ia64/metag/powerpc/sh/x86. Thanks, Li Bin on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin <huawei.li...@huawei.com> wrote: > >> There is n

[PATCH 3/5] powerpc: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linuxppc-...@lists.ozlabs.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> ---

[PATCH 4/5] sh: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
: linux...@vger.kernel.org Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/sh/kernel/ftrace.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/sh/kernel/ftrace.c b/arch/sh/kernel/ftrace.c i

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin <huawei.li...@huawei.com> wrote: > >> There is no need to worry about module text disappearing case, >> because that ftrace has a module notifier that is called when >> a mo

[PATCH v3 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
. Suggested-by: Steven Rostedt <rost...@goodmis.org> Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/arm64/kernel/ftrace.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c index 9669b33..8f

[PATCH v2 1/2] arm64: ftrace: stop using kstop_machine to enable/disable tracing

2015-12-03 Thread Li Bin
tions", that can be executed by one thread of execution as they are being modified by another thread of execution without requiring explicit synchronization. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/arm64/kernel/ftrace.c |5 + 1 files changed, 5 insertions(+), 0 deletion

[PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
, such that it will no longer do any modifications to that module's text. The update to make functions be traced or not is done under the ftrace_lock mutex as well. Signed-off-by: Li Bin <huawei.li...@huawei.com> --- arch/arm64/kernel/ftrace.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff

[PATCH v2 0/2] arm64: stop using kstop_machine for ftrace

2015-12-03 Thread Li Bin
v2: Based on the comments from Will and Steve, 1. Modify the commit message 2. Fix the misleading comments for ftrace_modify_code Link: https://lkml.org/lkml/2015/12/3/422 Li Bin (2): arm64: ftrace: stop using kstop_machine to enable/disable tracing arm64: ftrace: fix the comments

[PATCH v2] ftrace: fix a typo in comment

2015-11-30 Thread Li Bin
s/ARCH_SUPPORT_FTARCE_OPS/ARCH_SUPPORTS_FTRACE_OPS Signed-off-by: Li Bin --- kernel/trace/ftrace.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 3f743b1..0033e05 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace

[PATCH] ftrace: fix a typo in comment

2015-11-30 Thread Li Bin
s/ARCH_SUPPORT_FTARCE_OPS/ARCH_SUPPORTS_FTARCE_OPS Signed-off-by: Li Bin --- kernel/trace/ftrace.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 3f743b1..eb4a881 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace

[PATCH v2] ftrace: fix a typo in comment

2015-11-30 Thread Li Bin
s/ARCH_SUPPORT_FTARCE_OPS/ARCH_SUPPORTS_FTRACE_OPS Signed-off-by: Li Bin <huawei.li...@huawei.com> --- kernel/trace/ftrace.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 3f743b1..0033e05 100644 --- a/kernel

  1   2   3   >