Re: [PATCH][next] net: hns3: Fix uninitialized return from function

2021-02-17 Thread lipeng (Y)
在 2021/2/10 23:26, Colin King 写道: From: Colin Ian King Currently function hns3_reset_notify_uninit_enet is returning the contents of the uninitialized variable ret. Fix this by removing ret (since it is no longer used) and replace it with a return of the literal value 0. you can not

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2019-01-02 Thread lipeng (Y)
On 2019/1/1 9:22, dann frazier wrote: On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and

Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

2018-08-26 Thread lipeng (Y)
On 2018/8/26 2:07, Andrew Lunn wrote: This patch is a  theoretical protect, and the problem does not really happen. I think you really get the point, do you think we need this patch? I think it is not needed. And if it was needed, it would indicate there is a bug somewhere else. Hi,

Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

2018-08-26 Thread lipeng (Y)
On 2018/8/26 2:07, Andrew Lunn wrote: This patch is a  theoretical protect, and the problem does not really happen. I think you really get the point, do you think we need this patch? I think it is not needed. And if it was needed, it would indicate there is a bug somewhere else. Hi,

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-08 Thread lipeng (Y)
On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-08 Thread lipeng (Y)
On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

2018-01-18 Thread lipeng (Y)
On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

2018-01-18 Thread lipeng (Y)
On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 00/11] add some new features and fix some bugs

2018-01-11 Thread lipeng (Y)
On 2018/1/12 1:07, David Miller wrote: From: Peng Li <lipeng...@huawei.com> Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF

Re: [PATCH net-next 00/11] add some new features and fix some bugs

2018-01-11 Thread lipeng (Y)
On 2018/1/12 1:07, David Miller wrote: From: Peng Li Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver. [patch 3/11] adds

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" <lipeng...@huawei.com> Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch,

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted.

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted. [patch 12/20 ]

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

[PATCH V4 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

2017-12-20 Thread Lipeng
When auto-negotiation is enabled, the MAC flow control settings is based on the flow control negotiation result. And it should be configured after a valid link has been established. This patch adds support to update flow control settings after auto-negotiation has completed. Signed-off-by: Lipeng

[PATCH V4 net-next 01/17] net: hns3: add support to query tqps number

2017-12-20 Thread Lipeng
This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Mingguang Qu <quminggu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++ drivers/net/ethernet/hi

[PATCH V4 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

2017-12-20 Thread Lipeng
When auto-negotiation is enabled, the MAC flow control settings is based on the flow control negotiation result. And it should be configured after a valid link has been established. This patch adds support to update flow control settings after auto-negotiation has completed. Signed-off-by: Lipeng

[PATCH V4 net-next 01/17] net: hns3: add support to query tqps number

2017-12-20 Thread Lipeng
This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 10 ++ .../net/ethernet

[PATCH V4 net-next 08/17] net: hns3: add ethtool related offload command

2017-12-20 Thread Lipeng
This patch adds offload command related to "ethtool -K". Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Jian Shen <shenjia...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hn

[PATCH V4 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread Lipeng
hns3: cleanup mac auto-negotiation state query net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg net: hns3: add Asym Pause support to phy default features Lipeng (14): net: hns3: add support to query tqps number net: hns3: add support to modify tqps number net: hns3: change

[PATCH V4 net-next 08/17] net: hns3: add ethtool related offload command

2017-12-20 Thread Lipeng
This patch adds offload command related to "ethtool -K". Signed-off-by: Lipeng Signed-off-by: Jian Shen --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 16 drivers/net/ethernet/hisi

[PATCH V4 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread Lipeng
hns3: cleanup mac auto-negotiation state query net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg net: hns3: add Asym Pause support to phy default features Lipeng (14): net: hns3: add support to query tqps number net: hns3: add support to modify tqps number net: hns3: change

[PATCH V4 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-20 Thread Lipeng
This patch adds the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Mingguang Qu <quminggu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 + drivers/net/ethernet/hi

[PATCH V4 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-20 Thread Lipeng
This patch adds the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 122 + drivers

[PATCH V4 net-next 05/17] net: hns3: get rss_size_max from configuration but not hardcode

2017-12-20 Thread Lipeng
Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Mingguang Qu <quminggu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclg

[PATCH V4 net-next 05/17] net: hns3: get rss_size_max from configuration but not hardcode

2017-12-20 Thread Lipeng
Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +- drivers/net/ethernet/hisilicon/hns3/hns3pf

[PATCH V4 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

2017-12-20 Thread Lipeng
TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng <lipeng...@huawei.com> --- driv

[PATCH V4 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

2017-12-20 Thread Lipeng
TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/h

[PATCH V4 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

2017-12-20 Thread Lipeng
state in hclge_get_autoneg(). Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" <lipeng...@huawei.com> Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new fea

[PATCH V4 net-next 06/17] net: hns3: add a mask initialization for mac_vlan table

2017-12-20 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Jian Shen <shenjia...@huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/

[PATCH V4 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

2017-12-20 Thread Lipeng
Burstiness of a flow is determined by the depth of a bucket, When the upper rate of shaper is large, the current depth of a bucket is not enough. The default upper rate of shaper is 100G, so increase the depth of a bucket according to UM. Signed-off-by: Lipeng <lipeng...@huawei.com> Sign

[PATCH V4 net-next 07/17] net: hns3: add vlan offload config command

2017-12-20 Thread Lipeng
This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Jian Shen <shenjia...@huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++ .../ethernet/hi

[PATCH V4 net-next 07/17] net: hns3: add vlan offload config command

2017-12-20 Thread Lipeng
This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 158

[PATCH V4 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

2017-12-20 Thread Lipeng
: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3p

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 -

[PATCH V4 net-next 06/17] net: hns3: add a mask initialization for mac_vlan table

2017-12-20 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 39 +- 2 files changed

[PATCH V4 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

2017-12-20 Thread Lipeng
Burstiness of a flow is determined by the depth of a bucket, When the upper rate of shaper is large, the current depth of a bucket is not enough. The default upper rate of shaper is 100G, so increase the depth of a bucket according to UM. Signed-off-by: Lipeng Signed-off-by: Yunsheng Lin

[PATCH V4 net-next 09/17] net: hns3: add handling vlan tag offload in bd

2017-12-20 Thread Lipeng
This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Jian Shen <shenjia...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 inse

[PATCH V4 net-next 09/17] net: hns3: add handling vlan tag offload in bd

2017-12-20 Thread Lipeng
This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[PATCH V4 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

2017-12-20 Thread Lipeng
rdware. This patch removes the mac auto-negotiation state query. Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/dr

[PATCH V4 net-next 04/17] net: hns3: free the ring_data structrue when change tqps

2017-12-20 Thread Lipeng
This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Mingguang Qu <quminggu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3

[PATCH V4 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

2017-12-20 Thread Lipeng
This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> ---

[PATCH V4 net-next 14/17] net: hns3: add Asym Pause support to phy default features

2017-12-20 Thread Lipeng
t Asym Pause can not be advertised when the phy negotiates flow control. Fixes: c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- driv

[PATCH V4 net-next 04/17] net: hns3: free the ring_data structrue when change tqps

2017-12-20 Thread Lipeng
This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 1 file changed, 4 insertions

[PATCH V4 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

2017-12-20 Thread Lipeng
This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Lipeng Signed-off-by: Fuyun Liang --- drivers/net/ethernet/hisilicon/hns3/hnae3.h

[PATCH V4 net-next 14/17] net: hns3: add Asym Pause support to phy default features

2017-12-20 Thread Lipeng
tised when the phy negotiates flow control. Fixes: c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH V4 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

2017-12-20 Thread Lipeng
-negotiation state query. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon

[PATCH V4 net-next 12/17] net: hns3: add support for set_pauseparam

2017-12-20 Thread Lipeng
This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_ma

[PATCH V4 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

2017-12-20 Thread Lipeng
This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: Lipeng <lipeng...@huawei.com> Signed-off-by: Mingguang Qu <

[PATCH V4 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

2017-12-20 Thread Lipeng
This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon

[PATCH V4 net-next 12/17] net: hns3: add support for set_pauseparam

2017-12-20 Thread Lipeng
This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Lipeng Signed-off-by: Fuyun Liang --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 83 ++ .../net/ethernet/hisilicon/hns3/hns3pf

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and al

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and al

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread lipeng (Y)
On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs

[PATCH V3 net-next 04/17] net: hns3: Free the ring_data structrue when change tqps

2017-12-20 Thread Lipeng
This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: qumingguang <quminggu...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3

[PATCH V3 net-next 04/17] net: hns3: Free the ring_data structrue when change tqps

2017-12-20 Thread Lipeng
This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 1 file changed, 4 insertions

[PATCH V3 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

2017-12-20 Thread Lipeng
This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> ---

[PATCH V3 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

2017-12-20 Thread Lipeng
This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h

[PATCH V3 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

2017-12-20 Thread Lipeng
rdware. This patch removes the mac auto-negotiation state query. Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/dr

[PATCH V3 net-next 14/17] net: hns3: add Asym Pause support to phy default features

2017-12-20 Thread Lipeng
t Asym Pause can not be advertised when the phy negotiates flow control. Fixes: c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- driv

[PATCH V3 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

2017-12-20 Thread Lipeng
-negotiation state query. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon

[PATCH V3 net-next 14/17] net: hns3: add Asym Pause support to phy default features

2017-12-20 Thread Lipeng
tised when the phy negotiates flow control. Fixes: c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH V3 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

2017-12-20 Thread Lipeng
Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 36 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c| 4 +++ 3 files

[PATCH V3 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

2017-12-20 Thread Lipeng
Liang Signed-off-by: Lipeng --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 36 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c| 4 +++ 3 files changed, 41 insertions(+) diff --git a/drivers/net

[PATCH V3 net-next 09/17] net: hns3: Add handling vlan tag offload in bd

2017-12-20 Thread Lipeng
This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Shenjian <shenjia...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 inse

[PATCH V3 net-next 09/17] net: hns3: Add handling vlan tag offload in bd

2017-12-20 Thread Lipeng
This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Shenjian Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[PATCH V3 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

2017-12-20 Thread Lipeng
TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng <lipeng...@huawei.com> --- driv

[PATCH V3 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

2017-12-20 Thread Lipeng
TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/h

[PATCH V3 net-next 08/17] net: hns3: Add ethtool related offload command

2017-12-20 Thread Lipeng
This patch adds offload command related to "ethtool -K". Signed-off-by: Shenjian <shenjia...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hn

[PATCH V3 net-next 08/17] net: hns3: Add ethtool related offload command

2017-12-20 Thread Lipeng
This patch adds offload command related to "ethtool -K". Signed-off-by: Shenjian Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 16 drivers/net/ethernet/hisilicon/h

[PATCH V3 net-next 05/17] net: hns3: Get rss_size_max from configuration but not hardcode

2017-12-20 Thread Lipeng
From: qumingguang <quminggu...@huawei.com> Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: qumingguang <quminggu...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ dr

[PATCH V3 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

2017-12-20 Thread Lipeng
com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c i

[PATCH V3 net-next 05/17] net: hns3: Get rss_size_max from configuration but not hardcode

2017-12-20 Thread Lipeng
From: qumingguang Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +- drivers/net/ethernet

[PATCH V3 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

2017-12-20 Thread Lipeng
Burstiness of a flow is determined by the depth of a bucket, When the upper rate of shaper is large, the current depth of a bucket is not enough. The default upper rate of shaper is 100G, so increase the depth of a bucket according to UM. Signed-off-by: Yunsheng Lin Signed-off-by: Lipeng

[PATCH V3 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-20 Thread Lipeng
This patch adds the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: qumingguang <quminggu...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 + drivers/net/ethernet/hi

[PATCH V3 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-20 Thread Lipeng
This patch adds the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 122 + drivers

[PATCH V3 net-next 12/17] net: hns3: add support for set_pauseparam

2017-12-20 Thread Lipeng
This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_ma

[PATCH V3 net-next 12/17] net: hns3: add support for set_pauseparam

2017-12-20 Thread Lipeng
This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 83 ++ .../net/ethernet/hisilicon/hns3/hns3pf

[PATCH V3 net-next 01/17] net: hns3: add support to query tqps number

2017-12-20 Thread Lipeng
This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: qumingguang <quminggu...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++ drivers/net/ethernet/hi

[PATCH V3 net-next 01/17] net: hns3: add support to query tqps number

2017-12-20 Thread Lipeng
This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 10 ++ .../net/ethernet

[PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread Lipeng
to-negotiation state in hclge_get_autoneg net: hns3: add Asym Pause support to phy default features Lipeng (13): net: hns3: add support to query tqps number net: hns3: add support to modify tqps number net: hns3: change the returned tqp number by ethtool -x net: hns3: Free the ring_data s

[PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

2017-12-20 Thread Lipeng
to-negotiation state in hclge_get_autoneg net: hns3: add Asym Pause support to phy default features Lipeng (13): net: hns3: add support to query tqps number net: hns3: add support to modify tqps number net: hns3: change the returned tqp number by ethtool -x net: hns3: Free the ring_data s

[PATCH V3 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

2017-12-20 Thread Lipeng
This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: qumingguang <quminggu...@huawei.com> Signed-off-by: Lipeng &

[PATCH V3 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

2017-12-20 Thread Lipeng
This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon

[PATCH V3 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

2017-12-20 Thread Lipeng
state in hclge_get_autoneg(). Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Fuyun Liang <liangfuy...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++

[PATCH V3 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table

2017-12-20 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Shenjian <shenjia...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/

[PATCH V3 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

2017-12-20 Thread Lipeng
: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3p

[PATCH V3 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table

2017-12-20 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Shenjian Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 39 +- 2 files changed

[PATCH V3 net-next 07/17] net: hns3: Add vlan offload config command

2017-12-20 Thread Lipeng
This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Shenjian <shenjia...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++ .../ethernet/hi

[PATCH V3 net-next 07/17] net: hns3: Add vlan offload config command

2017-12-20 Thread Lipeng
This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Shenjian Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 158

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:18, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Tue, 19 Dec 2017 12:02:24 +0800 @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv) return ret; } +static void hns3_put_ring_config(struct hns3_nic_priv

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:18, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:24 +0800 @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv) return ret; } +static void hns3_put_ring_config(struct hns3_nic_priv *priv) +{ + struct

Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:16, David Miller wrote: From: Lipeng <lipeng...@huawei.com> Date: Tue, 19 Dec 2017 12:02:23 +0800 @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) ae_dev->priv = NULL; } +static u32 hclge_get_max_channels(struct hna

Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

2017-12-19 Thread lipeng (Y)
On 2017/12/20 3:16, David Miller wrote: From: Lipeng Date: Tue, 19 Dec 2017 12:02:23 +0800 @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev) ae_dev->priv = NULL; } +static u32 hclge_get_max_channels(struct hnae3_handle *han

[PATCH V2 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table

2017-12-18 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Shenjian <shenjia...@huawei.com> Signed-off-by: Lipeng <lipeng...@huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/

[PATCH V2 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table

2017-12-18 Thread Lipeng
This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Shenjian Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 39 +- 2 files changed

  1   2   3   4   >