Re: [PATCH 11/19] fuse, dax: Implement dax read/write operations

igned-off-by: Vivek Goyal > Signed-off-by: Miklos Szeredi > Signed-off-by: Liu Bo > Signed-off-by: Peng Tao > --- > fs/fuse/file.c| 603 +- > fs/fuse/fuse_i.h | 23 ++ > fs/fuse/inode.c | 6 + > inclu

Re: [PATCH] blk-throttle: fix zero wait time for iops throttled group

On Mon, Jul 08, 2019 at 06:29:57PM +0300, Konstantin Khlebnikov wrote: > After commit 991f61fe7e1d ("Blk-throttle: reduce tail io latency when iops > limit is enforced") wait time could be zero even if group is throttled and > cannot issue requests right now. As a result throtl_select_dispatch()

Re: [PATCH AUTOSEL 4.4 23/56] fuse: honor RLIMIT_FSIZE in fuse_file_fallocate

On Sat, Jun 01, 2019 at 09:25:27AM -0400, Sasha Levin wrote: > From: Liu Bo > > [ Upstream commit 0cbade024ba501313da3b7e5dd2a188a6bc491b5 ] > > fstests generic/228 reported this failure that fuse fallocate does not > honor what 'ulimit -f' has set. > > This adds the ne

Re: [PATCH] virtio-fs: fix multiple tag support

On Tue, Mar 19, 2019 at 04:26:54PM -0400, Vivek Goyal wrote: > On Sun, Mar 17, 2019 at 08:35:21AM +0800, Liu Bo wrote: > > While doing memremap from pci_dev's system bus address to kernel virtual > > address, we assign a wrong value to the %end of pgmap.res, which ends up > >

[PATCH] virtio-fs: fix multiple tag support

-off-by: Liu Bo --- fs/fuse/virtio_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 88b00055589b..7abf2187d85f 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -713,7 +713,7 @@ static int virtio_fs_setup_dax(struct

Re: [PATCH 18/52] virtio-fs: Map cache using the values from the capabilities

On Mon, Dec 10, 2018 at 9:57 AM Vivek Goyal wrote: > > Instead of assuming we had the fixed bar for the cache, use the > value from the capabilities. > > Signed-off-by: Dr. David Alan Gilbert > --- > fs/fuse/virtio_fs.c | 32 +--- > 1 file changed, 17 insertions(+),

Re: [PATCH v3] block: fix blk-iolatency accounting underflow

On Mon, Dec 17, 2018 at 1:28 PM Dennis Zhou wrote: > > On Mon, Dec 17, 2018 at 11:42:28AM -0800, Liu Bo wrote: > > On Mon, Dec 17, 2018 at 8:04 AM Dennis Zhou wrote: > > > > > > The blk-iolatency controller measures the time from rq_qos_throttle() to > >

Re: [PATCH v3] block: fix blk-iolatency accounting underflow

On Mon, Dec 17, 2018 at 8:04 AM Dennis Zhou wrote: > > The blk-iolatency controller measures the time from rq_qos_throttle() to > rq_qos_done_bio() and attributes this time to the first bio that needs > to create the request. This means if a bio is plug-mergeable or > bio-mergeable, it gets to

Re: [PATCH v3] mm, memcg: fix reclaim deadlock with writeback

On Thu, Dec 13, 2018 at 10:22:21AM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_i

Re: [PATCH v2] mm, memcg: fix reclaim deadlock with writeback

On Wed, Dec 12, 2018 at 04:50:55PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_i

Re: [PATCH 1/6] Generic radix trees

On Sat, May 26, 2018 at 1:56 PM, Kent Overstreet wrote: > On Sat, May 26, 2018 at 11:16:42AM +0800, Liu Bo wrote: >> > +/* >> > + * Returns pointer to the specified byte @offset within @radix, >> > allocating it if >> > + * necessary - newl

Re: [PATCH 1/6] Generic radix trees

On Sat, May 26, 2018 at 1:56 PM, Kent Overstreet wrote: > On Sat, May 26, 2018 at 11:16:42AM +0800, Liu Bo wrote: >> > +/* >> > + * Returns pointer to the specified byte @offset within @radix, >> > allocating it if >> > + * necessary - newl

Re: [PATCH 1/6] Generic radix trees

Hi Kent, (Add all ML to cc this time.) On Wed, May 23, 2018 at 9:18 AM, Kent Overstreet wrote: > Very simple radix tree implementation that supports storing arbitrary > size entries, up to PAGE_SIZE - upcoming patches will convert existing > flex_array users to

Re: [PATCH 1/6] Generic radix trees

Hi Kent, (Add all ML to cc this time.) On Wed, May 23, 2018 at 9:18 AM, Kent Overstreet wrote: > Very simple radix tree implementation that supports storing arbitrary > size entries, up to PAGE_SIZE - upcoming patches will convert existing > flex_array users to genradixes. The new genradix code

Re: [PATCH v5 00/19] fs: rework and optimize i_version handling in filesystems

On Tue, Jan 09, 2018 at 09:10:40AM -0500, Jeff Layton wrote: > From: Jeff Layton > > v5: > - don't corrupt refcounts stashed in i_version of ext4 xattr inodes > - add raw variants of inc and cmp functions, and have nfs use them > > v4: > - fix SB_LAZYTIME handling in

Re: [PATCH v5 00/19] fs: rework and optimize i_version handling in filesystems

On Tue, Jan 09, 2018 at 09:10:40AM -0500, Jeff Layton wrote: > From: Jeff Layton > > v5: > - don't corrupt refcounts stashed in i_version of ext4 xattr inodes > - add raw variants of inc and cmp functions, and have nfs use them > > v4: > - fix SB_LAZYTIME handling in generic_update_time > - add

Re: [PATCH v5 18/19] btrfs: only dirty the inode in btrfs_update_time if something was changed

in-memory inode in update_time_for_write(), - step 2 is to update the time/iversion of on-disk inode in btrfs_update_inode()->fill_inode_item(). I think update_time_for_write() also needs to be updated to use the new iversion API. With that, Reviewed-by: Liu Bo <bo.li@oracle.com> Thanks, -liubo > /* > -- > 2.14.3 >

Re: [PATCH v5 18/19] btrfs: only dirty the inode in btrfs_update_time if something was changed

time/iversion of on-disk inode in btrfs_update_inode()->fill_inode_item(). I think update_time_for_write() also needs to be updated to use the new iversion API. With that, Reviewed-by: Liu Bo Thanks, -liubo > /* > -- > 2.14.3 >

Re: [PATCH v2 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup

isn't desirable, > please feel free to drop the section. > > v2: Fixed missing @bh in submit_bh_blkcg_css() call. > Looks good. Reviewed-by: Liu Bo <bo.li@oracle.com> -liubo > Signed-off-by: Tejun Heo <t...@kernel.org> > Cc: Chris Mason <c...@fb.com> >

Re: [PATCH v2 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup

isn't desirable, > please feel free to drop the section. > > v2: Fixed missing @bh in submit_bh_blkcg_css() call. > Looks good. Reviewed-by: Liu Bo -liubo > Signed-off-by: Tejun Heo > Cc: Chris Mason > Cc: Josef Bacik > --- > fs/btrfs/check-integrity.c | 2 +- &

Re: [PATCH v2] btrfs: Correct assignment of pos

@@ static ssize_t btrfs_file_write_iter(struct kiocb > *iocb, > inode_unlock(inode); > return -EAGAIN; > } > - } else > - inode_lock(inode); > - > - err = generic_write_checks(iocb, from); > - if (err <= 0) { > - inode_unlock(inode); > - return err; > } > > current->backing_dev_info = inode_to_bdi(inode); Reviewed-by: Liu Bo <bo.li@oracle.com> -liubo

Re: [PATCH v2] btrfs: Correct assignment of pos

struct kiocb > *iocb, > inode_unlock(inode); > return -EAGAIN; > } > - } else > - inode_lock(inode); > - > - err = generic_write_checks(iocb, from); > - if (err <= 0) { > - inode_unlock(inode); > - return err; > } > > current->backing_dev_info = inode_to_bdi(inode); Reviewed-by: Liu Bo -liubo

Re: [PATCH v2 14/51] btrfs: avoid to access bvec table directly for a cloned bio

to retrieve the 1st bvec. > Looks good to me. Reviewed-by: Liu Bo <bo.li@oracle.com> -liubo > Cc: Chris Mason <c...@fb.com> > Cc: Josef Bacik <jba...@fb.com> > Cc: David Sterba <dste...@suse.com> > Cc: linux-bt...@vger.kernel.org > Cc: Liu Bo

Re: [PATCH v2 14/51] btrfs: avoid to access bvec table directly for a cloned bio

to retrieve the 1st bvec. > Looks good to me. Reviewed-by: Liu Bo -liubo > Cc: Chris Mason > Cc: Josef Bacik > Cc: David Sterba > Cc: linux-bt...@vger.kernel.org > Cc: Liu Bo > Signed-off-by: Ming Lei > --- > fs/btrfs/inode.c | 4 +++- > 1 file changed, 3 in

Re: [PATCH] Btrfs: work around maybe-uninitialized warning

On Thu, May 18, 2017 at 03:33:29PM +0200, Arnd Bergmann wrote: > A rewrite of btrfs_submit_direct_hook appears to have introduced a warning: > > fs/btrfs/inode.c: In function 'btrfs_submit_direct_hook': > fs/btrfs/inode.c:8467:14: error: 'bio' may be used uninitialized in this > function

Re: [PATCH] Btrfs: work around maybe-uninitialized warning

On Thu, May 18, 2017 at 03:33:29PM +0200, Arnd Bergmann wrote: > A rewrite of btrfs_submit_direct_hook appears to have introduced a warning: > > fs/btrfs/inode.c: In function 'btrfs_submit_direct_hook': > fs/btrfs/inode.c:8467:14: error: 'bio' may be used uninitialized in this > function

Re: [PATCH v4 05/27] btrfs: btrfs_wait_tree_block_writeback can be void return

On Tue, May 09, 2017 at 11:49:08AM -0400, Jeff Layton wrote: > Nothing checks its return value. Reviewed-by: Liu Bo <bo.li@oracle.com> -liubo > > Signed-off-by: Jeff Layton <jlay...@redhat.com> > --- > fs/btrfs/disk-io.c | 6 +++--- > fs/btrfs/disk-io.

Re: [PATCH v4 05/27] btrfs: btrfs_wait_tree_block_writeback can be void return

On Tue, May 09, 2017 at 11:49:08AM -0400, Jeff Layton wrote: > Nothing checks its return value. Reviewed-by: Liu Bo -liubo > > Signed-off-by: Jeff Layton > --- > fs/btrfs/disk-io.c | 6 +++--- > fs/btrfs/disk-io.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletio

Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error

On Tue, May 09, 2017 at 06:14:01PM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The setting of return code ret should be based on the error code > passed into function end_extent_writepage and not on ret. Thanks > to Liu Bo for

Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error

On Tue, May 09, 2017 at 06:14:01PM +0100, Colin King wrote: > From: Colin Ian King > > The setting of return code ret should be based on the error code > passed into function end_extent_writepage and not on ret. Thanks > to Liu Bo for spotting this mistake in the original

Re: [PATCH] btrfs: scrub: use do_div() for 64-by-32 division

On Sat, Apr 08, 2017 at 11:07:37PM +0200, Adam Borowski wrote: > Unbreaks ARM and possibly other 32-bit architectures. > Thanks a lot for the fix. Reviewed-by: Liu Bo <bo.li@oracle.com> Thanks, -liubo > Fixes: 7d0ef8b4d: Btrfs: update scrub_parity to use u64 stripe

Re: [PATCH] btrfs: scrub: use do_div() for 64-by-32 division

On Sat, Apr 08, 2017 at 11:07:37PM +0200, Adam Borowski wrote: > Unbreaks ARM and possibly other 32-bit architectures. > Thanks a lot for the fix. Reviewed-by: Liu Bo Thanks, -liubo > Fixes: 7d0ef8b4d: Btrfs: update scrub_parity to use u64 stripe_len > Reported-by: Icenowy Zhe

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

GE_SIZE, so we could only submit_extent_page once for each page, and bio_ret is used to batch bio submit. (But it could be changed after subpagesize block patchset, and there is more work rather than just adding a end_page_writeback, e.g. writepage endio also needs to be updated). Thanks, -liubo

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

GE_SIZE, so we could only submit_extent_page once for each page, and bio_ret is used to batch bio submit. (But it could be changed after subpagesize block patchset, and there is more work rather than just adding a end_page_writeback, e.g. writepage endio also needs to be updated). Thanks, -liubo

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

.) I think its caller, "__extent_writepage", has covered the above case by setting page writeback again. Thanks, -liubo > > Sincerely, > > On 2016/12/22 15:20, Liu Bo wrote: > > On Fri, Dec 16, 2016 at 03:41:50PM +0900, Takafumi Kubota wrote: &g

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

.) I think its caller, "__extent_writepage", has covered the above case by setting page writeback again. Thanks, -liubo > > Sincerely, > > On 2016/12/22 15:20, Liu Bo wrote: > > On Fri, Dec 16, 2016 at 03:41:50PM +0900, Takafumi Kubota wrote: &g

Re: master - btrfs lockdep splat

On Thu, Jan 12, 2017 at 07:12:12PM +0100, Mike Galbraith wrote: > Greetings, > > I wanted to do some -rt testing, but seems non-rt kernels aren't > lockdep clean with btrfs /, making -rt testing a bit premature. > > (hm, 28a235931 Btrfs: fix lockdep warning on deadlock against an inode's log >

Re: master - btrfs lockdep splat

On Thu, Jan 12, 2017 at 07:12:12PM +0100, Mike Galbraith wrote: > Greetings, > > I wanted to do some -rt testing, but seems non-rt kernels aren't > lockdep clean with btrfs /, making -rt testing a bit premature. > > (hm, 28a235931 Btrfs: fix lockdep warning on deadlock against an inode's log >

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

On Fri, Dec 16, 2016 at 03:41:50PM +0900, Takafumi Kubota wrote: > This is actually inspired by Filipe's patch(55e3bd2e0c2e1). > > When submit_extent_page() in __extent_writepage_io() fails, > Btrfs misses clearing a writeback bit of the failed page. > This causes the false under-writeback page.

Re: [PATCH] Btrfs: add another missing end_page_writeback on submit_extent_page failure

On Fri, Dec 16, 2016 at 03:41:50PM +0900, Takafumi Kubota wrote: > This is actually inspired by Filipe's patch(55e3bd2e0c2e1). > > When submit_extent_page() in __extent_writepage_io() fails, > Btrfs misses clearing a writeback bit of the failed page. > This causes the false under-writeback page.

Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)

On Sat, Nov 26, 2016 at 08:46:38AM -0500, Chris Mason wrote: > On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: > > FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ > > Filipe reworked the code to avoid taking the same lock twice. As far as I > can tell, this just

Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)

On Sat, Nov 26, 2016 at 08:46:38AM -0500, Chris Mason wrote: > On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: > > FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ > > Filipe reworked the code to avoid taking the same lock twice. As far as I > can tell, this just

Re: deleting a btrfs subvolume shut up a server

On Thu, May 14, 2015 at 02:16:58PM +0200, Toralf Förster wrote: > I created at a 3 TB btrfs formatted disk a btrfs subvolume, unpacked a > minimal Gentoo Linux in it, created in addition few files within it under > ./tmp and bind mount from the host few files onto those files. If I now > delete

Re: deleting a btrfs subvolume shut up a server

On Thu, May 14, 2015 at 02:16:58PM +0200, Toralf Förster wrote: I created at a 3 TB btrfs formatted disk a btrfs subvolume, unpacked a minimal Gentoo Linux in it, created in addition few files within it under ./tmp and bind mount from the host few files onto those files. If I now delete in

Re: [PATCH v2 2/3] btrfs: fix race on ENOMEM in alloc_extent_buffer

LL in the case that we don't use exists to > avoid accidentally returning a freed extent_buffer in an error case. Reviewed-by: Liu Bo > > Signed-off-by: Omar Sandoval > --- > fs/btrfs/extent_io.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a

Re: [PATCH v2 2/3] btrfs: fix race on ENOMEM in alloc_extent_buffer

extent_buffer in an error case. Reviewed-by: Liu Bo bo.li@oracle.com Signed-off-by: Omar Sandoval osan...@osandov.com --- fs/btrfs/extent_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index c7233ff..7ecfae0 100644

Re: [PATCH 3/3] btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache

On Tue, Feb 17, 2015 at 02:51:09AM -0800, Omar Sandoval wrote: > If io_ctl_prepare_pages fails, the pages in io_ctl.pages are not valid. > When we try to access them later, things will blow up in various ways. > Looks good. Reviewed-by: Liu Bo > Signed-off-by: Omar Sandoval >

Re: [PATCH 3/3] btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache

On Tue, Feb 17, 2015 at 02:51:09AM -0800, Omar Sandoval wrote: If io_ctl_prepare_pages fails, the pages in io_ctl.pages are not valid. When we try to access them later, things will blow up in various ways. Looks good. Reviewed-by: Liu Bo bo.li@oracle.com Signed-off-by: Omar Sandoval

Re: btrfs: WARN_ON(data_sinfo->bytes_may_use < bytes);

Hi Dave, On Wed, Oct 22, 2014 at 09:22:36PM -0400, Dave Jones wrote: > On Wed, Oct 22, 2014 at 09:07:31PM -0400, Dave Jones wrote: > > Just hit this while running trinity. > > > > WARNING: CPU: 3 PID: 9612 at fs/btrfs/extent-tree.c:3799 > btrfs_free_reserved_data_space+0x1d1/0x280 [btrfs]()

Re: btrfs: WARN_ON(data_sinfo-bytes_may_use bytes);

Hi Dave, On Wed, Oct 22, 2014 at 09:22:36PM -0400, Dave Jones wrote: On Wed, Oct 22, 2014 at 09:07:31PM -0400, Dave Jones wrote: Just hit this while running trinity. WARNING: CPU: 3 PID: 9612 at fs/btrfs/extent-tree.c:3799 btrfs_free_reserved_data_space+0x1d1/0x280 [btrfs]()

Re: btrfs hanging since 3.16-rc3 or so

Hi, On Tue, Jul 15, 2014 at 10:47:01PM +0100, Hugo Mills wrote: > cc linux-btrfs list > > On Tue, Jul 15, 2014 at 10:40:46PM +0900, Norbert Preining wrote: > > Dear all > > > > (please keep Cc) > > > > Since 3.16-rc3 or so I regularly get btrfs hanging in some transations. > > > > Usually

Re: btrfs hanging since 3.16-rc3 or so

Hi, On Tue, Jul 15, 2014 at 10:47:01PM +0100, Hugo Mills wrote: cc linux-btrfs list On Tue, Jul 15, 2014 at 10:40:46PM +0900, Norbert Preining wrote: Dear all (please keep Cc) Since 3.16-rc3 or so I regularly get btrfs hanging in some transations. Usually during apt-get

e1000 crash on 3.15.0-rc4

Hi, I'm using qemu to load kernel of 3.15.0-rc4, and with CONFIG_E1000=y, everying is ok, but with CONFIG_E1000=m, I got the following crash: [...] [6.020409] tsc: Refined TSC clocksource calibration: 2491.912 MHz [6.074925] floppy: Unknown symbol mutex_lock (err 0) [6.128579]

e1000 crash on 3.15.0-rc4

Hi, I'm using qemu to load kernel of 3.15.0-rc4, and with CONFIG_E1000=y, everying is ok, but with CONFIG_E1000=m, I got the following crash: [...] [6.020409] tsc: Refined TSC clocksource calibration: 2491.912 MHz [6.074925] floppy: Unknown symbol mutex_lock (err 0) [6.128579]

Re: [PATCH] btrfs: raid56: avoid double allocation

On Thu, Jul 25, 2013 at 02:09:40AM +0200, Andi Shyti wrote: > alloc_rbio frees already bbio and raid_map, therefore they don't > need to be freed in case it fails > Looks good to me. Reviewed-by: Liu Bo > Signed-off-by: Andi Shyti > --- > fs/btrfs/raid56.c | 6 ++ &g

Re: [PATCH] btrfs: raid56: avoid double allocation

On Thu, Jul 25, 2013 at 02:09:40AM +0200, Andi Shyti wrote: alloc_rbio frees already bbio and raid_map, therefore they don't need to be freed in case it fails Looks good to me. Reviewed-by: Liu Bo bo.li@oracle.com Signed-off-by: Andi Shyti a...@etezian.org --- fs/btrfs/raid56.c | 6

Re: [GIT PULL] Btrfs

remove extent mapping if we fail to add chunk (+12/-2) > Btrfs: relax the block group size limit for bitmaps (+9/-3) > Btrfs: cleanup orphan reservation if truncate fails (+2/-0) > Btrfs: make sure NODATACOW also gets NODATASUM set (+2/-1) > Btrfs: don't re-enter when allo

Re: [GIT PULL] Btrfs

orphan reservation if truncate fails (+2/-0) Btrfs: make sure NODATACOW also gets NODATASUM set (+2/-1) Btrfs: don't re-enter when allocating a chunk (+9/-0) Btrfs: remove unused extent io tree ops V2 (+11/-27) Btrfs: fix chunk allocation error handling (+22/-10) Liu Bo (14

Re: [GIT PULL] Btrfs fixes

I was > really hoping to get into this pull. It isn't nailed down yet, but we > were finally able to get a solid way to reproduce. The only good > news is it isn't a recent regression. > > The most important batch of fixes in here come from Ilya. They address > a regres

Re: [GIT PULL] Btrfs fixes

into this pull. It isn't nailed down yet, but we were finally able to get a solid way to reproduce. The only good news is it isn't a recent regression. The most important batch of fixes in here come from Ilya. They address a regression Liu Bo found in the balance ioctls for pausing

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Wed, Jan 16, 2013 at 01:34:38PM +0800, Miao Xie wrote: > On wed, 16 Jan 2013 11:03:13 +0800, Liu Bo wrote: > > This adds a leak decoder callback so that slab destruction > > can use to generate debugging output for the allocated objects. > > > > Callers like btr

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Wed, Jan 16, 2013 at 03:20:57PM +, Christoph Lameter wrote: > On Wed, 16 Jan 2013, Liu Bo wrote: > > > --- a/include/linux/slub_def.h > > +++ b/include/linux/slub_def.h > > @@ -93,6 +93,7 @@ struct kmem_cache { > > gfp_t allocflags; /*

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Thu, Jan 17, 2013 at 05:34:46PM +0900, Joonsoo Kim wrote: > Hello, Liu Bo. > > On Wed, Jan 16, 2013 at 11:03:13AM +0800, Liu Bo wrote: > > This adds a leak decoder callback so that slab destruction > > can use to generate debugging output for the allocated objects. > &

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Thu, Jan 17, 2013 at 05:34:46PM +0900, Joonsoo Kim wrote: Hello, Liu Bo. On Wed, Jan 16, 2013 at 11:03:13AM +0800, Liu Bo wrote: This adds a leak decoder callback so that slab destruction can use to generate debugging output for the allocated objects. Callers like btrfs are using

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Wed, Jan 16, 2013 at 03:20:57PM +, Christoph Lameter wrote: On Wed, 16 Jan 2013, Liu Bo wrote: --- a/include/linux/slub_def.h +++ b/include/linux/slub_def.h @@ -93,6 +93,7 @@ struct kmem_cache { gfp_t allocflags; /* gfp flags to use on each alloc */ int refcount

Re: [PATCH V2] mm/slab: add a leak decoder callback

On Wed, Jan 16, 2013 at 01:34:38PM +0800, Miao Xie wrote: On wed, 16 Jan 2013 11:03:13 +0800, Liu Bo wrote: This adds a leak decoder callback so that slab destruction can use to generate debugging output for the allocated objects. Callers like btrfs are using their own leak tracking

[PATCH V2] mm/slab: add a leak decoder callback

adding a callback for leak tracking can avoid this as well as runtime overhead. (The idea is from Zach Brown .) Signed-off-by: Liu Bo --- v2: add a wrapper API for slab destruction to make decoder only work in particular path. fs/btrfs/extent_io.c | 26 -- fs/btrfs

Re: [PATCH] mm/slab: add a leak decoder callback

On Tue, Jan 15, 2013 at 09:01:05AM -0800, Zach Brown wrote: > > The merge processing occurs during kmem_cache_create and you are setting > > up the decoder field afterwards! Wont work. > > In the thread I suggested providing the callback at destruction: > >

Re: [PATCH] mm/slab: add a leak decoder callback

On Tue, Jan 15, 2013 at 04:30:52PM +, Christoph Lameter wrote: > On Mon, 14 Jan 2013, Liu Bo wrote: > > > This adds a leak decoder callback so that kmem_cache_destroy() > > can use to generate debugging output for the allocated objects. > > Interesting idea. &

Re: [PATCH] mm/slab: add a leak decoder callback

On Tue, Jan 15, 2013 at 04:30:52PM +, Christoph Lameter wrote: On Mon, 14 Jan 2013, Liu Bo wrote: This adds a leak decoder callback so that kmem_cache_destroy() can use to generate debugging output for the allocated objects. Interesting idea. @@ -3787,6 +3789,9 @@ static int

Re: [PATCH] mm/slab: add a leak decoder callback

On Tue, Jan 15, 2013 at 09:01:05AM -0800, Zach Brown wrote: The merge processing occurs during kmem_cache_create and you are setting up the decoder field afterwards! Wont work. In the thread I suggested providing the callback at destruction:

[PATCH V2] mm/slab: add a leak decoder callback

adding a callback for leak tracking can avoid this as well as runtime overhead. (The idea is from Zach Brown z...@zabbo.net.) Signed-off-by: Liu Bo bo.li@oracle.com --- v2: add a wrapper API for slab destruction to make decoder only work in particular path. fs/btrfs/extent_io.c | 26

[PATCH] mm/slab: add a leak decoder callback

. So adding a callback for leak tracking can avoid this as well as runtime overhead. Signed-off-by: Liu Bo --- The idea is from Zach Brown . fs/btrfs/extent_io.c | 24 fs/btrfs/extent_map.c| 12 include/linux/slab.h |1 + include/linux

[PATCH] Tracing: fix regression of trace_pipe

buffer, or we may lose what we want since ring buffer's size is limited. Signed-off-by: Liu Bo --- kernel/trace/trace.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index e512567..fc76beb 100644 --- a/kernel/trace/trace.c

[PATCH] Tracing: fix regression of trace_pipe

buffer, or we may lose what we want since ring buffer's size is limited. Signed-off-by: Liu Bo bo.li@oracle.com --- kernel/trace/trace.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index e512567..fc76beb 100644

[PATCH] mm/slab: add a leak decoder callback

. So adding a callback for leak tracking can avoid this as well as runtime overhead. Signed-off-by: Liu Bo bo.li@oracle.com --- The idea is from Zach Brown z...@zabbo.net. fs/btrfs/extent_io.c | 24 fs/btrfs/extent_map.c| 12 include/linux

Re: 3.7.0-rc8 btrfs locking issue

On Wed, Dec 12, 2012 at 09:37:37AM +0800, Liu Bo wrote: > On Tue, Dec 11, 2012 at 09:33:15AM -0700, Jim Schutt wrote: > > On 12/09/2012 07:04 AM, Liu Bo wrote: > > > On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: > > > Hi Jim, > > > > > &g

Re: 3.7.0-rc8 btrfs locking issue

On Tue, Dec 11, 2012 at 09:33:15AM -0700, Jim Schutt wrote: > On 12/09/2012 07:04 AM, Liu Bo wrote: > > On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: > > Hi Jim, > > > > Could you please apply the following patch to test if it works? > > Hi, >

Re: 3.7.0-rc8 btrfs locking issue

On Tue, Dec 11, 2012 at 09:33:15AM -0700, Jim Schutt wrote: On 12/09/2012 07:04 AM, Liu Bo wrote: On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: Hi Jim, Could you please apply the following patch to test if it works? Hi, So far, with your patch applied I've been unable

Re: 3.7.0-rc8 btrfs locking issue

On Wed, Dec 12, 2012 at 09:37:37AM +0800, Liu Bo wrote: On Tue, Dec 11, 2012 at 09:33:15AM -0700, Jim Schutt wrote: On 12/09/2012 07:04 AM, Liu Bo wrote: On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: Hi Jim, Could you please apply the following patch to test

Re: 3.7.0-rc8 btrfs locking issue

On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: > Hi, > > I'm hitting a btrfs locking issue with 3.7.0-rc8. > > The btrfs filesystem in question is backing a Ceph OSD > under a heavy write load from many cephfs clients. > > I reported this issue a while ago: >

Re: 3.7.0-rc8 btrfs locking issue

On Wed, Dec 05, 2012 at 09:07:05AM -0700, Jim Schutt wrote: Hi, I'm hitting a btrfs locking issue with 3.7.0-rc8. The btrfs filesystem in question is backing a Ceph OSD under a heavy write load from many cephfs clients. I reported this issue a while ago:

Re: [PATCH 1/2] Btrfs: fix permissions of empty files not affected by umask

not get lost if the in-memory inode is flushed before other > changes are made to the file. > Looks good to me. Reviewed-by: Liu Bo thanks, liubo > Signed-off-by: Filipe Brandenburger > --- > fs/btrfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > > di

Re: [PATCH 1/2] Btrfs: fix permissions of empty files not affected by umask

is flushed before other changes are made to the file. Looks good to me. Reviewed-by: Liu Bo bo.li@oracle.com thanks, liubo Signed-off-by: Filipe Brandenburger filbran...@google.com --- fs/btrfs/inode.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/btrfs/inode.c b/fs

Re: [PATCH] Btrfs: small fix the commment for the action flags in delayed-ref.h

On 09/20/2012 11:07 PM, Wang Sheng-Hui wrote: > The action has been merged into struct btrfs_delayed_ref_node, > and no struct btrfs_delayed_ref is available now. > You can consider sending this kind of typo fix patch to trivial list instead. thanks, liubo > Signed-off-by: Wang Sheng-Hui >

Re: [PATCH] Btrfs: small fix the commment for the action flags in delayed-ref.h

On 09/20/2012 11:07 PM, Wang Sheng-Hui wrote: The action has been merged into struct btrfs_delayed_ref_node, and no struct btrfs_delayed_ref is available now. You can consider sending this kind of typo fix patch to trivial list instead. thanks, liubo Signed-off-by: Wang Sheng-Hui

Re: [BUG Report] BUG: unable to handle kernel NULL pointer dereference at

On 08/13/2012 06:01 PM, Bjørn Mork wrote: > Liu Bo writes: > >> I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. >> >> When I unplug my mobile usb card, I hit this: >> >> [ 247.017258] BUG: unable to handle kernel NULL pointe

[BUG Report] BUG: unable to handle kernel NULL pointer dereference at

Hi all, I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. When I unplug my mobile usb card, I hit this: [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at (null) [ 247.017378] IP: [] stop_read_write_urbs+0x3f/0x90 [usb_wwan] [ 247.017484] PGD

[BUG Report] BUG: unable to handle kernel NULL pointer dereference at

Hi all, I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. When I unplug my mobile usb card, I hit this: [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at (null) [ 247.017378] IP: [a03bf27f] stop_read_write_urbs+0x3f/0x90 [usb_wwan] [

Re: [BUG Report] BUG: unable to handle kernel NULL pointer dereference at

On 08/13/2012 06:01 PM, Bjørn Mork wrote: Liu Bo liub.li...@gmail.com writes: I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. When I unplug my mobile usb card, I hit this: [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at (null