[PATCH] drm/panel: lvds: Drop unnecessary NULL pointer checks for lvds->enable_gpio

2021-04-20 Thread Liu Ying
: Daniel Vetter Signed-off-by: Liu Ying --- drivers/gpu/drm/panel/panel-lvds.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 59a8d99..19f11fa 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c

[PATCH] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()

2021-04-16 Thread Liu Ying
krabec Cc: David Airlie Cc: Daniel Vetter Cc: Guido Günther Cc: Robert Chiras Cc: NXP Linux Team Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/nwl-dsi.c | 86 +--- 1 file changed, 46 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-ds

Re: [PATCH v5 2/2] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-04-12 Thread Liu Ying
ev, "Failed to create phy %ld\n", PTR_ERR(phy)); > return PTR_ERR(phy); > } > phy_set_drvdata(phy, priv); > > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + if (IS_ERR(phy_provider)) > +

Re: [PATCH v5 1/2] phy: core: Use runtime pm during configure too

2021-04-12 Thread Liu Ying
e_get_sync(phy); > + if (ret < 0 && ret != -ENOTSUPP) > + return ret; > + ret = 0; /* Override possible ret == -ENOTSUPP */ This override is not needed, because 'ret' will be the return value of phy->ops->configure() right below. Regards, Liu Y

Re: [PATCH v7 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-04-01 Thread Liu Ying
On Wed, 2021-03-31 at 08:40 -0500, Rob Herring wrote: > On Wed, 31 Mar 2021 14:33:18 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp Control and Status Registers > > module. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > &

Re: [PATCH v5 2/5] phy: Add LVDS configuration options

2021-04-01 Thread Liu Ying
Hi Kishon, First of all, thanks for your review. On Wed, 2021-03-31 at 19:02 +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 25/03/21 2:30 pm, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custo

[PATCH v7 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-31 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v6->v7: * Add Robert's R-b tag. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS

[PATCH v7 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-31 Thread Liu Ying
Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/devicetree/msg414149.html Marcel, I

[PATCH v7 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-31 Thread Liu Ying
supports the LDB single mode and split mode. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series

[PATCH v7 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-31 Thread Liu Ying
-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix in v7 is trivial. v6->v7: * Fix below complaints from 'checkpatch.pl --strict'. (Robert) - 'Alignment should match open parenthesis' - 'Prefer using the BIT macro' *

[PATCH v7 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-31 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- Marcel, I add your T-b tag from v6, let me know if you want me to drop it, as the checkpatch fix

[PATCH v7 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-03-31 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention the CSR

[PATCH v7 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-31 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Rob) v2->v3: * Drop 'fsl,syscon' property.

[PATCH v7 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-31 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * Add Rob's R-b tag. v5->v6: * Drop 'select' schema. (Rob) v4->v5: * Newly introduced in v5. (Rob) .../devicetree/bindings/mfd/fsl,imx8qxp

[PATCH v7 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-31 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Requ

[PATCH v7 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-31 Thread Liu Ying
and a control interface. Reviewed-by: Robert Foss Tested-by: Marcel Ziswiler # Colibri iMX8X, LT170410-2WHC, LP156WF1 Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial

[PATCH v7 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-03-31 Thread Liu Ying
-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v7 contains a fix for checkpatch complaints. Marcel, as the fix is trivial, I add your T-b tag. Let me know if you want me to drop it. v6->v7: * Fix 'Alignment should match open parenthe

[PATCH v7 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-31 Thread Liu Ying
8qm/qxp LDB bridge drivers and Kconfig help messages. Liu Ying (14): media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding drm/bridge

[PATCH v7 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-31 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2: * No chan

[PATCH v7 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-31 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v6->v7: * No change. v5->v6: * Fi

[PATCH v7 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-31 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Use enu

Re: [PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-31 Thread Liu Ying
warning you mentioned, is it the Kconfig warning? I'm asssuming it can also be ignored just like the one for patch 12/14? Liu Ying > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm LVDS display bridge(LDB) > > which is of

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-31 Thread Liu Ying
On Tue, 2021-03-30 at 11:54 +0200, Robert Foss wrote: > Hey Liu, > > checkpatch --strict lists some nit and a warning. With those fixed > feel free to add my r-b. > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp

Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-31 Thread Liu Ying
w. Will fix those nits and that warning in the next version. Liu Ying

Re: [PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-31 Thread Liu Ying
Hi Robert, On Tue, 2021-03-30 at 11:46 +0200, Robert Foss wrote: > Hey Liu, > > checkpatch --strict is listing some nits for this patch, with those > fixed feel free to add my r-b. > > Reviewed-by: Robert Foss Thanks for your review. Will fix those nits in the next version. Liu Ying

Re: [PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-31 Thread Liu Ying
rom 'checkpatch.pl --strict' for the pixel combiner driver(patch 4/16) and pixel link driver(patch 6/16). If no objections, I'll keep your R-b tags on them. > > On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qxp pixel link to displ

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-29 Thread Liu Ying
Hi Marcel, On Mon, 2021-03-29 at 00:49 +, Marcel Ziswiler wrote: > Hi Liu > > On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote: > > On Tue, 2021-03-23 at 01:03 +, Marcel Ziswiler wrote: > > > Hi Liu > > > > > > Some further discrepancy wit

[PATCH v9 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-03-29 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAIN

[PATCH v9 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2021-03-29 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * Fix co

[PATCH v9 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-29 Thread Liu Ying
i.MX8qxp and i.MX8qm in DPU's dt binding documentation. * Use new dt binding way to add clocks in the dt binding examples. * Address several comments from Laurentiu on the DPU DRM patch. Liu Ying (6): dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding dt-bindings: display: imx: Add i.MX8qx

[PATCH v9 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2021-03-29 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: *

[PATCH v9 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2021-03-29 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * Improve compatible prop

[PATCH v9 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2021-03-29 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Signed-off-by: Liu Ying --- v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional interrupt(r_rtram_stall) because the reference manual does mention it, though the dri

[PATCH v2] drm/imx: ipuv3-plane: Remove two unnecessary export symbols

2021-03-25 Thread Liu Ying
: merge imx-drm-core and ipuv3-crtc in one module) Signed-off-by: Liu Ying --- v2: * Fix commit message typo - s/ipu_plane_assign_pre/ipu_planes_assign_pre/ drivers/gpu/drm/imx/ipuv3-plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
Hi Vinod, On Thu, 2021-03-25 at 12:58 +0530, Vinod Koul wrote: > On 18-03-21, 10:22, Liu Ying wrote: > > > > Can we have these in kernel-doc style please, similar to style in > > > linux/phy/phy.h > > > > I take this way of in-line member documentation

[PATCH v5 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
wed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Guido's R-b tag. v2->v3: * Improve readability of mixel_dphy_set_mode(). (Guido) v1->v2: * Print invalid PHY mode in dmesg. (Guido) drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 269 +

[PATCH v5 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2021-03-25 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change.

[PATCH v5 3/5] dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema

2021-03-25 Thread Liu Ying
Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Rob's and Guido's R-b tags. v2->v3: * Improve the 'clock-names' property by dropping 'items:'. v1->v2: * Newly introduced in

[PATCH v5 2/5] phy: Add LVDS configuration options

2021-03-25 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Signed-off-by: Liu Ying --- v4->v5: * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) * Trivial tweaks. * Drop Robert's R-b tag. v3->v4: * Add Robert's R-b tag. v2->v3: * No change. v1->v2: * No change. include/linux/phy/phy

[PATCH v5 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2021-03-25 Thread Liu Ying
Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * No change.

[PATCH v5 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-25 Thread Liu Ying
onvert mixel,mipi-dsi-phy plain text dt binding to json-schema. (Guido) * Print invalid PHY mode in dmesg from the Mixel PHY driver. (Guido) * Add Guido's R-b tag on the patch for the nwl-dsi drm bridge driver. Liu Ying (5): drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable() phy: Add LVDS c

Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Liu Ying
d at runtime. > > The warning could be fixed by adding a Kconfig depedency on CONFIG_OF, > but Liu Ying points out that the driver may hit the out-of-bounds > problem at runtime anyway. Almost impossible to hit the out-of-bounds problem at runtime, unless something wrong happens and

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
Hi Arnd, Thanks for your patch. It would be good to improve the patch's head line to something like: drm/imx: imx-ldb: fix out of bounds array access warning Regards, Liu Ying On Tue, 2021-03-23 at 14:05 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_OF is

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
DRM_IMX_LDB is in the same case. Moreover, even if OF is enabled, drm_of_encoder_active_endpoint() is likely to return -EINVAL. So, it looks ok to add an error check. Regards, Liu Ying > > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -27,7 +27,7 @@ config DRM_

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Liu Ying
; > +"%s: invalid mux\n", __func__); > > trivia: > > Any real reason to make this 2 lines? It fits nicely in 80 chars. Maybe: > > dev_warn(ldb->dev, "%s: invalid mux: %d\n", __func__, mux); > > or maybe: > >

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Liu Ying
i > failed with error -12 > [1.840547] imx8qxp-lpcg-clk 5958.clock-controller: deferred probe > timeout, ignoring dependency > [1.840571] imx8qxp-lpcg-clk: probe of 5958.clock-controller failed > with error -110 > > Any suggestions welcome. Thanks! Please reference th

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:38 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:34 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > &g

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:23 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. >

[PATCH] drm/imx: ipuv3-plane: Remove two unnecessary export symbols

2021-03-21 Thread Liu Ying
: merge imx-drm-core and ipuv3-crtc in one module) Signed-off-by: Liu Ying --- drivers/gpu/drm/imx/ipuv3-plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 0755080..4bd39bb 100644 --- a/drivers/gpu/drm/imx/ipuv3

[PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

2021-03-21 Thread Liu Ying
-off-by: Liu Ying --- This patch fixes an issue introduced in v5.12-rc1. It would be good to fix sooner than later. drivers/gpu/drm/imx/imx-ldb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index dbfe39e

Re: [PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-17 Thread Liu Ying
Hi Vinod, On Wed, 2021-03-17 at 15:52 +0530, Vinod Koul wrote: > On 08-03-21, 11:52, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic union. > > > > Th

[PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-16 Thread Liu Ying
simultaneously, either in dual mode or split mode. In dual mode, the two channels output identical data. In split mode, channel0 outputs odd pixels and channel1 outputs even pixels. This patch supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch

[PATCH v6 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-16 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-16 Thread Liu Ying
supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/arm-kernel/msg879957

[PATCH v6 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention the CSR module controls LDB. v

[PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-16 Thread Liu Ying
This patch adds a helper to support LDB drm bridge drivers for i.MX SoCs. Helper functions supported by this helper should implement common logics for all LDB modules embedded in i.MX SoCs. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * Make imx-ldb-helper be a pure

[PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-16 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Use 'fsl,sc-resource' DT property to get the SCU resource ID associated with the PXL2DPI instance instead of using alias ID. (Rob) v2-&g

[PATCH v6 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * Add Rob's R-b tag. v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Rob) v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention th

[PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Require all four pixel li

[PATCH v6 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-03-16 Thread Liu Ying
screens, or virtual screens. The pixel combiner is also responsible for generating some of the control signals for the pixel link output channel. For now, the driver only supports the bypass mode. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5:

[PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-16 Thread Liu Ying
using companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum available LDB channels from i.MX8qm LDB bridge driver. * Mention i.MX8qm/qxp LDB official name 'pixel mapper' in i.MX8qm/qxp LDB bridge drivers and Kcon

[PATCH v6 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Signed-off-by: Liu Ying --- v5->v6: * Drop 'select' schema. (Rob) v4->v5: * Newly introduced in v5. (Rob) .../devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml | 192 + 1 file change

[PATCH v6 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-16 Thread Liu Ying
and a control interface. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * Make a comment occupy a line. (Robert) * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * Drop two macros which help define functions and define them directly. * Properly

[PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-16 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- v5->v6: * Add Laurent's R-b tag. v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. include/uapi/linux/med

[PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-16 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Use enum instead of oneOf + co

[PATCH v6 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-16 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Liu Ying --- Robert, I keep your R-b tag from v5. Let me know if you want me to drop it, as v6 contains a fix. v5->v6: * Fix data organizati

Re: [PATCH v5 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-16 Thread Liu Ying
On Tue, 2021-03-16 at 16:38 -0600, Rob Herring wrote: > On Wed, Mar 10, 2021 at 05:55:31PM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp Control and Status Registers > > module. > > > > Signed-off-by: Liu Ying > > --- > > v4-

[PATCH] media: docs: Fix data organization of MEDIA_BUS_FMT_RGB101010_1X30

2021-03-10 Thread Liu Ying
The media bus bit width of MEDIA_BUS_FMT_RGB101010_1X30 is 30. So, 'Bit31' and 'Bit30' cells for the 'MEDIA_BUS_FMT_RGB101010_1X30' row should be spaces instead of '0's. Fixes: 54f38fcae536 ("media: docs: move uAPI book to userspace-api/media") Signed-off-by: Liu Ying --- Doc

Re: [PATCH v5 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-10 Thread Liu Ying
Hi Laurent, On Wed, 2021-03-10 at 15:24 +0200, Laurent Pinchart wrote: > Hi Liu, > > Thank you for the patch. Thanks for your review. > > On Wed, Mar 10, 2021 at 05:55:26PM +0800, Liu Ying wrote: > > This patch adds documentations for RGB666_1X30_CPADL

[PATCH v5 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs

2021-03-10 Thread Liu Ying
Add myself as the maintainer of DRM bridge drivers for i.MX SoCs. Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINT

[PATCH v5 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp

2021-03-10 Thread Liu Ying
supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch 'phy: Add LVDS configuration options', which has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/arm-kernel/msg879957

[PATCH v5 13/14] drm/bridge: imx: Add LDB support for i.MX8qm

2021-03-10 Thread Liu Ying
simultaneously, either in dual mode or split mode. In dual mode, the two channels output identical data. In split mode, channel0 outputs odd pixels and channel1 outputs even pixels. This patch supports the LDB single mode and split mode. Signed-off-by: Liu Ying --- Note that this patch depends on the patch

[PATCH v5 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-03-10 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Rob's R-b tag. v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention the CSR module controls LDB. v1->v2: * Use graph sche

[PATCH v5 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-10 Thread Liu Ying
This patch adds a helper to support LDB drm bridge drivers for i.MX SoCs. Helper functions supported by this helper should implement common logics for all LDB modules embedded in i.MX SoCs. Signed-off-by: Liu Ying --- v4->v5: * Make imx-ldb-helper be a pure object to be linked with i.MX8qxp

[PATCH v5 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support

2021-03-10 Thread Liu Ying
codings between those modules. The PXL2DPI is purely combinatorial. Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Use 'fsl,sc-resource' DT property to get the SCU resource ID associated with the PXL2DPI instance instead of using alias ID. (Rob) v2->v3: * Call syscon_node_

[PATCH v5 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding

2021-03-10 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp Control and Status Registers module. Signed-off-by: Liu Ying --- v4->v5: * Newly introduced in v5. (Rob) .../devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml | 202 + 1 file changed, 202 insertions(+) create mode 100644 Documentat

[PATCH v5 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-10 Thread Liu Ying
This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add 'fsl,sc-resource' property. (Rob) v2->v3: * Drop 'fsl,syscon' property. (Rob) * Mention the CSR module controls PXL2DPI. v1->v2: * Use graph sche

[PATCH v5 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-10 Thread Liu Ying
and a control interface. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v4->v5: * Make a comment occupy a line. (Robert) * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * Drop two macros which help define functions and define them directly. * Properly disable all pixel link contro

[PATCH v5 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-10 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp display pixel link. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Require all four pixel link output ports. (Laurent) * M

[PATCH v5 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

2021-03-10 Thread Liu Ying
screens, or virtual screens. The pixel combiner is also responsible for generating some of the control signals for the pixel link output channel. For now, the driver only supports the bypass mode. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v4->v5: * Drop the 'PC_BUF_PARA_REG' regis

[PATCH v5 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-10 Thread Liu Ying
This patch adds bindings for i.MX8qm/qxp pixel combiner. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * No change. v2->v3: * Add Rob's R-b tag. v1->v2: * Use graph schema. (Laurent) * Use enum instead of oneOf + const for the reg prope

[PATCH v5 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-10 Thread Liu Ying
bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. include/uapi/linux/media-bus-format.h | 6 +- 1 file changed, 5 insertions(+), 1 delet

[PATCH v5 02/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-10 Thread Liu Ying
or a 36-bit output bus(12-bit per component) to a pixel link. Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v4->v5: * Add Robert's R-b tag. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. .../userspace-api/media/v4l/subdev-formats.rst | 156

[PATCH v5 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-10 Thread Liu Ying
ng companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum available LDB channels from i.MX8qm LDB bridge driver. * Mention i.MX8qm/qxp LDB official name 'pixel mapper' in i.MX8qm/qxp LDB bridge drivers a

Re: [PATCH v4 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-08 Thread Liu Ying
Hi Robert, On Thu, 2021-03-04 at 11:27 +0800, Liu Ying wrote: > Hi Robert, > > On Wed, 2021-03-03 at 16:34 +0100, Robert Foss wrote: > > On Wed, 3 Mar 2021 at 08:23, Liu Ying wrote: > > > Hi Robert, > > > > > > On Tue, 2021-03-02 at 15:22

Re: [PATCH v4 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-03-08 Thread Liu Ying
Hi Rob, On Fri, 2021-03-05 at 16:42 -0600, Rob Herring wrote: > On Thu, Feb 18, 2021 at 11:41:49AM +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). > > > > Signed-off-by: Liu Ying > > --- > > v3->v4: > &

[PATCH v4 3/5] dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema

2021-03-07 Thread Liu Ying
Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v3->v4: * Add Rob's and Guido's R-b tags. v2->v3: * Improve the 'clock-names' property by dropping 'items:'. v1->v2: * Newly introduced in v2. (Guido) .../d

[PATCH v4 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-07 Thread Liu Ying
wed-by: Guido Günther Signed-off-by: Liu Ying --- v3->v4: * Add Guido's R-b tag. v2->v3: * Improve readability of mixel_dphy_set_mode(). (Guido) v1->v2: * Print invalid PHY mode in dmesg. (Guido) drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 269 - 1 file

[PATCH v4 2/5] phy: Add LVDS configuration options

2021-03-07 Thread Liu Ying
I Cc: Vinod Koul Cc: NXP Linux Team Reviewed-by: Robert Foss Signed-off-by: Liu Ying --- v3->v4: * Add Robert's R-b tag. v2->v3: * No change. v1->v2: * No change. include/linux/phy/phy-lvds.h | 48 include/linux/phy/phy.h | 4

[PATCH v4 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2021-03-07 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v3->v4: * Add Ro

[PATCH v4 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2021-03-07 Thread Liu Ying
Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v3->v4: * No change. v2->v3: * No change.

[PATCH v4 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-07 Thread Liu Ying
rm bridge driver. Liu Ying (5): drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable() phy: Add LVDS configuration options dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp phy: freescale: phy-fsl-

Re: [PATCH v3 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2021-03-07 Thread Liu Ying
s. Will respin this series soon with all R-b tags added. Thanks, Liu Ying > > [1] > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fdri-devel%2Fcover%2F1607651182-12307-1-git-send-email-victor.liu%40nxp.com%2Fdata=04%7C0

Re: [PATCH v3 2/5] phy: Add LVDS configuration options

2021-03-07 Thread Liu Ying
f still looks good though :) ) Thanks for your review :) Liu Ying > > On Fri, 11 Dec 2020 at 02:56, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic

Re: [PATCH v4 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-03 Thread Liu Ying
Hi Robert, On Wed, 2021-03-03 at 16:34 +0100, Robert Foss wrote: > On Wed, 3 Mar 2021 at 08:23, Liu Ying wrote: > > Hi Robert, > > > > On Tue, 2021-03-02 at 15:22 +0100, Robert Foss wrote: > > > Hey Liu, > > > > > > Thanks for submitting this

Re: [PATCH v4 10/14] drm/bridge: imx: Add LDB driver helper support

2021-03-03 Thread Liu Ying
Hi Robert, On Tue, 2021-03-02 at 15:22 +0100, Robert Foss wrote: > Hey Liu, > > Thanks for submitting this patch. Thanks for reviewing this patch. > > On Thu, 18 Feb 2021 at 04:59, Liu Ying wrote: > > This patch adds a helper to support LDB drm bridge drivers for &

Re: [PATCH v4 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support

2021-03-03 Thread Liu Ying
n Thu, 18 Feb 2021 at 04:59, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm/qxp display pixel link. > > The pixel link forms a standard asynchronous linkage between > > pixel sources(display controller or camera module) and pixel > > consumers

Re: [PATCH v8 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-03 Thread Liu Ying
On Tue, 2021-03-02 at 16:36 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > One comment below. > > On Tue, Mar 02, 2021 at 02:33:15PM +0800, Liu Ying wrote: > > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > > > DPU is

[PATCH v8 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-03-02 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Signed-off-by: Liu Ying --- v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: * No change. v2->v3: * No change. v1->v2: * No change. MAINTAINERS | 9 +++

  1   2   3   4   5   6   7   8   >