RE: [tip:x86/cpufeature] x86/cpufeature: Enable RING3MWAIT for Knights Mill

Hi Thomas, It looks like there is a typo with the line with 'break' - it should be semicolon there. Could you fix it, please? Thx, Piotr > > Signed-off-by: Piotr Luc <piotr@intel.com> > Cc: piotr@intel.com > Cc: dave.han...@linux.intel.com > Link: http://lkml.ke

RE: [tip:x86/cpufeature] x86/cpufeature: Enable RING3MWAIT for Knights Mill

Hi Thomas, It looks like there is a typo with the line with 'break' - it should be semicolon there. Could you fix it, please? Thx, Piotr > > Signed-off-by: Piotr Luc > Cc: piotr@intel.com > Cc: dave.han...@linux.intel.com > Link:

Re: [PATCH v1 0/2] vpopcntdq support

On Tue, 2017-01-10 at 18:39 +0100, Paolo Bonzini wrote: > > The path 1/2 adds new feature flags and handles clearing the > > feature bit in > > case xsave is not enabled. > > > > The patch 2/2 enables passing the feature bit to a kvm/quemu guest. > > > > The patchset is based on v4.10-rc3. > >

Re: [PATCH v1 0/2] vpopcntdq support

On Tue, 2017-01-10 at 18:39 +0100, Paolo Bonzini wrote: > > The path 1/2 adds new feature flags and handles clearing the > > feature bit in > > case xsave is not enabled. > > > > The patch 2/2 enables passing the feature bit to a kvm/quemu guest. > > > > The patchset is based on v4.10-rc3. > >

Re: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM)

On Thu, 2016-12-01 at 01:47 -0500, Len Brown wrote: > Piotr, > Thanks for sending the patch, I've made this change to my turbostat > branch for 4.10. > > I did not apply your patch directly because for some reason it didn't > appear in patchwork for linux-pm, > only for lkml, which I do not

Re: [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM)

On Thu, 2016-12-01 at 01:47 -0500, Len Brown wrote: > Piotr, > Thanks for sending the patch, I've made this change to my turbostat > branch for 4.10. > > I did not apply your patch directly because for some reason it didn't > appear in patchwork for linux-pm, > only for lkml, which I do not

Re: [PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

On Thu, 2016-12-01 at 00:39 +0100, Thomas Gleixner wrote: > On Thu, 1 Dec 2016, Piotr Luc wrote: > > > > > The Knights Mill is enough close to Knights Landing so the path > > reuses > > C-state residency support of the latter. > > > > Signed-off-

Re: [PATCH] perf/x86/intel: Enable C-state residency events for Knights Mill

On Thu, 2016-12-01 at 00:39 +0100, Thomas Gleixner wrote: > On Thu, 1 Dec 2016, Piotr Luc wrote: > > > > > The Knights Mill is enough close to Knights Landing so the path > > reuses > > C-state residency support of the latter. > > > > Signed-off-by: Piotr Luc > > Cc: Thomas Gleixner > > Cc:

Re: [RESEND,10/11] powercap / RAPL: Add Knights Mill CPUID

Hi Rafael, Kindly reminder. Could you pick this patch up for kernel 4.10? The RedHat acceptance window is closing soon, I need to pass them the commit id. Thanks, Piotr On Tue, 2016-10-25 at 12:35 +0200, Luc, Piotr wrote: > Hi Rafael, > > Could you tell me what more do I need to

Re: [RESEND,10/11] powercap / RAPL: Add Knights Mill CPUID

Hi Rafael, Kindly reminder. Could you pick this patch up for kernel 4.10? The RedHat acceptance window is closing soon, I need to pass them the commit id. Thanks, Piotr On Tue, 2016-10-25 at 12:35 +0200, Luc, Piotr wrote: > Hi Rafael, > > Could you tell me what more do I need to

RE: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

Thanks! Piotr > -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of > Rafael J. Wysocki > Sent: Wednesday, November 30, 2016 11:02 PM > To: Luc, Piotr <piotr@intel.com> > Cc: raf...@kernel.org; srinivas.pandruv...@linux.inte

RE: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

Thanks! Piotr > -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of > Rafael J. Wysocki > Sent: Wednesday, November 30, 2016 11:02 PM > To: Luc, Piotr > Cc: raf...@kernel.org; srinivas.pandruv...@linux.intel.com; > l...@

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

Hi Rafael, > > > > > > The mentioned path 03/11 is already merged in 4.9.rc2. > > > > If it's already there, I can pick up the intel_pstate one. > > > > Thanks, > > > > > > Rafael > > Here is the commit http://git.kernel.org/cgit/linux/kernel/git/torval > ds >

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

Hi Rafael, > > > > > > The mentioned path 03/11 is already merged in 4.9.rc2. > > > > If it's already there, I can pick up the intel_pstate one. > > > > Thanks, > > > > > > Rafael > > Here is the commit http://git.kernel.org/cgit/linux/kernel/git/torval > ds >

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Mon, 2016-10-31 at 10:53 +0100, Borislav Petkov wrote: > > I think that in v4.9-rc2 the CPUID[7,0].edx bits can be masked out > by > > applying noxsave to cmdline. Using directly cpu_count will result > in > > passing the bits in edx to a guest directly while the xsaveopt and > rest > > of

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Mon, 2016-10-31 at 10:53 +0100, Borislav Petkov wrote: > > I think that in v4.9-rc2 the CPUID[7,0].edx bits can be masked out > by > > applying noxsave to cmdline. Using directly cpu_count will result > in > > passing the bits in edx to a guest directly while the xsaveopt and > rest > > of

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Sat, 2016-10-29 at 08:21 -0400, Paolo Bonzini wrote: > > Currently none of the bits in CPUID[7,0].edx is ever masked by the > host, so > this would be enough.  If we ever need to do some masking, I guess > I'll > practice my puss-in-boots look and submit a patch to add CPUID[7,0] > back > as a

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Sat, 2016-10-29 at 08:21 -0400, Paolo Bonzini wrote: > > Currently none of the bits in CPUID[7,0].edx is ever masked by the > host, so > this would be enough.  If we ever need to do some masking, I guess > I'll > practice my puss-in-boots look and submit a patch to add CPUID[7,0] > back > as a

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Fri, 2016-10-28 at 17:12 +0800, He Chen wrote: > The spec can be found in Intel Software Developer Manual or in > Instruction Set Extensions Programming Reference. > > Signed-off-by: Luwei Kang > Signed-off-by: He Chen > --- >  

Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest

On Fri, 2016-10-28 at 17:12 +0800, He Chen wrote: > The spec can be found in Intel Software Developer Manual or in > Instruction Set Extensions Programming Reference. > > Signed-off-by: Luwei Kang > Signed-off-by: He Chen > --- >  arch/x86/kvm/cpuid.c | 7 ++- >  1 file changed, 6

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

On Tue, 2016-10-25 at 13:16 +0200, Rafael J. Wysocki wrote: > Hi, > > On Tue, Oct 25, 2016 at 12:48 PM, Luc, Piotr <piotr@intel.com> > wrote: > > > > Hi > > > > Could you tell me what more do I need to do to get the patch > > accepted? >

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

On Tue, 2016-10-25 at 13:16 +0200, Rafael J. Wysocki wrote: > Hi, > > On Tue, Oct 25, 2016 at 12:48 PM, Luc, Piotr > wrote: > > > > Hi > > > > Could you tell me what more do I need to do to get the patch > > accepted? > > > > The mentioned

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

ights Mill (KNM) to the list of CPUIDs supported by > > intel_pstate. > > > > Signed-off-by: Piotr Luc <piotr@intel.com> > > Reviewed-by: Dave Hansen <dave.han...@intel.com> > > Cc: Srinivas Pandruvada <srinivas.pandruv...@linux.intel.com> >

Re: [RESEND PATCH 06/11] cpufreq: intel_pstate: Add Knights Mill CPUID

Hi Could you tell me what more do I need to do to get the patch accepted? The mentioned path 03/11 is already merged in 4.9.rc2. Thanks Piotr On Thu, 2016-10-13 at 10:51 -0700, Srinivas Pandruvada wrote: > On Thu, 2016-10-13 at 17:31 +0200, Piotr Luc wrote: > > > > Add Knights Mill (KNM) to

Re: [RESEND,10/11] powercap / RAPL: Add Knights Mill CPUID

igned-off-by: Piotr Luc <piotr@intel.com> > Reviewed-by: Dave Hansen <dave.han...@intel.com> > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > This patch depends on [PATCH 03

Re: [RESEND,10/11] powercap / RAPL: Add Knights Mill CPUID

Hi Rafael, Could you tell me what more do I need to do to get the patch accepted? The mentioned path 03/11 is already merged in 4.9.rc2. Thanks, Piotr On Thu, 2016-10-13 at 17:31 +0200, Piotr Luc wrote: > Add Knights Mill (KNM) to the list of CPUIDs supported by intel_rapl > > Signed-off-by:

Re: [RESEND,04/11] x86/intel_idle: Add Knights Mill CPUID

igned-off-by: Piotr Luc <piotr@intel.com> > Reviewed-by: Dave Hansen <dave.han...@intel.com> > Cc: linux...@vger.kernel.org > Cc: Len Brown <l...@kernel.org> > Cc: linux-kernel@vger.kernel.org > --- > This patch depends on [PATCH 03/11] x86/cpu/intel: Add Knigh

Re: [RESEND,04/11] x86/intel_idle: Add Knights Mill CPUID

Hi Len, Could you tell me what more do I need to do to get the patchset accepted? The mentioned path 03/11 is already merged in 4.9.rc2. Thanks, Piotr On Thu, 2016-10-13 at 17:30 +0200, Piotr Luc wrote: > Add Knights Mill (KNM) to the list of CPUIDs supported by intel_idle. > > Signed-off-by:

Re: [RESEND PATCH 00/11] Add Knights Mill CPU ID

On Thu, 2016-10-13 at 23:56 +0200, Rafael J. Wysocki wrote: > On Thursday, October 13, 2016 05:30:54 PM Piotr Luc wrote: > > > > Piotr Luc (11): > >   EDAC, sb_edac: Use Intel family processor macros > >   tools/power turbostat: Use Intel family processor macros > >   x86/cpu/intel: Add Knights

Re: [RESEND PATCH 00/11] Add Knights Mill CPU ID

On Thu, 2016-10-13 at 23:56 +0200, Rafael J. Wysocki wrote: > On Thursday, October 13, 2016 05:30:54 PM Piotr Luc wrote: > > > > Piotr Luc (11): > >   EDAC, sb_edac: Use Intel family processor macros > >   tools/power turbostat: Use Intel family processor macros > >   x86/cpu/intel: Add Knights

Re: [PATCH 0/2]tools/power turbostat: enable turbostat to support Knights Mill (KNM)

On Tue, 2016-10-18 at 23:06 +0200, Piotr Luc wrote: > This patchset is rebased onto > 08328814256d888634ff15ba8fb67e2ae4340b64.  > > First patch improves code style by replacing raw numbers > of CPUID with descriptive macros of processor names. > > The second patch adds Knights Mill (KNM) to the

Re: [PATCH 0/2]tools/power turbostat: enable turbostat to support Knights Mill (KNM)

On Tue, 2016-10-18 at 23:06 +0200, Piotr Luc wrote: > This patchset is rebased onto > 08328814256d888634ff15ba8fb67e2ae4340b64.  > > First patch improves code style by replacing raw numbers > of CPUID with descriptive macros of processor names. > > The second patch adds Knights Mill (KNM) to the

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote: > On Thu, 13 Oct 2016, Piotr Luc wrote: > > > > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ > > Especialy those, which are completely useless? > > The defines are there to be self explaining and the extra verbose > information

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote: > On Thu, 13 Oct 2016, Piotr Luc wrote: > > > > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ > > Especialy those, which are completely useless? > > The defines are there to be self explaining and the extra verbose > information

Re: [v2] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features.

On Mon, 2016-10-17 at 17:03 +0200, Piotr Luc wrote: > v2: Initialize new bits in the scattered group. Add The commit message is obviously broken. Sorry for that. I will resend with fixed message. Regards, Piotr

Re: [v2] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features.

On Mon, 2016-10-17 at 17:03 +0200, Piotr Luc wrote: > v2: Initialize new bits in the scattered group. Add The commit message is obviously broken. Sorry for that. I will resend with fixed message. Regards, Piotr

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 00:42 +0200, Borislav Petkov wrote: > On Sun, Oct 16, 2016 at 11:42:26AM -0700, h...@zytor.com wrote: > > > > It's needlessly adding complexity for no reason, at least for the > > What complexity? The init_scattered_cpuid_features() version is a > trivial patch in

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 00:42 +0200, Borislav Petkov wrote: > On Sun, Oct 16, 2016 at 11:42:26AM -0700, h...@zytor.com wrote: > > > > It's needlessly adding complexity for no reason, at least for the > > What complexity? The init_scattered_cpuid_features() version is a > trivial patch in

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 10:47 +0200, Ingo Molnar wrote: > * Luc, Piotr <piotr@intel.com> wrote: > > > > > On Mon, 2016-10-17 at 09:55 +0200, Thomas Gleixner wrote: > > > > > The typo was acknowledged and is going to be fixed in next version > >

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 10:47 +0200, Ingo Molnar wrote: > * Luc, Piotr wrote: > > > > > On Mon, 2016-10-17 at 09:55 +0200, Thomas Gleixner wrote: > > > > > The typo was acknowledged and is going to be fixed in next version > > of > > the docu

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 09:55 +0200, Thomas Gleixner wrote: > On Sun, 16 Oct 2016, Borislav Petkov wrote: > > > > > > > > The spec can be found in Intel Software Developer Manual or in > > > Instruction Set Extensions Programming Reference. See > > >

Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features

On Mon, 2016-10-17 at 09:55 +0200, Thomas Gleixner wrote: > On Sun, 16 Oct 2016, Borislav Petkov wrote: > > > > > > > > The spec can be found in Intel Software Developer Manual or in > > > Instruction Set Extensions Programming Reference. See > > >

Re: [PATCH] cpufreq: intel_pstate: Add Knights Mill CPUID

On Wed, 2016-10-12 at 21:39 +0200, Rafael J. Wysocki wrote: > On Wednesday, October 12, 2016 08:25:50 PM Piotr Luc wrote: > > > > --- > > Depends-on: x86/cpu/intel: Add Knights Mill to Intel family > > https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel > > ! com > > First,

Re: [PATCH] cpufreq: intel_pstate: Add Knights Mill CPUID

On Wed, 2016-10-12 at 21:39 +0200, Rafael J. Wysocki wrote: > On Wednesday, October 12, 2016 08:25:50 PM Piotr Luc wrote: > > > > --- > > Depends-on: x86/cpu/intel: Add Knights Mill to Intel family > > https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel > > ! com > > First,