Re: [PATCH 2/6] module: add support for symbol namespaces.

2018-07-25 Thread Lucas De Marchi
ould do nothing if the symbol doesn't have the suffix. As for dependency on a new version, this seems trivial enough to be backported to previous releases used on distros so even if they are not rolling they would get a compatible depmod. CC'ing linux-modu...@vger.kernel.org to keep track of this the

[ANNOUNCE] kmod 25

2018-01-08 Thread Lucas De Marchi
d override test depmod: module_is_higher_priority: fix modname length calculation Lucas De Marchi (9): test-depmod: avoid warning when we don't have zlib build: add mkosi hooks build: use tool from configure testsuite: generalize mkosi support for other distros

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
d use it to handle dependencies). For this particular case, not going through the modprobe helper would be a way to accomplish that since you wouldn't need the corresponding binfmt module to run modprobe. Udev handles module loading via libkmod , but the only way to trigger it is via the rules rather than via a request from kernel. Lucas De Marchi

Re: [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS

2017-07-19 Thread Lucas De Marchi
> else > bind = ELF64_ST_BIND(info); > > - a[count].crc = crc; > + a[count].crc = kmod_elf_resolve_crc(elf, crc, shndx); > a[count].bind = kmod_symbol_bind_from_elf(bind); > a[count].symbol = itr; > slen = strlen(name); > -- LGTM. I'll give this a try and apply. Do you think it's possible to build an out-of-tree module with this option so we can add one to the testsuite? Lucas De Marchi

[ANNOUNCE] kmod 24

2017-02-23 Thread Lucas De Marchi
Shortlog is below Bartosz Golaszewski (1): module: fix a memory leak James Minor (1): libkmod: Fix handling of quotes in kernel command line Lucas De Marchi (15): libkmod: fix use of strcpy util: fix warning of equal values on logical OR testsuite: include stdio.h

[PATCH v4 0/4] i2c: designware: improve performance for transfers

2016-08-23 Thread Lucas De Marchi
he last patch the bits were changed as suggested by Jarkko. - This is tested on BayTrail and CherryTrail, both of them returning true for "dynamically update TAR" José Roberto de Souza (1): i2c: designware: wait for disable/enable only if necessary Lucas De Marchi (3): i2c:

[PATCH v4 4/4] i2c: designware: do not disable adapter after transfer

2016-08-23 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi

[PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

2016-08-23 Thread Lucas De Marchi
After: 8.638705161 seconds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza <jose.so...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deleti

[PATCH v4 3/4] i2c: designware: detect when dynamic tar update is possible

2016-08-23 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Signed-off-by: José Roberto de Souza <jose.so...@intel.com> --- drivers/i2c/busses/i2c-designware

[PATCH v4 2/4] i2c: designware: add common functions for locking

2016-08-23 Thread Lucas De Marchi
These are used in 2 places and will be needed in more. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-desi

[PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

2016-07-28 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi

[PATCH v3 0/3] i2c: designware: improve performance for transfers

2016-07-28 Thread Lucas De Marchi
2c: designware: wait for disable/enable only if necessary Lucas De Marchi (2): i2c: designware: detect when dynamic tar update is possible i2c: designware: do not disable adapter after transfer drivers/i2c/busses/i2c-designware-core.c | 103 +-- drivers/i2c/busses/i

[PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

2016-07-28 Thread Lucas De Marchi
After: 8.638705161 seconds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza <jose.so...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deleti

[PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

2016-07-28 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Signed-off-by: José Roberto de Souza <jose.so...@intel.com> --- drivers/i2c/busses/i2c-designware

[ANNOUNCE] kmod 23

2016-07-19 Thread Lucas De Marchi
): depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Héctor Orón Martínez (1): kmod: compiling with old sed version (!ERE support) Josh Triplett (1): depmod: Don't insert comment in modules.devname if otherwise empty Lucas De Marchi (8): travis: workaround bug in environment setup

Re: [PATCH] modprobe: install default configuration

2016-06-14 Thread Lucas De Marchi
CC'ing lkml and Rusty to get opinions on this. On Sat, Apr 23, 2016 at 3:18 PM, Lubomir Rintel <lkund...@v3.sk> wrote: > On Wed, 2016-04-13 at 01:11 -0300, Lucas De Marchi wrote: >> On Tue, Mar 29, 2016 at 7:27 AM, Lubomir Rintel <lkund...@v3.sk> >> wrote: >> &

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert <christian.rupp...@alitech.com> wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> <luca

Re: [RFT PATCH] iio: magn: Add support for BMM150 magnetometer

2016-04-27 Thread Lucas De Marchi
, so expect delay on testing this. thanks Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
send an update. Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi <lucas.demar...@intel.com> wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since ea

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
: i2c-transfer-time -w -a 0x40 -x 6 -n 2 -- 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 num_transfers=2 transfer_time_avg=470.256050us Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-18 Thread Lucas De Marchi
LSM9DS0 just a package of LSM303D and L3GD20 that could reuse the drivers already present? Lucas De Marchi

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi <lucas.demar...@intel.com> Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Lucas De Marchi
e in a previous version of the patch. I remember it being fixed in the last version (or at least I could not reproduce). I'll test again tomorrow with your script. Lucas De Marchi

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Lucas De Marchi
n't it be better to use another id? Other than that, I tested it on the MinnowBoard Max with a Drone Lure connected and it works fine. thanks Lucas De Marchi

Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell <ru...@rustcorp.com.au> wrote: > Lucas De Marchi <lucas.de.mar...@gmail.com> writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_

Re: modinfo crc32 broken after fd44a98ae2eb

2016-01-28 Thread Lucas De Marchi
Hi! CC'ing Rusty and mailing lists On Thu, Jan 28, 2016 at 8:40 PM, Samson Yeung <samson.ye...@oracle.com> wrote: > > On 01/28/2016 11:21 AM, Lucas De Marchi wrote: >> >> Hi Samson, >> >> On Wed, Jan 27, 2016 at 5:32 PM, Samson Yeung <samson.ye.

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-26 Thread Lucas De Marchi
his be ti-ads1015 so not to clash with the hwmon driver? > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, ads1015_id); > + > +static struct i2c_driver ads1015_driver = { > + .driver = { > + .name = ADS1015_DRV_NAME, same here, otherwise we will have an i2c:ads1015 alias Lucas De Marchi

[ANNOUNCE] kmod 22

2015-11-17 Thread Lucas De Marchi
requirements modprobe: Update error message when path is missing Change default log level depmod: Remove unprinted debug messages depmod: Don't fall back to uname on bad version Lucas De Marchi (4): Add README.md file with build details libkmod-module: fix return code

Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access

2015-10-30 Thread Lucas De Marchi
tree: 39ce815 pinctrl: baytrail: Serialize all register access 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking The ones to Cherryview could be sent too but I couldn't test them. Leaving the patch below for reference. thanks Lucas De Marchi > drivers/pinctrl/intel/pinctrl-baytrail.c

Re: [PATCH] spi: Force the registration of the spidev devices

2015-07-15 Thread Lucas De Marchi
that support that. ACPI doesn't support overlays (yet) so we need to keep awful external platform drivers[1] just to make spidev to work. -- Lucas De Marchi [1] https://github.com/MinnowBoard/minnow-max-extras/blob/master/modules/low-speed-spidev/low-speed-spidev.c -- To unsubscribe from this list: send

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-23 Thread Lucas De Marchi
On Tue, Jun 23, 2015 at 1:45 PM, christian.rupp...@alitech.com wrote: Hello, Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: Mika Westerberg mika.westerb...@linux.intel.com wrote on 10.06. 2015 09:07:22: On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote: Hi

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-12 Thread Lucas De Marchi
-pm_runtime_disabled) - i2c_dw_init(i_dev); + i2c_dw_enable(i_dev); This will not work if the device power gets removed (for example being put to D3cold) as it looses context. Do you mean we should keep the i2c_dw_init() here? -- Lucas De Marchi -- To unsubscribe from

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-11 Thread Lucas De Marchi
previous versions of this driver. So adding a quirk with correct versions will be difficult IMO. We've been only testing this with well behaved slaves. Do you have any idea how to test the bad guys? Maybe connecting a slave with a long wire to introduce errors? -- Lucas De Marchi

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-09 Thread Lucas De Marchi
...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- These pictures explain a little more the consequence of letting the enable+disable in the code: http://pub.politreco.com/paste/TEK0011-before.jpg http://pub.politreco.com/paste/TEK0007-after.jpg The yellow

[PATCH] i2c: designware: use enable on resume instead initialization

2015-06-08 Thread lucas . de . marchi
with a simple enable, and removes the (non required anymore) enables and disables. Signed-off-by: Fabio Mello fabio.me...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- These pictures explain a little more the consequence of letting the enable+disable in the code: http

Re: [PATCH kmod 3/3] tools: display features together with version information

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr a...@lisas.de wrote: Hi, On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com diff --git a/tools/kmod.c b/tools/kmod.c index c9d2cc8..28217df 100644 --- a/tools/kmod.c +++ b

Re: [PATCH kmod 0/3] Add feature list together with version

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:25 AM, Andreas Mohr a...@lisas.de wrote: Hi, On Sun, Jun 07, 2015 at 03:27:26AM -0300, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com Sample output: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL Thank you

[ANNOUNCE] kmod 21

2015-06-08 Thread Lucas De Marchi
are needed and all of them can run fine. Shortlog: Lucas De Marchi lucas.demar...@intel.com (12): build: use dolt build: sync dolt with upstream util: use UINT64_MAX build: cache modules from playground tools: Hide new commands behind experimental flag

[PATCH kmod 3/3] tools: display features together with version information

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com --- tools/depmod.c | 1 + tools/insmod.c | 1 + tools/kmod.c | 1 + tools/modinfo.c | 1 + tools/modprobe.c | 1 + tools/rmmod.c| 1 + 6 files changed, 6 insertions(+) diff --git a/tools/depmod.c b/tools/depmod.c index 231b9ab..2a08b6e

[PATCH kmod 0/3] Add feature list together with version

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com Sample output: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL Lucas De Marchi (3): build: add function to build string of features build: add relevant features to KMOD_FEATURES in config.h tools: display features together

[PATCH kmod 1/3] build: add function to build string of features

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com Add a CC_FEATURE_APPEND function that we can use to append the features that are enabled/disabled. This will generate a single string in the form +FEATURE1 +FEATURE2 -FEATURE3. --- m4/features.m4 | 48

[PATCH kmod 2/3] build: add relevant features to KMOD_FEATURES in config.h

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com Not all the features (i.e. those available in --enable-* or --with-*) are really relevant to the final user. Create a KMOD_FEATURES definition in config.h containing these features. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-07 Thread Lucas De Marchi
On Thu, Jun 4, 2015 at 5:22 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: + gzip and xz (but doesn't by default, at least as of version 18!). This is pretty much misleading. There's no such a default option. It's like saying kernel

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
On Wed, Jun 3, 2015 at 10:30 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell ru...@rustcorp.com.au wrote: Andreas Mohr a...@lisas.de writes: Hi, I just had a not so nice experience when finally

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
the first version and xz since version 3. So both of them can be safely fall into it's supported since the beginning of kmod IMO. Regarding the default configuration, there's no such thing. Each distribution uses a different one. -- Lucas De Marchi -- To unsubscribe from this list: send the line

Re: [PATCH] modules: CONFIG_MODULE_COMPRESS: add hint that userspace support may easily be missing.

2015-06-03 Thread Lucas De Marchi
On Wed, Jun 3, 2015 at 2:36 PM, Kay Sievers k...@vrfy.org wrote: On Wed, Jun 3, 2015 at 7:30 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: On Mon, Jun 1, 2015 at 3:26 AM, Rusty Russell ru...@rustcorp.com.au wrote: Andreas Mohr a...@lisas.de writes: Hi, I just had a not so nice

Re: modules out of tree issue

2015-04-16 Thread Lucas De Marchi
modules just fine. See https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/tree/testsuite/module-playground/Makefile for an example. Any ideas? I'm not sure is this the right group, sorry. You probably should CC lkml as well. Doing it now. -- Lucas De Marchi -- To unsubscribe from

Re: How to get instance for kallsyms_address or kallsyms_num_syms?

2015-04-09 Thread Lucas De Marchi
Hi Buddy, This question is more for lkml than linux-modules. I'm CC'ing it. -- Lucas De Marchi On Tue, Apr 7, 2015 at 6:48 AM, Buddy buddy.d.zh...@outlook.com wrote: HI: I want to get information for kernel symbol,so I use array of kallsyms_address and value of kallsyms_num_syms.But when

[PATCH] kdbus: fix header guard name

2015-03-17 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com UAPI headers have a _UAPI_ as prefix, which is removed during headers_install. If it's put as a suffix it will not be removed and will be the only header with UAPI in the header guard macro. Signed-off-by: Lucas De Marchi lucas.demar...@intel.com

[PATCH] kdbus: fix header guard name

2015-03-16 Thread lucas . de . marchi
From: Lucas De Marchi lucas.demar...@intel.com UAPI headers have a _UAPI_ as prefix, which is removed during headers_install. If it's put as a suffix it will not be removed and will be the only header with UAPI in the header guard macro. Signed-off-by: Lucas De Marchi lucas.demar...@intel.com

Re: [PATCH] checkpatch: Add optional --codespell dictionary to find more typos

2015-03-05 Thread Lucas De Marchi
Marchi lucas.de.mar...@gmail.com -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: timerfd waking up before timer really expires

2015-03-04 Thread Lucas De Marchi
On Wed, Mar 4, 2015 at 5:06 AM, Clemens Ladisch clem...@ladisch.de wrote: Lucas De Marchi wrote: I was debugging my application and noticed that a timerfd event was being triggered *before* the timer expires. I reduced the scope of the program to test a single timerfd and measure

timerfd waking up before timer really expires

2015-03-03 Thread Lucas De Marchi
for wakeup events with ftrace[1] I also get the same results... the time difference between 2 wakeup events for ~30% of events are shorter the configured interval. I'm currently running with kernel version 3.18.6. Is there anything I'm missing? thanks -- Lucas De Marchi [1] trace-cmd record -F

[ANNOUNCE] kmod 20

2015-03-01 Thread Lucas De Marchi
for -Wflag instead of -Wno-flag Harish Jenny K N harish_kand...@mentor.com (1): Fix race while loading modules Lucas De Marchi lucas.demar...@intel.com (78): NEWS: Fix typos README: move mailing list information to top build-sys: Don't add libkmod subdirectory to include

Re: Differences between builtins and modules

2015-02-28 Thread Lucas De Marchi
On Wed, Feb 25, 2015 at 8:53 AM, Michal Marek mma...@suse.cz wrote: On Tue, Feb 24, 2015 at 10:02:55PM -0300, Lucas De Marchi wrote: On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek mma...@suse.cz wrote: On 2015-02-23 15:30, Lucas De Marchi wrote: My questions are: 1) should we put *all

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-28 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:35 PM, Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com wrote: On Thursday 19 February 2015 07:32 PM, Harish Jenny Kandiga Nagaraj wrote: On Thursday 19 February 2015 06:13 PM, Lucas De Marchi wrote: On Thu, Feb 19, 2015 at 10:32 AM, Harish Jenny Kandiga

Re: Differences between builtins and modules

2015-02-24 Thread Lucas De Marchi
On Mon, Feb 23, 2015 at 12:51 PM, Michal Marek mma...@suse.cz wrote: On 2015-02-23 15:30, Lucas De Marchi wrote: This could be particularly bad if in a kernel version an option was tristate and in a new version it changed to boolean. I'm not sure if this is common to happen in kernel. Any code

Re: Differences between builtins and modules

2015-02-24 Thread Lucas De Marchi
On Tue, Feb 24, 2015 at 8:42 AM, Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com wrote: On Monday 23 February 2015 09:21 PM, Michal Marek wrote: On 2015-02-23 15:30, Lucas De Marchi wrote: Can we add some flag like KMOD_PROBE_FORCE_DIRECTORY_CHECK = 0x00040, and pass

Differences between builtins and modules

2015-02-23 Thread Lucas De Marchi
to do the opposite, but given the race in deciding this I'm favoring the index. thanks -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-19 Thread Lucas De Marchi
the end of this week. -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-19 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 10:32 AM, Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com wrote: On Thursday 19 February 2015 04:00 PM, Lucas De Marchi wrote: On Thu, Feb 19, 2015 at 3:49 AM, Harish Jenny Kandiga Nagaraj harish_kand...@mentor.com wrote: Harrish, in your patch if you just

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Tue, Feb 17, 2015 at 10:56 AM, Harish Jenny K N harish_kand...@mentor.com wrote: usecase: two sd cards are being mounted in parallel at same time on dual core

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:25 AM, greg KH gre...@linuxfoundation.org wrote: On Wed, Feb 18, 2015 at 11:19:14PM -0200, Lucas De Marchi wrote: On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Feb 18, 2015 at 2

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Feb 18, 2015 at 2:07 AM, Rusty Russell ru...@rustcorp.com.au wrote: Yeah, I just thought (an wanted that) the attributes were being created first

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-18 Thread Lucas De Marchi
On Thu, Feb 19, 2015 at 12:25 AM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Feb 18, 2015 at 8:40 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Feb 18, 2015 at 2:07 AM, Rusty

Re: [PATCH] libkmod-module: Remove directory existence check for KMOD_MODULE_BUILTIN

2015-02-17 Thread Lucas De Marchi
the module is builtin. Rusty, was there any changes in this area in the kernel recently? Or is the creation of /sys/module/module and /sys/module/module/initstate not atomic? See patch below. -- Lucas De Marchi Experiments done to prove the issue in kmod. Added sleep in kernel module.c

[ANNOUNCE] kmod 19

2014-11-16 Thread Lucas De Marchi
code for each test. Shortlog is below: Cristian Rodríguez (1): Add missing O_CLOEXEC in kmod_module_get_size() Holger Obermaier (1): libkmod-index.c: Fix error message Lucas De Marchi (35): Update TODO Move macro.h to shared directory Move missing.h

Re: [PATCH 0/3] Implement /proc/built-in file similar to /proc/modules

2014-09-16 Thread Lucas De Marchi
node: /dev/loop-control Type: character device Major: 10 Minor: 237 -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC PATCH 0/2] kmod: Support lockup option to make module un-removable

2014-09-01 Thread Lucas De Marchi
? -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH 4/5] module: Lock up a module when loading with a LOCLUP flag

2014-08-25 Thread Lucas De Marchi
. -- Lucas De Marchi Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com --- include/linux/module.h |6 ++ include/uapi/linux/module.h |1 + kernel/module.c | 28 3 files changed, 27 insertions(+), 8 deletions(-) diff

[ANNOUNCE] kmod 18

2014-06-14 Thread Lucas De Marchi
. Close /sys/module/$NAME directory if opening /proc/module fails. Lucas De Marchi (17): Update .travis.yml Add strndupa to missing.h Make sure there's NUL byte at the end of strndupa testsuite: Add module playground dir Add gitignore to module playground depmod: Make

Re: [PATCH] module: remove warning about waiting module removal.

2014-04-24 Thread Lucas De Marchi
this patch in kernel is sufficient? -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] fix printk output

2014-04-23 Thread Lucas De Marchi
) flag, until it was finally enforced in commit 7ab8804448377fb6b8854f2dd288608db01bb43b Author: Lucas De Marchi lucas.demar...@intel.com Date: Fri Sep 20 01:30:07 2013 -0500 See: tools/modprobe.c at that commit: static int rmmod_do_remove_module(struct kmod_module *mod

[ANNOUNCE] kmod 17

2014-04-06 Thread Lucas De Marchi
setuptools_cython Lucas De Marchi (23): man: Change my contact email address Remove duplicate includes testsuite: add test for kcmdline params with no value testsuite: give a more suitable description to test testsuite: add test to ignore unrelated strings in kcmdline

Re: [PATCH] Revert Bluetooth: Use devname:vhci module alias for virtual HCI driver

2014-03-18 Thread Lucas De Marchi
to catch problems like this and help people doing the drivers. Once I found out the problem with vhci I sent the patch to fix it, which is heading to Linus tree. -- Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/2] misc: add missing minor nodes

2014-02-19 Thread Lucas De Marchi
On Wed, Feb 19, 2014 at 07:46:02PM +, Mark Jackson wrote: On 18/02/14 18:52, Greg Kroah-Hartman wrote: On Tue, Feb 18, 2014 at 02:27:25AM -0300, Lucas De Marchi wrote: From: Lucas De Marchi lucas.demar...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com

[PATCH v2] Bluetooth: allocate static minor for vhci

2014-02-17 Thread Lucas De Marchi
From: Lucas De Marchi lucas.demar...@intel.com Commit bfacbb9 (Bluetooth: Use devname:vhci module alias for virtual HCI driver) added the module alias to hci_vhci module so it's possible to create the /dev/vhci node. However creating an alias without specifying the minor doesn't allow us

[PATCH 0/2] Fix missing misc nodes

2014-02-17 Thread Lucas De Marchi
From: Lucas De Marchi lucas.demar...@intel.com These patches are not intended for merging as is... clearly we have at least one problem: fram's minor is clashing with logibm's. I don't know what to do here. The first patch also adds comments on those minors that are defined but not used

[PATCH 1/2] misc: add comment on unused minors

2014-02-17 Thread Lucas De Marchi
From: Lucas De Marchi lucas.demar...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- include/linux/miscdevice.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h index 7bb6148

[PATCH 2/2] misc: add missing minor nodes

2014-02-17 Thread Lucas De Marchi
From: Lucas De Marchi lucas.demar...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- Documentation/devices.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devices.txt b/Documentation/devices.txt index 04356f5..0ea1cc2 100644 --- a/Documentation

[ANNOUNCE] kmod 16

2013-12-22 Thread Lucas De Marchi
. Lucas De Marchi --- Anders Olofsson (1): build: Allow disabling maintainer mode John Spencer (1): testsuite: fix usage of reserved names Lucas De Marchi (19): Fix usage of readdir_r() build: remove check for typeof util: Add ALIGN_POWER2 libkmod-hash: always align

Re: [PATCH] LSM: ModPin LSM for module loading restrictions

2013-10-22 Thread Lucas De Marchi
the guarantee that the first module to load is any more trustable than the others? Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu herb

Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

2013-09-17 Thread Lucas De Marchi
On Mon, Sep 16, 2013 at 12:47 AM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Thu, Sep 12, 2013 at 9:30 PM, Rusty Russell ru...@rustcorp.com.au wrote: Peter Chen peter.c...@freescale.com writes: Currently, if module's refcount is not zero

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Tue, Sep 17, 2013 at 11:10 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert

Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

2013-09-12 Thread Lucas De Marchi
a 10s delay on module removal. So far nobody complained. Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Lucas De Marchi
to load it as a pre softdep and possibly failing? Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd

2013-09-10 Thread Lucas De Marchi
. Try playing with this in /etc/modprobe.d/bla.conf (and replace echo with whatever unknown command to test a failure scenario): install bla echo install bla remove bla echo remove bla softdep sr_mod pre: bla Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] depmod: warn on invalid devname specification

2013-09-09 Thread Lucas De Marchi
Cc: Lucas De Marchi lucas.demar...@profusion.mobi --- tools/depmod.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/depmod.c b/tools/depmod.c index 985cf3a..5855b2a 100644 --- a/tools/depmod.c +++ b/tools/depmod.c @@ -2120,11 +2120,18 @@ static int

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Lucas De Marchi
the child thread that will do exec. I don't know whether it's a problem with the code or with the name. Same. Agreed Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[ANNOUNCE] kmod 15

2013-08-22 Thread Lucas De Marchi
to the library is kind of an workaround for people doing initrd needing their tools to be statically linked. As usual, shortlog is below. Cheers Lucas De Marchi --- Jan Engelhardt (1): depmod: add missing else clause Lucas De Marchi (15): tools: Do not link dynamically with libkmod Use

Re: [PATCH 0/3] module: Allow parameters without arguments

2013-08-13 Thread Lucas De Marchi
as a wrong token. From a quick look, allowing it in kmod would be as simple as removing a condition check. Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 0/3] module: Allow parameters without arguments

2013-08-13 Thread Lucas De Marchi
On Tue, Aug 13, 2013 at 10:00 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt rost...@goodmis.org wrote: On Tue, 13 Aug 2013 20:34:58 -0300 Lucas De Marchi lucas.de.mar...@gmail.com wrote: so in kcmdline we would have modulename.param

Re: [PATCH 0/3] module: Allow parameters without arguments

2013-08-13 Thread Lucas De Marchi
On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt rost...@goodmis.org wrote: On Tue, 13 Aug 2013 20:34:58 -0300 Lucas De Marchi lucas.de.mar...@gmail.com wrote: so in kcmdline we would have modulename.param instead of modulename.param=1? I guess we need to update kmod then, because currently

Re: [PATCH] depmod: add missing else clause

2013-08-09 Thread Lucas De Marchi
Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [BUG] 3.10.[01] modprobe snd-... hangs

2013-07-16 Thread Lucas De Marchi
files. Dumping indexes now: On my systems, that's snd-seq-dummy, which depends on snd_seq. Which, in fact, is already loaded. Lucas, any clues? I don't think I could help, but we need more data, like the ones above. Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe

Re: [alsa-devel] [BUG] 3.10.[01] modprobe snd-... hangs

2013-07-16 Thread Lucas De Marchi
file. Please note that in this case the proprietary nvidia module was loaded, since I currently onyl have remove access to the machine. The original trace from yesterday happend without the nvidia module ever being loaded. Am Dienstag 16 Juli 2013, 08:42:35 schrieb Lucas De Marchi: On Tue

[ANNOUNCE] kmod 14

2013-07-03 Thread Lucas De Marchi
in this release. Shortlog is below. Cheers Lucas De Marchi --- Chengwei Yang (2): Several minor fixes for documentation Add document for exported enums Jan Luebbe (1): libkmod: Avoid calling syscall() with -1 Johannes Berg (1): modprobe: don't check refcount with remove command

Re: [RFC PATCH] Allow optional module parameters

2013-07-03 Thread Lucas De Marchi
to tell the module loader not to load a module? modprobe.blacklist=modname1,modname2,... is already there, though all the silliness of blacklist applies unless -b is passed (that's the equivalent behavior of udev) Lucas De Marchi -- To unsubscribe from this list: send the line unsubscribe linux-kernel

  1   2   >