[PATCH] MAINTAINERS: update name change for myself

2018-11-21 Thread Luis R. Rodriguez
WIRELESS DRIVER M: Jiri Slaby M: Nick Kossifidis -M: "Luis R. Rodriguez" +M: Luis Chamberlain L: linux-wirel...@vger.kernel.org W: http://wireless.kernel.org/en/users/Drivers/ath5k S: Maintained @@ -5784,7 +5784,7 @@ F:include/uapi/linux/fire

Re: [PATCH 11/11] proc/sched: remove unused sched_time_avg_ms

2018-06-28 Thread Luis R. Rodriguez
On Thu, Jun 28, 2018 at 05:45:14PM +0200, Vincent Guittot wrote: > /proc/sys/kernel/sched_time_avg_ms entry is not used anywhere. > Remove it > > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Kees Cook > Cc: "Luis R. Rodriguez" > Signed-off-by: Vincent Guitto

Re: [PATCH 0/2] Avoid firmware warning in imx-sdma

2018-06-27 Thread Luis R. Rodriguez
On Fri, Jun 22, 2018 at 04:49:49PM +0200, Sebastian Reichel wrote: > Subject: Avoid firmware warning in imx-sdma > > Hi, > > I grabbed the first patch from patchwork from an 2017 patch series. As far as > I > could see, their usecase vanished due to switching to sync FW API (that > already >

Re: bpf-next boot error: KASAN: use-after-free Write in call_usermodehelper_exec_work

2018-06-07 Thread Luis R. Rodriguez
On Thu, Jun 07, 2018 at 09:07:01AM -0700, Alexei Starovoitov wrote: > On Thu, Jun 07, 2018 at 02:19:16PM +0200, Dmitry Vyukov wrote: > > On Mon, Jun 4, 2018 at 10:21 PM, syzbot > > wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:69b450789136 Merge

Re: [PATCH v6 2/5] efi: Add embedded peripheral firmware support

2018-06-06 Thread Luis R. Rodriguez
On Wed, Jun 06, 2018 at 08:39:15PM +0200, Hans de Goede wrote: > On 05-06-18 23:07, Luis R. Rodriguez wrote: > > > +To make request_firmware() fallback to trying EFI embedded firmwares > > > after this, > > > +the driver must set a boolean "efi

[PATCH] Documentation: update firmware loader fallback reference

2018-06-06 Thread Luis R. Rodriguez
The firmware loader has a fallback mechanism, and it now has some proper kdoc, but we forgot to update the Documentation to use the new kdoc. Fix that. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [PATCH v6 2/5] efi: Add embedded peripheral firmware support

2018-06-05 Thread Luis R. Rodriguez
On Fri, Jun 01, 2018 at 02:53:27PM +0200, Hans de Goede wrote: > Just like with PCI options ROMs, which we save in the setup_efi_pci* > functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself > sometimes may contain data which is useful/necessary for peripheral drivers > to have

Re: [PATCH v4 5/8] ima: based on policy require signed firmware (sysfs fallback)

2018-06-01 Thread Luis R. Rodriguez
> > Signed-off-by: Mimi Zohar > Cc: Luis R. Rodriguez > Cc: David Howells > Cc: Matthew Garrett > --- > security/integrity/ima/ima_main.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima_main.c >

Re: [PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-30 Thread Luis R. Rodriguez
On Wed, May 30, 2018 at 10:06:08PM +0200, Greg KH wrote: > On Wed, May 30, 2018 at 09:55:00PM +0200, Luis R. Rodriguez wrote: > > On Wed, May 23, 2018 at 11:35:51PM +0200, Luis R. Rodriguez wrote: > > > On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote: > >

Re: [PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-30 Thread Luis R. Rodriguez
On Wed, May 23, 2018 at 11:35:51PM +0200, Luis R. Rodriguez wrote: > On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote: > > On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote: > > > This is the 3rd iteration for moving PAGE_KERNEL_* fallback

Re: PostgreSQL licensed code on Linux

2018-05-29 Thread Luis R. Rodriguez
On Wed, May 30, 2018 at 02:22:14AM +0300, Andy Shevchenko wrote: > On Wed, May 30, 2018 at 2:12 AM, Luis R. Rodriguez wrote: > > It would seem I did follow up with a v3 patch and Rusty noted that although > > I may be right, its hard to care [0]. But of relevance here

Re: PostgreSQL licensed code on Linux

2018-05-29 Thread Luis R. Rodriguez
It would seem I did follow up with a v3 patch and Rusty noted that although I may be right, its hard to care [0]. But of relevance here is again if one of the MODULE_LICENSE() dual tags should be used or the GPL tag. I'll continue to side recommending with the MODULE_LICENSE("GPL") tag even on

Re: PostgreSQL licensed code on Linux

2018-05-29 Thread Luis R. Rodriguez
On Tue, May 29, 2018 at 05:00:25PM -0400, Kent Overstreet wrote: > On Tue, May 29, 2018 at 04:51:44PM -0400, Theodore Y. Ts'o wrote: > > On Tue, May 29, 2018 at 03:26:43PM -0400, Kent Overstreet wrote: > > > > That seems to indicate that we've had already PostgreSQL licensed code > > > > on > > >

Re: PostgreSQL licensed code on Linux

2018-05-29 Thread Luis R. Rodriguez
On Tue, May 29, 2018 at 03:26:43PM -0400, Kent Overstreet wrote: > On Tue, May 29, 2018 at 12:14:01PM -0700, Luis R. Rodriguez wrote: > > The question over future possible PostgreSQL licensed code on Linux came up > > to me recently. While doing some quick of digging arou

PostgreSQL licensed code on Linux

2018-05-29 Thread Luis R. Rodriguez
The question over future possible PostgreSQL licensed code on Linux came up to me recently. While doing some quick of digging around I found code already under such license it seems: The file drivers/md/bcache/util.c has: cafe563591446 (Kent Overstreet 2013-03-23 16:11:31 -0700 318) /*

Re: [PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-23 Thread Luis R. Rodriguez
On Wed, May 16, 2018 at 06:44:03PM +0200, Luis R. Rodriguez wrote: > On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote: > > This is the 3rd iteration for moving PAGE_KERNEL_* fallback > > definitions into asm-generic headers. Greg asked for a Changelog > >

Re: [PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-16 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 11:55:05AM -0700, Luis R. Rodriguez wrote: > This is the 3rd iteration for moving PAGE_KERNEL_* fallback > definitions into asm-generic headers. Greg asked for a Changelog > for patch iteration changes, its below. > > All these patches have been

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-15 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 07:35:03AM -0300, Mauro Carvalho Chehab wrote: > Hi Fabien, > > Em Mon, 14 May 2018 08:00:37 + > Fabien DESSENNE escreveu: > > > On 07/05/18 17:19, Mauro Carvalho Chehab wrote: > > > Em Mon, 07 May 2018 16:26:08 +0300 > > > Laurent Pinchart

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 10:02:31PM -0400, Mimi Zohar wrote: > On Mon, 2018-05-14 at 19:28 +0000, Luis R. Rodriguez wrote: > > > - CONFIG_IMA_APPRAISE is not fine enough grained. > > > > > > The CONFIG_IMA_APPRAISE_FIRMWARE will be a Kconfig option.  Similar >

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 08:58:12AM -0400, Mimi Zohar wrote: > On Fri, 2018-05-11 at 21:52 +0000, Luis R. Rodriguez wrote: > > diff --git a/drivers/base/firmware_loader/main.c > > b/drivers/base/firmware_loader/main.c > > index eb34089e4299..d7cdf04a8681 100644 &

Re: [PATCH 6/9] firmware: print firmware name on fallback path

2018-05-12 Thread Luis R. Rodriguez
On Sat, May 12, 2018 at 11:03:52AM +0300, Kalle Valo wrote: > (sorry for the delay, this got buried in my inbox) > > "Luis R. Rodriguez" <mcg...@kernel.org> writes: > > > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: > >> Previous

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-11 Thread Luis R. Rodriguez
On Fri, May 11, 2018 at 01:00:26AM -0400, Mimi Zohar wrote: > On Thu, 2018-05-10 at 23:26 +0000, Luis R. Rodriguez wrote: > > On Wed, May 09, 2018 at 10:00:58PM -0400, Mimi Zohar wrote: > > > On Wed, 2018-05-09 at 23:48 +, Luis R. Rodriguez wrote: > > > > On W

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

2018-05-11 Thread Luis R. Rodriguez
On Fri, May 11, 2018 at 03:48:51AM +0100, Al Viro wrote: > On Thu, May 10, 2018 at 11:32:47PM +0000, Luis R. Rodriguez wrote: > > > I think net-next makes sense if Al Viro is OK with that. This way it could > > go > > in regardless of the state of your series, but it

Re: [PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 04:19:09PM -0700, Alexei Starovoitov wrote: > On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote: > > This makes it clearer this code is part of the coredump code, and > > is not an exported generic helper from kernel/umh.c. > > >

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-10 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 10:00:58PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 23:48 +0000, Luis R. Rodriguez wrote: > > On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote: > > > > > > Yes, writing regdb as a micro/mini LSM sounds reasonable.  The LSM &g

[RFC v2 2/4] xfs: add verifier check for symlink with append/immutable flags

2018-05-10 Thread Luis R. Rodriguez
The Linux VFS does not allow a way to set append/immuttable attributes to symlinks, this is just not possible. If this is detected we can correct this with xfs_repair, so inform the user. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/xfs/libxfs/xfs_symlink_remote.c | 5 ++

[RFC v2 0/4] vfs: detect symlink corruption with attributes

2018-05-10 Thread Luis R. Rodriguez
and inform the users of corruption. These filesystems should have their respective filesystem checker tools updated to correct this as well. v1: Sent out a single patch just to ignore the append/immutable attributes set on symlinks. Luis R. Rodriguez (4): vfs: skip extra attributes check on removal

[RFC v2 3/4] ext4: add verifier check for symlink with append/immutable flags

2018-05-10 Thread Luis R. Rodriguez
The Linux VFS does not allow a way to set append/immuttable attributes to symlinks, this is just not possible. If this is detected inform the user as the filesystem must be corrupted. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/ext4/inode.c | 7 +++ 1 file chan

[RFC v2 4/4] btrfs: verify symlinks with append/immutable flags

2018-05-10 Thread Luis R. Rodriguez
The Linux VFS does not allow a way to set append/immuttable attributes to symlinks, this is just not possible. If this is detected inform the user as the filesystem must be corrupted. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/btrfs/inode.c | 9 + 1 file chan

[RFC v2 1/4] vfs: skip extra attributes check on removal for symlinks

2018-05-10 Thread Luis R. Rodriguez
s varies by filesystem for special files, only make a special rule to respect the immutable and append attribute on symlinks. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=152029 Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/namei.c | 24 ++-- 1 file

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 09:48:07PM +0100, Al Viro wrote: > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote: > > > Since we cannot set these attributes we should special-case the > > immutable/append on delete for symlinks, this would be consistent with >

[PATCH v7 01/14] firmware: wrap FW_OPT_* into an enum

2018-05-10 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Reviewed-by: Kees Cook <keesc...@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel

[PATCH v7 03/14] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-10 Thread Luis R. Rodriguez
..@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: small coding style changes] Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/fallback.h | 16 drivers/b

[PATCH v7 02/14] firmware: use () to terminate kernel-doc function names

2018-05-10 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andre...@gmail.com> Reviewed-by: Kees Cook <keesc...@chromium.org> Acked-by: Randy Dunlap <rdun...@infradead.org> Acked-by: Luis R. Rodr

[PATCH v7 05/14] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-10 Thread Luis R. Rodriguez
esc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/Kconfig | 165 ++- 1 file changed, 131 insertions(+), 34 deletions(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 29b0eb452b3a..db2bbe4

[PATCH v7 04/14] firmware_loader: document firmware_sysfs_fallback()

2018-05-10 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Reviewed-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 2

[PATCH v7 07/14] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-10 Thread Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/Kconfig | 155 +-- drivers/base/firmware_loader/Kconfig | 154 ++ 2 files changed, 155 insertions(+), 154 deletions(-) create mode 100644 drivers/base/fir

[PATCH v7 08/14] firmware_loader: make firmware_fallback_sysfs() print more useful

2018-05-10 Thread Luis R. Rodriguez
: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index 9169e7b9800c..b676a99c469c 100644 --- a/

[PATCH v7 06/14] firmware_loader: replace ---help--- with help

2018-05-10 Thread Luis R. Rodriguez
As per checkpatch using help is preferred over ---help---. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index db2bbe483927..0c38df32c7fe

[PATCH v7 10/14] ath10k: use firmware_request_nowarn() to load firmware

2018-05-10 Thread Luis R. Rodriguez
gt; Acked-by: Kalle Valo <kv...@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k

[PATCH v7 14/14] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-10 Thread Luis R. Rodriguez
Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Reviewed-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Reviewed-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mc

[PATCH v7 11/14] ath10k: re-enable the firmware fallback mechanism for testmode

2018-05-10 Thread Luis R. Rodriguez
eeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Reviewed-by: Kees Cook <keesc...@chromium.org> Acked-by: Kalle Valo <kv...@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/net/wire

[PATCH v7 13/14] Documentation: remove stale firmware API reference

2018-05-10 Thread Luis R. Rodriguez
It refers to a pending patch, but this was merged eons ago. Reviewed-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Reviewed-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/dell_rbu.txt | 5 + 1 file ch

[PATCH v7 00/14] firmware_loader changes for v4.18

2018-05-10 Thread Luis R. Rodriguez
fallback mechanism for testmode Luis R. Rodriguez (8): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: replace ---help--- with help firmware_loader: move kconfig FW_LOADER entries to its own file firmware_loader

[PATCH v7 09/14] firmware: add firmware_request_nowarn() - load firmware without warnings

2018-05-10 Thread Luis R. Rodriguez
riguez <andre...@gmail.com> Reviewed-by: Kees Cook <keesc...@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: used the old API calls as the full rename is not done yet, and add the caller for when FW_LOADER is disabled, enhance documentation ] Signed-off-by

[PATCH v7 12/14] Documentation: fix few typos and clarifications for the firmware loader

2018-05-10 Thread Luis R. Rodriguez
Fix a few typos, and clarify a few sentences. Reviewed-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 +

[PATCH v3 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

2018-05-10 Thread Luis R. Rodriguez
Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c and mm/vmalloc.c code have been using PAGE_KERNEL as a fallback for years. Move this fallback to asm-generic. Suggested-by: Matthew Wilcox <wi...@infradead.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org>

[PATCH v3 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

2018-05-10 Thread Luis R. Rodriguez
-generic header. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 14 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/d

[PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-10 Thread Luis R. Rodriguez
he fallback mechanism for PAGE_KERNEL_RO. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide a fallback for PAGE_KERNEL_EXEC for architectures drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 18

Re: [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 08:07:33AM +0200, Greg KH wrote: > On Wed, May 09, 2018 at 06:44:45PM -0700, Luis R. Rodriguez wrote: > > While dusting out the firmware loader closet I spotted a PAGE_KERNEL_* > > fallback hack. This hurts my eyes, and it should also be blinding > >

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 03:33:55PM +, Luis R. Rodriguez wrote: > On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > &g

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

2018-05-10 Thread Luis R. Rodriguez
On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > Hi Luis, > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c > > and mm/vmalloc.c code

[PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

2018-05-09 Thread Luis R. Rodriguez
-by: Matthew Wilcox <wi...@infradead.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- include/asm-generic/pgtable.h | 12 mm/nommu.c| 4 mm/vmalloc.c | 4 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

2018-05-09 Thread Luis R. Rodriguez
love or review. At least 0-day was happy with the changes. Matthew Wilcox did put together a PAGE_KERNEL_RO patch for ia64, that needs review and testing, and if it goes well it should be merged. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide

[PATCH v2 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

2018-05-09 Thread Luis R. Rodriguez
in place on the firmware loader for years. Move the fallback into the respective asm-generic header. Architectures which don't define this yet: o alpha o ia64 o m68k o mips o sparc64 o sparc Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fall

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 02, 2018 at 03:11:13PM +, Luis R. Rodriguez wrote: > On Wed, May 02, 2018 at 12:08:57PM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Sat, Apr 28, 2018 at 2:15 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > > > Some

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

2018-05-09 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 06:39:35PM -0700, Matthew Wilcox wrote: > On Wed, May 09, 2018 at 01:04:38AM +0000, Luis R. Rodriguez wrote: > > On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > > > ia64: Add PAGE_KERNEL_RO and PAGE_KERNEL_EXEC > > > &

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 21:22 +0000, Luis R. Rodriguez wrote: > > > > OK, its still not clear to what it will do. If it does not touch the > > firmware > > loader code, and it just sets and configur

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 03:57:18PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 19:15 +0000, Luis R. Rodriguez wrote: > > > > > > If both are enabled, do we require both signatures or is one enough. > > > > > > > > Good question. Considering

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-09 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote: > On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > + This used to be the default firmware loading facility, and udev > > used > > + to listen for uvents to l

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 11:12:46 -0700 > "Luis R. Rodriguez" <mcg...@kernel.org> escreveu: > > > It refers to a pending patch, but this was merged eons ago. > > Didn't know that

Re: [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni

2018-05-09 Thread Luis R. Rodriguez
On Mon, May 07, 2018 at 07:57:12PM -0400, Waiman Long wrote: > On 05/07/2018 06:39 PM, Luis R. Rodriguez wrote: > > On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote: > >> A user can write arbitrary integer values to msgmni and shmmni sysctl > >> param

Re: [PATCH 13/24] selftests: kmod: return Kselftest Skip code for skipped tests

2018-05-09 Thread Luis R. Rodriguez
ftest framework SKIP code is 4 and the framework prints appropriate > messages to indicate that the test is skipped. > > Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org> Reviewed-by: Luis R. Rodriguez <mcg...@kernel.org> Luis

Re: [PATCH 08/24] selftests: firmware: return Kselftest Skip code for skipped tests

2018-05-09 Thread Luis R. Rodriguez
ped. > > Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org> Reviewed-by: Luis R. Rodriguez <mcg...@kernel.org> Luis > --- > tools/testing/selftests/firmware/fw_fallback.sh | 4 ++-- > tools/testing/selftests/firmware/fw_filesystem.sh | 4 +++- > tools/

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-09 Thread Luis R. Rodriguez
On Wed, May 09, 2018 at 07:30:28AM -0400, Mimi Zohar wrote: > On Tue, 2018-05-08 at 17:34 +0000, Luis R. Rodriguez wrote: > > On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > > > On Fri, 2018-05-04 at 00:07 +, Luis R. Rodriguez wrote: > > > > On T

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

2018-05-08 Thread Luis R. Rodriguez
On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > On Fri, Apr 27, 2018 at 05:15:26PM -0700, Luis R. Rodriguez wrote: > > Some architectures do not define PAGE_KERNEL_RO, best we can do > > for them is to provide a fallback onto PAGE_KERNEL. Remove the > > h

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

2018-05-08 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > On Wed, May 09, 2018 at 12:03:28AM +0000, Luis R. Rodriguez wrote: > > Groovy, thanks, let's not forget the xfs_repair respective fix :) let me > > know > > if you have any feedback on that. > >

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

2018-05-08 Thread Luis R. Rodriguez
On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote: > On Tue, May 01, 2018 at 05:45:12PM +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: > > > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wr

[PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: coding style fixes, merge kdoc with

[PATCH v6 02/13] firmware: use () to terminate kernel-doc function names

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: adjust s

[PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback()

2018-05-08 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_

[PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-08 Thread Luis R. Rodriguez
into the firmware_loader/ directory later. This also now recommends using firmwared [0] for folks left needing a uevent handler in userspace for the sysfs firmware fallback mechanis given udev's uevent firmware mechanism was ripped out a while ago. [0] https://github.com/teg/firmwared Signed-off-by: Luis R

[PATCH v2] mm: expland documentation over __read_mostly

2018-05-08 Thread Luis R. Rodriguez
__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Acked-by: Christoph Lameter <c...@linux.com> Signed-off-by:

[PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-08 Thread Luis R. Rodriguez
This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-08 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 08:39:30AM -0700, Randy Dunlap wrote: > On 05/08/2018 04:23 AM, Matthew Wilcox wrote: > > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: > >> Randy Dunlap wrote: > >> > + * execute a critial path. We should be mindful and

[PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Kalle Valo <kv...@codeaurora.o

[PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode

2018-05-08 Thread Luis R. Rodriguez
eeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Kalle Valo <kv...@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1

[PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful

2018-05-08 Thread Luis R. Rodriguez
with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- d

[PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader

2018-05-08 Thread Luis R. Rodriguez
Fix a few typos, and clarify a few sentences. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-)

[PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings

2018-05-08 Thread Luis R. Rodriguez
riguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: used the old API calls as the full rename is not done yet, and add the caller for when FW_LOADER is disabled, enhance documentation ] Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> ---

[PATCH v6 12/13] Documentation: remove stale firmware API reference

2018-05-08 Thread Luis R. Rodriguez
It refers to a pending patch, but this was merged eons ago. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/dell_rbu.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt index 0fdb6aa2704c..077fdc29a0d0

[PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-08 Thread Luis R. Rodriguez
From: Andres Rodriguez <andre...@gmail.com> This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mc

[PATCH v6 00/13] firmware_loader changes for v4.18

2018-05-08 Thread Luis R. Rodriguez
() to load firmware ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez (7): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: move kconfig FW_LOADER entries to its own file

[PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-08 Thread Luis R. Rodriguez
Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file changed, 6 insertions

Re: [PATCH 00/18] Fix some build warnings/errors with Sphinx

2018-05-08 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 10:13:42AM -0600, Jonathan Corbet wrote: > On Mon, 7 May 2018 06:35:36 -0300 > Mauro Carvalho Chehab wrote: > > > I decided to give a try with Sphinx last stable version > > (1.17.4), and noticed several issues. The worse one was > > with the

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-08 Thread Luis R. Rodriguez
On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > On Fri, 2018-05-04 at 00:07 +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 09:48:20AM -0400, Mimi Zohar wrote: > > > Allow LSMs and IMA to differentiate between signed regulatory.db and &g

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

2018-05-08 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: > On 4 May 2018 at 01:29, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: > [...] > >> diff --git a/Documentation/driver-api/firmware/r

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

2018-05-08 Thread Luis R. Rodriguez
On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > > > A

Re: [PATCH 02/18] docs: fix location of request_firmware & friends

2018-05-08 Thread Luis R. Rodriguez
into its own directory") > Cc: Kees Cook <keesc...@chromium.org> > Cc: Luis R. Rodriguez <mcg...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> > --- > Documentation/dell

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

2018-05-08 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_FALLBACK. > > > > It would be good for us to hear from And

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-08 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 10:43:49AM -0700, Luis R. Rodriguez wrote: > Greg, > > I've reviewed the pending patches for the firmware_laoder and as for > v4.18, the following 3 patches from Andres have been iterated enough > that they're ready after I made some final minor chang

Re: [PATCH 6/9] firmware: print firmware name on fallback path

2018-05-07 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 10:57:26PM -0400, Andres Rodriguez wrote: > On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote: > > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: > > > Previously, one could assume the firmware name from the preceding > > > mes

[PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

2018-05-07 Thread Luis R. Rodriguez
This makes it clearer this code is part of the coredump code, and is not an exported generic helper from kernel/umh.c. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/coredump.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/coredump.c b/fs/core

Re: [PATCH v7 3/4] ipc: Allow boot time extension of IPCMNI from 32k to 2M

2018-05-07 Thread Luis R. Rodriguez
On Mon, May 07, 2018 at 04:59:11PM -0400, Waiman Long wrote: > diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c > index 49f9bf4..d62335f 100644 > --- a/ipc/ipc_sysctl.c > +++ b/ipc/ipc_sysctl.c > @@ -120,7 +120,8 @@ static int proc_ipc_sem_dointvec(struct ctl_table *table, > int write, > static

[PATCH] mm: expland documentation over __read_mostly

2018-05-07 Thread Luis R. Rodriguez
__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- include

Re: [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni

2018-05-07 Thread Luis R. Rodriguez
On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote: > A user can write arbitrary integer values to msgmni and shmmni sysctl > parameters without getting error, but the actual limit is really > IPCMNI (32k). This can mislead users as they think they can get a > value that is not real. > >

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-07 Thread Luis R. Rodriguez
On Wed, May 02, 2018 at 09:36:02PM -0700, Alexei Starovoitov wrote: > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > and user mode helper code that is embedded into bpfilter.ko > > The steps to build bpfilter.ko are the following: > - main.c is compiled by HOSTCC into the

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-07 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 06:37:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 04, 2018 at 07:56:43PM +0000, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these pat

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 09:17:08PM +0200, Krzysztof Halasa wrote: > "Luis R. Rodriguez" <mcg...@kernel.org> writes: > > > * CONFIG_WANXL --> CONFIG_WANXL_BUILD_FIRMWARE > > * CONFIG_SCSI_AIC79XX --> CONFIG_AIC79XX_BUILD_FIRMWARE > > > > T

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-04 Thread Luis R. Rodriguez
What a mighty short list of reviewers. Adding some more. My review below. I'd appreciate a Cc on future versions of these patches. On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); >

  1   2   3   4   5   6   7   8   9   10   >