[PATCH] drivers/staging/wlan-ng/p80211conv.c: fixed a potential memory leak

2017-08-08 Thread Lynn Lei
Fixed a potential memory leak inside skb_ether_to_p80211() When the wep_encrypt() fails the code return 2 directly Which causes the p80211_wep->data dangling Add a kfree statement to reclaim that memory allocated Signed-off-by: Lynn Lei <lynnl@gmail.com> --- driver

[PATCH] drivers/staging/wlan-ng/p80211conv.c: fixed a potential memory leak

2017-08-08 Thread Lynn Lei
Fixed a potential memory leak inside skb_ether_to_p80211() When the wep_encrypt() fails the code return 2 directly Which causes the p80211_wep->data dangling Add a kfree statement to reclaim that memory allocated Signed-off-by: Lynn Lei --- drivers/staging/wlan-ng/p80211con

[PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

2017-07-11 Thread Lynn Lei
Fixed the unenclosed complex values macro issue generated by scripts/checkpatch.pl: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/leds/leds-aat1290.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

2017-07-11 Thread Lynn Lei
Fixed the unenclosed complex values macro issue generated by scripts/checkpatch.pl: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Lynn Lei --- drivers/leds/leds-aat1290.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] video: backlight: pwm_bl.c: make of_device_id structure to const

2017-07-05 Thread Lynn Lei
Fixed a of_device_id structure normally be const warning issue which checked by scripts/checkpatch.pl: WARNING: struct of_device_id should normally be const Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/backlight/pwm_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] video: backlight: pwm_bl.c: make of_device_id structure to const

2017-07-05 Thread Lynn Lei
Fixed a of_device_id structure normally be const warning issue which checked by scripts/checkpatch.pl: WARNING: struct of_device_id should normally be const Signed-off-by: Lynn Lei --- drivers/video/backlight/pwm_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] video: backlight: gpio_backlight.c: make of_device_id structure const

2017-07-05 Thread Lynn Lei
Fixed a of_device_id structure normally be const warning issue checked by scripts/checkpatch.pl: WARNING: struct of_device_id should normally be const Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/backlight/gpio_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] video: backlight: gpio_backlight.c: make of_device_id structure const

2017-07-05 Thread Lynn Lei
Fixed a of_device_id structure normally be const warning issue checked by scripts/checkpatch.pl: WARNING: struct of_device_id should normally be const Signed-off-by: Lynn Lei --- drivers/video/backlight/gpio_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning

2017-07-04 Thread Lynn Lei
Fixed a constant-left comparison warning issue check by scripts/checkpatch.pl: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 3/4] video: fbdev: sm712fb.c: fixed prefer unsigned int warning

2017-07-04 Thread Lynn Lei
Fixed several prefer 'unsigned int' over 'unsigned' warnings checked by scripts/checkpatch.pl: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/fbdev/sm712fb.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning

2017-07-04 Thread Lynn Lei
Fixed a constant-left comparison warning issue check by scripts/checkpatch.pl: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Lynn Lei --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/4] video: fbdev: sm712fb.c: fixed prefer unsigned int warning

2017-07-04 Thread Lynn Lei
Fixed several prefer 'unsigned int' over 'unsigned' warnings checked by scripts/checkpatch.pl: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Lynn Lei --- drivers/video/fbdev/sm712fb.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/video

[PATCH 2/4] video: fbdev: sm712fb.c: fix unaligned block comments warning

2017-07-04 Thread Lynn Lei
Fixed unaligned block comments warning generated by scripts/checkpatch.pl: WARNING: Block comments should align the * on each line Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/fbdev/sm712fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 2/4] video: fbdev: sm712fb.c: fix unaligned block comments warning

2017-07-04 Thread Lynn Lei
Fixed unaligned block comments warning generated by scripts/checkpatch.pl: WARNING: Block comments should align the * on each line Signed-off-by: Lynn Lei --- drivers/video/fbdev/sm712fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/sm712fb.c b

[PATCH 1/4] video: fbdev: sm712fb.c: using __func__ macro for pr_debug

2017-07-04 Thread Lynn Lei
Inside function sm7xx_vga_setup() Using a generic function macro for debug information display Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video

[PATCH 1/4] video: fbdev: sm712fb.c: using __func__ macro for pr_debug

2017-07-04 Thread Lynn Lei
Inside function sm7xx_vga_setup() Using a generic function macro for debug information display Signed-off-by: Lynn Lei --- drivers/video/fbdev/sm712fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index

[PATCH v3] staging: sm750fb: fixed a assignment typo

2017-07-03 Thread Lynn Lei
fixed a typo issue in get_mxclk_freq() function. the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT. both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT defined in drivers/staging/sm750fb/ddk750_reg.h Signed-off-by: Lynn Lei <ly

[PATCH v3] staging: sm750fb: fixed a assignment typo

2017-07-03 Thread Lynn Lei
fixed a typo issue in get_mxclk_freq() function. the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT. both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT defined in drivers/staging/sm750fb/ddk750_reg.h Signed-off-by: Lynn Lei --- v3

[PATCH v2] staging: sm750fb: fixed a assignment typo

2017-07-03 Thread Lynn Lei
fixed a typo issue in get_mxclk_freq(). the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT. both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT defined in drivers/staging/sm750fb/ddk750_reg.h Signed-off-by: Lynn Lei <ly

[PATCH v2] staging: sm750fb: fixed a assignment typo

2017-07-03 Thread Lynn Lei
fixed a typo issue in get_mxclk_freq(). the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT. both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT defined in drivers/staging/sm750fb/ddk750_reg.h Signed-off-by: Lynn Lei --- drivers

[PATCH] staging: sm750fb: skip unnecessary comparisons

2017-07-02 Thread Lynn Lei
introduced early checks to skip unnecessary comparisons when flags set. Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/sm750.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/s

[PATCH] staging: sm750fb: skip unnecessary comparisons

2017-07-02 Thread Lynn Lei
introduced early checks to skip unnecessary comparisons when flags set. Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/sm750.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index

[PATCH] staging: sm750fb: coordinate conditional compilation

2017-07-02 Thread Lynn Lei
coordinate conditional compilation with g_dcftSupportedDviController[] fix exceed-80-characters issue Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/ddk750_dvi.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/s

[PATCH] staging: sm750fb: coordinate conditional compilation

2017-07-02 Thread Lynn Lei
coordinate conditional compilation with g_dcftSupportedDviController[] fix exceed-80-characters issue Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_dvi.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b

[PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

2017-07-02 Thread Lynn Lei
include PANEL_DISPLAY_CTRL_FPVDDEN control mask Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/ddk750_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_dis

[PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

2017-07-02 Thread Lynn Lei
include PANEL_DISPLAY_CTRL_FPVDDEN control mask Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c index 0f666dc2729a

[PATCH] staging: sm750fb: refactor method and fix potential type inconsistence

2017-07-02 Thread Lynn Lei
make reg variable typed `u32' not `unsigned int' this can fix potential type inconsistence in some platforms refactor swPanelPowerSequence() make the code less redundant a early check for disp to skip unnecessary delay Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/s

[PATCH] staging: sm750fb: refactor method and fix potential type inconsistence

2017-07-02 Thread Lynn Lei
make reg variable typed `u32' not `unsigned int' this can fix potential type inconsistence in some platforms refactor swPanelPowerSequence() make the code less redundant a early check for disp to skip unnecessary delay Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_display.c | 36

[PATCH] staging: sm750fb: coordinate tab indent

2017-07-02 Thread Lynn Lei
fixed a tab inconsistence(coordinated with previous if-clause) issue. Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/s

[PATCH] staging: sm750fb: coordinate tab indent

2017-07-02 Thread Lynn Lei
fixed a tab inconsistence(coordinated with previous if-clause) issue. Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index

[PATCH] staging: sm750fb: refactor the clock frequency calculation method

2017-07-02 Thread Lynn Lei
speed up calculation by merging two divisions into one. Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c

[PATCH] staging: sm750fb: refactor the clock frequency calculation method

2017-07-02 Thread Lynn Lei
speed up calculation by merging two divisions into one. Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index c51761221131

[PATCH] staging: sm750fb: fixed a assignment typo

2017-07-01 Thread Lynn Lei
Fixed a typo issue in get_mxclk_freq(). Signed-off-by: Lynn Lei <lynnl@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5e4bfb

[PATCH] staging: sm750fb: fixed a assignment typo

2017-07-01 Thread Lynn Lei
Fixed a typo issue in get_mxclk_freq(). Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5e4bfb601cea..c51761221131 100644