Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

Hi Nicolas On Wed, Dec 21, 2016 at 3:00 PM, Nicolas Saenz Julienne <nicolas.sa...@prodys.net> wrote: > Hi Manish, thanks for the interest. > > On 20/12/16 17:54, Manish Badarkhe wrote: >> Hi Nicola >> > [...] >> >> Just some general comment, Can yo

Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

Hi Nicolas On Wed, Dec 21, 2016 at 3:00 PM, Nicolas Saenz Julienne wrote: > Hi Manish, thanks for the interest. > > On 20/12/16 17:54, Manish Badarkhe wrote: >> Hi Nicola >> > [...] >> >> Just some general comment, Can you add some more properties here t

Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

properties here to know voltage and current? Also, can you add other properties present in charging status register like POWER_FAIL, VOLTAGE_OR, CURRENT_OR etc. Don't know weather it is feasible to add or not and Also, let me know, if it is already been covered in some part of the code. Thanks Manish Badarkhe

Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

other properties present in charging status register like POWER_FAIL, VOLTAGE_OR, CURRENT_OR etc. Don't know weather it is feasible to add or not and Also, let me know, if it is already been covered in some part of the code. Thanks Manish Badarkhe

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

Hi Keerthy, sorry ignore my last two comments in previous mail. On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe <badarkhe.man...@gmail.com> wrote: > Hi Keerthy > > Some minor comment > >> +static int lp873x_gpio_direction_outpu

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

Hi Keerthy, sorry ignore my last two comments in previous mail. On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe wrote: > Hi Keerthy > > Some minor comment > >> +static int lp873x_gpio_direction_output(struct gpio_chip *chip, >> +

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

873->regmap, > + LP873X_REG_GPO_CTRL, > + BIT(offset * 4 + 2), 0); > + default: > + return -ENOTSUPP; > + } > +} Error needs to be return, this function always return 0. Only default returns error here which is unlikely condition. Regards Manish Badarkhe

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

873->regmap, > + LP873X_REG_GPO_CTRL, > + BIT(offset * 4 + 2), 0); > + default: > + return -ENOTSUPP; > + } > +} Error needs to be return, this function always return 0. Only default returns error here which is unlikely condition. Regards Manish Badarkhe

Re: [PATCH v2] thermal: add Intel BXT WhiskeyCove PMIC thermal driver

Hi > +static int pmic_thermal_remove(struct platform_device *pdev) > +{ > + return 0; > +} > + Why this remove function still requires? Regards Manish Badarkhe

Re: [PATCH v2] thermal: add Intel BXT WhiskeyCove PMIC thermal driver

Hi > +static int pmic_thermal_remove(struct platform_device *pdev) > +{ > + return 0; > +} > + Why this remove function still requires? Regards Manish Badarkhe

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

; + > +static int omap_i2c_unreg_slave(struct i2c_client *slave) > +{ > + struct omap_i2c_dev *omap = i2c_get_adapdata(slave->adapter); > + u16 reg; > + > + pm_runtime_put(omap->dev); > + return 0; > +} > +#endif This function always return 0 Regards Manish Badarkhe

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

; + > +static int omap_i2c_unreg_slave(struct i2c_client *slave) > +{ > + struct omap_i2c_dev *omap = i2c_get_adapdata(slave->adapter); > + u16 reg; > + > + pm_runtime_put(omap->dev); > + return 0; > +} > +#endif This function always return 0 Regards Manish Badarkhe

Re: [PATCH] mfd: lp873x: Add lp873x PMIC support

gt; + struct mutex lp873_lock;/* lock guarding the data structure */ > + struct regmap *regmap; > +}; > +#endif /* __LINUX_MFD_LP873X_H */ > -- Regards Manish Badarkhe

Re: [PATCH] mfd: lp873x: Add lp873x PMIC support

gt; + struct mutex lp873_lock;/* lock guarding the data structure */ > + struct regmap *regmap; > +}; > +#endif /* __LINUX_MFD_LP873X_H */ > -- Regards Manish Badarkhe

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

tic int bam_dma_suspend(struct device *dev) >>> +{ >>> + struct bam_device *bdev = dev_get_drvdata(dev); >>> + >>> + pm_runtime_force_suspend(dev); >>> + >>> + clk_unprepare(bdev->bamclk); >>> >>> return 0; >>> } >> >> Why this function simply return 'success' without any error capture? > Same logic applies here as well, as pm_runtime_force_suspend and > clk_unprepare may not return error in our case once probe is through. got it. Regards Manish Badarkhe

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

tic int bam_dma_suspend(struct device *dev) >>> +{ >>> + struct bam_device *bdev = dev_get_drvdata(dev); >>> + >>> + pm_runtime_force_suspend(dev); >>> + >>> + clk_unprepare(bdev->bamclk); >>> >>> return 0; >>> } >> >> Why this function simply return 'success' without any error capture? > Same logic applies here as well, as pm_runtime_force_suspend and > clk_unprepare may not return error in our case once probe is through. got it. Regards Manish Badarkhe

Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

nes would just be TABLE_ENTRY_1 or > whatever. Thanks for the clarification, In that case, comments/documentation will work instead of making any defines. Regards Manish Badarkhe

Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

nes would just be TABLE_ENTRY_1 or > whatever. Thanks for the clarification, In that case, comments/documentation will work instead of making any defines. Regards Manish Badarkhe

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

e *dev) > +{ > + struct bam_device *bdev = dev_get_drvdata(dev); > + > + pm_runtime_force_suspend(dev); > + > + clk_unprepare(bdev->bamclk); > > return 0; > } Why this function simply return 'success' without any error capture? Regards Manish Badarkhe

Re: [PATCH v2 1/2] dmaengine: qcom-bam-dma: Add pm_runtime support

e *dev) > +{ > + struct bam_device *bdev = dev_get_drvdata(dev); > + > + pm_runtime_force_suspend(dev); > + > + clk_unprepare(bdev->bamclk); > > return 0; > } Why this function simply return 'success' without any error capture? Regards Manish Badarkhe

Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

t wm831x_usb_limits[] = { > + 0, > + 2, > + 100, > + 500, > + 900, > + 1500, > + 1800, > + 550, > +}; Just for curiosity, How these current limits are getting decided? Can we have some proper defines over here so that it can be grasped easily? Thanks Manish Badarkhe

Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

_SUPPLY_PROP_VOLTAGE_NOW, > }; > > +/* In milliamps */ > +static const unsigned int wm831x_usb_limits[] = { > + 0, > + 2, > + 100, > + 500, > + 900, > + 1500, > + 1800, > + 550, > +}; Just for curiosity, How these current limits are getting decided? Can we have some proper defines over here so that it can be grasped easily? Thanks Manish Badarkhe

Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT

l_zone_device *zone, int *temp) > +{ > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > + > + *temp = rcar_thermal_get_current_temp(priv); > + > return 0; > } > Above two function, always returns 0. Can it possible to handle error and log some mes

Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT

l_zone_device *zone, int *temp) > +{ > + struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > + > + *temp = rcar_thermal_get_current_temp(priv); > + > return 0; > } > Above two function, always returns 0. Can it possible to handle error and log some mes

Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver

On Tue, Nov 17, 2015 at 11:35 AM, Pankaj Dubey wrote: > This patch moves exynos_sys_powerdown_conf function above all > static functions, to avoid confusion causing due to mixing of > static-nonstatic-static functions and to improve readability of this > driver. > > Signed-off-by: Pankaj Dubey >

Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver

On Tue, Nov 17, 2015 at 11:35 AM, Pankaj Dubey wrote: > This patch moves exynos_sys_powerdown_conf function above all > static functions, to avoid confusion causing due to mixing of > static-nonstatic-static functions and to improve readability of this > driver. > >

Re: [PATCH] regulator: tps65218: Remove '.owner' field

Hi Mark, On Sun, Nov 9, 2014 at 2:49 PM, Mark Brown wrote: > On Sat, Nov 08, 2014 at 05:42:52PM +0530, Manish Badarkhe wrote: >> Remove '.owner' field of driver structure as it is >> going to be filled via "module_platform_driver" call. > > Same question as ever wi

Re: [PATCH] regulator: tps65218: Remove '.owner' field

Hi Mark, On Sun, Nov 9, 2014 at 2:49 PM, Mark Brown broo...@kernel.org wrote: On Sat, Nov 08, 2014 at 05:42:52PM +0530, Manish Badarkhe wrote: Remove '.owner' field of driver structure as it is going to be filled via module_platform_driver call. Same question as ever with this stuff

[PATCH] regulator: tps65218: Remove '.owner' field

Remove '.owner' field of driver structure as it is going to be filled via "module_platform_driver" call. Signed-off-by: Manish Badarkhe --- :100644 100644 f0a4028... e2b97ac... M drivers/regulator/tps65218-regulator.c drivers/regulator/tps65218-regulator.c |1 - 1 file changed,

[PATCH] regulator: tps65218: Remove '.owner' field

Remove '.owner' field of driver structure as it is going to be filled via module_platform_driver call. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 f0a4028... e2b97ac... M drivers/regulator/tps65218-regulator.c drivers/regulator/tps65218-regulator.c |1 - 1

Re: [PATCH V4] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Hi Dmitry, On Tue, Feb 11, 2014 at 10:15 PM, Manish Badarkhe wrote: > Hi Dmitry, > > On Tue, Jan 28, 2014 at 10:24 PM, Manish Badarkhe > wrote: >> Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" >> option for DT code to avoid if-deffery i

Re: [PATCH V4] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Hi Dmitry, On Tue, Feb 11, 2014 at 10:15 PM, Manish Badarkhe badarkhe.man...@gmail.com wrote: Hi Dmitry, On Tue, Jan 28, 2014 at 10:24 PM, Manish Badarkhe badarkhe.man...@gmail.com wrote: Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code

[PATCH] video: da8xx-fb: Use "SIMPLE_DEV_PM_OPS" macro

Update driver to use SIMPLE_DEV_PM_OPS macro for power management suspend and resume operations. Signed-off-by: Manish Badarkhe --- :100644 100644 a1d74dd... 0c0ba92... M drivers/video/da8xx-fb.c drivers/video/da8xx-fb.c | 22 ++ 1 file changed, 10 insertions(+), 12

[PATCH] video: da8xx-fb: Use SIMPLE_DEV_PM_OPS macro

Update driver to use SIMPLE_DEV_PM_OPS macro for power management suspend and resume operations. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 a1d74dd... 0c0ba92... M drivers/video/da8xx-fb.c drivers/video/da8xx-fb.c | 22 ++ 1 file changed

Re: [PATCH V4] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Hi Dmitry, On Tue, Jan 28, 2014 at 10:24 PM, Manish Badarkhe wrote: > Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" > option for DT code to avoid if-deffery in code. > > Signed-off-by: Manish Badarkhe > --- > Changes since V1: > 1.Updated

Re: [PATCH V4] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Hi Dmitry, On Tue, Jan 28, 2014 at 10:24 PM, Manish Badarkhe badarkhe.man...@gmail.com wrote: Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1.Updated code

[PATCH V2] regulator: tps6507x: Use "IS_ENABLED" for DT code.

Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Also, modify code as per coding style. Signed-off-by: Manish Badarkhe --- Changes since V1: 1. fix build break when CONFIG_OF is not set. :100644 100644 162a0fa... 8

[PATCH] regulator: tps6507x: Use "IS_ENABLED" for DT code.

Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Also, modify code as per coding style. Signed-off-by: Manish Badarkhe --- :100644 100644 162a0fa... 97868b7... M drivers/regulator/tps6507x-regulator.c driver

[PATCH] regulator: tps6507x: Use IS_ENABLED for DT code.

Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Also, modify code as per coding style. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 162a0fa... 97868b7... M drivers/regulator/tps6507x-regulator.c drivers

[PATCH V2] regulator: tps6507x: Use IS_ENABLED for DT code.

Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Also, modify code as per coding style. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. fix build break when CONFIG_OF is not set. :100644 100644 162a0fa

Re: [PATCH V4 0/2] devm_* API operation for fixed regulator

Hi Mark, On Wed, Jan 29, 2014 at 8:27 PM, Manish Badarkhe wrote: > Use devm_* API operations for fixed regulator driver so that > driver core will manage resources. > > Also, introduce a new API "devm_kstrdup" and used it in fixed > regulator driver to manage resour

Re: [PATCH V4 0/2] devm_* API operation for fixed regulator

Hi Mark, On Wed, Jan 29, 2014 at 8:27 PM, Manish Badarkhe badarkhe.man...@gmail.com wrote: Use devm_* API operations for fixed regulator driver so that driver core will manage resources. Also, introduce a new API devm_kstrdup and used it in fixed regulator driver to manage resources

[PATCH V4 0/2] devm_* API operation for fixed regulator

ed driver to use "devm_kzalloc" instead of "kstrdup". 2. Updated commit message. Manish Badarkhe (2): devres: introduce API "devm_kstrdup" regulator: fixed: update to devm_* API drivers/base/devres.c | 26 ++ drivers/regulator/fixe

[PATCH V4 2/2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe --- :100644 100644 5ea64b9... 3c307d6... M drivers/regulator/fixed.c drivers/regulator/fixed.c | 42 -- 1 file changed, 12 insertions(+), 30

[PATCH V4 1/2] devres: introduce API "devm_kstrdup"

This patch introduces "devm_kstrdup" API so that the device's driver can allocate memory and copy string. Signed-off-by: Manish Badarkhe --- :100644 100644 545c4de... db4e264... M drivers/base/devres.c :100644 100644 952b010... ec1b6e2... M include/linux/device.h drivers/base/devres

Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

Hi Mark, On Wed, Jan 29, 2014 at 5:10 PM, Mark Brown wrote: > On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote: >> On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches wrote: > >> >> + buf = devm_kzalloc(dev, size, gfp); > >> > If this is reall

Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

Hi Joe, Thank you for your review. On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches wrote: > On Wed, 2014-01-29 at 09:33 +0530, Manish Badarkhe wrote: >> This patch introduces "devm_kstrdup" API so that the >> device's driver can allocate memory and copy string. > []

Re: [PATCH V3 1/2] devres: introduce API devm_kstrdup

Hi Joe, Thank you for your review. On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches j...@perches.com wrote: On Wed, 2014-01-29 at 09:33 +0530, Manish Badarkhe wrote: This patch introduces devm_kstrdup API so that the device's driver can allocate memory and copy string. [] diff --git a/drivers

Re: [PATCH V3 1/2] devres: introduce API devm_kstrdup

Hi Mark, On Wed, Jan 29, 2014 at 5:10 PM, Mark Brown broo...@kernel.org wrote: On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote: On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches j...@perches.com wrote: + buf = devm_kzalloc(dev, size, gfp); If this is really necessary

[PATCH V4 1/2] devres: introduce API devm_kstrdup

This patch introduces devm_kstrdup API so that the device's driver can allocate memory and copy string. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 545c4de... db4e264... M drivers/base/devres.c :100644 100644 952b010... ec1b6e2... M include/linux/device.h

[PATCH V4 0/2] devm_* API operation for fixed regulator

instead of devm_kzalloc. Changes since V2: 1. Update driver to use new API devm_kstrdup instead of kstrdup. 2. Added a seperate patch to introduce new API devm_kstrdup Changes since V1: 1. Updated driver to use devm_kzalloc instead of kstrdup. 2. Updated commit message. Manish Badarkhe

[PATCH V4 2/2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 5ea64b9... 3c307d6... M drivers/regulator/fixed.c drivers/regulator/fixed.c | 42 -- 1 file changed

[PATCH V3 0/2] devm_* API operation for fixed regulator

of "kstrdup". 2. Added a seperate patch to introduce new API "devm_kstrdup" Changes since V1: 1. Updated driver to use "devm_kzalloc" instead of "kstrdup". 2. Updated commit message. Manish Badarkhe (2): devres: introduce API "devm_kstrdup&

[PATCH V3 1/2] devres: introduce API "devm_kstrdup"

This patch introduces "devm_kstrdup" API so that the device's driver can allocate memory and copy string. Signed-off-by: Manish Badarkhe --- :100644 100644 545c4de... 6e88a3d... M drivers/base/devres.c :100644 100644 952b010... 8fee649... M include/linux/device.h drivers/base/devres

[PATCH V3 2/2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe --- :100644 100644 5ea64b9... 1d42613... M drivers/regulator/fixed.c drivers/regulator/fixed.c | 44 ++-- 1 file changed, 14 insertions(+), 30

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Mark, On Tue, Jan 28, 2014 at 4:15 PM, Mark Brown wrote: > On Tue, Jan 28, 2014 at 02:31:32PM +0530, Manish Badarkhe wrote: >> On Tue, Jan 28, 2014 at 2:25 PM, Heiko Stübner wrote: > >> > I don't have a strong opinion on this and others are most likely more >&g

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Stephan, On Tue, Jan 28, 2014 at 10:11 PM, Stephen Warren wrote: > On 01/27/2014 08:12 PM, Manish Badarkhe wrote: >> Update the code to use devm_* API so that driver core will manage >> resources. > > I'm not sure why this patch is sent to linux-te...@vger.kernel.org; it

[PATCH V4] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- Changes since V1: 1.Updated code to use "IS_ENABLED" during retrieval of platform/DT data. Changes since V2: 1.Update

Re: [PATCH V3] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Hi Tomasz, On Tue, Jan 28, 2014 at 5:21 PM, Tomasz Figa wrote: > Hi, > > > On 27.01.2014 19:37, Manish Badarkhe wrote: >> >> Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" >> option for DT code to avoid if-deffery in code. >> >

Re: [PATCH V2] regulator: fixed: update to devm_* API

On Tue, Jan 28, 2014 at 2:25 PM, Heiko Stübner wrote: > On Tuesday, 28. January 2014 14:16:39 Manish Badarkhe wrote: >> Hi Heiko >> >> Thank you for your reply. >> >> On Tue, Jan 28, 2014 at 1:08 PM, Heiko Stübner wrote: >> > On Tuesday, 28. January 201

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Heiko Thank you for your reply. On Tue, Jan 28, 2014 at 1:08 PM, Heiko Stübner wrote: > On Tuesday, 28. January 2014 12:46:01 Manish Badarkhe wrote: >> Hi Dmitry, >> >> Thank you for your review. >> >> On Tue, Jan 28, 2014 at 12:03 PM, Dmitry Toro

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Heiko Thank you for your reply. On Tue, Jan 28, 2014 at 1:08 PM, Heiko Stübner he...@sntech.de wrote: On Tuesday, 28. January 2014 12:46:01 Manish Badarkhe wrote: Hi Dmitry, Thank you for your review. On Tue, Jan 28, 2014 at 12:03 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote

Re: [PATCH V2] regulator: fixed: update to devm_* API

On Tue, Jan 28, 2014 at 2:25 PM, Heiko Stübner he...@sntech.de wrote: On Tuesday, 28. January 2014 14:16:39 Manish Badarkhe wrote: Hi Heiko Thank you for your reply. On Tue, Jan 28, 2014 at 1:08 PM, Heiko Stübner he...@sntech.de wrote: On Tuesday, 28. January 2014 12:46:01 Manish Badarkhe

Re: [PATCH V3] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Hi Tomasz, On Tue, Jan 28, 2014 at 5:21 PM, Tomasz Figa t.f...@samsung.com wrote: Hi, On 27.01.2014 19:37, Manish Badarkhe wrote: Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com

[PATCH V4] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1.Updated code to use IS_ENABLED during retrieval of platform/DT data. Changes since V2: 1.Updated code as per

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Stephan, On Tue, Jan 28, 2014 at 10:11 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 01/27/2014 08:12 PM, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. I'm not sure why this patch is sent to linux-te...@vger.kernel.org; it seems

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Mark, On Tue, Jan 28, 2014 at 4:15 PM, Mark Brown broo...@kernel.org wrote: On Tue, Jan 28, 2014 at 02:31:32PM +0530, Manish Badarkhe wrote: On Tue, Jan 28, 2014 at 2:25 PM, Heiko Stübner he...@sntech.de wrote: I don't have a strong opinion on this and others are most likely more

[PATCH V3 2/2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 5ea64b9... 1d42613... M drivers/regulator/fixed.c drivers/regulator/fixed.c | 44 ++-- 1 file

[PATCH V3 1/2] devres: introduce API devm_kstrdup

This patch introduces devm_kstrdup API so that the device's driver can allocate memory and copy string. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 545c4de... 6e88a3d... M drivers/base/devres.c :100644 100644 952b010... 8fee649... M include/linux/device.h

[PATCH V3 0/2] devm_* API operation for fixed regulator

a seperate patch to introduce new API devm_kstrdup Changes since V1: 1. Updated driver to use devm_kzalloc instead of kstrdup. 2. Updated commit message. Manish Badarkhe (2): devres: introduce API devm_kstrdup regulator: fixed: update to devm_* API drivers/base/devres.c | 26

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Dmitry, Thank you for your review. On Tue, Jan 28, 2014 at 12:03 PM, Dmitry Torokhov wrote: > Hi Manish, > > On Tue, Jan 28, 2014 at 08:42:00AM +0530, Manish Badarkhe wrote: >> Update the code to use devm_* API so that driver core will manage >> resources. >&g

[PATCH V2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe --- Changes since V1: 1. Updated driver to use "devm_kzalloc" to "kstrdup". 2. Updated commit message. Not tested on any board. :100644 100644 5ea64b9... e9763a4...

[PATCH V3] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- :100644 100644 b4513f2... 3e54476... M drivers/power/max8925_power.c drivers/power/max8925_power.c | 17 + 1 file c

[PATCH V3] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 b4513f2... 3e54476... M drivers/power/max8925_power.c drivers/power/max8925_power.c | 17 + 1 file

[PATCH V2] regulator: fixed: update to devm_* API

Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. Updated driver to use devm_kzalloc to kstrdup. 2. Updated commit message. Not tested on any board. :100644 100644 5ea64b9... e9763a4

Re: [PATCH V2] regulator: fixed: update to devm_* API

Hi Dmitry, Thank you for your review. On Tue, Jan 28, 2014 at 12:03 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Tue, Jan 28, 2014 at 08:42:00AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off

Re: [PATCH] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

M, Tomasz Figa wrote: >>> > On 26.01.2014 22:45, Dmitry Torokhov wrote: >>> >> >>> >> On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: >>> >>> >>> >>> Hi Tomasz, >>> >>> &g

Re: [PATCH] regulator: fixed: Use devm_regulator_register

Hi On Mon, Jan 27, 2014 at 5:33 AM, Mark Brown wrote: > On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: >> On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: > >> > Use "devm_regulator_register" instead of "regulator_regi

[PATCH V2] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Instead of "#ifdef CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- Changes since V1: 1. update code to retrieve platform/dt data in same function :100644 100644 b4513f2... 20a7100... M drivers/p

Re: [PATCH] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa wrote: > > Hi Manish, > > > On 26.01.2014 08:15, Manish Badarkhe wrote: >> >> Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" >> option

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code

[PATCH V2] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. update code to retrieve platform/dt data in same function :100644 100644 b4513f2... 20a7100... M drivers/power

Re: [PATCH] regulator: fixed: Use devm_regulator_register

Hi On Mon, Jan 27, 2014 at 5:33 AM, Mark Brown broo...@kernel.org wrote: On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote

[PATCH] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- :100644 100644 b4513f2... d353fbc... M drivers/power/max8925_power.c drivers/power/max8925_power.c | 14 +

[PATCH] regulator: fixed: Use devm_regulator_register

Use "devm_regulator_register" instead of "regulator_register" which simplifies the code. Signed-off-by: Manish Badarkhe --- :100644 100644 5ea64b9... 6d32341... M drivers/regulator/fixed.c drivers/regulator/fixed.c |4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH] regulator: fixed: Use devm_regulator_register

Use devm_regulator_register instead of regulator_register which simplifies the code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 5ea64b9... 6d32341... M drivers/regulator/fixed.c drivers/regulator/fixed.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 b4513f2... d353fbc... M drivers/power/max8925_power.c drivers/power/max8925_power.c | 14 +- 1 file

Re: [PATCH] mfd: max8997: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Hi Samuel, On Sun, Dec 22, 2013 at 11:18 PM, Manish Badarkhe wrote: > > Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" > option for DT code to avoid if-deffery in code. > > Signed-off-by: Manish Badarkhe > --- > :100644 100644 791ae

Re: [PATCH] mfd: max8997: Use IS_ENABLED(CONFIG_OF) for DT code.

Hi Samuel, On Sun, Dec 22, 2013 at 11:18 PM, Manish Badarkhe badarkhe.man...@gmail.com wrote: Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 791aea3

[PATCH] mfd: max8997: Use "IS_ENABLED(CONFIG_OF)" for DT code.

Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- :100644 100644 791aea3... be9a8b0... M drivers/mfd/max8997.c drivers/mfd/max8997.c | 14 ++ 1 file changed,

[PATCH] mfd: max8997: Use IS_ENABLED(CONFIG_OF) for DT code.

Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 791aea3... be9a8b0... M drivers/mfd/max8997.c drivers/mfd/max8997.c | 14 ++ 1 file changed, 2

Re: [PATCH 3/4] Regulators: TPS65218: Add Regulator driver for TPS65218 PMIC

> + return PTR_ERR(rdev); > + } > + > + /* Save regulator */ > + tps->rdev[id] = rdev; > + > + return 0; > +} Best Regards Manish Badarkhe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 3/4] Regulators: TPS65218: Add Regulator driver for TPS65218 PMIC

(rdev); + } + + /* Save regulator */ + tps-rdev[id] = rdev; + + return 0; +} Best Regards Manish Badarkhe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

Hi Mark, Apologize for my late reply. On Thu, Oct 24, 2013 at 10:57 PM, Mark Rutland wrote: > > On Thu, Oct 24, 2013 at 06:05:53PM +0100, Manish Badarkhe wrote: > > Hi Mark, > > > > Thank you for your reply. > > > > On Wed, Oct 23, 2013 at 10:15 PM, Mark Rut

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

Hi Mark, Apologize for my late reply. On Thu, Oct 24, 2013 at 10:57 PM, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Oct 24, 2013 at 06:05:53PM +0100, Manish Badarkhe wrote: Hi Mark, Thank you for your reply. On Wed, Oct 23, 2013 at 10:15 PM, Mark Rutland mark.rutl...@arm.com

[PATCH V4 1/2] tps6507x-ts: Add DT support

Add device tree based support for TI's tps6507x touchscreen. Signed-off-by: Manish Badarkhe --- Changes since V3: - Rebased on top of Dmitry's changes - Removed error handling for optional DT properties Changes since V2: - Removed unnecessary code. - Updated Documentation to provide proper

[PATCH V4 0/2] Add DT support for tps6507x touchscreen

message. - return proper error value in absence platform and DT data for touchscreen. Manish Badarkhe (2): tps6507x-ts: Add DT support ARM: davinci: da850: add tps6507x touchscreen DT data Documentation/devicetree/bindings/mfd/tps6507x.txt | 24 +- arch/arm/boot/dts/da850-evm.dts

[PATCH V4 2/2] ARM: davinci: da850: add tps6507x touchscreen DT data

Add tps6507x touchscreen DT node to da850-evm. Touchscreen DT data is added as per da850 board file. Signed-off-by: Manish Badarkhe --- Changes since V3: - Removed vref property. Changes since V2: - Updated tps6507x documentation. - Removed unnecessary code. Changes since V1: - Updated

[PATCH V4 2/2] ARM: davinci: da850: add tps6507x touchscreen DT data

Add tps6507x touchscreen DT node to da850-evm. Touchscreen DT data is added as per da850 board file. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V3: - Removed vref property. Changes since V2: - Updated tps6507x documentation. - Removed unnecessary code. Changes

  1   2   >