Re: [PATCH v3 2/4] drivers/irqchip: Add Actions external interrupts support

2018-12-07 Thread Marc Zyngier
On 26/11/2018 10:03, Parthiban Nallathambi wrote: > Actions Semi Owl family SoC's S500, S700 and S900 provides support > for 3 external interrupt controllers through SIRQ pins. > > Each line can be independently configured as interrupt and triggers > on either of the edges (raising or falling) or

Re: [RFC PATCH v3 3/4] irqchip: gic-v3: Add quirk for msm8996 secured registers

2018-12-07 Thread Marc Zyngier
On 12/11/2018 10:33, Srinivas Kandagatla wrote: > Access to GICR_WAKER is restricted on msm8996 SoC in Hypervisor. > Its been more than 2+ years of wait for this to be fixed, which has > no hopes to be fixed. This change was introduced for the "lead device" > on msm8996 platform. It looks like all

Re: [RFC PATCH v3 4/4] arm64: dts: add msm8996 compatible to gicv3

2018-12-07 Thread Marc Zyngier
On 12/11/2018 10:33, Srinivas Kandagatla wrote: > Signed-off-by: Srinivas Kandagatla Please write a commit log. M. > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi >

Re: [PATCH 2/3] irqchip: stm32: protect configuration registers with hwspinlock

2018-12-07 Thread Marc Zyngier
On 13/11/2018 14:48, Benjamin Gaignard wrote: > If a hwspinlock is defined in device tree use it to protect > configuration registers. > > Signed-off-by: Benjamin Gaignard > --- > drivers/irqchip/irq-stm32-exti.c | 36 ++-- > 1 file changed, 30 insertions(+), 6

Re: [PATCH 0/5] i.MX8MQ support for GPCv2 irqchip driver

2018-12-07 Thread Marc Zyngier
On 06/12/2018 07:31, Andrey Smirnov wrote: > Everyone: > > This series is 4 trivial (and optional) changes and a patch to add > support for i.MX8MQ to GPCv2 irqchip driver. Bingings for new GPC > variant were taken from [gpcv2-imx8mq]. Hopefully all of the patches > are self-explanatory. > >

Re: [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor

2018-12-07 Thread Marc Zyngier
On 22/11/2018 03:10, k...@linuxonhyperv.com wrote: > From: Michael Kelley > > Add ARM64-specific code to enable Hyper-V. This code includes: > * Detecting Hyper-V and initializing the guest/Hyper-V interface > * Setting up Hyper-V's synthetic clocks > * Making hypercalls using the HVC

Re: [PATCH v2 2/5] genirq: Export irq_chip_set_wake_parent()

2018-12-06 Thread Marc Zyngier
omains. >> >> Signed-off-by: Thierry Reding > > Tglx/Marc: is this change OK? (ACK?) It looks OK to me, as it is consistent with irq_chip_set_type_parent, among others. Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...

Re: [PATCH v2 00/10] irqdomain, gic-v3-its: Implement late irq domain initialization

2018-12-05 Thread Marc Zyngier
On 05/12/2018 12:50, Richter, Robert wrote: > Marc, > > do you have any comments on this series? Please take a look at it. It is on my list of stuff to review. Slowly getting there. Thanks, M. -- Jazz is not dead. It just smells funny...

Re: [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge()

2018-12-02 Thread Marc Zyngier
intainers (Thomas, Marc). I'm fine with that patch, with the provision that (nitpick) the edge field is turned into a bool instead of an int. With that, Acked-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible.

Re: [RFC PATCH v3 3/4] irqchip: gic-v3: Add quirk for msm8996 secured registers

2018-11-28 Thread Marc Zyngier
Bjorn, On Wed, 28 Nov 2018 23:33:27 +, Bjorn Andersson wrote: > > On Mon 12 Nov 02:33 PST 2018, Srinivas Kandagatla wrote: > > > Access to GICR_WAKER is restricted on msm8996 SoC in Hypervisor. > > Its been more than 2+ years of wait for this to be fixed, which has > > no hopes to be

Re: [PATCH 09/17] irqchip: bcm283x: Switch to SPDX identifier

2018-11-23 Thread Marc Zyngier
he License, or >> - * (at your option) any later version. >> - * >> - * This program is distributed in the hope that it will be useful, >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See t

Re: [PATCH v2 1/1] arm64: Early boot time stamps

2018-11-22 Thread Marc Zyngier
On Wed, 21 Nov 2018 17:58:41 +, Pavel Tatashin wrote: > > On 18-11-21 17:47:07, Will Deacon wrote: > > > + /* > > > + * The arm64 boot protocol mandates that CNTFRQ_EL0 reflects > > > + * the timer frequency. To avoid breakage on misconfigured > > > + * systems, do not register the early

[PATCH 1/2] scripts/decodecode: Set ARCH when running natively on arm/arm64

2018-11-22 Thread Marc Zyngier
when it is not set and that we're running on an arm/arm64 system. Signed-off-by: Marc Zyngier --- scripts/decodecode | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/decodecode b/scripts/decodecode index 9cef558528aa..ba8b8d5834e6 100755 --- a/scripts/decodecode +++ b/scripts

[PATCH 2/2] scripts/decode_stacktrace: Only strip base path when a prefix of the path

2018-11-22 Thread Marc Zyngier
41) which doesn't help further processing. Fix it by only stripping the base path if it is a prefix of the path. Signed-off-by: Marc Zyngier --- scripts/decode_stacktrace.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrac

[PATCH 0/2] scripts/decode{code,_stacktrace} fixes

2018-11-22 Thread Marc Zyngier
affects everyone. Marc Zyngier (2): scripts/decodecode: Set ARCH when running natively on arm/arm64 scripts/decode_stacktrace: Only strip base path when a prefix of the path scripts/decode_stacktrace.sh | 2 +- scripts/decodecode | 7 +++ 2 files changed, 8 insertions(+), 1

Re: [PATCH v2 08/15] irqchip: Add RDA8810PL interrupt driver

2018-11-21 Thread Marc Zyngier
On 21/11/2018 03:36, Manivannan Sadhasivam wrote: > Add interrupt driver for RDA Micro RDA8810PL SoC. > > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/mach-rda/Kconfig | 1 + > drivers/irqchip/Kconfig| 4 ++ > drivers/irqchip/Makefile

Re: WARN_ON after gic_reserve_range

2018-11-20 Thread Marc Zyngier
On 20/11/2018 17:30, John Garry wrote: > On 20/11/2018 16:23, Jan Glauber wrote: >> Hi Marc, >> >> with 4.20-rc3 I see two WARN_ON's firing on a ThunderX2 system that come from >> commit 3fb68faee867 (irqchip/gic-v3-its: Register LPI tables with EFI config >> table). >> >> Global

Re: WARN_ON after gic_reserve_range

2018-11-20 Thread Marc Zyngier
[+ Ard] Hi Jan, On 20/11/2018 16:23, Jan Glauber wrote: > Hi Marc, > > with 4.20-rc3 I see two WARN_ON's firing on a ThunderX2 system that come from > commit 3fb68faee867 (irqchip/gic-v3-its: Register LPI tables with EFI config > table). > > Global efi_memreserve_root is NULL as it will only

Re: [PATCH v1 1/1] arm64: Early boot time stamps

2018-11-20 Thread Marc Zyngier
On 20/11/2018 14:40, Pavel Tatashin wrote: >>> +static __init void sched_clock_early_init(void) >>> +{ >>> + u64 freq = arch_timer_get_cntfrq(); >>> + u64 (*read_time)(void) = arch_counter_get_cntvct; >> >> We already have arch_timer_read_counter which is exposed from >> arm_arch_timer.h.

Re: [PATCH v1 1/1] arm64: Early boot time stamps

2018-11-20 Thread Marc Zyngier
Hi Pavel, On 19/11/2018 21:44, Pavel Tatashin wrote: > Allow printk time stamps/sched_clock() to be available from the early > boot. > > Signed-off-by: Pavel Tatashin > --- > arch/arm64/kernel/setup.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On 20/11/2018 08:56, Linus Walleij wrote: > On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > >> How does this change anything with the fact that the above code is >> broken? 56 or 64 bit, you cannot read this counter with a single >> access, or two. The

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On Tue, 20 Nov 2018 05:06:50 +, Manivannan Sadhasivam wrote: > > Hi Marc, > > On Mon, Nov 19, 2018 at 05:57:12PM +, Marc Zyngier wrote: > > On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > > > Add clock driver for RDA Micro RDA8810PL SoC supportin

Re: [PATCH 09/16] irqchip: Add RDA8810PL interrupt driver

2018-11-20 Thread Marc Zyngier
[dropping the @rdamicro.com addresses, as they bounce...] On Tue, 20 Nov 2018 03:19:58 +, Manivannan Sadhasivam wrote: > > Hi Marc, > > Thanks for the quick review! > > On Mon, Nov 19, 2018 at 05:36:49PM +, Marc Zyngier wrote: > > Manivannan, > > >

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Marc Zyngier
On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. > > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/mach-rda/Kconfig | 1 + > drivers/clocksource/Kconfig | 7

Re: [PATCH 09/16] irqchip: Add RDA8810PL interrupt driver

2018-11-19 Thread Marc Zyngier
Manivannan, On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > Add interrupt driver for RDA Micro RDA8810PL SoC. > > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/mach-rda/Kconfig | 1 + > drivers/irqchip/Kconfig| 4 ++ >

Re: [PATCH] ARM: smp_twd: Remove legacy TWD registration

2018-11-19 Thread Marc Zyngier
h implies OF, TIMER_OF, and COMMON_CLK. > > Hence remove all unused legacy infrastructure from the driver. > > Signed-off-by: Geert Uytterhoeven Good cleanup! Acked-by: Marc Zyngier Thanks, M. -- Jazz is not dead. It just smells funny...

Re: [PATCH] kvm: arm/arm64 : fix vm's hanging at startup time

2018-11-19 Thread Marc Zyngier
On 19/11/2018 09:10, Mark Rutland wrote: > On Sat, Nov 17, 2018 at 10:58:37AM +0800, peng.h...@zte.com.cn wrote: >>> On 16/11/18 00:23, peng.h...@zte.com.cn wrote: > Hi, >> When virtual machine starts, hang up. > > I take it you mean the *guest* hangs? Because it doesn't get a

Re: [PATCH] kvm: arm/arm64 : fix vm's hanging at startup time

2018-11-19 Thread Marc Zyngier
On 19/11/2018 09:10, Mark Rutland wrote: > On Sat, Nov 17, 2018 at 10:58:37AM +0800, peng.h...@zte.com.cn wrote: >>> On 16/11/18 00:23, peng.h...@zte.com.cn wrote: > Hi, >> When virtual machine starts, hang up. > > I take it you mean the *guest* hangs? Because it doesn't get a

Re: [PATCH v2 2/3] drivers/irqchip: Add Actions external interrupts support

2018-11-13 Thread Marc Zyngier
On Mon, 12 Nov 2018 10:32:51 +, Parthiban Nallathambi wrote: > > > > On 11/8/18 6:03 PM, Marc Zyngier wrote: > > On 26/08/18 16:20, Parthiban Nallathambi wrote: > >> Hello Marc, > >> > >> Thanks for your feedback. > >> > >>

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-12 Thread Marc Zyngier
On Fri, 09 Nov 2018 18:41:03 +, Qian Cai wrote: > > > > > On Nov 9, 2018, at 12:41 PM, Marc Zyngier wrote: > > > > On 09/11/18 17:28, Sudeep Holla wrote: > >> On Fri, Nov 9, 2018 at 4:10 PM Marc Zyngier wrote: > >>> > >> [

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-09 Thread Marc Zyngier
On 09/11/18 17:28, Sudeep Holla wrote: > On Fri, Nov 9, 2018 at 4:10 PM Marc Zyngier wrote: >> > [...] > >> >> See bb42ca474010 and d003d029cea8 for details. >> >> Now, activating this workaround leads to lockdep being really angry, >> most likely b

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-09 Thread Marc Zyngier
On 09/11/18 15:52, Qian Cai wrote: > > >> On Nov 9, 2018, at 10:38 AM, Marc Zyngier wrote: >> >> On 09/11/18 15:28, Qian Cai wrote: >>> >>> >>>> On Nov 9, 2018, at 8:50 AM, Marc Zyngier wrote: >>>> >>>> On 09/11/1

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-09 Thread Marc Zyngier
On 09/11/18 15:28, Qian Cai wrote: > > >> On Nov 9, 2018, at 8:50 AM, Marc Zyngier wrote: >> >> On 09/11/18 12:28, Qian Cai wrote: >>> >>> On 11/9/18 at 7:08 AM, Marc Zyngier wrote: >>> >>>> [+Ard] >>>> >>>>

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-09 Thread Marc Zyngier
On 09/11/18 12:28, Qian Cai wrote: > > On 11/9/18 at 7:08 AM, Marc Zyngier wrote: > >> [+Ard] >> >> On 08/11/18 20:59, Qian Cai wrote: >>> Just booting up the latest git master (b00d209) on an aarch64 server and saw >>> this. Not sure

Re: WARNING: CPU: 0 PID: 0 at drivers/irqchip/irq-gic-v3-its.c

2018-11-09 Thread Marc Zyngier
[+Ard] On 08/11/18 20:59, Qian Cai wrote: > Just booting up the latest git master (b00d209) on an aarch64 server and saw > this. Not sure about the third warning (at kernel/cpu.c:315 > lockdep_assert_cpus_held+0x50/0x60) relates to irqchip or not, but appended it > to here anyway just in case. >

Re: [PATCH v2 2/3] drivers/irqchip: Add Actions external interrupts support

2018-11-08 Thread Marc Zyngier
On 26/08/18 16:20, Parthiban Nallathambi wrote: > Hello Marc, > > Thanks for your feedback. > > On 8/13/18 1:46 PM, Marc Zyngier wrote: >> On 12/08/18 13:22, Parthiban Nallathambi wrote: >>> Actions Semi Owl family SoC's S500, S700 and S900 provides suppor

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-11-05 Thread Marc Zyngier
On 05/11/18 16:20, Lokesh Vutla wrote: > Hi Marc, > > On Monday 05 November 2018 09:06 PM, Marc Zyngier wrote: >> On 05/11/18 08:08, Lokesh Vutla wrote: >>> Hi Marc, >>> >>> On Monday 29 October 2018 06:34 PM, Lokesh Vutla wrote: >>>> Hi Ma

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-11-05 Thread Marc Zyngier
On 05/11/18 08:08, Lokesh Vutla wrote: > Hi Marc, > > On Monday 29 October 2018 06:34 PM, Lokesh Vutla wrote: >> Hi Marc, >> >> On Sunday 28 October 2018 07:01 PM, Marc Zyngier wrote: >>> Hi Lokesh, >>> >>> On Fri, 26 Oct 2018 21:1

Re: [PATCH] iov_iter: Fix 9p virtio breakage

2018-11-03 Thread Marc Zyngier
On Fri, 02 Nov 2018 19:04:33 +, Al Viro wrote: > > On Fri, Nov 02, 2018 at 05:16:51PM +, Marc Zyngier wrote: > > When switching to the new iovec accessors, a negation got subtly > > dropped, leading to 9p being remarkably broken (here with kvmtool): > > > &g

[PATCH v2] iov_iter: Fix 9p virtio breakage

2018-11-03 Thread Marc Zyngier
- not syncing: Requested init /virt/init failed (error -8). ]--- Restoring the missing "!" brings the guest back to life. Fixes: 00e23707442a ("iov_iter: Use accessor function") Reported-by: Will Deacon Acked-by: Al Viro Signed-off-by: Marc Zyngier --- Reposting with Al's ack,

[PATCH] iov_iter: Fix 9p virtio breakage

2018-11-02 Thread Marc Zyngier
- not syncing: Requested init /virt/init failed (error -8). ]--- Restoring the missing "!" brings the guest back to life. Fixes: 00e23707442a ("iov_iter: Use accessor function") Reported-by: Will Deacon Signed-off-by: Marc Zyngier --- net/9p/trans_virtio.c | 2 +- 1 file change

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-11-01 Thread Marc Zyngier
On 31/10/18 20:33, Grygorii Strashko wrote: > > > On 10/31/18 1:21 PM, Marc Zyngier wrote: >> Hi Grygorii, >> >> On 31/10/18 16:39, Grygorii Strashko wrote: >> >> [...] >> >>> I'd try to provide some additional information here. >>>

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-11-01 Thread Marc Zyngier
On Thu, 01 Nov 2018 07:55:12 +, Peter Ujfalusi wrote: > > Lokesh, > > On 10/29/18 3:04 PM, Lokesh Vutla wrote: > >>> With the above information, linux should send a message to > >>> system-controller using TISCI protocol. After policing the given > >>> information, system-controller does

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-31 Thread Marc Zyngier
On 31/10/18 18:38, Santosh Shilimkar wrote: > On 10/31/2018 11:21 AM, Marc Zyngier wrote: >> Hi Grygorii, >> > > [...] > >> >> Well, I'm convinced that we do not want a networking driver to be tied >> to an interrupt architecture, and that the two shoul

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-31 Thread Marc Zyngier
Hi Grygorii, On 31/10/18 16:39, Grygorii Strashko wrote: [...] > I'd try to provide some additional information here. > (Sry, I'll still use term "events") > > As Lokesh explained in other mail on K3 SoC everything is generic and most > of resources allocated dynamicaly: > - generic DMA

[PATCH v2] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-31 Thread Marc Zyngier
cpumask that gets allocated, giving the driver a chance to actually work with things like irqbalance as well as have a hypothetical 64bit future. Cc: sta...@vger.kernel.org Acked-by: Santosh Shilimkar Signed-off-by: Marc Zyngier --- * From v1: - Added Santosh's Ack - Cc stable - Directly

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Marc Zyngier
On 30/10/18 17:02, Florian Fainelli wrote: > On 10/30/18 4:11 AM, Marc Zyngier wrote: >> The Keystone QMSS driver is pretty damaged, in the sense that it >> does things like this: >> >> irq_set_affinity_hint(irq, to_cpumask(_map)); >> >> where c

[PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Marc Zyngier
cpumask that gets allocated, giving the driver a chance to actually work with things like irqbalance as well as have a hypothetical 64bit future. Signed-off-by: Marc Zyngier --- I found this one by inspection after finding a similar bug in an unrelated driver. It is only compile-tested. It would

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-28 Thread Marc Zyngier
Hi Lokesh, On Fri, 26 Oct 2018 21:19:41 +0100, Lokesh Vutla wrote: > > Hi Marc, > > [..snip..] > >> [...] > >> > > +/** > > + * ti_sci_inta_register_event() - Register a event to an interrupt > > aggregator > > + * @dev: Device pointer to source generating the event >

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-23 Thread Marc Zyngier
Hi Lokesh, On Mon, 22 Oct 2018 15:35:41 +0100, Lokesh Vutla wrote: > > Hi Marc, > > On Friday 19 October 2018 08:52 PM, Marc Zyngier wrote: > > Hi Lokesh, > > > > On 18/10/18 16:40, Lokesh Vutla wrote: > >> Texas Instruments' K3 generation SoCs ha

Re: [RESEND PATCH v3 3/3] sh: add the sh_ prefix to early platform symbols

2018-10-23 Thread Marc Zyngier
Hi Bartosz, On Mon, 27 Aug 2018 10:06:51 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Old early platform device support is now sh-specific. Before moving on > to implementing new early platform framework based on real platform > devices, prefix all early platform

Re: [PATCH v2 00/10] Add support for TISCI irqchip drivers

2018-10-23 Thread Marc Zyngier
On Tue, 23 Oct 2018 09:17:56 +0100, Lokesh Vutla wrote: > > Hi Santosh, > > On Tuesday 23 October 2018 02:09 AM, Santosh Shilimkar wrote: > > On 10/18/2018 8:40 AM, Lokesh Vutla wrote: > >> TISCI abstracts the handling of IRQ routes where interrupt sources > >> are not directly connected to

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-22 Thread Marc Zyngier
On Fri, 19 Oct 2018 20:47:12 +0100, Lina Iyer wrote: > > On Fri, Oct 19 2018 at 09:53 -0600, Marc Zyngier wrote: > > Hi Lina, > > > > On 19/10/18 16:32, Lina Iyer wrote: > >> Hi folks, > >> > >> On Wed, Oct 10 2018 at 18:30 -0600, Lina

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-19 Thread Marc Zyngier
Hi Lina, On 19/10/18 16:32, Lina Iyer wrote: > Hi folks, > > On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: >> QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on >> domain can wakeup the SoC, when interrupts and GPIOs are routed to its >> interrupt controller. Only

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-19 Thread Marc Zyngier
Hi Lokesh, On 18/10/18 16:40, Lokesh Vutla wrote: > Texas Instruments' K3 generation SoCs has an IP Interrupt Aggregator > which is an interrupt controller that does the following: > - Converts events to interrupts that can be understood by > an interrupt router. > - Allows for multiplexing of

Re: [PATCH 3/4] irqchip/mbigen: add support for a MBIGEN generating SPIs

2018-10-18 Thread Marc Zyngier
Hi Hanjun, On 18/10/18 12:20, Hanjun Guo wrote: > Hi Marc, > > Now, the biggest question of them all: how does it work with ACPI? Last time I checked, there was no DT support for platforms using the MBIGEN. >>>

Re: [PATCH 3/4] irqchip/mbigen: add support for a MBIGEN generating SPIs

2018-10-18 Thread Marc Zyngier
Hi Yang, On 18/10/18 04:41, Yang Yingliang wrote: > Hi, Marc > > On 2018/10/18 0:30, Marc Zyngier wrote: >> On 16/10/18 10:15, Yang Yingliang wrote: >>> Now with >>> 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an >>&

Re: [PATCH 3/4] irqchip/mbigen: add support for a MBIGEN generating SPIs

2018-10-17 Thread Marc Zyngier
On 16/10/18 10:15, Yang Yingliang wrote: > Now with > 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI > controller"), > we can support MBIGEN to generate message based SPIs by writing GICD_SETSPIR. > > The first 64-pins of each MBIGEN chip is used to generate SPIs,

Re: [PATCH V13 0/4] C-SKY(csky) Linux Intc Driver

2018-10-17 Thread Marc Zyngier
Hi Guo, On 17/10/18 02:55, Guo Ren wrote: > Hi Marc, > > On Tue, Oct 16, 2018 at 03:41:05PM +0100, Marc Zyngier wrote: >> Guo, >> >> On 16/10/18 15:08, Guo Ren wrote: >>> This is about 13th patchset for C-SKY linux intc drivers and it should pair >>

Re: [PATCH 2/2] irqchip: add driver for imx-irqsteer controller

2018-10-16 Thread Marc Zyngier
Hi Lucas, On 16/10/18 17:42, Lucas Stach wrote: > The irqsteer block is a interrupt multiplexer/remapper found on the > i.MX8 line of SoCs. > > Signed-off-by: Fugang Duan > Signed-off-by: Lucas Stach > --- > This submission is a heavily cleaned up version of the downstream driver. > --- >

Re: [PATCH V13 0/4] C-SKY(csky) Linux Intc Driver

2018-10-16 Thread Marc Zyngier
I haven't seen a clear indication that the rest of the architecture code is going to be merged for 4.20. If the arch code is actually being merged for 4.20, then please add my: Reviewed-by: Marc Zyngier to these 4 patches, and get the whole thing merged in one go. Thanks, M. -- Jazz is not dead. It just smells funny...

Re: [PATCH V8 16/21] csky: SMP support

2018-10-12 Thread Marc Zyngier
t; - Bugfix request_irq with IPI_IRQ, we must use irq_mapping return value >not directly use IPI_IRQ. The modification also involves csky_mp_intc. > > Signed-off-by: Guo Ren > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: Peter Zijlstra > --- > arc

Re: [PATCH v3 1/5] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-10 Thread Marc Zyngier
On 09/10/18 18:07, Lina Iyer wrote: On Tue, Oct 02 2018 at 11:06 -0600, Lina Iyer wrote: Marc, I am exploring an option where we don't do this enable/disable every suspend/resume and in that process, I was able to just use the PDC interrupt instead of the TLMM for triggering the GPIO. The PDC

Re: [PATCH V11 1/8] irqchip: add C-SKY SMP interrupt controller

2018-10-09 Thread Marc Zyngier
irq balance in SMP Signed-off-by: Guo Ren Cc: Marc Zyngier [...] +/* C-SKY multi processor interrupt controller */ +static int __init +csky_mpintc_init(struct device_node *node, struct device_node *parent) +{ + unsigned int cpu, nr_irq; + int ret; + + if (pa

Re: [PATCH 0/9] Implement wake event support on Tegra186 and later

2018-10-09 Thread Marc Zyngier
On Mon, 08 Oct 2018 08:14:53 +0100, Stephen Boyd wrote: > > Quoting Lina Iyer (2018-09-25 10:16:05) > > Thanks Linus, for bringing this to my attention. > > > > Hi Thierry, > > > > On Tue, Sep 25 2018 at 03:57 -0600, Thierry Reding wrote: > > >On Tue, Sep 25, 2018 at 10:48:39AM +0200, Linus

Re: [PATCH V10 1/8] irqchip: add C-SKY SMP interrupt controller

2018-10-09 Thread Marc Zyngier
On 09/10/18 03:24, Guo Ren wrote: Hi Marc, On Mon, Oct 08, 2018 at 05:35:19PM +0100, Marc Zyngier wrote: Hi Guo, On 04/10/18 18:22, Guo Ren wrote: - Irq-csky-mpintc is C-SKY smp system interrupt controller and it could support 16 soft irqs, 16 private irqs, and 992 max common irqs

Re: [PATCH V10 1/8] irqchip: add C-SKY SMP interrupt controller

2018-10-08 Thread Marc Zyngier
Hi Guo, On 04/10/18 18:22, Guo Ren wrote: - Irq-csky-mpintc is C-SKY smp system interrupt controller and it could support 16 soft irqs, 16 private irqs, and 992 max common irqs. Changelog: - pass checkpatch.pl - Move IPI_IRQ into the driver - Remove irq_set_default_host() and

Re: [PATCH 1/2] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2018-10-08 Thread Marc Zyngier
On 08/10/18 10:46, Lokesh Vutla wrote: Hi Marc, On Saturday 06 October 2018 03:32 PM, Marc Zyngier wrote: On Sat, 06 Oct 2018 08:28:11 +0100, Lokesh Vutla wrote: Add the DT binding documentation for Interrupt router driver. Signed-off-by: Lokesh Vutla --- .../interrupt-controller/ti

Re: [PATCH 4/7] clocksource: arch_timer: Add support for not-fw-configured timer on ARM64

2018-10-08 Thread Marc Zyngier
+ Mark Rutland Hi Marek, On 08/10/18 13:50, Marek Szyprowski wrote: Use common infrastructure for ARM Architected Timers erratum to enable support for systems with broken CPU firmware (timer registers not properly configured). This mode has been already availabled on ARM (32bits) architecture.

Re: [PATCH 2/2] irqchip: ti-sci-intr: Add support for Interrupt Router driver

2018-10-08 Thread Marc Zyngier
Hi Lokesh, On 08/10/18 10:48, Lokesh Vutla wrote: Hi Marc, On 10/6/2018 3:25 PM, Marc Zyngier wrote: Hi Lokesh, On Sat, 06 Oct 2018 08:28:12 +0100, Lokesh Vutla wrote: Texas Instruments' K3 generation SoCs has an IP Interrupt Router that does allows for multiplexing of input interrupts

Re: linux-next: build failure after merge of the irqchip tree

2018-10-08 Thread Marc Zyngier
Hi Stephen, On Mon, 08 Oct 2018 04:06:21 +0100, Stephen Rothwell wrote: > > [1 ] > Hi Marc, > > After merging the irqchip tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from drivers/irqchip/irq-madera.c:21: > include/linux/irqchip/irq-madera.h:

Re: [GIT PULL] irqchip updates for 4.20

2018-10-06 Thread Marc Zyngier
Hi Thomas, On Sat, 06 Oct 2018 14:53:01 +0100, Thomas Gleixner wrote: > > Marc, > > On Fri, 5 Oct 2018, Marc Zyngier wrote: > > Here's the set of irqchip updates for 4.20. On the menu this time, > > support for the Marvell SEI and Cirrus Logic Madera interrupt

Re: [PATCH 1/2] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2018-10-06 Thread Marc Zyngier
On Sat, 06 Oct 2018 08:28:11 +0100, Lokesh Vutla wrote: > > Add the DT binding documentation for Interrupt router driver. > > Signed-off-by: Lokesh Vutla > --- > .../interrupt-controller/ti,sci-intr.txt | 83 +++ > MAINTAINERS | 1 + > 2

Re: [PATCH 2/2] irqchip: ti-sci-intr: Add support for Interrupt Router driver

2018-10-06 Thread Marc Zyngier
Hi Lokesh, On Sat, 06 Oct 2018 08:28:12 +0100, Lokesh Vutla wrote: > > Texas Instruments' K3 generation SoCs has an IP Interrupt Router > that does allows for multiplexing of input interrupts to host > interrupt controller. Interrupt Router inputs are either from a > peripheral or from an

Re: [PATCH] irqchip/gic-v3-its: Add early memory allocation errata

2018-10-05 Thread Marc Zyngier
On Fri, 05 Oct 2018 15:13:48 +0100, Matthias Brugger wrote: > > > > On 05/10/2018 15:42, Marc Zyngier wrote: > > On 05/10/18 13:33, Matthias Brugger wrote: > >> > >> > >> On 05/10/2018 12:55, Marc Zyngier wrote: > >>> Hi Matthi

Re: [PATCH] irqchip/gic-v3-its: Add early memory allocation errata

2018-10-05 Thread Marc Zyngier
On 05/10/18 13:33, Matthias Brugger wrote: On 05/10/2018 12:55, Marc Zyngier wrote: Hi Matthias, On 04/10/18 23:11, Matthias Brugger wrote: Friendly reminder, if anyone has any comment on the patch :) On 9/12/18 11:52 AM, matthias@kernel.org wrote: From: Matthias Brugger Some

[GIT PULL] irqchip updates for 4.20

2018-10-05 Thread Marc Zyngier
): irqchip/pdc: Setup all edge interrupts as rising edge at GIC Marc Zyngier (11): irqchip/gic-v3-its: Change initialization ordering for LPIs irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage irqchip/gic-v3-its: Split property table clearing from allocation irqchip/gic-v3

Re: [PATCH] irqchip/gic-v3-its: Add early memory allocation errata

2018-10-05 Thread Marc Zyngier
Hi Matthias, On 04/10/18 23:11, Matthias Brugger wrote: Friendly reminder, if anyone has any comment on the patch :) On 9/12/18 11:52 AM, matthias@kernel.org wrote: From: Matthias Brugger Some hardware does not implement two-level page tables so that the amount of contigious memory

Re: [PATCH v5 19/27] irqchip/gic-v3: Remove acknowledge loop

2018-10-03 Thread Marc Zyngier
to be raised. Tested-by: Daniel Thompson Signed-off-by: Julien Thierry Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v3.c | 65 +--- 1 file changed, 31 insertions(+), 34 deletions(-) It would probably be valuable

Re: [PATCH v5 08/27] irqchip/gic: Unify GIC priority definitions

2018-10-03 Thread Marc Zyngier
Gleixner Cc: Jason Cooper Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 2 +- include/linux/irqchip/arm-gic-common.h | 6 ++ include/linux/irqchip/arm-gic.h| 5 - 3 files changed, 7 insertions(+), 6 deletions(-) I've cherry-picked this for 4.20, as this is a good

Re: [PATCH] arm64: arch_timer: avoid unused function warning

2018-10-03 Thread Marc Zyngier
: Add workaround for ARM erratum 1188873") Signed-off-by: Arnd Bergmann Acked-by: Marc Zyngier Thanks, M. -- Jazz is not dead. It just smells funny...

Re: [PATCH 0/2] arm64: remove some extra semicolon

2018-10-01 Thread Marc Zyngier
On 01/10/18 14:40, Catalin Marinas wrote: On Mon, Sep 03, 2018 at 05:59:35PM +0100, Will Deacon wrote: On Thu, Aug 09, 2018 at 10:20:39PM +0800, zhong jiang wrote: There are some extra semicolon in arm64 architecture. Just remove them. These are trivial but certainly not urgent, so I guess

Re: [RFC v2 3/7] irqchip/rtl8186: Add RTL8186 interrupt controller driver

2018-10-01 Thread Marc Zyngier
/Realtek_RTL8186 Signed-off-by: Yasha Cherikovsky Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Cc: Rob Herring Cc: Mark Rutland Cc: linux-m...@linux-mips.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/irqchip

[tip:irq/core] genirq/debugfs: Reinstate full OF path for domain name

2018-10-01 Thread tip-bot for Marc Zyngier
Commit-ID: 94967b55ebf3b603f2fe750ecedd896042585a1c Gitweb: https://git.kernel.org/tip/94967b55ebf3b603f2fe750ecedd896042585a1c Author: Marc Zyngier AuthorDate: Mon, 1 Oct 2018 11:05:22 +0100 Committer: Thomas Gleixner CommitDate: Mon, 1 Oct 2018 12:24:53 +0200 genirq/debugfs

[tip:irq/core] genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file

2018-10-01 Thread tip-bot for Marc Zyngier
Commit-ID: 513145ea66af95f1a5c744d7b5a4f4a97625e669 Gitweb: https://git.kernel.org/tip/513145ea66af95f1a5c744d7b5a4f4a97625e669 Author: Marc Zyngier AuthorDate: Mon, 1 Oct 2018 11:05:21 +0100 Committer: Thomas Gleixner CommitDate: Mon, 1 Oct 2018 12:24:53 +0200 genirq/debugfs: Reset

[PATCH 0/2] irqdomain debufs fixes for 4.20

2018-10-01 Thread Marc Zyngier
Here's a couple of fixes for the irqdomain debugfs feature that I wrote while working on some unrelated irqchip over the weekend. If nobody screams, I'll queue them for 4.20. Thanks, M. Marc Zyngier (2): genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file

[PATCH 1/2] genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file

2018-10-01 Thread Marc Zyngier
file). This doesn't have any impact other than making debug more difficult, but we do value ease of debugging... So let's clear the debugfs_file field. Signed-off-by: Marc Zyngier --- kernel/irq/irqdomain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/irqdomain.c b/kernel/irq

[PATCH 2/2] genirq/debugfs: Reinstate full OF path for domain name

2018-10-01 Thread Marc Zyngier
ight thing. Fixes: a7e4cfb0a7ca ("of/fdt: only store the device node basename in full_name") Signed-off-by: Marc Zyngier --- kernel/irq/irqdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 95a0acbdd4e6.

Re: [RFC 5/5] MIPS: Add Realtek RTL8186 SoC support

2018-10-01 Thread Marc Zyngier
On 01/10/18 09:48, Yasha Cherikovsky wrote: Hi Marc, On Mon, 2018-10-01 at 09:19 +0100, Marc Zyngier wrote: Hi Yasha, On 30/09/18 15:15, Yasha Cherikovsky wrote: The Realtek RTL8186 SoC is a MIPS based SoC used in some home routers [1][2]. The hardware includes Lexra LX5280 CPU with a TLB

Re: [RFC 5/5] MIPS: Add Realtek RTL8186 SoC support

2018-10-01 Thread Marc Zyngier
Burton Cc: James Hogan Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Cc: Daniel Lezcano Cc: Rob Herring Cc: Mark Rutland Cc: linux-m...@linux-mips.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- arch/mips/Kbuild.platforms| 1 + arch/mips

Re: [PATCH v2 2/2] PCI: controller: dwc: add UniPhier PCIe host controller support

2018-09-28 Thread Marc Zyngier
On 28/09/18 12:06, Lorenzo Pieralisi wrote: [+Murali, Marc] On Thu, Sep 27, 2018 at 04:44:26PM +0900, Kunihiko Hayashi wrote: Hi Lorenzo, Gustavo, On Wed, 26 Sep 2018 21:31:36 +0900 wrote: Hi Lorenzo, Gustavo, Thank you for reviewing. On Tue, 25 Sep 2018 18:53:01 +0100 Gustavo Pimentel

Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC

2018-09-28 Thread Marc Zyngier
On 27/09/18 18:18, Lina Iyer wrote: The PDC irqchp can convert a falling edge or level low interrupt to a rising edge or level high interrupt at the GIC. We just need to setup the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH as IRQ_TYPE_EDGE_RISING at the GIC.

Re: [PATCH 00/10] GICv3 support for kexec/kdump on EFI systems

2018-09-28 Thread Marc Zyngier
Hi Richard, On 27/09/18 22:10, Richard Ruigrok wrote: Hi Marc On 9/21/2018 1:59 PM, Marc Zyngier wrote: The GICv3 architecture has the remarkable feature that once LPI tables have been assigned to redistributors and that LPI delivery is enabled, there is no guarantee that LPIs can be turned

Re: [GIT PULL 00/11] EFI updates for v4.20

2018-09-27 Thread Marc Zyngier
Hi all, On 27/09/18 09:50, Ard Biesheuvel wrote: Thomas, Ingo, Please pull/cherry-pick the below. Note that the first three patches will be depended upon by an irqchip series that Marc Zyngier has sent out last week, and that targets the next release as well. So please advise how to proceed

Re: [PATCH 04/10] irqchip/gic-v3-its: Move pending table allocation to init time

2018-09-26 Thread Marc Zyngier
Hi Julien, On 24/09/18 12:58, Julien Thierry wrote: Hi Marc, On 21/09/18 20:59, Marc Zyngier wrote: Pending tables for the redistributors are currently allocated one at a time as each CPU boots. This is causing some grief for Linux/RT (allocation from within a CPU hotplug notifier is frown

Re: [PATCH 02/10] irqchip/gic-v3-its: Consolidate LPI_PENDBASE_SZ usage

2018-09-26 Thread Marc Zyngier
On 24/09/18 11:33, Suzuki K Poulose wrote: Hi Marc, On 21/09/18 20:59, Marc Zyngier wrote: LPI_PENDING_SZ is always used in conjunction with a max(). Let's factor this in the definition of the macro, and simplify the rest of the code. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq

Re: [PATCH v5 01/27] arm64: cpufeature: Set SYSREG_GIC_CPUIF as a boot system feature

2018-09-25 Thread Marc Zyngier
On 25/09/18 04:10, Yao Lihua wrote: Hi Marc, Julien, On 09/21/2018 11:56 PM, Marc Zyngier wrote: On Tue, 28 Aug 2018 16:51:11 +0100, Julien Thierry wrote: Signed-off-by: Julien Thierry Suggested-by: Daniel Thompson Cc: Catalin Marinas Cc: Will Deacon Cc: Suzuki K Poulose Cc: Marc

Re: [PATCH v3 3/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-09-23 Thread Marc Zyngier
On Sat, 22 Sep 2018 18:09:09 +0100, Lina Iyer wrote: > > On Sat, Sep 22 2018 at 10:29 -0600, Marc Zyngier wrote: > > Hi Lina, > > > > On Tue, 04 Sep 2018 22:18:08 +0100, > > Lina Iyer wrote: > >> > >> During suspend the system may power

Re: [PATCH v3 3/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-09-22 Thread Marc Zyngier
Hi Lina, On Tue, 04 Sep 2018 22:18:08 +0100, Lina Iyer wrote: > > During suspend the system may power down some of the system rails. As a > result, the TLMM hw block may not be operational anymore and wakeup > capable GPIOs will not be detected. The PDC however will be operational > and the

[PATCH 00/10] GICv3 support for kexec/kdump on EFI systems

2018-09-21 Thread Marc Zyngier
testing of different HW. For convenience, I've stashed a branch containing the whole thing at [2]. [1] https://marc.info/?l=linux-efi=153754757208163=2 [2] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/gicv3-kdump Marc Zyngier (10): irqchip/gic-v3-its: Change

  1   2   3   4   5   6   7   8   9   10   >