Re: [linux-nfc] [PATCH] NFC: trf7970a: Move trf7970a_init inside #ifdef CONFIG_PM_RUNTIME

2014-07-03 Thread Mark A. Greer
On Mon, Jun 16, 2014 at 08:58:55AM -0700, Mark A. Greer wrote: > On Mon, Jun 16, 2014 at 03:06:13PM +0200, Geert Uytterhoeven wrote: > > If CONFIG_PM_RUNTIME=n: > > > > drivers/nfc/trf7970a.c:755: warning: ‘trf7970a_init’ defined but not used > > > > Signed-off-b

Re: [linux-nfc] [PATCH] NFC: trf7970a: Move trf7970a_init inside #ifdef CONFIG_PM_RUNTIME

2014-07-03 Thread Mark A. Greer
On Mon, Jun 16, 2014 at 08:58:55AM -0700, Mark A. Greer wrote: On Mon, Jun 16, 2014 at 03:06:13PM +0200, Geert Uytterhoeven wrote: If CONFIG_PM_RUNTIME=n: drivers/nfc/trf7970a.c:755: warning: ‘trf7970a_init’ defined but not used Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org

Re: [PATCH] NFC: trf7970a: Move trf7970a_init inside #ifdef CONFIG_PM_RUNTIME

2014-06-16 Thread Mark A. Greer
On Mon, Jun 16, 2014 at 03:06:13PM +0200, Geert Uytterhoeven wrote: > If CONFIG_PM_RUNTIME=n: > > drivers/nfc/trf7970a.c:755: warning: ‘trf7970a_init’ defined but not used > > Signed-off-by: Geert Uytterhoeven Acked-by: Mark A. Greer -- To unsubscribe from this list

Re: [PATCH] NFC: trf7970a: Move trf7970a_init inside #ifdef CONFIG_PM_RUNTIME

2014-06-16 Thread Mark A. Greer
On Mon, Jun 16, 2014 at 03:06:13PM +0200, Geert Uytterhoeven wrote: If CONFIG_PM_RUNTIME=n: drivers/nfc/trf7970a.c:755: warning: ‘trf7970a_init’ defined but not used Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Mark A. Greer mgr...@animalcreek.com -- To unsubscribe from

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
[Removing Anton from CC] On Wed, May 21, 2014 at 11:25:43AM -0700, Mark A. Greer wrote: > On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: > > Hi Mark, > > > > Thank you for the quick reply. > > Hi Laurent. Sorry for the delay. > > > O

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
On Wed, May 21, 2014 at 11:25:43AM -0700, Mark A. Greer wrote: > On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: > > On a side note, is there any reference userspace implementation of a > > battery > > manager ? The vendor BSP I've received with the

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: > Hi Mark, > > Thank you for the quick reply. Hi Laurent. Sorry for the delay. > On Thursday 15 May 2014 15:08:44 Mark A. Greer wrote: > > On Thu, May 15, 2014 at 10:29:26PM +0200, Laurent Pinchart

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: Hi Mark, Thank you for the quick reply. Hi Laurent. Sorry for the delay. On Thursday 15 May 2014 15:08:44 Mark A. Greer wrote: On Thu, May 15, 2014 at 10:29:26PM +0200, Laurent Pinchart wrote: Hello, [Adding Anton

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
On Wed, May 21, 2014 at 11:25:43AM -0700, Mark A. Greer wrote: On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: On a side note, is there any reference userspace implementation of a battery manager ? The vendor BSP I've received with the board hardcodes calls

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-21 Thread Mark A. Greer
[Removing Anton from CC] On Wed, May 21, 2014 at 11:25:43AM -0700, Mark A. Greer wrote: On Fri, May 16, 2014 at 12:35:34AM +0200, Laurent Pinchart wrote: Hi Mark, Thank you for the quick reply. Hi Laurent. Sorry for the delay. On Thursday 15 May 2014 15:08:44 Mark A. Greer wrote

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-15 Thread Mark A. Greer
On Thu, May 15, 2014 at 10:29:26PM +0200, Laurent Pinchart wrote: > Hello, [Adding Anton Vorontsov to CC list.] Hi Laurent. > I'm trying to enable battery charging on an OMAP4 board based on a twl6030 > PMIC with external bq24190 battery charger and bq27510 fuel gauge. > > The system has an

Re: bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-15 Thread Mark A. Greer
On Thu, May 15, 2014 at 10:29:26PM +0200, Laurent Pinchart wrote: Hello, [Adding Anton Vorontsov to CC list.] Hi Laurent. I'm trying to enable battery charging on an OMAP4 board based on a twl6030 PMIC with external bq24190 battery charger and bq27510 fuel gauge. The system has an OTG

[PATCH v2] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-23 Thread Mark A. Greer
sysfs file exported by the power_supply infrastructure. Signed-off-by: Mark A. Greer --- - Tested on an ARM 3703-based platform which hasn't been submitted to the community yet. - Patch tested on k.o 89b53e5 (Merge branch 'for-3.11-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git

[PATCH v2] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-23 Thread Mark A. Greer
exported by the power_supply infrastructure. Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- - Tested on an ARM 3703-based platform which hasn't been submitted to the community yet. - Patch tested on k.o 89b53e5 (Merge branch 'for-3.11-fixes' of git://git.kernel.org/pub/scm/linux

Re: [PATCH] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-12 Thread Mark A. Greer
On Fri, Aug 09, 2013 at 12:21:11PM -0700, Anton Vorontsov wrote: > On Wed, Aug 07, 2013 at 02:56:48PM -0700, Mark A. Greer wrote: > ... > > +static irqreturn_t bq24190_irq_handler_thread(int irq, void *data) > > +{ > > + struct bq24190_dev_info *bdi = data; > > +

Re: [PATCH] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-12 Thread Mark A. Greer
On Fri, Aug 09, 2013 at 12:21:11PM -0700, Anton Vorontsov wrote: On Wed, Aug 07, 2013 at 02:56:48PM -0700, Mark A. Greer wrote: ... +static irqreturn_t bq24190_irq_handler_thread(int irq, void *data) +{ + struct bq24190_dev_info *bdi = data; + bool alert_userspace = false; + u8

[PATCH] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-07 Thread Mark A. Greer
sysfs file exported by the power_supply infrastructure. Signed-off-by: Mark A. Greer --- - Tested on an ARM 3703-based platform which hasn't been submitted to the community yet. - Patch based on git://git.infradead.org/battery-2.6.git but was tested on stock 3.10 plus patches for platform

[PATCH] bq24190_charger: Add support for TI BQ24190 Battery Charger

2013-08-07 Thread Mark A. Greer
exported by the power_supply infrastructure. Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- - Tested on an ARM 3703-based platform which hasn't been submitted to the community yet. - Patch based on git://git.infradead.org/battery-2.6.git but was tested on stock 3.10 plus patches

Re: crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-26 Thread Mark A. Greer
[CC'ing more people & lists.] On Tue, Feb 26, 2013 at 11:36:46AM -0700, Tim Gardner wrote: > Whats up with commits 0e87e73f4abe1ada69cf780fe2550c6361a1b53b and > b4b87a934c30fb91cbdd18ae028acdc361e1cf0f. As far as I can tell, > dma_request_slave_channel_compat() does not exist in 3.9 as of >

Re: crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-26 Thread Mark A. Greer
[CC'ing more people lists.] On Tue, Feb 26, 2013 at 11:36:46AM -0700, Tim Gardner wrote: Whats up with commits 0e87e73f4abe1ada69cf780fe2550c6361a1b53b and b4b87a934c30fb91cbdd18ae028acdc361e1cf0f. As far as I can tell, dma_request_slave_channel_compat() does not exist in 3.9 as of

Re: [PATCH] Don't mark shared helper functions as inline

2012-11-26 Thread Mark A. Greer
On Mon, Nov 26, 2012 at 11:57:42AM -0800, Mike Turquette wrote: > Quoting Russ Dill (2012-11-26 11:20:09) > > The helper functions that access the opaque struct clk should > > not be marked inline since they are contained in clk.c, but expected > > to be used by other compilation units. This

Re: [PATCH] Don't mark shared helper functions as inline

2012-11-26 Thread Mark A. Greer
On Mon, Nov 26, 2012 at 11:57:42AM -0800, Mike Turquette wrote: Quoting Russ Dill (2012-11-26 11:20:09) The helper functions that access the opaque struct clk should not be marked inline since they are contained in clk.c, but expected to be used by other compilation units. This causes

Re: [GIT PULL 00/15] arm-soc: changes for v3.6

2012-07-26 Thread Mark A. Greer
On Tue, Jul 24, 2012 at 02:51:35PM -0600, Paul Walmsley wrote: > Hi > > On Tue, 24 Jul 2012, Arnd Bergmann wrote: > > > On Tuesday 24 July 2012, Linus Torvalds wrote: > > > > > In your "for-linus" branch, "_3xxx_clkdm" remains in the > > > clockdomains_common[] array. In my merge, it is gone.

Re: [GIT PULL 00/15] arm-soc: changes for v3.6

2012-07-26 Thread Mark A. Greer
On Tue, Jul 24, 2012 at 02:51:35PM -0600, Paul Walmsley wrote: Hi On Tue, 24 Jul 2012, Arnd Bergmann wrote: On Tuesday 24 July 2012, Linus Torvalds wrote: In your for-linus branch, mpu_3xxx_clkdm remains in the clockdomains_common[] array. In my merge, it is gone. But I think I

[PATCH] Serial: MPSC - Set baudrate when BRG divider is set.

2008-01-14 Thread Mark A. Greer
From: Mark A. Greer <[EMAIL PROTECTED]> The clock to generate the desired baudrate with the MPSC is first divided by the Baud Rate Generator (BRG) and then by the MPSC itself. So, when the BRG divider is changed, the MPSC divider must also be changed to generate the correct baudrate.

[PATCH] Serial: MPSC - Set baudrate when BRG divider is set.

2008-01-14 Thread Mark A. Greer
From: Mark A. Greer [EMAIL PROTECTED] The clock to generate the desired baudrate with the MPSC is first divided by the Baud Rate Generator (BRG) and then by the MPSC itself. So, when the BRG divider is changed, the MPSC divider must also be changed to generate the correct baudrate. During MPSC

[PATCH 4/4] serial: MPSC: Fix coding style and whitespace issues

2007-07-19 Thread Mark A. Greer
Fix up mpsc.c to be aligned with Documentation/CodingStyle. Also fix up some whitespace issues. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c | 684 1 file changed, 283 insertions(+), 401 deletions(-) diff --git a/d

[PATCH 3/4] serial: MPSC: Remove duplicate SUPPORT_SYSRQ definition

2007-07-19 Thread Mark A. Greer
Remove the duplicate definition of SUPPORT_SYSRQ in mpsc driver. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 0d75505..1311433 100644 --- a/drivers/

[PATCH 2/4] serial: MPSC: Stop rx engine when CREAD cleared

2007-07-19 Thread Mark A. Greer
> Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 99715fe..108fa4c 100644 --- a/drivers/serial/mpsc.c +++ b/drivers/serial/mpsc

[PATCH 1/4] serial: MPSC: Remove race between Rx stop & restart

2007-07-19 Thread Mark A. Greer
; Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 00924fe..567fa78 100644 --- a/drivers/serial/mpsc.c +++ b/drivers/serial

[PATCH 1/4] serial: MPSC: Remove race between Rx stop restart

2007-07-19 Thread Mark A. Greer
-by: Mark A. Greer [EMAIL PROTECTED] --- drivers/serial/mpsc.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 00924fe..567fa78 100644 --- a/drivers/serial/mpsc.c +++ b/drivers/serial/mpsc.c @@ -1363,8 +1363,6

[PATCH 2/4] serial: MPSC: Stop rx engine when CREAD cleared

2007-07-19 Thread Mark A. Greer
From: Stephane Chazelas [EMAIL PROTECTED] Currently, the MPSC driver doesn't stop recieving characters when the CREAD flag in termios-c_cflag is cleared. It should. Also, only start receiving if its not already started. Signed-off-by: Stephane Chazelas [EMAIL PROTECTED] Signed-off-by: Mark

[PATCH 3/4] serial: MPSC: Remove duplicate SUPPORT_SYSRQ definition

2007-07-19 Thread Mark A. Greer
Remove the duplicate definition of SUPPORT_SYSRQ in mpsc driver. Signed-off-by: Mark A. Greer [EMAIL PROTECTED] --- drivers/serial/mpsc.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 0d75505..1311433 100644 --- a/drivers/serial

[PATCH 4/4] serial: MPSC: Fix coding style and whitespace issues

2007-07-19 Thread Mark A. Greer
Fix up mpsc.c to be aligned with Documentation/CodingStyle. Also fix up some whitespace issues. Signed-off-by: Mark A. Greer [EMAIL PROTECTED] --- drivers/serial/mpsc.c | 684 1 file changed, 283 insertions(+), 401 deletions(-) diff --git a/drivers

[PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-25 Thread Mark A. Greer
t. So, don't clear the interrupt cause bits for both MPSC controllers when clearing the interrupt for one of them. Just clear the one that is supposed to be cleared. Signed-off-by: Jay Lubomirski <[EMAIL PROTECTED]> Acked-by: Mark A. Greer <[EMAIL PROTECTED]> --- Please add this to 2.6.2

Re: [PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-25 Thread Mark A. Greer
On Sat, Jun 23, 2007 at 09:51:44AM -0700, Andrew Morton wrote: > > On Thu, 21 Jun 2007 19:32:08 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> > > wrote: > > From: Jay Lubomirski <[EMAIL PROTECTED]> > > > > Don't clobber the interrupt ca

Re: [PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-25 Thread Mark A. Greer
On Sat, Jun 23, 2007 at 09:51:44AM -0700, Andrew Morton wrote: On Thu, 21 Jun 2007 19:32:08 -0700 Mark A. Greer [EMAIL PROTECTED] wrote: From: Jay Lubomirski [EMAIL PROTECTED] Don't clobber the interrupt cause bits for both MPSC controllers when clearing the interrupt for one of them

[PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-25 Thread Mark A. Greer
clear the interrupt cause bits for both MPSC controllers when clearing the interrupt for one of them. Just clear the one that is supposed to be cleared. Signed-off-by: Jay Lubomirski [EMAIL PROTECTED] Acked-by: Mark A. Greer [EMAIL PROTECTED] --- Please add this to 2.6.21.x and 2.6.22-rc6, if its

[PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-21 Thread Mark A. Greer
From: Jay Lubomirski <[EMAIL PROTECTED]> Don't clobber the interrupt cause bits for both MPSC controllers when clearing the interrupt for one of them. Just clear the one that is supposed to be cleared. Signed-off-by: Jay Lubomirski <[EMAIL PROTECTED]> Acked-by: Mark A. Greer <[

[PATCH] serial: Clear proper MPSC interrupt cause bits

2007-06-21 Thread Mark A. Greer
From: Jay Lubomirski [EMAIL PROTECTED] Don't clobber the interrupt cause bits for both MPSC controllers when clearing the interrupt for one of them. Just clear the one that is supposed to be cleared. Signed-off-by: Jay Lubomirski [EMAIL PROTECTED] Acked-by: Mark A. Greer [EMAIL PROTECTED

Re: [PATCH 1/2] rtc: add rtc-m41txx driver

2007-06-19 Thread Mark A. Greer
CTED]> > Signed-off-by: Alexander Bigga <[EMAIL PROTECTED]> Other than addressing David's question about alarm support, Acked-by: Mark A. Greer <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH 1/2] rtc: add rtc-m41txx driver

2007-06-19 Thread Mark A. Greer
] Other than addressing David's question about alarm support, Acked-by: Mark A. Greer [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-09 Thread Mark A. Greer
h adds the driver for that i2c controller. Please apply. Depends on patch submitted by Jean Delvare: http://archives.andrew.net.au/lm-sensors/msg29405.html Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/driver

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-09 Thread Mark A. Greer
the driver for that i2c controller. Please apply. Depends on patch submitted by Jean Delvare: http://archives.andrew.net.au/lm-sensors/msg29405.html Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-08 Thread Mark A. Greer
submitted by Jean Delvare: http://archives.andrew.net.au/lm-sensors/msg29405.html Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-02-08 17:28:52 -07:00 +++ b/drivers/i2c/busses/K

[PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-08 Thread Mark A. Greer
64xxx_i2c_unmap_regs(drv_data); + exit_kfree: + kfree(drv_data); + return rc; +} + +static int __devexit +mv64xxx_i2c_remove(struct device *dev) +{ + struct mv64xxx_i2c_data *drv_data = dev_get_drvdata(dev); + int rc; + + rc = i2c_

[PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-08 Thread Mark A. Greer
+++ b/drivers/i2c/busses/i2c-mv64xxx.c 2005-02-08 16:24:33 -07:00 @@ -0,0 +1,606 @@ +/* + * drivers/i2c/busses/i2c-mv64xxx.c + * + * Driver for the i2c controller on the Marvell line of host bridges for MIPS + * and PPC (e.g, gt642[46]0, mv643[46]0, mv644[46]0). + * + * Author: Mark A. Greer

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-08 Thread Mark A. Greer
on patch submitted by Jean Delvare: http://archives.andrew.net.au/lm-sensors/msg29405.html Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-02-08 17:28:52 -07:00 +++ b/drivers/i2c

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-04 Thread Mark A. Greer
to provide the context required by the i2c core code. Please apply. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig --- a/drivers/i2c/chips/Kconfig 2005-02-04 17:00:45 -07:00 +++ b/drivers/i2c/chips/Kconfig 2005-02-04 17:00:

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-04 Thread Mark A. Greer
From http://archives.andrew.net.au/lm-sensors/msg29319.html: Mark A. Greer wrote: Here is a replacement patch that should address Jean Delvare and Dick Johnson's issues. Please let me know if there are any more issues. Thanks, Mark Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- I h

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-04 Thread Mark A. Greer
From http://archives.andrew.net.au/lm-sensors/msg29319.html: Mark A. Greer wrote: snip Here is a replacement patch that should address Jean Delvare and Dick Johnson's issues. Please let me know if there are any more issues. Thanks, Mark Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- I

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-04 Thread Mark A. Greer
to provide the context required by the i2c core code. Please apply. Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig --- a/drivers/i2c/chips/Kconfig 2005-02-04 17:00:45 -07:00 +++ b/drivers/i2c/chips/Kconfig 2005-02-04 17:00:45 -07

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-03 Thread Mark A. Greer
Alexey Dobriyan wrote: On Thursday 03 February 2005 21:12, Mark A. Greer wrote: + mv64xxx_i2c_fsm(drv_data, status); It can set drv_data->rc to -ENODEV or -EIO. In both cases ->action goes to MV64XXX_I2C_ACTION_SEND_STOP and mv64xxx_i2c_do_action() will writel() som

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-03 Thread Mark A. Greer
Hi, Alexey. -- Alexey Dobriyan wrote: On Wednesday 02 February 2005 19:26, Mark A. Greer wrote: How's this (a complete replacement for previous patch)? --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig + If you say yes to this option, support will be included

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-03 Thread Mark A. Greer
Hi, Alexey. -- Alexey Dobriyan wrote: On Wednesday 02 February 2005 19:26, Mark A. Greer wrote: How's this (a complete replacement for previous patch)? --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig + If you say yes to this option, support will be included

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-03 Thread Mark A. Greer
Alexey Dobriyan wrote: On Thursday 03 February 2005 21:12, Mark A. Greer wrote: + mv64xxx_i2c_fsm(drv_data, status); It can set drv_data-rc to -ENODEV or -EIO. In both cases -action goes to MV64XXX_I2C_ACTION_SEND_STOP and mv64xxx_i2c_do_action() will writel() something. Is it correct

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-02 Thread Mark A. Greer
Alexey Dobriyan wrote: On Tue, 01 Feb 2005 10:54:32 -0700, Mark A. Greer wrote: +struct mv64xxx_i2c_data { + void *reg_base; ioremap() returns "void __iomem *". Okay. +static void __devexit +mv64xxx_i2c_unmap_regs(struct mv64xxx_i2c_data *drv_data) +{ + if (!drv_data

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-02 Thread Mark A. Greer
Alexey Dobriyan wrote: On Tue, 01 Feb 2005 10:54:32 -0700, Mark A. Greer wrote: +struct mv64xxx_i2c_data { + void *reg_base; ioremap() returns void __iomem *. Okay. +static void __devexit +mv64xxx_i2c_unmap_regs(struct mv64xxx_i2c_data *drv_data) +{ + if (!drv_data-reg_base

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-01 Thread Mark A. Greer
sues. Thanks, Mark Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig --- a/drivers/i2c/chips/Kconfig 2005-02-01 13:37:08 -07:00 +++ b/drivers/i2c/chips/Kconfig 2005-02-01 13:37:08 -07:00 @@ -371,4 +371,13 @@ This drive

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-01 Thread Mark A. Greer
.g, gt642[46]0, mv643[46]0, mv644[46]0). + * + * Author: Mark A. Greer <[EMAIL PROTECTED]> + * + * 2005 (c) MontaVista, Software, Inc. This file is licensed under + * the terms of the GNU General Public License version 2. This program + * is licensed "as is" without any warranty o

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-02-01 Thread Mark A. Greer
[46]0). + * + * Author: Mark A. Greer [EMAIL PROTECTED] + * + * 2005 (c) MontaVista, Software, Inc. This file is licensed under + * the terms of the GNU General Public License version 2. This program + * is licensed as is without any warranty of any kind, whether express + * or implied

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-02-01 Thread Mark A. Greer
. Thanks, Mark Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig --- a/drivers/i2c/chips/Kconfig 2005-02-01 13:37:08 -07:00 +++ b/drivers/i2c/chips/Kconfig 2005-02-01 13:37:08 -07:00 @@ -371,4 +371,13 @@ This driver can also

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-01-31 Thread Mark A. Greer
linux-os wrote: On ix86 machines, it is appropriate to read the RTC clock several times in a row until nothing changes. This protects against getting bad readings when some values wrap (like seconds). You can't stop the clock when you read it or you will lose time. I don't see anything like this

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-31 Thread Mark A. Greer
Greg KH wrote: On Tue, Jan 25, 2005 at 06:26:45PM -0700, Mark A. Greer wrote: +static inline void +mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status) This is a much too big of a function to be "inline". Please change it. Same for your other inline functions, that's

[PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-01-31 Thread Mark A. Greer
TA_UNSYNC is not set (e.g., ntpd is running). To handle this, a tasklet is used to set the clock if in_interrupt() is true. I'd appreciate an comments or to have it pushed into the kernel.org tree if its acceptable. Thanks, Mark Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nr

[PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-01-31 Thread Mark A. Greer
is not set (e.g., ntpd is running). To handle this, a tasklet is used to set the clock if in_interrupt() is true. I'd appreciate an comments or to have it pushed into the kernel.org tree if its acceptable. Thanks, Mark Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/chips

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-31 Thread Mark A. Greer
Greg KH wrote: On Tue, Jan 25, 2005 at 06:26:45PM -0700, Mark A. Greer wrote: +static inline void +mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status) This is a much too big of a function to be inline. Please change it. Same for your other inline functions, that's not really

Re: [PATCH][I2C] ST M41T00 I2C RTC chip driver

2005-01-31 Thread Mark A. Greer
linux-os wrote: On ix86 machines, it is appropriate to read the RTC clock several times in a row until nothing changes. This protects against getting bad readings when some values wrap (like seconds). You can't stop the clock when you read it or you will lose time. I don't see anything like this

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
Jean Delvare wrote: Hi Mark, Thanks for the commenting, Jean. +config I2C_MV64XXX + tristate "Marvell mv64xxx I2C Controller" + depends on I2C && MV64X60 && EXPERIMENTAL? Yes, I guess that's the correct thing to do. I'll add that. diff -Nru a/include/linux/i2c-id.h

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
s a complete replacement for the one posted earlier. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-01-26 14:49:22 -07:00 +++ b/drivers/i2c/busses/Kconfig20

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
rv_data); kfree(drv_data); diff -Nru a/drivers/i2c/busses/i2c-mv64xxx.h b/drivers/i2c/busses/i2c-mv64xxx.h --- a/drivers/i2c/busses/i2c-mv64xxx.h 2005-01-26 16:52:56 -07:00 +++ /dev/null Wed Dec 31 16:00:00 196900 @@ -1,99 +0,0 @@ -/* - * drivers/i2c/busses/i2c-mv6

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
:00 196900 @@ -1,99 +0,0 @@ -/* - * drivers/i2c/busses/i2c-mv64xxx.h - * - * Driver for the i2c controller on the Marvell line of host bridges for MIPS - * and PPC (e.g, gt642[46]0, mv643[46]0, mv644[46]0). - * - * Author: Mark A. Greer [EMAIL PROTECTED] - * - * 2005 (c) MontaVista, Software, Inc

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
earlier. Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-01-26 14:49:22 -07:00 +++ b/drivers/i2c/busses/Kconfig2005-01-26 14:49:22 -07:00 @@ -476,4 +476,14 @@ This driver

Re: [PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-26 Thread Mark A. Greer
Jean Delvare wrote: Hi Mark, Thanks for the commenting, Jean. snip +config I2C_MV64XXX + tristate Marvell mv64xxx I2C Controller + depends on I2C MV64X60 EXPERIMENTAL? Yes, I guess that's the correct thing to do. I'll add that. diff -Nru a/include/linux/i2c-id.h b/include/linux/i2c-id.h

[PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-25 Thread Mark A. Greer
is. Thanks, Mark Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-01-25 18:15:24 -07:00 +++ b/drivers/i2c/busses/Kconfig2005-01-25 18:15:24 -07:00 @@ -476,4 +

[PATCH][SERIAL] mpsc updates

2005-01-25 Thread Mark A. Greer
whitespace Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> -- diff -Nru a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c --- a/drivers/serial/mpsc.c 2005-01-25 17:28:43 -07:00 +++ b/drivers/serial/mpsc.c 2005-01-25 17:28:43 -07:00 @@ -36,16 +36,14 @@ * * 1) Some chips have an erratum

[PATCH][SERIAL] mpsc updates

2005-01-25 Thread Mark A. Greer
whitespace Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c --- a/drivers/serial/mpsc.c 2005-01-25 17:28:43 -07:00 +++ b/drivers/serial/mpsc.c 2005-01-25 17:28:43 -07:00 @@ -36,16 +36,14 @@ * * 1) Some chips have an erratum where

[PATCH][I2C] Marvell mv64xxx i2c driver

2005-01-25 Thread Mark A. Greer
is. Thanks, Mark Signed-off-by: Mark A. Greer [EMAIL PROTECTED] -- diff -Nru a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig --- a/drivers/i2c/busses/Kconfig2005-01-25 18:15:24 -07:00 +++ b/drivers/i2c/busses/Kconfig2005-01-25 18:15:24 -07:00 @@ -476,4 +476,14