[PATCH] clk: stm32mp1: wait for LSE to become ready after enabling

2021-02-11 Thread Martin Fuzzey
e RTC to initialise. When the RTC driver is built in it works, provided the LSE has already been enabled by the bootloader. Signed-off-by: Martin Fuzzey --- drivers/clk/clk-stm32mp1.c | 73 +++--- 1 file changed, 69 insertions(+), 4 deletions(-) diff --

[PATCH] w1: mxc_w1: Fix timeout resolution problem leading to bus error

2020-09-30 Thread Martin Fuzzey
by replacing jiffies by ktime_get(). For consistency apply the same change to the other use of jiffies in mxc_w1_ds2_reset_bus(). Fixes: f80b2581a706 ("w1: mxc_w1: Optimize mxc_w1_ds2_touch_bit()") Cc: stable Signed-off-by: Martin Fuzzey --- drivers/w1/masters/mxc_w1.c | 14 +++

[PATCH] drm: imx: Fix occasional screen corruption on modeset.

2020-07-07 Thread Martin Fuzzey
fixes this. Signed-off-by: Martin Fuzzey --- drivers/gpu/drm/imx/ipuv3-crtc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c index 63c0284..9137b64 100644 --- a/drivers/gpu/drm/imx/ipuv3-crtc.c ++

[PATCH] regulator: da9063: fix LDO9 suspend and warning.

2020-06-12 Thread Martin Fuzzey
test robot. da9063-regulator.c:515:3: warning: initialized field overwritten Fix this by converting that regulator too like the others. Fixes: 99f75ce66619 ("regulator: da9063: fix suspend") Reported-by: kernel test robot Signed-off-by: Martin Fuzzey --- drivers/regulator/da

[PATCH] drm/etnaviv: fix memory leak when mapping prime imported buffers

2020-05-20 Thread Martin Fuzzey
When using mmap() on a prime imported buffer allocated by a different driver (such as imx-drm) the later munmap() does not correctly decrement the refcount of the original enaviv_gem_object, leading to a leak. Signed-off-by: Martin Fuzzey Cc: sta...@vger.kernel.org --- drivers/gpu/drm/etnaviv

Re: [v3,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties

2019-09-03 Thread Martin Fuzzey
On 03/09/2019 08:18, Biwen Li wrote: diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt index 94adc1cf93d9..588f688b30d1 100644 --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt +++ b/Documentation/devicetree/bindings/rtc/p

Re: [PATCH] firmware: cleanup - group and document up private firmware parameters

2017-09-15 Thread Martin Fuzzey
Hi Luis, On 15/09/17 00:54, Luis R. Rodriguez wrote: The firmware API has a slew of private options available, which can sometimes be hard to understand. When new functionality is introduced we also tend to have modify a slew of internal helpers. Just stuff all common private requirements into

Re: [PATCH 0/4] firmware: fix fallback mechanism by ignoring SIGCHLD

2017-06-15 Thread Martin Fuzzey
On 15/06/17 00:20, Luis R. Rodriguez wrote: Martin reported an issue with Android where if sysfs is used to trigger a sync fw load which *relies* on the fallback mechanism and a background job completes while the trigger is ongoing in the foreground it will immediately fail the fw request. The i

Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback

2017-06-09 Thread Martin Fuzzey
On 09/06/17 03:57, Luis R. Rodriguez wrote: On Thu, Jun 8, 2017 at 6:10 PM, Luis R. Rodriguez wrote: Android didn't send the signal, the kernel did (SIGCHLD). Like this: 1) Android init (pid=1) fork()s (say pid=42) [this child process is totally unrelated to firmware loading] 2) Android init

Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback

2017-06-07 Thread Martin Fuzzey
On 07/06/17 19:08, Luis R. Rodriguez wrote: On Thu, May 25, 2017 at 10:28:38AM +0200, Fuzzey, Martin wrote: 1) Android init calls write() on the sysfs file 2) The sysfs .store() callback registered by a driver is called 3) The driver calls request_firmware() 4) request_firmware() sends the firmw

Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback

2017-06-06 Thread Martin Fuzzey
ent_killable_timeout() into -stables. After seeing how simple it is to do so I tend to agree. Greg, Peter, what are your thoughts ? Martin Fuzzey can you test this patch as an alternative to your issue ? diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index b9f907eedbf7.

Re: [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS

2017-05-23 Thread Martin Fuzzey
On 23/05/17 15:31, Greg Kroah-Hartman wrote: On Tue, May 23, 2017 at 03:16:07PM +0200, Martin Fuzzey wrote: When -ERESTARTSYS is returned by wait_* due to a signal this should be returned from request_firmware() so that the syscall may be restarted if necessary. Nice find, should this go to

[PATCH] firmware: request_firmware() should propagate -ERESTARTSYS

2017-05-23 Thread Martin Fuzzey
particular case request_firmware() was being called from a sysfs .store() callback and the writing process was the Android init process which received a SIGCHLD causing request_firmware() to fail. Signed-off-by: Martin Fuzzey --- drivers/base/firmware_class.c |7 --- 1 file changed, 4

Re: Regulator: drivers that need to know their supply

2016-04-07 Thread Martin Fuzzey
Thanks for your reply. On 07/04/16 19:02, Mark Brown wrote: On Thu, Apr 07, 2016 at 03:25:09PM +0200, Martin Fuzzey wrote: To implement the .enable_time() method I need the voltage (which is the supply's voltage). No, this is not sensible. You should be telling the framework about the

Regulator: drivers that need to know their supply

2016-04-07 Thread Martin Fuzzey
Hi, I am working on a driver for the tps22993 load switch. This chip has configurable slew rates but no voltage setting (as it's just a switch). To implement the .enable_time() method I need the voltage (which is the supply's voltage). The problem is that, when my regulator is configured as al

Re: [PATCH] base/platform: Fix platform drivers with no probe callback (ex alarmtimer)

2016-01-05 Thread Martin Fuzzey
Hi Uwe, On 05/01/16 09:43, Uwe Kleine-König wrote: Hello, I think this is the same problem that another Martin found and fixed in http://mid.gmane.org/1449132704-9952-1-git-send-email-martin.wi...@ts.fujitsu.com Yes it's the same problem and the fix is equivalent to my patch I didn't check,

[PATCH] base/platform: Fix platform drivers with no probe callback (ex alarmtimer)

2016-01-04 Thread Martin Fuzzey
-off-by: Martin Fuzzey --- drivers/base/platform.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 1dd6d3b..61e5b7e 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -513,8 +513,8 @@ static int

Re: [PATCH 8/8] iio: mma8452: add devicetree property to allow all pin wirings

2015-07-20 Thread Martin Fuzzey
On 19/07/15 15:47, Jonathan Cameron wrote: On 06/07/15 13:34, Martin Kepplinger wrote: For the devices supported by the mma8452 driver, two interrupt pins are available to route the interrupt signals to. By default INT1 is assumed. This adds a simple boolean DT property, for users to configure

Re: [PATCH 7/9] iio: mma8452: change iio event type to IIO_EV_TYPE_MAG

2015-07-06 Thread Martin Fuzzey
On 05/07/15 13:50, Jonathan Cameron wrote: On 04/07/15 14:55, Martin Kepplinger wrote: IIO_EV_TYPE_THRESH in rising direction describes an event where the threshold is crossed in rising direction, positive or negative values being possible. This is not the case here. Since the threshold is no s

Re: [PATCH 5/9] iio: mma8452: add devicetree documentation

2015-07-06 Thread Martin Fuzzey
On 05/07/15 13:48, Jonathan Cameron wrote: On 04/07/15 14:55, Martin Kepplinger wrote: Signed-off-by: Martin Kepplinger Signed-off-by: Christoph Muellner This is trivial enough I'll take it without a device tree ack (after a few days) but convention is to CC all device tree patches to the mai

Re: [PATCH 2/2] Regulator: add driver for Freescale MC34708

2015-05-11 Thread Martin Fuzzey
Thank you for the review. On 30/04/15 21:45, Mark Brown wrote: On Tue, Apr 28, 2015 at 04:17:40PM +0200, Martin Fuzzey wrote: Signed-off-by: Martin Fuzzey Please use subject lines reflecting the style for the subsystem. You mean regulator: mc34708: Add driver? I ommitted the mc34708 part

[PATCH 2/2] Regulator: add driver for Freescale MC34708

2015-04-28 Thread Martin Fuzzey
Signed-off-by: Martin Fuzzey --- drivers/regulator/Kconfig |7 drivers/regulator/Makefile|1 drivers/regulator/mc34708-regulator.c | 1266 + 3 files changed, 1274 insertions(+) create mode 100644 drivers/regulator/mc34708

[PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-04-28 Thread Martin Fuzzey
Signed-off-by: Martin Fuzzey --- .../bindings/regulator/mc34708-regulator.txt | 198 1 file changed, 198 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mc34708-regulator.txt diff --git a/Documentation/devicetree/bindings/regulator

[PATCH 0/2] regulator: Add regulator driver for the MC34708 PMIC

2015-04-28 Thread Martin Fuzzey
Add regulator driver and associated DT bindings for the regulators in the Freescale MC34708 PMIC. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

[PATCH] clk: clk-gpio-gate: Fix active low

2015-03-18 Thread Martin Fuzzey
() but there are currently no other users. Signed-off-by: Martin Fuzzey --- drivers/clk/clk-gpio-gate.c | 31 +-- include/linux/clk-provider.h |2 +- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/clk/clk-gpio-gate.c b/drivers/clk/clk-gpio

[PATCH] reset: Add generic GPIO reset driver.

2014-02-10 Thread Martin Fuzzey
oller implementation it is also possible to reset devices at boot via a DT property or from userspace on request via sysfs attributes. Signed-off-by: Martin Fuzzey --- Documentation/ABI/testing/sysfs-driver-gpio-reset | 18 + Documentation/devicetree/bindings/reset/gpio.txt | 44 ++ drivers/reset/Kc

Re: [11/51] Input: atmel_mxt_ts - Implement CRC check for configuration data

2013-09-18 Thread Martin Fuzzey
On 27/06/13 14:48, Nick Dyer wrote: The configuration is stored in NVRAM on the maXTouch chip. When the device is reset it reports a CRC of the stored configuration values. Therefore it isn't necessary to send the configuration on each probe - we can check the CRC matches and avoid a timeconsumin

Re: [12/51] Input: atmel_mxt_ts - Download device config using firmware loader

2013-09-18 Thread Martin Fuzzey
On 27/06/13 14:48, Nick Dyer wrote: The existing implementation which encodes the configuration as a binary blob in platform data is unsatisfactory since it requires a kernel recompile for the configuration to be changed, and it doesn't deal well with firmware changes that move values around on t