Re: linux-next: Signed-off-by missing for commit in the scsi-fixes tree

2018-11-06 Thread Martin K. Petersen
Stephen, > Commit > > 85ee0a7b2d53 ("Revert "scsi: ufs: Disable blk-mq for now"") > > is missing a Signed-off-by from its author and committer. Fixed up, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

2018-10-23 Thread Martin K. Petersen
~~~ > > Update cdb's type to unsigned char, which matches the type of the cdb > member in struct TW_Command_Apache. Applied to 4.20/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch

2018-10-15 Thread Martin K. Petersen
ue to work towards exposing > multiple queues to upper layer, but for the moment I think patch 6/7 is > a good change. Thanks for the discussion. That's exactly what I was looking for. Applied to 4.20/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] target: Fix target_wait_for_sess_cmds breakage with active signals

2018-10-15 Thread Martin K. Petersen
Bryant, > VMs do not remove the I_T nexus while the VM is active, so we can remove > the target_wait_for_sess_cmd() call. Patch forthcoming? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: arcmsr: clean up clang warning on extraneous parentheses

2018-10-10 Thread Martin K. Petersen
Colin, > There are extraneous parantheses that are causing clang to produce a > warning so remove these. > > Clean up 3 clang warnings: > equality comparison with extraneous parentheses [-Wparentheses-equality] Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen

Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch

2018-10-10 Thread Martin K. Petersen
gt; if we switched to SCSI MQ, the block layer tag becomes unique per queue, > and not per HBA. That doesn't sound right. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

2018-09-27 Thread Martin K. Petersen
Masanari, > Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in > commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not > modified. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: Use vmemdup_user to replace the open code

2018-09-18 Thread Martin K. Petersen
Hi Zhong, > Can you pick up the patch? Please submit SCSI patches to linux-s...@vger.kernel.org so they get tracked in patchwork. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: iscsi: target: fix spelling mistake "entires" -> "entries"

2018-09-17 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in function name and comment Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv3] iscsi-target: Don't use stack buffer for scatterlist

2018-09-11 Thread Martin K. Petersen
> Applied to 4.20/scsi-queue, thank you! 4.19/scsi-fixes, that is... -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv3] iscsi-target: Don't use stack buffer for scatterlist

2018-09-11 Thread Martin K. Petersen
Laura, > There are two cases that trigger this bug. Switch to using a > dynamically allocated buffer for one case and do not assign > a NULL buffer in another case. Applied to 4.20/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [regression/bisected] 4.19 cycle boot time IO stalls

2018-09-05 Thread Martin K. Petersen
> I reverted the two offending changes last week. James just hasn't sent > Linus a pull request yet... Actually, he did earlier today. -- Martin K. Petersen Oracle Linux Engineering

Re: [regression/bisected] 4.19 cycle boot time IO stalls

2018-09-05 Thread Martin K. Petersen
quest yet... -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv2] iscsi-target: Don't use stack buffer for scatterlist

2018-08-30 Thread Martin K. Petersen
a/0x50 > > This is a BUG_ON for using a stack buffer with a scatterlist. There > are two cases that trigger this bug. Switch to using a dynamically > allocated buffer for one case and do not assign a NULL buffer in > another case. Mike: Please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] libata: Add missing newline at end of file

2018-08-23 Thread Martin K. Petersen
Geert, > With gcc 4.1.2: > > drivers/ata/libata-core.c:7396:33: warning: no newline at end of file Applied to 4.19/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] scsi: arcmsr: fix error of resuming from hibernation

2018-07-12 Thread Martin K. Petersen
Ching, > This patch series are against to mkp's 4.19/scsi-queue. > > 1. Fix error of resuming from hibernation for adapter type E. > 2. Update driver version to v1.40.00.09-20180709 Applied to 4.19/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

2018-07-10 Thread Martin K. Petersen
t on vacation. I thought I committed it but I guess not. I'll get to it today. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] sg: mitigate read/write abuse

2018-06-26 Thread Martin K. Petersen
it on ->write(), also > on ->read(). > > As a band-aid, make sure that the ->read() and ->write() handlers can > not be called in weird contexts (kernel context or credentials > different from file opener), like for ib_safe_file_access(). Applied to 4.18/scsi-fixes with the namin

Re: linux-next: Signed-off-by missing for commit in the scsi-mkp tree

2018-06-20 Thread Martin K. Petersen
Stephen, >> Fixed, thanks! > > Unfortunately, James had already merged your tree :-( James' script will drop the offending original commit when I amend something in the SCSI tree. So the discrepancy will go away next time he updates. -- Martin K. Petersen Oracle Linux Engineering

Re: linux-next: Signed-off-by missing for commit in the scsi-mkp tree

2018-06-19 Thread Martin K. Petersen
Stephen, > Commit > > 508fbc44bbb7 ("scsi: be2iscsi: Include null char in SET_HOST_DATA") > > is missing a Signed-off-by from its author. Fixed, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: cxlflash: Change return type for fault handler

2018-06-19 Thread Martin K. Petersen
Matthew, > Since this has not yet been queued for 4.19, please submit a v2 with > the modifications to also update the return type for > ocxlflash_mmap_fault(). Yes, please. I have been waiting for an amended patch. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 4.4 128/268] scsi: sd: Keep disk read-only when re-reading partition

2018-06-14 Thread Martin K. Petersen
m with distinguishing between current state and an override flag in the block layer. However, I think an incremental patch to fix that up is fine. SCSI devices don't typically switch write protection state on a whim. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-06-01 Thread Martin K. Petersen
sn't or can't be handled by the ANA code in NVMe? What is it that must go against the grain of what the storage vendors are trying to achieve with ANA? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-05-31 Thread Martin K. Petersen
t's only complicating things and therefore we'd be doing people a disservice rather than a favor. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/13] hisi_sas: Misc improvements, bugfixes, etc.

2018-05-28 Thread Martin K. Petersen
allocation method to avoid > unknown SoC bugs > - fix potential problem of removing the driver when > a disk is mounted > - other more minor stuff Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: pm80xx: fix spelling mistake "UNSORPORTED" -> "SUPPORTED"

2018-05-28 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in pm8001_printk message text; also I > believe NOT_UNSUPPORTED should probably be NOT_SUPPORTED. Also fix the > indent of the pm8001_printk statement. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: target: fix spelling mistake "Uknown" -> "Unknown"

2018-05-28 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in pr_err message text Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-05-28 Thread Martin K. Petersen
end the specification or fix their implementations to work with ANA. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI

2018-05-23 Thread Martin K. Petersen
functionality out of the subsystem to accommodate ioctl handling. I'm traveling today so I probably won't get a chance to look closely until tomorrow morning. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI

2018-05-22 Thread Martin K. Petersen
ctl.c which is linked with CONFIG_IDE >> by way of CONFIG_BLK_SCSI_REQUEST. > > Please keep the code where it is and just depend on SCSI on the legacy > ide driver. No need to do gymnastics just for a legacy case. Yup, I agree. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: snic: fix a couple of spelling mistakes: "COMPLETE"

2018-05-18 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistakes/typos: > "SNIC_IOREQ_ABTS_COMPELTE" -> "SNIC_IOREQ_ABTS_COMPLETE" > "SNIC_IOREQ_LR_COMPELTE" -> "SNIC_IOREQ_LR_COMPLETE" > "SNIC_IOREQ_CMD_COMPELTE" -> "SNIC_IOREQ_CMD_COMPLE

Re: [PATCH] scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'

2018-05-18 Thread Martin K. Petersen
Christophe, > The 'free_irq()' call is not at the right place in the error handling > path. The changed order has been introduced in commit 3d4253d9afab > ("[SCSI] qlogicpti: Convert to new SBUS device framework.") Applied to 4.18/scsi-queue. Thanks! -- Martin K. Peterse

Re: [PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-18 Thread Martin K. Petersen
look for v4.18? Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/3] Fix UFS and devfreq interaction

2018-05-18 Thread Martin K. Petersen
/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: storvsc: Avoid allocating memory for temp cpumasks

2018-05-18 Thread Martin K. Petersen
Michael, > Current code allocates 240 Kbytes (in typical configs) for each > synthetic SCSI controller to use as temp cpumask variables. Recode to > avoid needing the temp cpumask variables and remove the memory > allocation. Applied to 4.18/scsi-queue. Thanks! -- Martin

Re: [PATCH 0/6] hisi_sas: improve DQ locking

2018-05-18 Thread Martin K. Petersen
John, > This patchset introduces some patches to much improve DQ lockout for > sending commands to the HW. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci

2018-05-18 Thread Martin K. Petersen
driver. Splitting this has a advantage of less reviewing over head. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: ufshcd: Remove VLA usage

2018-05-18 Thread Martin K. Petersen
gt; stack space. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-05-18 Thread Martin K. Petersen
Alexander, > This shall help avoid copying uninitialized memory to the userspace > when calling ioctl(fd, SG_IO) with an empty command. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-14 Thread Martin K. Petersen
ng mpt_lan_send_reply(). Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: clean up generated file scsi_devinfo_tbl.c

2018-05-14 Thread Martin K. Petersen
Randy, > "make clean" should remove the generated file "scsi_devinfo_tbl.c", so > list it in the clean-files variable so that the file gets cleaned up. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: esas2r: fix spelling mistake: "requestss" -> "requests"

2018-05-14 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in esas2r_debug message Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libosd: Remove VLA usage

2018-05-14 Thread Martin K. Petersen
Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

2018-05-07 Thread Martin K. Petersen
the admin or application. Also, instead of introducing this module parameter, why not simply ask the user to change rq_timeout? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread Martin K. Petersen
(CAP_SYS_ADMIN) in twa_chrdev_open()t o avoid > the above issues. Applied patch 1 + 2 to 4.18/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptsas: fix spelling mistake: "matchs" -> "matches"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in warning message Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][V2] scsi: lpfc: fix spelling mistakes: "mabilbox" and "maibox"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistakes in lpfc_printf_log log message > > "mabilbox" -> "mailbox" > "maibox" -> "mailbox" Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

2018-05-07 Thread Martin K. Petersen
Andrei, Applied to 4.18/scsi-queue. thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptfusion: fix spelling mistake: "initators" -> "initiators"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in text string Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-07 Thread Martin K. Petersen
Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/11] hisi_sas: some misc patches

2018-05-07 Thread Martin K. Petersen
other more minor things Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] libata: blacklist Micron SSD

2018-05-02 Thread Martin K. Petersen
et/lists/linux-ide/msg55370.html Yep, but they have confirmed it's only that model and firmware rev that's affected. I just haven't gotten the comprehensive matrix of all current models and firmware revs I was hoping for. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: fix spelling mistake: "disbale" -> "disable"

2018-05-01 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in module parameter description text Mangled patch. Applied by hand. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mpt3sas: fix spelling mistake: "disbale" -> "disable"

2018-05-01 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in module parameter description text Ditto. Also hand-applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: esas2r: fix spelling mistake: "asynchromous" -> "asynchronous"

2018-05-01 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in module description text Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency

2018-05-01 Thread Martin K. Petersen
dition is always true. Applied to 4.18/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] libata: blacklist Micron SSD

2018-04-30 Thread Martin K. Petersen
hrough further down for the rest. I have not gotten firm confirmation on ZRAT behavior so for now we should probably just do: + { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] [v2] scsi: ips: fix firmware timestamps for 32-bit

2018-04-20 Thread Martin K. Petersen
e way here, and gets us closer to removing the deprecated > interfaces. Applied to 4.18/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] [RESEND 2] scsi: esas2r: use ktime_get_real_seconds()

2018-04-20 Thread Martin K. Petersen
ot > much we can do about it. > > This changes do_gettimeofday() to ktime_get_real_seconds(), which at > least simplifies the code a bit, and avoids the deprecated > interface. I'm adding a comment about the overflow to document what > happens. Applied to 4.18/scsi-queue. T

Re: [PATCH][V2] isci: Fix infinite loop in while loop

2018-04-20 Thread Martin K. Petersen
gt; SCI_MAX_PHS. Fix this by turning the while loop into a for loop. Applied to 4.17/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/6] scsi: handle special return codes for ABORTED COMMAND

2018-04-20 Thread Martin K. Petersen
s for the current > code first. Much better, thanks for reworking this. Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe

2018-04-20 Thread Martin K. Petersen
Jia-Ju, > st_probe() is never called in atomic context. Applied patches 1 and 2 to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write

2018-04-20 Thread Martin K. Petersen
to take advantage of cache locality. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-20 Thread Martin K. Petersen
Long, > If num_cpus=1, we don't have any sub channels. > > The host offers one sub channel for VM with 5 CPUs, after that it offers > an additional sub channel every 4 CPUs. > > The primary channel is always offered. Applied to 4.17/scsi-fixes. Thanks! -- Martin K. Petersen

Re: [PATCH 01/12] iscsi_tcp: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 02/12] storsvc: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptfc: fix spelling mistake in macro names

2018-04-18 Thread Martin K. Petersen
Colin, > Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and > MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN Applied to 4.18/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Martin K. Petersen
Long, > Can you take a look at the following patch? >> > + max_sub_channels = >> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel; What happens if num_cpus = 1? -- Martin K. Petersen Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

2018-04-18 Thread Martin K. Petersen
Long, > I will fix this by moving those data structure to kmalloc pre-allocated > when channel is first created. Sounds good. I'll drop patch 3 for now and wait for you to resubmit. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] block: ratelimite pr_err on IO path

2018-04-13 Thread Martin K. Petersen
X supposed to work for SATA drives behind an mpt3sas controller? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: fnic: fix spelling mistake in fnic stats "Abord" -> "Abort"

2018-04-12 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in fnic stats message text Applied to 4.17/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage

2018-04-12 Thread Martin K. Petersen
on table". Looks fine. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] block: ratelimite pr_err on IO path

2018-04-12 Thread Martin K. Petersen
Jack, > + pr_err_ratelimited("%s: ref tag error at > location %llu (rcvd %u)\n", I'm a bit concerned about dropping records of potential data loss. Also, what are you doing that compels all these to be logged? This should be a very rare occurrenc

Re: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

2018-04-09 Thread Martin K. Petersen
i-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/8] hisi_sas: some misc changes

2018-04-09 Thread Martin K. Petersen
John, > This patchset introduces some minor, more trivial patches, some of > which have been sitting on our internal dev branch for a while. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

2018-04-09 Thread Martin K. Petersen
fixes, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION

2018-04-09 Thread Martin K. Petersen
Johannes, > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. Applied to 4.17/scsi-fixes. Thx! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] qla2xxx: correctly shift host byte

2018-04-09 Thread Martin K. Petersen
Johannes, > The SCSI host byte has to be shifted by 16 not 6. > > As Bart pointed out this patch does not change any functionality > because DID_OK == 0, but a wrong shift is irritating for the reviewer. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen

Re: [PATCH 01/10] staging: fnic2 add initialization

2018-04-09 Thread Martin K. Petersen
e: Why is a new driver necessary? Why can't the existing fnic driver be extended? And if it can't, what can be shared between the two drivers? A good place to have that discussion would be on linux-scsi... -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] libata: blacklist Micron 500IT SSD with MU01 firmware

2018-04-05 Thread Martin K. Petersen
Sudip, > Any reply from Micron yet? No, let me poke them again. > It might be better and safe to blacklist all Micron SSDs except M500DC > and M500IT (with MG02 firmware) until Micron replies. Yeah, let's do that if I don't hear back within a day or two. -- Martin K. Petersen

Re: [PATCH] scsi: don't look for NULL devices handlers by name

2018-03-28 Thread Martin K. Petersen
Johannes, > Currently scsi_dh_lookup() doesn't check for NULL as a device > name. This combined with nvme over dm-mapth results in the following > messages emitted by device-mapper: Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][scsi-next] scsi: core: remove redundant assignment to shost->use_blk_mq

2018-03-28 Thread Martin K. Petersen
Colin, > The first assignment to shost->use_blk_mq is redundant as it is > overwritten by the following statement. Remove this redundant code. Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fnic: fix spelling mistake: "abord" -> "abort"

2018-03-28 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in message text Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: ufs: add trace event for ufs upiu

2018-03-28 Thread Martin K. Petersen
. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

2018-03-28 Thread Martin K. Petersen
ed an ack from davem. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

2018-03-28 Thread Martin K. Petersen
CROP", "4110", NULL, BLIST_NOTQ}, > - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC}, > + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC}, > {"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2}, > {"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN}, > {"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V3 0/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-21 Thread Martin K. Petersen
o > takes care to restore auto-hibernate during resume, and otherwise avoids > updating the register if the device is runtime suspended. Also a default > value of 150ms is set. Applied to 4.17/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: sysfs: reworking of the rpm_lvl and spm_lvl entries

2018-03-21 Thread Martin K. Petersen
>> managements levels was added to the ABI file. The on-write behaviour of >> these entries wasn't changed. >> >> Signed-off-by: Stanislav Nijnikov <stanislav.nijni...@wdc.com> > > Acked-by: Adrian Hunter <adrian.hun...@intel.com> Applied to 4.17/s

Re: [PATCH 0/4] scsi: arcmsr: Support Areca thunderbolt devices hot-plug

2018-03-21 Thread Martin K. Petersen
7/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

2018-03-19 Thread Martin K. Petersen
; To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled > in iscsi_tcp .slave_configure callback. Applied to 4.16/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: fix spelling mistake: "existant" -> "existent"

2018-03-19 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in debug message text Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] libata: blacklist Micron 500IT SSD with MU01 firmware

2018-03-16 Thread Martin K. Petersen
Sudip, >> Any reason to believe this deficiency is limited to MU01 firmware? > > Not really. But we also use MG02 firmware and afaik, Micron has > confirmed that MG02 is a fixed one. I have only mentioned MU01 as I > know it has the problem. Let me ask... -- Martin K. Pe

Re: [PATCH] libata: blacklist Micron 500IT SSD with MU01 firmware

2018-03-16 Thread Martin K. Petersen
ng corrupted. > + { "Micron_M500IT_*","MU01", ATA_HORKAGE_NO_NCQ_TRIM | > + ATA_HORKAGE_ZERO_AFTER_TRIM, }, Any reason to believe this deficiency is limited to MU01 firmware? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] aic7xxx/aic79xx: remove VLAs

2018-03-14 Thread Martin K. Petersen
sor-level constant instead using ARRAY_SIZE. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] bfa: remove VLA

2018-03-14 Thread Martin K. Petersen
s])) != BFA_STATUS_OK) { > + sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) { These parentheses made me blurry eyed but it's actually OK. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

2018-03-14 Thread Martin K. Petersen
STABLE_WRITES when data digest is enabled > in iscsi_tcp .slave_configure callback. Lee, Chris: Please review! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

2018-03-14 Thread Martin K. Petersen
> Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. Lee, Chris: Please review! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-14 Thread Martin K. Petersen
wnwards. It has proven quite hard to reconcile token-based and EXTENDED COPY semantics along with the desire to support stacking. But from an application/filesystem perspective everything looks the same regardless of the intricacies of the device. Nothing is preventing us from supporting other protocols... -

Re: [PATCH][next] scsi: lpfc: make several unions static, fix non-ANSI prototype

2018-03-14 Thread Martin K. Petersen
ueue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [GIT PULL] SCSI fixes for 4.16-rc5

2018-03-14 Thread Martin K. Petersen
at day that compelled me to reset to my latest public hash and redo several commits. I completely forgot that I had intended to tweak this patch when I finally got around to applying it. I should have looked closer, but it was already in my "done" pile. Botched it. Sorry about that! -- Ma

  1   2   3   4   5   6   7   8   9   10   >