Re: [PATCH v6 0/3] Add UFS host controller and Phy nodes for sc7280
On Tue, 05 Dec 2023 15:38:53 +0100, Luca Weiss wrote: > This patch adds UFS host controller and Phy nodes for Qualcomm sc7280 > SoC and enable it on some sc7280-based boards. > > Pick up the patchset from Nitin since the last revision (v4) has been > sent end of September and is blocking qcm6490-fairphone-fp5 UFS. > Applied to 6.8/scsi-queue, thanks! [1/3] scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string https://git.kernel.org/mkp/scsi/c/98bfeda31969 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v6 1/3] scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string
Luca, > Document the compatible string for the UFS found on SC7280. Applied to 6.8/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: target: Replace strlcpy with strscpy
On Thu, 31 Aug 2023 14:36:38 +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > > [...] Applied to 6.6/scsi-fixes, thanks! [1/1] scsi: target: Replace strlcpy with strscpy https://git.kernel.org/mkp/scsi/c/5c584fe6098a -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] ibmvfc: Fix invalid state machine BUG_ON
On Mon, 12 Apr 2021 18:10:09 -0600, Tyrel Datwyler wrote: > This fixes an issue hitting the BUG_ON in ibmvfc_do_work. When > going through a host action of IBMVFC_HOST_ACTION_RESET, > we change the action to IBMVFC_HOST_ACTION_TGT_DEL, > then drop the host lock, and reset the CRQ, which changes > the host state to IBMVFC_NO_CRQ. If, prior to setting the > host state to IBMVFC_NO_CRQ, ibmvfc_init_host is called, > it can then end up changing the host action to IBMVFC_HOST_ACTION_INIT. > If we then change the host state to IBMVFC_NO_CRQ, we will then > hit the BUG_ON. This patch makes a couple of changes to avoid this. > It leaves the host action to be IBMVFC_HOST_ACTION_RESET > or IBMVFC_HOST_ACTION_REENABLE until after we drop the host > lock and reset or reenable the CRQ. It also hardens the > host state machine to ensure we cannot leave the reset / reenable > state until we've finished processing the reset or reenable. Applied to 5.13/scsi-queue, thanks! [1/1] ibmvfc: Fix invalid state machine BUG_ON https://git.kernel.org/mkp/scsi/c/15cfef8623a4 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next] scsi: qla2xxx: remove unneeded if-null-free check
On Fri, 9 Apr 2021 20:09:25 +0800, Qiheng Lin wrote: > Eliminate the following coccicheck warning: > > drivers/scsi/qla2xxx/qla_os.c:4622:2-7: > WARNING: NULL check before some freeing functions is not needed. > drivers/scsi/qla2xxx/qla_os.c:4637:3-8: > WARNING: NULL check before some freeing functions is not needed. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla2xxx: remove unneeded if-null-free check https://git.kernel.org/mkp/scsi/c/efd2617100d9 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3 0/2] scsi: pm8001: tiny clean up patches
On Thu, 8 Apr 2021 20:56:31 +0800, Luo Jiaxing wrote: > Several error is reported by checkpatch.pl, here are two patches to clean > them up. Applied to 5.13/scsi-queue, thanks! [1/2] scsi: pm8001: clean up for white space https://git.kernel.org/mkp/scsi/c/8a23dbc60089 [2/2] scsi: pm8001: clean up for open brace https://git.kernel.org/mkp/scsi/c/fa5ac2beabad -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next] scsi: qla4xxx: remove unneeded if-null-free check
On Fri, 9 Apr 2021 20:03:45 +0800, Qiheng Lin wrote: > Eliminate the following coccicheck warning: > > drivers/scsi/qla4xxx/ql4_os.c:4175:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:4196:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:4215:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:6400:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:6402:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:6555:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:6557:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:7838:2-7: WARNING: > NULL check before some freeing functions is not needed. > drivers/scsi/qla4xxx/ql4_os.c:7840:2-7: WARNING: > NULL check before some freeing functions is not needed. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla4xxx: remove unneeded if-null-free check https://git.kernel.org/mkp/scsi/c/eb5a3e3b75fe -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: isci/phy.h: Remove unnecessary struct declaration
On Tue, 6 Apr 2021 18:59:13 +0800, Wan Jiabing wrote: > struct sci_phy_proto is defined at 142nd line. > The declaration here is unnecessary. Remove it. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: isci/phy.h: Remove unnecessary struct declaration https://git.kernel.org/mkp/scsi/c/8350e19658c1 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/3] scsi: mptfusion: Clear the warnings indicating that the variable is not used
On Thu, 8 Apr 2021 14:18:48 +0800, Zhen Lei wrote: > Fix below warnings: > drivers/message/fusion/mptctl.c: In function ‘mptctl_do_taskmgmt’: > drivers/message/fusion/mptctl.c:324:17: warning: variable ‘time_count’ set > but not used [-Wunused-but-set-variable] > 324 | unsigned long time_count; > | ^~ > drivers/message/fusion/mptctl.c: In function ‘mptctl_gettargetinfo’: > drivers/message/fusion/mptctl.c:1372:7: warning: variable ‘port’ set but not > used [-Wunused-but-set-variable] > 1372 | u8 port; > | ^~~~ > drivers/message/fusion/mptctl.c: In function ‘mptctl_hp_hostinfo’: > drivers/message/fusion/mptctl.c:2337:8: warning: variable ‘retval’ set but > not used [-Wunused-but-set-variable] > 2337 | int retval; > |^~ > > [...] Applied to 5.13/scsi-queue, thanks! [1/3] scsi: mptfusion: Remove unused local variable 'time_count' https://git.kernel.org/mkp/scsi/c/039cf3816648 [2/3] scsi: mptfusion: Remove unused local variable 'port' https://git.kernel.org/mkp/scsi/c/30264737bd95 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: mpt3sas: Fix out-of-bounds warnings in _ctl_addnl_diag_query
On Thu, 1 Apr 2021 11:20:54 -0500, Gustavo A. R. Silva wrote: > Fix the following out-of-bounds warnings by embedding existing > struct htb_rel_query into struct mpt3_addnl_diag_query, instead > of duplicating its members: > > include/linux/fortify-string.h:20:29: warning: '__builtin_memcpy' offset [19, > 32] from the object at 'karg' is out of the bounds of referenced subobject > 'buffer_rel_condition' with type 'short unsigned int' at offset 16 > [-Warray-bounds] > include/linux/fortify-string.h:22:29: warning: '__builtin_memset' offset [19, > 32] from the object at 'karg' is out of the bounds of referenced subobject > 'buffer_rel_condition' with type 'short unsigned int' at offset 16 > [-Warray-bounds] > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mpt3sas: Fix out-of-bounds warnings in _ctl_addnl_diag_query https://git.kernel.org/mkp/scsi/c/16660db3fc2a -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: message: fusion: remove useless variable
On Mon, 12 Apr 2021 13:59:06 +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/message/fusion/mptsas.c:783:14: warning: variable ‘vtarget’ set > but not used [-Wunused-but-set-variable]. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: message: fusion: remove useless variable https://git.kernel.org/mkp/scsi/c/cf17ff267880 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
On Wed, 7 Apr 2021 14:58:40 +0100, Colin King wrote: > The for-loop iterates with a u8 loop counter i and compares this > with the loop upper limit of pm8001_ha->max_q_num which is a u32 > type. There is a potential infinite loop if pm8001_ha->max_q_num > is larger than the u8 loop counter. Fix this by making the loop > counter the same type as pm8001_ha->max_q_num. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: pm80xx: Fix potential infinite loop https://git.kernel.org/mkp/scsi/c/40fa7394a1ad -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE
On Wed, 31 Mar 2021 14:53:25 +0800, dingsen...@163.com wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE https://git.kernel.org/mkp/scsi/c/54300bfd738b -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla2xxx: Re-use existing error handling path
On Sun, 11 Apr 2021 11:21:40 +0200, Christophe JAILLET wrote: > There is no need to duplicate some code, use the existing error handling > path to free some resources. > This is more future-proof. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla2xxx: Re-use existing error handling path https://git.kernel.org/mkp/scsi/c/5dc3468888f8 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v18 1/2] scsi: ufs: Enable power management for wlun
Hi Bart! > Patches sent to the SCSI mailing list should not have a "scsi: " prefix > in the subject. That prefix is inserted before any SCSI patches go into > Martin's tree. This doesn't actually matter. My script will add the prefix if it's not present. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: ufs: Fix out-of-bounds warnings in ufshcd_exec_raw_upiu_cmd
On Wed, 31 Mar 2021 17:43:38 -0500, Gustavo A. R. Silva wrote: > Fix the following out-of-bounds warnings by enclosing > some structure members into new structure objects upiu_req > and upiu_rsp: > > include/linux/fortify-string.h:20:29: warning: '__builtin_memcpy' offset [29, > 48] from the object at 'treq' is out of the bounds of referenced subobject > 'req_header' with type 'struct utp_upiu_header' at offset 16 [-Warray-bounds] > include/linux/fortify-string.h:20:29: warning: '__builtin_memcpy' offset [61, > 80] from the object at 'treq' is out of the bounds of referenced subobject > 'rsp_header' with type 'struct utp_upiu_header' at offset 48 [-Warray-bounds] > arch/m68k/include/asm/string.h:72:25: warning: '__builtin_memcpy' offset [29, > 48] from the object at 'treq' is out of the bounds of referenced subobject > 'req_header' with type 'struct utp_upiu_header' at offset 16 [-Warray-bounds] > arch/m68k/include/asm/string.h:72:25: warning: '__builtin_memcpy' offset [61, > 80] from the object at 'treq' is out of the bounds of referenced subobject > 'rsp_header' with type 'struct utp_upiu_header' at offset 48 [-Warray-bounds] > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: ufs: Fix out-of-bounds warnings in ufshcd_exec_raw_upiu_cmd https://git.kernel.org/mkp/scsi/c/1352eec8c0da -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next] scsi: fnic: remove unnecessary spin_lock_init() and INIT_LIST_HEAD()
On Tue, 30 Mar 2021 20:59:11 +0800, Yang Yingliang wrote: > The spinlock and list head of fnic_list is initialized statically. > It is unnecessary to initialize by spin_lock_init() and INIT_LIST_HEAD(). Applied to 5.13/scsi-queue, thanks! [1/1] scsi: fnic: remove unnecessary spin_lock_init() and INIT_LIST_HEAD() https://git.kernel.org/mkp/scsi/c/aa6f2fccd711 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] message/fusion: Use BUG_ON instead of if condition followed by BUG.
On Tue, 30 Mar 2021 05:46:01 -0700, zhouchuangao wrote: > BUG_ON() uses unlikely in if(), which can be optimized at compile time. Applied to 5.13/scsi-queue, thanks! [1/1] message/fusion: Use BUG_ON instead of if condition followed by BUG. https://git.kernel.org/mkp/scsi/c/4dec8004de29 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bfa: Remove unnecessary struct declaration
On Thu, 1 Apr 2021 14:35:34 +0800, Wan Jiabing wrote: > struct bfa_fcs_s is declared twice. One is declared > at 50th line. Remove the duplicate. > struct bfa_fcs_fabric_s is defined at 175th line. > Remove unnecessary declaration. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: bfa: Remove unnecessary struct declaration https://git.kernel.org/mkp/scsi/c/c3b0d087763f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v1 0/2] scsi: libsas: few clean up patches
On Thu, 25 Mar 2021 20:29:54 +0800, Luo Jiaxing wrote: > Two types of errors are detected by the checkpatch. > 1. Alignment between switches and cases > 2. Improper use of some spaces > > Here are the clean up patches. > > Luo Jiaxing (2): > scsi: libsas: make switch and case at the same indent in > sas_to_ata_err() > scsi: libsas: clean up for white spaces > > [...] Applied to 5.13/scsi-queue, thanks! [1/2] scsi: libsas: make switch and case at the same indent in sas_to_ata_err() https://git.kernel.org/mkp/scsi/c/c03f2422b9f5 [2/2] scsi: libsas: clean up for white spaces https://git.kernel.org/mkp/scsi/c/857a80bbd732 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: libsas: Reset num_scatter if libata mark qc as NODATA
On Thu, 18 Mar 2021 15:56:32 -0700, Jolly Shah wrote: > When the cache_type for the scsi device is changed, the scsi layer > issues a MODE_SELECT command. The caching mode details are communicated > via a request buffer associated with the scsi command with data > direction set as DMA_TO_DEVICE (scsi_mode_select). When this command > reaches the libata layer, as a part of generic initial setup, libata > layer sets up the scatterlist for the command using the scsi command > (ata_scsi_qc_new). This command is then translated by the libata layer > into ATA_CMD_SET_FEATURES (ata_scsi_mode_select_xlat). The libata layer > treats this as a non data command (ata_mselect_caching), since it only > needs an ata taskfile to pass the caching on/off information to the > device. It does not need the scatterlist that has been setup, so it does > not perform dma_map_sg on the scatterlist (ata_qc_issue). Unfortunately, > when this command reaches the libsas layer(sas_ata_qc_issue), libsas > layer sees it as a non data command with a scatterlist. It cannot > extract the correct dma length, since the scatterlist has not been > mapped with dma_map_sg for a DMA operation. When this partially > constructed SAS task reaches pm80xx LLDD, it results in below warning. > > [...] Applied to 5.12/scsi-fixes, thanks! [1/1] scsi: libsas: Reset num_scatter if libata mark qc as NODATA https://git.kernel.org/mkp/scsi/c/176ddd89171d -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] ibmvfc: Fix invalid state machine BUG_ON
Tyrel, > This fixes an issue hitting the BUG_ON in ibmvfc_do_work. When going > through a host action of IBMVFC_HOST_ACTION_RESET, we change the > action to IBMVFC_HOST_ACTION_TGT_DEL, then drop the host lock, and > reset the CRQ, which changes the host state to IBMVFC_NO_CRQ. [...] Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/3] scsi: mptfusion: Clear the warnings indicating that the variable is not used
Zhen, > Zhen Lei (3): > scsi: mptfusion: Remove unused local variable 'time_count' > scsi: mptfusion: Remove unused local variable 'port' > scsi: mptfusion: Fix error return code of mptctl_hp_hostinfo() I applied patches 1+2. I hesitate making functional changes to such an old driver. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: aacraid: Replace one-element array with flexible-array member
Hi Kees/Gustavo! >> @@ -4020,7 +4020,8 @@ static int aac_convert_sgraw2(struct aac_raw_io2 >> *rio2, int pages, int nseg, int >> } >> } >> sge[pos] = rio2->sge[nseg-1]; >> -memcpy(>sge[1], [1], (nseg_new-1)*sizeof(struct >> sge_ieee1212)); >> +memcpy(>sge[1], [1], >> + flex_array_size(rio2, sge, nseg_new - 1)); > > This was hard to validate, ... which is why I didn't apply this patch. I don't like changes which make the reader have to jump through hoops to figure out what the code actually does. I find the original much easier to understand. Silencing analyzer warnings shouldn't be done at the expense of human readers. If it is imperative to switch to flex_array_size() to quiesce checker warnings, please add a comment in the code explaining that the size evaluates to nseg_new-1 sge_ieee1212 structs. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: mpt3sas: Fix out-of-bounds warnings in _ctl_addnl_diag_query
Gustavo, > Fix the following out-of-bounds warnings by embedding existing struct > htb_rel_query into struct mpt3_addnl_diag_query, instead of > duplicating its members: Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3 0/2] scsi: pm8001: tiny clean up patches
Luo, > Several error is reported by checkpatch.pl, here are two patches to clean > them up. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
Colin, > The for-loop iterates with a u8 loop counter i and compares this with > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > There is a potential infinite loop if pm8001_ha->max_q_num is larger > than the u8 loop counter. Fix this by making the loop counter the same > type as pm8001_ha->max_q_num. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop
Hi Colin! > The for-loop iterates with a u8 loop counter i and compares this with > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > There is a potential infinite loop if pm8001_ha->max_q_num is larger > than the u8 loop counter. Fix this by making the loop counter the same > type as pm8001_ha->max_q_num. No particular objections to the patch for future-proofing. However, as far as I can tell max_q_num is capped at 64 (PM8001_MAX_MSIX_VEC). -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings
On Mon, 22 Mar 2021 17:02:38 +0100, Arnd Bergmann wrote: > The coming gcc release introduces a new warning for string operations > reading beyond the end of a fixed-length object. After testing > randconfig kernels for a while, think I have patches for any such > warnings that came up on x86, arm and arm64. > > Most of these warnings are false-positive ones, either gcc warning > about something that is entirely correct, or about something that > looks suspicious but turns out to be correct after all. > > [...] Applied to 5.13/scsi-queue, thanks! [09/11] scsi: lpfc: fix gcc -Wstringop-overread warning https://git.kernel.org/mkp/scsi/c/ada48ba70f6b -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: mptlan: Replace one-element array with flexible-array member
On Wed, 24 Mar 2021 18:33:44 -0500, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of one-element or zero-length arrays should no longer be used[2]. > > Refactor the code according to the use of a flexible-array member in > struct _SGE_TRANSACTION32 instead of one-element array. > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mptlan: Replace one-element array with flexible-array member https://git.kernel.org/mkp/scsi/c/4e2e619f3c9e -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fcoe: fix mismatched fcoe_wwn_from_mac declaration
On Mon, 22 Mar 2021 17:46:59 +0100, Arnd Bergmann wrote: > An old cleanup changed the array size from MAX_ADDR_LEN to > unspecified in the declaration, but now gcc-11 warns about this: > > drivers/scsi/fcoe/fcoe_ctlr.c:1972:37: error: argument 1 of type ‘unsigned > char[32]’ with mismatched bound [-Werror=array-parameter=] > 1972 | u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN], > | ~~^ > In file included from /git/arm-soc/drivers/scsi/fcoe/fcoe_ctlr.c:33: > include/scsi/libfcoe.h:252:37: note: previously declared as ‘unsigned char[]’ > 252 | u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned > int); > | ~~^ > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: fcoe: fix mismatched fcoe_wwn_from_mac declaration https://git.kernel.org/mkp/scsi/c/5b11c9d80bde -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/2] aic94xx: avoid -Wempty-body warning
On Mon, 22 Mar 2021 11:25:43 +0100, Arnd Bergmann wrote:
> Building with 'make W=1' shows a harmless -Wempty-body warning:
>
> drivers/scsi/aic94xx/aic94xx_init.c: In function 'asd_free_queues':
> drivers/scsi/aic94xx/aic94xx_init.c:858:62: error: suggest braces around
> empty body in an 'if' statement [-Werror=empty-body]
> 858 | ASD_DPRINTK("Uh-oh! Pending is not empty!\n");
>
> Change the empty ASD_DPRINTK() macro to no_printk(), which avoids this
> warning and adds format string checking.
Applied to 5.13/scsi-queue, thanks!
[1/2] aic94xx: avoid -Wempty-body warning
https://git.kernel.org/mkp/scsi/c/6c26379def09
[2/2] scsi: message: fusion: avoid -Wempty-body warnings
https://git.kernel.org/mkp/scsi/c/472c1cfb10f1
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] mvsas: avoid -Wempty-body warning
On Mon, 22 Mar 2021 11:33:09 +0100, Arnd Bergmann wrote:
> Building with 'make W=1' shows a few harmless -Wempty-body warning for
> the mvsas driver:
>
> drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_phy_reset':
> drivers/scsi/mvsas/mv_94xx.c:278:63: error: suggest braces around empty body
> in an 'if' statement [-Werror=empty-body]
> 278 | mv_dprintk("phy hard reset failed.\n");
> | ^
> drivers/scsi/mvsas/mv_sas.c: In function 'mvs_task_prep':
> drivers/scsi/mvsas/mv_sas.c:723:57: error: suggest braces around empty body
> in an 'else' statement [-Werror=empty-body]
> 723 | SAS_ADDR(dev->sas_addr));
> | ^
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] mvsas: avoid -Wempty-body warning
https://git.kernel.org/mkp/scsi/c/ae3645d29d4e
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] SCSI: fusion: mpi_ioc.h: Replace one-element array with flexible-array member
On Wed, 24 Mar 2021 18:00:36 -0500, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of one-element or zero-length arrays should no longer be used[2]. > > Also, this helps with the ongoing efforts to enable -Warray-bounds by > fixing the following warning: > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] SCSI: fusion: mpi_ioc.h: Replace one-element array with flexible-array member https://git.kernel.org/mkp/scsi/c/ed46ccc7fe76 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide
On Tue, 30 Mar 2021 08:19:56 +0100, Sergei Trofimovich wrote: > Some of the structs contain `atomic_t` values and are not intended to be > sent to IO controller as is. > > The change adds __packed to every struct and union in the file. > Follow-up commits will fix `atomic_t` problems. > > The commit is a no-op at least on ia64: > $ diff -u <(objdump -d -r old.o) <(objdump -d -r new.o) Applied to 5.12/scsi-fixes, thanks! [1/3] hpsa: use __packed on individual structs, not header-wide https://git.kernel.org/mkp/scsi/c/5482a9a1a8fd [2/3] hpsa: fix boot on ia64 (atomic_t alignment) https://git.kernel.org/mkp/scsi/c/02ec144292bc [3/3] hpsa: add an assert to prevent from __packed reintroduction https://git.kernel.org/mkp/scsi/c/e01a00ff62ad -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 6/6] Fix spelling typo of is
On Fri, 26 Mar 2021 11:04:12 +0800, qiumibaoz...@163.com wrote: > Applied to 5.13/scsi-queue, thanks! [6/6] Fix spelling typo of is https://git.kernel.org/mkp/scsi/c/ce0b6e388772 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] __scsi_remove_device: fix comments minor error
On Fri, 26 Mar 2021 14:09:02 +0800, dudengke wrote: > Applied to 5.13/scsi-queue, thanks! [1/1] __scsi_remove_device: fix comments minor error https://git.kernel.org/mkp/scsi/c/eee8910fe0b5 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next 2/2] scsi: myrs: Make symbols DAC960_{GEM/BA/LP}_privdata static
On Sat, 27 Mar 2021 15:31:57 +0800, Shixin Liu wrote:
> This symbol is not used outside of myrs.c, so we can marks it static.
Applied to 5.13/scsi-queue, thanks!
[2/2] scsi: myrs: Make symbols DAC960_{GEM/BA/LP}_privdata static
https://git.kernel.org/mkp/scsi/c/e27f3c88e250
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: scsi_priv: Remove duplicate declaration
On Sat, 27 Mar 2021 11:08:50 +0800, Wan Jiabing wrote: > struct request and struct request_queue have been > declared at forward struct declaration. > Remove the duplicate and reorder the forward declaration > to be in alphabetic order. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: scsi_priv: Remove duplicate declaration https://git.kernel.org/mkp/scsi/c/fe515ac82768 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] include: scsi: scsi_host_cmd_pool is declared twice
On Thu, 25 Mar 2021 14:46:31 +0800, Wan Jiabing wrote: > struct scsi_host_cmd_pool has been declared. Remove the duplicate. Applied to 5.13/scsi-queue, thanks! [1/1] include: scsi: scsi_host_cmd_pool is declared twice https://git.kernel.org/mkp/scsi/c/6bfe9855daa3 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next 1/2] scsi: myrb: Make symbols DAC960_{LA/PG/PD/P}_privdata static
On Sat, 27 Mar 2021 15:31:56 +0800, Shixin Liu wrote:
> This symbol is not used outside of myrb.c, so we can marks it static.
Applied to 5.13/scsi-queue, thanks!
[1/2] scsi: myrb: Make symbols DAC960_{LA/PG/PD/P}_privdata static
https://git.kernel.org/mkp/scsi/c/182ad87c95e7
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qedi: emove redundant assignment to variable err
On Sat, 27 Mar 2021 23:06:50 +, Colin King wrote: > variable err is assigned -ENOMEM followed by an error return path > via label err_udev that does not access the variable and returns > with the -ENOMEM error return code. The assignment to err is > redundant and can be removed. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qedi: emove redundant assignment to variable err https://git.kernel.org/mkp/scsi/c/8dc602529681 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] Fix fnic driver to remove bogus ratelimit messages.
On Tue, 23 Mar 2021 10:27:56 -0700, ldun...@suse.com wrote:
> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid
> looding when vlan is not set by the switch.i") added
> printk_ratelimit() in front of a couple of debug-mode
> messages, to reduce logging overrun when debugging the
> driver. The code:
>
> > if (printk_ratelimit())
> > FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
> > "Start VLAN Discovery\n");
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] Fix fnic driver to remove bogus ratelimit messages.
https://git.kernel.org/mkp/scsi/c/d2478dd25691
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: a100u2w: remove unused variable biosaddr
On Thu, 25 Mar 2021 17:07:31 +, Colin King wrote: > The variable biosaddr is being assigned a value that is never read, > the variable is redundant and can be safely removed. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: a100u2w: remove unused variable biosaddr https://git.kernel.org/mkp/scsi/c/92b4c52c43e1 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ibmvscsi: delete the useless casting value returned
On Fri, 12 Mar 2021 10:18:53 +0800, Wang Qing wrote: > Fix the following coccicheck warning: > WARNING: casting value returned by memory allocation function is useless. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: ibmvscsi: delete the useless casting value returned https://git.kernel.org/mkp/scsi/c/0d556a21a9da -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH RESEND] scsi: ufs: Remove unnecessary null checks in ufshcd_find_max_sup_active_icc_level()
On Fri, 19 Mar 2021 15:09:16 +0800, Yue Hu wrote: > Since vcc/vccq/vccq2 have already been null checked before using. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: ufs: Remove unnecessary null checks in ufshcd_find_max_sup_active_icc_level() https://git.kernel.org/mkp/scsi/c/0873045f63c4 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: scsi_dh: Fix a typo
On Mon, 22 Mar 2021 12:17:24 +0530, Bhaskar Chowdhury wrote: > s/infrastruture/infrastructure/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: scsi_dh: Fix a typo https://git.kernel.org/mkp/scsi/c/ae98ddf05fdb -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bfa: Fix a typo in two places
On Tue, 23 Mar 2021 02:28:21 +0530, Bhaskar Chowdhury wrote: > s/defintions/definitions/ two different places. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: bfa: Fix a typo in two places https://git.kernel.org/mkp/scsi/c/9991ca001b9c -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: mpt3sas: Fix a typo
On Mon, 22 Mar 2021 08:51:45 +0530, Bhaskar Chowdhury wrote: > s/encloure/enclosure/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mpt3sas: Fix a typo https://git.kernel.org/mkp/scsi/c/206a3afa9482 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: dc395x: Use bitwise instead of arithmetic operator for flags
On Tue, 9 Mar 2021 11:39:13 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/dc395x.c:2921:28-29: WARNING: sum of probable bitmasks, > consider |. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: dc395x: Use bitwise instead of arithmetic operator for flags https://git.kernel.org/mkp/scsi/c/973c920811bc -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: delete the useless casting value returned
On Fri, 12 Mar 2021 10:18:19 +0800, Wang Qing wrote: > Fix the following coccicheck warning: > WARNING: casting value returned by memory allocation function is useless. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: fnic: delete the useless casting value returned https://git.kernel.org/mkp/scsi/c/3ba9f38ed43d -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] message: fusion: delete the useless casting value returned
On Fri, 12 Mar 2021 10:18:03 +0800, Wang Qing wrote: > Fix the following coccicheck warning: > WARNING: casting value returned by memory allocation function is useless. Applied to 5.13/scsi-queue, thanks! [1/1] message: fusion: delete the useless casting value returned https://git.kernel.org/mkp/scsi/c/690209d5ebef -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bnx2fc: Fix a typo
On Mon, 22 Mar 2021 12:05:30 +0530, Bhaskar Chowdhury wrote: > s/struture/structure/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: bnx2fc: Fix a typo https://git.kernel.org/mkp/scsi/c/5fae809faec6 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: esp_scsi: Trivial typo fixes
On Wed, 24 Mar 2021 11:43:18 +0530, Bhaskar Chowdhury wrote: > s/conditon/condition/ > s/pecularity/peculiarity/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: esp_scsi: Trivial typo fixes https://git.kernel.org/mkp/scsi/c/835b8c16a0e3 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: csiostor: Fix a typo
On Fri, 19 Mar 2021 14:53:11 +0530, Bhaskar Chowdhury wrote: > s/boudaries/boundaries/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: csiostor: Fix a typo https://git.kernel.org/mkp/scsi/c/a89562e31f01 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: lpfc: A mundane typo fix
On Wed, 24 Mar 2021 12:18:29 +0530, Bhaskar Chowdhury wrote: > s/conditons/conditions/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: lpfc: A mundane typo fix https://git.kernel.org/mkp/scsi/c/f1891f9bbc46 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: lpfc: Fix some typo error
On Mon, 22 Mar 2021 15:56:45 +0800, samirweng1979 wrote: > change 'lenth' to 'length'. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: lpfc: Fix some typo error https://git.kernel.org/mkp/scsi/c/89bbf550eafc -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: pm8001: avoid -Wrestrict warning
On Tue, 23 Mar 2021 13:54:23 +0100, Arnd Bergmann wrote:
> On some configurations, gcc warns about overlapping source and
> destination arguments to snprintf:
>
> drivers/scsi/pm8001/pm8001_init.c: In function 'pm8001_request_msix':
> drivers/scsi/pm8001/pm8001_init.c:977:3: error: 'snprintf' argument 4 may
> overlap destination object 'pm8001_ha' [-Werror=restrict]
> 977 | snprintf(drvname, len, "%s-%d", pm8001_ha->name, i);
> | ^~~
> drivers/scsi/pm8001/pm8001_init.c:962:56: note: destination object referenced
> by 'restrict'-qualified argument 1 was declared here
> 962 | static u32 pm8001_request_msix(struct pm8001_hba_info *pm8001_ha)
> |^
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: pm8001: avoid -Wrestrict warning
https://git.kernel.org/mkp/scsi/c/c2255ece2be2
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla1280: fix warning comparing pointer to 0
On Mon, 15 Mar 2021 11:49:19 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/scsi/qla1280.c:3057:37-38: WARNING comparing pointer to 0. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla1280: fix warning comparing pointer to 0 https://git.kernel.org/mkp/scsi/c/3070c72155c5 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: mac53c94: fix warning comparing pointer to 0
On Wed, 10 Mar 2021 12:16:11 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/scsi/mac53c94.c:470:29-30: WARNING comparing pointer to 0. > ./drivers/scsi/mac53c94.c:349:12-13: WARNING comparing pointer to 0. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mac53c94: fix warning comparing pointer to 0 https://git.kernel.org/mkp/scsi/c/be20b96b6319 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust
On Wed, 10 Mar 2021 23:16:02 +0100, Rasmus Villemoes wrote: > Instead of strcpy'ing into a stack buffer, just let additional_notice > point to a string literal living in .rodata. This is better in a few > ways: > > - Smaller .text - instead of gcc compiling the strcpys as a bunch of > immediate stores (effectively encoding the string literal in the > instruction stream), we only pay the price of storing the literal in > .rodata. > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust https://git.kernel.org/mkp/scsi/c/adb253433dc8 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bfa: fix warning comparing pointer to 0
On Tue, 16 Mar 2021 15:48:50 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/scsi/bfa/bfad_bsg.c:3412:29-30: WARNING comparing pointer to > 0. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: bfa: fix warning comparing pointer to 0 https://git.kernel.org/mkp/scsi/c/1630e752fb83 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)
Arnd, > I think Martin is still waiting for a fixed version of the patch, as > the proposed patch from March 12 only solves the immediate symptom, > but not the underlying problem of the CommandList structure being > marked as unaligned. If it gets fixed, the new version should work on > all architectures. Yep. I unfortunately don't have any hpsa adapters to test with. Was hoping somebody with hardware would attempt to fix up the struct properly. Given -rc5 we're running out of time so for 5.12 it's probably best if we queue up the workaround. I would prefer an amalgamation of Don's and Sergei's patches, though. I do like the assert so we can catch problems early. But really, somebody should fix this. While hpsa may be out of commercial support, Linux will support the driver it until there are no more users. And the current structure packing is just wrong. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] Fix fnic driver to remove bogus ratelimit messages.
Lee,
> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid looding
> when vlan is not set by the switch.i") added printk_ratelimit() in
> front of a couple of debug-mode messages, to reduce logging overrun
> when debugging the driver.
Applied to 5.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: aacraid: Replace one-element array with flexible-array member
Gustavo, > Precisely this sort of confusion is one of the things we want to avoid > by using flexible-array members instead of one-element arrays. Ah, you're right! Now that I look at it again I also don't think that was the issue that originally caused concern. @@ -4020,7 +4020,8 @@ static int aac_convert_sgraw2(struct aac_raw_io2 *rio2, int pages, int nseg, int } } sge[pos] = rio2->sge[nseg-1]; - memcpy(>sge[1], [1], (nseg_new-1)*sizeof(struct sge_ieee1212)); + memcpy(>sge[1], [1], + flex_array_size(rio2, sge, nseg_new - 1)); kfree(sge); rio2->sgeCnt = cpu_to_le32(nseg_new); I find it counter-intuitive to use the type of the destination array to size the amount of source data to copy. "Are source and destination same type? Does flex_array_size() do the right thing given the ->sge[1] destination offset?". It wasn't immediately obvious. To me, "copy this many scatterlist entries" in the original is much more readable. That said, this whole function makes my head hurt! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI
ain the function name https://git.kernel.org/mkp/scsi/c/2efd8631d6a5 [19/36] scsi: isci: phy: Provide function name and demote non-conforming header https://git.kernel.org/mkp/scsi/c/6ab7ca5139b7 [20/36] scsi: isci: request: Fix a myriad of kernel-doc issues https://git.kernel.org/mkp/scsi/c/db35a0835357 [21/36] scsi: isci: host: Fix bunch of kernel-doc related issues https://git.kernel.org/mkp/scsi/c/44b7ca966128 [22/36] scsi: isci: task: Demote non-conformant header and remove superfluous param https://git.kernel.org/mkp/scsi/c/0afdee03f2e7 [23/36] scsi: isci: remote_node_table: Fix a bunch of kernel-doc misdemeanours https://git.kernel.org/mkp/scsi/c/103d61927ed3 [24/36] scsi: isci: remote_node_context: Fix one function header and demote a couple more https://git.kernel.org/mkp/scsi/c/ad276048f1bc [25/36] scsi: isci: port_config: Fix a bunch of doc-rot and demote abuses https://git.kernel.org/mkp/scsi/c/29faa5ce26ae [26/36] scsi: isci: remote_device: Fix a bunch of doc-rot issues https://git.kernel.org/mkp/scsi/c/242e15d7a4f4 [27/36] scsi: isci: request: Fix doc-rot issue relating to 'ireq' param https://git.kernel.org/mkp/scsi/c/a8604e44514d [28/36] scsi: isci: port: Fix a bunch of kernel-doc issues https://git.kernel.org/mkp/scsi/c/7292a8b039c5 [29/36] scsi: isci: remote_node_context: Demote kernel-doc abuse https://git.kernel.org/mkp/scsi/c/d2d480f132e8 [30/36] scsi: isci: remote_node_table: Provide some missing params and remove others https://git.kernel.org/mkp/scsi/c/188f513dd22c [31/36] scsi: cxlflash: main: Fix a little do-rot https://git.kernel.org/mkp/scsi/c/cf0ad7a15ac5 [32/36] scsi: cxlflash: superpipe: Fix a few misnaming issues https://git.kernel.org/mkp/scsi/c/32b3edfd28f8 [33/36] scsi: ibmvscsi: Fix a bunch of kernel-doc related issues https://git.kernel.org/mkp/scsi/c/841d7df0d416 [34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation https://git.kernel.org/mkp/scsi/c/dd9c77297148 [35/36] scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section 'NOTE' https://git.kernel.org/mkp/scsi/c/cba3ebfc008e [36/36] scsi: cxlflash: vlun: Fix some misnaming related doc-rot https://git.kernel.org/mkp/scsi/c/a690baa47fd1 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: ufs: Tidy up WB configuration code
On Thu, 18 Mar 2021 17:55:36 +0800, Yue Hu wrote:
> There are similar code implementations for WB configuration in
> ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. We can
> extract the part to create a new helper with a flag parameter to
> reduce code duplication.
>
> Meanwhile, rename ufshcd_wb_ctrl() to ufshcd_wb_toggle() for better
> readability.
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ufs: Tidy up WB configuration code
https://git.kernel.org/mkp/scsi/c/3b5f3c0d0548
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Rudimentary spelling fixes throughout the file fnic_trace.c
On Wed, 17 Mar 2021 14:52:40 +0530, Bhaskar Chowdhury wrote: > Rudimentary typo fixes throughout the file. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: fnic: Rudimentary spelling fixes throughout the file fnic_trace.c https://git.kernel.org/mkp/scsi/c/bcf064bc2a3b -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] Fix EH race and MQ support
On Fri, 19 Mar 2021 14:50:27 -0600, Tyrel Datwyler wrote: > Changes to the locking pattern protecting the event lists and handling of scsi > command completion introduced a race where an ouststanding command that EH is > waiting ifor to complete is no longer identifiable by being on the sent list, > but > instead as a command that is not on the free list. This is a result of moving > commands to be completed off the sent list to a private list to be completed > outside the list lock. > > [...] Applied to 5.12/scsi-fixes, thanks! [1/2] ibmvfc: fix potential race in ibmvfc_wait_for_ops https://git.kernel.org/mkp/scsi/c/8b1c9b202549 [2/2] ibmvfc: make ibmvfc_wait_for_ops MQ aware https://git.kernel.org/mkp/scsi/c/62fc2661482b -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] message: fusion: Fix a typo in the file mptbase.h
On Wed, 17 Mar 2021 15:42:38 +0530, Bhaskar Chowdhury wrote: > s/contets/contents/ Applied to 5.13/scsi-queue, thanks! [1/1] message: fusion: Fix a typo in the file mptbase.h https://git.kernel.org/mkp/scsi/c/69a1709e2ec8 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()
On Sun, 7 Mar 2021 19:30:24 -0800, Jia-Ju Bai wrote: > When kzalloc() returns NULL to qedi->global_queues[i], no error return > code of qedi_alloc_global_queues() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. Applied to 5.12/scsi-fixes, thanks! [1/1] scsi: qedi: fix error return code of qedi_alloc_global_queues() https://git.kernel.org/mkp/scsi/c/f69953837ca5 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: mpt3sas: fix error return code of mpt3sas_base_attach()
On Sun, 7 Mar 2021 19:52:41 -0800, Jia-Ju Bai wrote: > When kzalloc() returns NULL, no error return code of > mpt3sas_base_attach() is assigned. > To fix this bug, r is assigned with -ENOMEM in this case. Applied to 5.12/scsi-fixes, thanks! [1/1] scsi: mpt3sas: fix error return code of mpt3sas_base_attach() https://git.kernel.org/mkp/scsi/c/3401ecf7fc1b -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust
Rasmus, > Instead of strcpy'ing into a stack buffer, just let additional_notice > point to a string literal living in .rodata. This is better in a few > ways: Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: aacraid: Replace one-element array with flexible-array member
Hi Gustavo! Your changes and the original code do not appear to be functionally equivalent. > @@ -1235,8 +1235,8 @@ static int aac_read_raw_io(struct fib * fib, struct > scsi_cmnd * cmd, u64 lba, u3 > if (ret < 0) > return ret; > command = ContainerRawIo2; > - fibsize = sizeof(struct aac_raw_io2) + > - ((le32_to_cpu(readcmd2->sgeCnt)-1) * sizeof(struct > sge_ieee1212)); > + fibsize = struct_size(readcmd2, sge, > + le32_to_cpu(readcmd2->sgeCnt)); The old code allocated sgeCnt-1 elements (whether that was a mistake or not I do not know) whereas the new code would send a larger fib to the ASIC. I don't have any aacraid adapters and I am hesitant to merging changes that have not been validated on real hardware. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() https://git.kernel.org/mkp/scsi/c/1b8a7ee9308e [20/30] scsi: be2iscsi: be_main: Provide missing function name in header https://git.kernel.org/mkp/scsi/c/a905a1dce8bf [21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header https://git.kernel.org/mkp/scsi/c/ab4bab7a977d [22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description https://git.kernel.org/mkp/scsi/c/0a386beb7ebd [23/30] scsi: initio: Remove unused variable 'prev' https://git.kernel.org/mkp/scsi/c/78e40ac8b696 [24/30] scsi: a100u2w: Remove unused variable 'bios_phys' https://git.kernel.org/mkp/scsi/c/fb5b29b2ad3f [25/30] scsi: dc395x: Fix incorrect naming in function headers https://git.kernel.org/mkp/scsi/c/167b7e6bfbf5 [26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header https://git.kernel.org/mkp/scsi/c/6b71f60ca205 [27/30] scsi: myrs: Remove a couple of unused 'status' variables https://git.kernel.org/mkp/scsi/c/3cb0cfb557cd [28/30] scsi: 3w-: Remove 2 unused variables 'response_que_value' and 'tw_dev' https://git.kernel.org/mkp/scsi/c/6c31cb74a1ce [29/30] scsi: 3w-9xxx: Remove a few set but unused variables https://git.kernel.org/mkp/scsi/c/ea7fb5344ad0 [30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' https://git.kernel.org/mkp/scsi/c/475bff65c431 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI
1e2c6 [18/30] scsi: pm8001: pm8001_hwi: Fix some misnamed function descriptions https://git.kernel.org/mkp/scsi/c/6b87e435e4bc [19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue https://git.kernel.org/mkp/scsi/c/e39c31a7435a [20/30] scsi: bnx2fc: bnx2fc_tgt: Fix misnaming of bnx2fc_free_session_resc() https://git.kernel.org/mkp/scsi/c/a7f4242d1207 [21/30] scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at least 13 years https://git.kernel.org/mkp/scsi/c/241b37ac5859 [22/30] scsi: pm8001: pm80xx_hwi: Fix a bunch of doc-rotted function headers https://git.kernel.org/mkp/scsi/c/7cdaf12ea50a [23/30] scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues https://git.kernel.org/mkp/scsi/c/f11c8b42423f [24/30] scsi: aacraid: rx: Fix misspelling of _aac_rx_init() https://git.kernel.org/mkp/scsi/c/7df1daed3330 [25/30] scsi: lpfc: lpfc_ct: Fix formatting and misspelling issues https://git.kernel.org/mkp/scsi/c/964bc8c4adb3 [26/30] scsi: libfc: fc_lport: Fix some possible copy/paste issues https://git.kernel.org/mkp/scsi/c/4a4db603d0b7 [27/30] scsi: lpfc: lpfc_hbadisc: Fix incorrect naming of __lpfc_update_fcf_record() https://git.kernel.org/mkp/scsi/c/3884ce1539b0 [28/30] scsi: mpt3sas: mpt3sas_base: Fix misspelling of _base_put_smid_default_atomic() https://git.kernel.org/mkp/scsi/c/e015e0ded135 [29/30] scsi: lpfc: lpfc_nportdisc: Fix misspelling of lpfc_defer_acc_rsp() (no commit info) [30/30] scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the heap https://git.kernel.org/mkp/scsi/c/2111ba8781da -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg()
On Wed, 10 Mar 2021 16:27:41 +0800, Yue Hu wrote: > The local variable _ret_ is always zero, so we can remove it and just > return 0 directly in the end. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg() https://git.kernel.org/mkp/scsi/c/2a8561b78e37 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: Mundane spelling fixes in the file qla1280.c
On Mon, 15 Mar 2021 07:46:10 +0530, Bhaskar Chowdhury wrote: > s/quantites/quantities/ > s/Unfortunely/Unfortunately/ Applied to 5.13/scsi-queue, thanks! [1/1] scsi: Mundane spelling fixes in the file qla1280.c https://git.kernel.org/mkp/scsi/c/1bf5fa1a2916 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: 3w-sas: remove unneeded variable 'retval'
On Tue, 9 Mar 2021 14:41:04 +0800, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/scsi/3w-sas.c:866:5-11: Unneeded variable: "retval". Return > "1" on line 898 Applied to 5.13/scsi-queue, thanks! [1/1] scsi: 3w-sas: remove unneeded variable 'retval' https://git.kernel.org/mkp/scsi/c/2af0bf34ae1f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] Fix spelling typo of conditions
On Tue, 16 Mar 2021 10:51:41 +0800, qiumibaoz...@163.com wrote: > Applied to 5.13/scsi-queue, thanks! [1/1] Fix spelling typo of conditions https://git.kernel.org/mkp/scsi/c/ac5669bf79d9 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead
On Sat, 13 Mar 2021 10:41:15 +0800, Wang Qing wrote: > use dma_pool_zalloc instead of dma_pool_alloc and memset Applied to 5.13/scsi-queue, thanks! [1/1] scsi: qla2xxx: use dma_pool_zalloc instead https://git.kernel.org/mkp/scsi/c/720efdd23f96 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings
On Thu, 4 Feb 2021 22:22:34 +0530, Vinod Koul wrote: > Document "qcom,sm8250-ufshc" and "qcom,sm8350-ufshc" compatible string. > Use of "qcom,sm8250-ufshc" is already present upstream, so add misiing > documentation. "qcom,sm8350-ufshc" is for UFS HC found in SM8350 SoC. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings https://git.kernel.org/mkp/scsi/c/4517e77eb83d -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 1/1] scsi: storvsc: Enable scatterlist entry lengths > 4Kbytes
On Tue, 23 Feb 2021 14:44:54 -0800, Michael Kelley wrote: > storvsc currently sets .dma_boundary to limit scatterlist entries > to 4 Kbytes, which is less efficient with huge pages that offer > large chunks of contiguous physical memory. Improve the algorithm > for creating the Hyper-V guest physical address PFN array so > that scatterlist entries with lengths > 4Kbytes are handled. > As a result, remove the .dma_boundary setting. > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: storvsc: Enable scatterlist entry lengths > 4Kbytes https://git.kernel.org/mkp/scsi/c/3d9c3dcc58e9 -- Martin K. Petersen Oracle Linux Engineering
Re: v3: scsi: ufshcd: use a macro for UFS versions
On Wed, 10 Mar 2021 15:33:30 +, Caleb Connolly wrote: > When using a device with UFS > 2.1 the error "invalid UFS version" is > misleadingly printed. There was a patch for this almost a year > ago to which this solution was suggested. > > This series replaces the use of the growing UFSHCI_VERSION_xy macros with > an inline function to encode a major and minor version into the scheme > used on devices, that being: > > [...] Applied to 5.13/scsi-queue, thanks! [1/3] scsi: ufshcd: use a function to calculate versions https://git.kernel.org/mkp/scsi/c/514288180178 [2/3] scsi: ufs: qcom: use ufshci_version function https://git.kernel.org/mkp/scsi/c/f065aca20a26 [3/3] scsi: ufshcd: remove version check https://git.kernel.org/mkp/scsi/c/4f5e51c0ebf0 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: csiostor: Assign boolean values to a bool variable
On Tue, 9 Mar 2021 17:37:48 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/csiostor/csio_scsi.c:150:9-10: WARNING: return of 0/1 in > function 'csio_scsi_itnexus_loss_error' with return type bool. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: csiostor: Assign boolean values to a bool variable https://git.kernel.org/mkp/scsi/c/2ed0fc2b9a79 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: mvumi: Use true and false for bool variable
On Thu, 18 Feb 2021 18:16:11 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/mvumi.c:69:9-10: WARNING: return of 0/1 in function > 'tag_is_empty' with return type bool. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mvumi: Use true and false for bool variable https://git.kernel.org/mkp/scsi/c/59f90f5e6c80 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: mpt3sas: Replace unnecessary dynamic allocation with a static one
On Wed, 10 Mar 2021 17:59:51 -0600, Gustavo A. R. Silva wrote: > Dynamic memory allocation isn't actually needed and it can be > replaced by statically allocating memory for struct object > io_unit_pg3 with 36 hardcoded entries for its GPIOVal array. > > Also, this helps the with ongoing efforts to enable -Warray-bounds > by fixing the following warning: > > [...] Applied to 5.13/scsi-queue, thanks! [1/1] scsi: mpt3sas: Replace unnecessary dynamic allocation with a static one https://git.kernel.org/mkp/scsi/c/a1c4d7741323 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs-pci: Add support for Intel LKF
On Fri, 12 Mar 2021 10:06:20 +0200, Adrian Hunter wrote: > Add PCI ID and callbacks to support Intel LKF. > > This includes the ability to use an ACPI device-specific method (DSM) to > perform a UFS device reset. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: ufs-pci: Add support for Intel LKF https://git.kernel.org/mkp/scsi/c/b2c57925df1f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context
On Sat, 20 Feb 2021 10:39:51 +0100, Christophe JAILLET wrote: > 'mpt3sas_get_port_by_id()' can be called when a spinlock is hold. So use > GFP_ATOMIC instead of GFP_KERNEL when allocating memory. > > Issue spotted by call_kern.cocci: > ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function > mpt3sas_get_port_by_id called on line 7125 inside lock on line 7123 but uses > GFP_KERNEL > ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function > mpt3sas_get_port_by_id called on line 6842 inside lock on line 6839 but uses > GFP_KERNEL > ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function > mpt3sas_get_port_by_id called on line 6854 inside lock on line 6851 but uses > GFP_KERNEL > ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function > mpt3sas_get_port_by_id called on line 7706 inside lock on line 7702 but uses > GFP_KERNEL > ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function > mpt3sas_get_port_by_id called on line 10260 inside lock on line 10256 but > uses GFP_KERNEL Applied to 5.12/scsi-fixes, thanks! [1/1] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context https://git.kernel.org/mkp/scsi/c/a50bd6461690 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI
Lee, > This set is part of a larger effort attempting to clean-up W=1 kernel > builds, which are currently overwhelmingly riddled with niggly little > warnings. Applied to 5.13/scsi-staging, thanks! I fixed a few little things. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/8] [Set 3 v2] Rid W=1 warnings in SCSI
Lee, > This set contains functional changes. > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: ufs: Tidy up WB configuration code
Yue,
> There are similar code implementations for WB configuration in
> ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. We can extract
> the part to create a new helper with a flag parameter to reduce code
> duplication.
Applied to 5.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Add selector to ufshcd_query_flag* APIs
Daejun, > Unlike other query APIs in UFS, ufshcd_query_flag has a fixed selector > as 0. This patch allows ufshcd_query_flag API to choose selector value > by parameter. I don't see any users of the added parameter. Am I missing something? -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs-pci: Add support for Intel LKF
Adrian, > Add PCI ID and callbacks to support Intel LKF. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: mpt3sas: Replace unnecessary dynamic allocation with a static one
Gustavo, > Dynamic memory allocation isn't actually needed and it can be replaced > by statically allocating memory for struct object io_unit_pg3 with 36 > hardcoded entries for its GPIOVal array. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: v3: scsi: ufshcd: use a macro for UFS versions
Caleb, > When using a device with UFS > 2.1 the error "invalid UFS version" is > misleadingly printed. There was a patch for this almost a year > ago to which this solution was suggested. Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: ufs: sysfs: Print string descriptors as raw data
Hi Arthur! > Could you please consider to take this patch? The patch needs some reviews. I suggest you repost. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)
Arnd, > Actually that still feels wrong: the annotation of the struct is to > pack every member, which causes the access to be done in byte units on > architectures that do not have hardware unaligned load/store > instructions, at least for things like atomic_read() that does not go > through a cmpxchg() or ll/sc cycle. > This change may fix itanium, but it's still not correct. Other > architectures would have already been broken before the recent change, > but that's not a reason against fixing them now. I agree. I understand why there are restrictions on fields consumed by the hardware. But for fields internal to the driver the packing doesn't make sense to me. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
Lee, > Would you like them in 1 or 2 sets? As long as they are trivial, one set is fine. What does help is to split by complexity. In your two previous series I would have preferred the mpt3sas and bfa patches that actually change code to be posted separately. Just to make sure they don't get lost in a sea of trivial changes. IOW, if the patches contain substantial functional changes I'd prefer them to be separate from all the kernel-doc, function prototype, etc. fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings
Vinod, >> Document "qcom,sm8250-ufshc" and "qcom,sm8350-ufshc" compatible string. >> Use of "qcom,sm8250-ufshc" is already present upstream, so add misiing >> documentation. "qcom,sm8350-ufshc" is for UFS HC found in SM8350 SoC. > > Gentle reminder for this patch, Rob has acked this Was not really expecting a DT patch to be routed through SCSI. But no worries. I've queued it up. -- Martin K. Petersen Oracle Linux Engineering
