Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-25 Thread Martin Pärtel
> > Then my analysis is correct that you simply missed filtering out the > si codes that are not signal specific and do not use the fault layout > in struct siginfo. > ... > I would say that you really need a > white-list of si_codes that whose use of struct siginfo that you know. > Otherwise you

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-25 Thread Martin Pärtel
> > Then my analysis is correct that you simply missed filtering out the > si codes that are not signal specific and do not use the fault layout > in struct siginfo. > ... > I would say that you really need a > white-list of si_codes that whose use of struct siginfo that you know. > Otherwise you

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Martin Pärtel
And once more in plain text.. On 25 April 2018 at 01:00, Martin Pärtel <martin.par...@gmail.com> wrote: > > Hi all, > > This was ages ago, but from what I remember... > >> >> Having a second look I really don't understand what relay_signal is >> trying to d

Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

2018-04-24 Thread Martin Pärtel
And once more in plain text.. On 25 April 2018 at 01:00, Martin Pärtel wrote: > > Hi all, > > This was ages ago, but from what I remember... > >> >> Having a second look I really don't understand what relay_signal is >> trying to do. >> >> The functi