Re: [PATCH 1/5] kconfig: remove unneeded setsym label in conf_read_simple()

2018-12-07 Thread Masahiro Yamada
On Fri, Nov 30, 2018 at 6:17 PM Masahiro Yamada wrote: > > The two 'goto setsym' statements are reachable only when sym == NULL. > > The code below the 'setsym:' label does nothing when sym == NULL > since there is just one if-block guarded by 'if (sym && ...)'. >

Re: [PATCH 6/7] microblaze: fix race condition in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 1:32 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > I fixed a race condition in the parallel building of ARM in commit > > 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not > > generate invalid images"

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
On Sat, Dec 8, 2018 at 12:20 AM Michal Simek wrote: > > On 07. 12. 18 14:29, Michal Simek wrote: > > On 07. 12. 18 12:29, Masahiro Yamada wrote: > >> On Thu, Dec 6, 2018 at 11:55 PM Michal Simek wrote: > >>> > >>> On 03. 12. 18 8:50, Masahiro Yama

[PATCH 1/6] microblaze: adjust the help to the real behavior

2018-12-07 Thread Masahiro Yamada
mu nommu_defconfig - Build for nommu Signed-off-by: Masahiro Yamada --- Changes in v2: - Show all the four images in help - Delete redundant *_defconfig explanation arch/microblaze/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/microb

[PATCH 4/6] microblaze: add linux.bin* and simpleImage.* to PHONY

2018-12-07 Thread Masahiro Yamada
-by: Masahiro Yamada --- Changes in v2: None arch/microblaze/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index ff5abbd..180dffa 100644 --- a/arch/microblaze/Makefile +++ b/arch/microblaze/Makefile @@ -82,11 +82,13

[PATCH 3/6] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile

2018-12-07 Thread Masahiro Yamada
nes to not change the behavior. Lastly, this commit fixes "make ARCH=microblaze clean". Previously, it only cleaned up the unstrip image. Now, all the simpleImage files are cleaned. Signed-off-by: Masahiro Yamada --- Changes in v2: - Squash the first patch into this - Separate simpleImag

[PATCH 6/6] microblaze: remove the explicit removal of system.dtb

2018-12-07 Thread Masahiro Yamada
quivalent cmd_shipped from scripts/Makefile.lib. Signed-off-by: Masahiro Yamada --- Changes in v2: None arch/microblaze/boot/dts/Makefile | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/microblaze/boot/dts/Makefile b/arch/microblaze/boot/dts/Makefile index c7324e7.

[PATCH 5/6] microblaze: fix race condition in building boot images

2018-12-07 Thread Masahiro Yamada
two threads descend into arch/microblaze/boot simultaneously. Add proper dependencies to avoid it. Signed-off-by: Masahiro Yamada --- Changes in v2: None arch/microblaze/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/microblaze/Makefile b/arch/micro

[PATCH 2/6] microblaze: move "... is ready" messages to arch/microblaze/Makefile

2018-12-07 Thread Masahiro Yamada
To prepare for more fixes, move this to arch/microblaze/Makefile. Otherwise, the same "... is ready" would be printed multiple times. Signed-off-by: Masahiro Yamada --- Changes in v2: None arch/microblaze/Makefile | 2 ++ arch/microblaze/boot/Makefile | 4 2 files

[PATCH 0/6] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
apply to MicroBlaze tree. Resolved the conflict with: commit 1e17ab5320a654eaf1e4ce121c61e7aa9732805a Author: Firoz Khan Date: Tue Nov 13 11:34:34 2018 +0530 microblaze: generate uapi header and system call table files Masahiro Yamada (6): microblaze: adjust the help to the real

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 11:55 PM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > This patch set fixes various issues in microblaze Makefiles. > > > > BTW, "simpleImage." works like a phony target to generate the > > following fou

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 10:10 PM Michal Simek wrote: > > Hi, > > On 06. 12. 18 6:08, Masahiro Yamada wrote: > > Hi Michal, > > > > On Thu, Dec 6, 2018 at 1:41 AM Michal Simek wrote: > >> > >> On 03. 12. 18 8:50, Masahiro Yamada wrote: > &g

Re: [PATCH 2/7] microblaze: adjust the help to the real behavior

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 9:54 PM Michal Simek wrote: > > On 06. 12. 18 6:27, Masahiro Yamada wrote: > > Hi Michal, > > > > On Thu, Dec 6, 2018 at 12:41 AM Michal Simek wrote: > >> > >> On 03. 12. 18 8:50, Masahiro Yamada wrote: > >>> &qu

Re: [PATCH 2/7] microblaze: adjust the help to the real behavior

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 9:54 PM Michal Simek wrote: > > On 06. 12. 18 6:27, Masahiro Yamada wrote: > > Hi Michal, > > > > On Thu, Dec 6, 2018 at 12:41 AM Michal Simek wrote: > >> > >> On 03. 12. 18 8:50, Masahiro Yamada wrote: > >>> &qu

Re: [PATCH 2/7] microblaze: adjust the help to the real behavior

2018-12-05 Thread Masahiro Yamada
Hi Michal, On Thu, Dec 6, 2018 at 12:41 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > "make ARCH=microblaze help" mentions simpleImage..unstrip, > > but it never works because Makefile assumes "system.unstrip" is > > th

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-05 Thread Masahiro Yamada
Hi Michal, On Thu, Dec 6, 2018 at 1:41 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > This patch set fixes various issues in microblaze Makefiles. > > > > BTW, "simpleImage." works like a phony target to generate the > > foll

[PATCH 0/4] UniPhier I2C fixes

2018-12-05 Thread Masahiro Yamada
Masahiro Yamada (4): i2c: uniphier-f: fix timeout error after reading 8 bytes i2c: uniphier-f: fill TX-FIFO only in IRQ handler for repeated START i2c: uniphier: fix violation of tLOW requirement for Fast-mode i2c: uniphier-f: fix violation of tLOW requirement for Fast-mode drivers/i2c

[PATCH 1/4] i2c: uniphier-f: fix timeout error after reading 8 bytes

2018-12-05 Thread Masahiro Yamada
al. Fixes: eaba68785c2d ("i2c: uniphier-f: fix race condition when IRQ is cleared") Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/bus

[PATCH 3/4] i2c: uniphier: fix violation of tLOW requirement for Fast-mode

2018-12-05 Thread Masahiro Yamada
us Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index 454f914..c488e55 100644 --- a/drivers/i2c/busses/i2c-uniphier.c ++

[PATCH 4/4] i2c: uniphier-f: fix violation of tLOW requirement for Fast-mode

2018-12-05 Thread Masahiro Yamada
us Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index d8a5db14..03da4a5 100644 --- a/drivers/i2c/busses/

[PATCH 2/4] i2c: uniphier-f: fill TX-FIFO only in IRQ handler for repeated START

2018-12-05 Thread Masahiro Yamada
, the data after a repeated START may not be transferred if the interrupt is asserted while the TX-FIFO is being filled up. A more reliable way is to append TX data only in the interrupt handler. Signed-off-by: Masahiro Yamada --- drivers/i2c/busses/i2c-uniphier-f.c | 13 + 1 file

[PATCH] gpio: uniphier: convert to SPDX License Identifier

2018-12-05 Thread Masahiro Yamada
checkpatch.pl suggests to use SPDX license tag. I am happy to follow it. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-uniphier.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c index

[PATCH] pinctrl: uniphier: convert to SPDX License Identifier

2018-12-05 Thread Masahiro Yamada
checkpatch.pl suggests to use SPDX license tag. I am happy to follow it. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/uniphier/pinctrl-uniphier-core.c | 18 -- drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c | 18 -- drivers/pinctrl/uniphier/pinctrl

[PATCH 1/3] kbuild: refactor Makefile.asm-generic

2018-12-05 Thread Masahiro Yamada
- Use conventional $(MAKE) $(asm-generic)= style for directory descending - Remove unneeded FORCE since "all" is a phony target - Remove unneeded "_dummy :=" assignment - Skip $(shell mkdir ...) when headers exist in the directory - Misc cleanups Signed-off

[tip:x86/urgent] x86/build: Fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread tip-bot for Masahiro Yamada
Commit-ID: 25896d073d8a0403b07e6dec56f58e6c33678207 Gitweb: https://git.kernel.org/tip/25896d073d8a0403b07e6dec56f58e6c33678207 Author: Masahiro Yamada AuthorDate: Wed, 5 Dec 2018 15:27:19 +0900 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 08:44:02 +0100 x86/build: Fix compiler

[tip:x86/urgent] x86/build: Fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread tip-bot for Masahiro Yamada
Commit-ID: 10b87bc9f630a38a7f0c1e7cf13ff23fea1692ec Gitweb: https://git.kernel.org/tip/10b87bc9f630a38a7f0c1e7cf13ff23fea1692ec Author: Masahiro Yamada AuthorDate: Wed, 5 Dec 2018 15:27:19 +0900 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 08:42:09 +0100 x86/build: Fix compiler

[PATCH] kbuild: exploit parallel building for CONFIG_HEADERS_CHECK

2018-12-04 Thread Masahiro Yamada
When CONFIG_HEADERS_CHECK is enabled, the headers_check is executed as a serialized task in the vmlinux recipe. Make it independent of vmlinux so that parallel building can process the headers_check and other build targets simultaneously. Signed-off-by: Masahiro Yamada --- Makefile | 7

[PATCH] kbuild: remove a special handling for *.agh in Makefile.headersinst

2018-12-04 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- scripts/Makefile.headersinst | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index 0d4a96d..3d1ebaa 100644 --- a/scripts/Makefile.headersinst +++ b/scripts/Makefile.headersinst @@ -44,7 +44,6 @@ k

[PATCH v2] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
ort") Reported-by: Meelis Roos Signed-off-by: Masahiro Yamada --- Changes in v2: - Revive ifdef CONFIG_RETPOLINE surrounding the KBUILD_CFLAGS addition - Rephase the commit log a bit, hoping the cause of the issue will be clearer arch/x86/Makefile | 10 +++--- 1 file changed, 7 inser

Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 3:08 PM Zhenzhong Duan wrote: > > > On 2018/12/5 11:00, Masahiro Yamada wrote: > > It is wrong to add CONFIG option diagnostic to the Makefile parse > > stage. > > > > Once you are hit by the error about non-retpoline compiler, the > &

Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
ONFIG_MATH_EMULATION) += arch/x86/math-emu/ > drivers-$(CONFIG_PCI) += arch/x86/pci/ > drivers-$(CONFIG_OPROFILE) += arch/x86/oprofile/ > drivers-$(CONFIG_PM) += arch/x86/power/ > drivers-$(CONFIG_FB) += arch/x86/video/ > ifeq ($(CONFIG_X86_DECODER_SELFTEST),y) > >

Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 3:14 AM Stephen Boyd wrote: > > Quoting Masahiro Yamada (2018-12-04 03:03:53) > > Hi Stephen, > > > > > > On Fri, Nov 30, 2018 at 5:31 PM Stephen Boyd wrote: > > > > > > Quoting Sugaya Taichi (2018-11-18 17:01:12) > >

[PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
9ac1 ("x86: Allow generating user-space headers without a compiler") did. Link: https://lkml.org/lkml/2018/12/4/206 Reported-by: Meelis Roos Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support") Signed-off-by: Masahiro Yamada --- arch/x86/Makefi

Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off

2018-12-04 Thread Masahiro Yamada
_RETPOLINE is > > enabled, but it still breaks. > > > > $ grep -r CONFIG_RETPOLINE .config > > # CONFIG_RETPOLINE is not set > > > > $ grep -r CONFIG_RETPOLINE include/ > > include/generated/autoconf.h:#define CONFIG_RETPOLINE 1 > > include/config/auto.conf:CONFIG_RETPOLINE=y > > > > So the headers have not been updated yet, maybe? > > -- Best Regards Masahiro Yamada

Re: [PATCH 11/14] pinctrl: milbeaut: Add Milbeaut M10V pinctrl

2018-12-04 Thread Masahiro Yamada
.name = "m10v-pinctrl", > + .of_match_table = m10v_pmatch, > + }, > +}; > + > +static int __init m10v_pinctrl_init(void) > +{ > + return platform_driver_register(_pinctrl_driver); > +} > +arch_initcall(m10v_pinctrl_init); Can't it be builtin_platform_driver()? Which device requires this to be arch_initcall()? -- Best Regards Masahiro Yamada

Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

2018-12-04 Thread Masahiro Yamada
the LSI business from Panasonic and Fujitsu. UniPhier originates in Panasonic, while Milbeaut in Fujitsu. Thanks. -- Best Regards Masahiro Yamada

[PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile

2018-12-02 Thread Masahiro Yamada
t/simpleImage..unstrip: identical to vmlinux - arch/microblaze/boot/simpleImage..ub: identical to arch/microblaze/boot/linux.bin.ub - arch/microblaze/boot/simpleImage..strip: stripped vmlinux The first three are just aliases of other images. Separate the recipe for eac

[PATCH 1/7] microblaze: fix cleaning of boot images

2018-12-02 Thread Masahiro Yamada
image. Fix the clean-files to take care of all the four. Adding linux.bin.ub to clean-files is redundant because it is already added into "targets". Signed-off-by: Masahiro Yamada --- arch/microblaze/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 6/7] microblaze: fix race condition in building boot images

2018-12-02 Thread Masahiro Yamada
two threads descend into arch/microblaze/boot simultaneously. Add proper dependencies to avoid it. Signed-off-by: Masahiro Yamada --- arch/microblaze/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index 7a5

[PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails

2018-12-02 Thread Masahiro Yamada
_ERROR special target"). Reuse equivalent cmd_shipped from scripts/Makefile.lib. Signed-off-by: Masahiro Yamada --- arch/microblaze/boot/dts/Makefile | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/microblaze/boot/dts/Makefile b/arch/microblaze/boot/dts/Ma

[PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile

2018-12-02 Thread Masahiro Yamada
To prepare for more fixes, move this to arch/microblaze/Makefile. Otherwise, the same "... is ready" would be printed multiple times. (Another solution would be, to remove these messages entirely unless people persist with them.) Signed-off-by: Masahiro Yamada --- arch/microblaz

[PATCH 5/7] microblaze: add linux.bin* and simpleImage.* to PHONY

2018-12-02 Thread Masahiro Yamada
-by: Masahiro Yamada --- arch/microblaze/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index c5d5b0e..7a5df02 100644 --- a/arch/microblaze/Makefile +++ b/arch/microblaze/Makefile @@ -79,11 +79,13 @@ all: linux.bin

[PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-02 Thread Masahiro Yamada
ed my best to keep the same behavior. IMHO, I guess DTB= would be more sensible, but it is up to Michal. Masahiro Yamada (7): microblaze: fix cleaning of boot images microblaze: adjust the help to the real behavior microblaze: move "... is ready" message to arch/microblaze/Makefi

[PATCH 2/7] microblaze: adjust the help to the real behavior

2018-12-02 Thread Masahiro Yamada
t generates multiple images. Reflect the behavior to the help message. Signed-off-by: Masahiro Yamada --- arch/microblaze/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index 0823d29..97e1384 100644 --- a/arch

Re: [PATCH v2 1/2] kbuild: make 'archprepare' depend on 'scripts'

2018-12-01 Thread Masahiro Yamada
On Thu, Nov 29, 2018 at 12:57 PM Masahiro Yamada wrote: > > Before start descending, Kbuild needs to run 'prepare' and 'scripts', > which has been orthogonal to each other. > > Going forward, let's consider 'scripts' is a part of the preparation. > This will allow more cleanups.

Re: [PATCH v2 2/2] kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

2018-12-01 Thread Masahiro Yamada
On Thu, Nov 29, 2018 at 12:57 PM Masahiro Yamada wrote: > > Now that 'archprepare' depends on 'scripts', Kbuild can descend into > scripts/gcc-plugins in a more standard way. > > Signed-off-by: Masahiro Yamada > Reviewed-by: Kees Cook > --- Applied to linux-kbui

Re: [PATCH] pcmcia: remove per-arch PCMCIA config entry

2018-12-01 Thread Masahiro Yamada
On Mon, Nov 26, 2018 at 6:24 PM Dominik Brodowski wrote: > > On Mon, Nov 26, 2018 at 05:15:41PM +0900, Masahiro Yamada wrote: > > Now that all architectures include drivers/pcmcia/Kconfig where > > the PCMCIA config is defined, the PCMCIA config entries in per-arch > > Kco

Re: [PATCH 1/3] modpost: refactor seen flag clearing in add_depends()

2018-12-01 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 5:08 PM Masahiro Yamada wrote: > > You do not need to iterate over all modules for resetting ->seen flag > because add_depends() is only interested in modules that export symbols > referenced from the given 'mod'. > > This also avoids shadowing th

Re: [PATCH] kbuild: fix UML build error with CONFIG_GCC_PLUGINS

2018-12-01 Thread Masahiro Yamada
On Thu, Nov 29, 2018 at 12:01 PM Masahiro Yamada wrote: > > UML fails to build with CONFIG_GCC_PLUGINS=y. > > $ make -s ARCH=um mrproper > $ make -s ARCH=um allmodconfig > $ make ARCH=um > UPD include/generated/uapi/linux/version.h > WRAParch/x86/in

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-30 Thread Masahiro Yamada
Hi Andrew, On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kb

[PATCH 2/5] kconfig: rename conf_split_config() to conf_touch_deps()

2018-11-30 Thread Masahiro Yamada
timestamp files under include/config/ in order to interact with the fixdep tool. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 1e35529..4c76

[PATCH 4/5] kconfig: remove S_OTHER symbol type and correct dependency tracking

2018-11-30 Thread Masahiro Yamada
e previous syncconfig, but is missing now, what we want to do is quite simple; just call conf_touch_dep() to touch include/config/foo.h instead of allocating a new symbol data. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 33 ++--- scripts/kconfig/expr.

[PATCH 3/5] kconfig: split out code touching a file to conf_touch_dep()

2018-11-30 Thread Masahiro Yamada
/*.h file. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 92 -- 1 file changed, 49 insertions(+), 43 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 4c76d56..7263b83 100644 --- a/scripts/kconfig

[PATCH 5/5] kconfig: remove k_invalid from expr_parse_string() return type

2018-11-30 Thread Masahiro Yamada
The only possibility of k_invalid being returned was when expr_parse_sting() parsed S_OTHER type symbol. This actually never happened, and this is even clearer since S_OTHER has gone. Clean up unreachable code. Signed-off-by: Masahiro Yamada --- scripts/kconfig/expr.c | 14 ++ 1

[PATCH 1/5] kconfig: remove unneeded setsym label in conf_read_simple()

2018-11-30 Thread Masahiro Yamada
The two 'goto setsym' statements are reachable only when sym == NULL. The code below the 'setsym:' label does nothing when sym == NULL since there is just one if-block guarded by 'if (sym && ...)'. Hence, 'goto setsym' can be replaced with 'continue'. Signed-off-by: Masahir

[PATCH v2 1/2] kbuild: make 'archprepare' depend on 'scripts'

2018-11-28 Thread Masahiro Yamada
target *.c files. Signed-off-by: Masahiro Yamada --- Changes in v2: - It turned out UML + CONFIG_GCC_PLUGINS is broken for a long time. https://patchwork.kernel.org/patch/10703853/ Rebased on the top of the fix-up Makefile | 32 +++- 1 file changed, 15

[PATCH v2 2/2] kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

2018-11-28 Thread Masahiro Yamada
Now that 'archprepare' depends on 'scripts', Kbuild can descend into scripts/gcc-plugins in a more standard way. Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook --- Changes in v2: - It turned out UML + CONFIG_GCC_PLUGINS is broken for a long time. https://patchwork.kernel.org/patch

[PATCH] kbuild: fix UML build error with CONFIG_GCC_PLUGINS

2018-11-28 Thread Masahiro Yamada
t;GCC plugin infrastructure") Signed-off-by: Masahiro Yamada --- I will pick up this to kbuild tree to avoid conflicts. Ack from UML people is appreciated, though. Makefile | 4 ++-- arch/um/Makefile | 24 ++-- arch/x86/um/Makefile | 4 +++- 3 files

[PATCH v2 1/2] mtd: rawnand: denali: remove ->dev_ready() hook

2018-11-27 Thread Masahiro Yamada
mis-implemented dev_ready hook, and fallback to sending the NAND_CMD_STATUS and nand_wait_status_ready(), which bails out more quickly. Signed-off-by: Masahiro Yamada --- Changes in v2: - Rebase drivers/mtd/nand/raw/denali.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletion

[PATCH v2 0/2] mtd: rawnand: denali: clean-up unnecessary hook and device reset

2018-11-27 Thread Masahiro Yamada
I sent this series on September, and Miquel replied this series was applied: http://patchwork.ozlabs.org/patch/967242/ But, It turned out not applied. I rebased it and resending now. Masahiro Yamada (2): mtd: rawnand: denali: remove ->dev_ready() hook mtd: rawnand: denali: rem

[PATCH v2 2/2] mtd: rawnand: denali: remove denali_reset_banks()

2018-11-27 Thread Masahiro Yamada
ly remove the redundant denali_nand_banks() by simply passing the maximum number of chip selects supported by this IP (typically 4 or 8) to nand_scan(). Let's leave all the chip detection process to nand_scan_ident(). Signed-off-by: Masahiro Yamada --- Changes in v2: None drivers/mtd

[PATCH] ARM: multi_v7_defconfig: enable CONFIG_UNIPHIER_MDMAC

2018-11-27 Thread Masahiro Yamada
Enable the UniPhier MIO DMAC driver. This is used as the DMA engine for accelerating the SD/eMMC controller drivers. Signed-off-by: Masahiro Yamada --- The insertion context was decided by savedefconfig on next-20181127. arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion

[PATCH] ARM: dts: uniphier: add MIO DMAC nodes

2018-11-27 Thread Masahiro Yamada
Add MIO-DMAC (Media IO DMA Controller) nodes, and use them as the DMA engine of SD/eMMC controllers. Signed-off-by: Masahiro Yamada --- arch/arm/boot/dts/uniphier-ld4.dtsi | 14 ++ arch/arm/boot/dts/uniphier-pro4.dtsi | 16 arch/arm/boot/dts/uniphier-sld8.dtsi

Re: [PATCH v4 0/2] dmaengine: add UniPhier MIO DMAC driver

2018-11-27 Thread Masahiro Yamada
On Wed, Nov 28, 2018 at 12:01 AM Vinod Koul wrote: > > On 25-11-18, 22:53, Masahiro Yamada wrote: > > On Sat, Nov 24, 2018 at 11:16 PM Vinod Koul wrote: > > > > > > On 12-10-18, 01:41, Masahiro Yamada wrote: > > > > 1/2: DT-binding > > > &g

Re: [PATCH v3 1/2] dt-bindings: uniphier: add bindings for UniPhier SoC family

2018-11-26 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 7:32 PM Masahiro Yamada wrote: > > Document the list of SoCs and boards of UniPhier platform. > > Signed-off-by: Masahiro Yamada > Reviewed-by: Rob Herring > --- Applied to linux-uniphier. > Changes in v3: > - Capitalize 'Board' consistently

Re: [PATCH v3 2/2] dt-bindings: uniphier: move cache-uniphier.txt to vendor directory

2018-11-26 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 7:33 PM Masahiro Yamada wrote: > > Now, the Socionext vendor directory is available at > Documentation/devicetree/bindings/arm/socionext/ > > Move cache-uniphier.txt over to it. > > Signed-off-by: Masahiro Yamada > Reviewed-by: Rob Herring

Re: [PATCH 6/6] ARM: dts: uniphier: Add all CPUs in cooling maps

2018-11-26 Thread Masahiro Yamada
MAL_NO_LIMIT THERMAL_NO_LIMIT>, > +< > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > +< > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > }; > }; > }; > -- > 2.19.1.568.g152ad8e3369a > -- Best Regards Masahiro Yamada

Re: [PATCH 10/10] ARM64: dts: uniphier: Add all CPUs in cooling maps

2018-11-26 Thread Masahiro Yamada
< > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > +< > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > +< > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > }; > }; > }; > -- > 2.19.1.568.g152ad8e3369a > -- Best Regards Masahiro Yamada

Re: [PATCH 2/2] kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

2018-11-26 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 4:57 PM Masahiro Yamada wrote: > > Now that 'prepare0' depends on 'scripts', building GCC plugins can > go into scripts/Makefile, which is a more standard way. > > Signed-off-by: Masahiro Yamada > --- Applied to linux-kbuild. > Makefile

Re: [PATCH 1/2] kbuild: make 'scripts' depend on 'prepare0'

2018-11-26 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 4:57 PM Masahiro Yamada wrote: > > Before start descending, Kbuild needs to run 'prepare' and 'scripts', > which were orthogonal to each other prior to this commit. > > Let's consider 'scripts' is a part of the preparation. This will allow > more

Re: [PATCH 2/2] modpost: file2alias: check prototype of handler

2018-11-26 Thread Masahiro Yamada
On Fri, Nov 23, 2018 at 1:51 AM Masahiro Yamada wrote: > > Use specific prototype instead of an opaque pointer so that the > compiler can catch incompatible pointer type. > > Signed-off-by: Masahiro Yamada > --- Applied to linux-kbuild. > scripts/mod/file2alias.c

Re: [PATCH 1/2] modpost: file2alias: go back to simple devtable lookup

2018-11-26 Thread Masahiro Yamada
On Fri, Nov 23, 2018 at 1:52 AM Masahiro Yamada wrote: > > Commit e49ce14150c6 ("modpost: use linker section to generate table.") > was not so cool as we had expected because it ended up with ugly section > hacks when commit dd2a3acaecd7 ("mod/file2alias: make modpos

Re: [PATCH 1/2] kbuild: fix single target build for external module

2018-11-26 Thread Masahiro Yamada
On Thu, Nov 22, 2018 at 6:33 PM Masahiro Yamada wrote: > > Building a single target in an external module fails due to missing > .tmp_versions directory. > > For example, > > $ make -C /lib/modules/$(uname -r)/build M=$PWD foo.o > > will fail in the following way: &

Re: [PATCH 1/2] kconfig: fix reverse dependency with tristate if-conditional

2018-11-26 Thread Masahiro Yamada
rop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Masahiro-Yamada/kconfig-fix-reverse-dependency-with-tristate-if-conditional/20181126-152716 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git >

[PATCH] pcmcia: remove per-arch PCMCIA config entry

2018-11-26 Thread Masahiro Yamada
Now that all architectures include drivers/pcmcia/Kconfig where the PCMCIA config is defined, the PCMCIA config entries in per-arch Kconfig files are redundant. Signed-off-by: Masahiro Yamada --- I will queue this up to my kbuild tree along with Christoph's clean-up patch set. arch/s390

[PATCH] nios2: remove unneeded HAS_DMA define

2018-11-25 Thread Masahiro Yamada
kernel/dma/Kconfig globally defines HAS_DMA as follows: config HAS_DMA bool depends on !NO_DMA default y Signed-off-by: Masahiro Yamada --- arch/nios2/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index

[PATCH 1/2] kconfig: fix reverse dependency with tristate if-conditional

2018-11-25 Thread Masahiro Yamada
ot;pcmcia: fix yenta dependency on PCCARD_NONSTATIC") but I suspect this is a bug of Kconfig itself. [1] https://www.spinics.net/lists/netfilter-devel/msg56985.html Reported-by: Taehee Yoo Reported-by: Randy Dunlap Signed-off-by: Masahiro Yamada --- scripts/kconfig/menu.c | 6 -- 1 f

[PATCH 2/2] kconfig: tests: test reverse dependency with tristate if-conditional

2018-11-25 Thread Masahiro Yamada
Add a test-case for the fixed reverse dependency handling. Signed-off-by: Masahiro Yamada --- .../kconfig/tests/revdep_with_tristate_if/Kconfig | 21 + .../tests/revdep_with_tristate_if/__init__.py | 14 ++ .../tests/revdep_with_tristate_if

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild

Re: [PATCH v4 0/2] dmaengine: add UniPhier MIO DMAC driver

2018-11-25 Thread Masahiro Yamada
On Sat, Nov 24, 2018 at 11:16 PM Vinod Koul wrote: > > On 12-10-18, 01:41, Masahiro Yamada wrote: > > 1/2: DT-binding > > 2/2: driver > > Applied this series, thanks Thanks. > While building I noticed that we get few warns when compiling with > C=1, I would pr

[PATCH 2/3] modpost: merge module iterations

2018-11-22 Thread Masahiro Yamada
Probably, this is just a matter of the order of error/warning messages. Merge the two for-loops. Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 39432c2

[PATCH 1/3] modpost: refactor seen flag clearing in add_depends()

2018-11-22 Thread Masahiro Yamada
You do not need to iterate over all modules for resetting ->seen flag because add_depends() is only interested in modules that export symbols referenced from the given 'mod'. This also avoids shadowing the 'modules' parameter of add_depends(). Signed-off-by: Masahiro Yamada --- scripts/

[PATCH 3/3] modpost: move unresolved symbol checks to check_exports()

2018-11-22 Thread Masahiro Yamada
This will fit better in check_exports() than add_versions(). Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 05e41eb..32e5026

Re: [PATCH] kbuild: move modpost out of 'scripts' target

2018-11-22 Thread Masahiro Yamada
On Wed, Nov 21, 2018 at 2:16 AM Masahiro Yamada wrote: > > I am eagar to build under the scripts/ directory only with $(HOSTCC), > but scripts/mod/ highly depends on the $(CC) and target arch headers. > That it why the 'scripts' target must depend on 'asm-generic', &g

[PATCH 2/2] kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

2018-11-22 Thread Masahiro Yamada
Now that 'prepare0' depends on 'scripts', building GCC plugins can go into scripts/Makefile, which is a more standard way. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- scripts/Makefile | 3 ++- scripts/Makefile.gcc-plugins | 8 3 files changed, 3

[PATCH 1/2] kbuild: make 'scripts' depend on 'prepare0'

2018-11-22 Thread Masahiro Yamada
*.c files. Signed-off-by: Masahiro Yamada --- Makefile | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/Makefile b/Makefile index 36f3f0e..cee4cec 100644 --- a/Makefile +++ b/Makefile @@ -1062,7 +1062,7 @@ $(sort $(vmlinux-deps)): $(vmlinux

Re: [PATCH] modpost: skip ELF local symbols during section mismatch check

2018-11-22 Thread Masahiro Yamada
of similar code already > present in modpost.c: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/mod/modpost.c?h=v4.19-rc4=7876320f88802b22d4e2daf7eb027dd14175a0f8#n1256 > > This third version of the patch implements a suggestion from Masahiro > Y

[PATCH 1/2] modpost: file2alias: go back to simple devtable lookup

2018-11-21 Thread Masahiro Yamada
ledge about the link stage of host programs, I really want to see simple, stupid table lookup so that this works in the same way regardless of the underlying executable binary format. Signed-off-by: Masahiro Yamada --- scripts/mod/file2alias.c | 144 ---

[PATCH 2/2] modpost: file2alias: check prototype of handler

2018-11-21 Thread Masahiro Yamada
Use specific prototype instead of an opaque pointer so that the compiler can catch incompatible pointer type. Signed-off-by: Masahiro Yamada --- scripts/mod/file2alias.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/mod/file2alias.c b/scripts/mod

[PATCH v4 3/3] build_bug.h: remove most of dummy BUILD_BUG_ON stubs for Sparse

2018-11-21 Thread Masahiro Yamada
e, which GCC is fine with: static const int x = 0; int y = BUILD_BUG_ON_ZERO(x); Signed-off-by: Masahiro Yamada Acked-by: Kees Cook Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers --- Changes in v4: None Changes in v3: - Add Kees' Ack

[PATCH v4 2/3] build_bug.h: remove negative-array fallback for BUILD_BUG_ON()

2018-11-21 Thread Masahiro Yamada
e VLA warning") enabled -Wvla warning. The use of variable length arrays is banned. Signed-off-by: Masahiro Yamada Acked-by: Kees Cook Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers --- Changes in v4: None Changes in v3: None Changes in v2: None include/linux/build_

[PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-21 Thread Masahiro Yamada
3e9c ("fix expansion of function designator"), but it will take time until the fixed version of Sparse is widely available. Disable the container_of() type checks for Sparse for now. [1] https://lore.kernel.org/lkml/1542623503-3755-1-git-send-email-yamada.masah...@socionext.com/ Signed-off

[PATCH 1/2] kbuild: fix single target build for external module

2018-11-21 Thread Masahiro Yamada
/foo.mod: Directory nonexistent This is because $(cmd_crmodverdir) is executed only for /, %/, %.ko single targets for external modules. Create .tmp_versions in the 'prepare' target. Signed-off-by: Masahiro Yamada --- Makefile | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff

[PATCH 2/2] kbuild: remove 'scripts' dummy target for external module build

2018-11-21 Thread Masahiro Yamada
Make simply skips a missing rule as long as it is marked as PHONY. Remove the dummy target. Signed-off-by: Masahiro Yamada --- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index 36f3f0e..269a9bf 100644 --- a/Makefile +++ b/Makefile @@ -1604,11 +1604,9

Re: [PATCH v2 0/9] kbuild: clean-up modversion, TRIM_UNUSED_KSYMS, if_changed_rule, etc.

2018-11-21 Thread Masahiro Yamada
On Tue, Nov 20, 2018 at 10:11 AM Masahiro Yamada wrote: > > As a Kbuild maintainer, I always struggle to keep the core makefiles > clean because people tend to squeeze more and more clutter code into > the kbuild core in order to do what they want to do. > > The bi

Re: Backed up kernels

2018-11-20 Thread Masahiro Yamada
on makes sense, but "make install" is basically implemented by arch-specific shell script. (For example, arch/x86/boot/install.sh) Will you talk to the maintainers of architecture you are interested in? (or send it to linux-a...@vger.kernel.org) > Thanks, > -- > Jean Delvare > SUSE L3 Support -- Best Regards Masahiro Yamada

Re: [PATCH] modpost: validate symbol names also in find_elf_symbol

2018-11-20 Thread Masahiro Yamada
tic inline int is_valid_name(struct elf_info *elf, Elf_Sym *sym) > -{ > - const char *name = elf->strtab + sym->st_name; > - > - if (!name || !strlen(name)) > - return 0; > - return !is_arm_mapping_symbol(name); > -} > - > /* > * Find symbols before or equal addr and after addr - in the section sec. > * If we find two symbols with equal offset prefer one with a valid name. > -- > 2.19.1.568.g152ad8e336-goog > -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] modpost: drop unused command line switches

2018-11-20 Thread Masahiro Yamada
out of modpost") > > Could you add a patch that delete these on top of what you already have. > > https://lore.kernel.org/lkml/20181020140835.ga3...@ravnborg.org/ > > Cc: Sam Ravnborg > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-kbu...@vger.kernel

Re: [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check

2018-11-20 Thread Masahiro Yamada
/tree/scripts/mod/modpost.c?h=v4.19-rc4=7876320f88802b22d4e2daf7eb027dd14175a0f8#n1256 > > This second version of the patch drops the option to keep section > mismatch warnings for local sections, based on feedback from Sam > Ravnborg ; and clarifies that these warnings > appear wit

Re: [PATCH v2 1/2] Makefile: Fix distcc compilation with x86 macros

2018-11-20 Thread Masahiro Yamada
On Tue, Nov 20, 2018 at 2:21 AM Nadav Amit wrote: > > at 8:20 PM, Masahiro Yamada wrote: > > > On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote: > >> From: Masahiro Yamada > >> Sent: November 16, 2018 at 7:45:45 AM GMT > >>> To: Nadav Amit > &g

  1   2   3   4   5   6   7   8   9   10   >