RE: [PATCH] Input: ALPS - add support for 73 03 28 devices (Thinkpad L570)

2018-03-27 Thread Masaki Ota
Hi, Dennis I know your issue, and I added the solution for Thinkpad L/E system last year. BTW, Pali also knows about it. On Wednesday 29 November 2017 17:33:58 Masaki Ota wrote: From: Masaki Ota <masaki@jp.alps.com - The issue is that Thinkpad L570 TrackStick does not work. Beca

RE: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices

2018-03-26 Thread Masaki Ota
by both of EA F0 F0 E9 and F0 F0 E9.) Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Monday, March 26, 2018 6:26 AM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: Dmitry Torokhov <dmitry.torok...@gmail.com>; linux-in...@vge

RE: [PATCH] Input: alps - Demystify trackstick initialization for v3 and v6 protocols

2018-03-19 Thread Masaki Ota
Hi, Pali, v3/v6 devices are T3 type, and it can use only Method 2. P36 (At this time GLIDEPOINT_T3 uses the Method 2 ) T3 has the potential that uses Method2, but I think it needs to change Firmware. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro

RE: [PATCH] input: multi-touch fix for ALPS touchpads ("SS4 plus" variant)

2018-01-11 Thread Masaki Ota
Hi, Nir, Wow, thank you for fixing the bug. Your code is correct! Best Regards, Masaki Ota -Original Message- From: Nir Perry [mailto:nirpe...@gmail.com] Sent: Saturday, January 06, 2018 8:55 PM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com>; Dmitry Torokhov <dmitry.torok...@

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-05 Thread Masaki Ota
Hi, Pali, OK, I got it. So, the problem of structure will be solved next chance. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Monday, December 04, 2017 6:51 PM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: Masaki Ota

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-04 Thread Masaki Ota
Hi, Pali, It does not work in my test result. BTW, other some functions also use both of "struct psmouse" and "struct alps_data" argument. I just followed it. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Monday,

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-12-03 Thread Masaki Ota
Hi, Pali, I don't get your point. Please modify the code if you have an idea. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Saturday, December 02, 2017 6:08 AM To: Masaki Ota <012ne...@gmail.com> Cc: dmitry.torok...@gma

[PATCH] Support TrackStick of Thinkpad L570

2017-11-29 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled. - Add th

[PATCH] Support TrackStick of Thinkpad L570

2017-11-28 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled. - Add th

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-11-28 Thread Masaki Ota
Hi, Domitry, I think we can add the code to HID for this device, but we will not use SMBus interface for Touchpad in the future. We should not do it. Best Regards, Masaki Ota -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Sunday, November 26, 2017 9

RE: [PATCH] Support TrackStick of Thinkpad L570

2017-11-20 Thread Masaki Ota
Hi, Pali, 1) Yes, but we don't have FW update plan. And this device works as SMBus in Windows, so this issue happens on only Linux. 2) Yes. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Monday, November 20, 2017 5:30 PM To: Masaki Ota

[PATCH] Support TrackStick of Thinkpad L570

2017-11-19 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled. - Add th

RE: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices

2017-11-15 Thread Masaki Ota
setting is wrong. Sorry for our mistake. Is your laptop L570 ? I will add code that supports the trackstick for this device. Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Wednesday, November 15, 2017 5:35 PM To: 太田 真喜 Masaki Ota <mas

[PATCH]Support new Alps HID Touchpad device

2017-10-05 Thread Masaki Ota
Hi, Jiri, Sorry, I have fixed the build warning error, and send the patch again. Best Regards, Masaki Ota

[PATCH 1/7] Delete unnecessary structure

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Delete "struct u1_dev devInfo" structure, because u1_dev structure is already declared as "struct u1_dev *data", and this structure is used for getting U1 data in [PATCH 2/7]. Signed-off-by: Masaki Ota <masaki@jp.a

[PATCH 2/7] Separate U1 device code

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Create "static int u1_init()" function for separate U1 device initialization code from Main initialization. -Create "has_sp" variable for checking whether it has SP device or not. Signed-off-by: Masaki Ota <masaki@jp.a

[PATCH 4/7] replace some variables

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Move some variables(dev_ctrl, dev_type, sen_line_num_x, sen_line_num_y, pitch_x, pitch_y, resolution, btn_info) from u1_dev structure to "u1_init()", because these variables are only used in "u1_init()" function. Signed-

[PATCH 6/7] Add new U1 device ID

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add new U1 device Product ID -This device is used on HP Elite book x360 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 3 +++ drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 3 file

[PATCH 5/7] Support Alps T4 Touchpad device

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Define T4 device specification value for support T4 device. -Create "t4_contact_data" and "t4_input_report" structure for decode T4 data and store it. -Create "t4_calc_check_sum()" function for calculate checksum

[PATCH 3/7] Add some variables

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Create x_min, y_min and max_fingers variables for set correct XY minimum value and the number of max finger on each devices. -Move the Button pad checking code to U1 init function, because this checking code is for U1 device. Signed-off-by: Masa

[PATCH 7/7] Support Alps U1 USB Touchpad device

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add T4 USB device Product ID. (0x1216) -Separate T4 USB device initialization code from T4 Standard device code. -T4 USB device is used on HP Elite x2 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid

[PATCH 1/7] Delete unnecessary structure

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Delete "struct u1_dev devInfo" structure, because u1_dev structure is already declared as "struct u1_dev *data", and this structure is used for getting U1 data in [PATCH 2/7]. Signed-off-by: Masaki Ota <masaki@jp.a

[PATCH 6/7] Add new U1 device ID

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add new U1 device Product ID -This device is used on HP Elite book x360 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 3 +++ drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 3 file

[PATCH 3/7] Add some variables

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Create x_min, y_min and max_fingers variables for set correct XY minimum value and the number of max finger on each devices. -Move the Button pad checking code to U1 init function, because this checking code is for U1 device. Signed-off-by: Masa

[PATCH]Support new Alps HID Touchpad device

2017-10-05 Thread Masaki Ota
I have modified the Patch. About __maybe_unused annotation, it was specified by Benjamin in previous review. So I added this annotation. Best Regards, Masaki OTa

[PATCH 4/7] replace some variables

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Move some variables(dev_ctrl, dev_type, sen_line_num_x, sen_line_num_y, pitch_x, pitch_y, resolution, btn_info) from u1_dev structure to "u1_init()", because these variables are only used in "u1_init()" function. Signed-

[PATCH 2/7] Separate U1 device code

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Create "static int u1_init()" function for separate U1 device initialization code from Main initialization. -Create "has_sp" variable for checking whether it has SP device or not. Signed-off-by: Masaki Ota <masaki@jp.a

[PATCH 7/7] Support Alps U1 USB Touchpad device

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add T4 USB device Product ID. (0x1216) -Separate T4 USB device initialization code from T4 Standard device code. -T4 USB device is used on HP Elite x2 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid

[PATCH 5/7] Support Alps T4 Touchpad device

2017-10-05 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Define T4 device specification value for support T4 device. -Create "t4_contact_data" and "t4_input_report" structure for decode T4 data and store it. -Create "t4_calc_check_sum()" function for calculate checksum

[PATCH 2/7] Minor changes in hid-alps.c for support new Alps device(Separate U1 device code)

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -To support Alps T4 device, separate U1 device code Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 120 +++-- 1 file changed, 67 insertions(+), 53 deletions(-)

[PATCH 1/7] Minor changes in hid-alps.c for support new Alps device(Delete unnecessary structure)

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -To support Alps T4 device, clean up the source code -Delete unnecessary structure Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 69 +- 1 file changed, 34 inser

[PATCH 7/7] Support Alps U1 USB device

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add T4 USB device code and Product ID -This device is used on HP Elite x2 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 35 +-- drivers/hid/hid-core.c | 1 + drivers/h

[PATCH 4/7] Minor changes in hid-alps.c for support new Alps device(replace some variables)

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -To support Alps T4 device, replace some variables Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 67 -- 1 file changed, 27 insertions(+), 40 deletions(-)

[PATCH 3/7] Minor changes in hid-alps.c for support new Alps device(Add some variables)

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -To support Alps T4 device, add x_min, y_min, max_fingers variables Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-)

[PATCH 6/7] Add new U1 device ID for supporting it

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add new U1 device Product ID -This device is used on HP Elite book x360 series Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 3 +++ drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 3 file

[PATCH 5/7] Support new Alps device that name is T4

2017-09-11 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add T4 device code and Product ID -This device is used on HP EliteBook 1000 series and Zbook Stduio Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 343 ++--- dri

[PATCH] Support new Alps HID Touchpad device

2017-09-11 Thread Masaki Ota
Hi, Jiri, Benjamin, This is the patch for support new Alps HID Touchpad device. I submitted these patch before, but it was not completed. So I separate the patch to some parts and release it again. Best Regards, Masaki Ota

[PATCH] Fix Alps Touchpad two finger scroll does not work on right side

2017-07-20 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> Fixed the issue that two finger scroll does not work correctly on V8 protocol. The cause is that V8 protocol X-coordinate decode is wrong at SS4 PLUS device. I added SS4 PLUS X decode definition. Signed-off-by: Masaki Ota <masaki@jp.alps.co

RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-20 Thread Masaki Ota
. Original code meaning is Kernel 4.10.6, it seems not to have this issue. Best Regards, Masaki Ota -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, July 20, 2017 6:35 PM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: Paul Donohue <linux-ker...@paulsd.co

RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-07-20 Thread Masaki Ota
amp; 0x0010) \ ) +#define SS4_PLUS_BTL_MF_X_V2(_b, _i) (SS4_PLUS_STD_MF_X_V2(_b, _i) | \ +((_b[0 + (_i) * 3] >> 4) & 0x0008) \ + ) + #define SS4_BTL_MF_Y_V2(_b, _i)(SS4_STD_MF_Y_V2(_b, _i) | \

[PATCH] Support PTP Stick and Touchpad device

2017-06-15 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - Support PTP Stick and Touchpad device. - This Touchpad is Precision Touchpad(PTP), and Stick Pointer data is the same as Mouse. - Stick Pointer works as Mouse. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-ids.h

RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-14 Thread Masaki Ota
effect, even if I set an abnormal value.(need this code?) I don't understand why these values have to do with this issue. Can you guess the root cause of this issue? Best Regards, Masaki Ota -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Thursday, June 15, 2017 3

[PATCH 1/1] Support PTP Stick and Touchpad device

2017-06-14 Thread Masaki Ota
>From Masaki Ota <masaki@jp.alps.com> Support PTP Stick and Touchpad device. This Touchpad is Precision Touchpad(PTP), and Stick Pointer data is the same as Mouse. So Stick Pointer works as Mouse. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-id

RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-11 Thread Masaki Ota
Regards, Masaki Ota -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Wednesday, June 07, 2017 1:59 AM To: Paul Donohue <linux-ker...@paulsd.com> Cc: 太田 真喜 Masaki Ota <masaki@jp.alps.com>; Dmitry Torokhov <dmitry.torok...@gmail.com>; Pali Rohar <

[PATCH 4/4] Add Alps T4 USB Touchpad device ID

2017-04-27 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Support Alps T4 USB Touchpad device -Laptop names that use this Touchpad:Elite x2 1012 G1 Tablet, HP Pro x2 612 G2 Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 37 ++--- dri

[PATCH 1/4] Replace Alps U1 Touchpad code

2017-04-27 Thread Masaki Ota
>From Masaki Ota <masaki@jp.alps.com> - Separate U1 device initialization from common initialization. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 188 ++--- 1 file changed, 99 insertions(+

[PATCH 2/4] Support Alps HID I2C T4 Touchpad device

2017-04-27 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Support Alps HID I2C T4 Touchpad device. -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, Elitebook 1030 G1, Elitebook 1040 G3. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-

[PATCH 0/4] Support new Alps HID I2C Touchpad device

2017-04-27 Thread Masaki Ota
Hi, Benjamin, I modified the patch and added the code that supports Alps USB Touchpad as PATCH 4/4. Best Regards, Masaki Ota

[PATCH 3/4] Add new Alps U1 Touchpad device

2017-04-27 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Add new Alps U1 Touchpad device ID -Laptop names that use this Touchpad:HP Elitebook x360 1030 G2 Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 3 +++ drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h |

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
data->dev_type = U1; break; default: data->dev_type = UNKNOWN; } Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org] Sent: Thursday, April 06, 2017 3:36 AM To: 太田 真喜 Masaki Ota <masaki@jp

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
./linux_kr_rebuild_tool_hid.sh /init linux-4.10.tar.gz #sudo ./linux_kr_rebuild_tool_hid.sh /build DebugSrc After that Touchpad all features should work. If Touchpad does not work, something error appears on dmesg. Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
Hi, Nikolaus, Um, but demesg log does not have any error of this Touchpad. It's a strange. Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org] Sent: Wednesday, April 05, 2017 8:43 AM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: linux-

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
of interface should work properly on Linux. I tested it on Ubuntu +4.10 kernel. If you don't apply my patch, does device work as I2C? (044E:120C appears?) Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org] Sent: Wednesday, April 05, 2017 2:09 AM To: 太田 真喜

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
. What does dmesg show? Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org] Sent: Tuesday, April 04, 2017 12:09 PM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com>; linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org

[PATCH 0/2] Support new Alps HID I2C Touchpad device

2017-03-29 Thread Masaki Ota
Hi, Jiri, This is the patch for new Alps HID I2C Touchpad device. These devices are used for HP Laptop. Best Regards, Masaki Ota

[PATCH 2/2] Add new U1 device ID

2017-03-29 Thread Masaki Ota
-Add new Alps U1 Touchpad device ID -Laptop names that use this Touchpad:HP Elitebook x360 1030 G2 Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 3 +++ drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 3 files changed, 5 insertions(+) diff

[PATCH 1/2] Alps HID I2C T4 device support

2017-03-29 Thread Masaki Ota
>From Masaki Ota <masai@jp.alps.com> -Support Alps HID I2C T4 Touchpad device. -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, Elitebook 1030 G1, Elitebook 1040 G3 Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/h

[PATCH 1/2] Fix V8 device information issue

2017-03-13 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Fix the issue that V8(E7=73 03 28) devices are not assined correct device information bit from OTP. -Specified correct OTP bit for the V8 device setting of Button pad, DualPoint and Touchpad size. -Deleted extra code from alps_v8_protocol_data de

[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work

2017-03-13 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - V8 Button pad Stick Right and Middle button don't work. - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process. Signed-off-by: Masaki Ota <masaki@jp.alps.com>

[PATCH 1/2] Fix V8 device information issue

2017-03-13 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Fix the issue that V8(E7=73 03 28) devices are not assined correct device information bit from OTP. -Specified correct OTP bit for the V8 device setting of Button pad, DualPoint and Touchpad size. -Deleted extra code from alps_v8_protocol_data de

[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work

2017-03-13 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> - V8 Button pad Stick Right and Middle button don't work. - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --

[PATCH] Fix V8 device information issue

2017-03-09 Thread Masaki Ota
From: Masaki Ota <masaki@jp.alps.com> -Fix the issue that V8(E7=73 03 28) devices are not assined correct device information from OTP. -Specified correct OTP bit for the V8 device setting of Button pad, DualPoint and Touchpad size. Signed-off-by: Masaki Ota <masaki@jp

RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-07 Thread Masaki Ota
Hi, Dmitry, OK, I will do it. Best Regards, Masaki Ota -Original Message- From: dmitry.torok...@gmail.com [mailto:dmitry.torok...@gmail.com] Sent: Wednesday, March 08, 2017 2:58 AM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: Paul Donohue <linux-ker...@paulsd.com>; N

RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-07 Thread Masaki Ota
Actually, the cause is all the same. E7=73 03 28 device does not get correct information from OTP. OTP is the device information byte. I specified correct bit. Then, I think it is also the issue. #4. Stick Pointer cursor speed is fast. I will check Stick parameter. Best Regards, Masaki Ota -

RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-06 Thread Masaki Ota
is_btnless = (otp[1][1] >> 3) & 0x01; E7=73 03 28 device has to use below bit. is_btnless = (otp[1][0] >> 1) & 0x01; I will check other parts of source code. Best Regards, Masaki Ota -Original Message- From: Paul Donohue [mailto:linux-ker...@paulsd.com] Sent: Monday,

RE: Unknown ALPS touchpad

2017-02-20 Thread Masaki Ota
f0) == 0xc0)) { protocol = _v7_protocol_data;} } E7=73 03 50, EC=73 02 02 <- alps_v5_protocol_data E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data Best Regards, Masaki Ota -Original Message- From: Pali Rohár [mailto:p

[PATCH] Fix a issue that Alps Touchpad cursor does not work

2016-09-26 Thread Masaki Ota
ak" code, and move xyz input code to the correct place. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 048befd..610df92

[PATCH] Fix a issue that Alps Touchpad cursor does not work

2016-09-22 Thread Masaki Ota
fix Touchpad cursor does not work after touching Touchpad by 3 or more fingers. Signed-off-by: Masaki Ota <masaki@jp.alps.com> --- drivers/hid/hid-alps.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c