Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 20:48:47 +0100 Borislav Petkov wrote: > On Fri, Dec 07, 2018 at 11:42:10PM +0900, Masami Hiramatsu wrote: > > Hmm, I just thought that the symbol only referred from inline asm should > > be visible. But if it is OK for any version of supported gcc and clan

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:58:05 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducin

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:00:26 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducin

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
: Masami Hiramatsu Blacklist symbols in arch-defined probe-prohibited areas. With this change, user can see all symbols which are prohibited to probe in debugfs. All archtectures which have custom prohibit areas should define its own arch_populate_kprobe_blacklist() function, but unless that, all

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-07 Thread Masami Hiramatsu
On Wed, 5 Dec 2018 15:24:48 +0100 Borislav Petkov wrote: > On Wed, Dec 05, 2018 at 10:49:06PM +0900, Masami Hiramatsu wrote: > > I would like to put this prototype inside arch/x86/kernel/kprobes/core.c, > > since that is locally used. > > Done. > > > Should we

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
; > Signed-off-by: Andrea Righi For the short term, this is OK. But this is not the best way to cover other functions which are also prohibited by arch_within_kprobe_blacklist(). I'll fix this issue later. Acked-by: Masami Hiramatsu Thank you, > --- > arch/x86/entry/entry_64.S | 4 +

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-07 Thread Masami Hiramatsu
at the symbol only referred from inline asm should be visible. But if it is OK for any version of supported gcc and clang, I'm good to remove it. :-) (IOW, I just concerned about older gcc) Reviewed-by: Masami Hiramatsu Thank you, > > --- > diff --git a/arch/x86/kernel/kprobes

Re: [PATCH v2 10/12] tracing: Remove orphaned trace_add/remove_event_call functions

2018-12-06 Thread Masami Hiramatsu
On Tue, 4 Dec 2018 13:51:20 -0500 Steven Rostedt wrote: > On Mon, 5 Nov 2018 18:04:29 +0900 > Masami Hiramatsu wrote: > > > Remove trace_add_event_call() and trace_remove_event_call() > > functions since those are not used anymore. > > > > Signed-off-by:

Re: [PATCH v2 01/12] tracing/uprobes: Add busy check when cleanup all uprobes

2018-12-06 Thread Masami Hiramatsu
On Tue, 4 Dec 2018 12:43:33 -0500 Steven Rostedt wrote: > On Mon, 5 Nov 2018 18:00:15 +0900 > Masami Hiramatsu wrote: > > > Add a busy check loop in cleanup_all_probes() before > > trying to remove all events in uprobe_events as same as > > kprobe_events does. &

Re: [PATCH v7 09/14] x86/kprobes: Instruction pages initialization enhancements

2018-12-06 Thread Masami Hiramatsu
hile at it, do some small cleanup of what appears to be unnecessary > masking. Looks good to me. Acked-by: Masami Hiramatsu Thanks! > > Cc: Masami Hiramatsu > Signed-off-by: Nadav Amit > --- > arch/x86/kernel/kprobes/core.c | 24 > 1 file cha

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-05 Thread Masami Hiramatsu
able_kprobe(struct kprobe *kp); > > void dump_kprobe(struct kprobe *kp); > > +void __weak *alloc_insn_page(void); > +void __weak free_insn_page(void *page); Should we declare prototypes for __weak functions? Anyway, we should remove __weak from the prototypes. Thank you, -- Masami Hiramatsu

[tip:perf/urgent] kprobes/x86: Fix instruction patching corruption when copying more than one RIP-relative instruction

2018-12-04 Thread tip-bot for Masami Hiramatsu
Commit-ID: 43a1b0cb4cd6dbfd3cd9c10da663368394d299d8 Gitweb: https://git.kernel.org/tip/43a1b0cb4cd6dbfd3cd9c10da663368394d299d8 Author: Masami Hiramatsu AuthorDate: Fri, 24 Aug 2018 02:16:12 +0900 Committer: Ingo Molnar CommitDate: Tue, 4 Dec 2018 09:35:20 +0100 kprobes/x86: Fix

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-12-04 Thread Masami Hiramatsu
On Tue, 4 Dec 2018 09:13:35 +0100 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Since copy_optimized_instructions() misses to update real RIP > > address while copying several instructions to working buffer, > > it adjusts RIP-relative instruc

Re: Strange hang with gcc 8 of kprobe multiple_kprobes test

2018-12-04 Thread Masami Hiramatsu
On Tue, 4 Dec 2018 16:40:07 +0900 Masami Hiramatsu wrote: > Hi Steve, > > On Mon, 3 Dec 2018 21:18:07 -0500 > Steven Rostedt wrote: > > > Hi Masami, > > > > I started testing some of my new code and the system got into a > > strange state. Debuggi

Re: Strange hang with gcc 8 of kprobe multiple_kprobes test

2018-12-03 Thread Masami Hiramatsu
you for digging it down. It is now much easier to me. > > I notice that when I get into the state, journald and the dbus_daemon > are constantly running. Perhaps the userspace time keeping went bad? Yeah, I think so. Maybe addl instruction becomes broken. Thank you, -- Masami Hiramatsu

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-30 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 22:24:35 -0500 Steven Rostedt wrote: > On Fri, 30 Nov 2018 11:26:58 +0900 > Masami Hiramatsu wrote: > > > On Thu, 29 Nov 2018 11:46:52 -0500 > > Steven Rostedt wrote: > > > > > On Thu, 29 Nov 2018 23:29:27 +0900 > > > Masami

Re: [PATCH v6 08/10] x86: avoid W^X being broken during modules loading

2018-11-29 Thread Masami Hiramatsu
as executable is > > done as a separate step to avoid one core in which the old PTE is cached > > (hence writable), and another which sees the updated PTE (executable), > > which would break the W^X protection. > > > > Cc: Andy Lutomirski > > Cc: Kees Cook

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 11:46:52 -0500 Steven Rostedt wrote: > On Thu, 29 Nov 2018 23:29:27 +0900 > Masami Hiramatsu wrote: > > > > One way to solve this is to also have a counter array that gets updated > > > every time the index array gets updated. And save the counte

Re: [PATCH v2] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 16:53:30 + Catalin Marinas wrote: > On Thu, Nov 29, 2018 at 02:39:33PM +0900, Masami Hiramatsu wrote: > > Since commit 4378a7d4be30 ("arm64: implement syscall wrappers") > > introduced "__arm64_" prefix to all syscall wrapper symbols in

Re: [PATCH] selftests/ftrace: Fix invalid SPDX identifiers

2018-11-29 Thread Masami Hiramatsu
orrect and valid identifiers for GPL > >> v2 > >> only code are 'GPL-2.0' or 'GPL-2.0-only'. > >> > >> Signed-off-by: Thomas Gleixner > >> Cc: Masami Hiramatsu > >> Cc: Shuah Khan (Samsung OSG) > >> > > Hi Masami, > > I am pulling this in for 4.21-rc1. Oops, I missed it. Acked-by: Masami Hiramatsu Thank you! -- Masami Hiramatsu

[PATCH] sefltests/ftrace: Use /bin/echo for output with options

2018-11-29 Thread Masami Hiramatsu
orted-by: Tom Zanussi Suggested-by: Tom Zanussi Signed-off-by: Masami Hiramatsu --- tools/testing/selftests/ftrace/ftracetest |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest

Re: [PATCH v7 00/16] tracing: Hist trigger snapshot and onchange additions

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 22:52:25 +0900 Masami Hiramatsu wrote: > > For that system, I'm using Gnome terminal 3.24.2 and GNU bash, version > > 4.4.12(1)-release (x86_64-pc-linux-gnu) (Ubuntu 17.10). > > > > If I change 'echo' to '/bin/echo' in e.g. prlog() it wo

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
Hi Steve, On Mon, 26 Nov 2018 11:32:15 -0500 Steven Rostedt wrote: > On Mon, 26 Nov 2018 18:21:12 +0900 > Masami Hiramatsu wrote: > > > > > Note, if another fgraph_ops is registered in the same location, its > > > retfunc may be called that wa

Re: [PATCH v7 00/16] tracing: Hist trigger snapshot and onchange additions

2018-11-29 Thread Masami Hiramatsu
On Mon, 26 Nov 2018 15:21:28 -0600 Tom Zanussi wrote: > Hi Masami, > > On Mon, 2018-11-26 at 23:09 +0900, Masami Hiramatsu wrote: > > Hi Tom, > > > > On Wed, 14 Nov 2018 14:17:57 -0600 > > Tom Zanussi wrote: > > > > > From: Tom Zanussi >

[PATCH v2] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-28 Thread Masami Hiramatsu
kernel, and some bpf testcases are failed on arm64. To fix this issue, this introduces custom arch_syscall_match_sym_name() which skips first 8 bytes when comparing the syscall and symbol names. Fixes: 4378a7d4be30 ("arm64: implement syscall wrappers") Reported-by: Naresh Kamboju Signed-o

Re: [PATCH] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-28 Thread Masami Hiramatsu
I'll add a comment about compat syscalls. BTW, this should be applied to 4.19 too, since without this, no one can use syscall events on arm64. Thank you, -- Masami Hiramatsu

Re: [PATCH v2 00/12] tracing: Unifying dynamic event interface

2018-11-28 Thread Masami Hiramatsu
Hi Tom, On Wed, 28 Nov 2018 17:42:22 -0600 Tom Zanussi wrote: > Hi Masami, > > On Wed, 2018-11-28 at 16:31 +0900, Masami Hiramatsu wrote: > > Ping? > > > > Hi Tom, > > > > This series, especially [09/12] tracing: Remove unneeded > > synth_eve

Re: [PATCH v2 00/12] tracing: Unifying dynamic event interface

2018-11-27 Thread Masami Hiramatsu
Ping? Hi Tom, This series, especially [09/12] tracing: Remove unneeded synth_event_mutex will effect your current working series. Please tell me your opinion. Thank you, On Mon, 5 Nov 2018 17:59:46 +0900 Masami Hiramatsu wrote: > Hi, > > This is v2 series of unifying dyna

Re: [PATCH v7 09/16] tracing: Add hist trigger snapshot() action test case

2018-11-27 Thread Masami Hiramatsu
event may continue to be called. Does this mean hist will be updated? (and I guess preferrable behavior is to stop hist too, isn't it?) Thank you, -- Masami Hiramatsu

Re: [PATCH] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-27 Thread Masami Hiramatsu
call table with AArch64, * tracing compat syscalls may result in reporting bogus syscalls or even * hang-up, so just do not trace them. That's why I dropped compat syscall support. Thank you, -- Masami Hiramatsu

[PATCH] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-27 Thread Masami Hiramatsu
kernel, and some bpf testcases are failed on arm64. To fix this issue, this introduces custom arch_syscall_match_sym_name() which skips first 8 bytes when comparing the syscall and symbol names. Fixes: 4378a7d4be30 ("arm64: implement syscall wrappers") Reported-by: Naresh Kamboju Signed-off

Re: File not found: /sys/kernel/debug/tracing/events/syscalls

2018-11-27 Thread Masami Hiramatsu
> strace output: > open(\"/sys/kernel/debug/tracing/events/syscalls/sys_enter_nanosleep/id\", > O_RDONLY) = -1 ENOENT (No such file or directory) > > This problem noticed on Linux mainline kernel version 4.20.0-rc3. > > Best regards > Naresh Kamboju -- Masami Hiramatsu

Re: [RFC][PATCH 11/14] function_graph: Convert ret_stack to a series of longs

2018-11-26 Thread Masami Hiramatsu
PROFILE > turned off). > > Where as before it would be 32 * 40 = 1280 bytes. That looks like ~7 times > more than before. Hmm, this seems too big... I thought the shadow-stack size should be smaller than 1 page (4kB). Steve, can we give a 4k page for shadow stack and define FTRACE_RETFUNC_DEP

Re: [PATCH v7 00/16] tracing: Hist trigger snapshot and onchange additions

2018-11-26 Thread Masami Hiramatsu
nmax-action-hist.tc |1 + > .../inter-event/trigger-snapshot-action-hist.tc| 43 + > .../trigger-synthetic-event-createremove.tc|1 + > .../inter-event/trigger-trace-action-hist.tc | 42 + > 18 files changed, 1433 insertions(+), 302 deletions(-) > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc > create mode 100644 > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc > > -- > 2.14.1 > -- Masami Hiramatsu

Re: [PATCH v7 09/16] tracing: Add hist trigger snapshot() action test case

2018-11-26 Thread Masami Hiramatsu
instead of disabling the event? Thank you, > + > +if ! grep -q "changed:" events/sched/sched_waking/hist; then > +fail "Failed to create onchange action inter-event histogram" > +fi > + > +if ! grep -q "comm=ping" snapshot; then > +fail "Failed to create snapshot action inter-event histogram" > +fi > + > +exit 0 > -- > 2.14.1 > -- Masami Hiramatsu

Re: [RFC][PATCH 07/14] fgraph: Add new fgraph_ops structure to enable function graph hooks

2018-11-26 Thread Masami Hiramatsu
CE > + struct ftrace_ops_hash local_hash; > + struct ftrace_ops_hash *func_hash; > +#endif Hmm, can we introduce these fields when we actually use it? BTW, would you have any idea for using private field? Thank you, -- Masami Hiramatsu

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-26 Thread Masami Hiramatsu
unction > and each callback. > > What's the solution? I use the shadow stack that is already being > used to store the function return addresses. > > A big thanks to Masami Hiramatsu for suggesting this idea! > > For now, I only allow an 16 users of the function graph trac

Re: uprobe support mix of ftrace and perf

2018-11-26 Thread Masami Hiramatsu
Hi Oleg, On Thu, 22 Nov 2018 15:32:10 +0100 Oleg Nesterov wrote: > Hi Masami, > > On 11/20, Masami Hiramatsu wrote: > > > > Hello Oleg, > > > > I have a question about the (revert) commit 48212542067a > > ("tracing/uprobes: Revert "Support mix o

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-25 Thread Masami Hiramatsu
ce_graph_ret_addr(struct task_struct *task, int *idx, unsigned long ret, > unsigned long *retp) > -- > 2.19.1 > > -- Masami Hiramatsu

Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-25 Thread Masami Hiramatsu
; > - > -void ftrace_graph_graph_time_control(bool enable) > -{ > - fgraph_graph_time = enable; > -} > > static int profile_graph_entry(struct ftrace_graph_ent *trace) > { -- Masami Hiramatsu

Re: [for-next][PATCH 00/18] function_graph: Add separate depth counter to prevent trace corruption

2018-11-25 Thread Masami Hiramatsu
Hi Steve, This series looks good to me. Reviewed-by: Masami Hiramatsu for this series. Thank you! # Now I know why sometimes func-graph depth looks broken... On Wed, 21 Nov 2018 19:28:01 -0500 Steven Rostedt wrote: > While working on rewriting function graph tracer, I found a des

uprobe support mix of ftrace and perf

2018-11-20 Thread Masami Hiramatsu
was a tentative one, and should be fixed afterwards. Since kprobe events already supported the mix of ftrace and perf, user may confuse why they can not use the uprobe event if it is used by ftrace. (perf probe treats both events transparently, and ftrace event interface too.) Thank you, -- Masami Hiramatsu

Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support

2018-11-15 Thread Masami Hiramatsu
On Wed, 14 Nov 2018 21:52:57 +0100 Patrick Staehlin wrote: > Hi Masami, > > thank you for your remarks. > > On 14.11.18 09:37, Masami Hiramatsu wrote> > > Thank you very much for implementing kprobes on RISC-V :) > > > > On Tue, 13 Nov 2018 20:58

Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support

2018-11-14 Thread Masami Hiramatsu
On Wed, 14 Nov 2018 22:10:52 +0100 Patrick Staehlin wrote: > On 14.11.18 16:49, Masami Hiramatsu wrote: > > On Wed, 14 Nov 2018 00:37:30 -0800 > > Masami Hiramatsu wrote: > > > >>> + > >>> +static int __kprobes

Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support

2018-11-14 Thread Masami Hiramatsu
On Wed, 14 Nov 2018 00:37:30 -0800 Masami Hiramatsu wrote: > > + > > +static int __kprobes patch_text(kprobe_opcode_t *addr, u32 opcode) > > +{ > > + if (is_compressed_insn(opcode)) > > + *(u16 *)addr = cpu_to_le16(opcode); > > + else > &

Re: [RFC/RFT 2/2] RISC-V: kprobes/kretprobe support

2018-11-14 Thread Masami Hiramatsu
N_H > + > +void simulate_caddisp16(u32 opcode, long addr, struct pt_regs *regs); > + > +#endif /* _RISCV_KERNEL_KPROBES_SIMULATE_INSN_H */ > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index 24a9333dda2c..d7113178d401 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -120,8 +121,14 @@ DO_ERROR_INFO(do_trap_ecall_m, > > asmlinkage void do_trap_break(struct pt_regs *regs) > { > + bool handler_found = false; > + > +#ifdef CONFIG_KPROBES > + if (kprobe_breakpoint_handler(regs)) > + handler_found = 1; Why don't you just return from here? > +#endif > #ifdef CONFIG_GENERIC_BUG > - if (!user_mode(regs)) { > + if (!handler_found && !user_mode(regs)) { > enum bug_trap_type type; > > type = report_bug(regs->sepc, regs); > @@ -137,7 +144,9 @@ asmlinkage void do_trap_break(struct pt_regs *regs) > } > #endif /* CONFIG_GENERIC_BUG */ > > - force_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)(regs->sepc), > current); > + if (!handler_found) > + force_sig_fault(SIGTRAP, TRAP_BRKPT, > + (void __user *)(regs->sepc), current); > } > > #ifdef CONFIG_GENERIC_BUG > diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c > index 88401d5125bc..eff816e33479 100644 > --- a/arch/riscv/mm/fault.c > +++ b/arch/riscv/mm/fault.c > @@ -22,6 +22,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -30,11 +31,33 @@ > #include > #include > > +#ifdef CONFIG_KPROBES > +static inline int notify_page_fault(struct pt_regs *regs, unsigned int cause) please use nokprobe_inline. > +{ > + int ret = 0; > + > + /* kprobe_running() needs smp_processor_id() */ > + if (!user_mode(regs)) { > + preempt_disable(); > + if (kprobe_running() && kprobe_fault_handler(regs, cause)) > + ret = 1; > + preempt_enable(); > + } > + > + return ret; > +} > +#else > +static inline int notify_page_fault(struct pt_regs *regs, unsigned int cause) > +{ > + return 0; > +} > +#endif > + > /* > * This routine handles page faults. It determines the address and the > * problem, and then passes it off to one of the appropriate routines. > */ > -asmlinkage void do_page_fault(struct pt_regs *regs) > +asmlinkage void __kprobes do_page_fault(struct pt_regs *regs) > { > struct task_struct *tsk; > struct vm_area_struct *vma; > @@ -47,6 +70,9 @@ asmlinkage void do_page_fault(struct pt_regs *regs) > cause = regs->scause; > addr = regs->sbadaddr; > > + if (notify_page_fault(regs, cause)) > + return; > + > tsk = current; > mm = tsk->mm; > > -- > 2.17.1 > Thank you, -- Masami Hiramatsu

Re: [PATCH 1/1] stackleak: Disable function tracing and kprobes for stackleak_erase()

2018-11-13 Thread Masami Hiramatsu
. > > So let's disable function tracing and kprobes for stackleak_erase(). > > Reported-by: kernel test robot > Signed-off-by: Alexander Popov Reviewed-by: Masami Hiramatsu Thank you! > --- > kernel/stackleak.c | 4 +++- > 1 file changed, 3 insertions(+), 1 del

Re: [PATCH 1/1] stackleak: Disable ftrace for stackleak.c

2018-11-13 Thread Masami Hiramatsu
much the only ones that currently do self > modification of code all over the kernel. Kprobes even more so than > ftrace. Right, since kprobes uses int3 or sw breakpoint exception for hooking into the code, it consumes stack much more. Thank you, -- Masami Hiramatsu

Re: [PATCH tip/core/rcu 20/41] kprobes: eplace synchronize_sched() with synchronize_rcu()

2018-11-13 Thread Masami Hiramatsu
On Sun, 11 Nov 2018 19:19:16 -0800 "Paul E. McKenney" wrote: > On Mon, Nov 12, 2018 at 12:00:48PM +0900, Masami Hiramatsu wrote: > > On Sun, 11 Nov 2018 11:43:49 -0800 > > "Paul E. McKenney" wrote: > > > > > Now that synchronize_rcu() waits

Re: [PATCH tip/core/rcu 20/41] kprobes: eplace synchronize_sched() with synchronize_rcu()

2018-11-11 Thread Masami Hiramatsu
Cc: Anil S Keshavamurthy > Cc: "David S. Miller" > Cc: Masami Hiramatsu > --- > kernel/kprobes.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 90e98e233647..08e31d863191 100644 >

Re: [PATCH v4 01/10] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-11 Thread Masami Hiramatsu
this looks reasonable and good to me. Reviewed-by: Masami Hiramatsu Thank you! > > Cc: Jiri Kosina > Cc: Andy Lutomirski > Cc: Kees Cook > Cc: Dave Hansen > Cc: Masami Hiramatsu > Fixes: 9222f606506c ("x86/alternatives: Lockdep-enforce text_mutex in > text_p

Re: [PATCH 1/1] stackleak: Disable ftrace for stackleak.c

2018-11-11 Thread Masami Hiramatsu
ftrace can't trace stack_erasing_sysctl() or perhaps even > stackleak_track_stack() as that may be very interesting to trace. I think it is not enough for stopping kprobes. If you want to stop the kprobes (int3 version) on stackleak_erase(), you should use NOKPROBE_SYMBOL(stackleak_erase), since kprobes can work without ftrace. Thank you, -- Masami Hiramatsu

Re: [PATCH RFC 0/3] Static calls

2018-11-10 Thread Masami Hiramatsu
> > > > > > Indeed. > > Although I had assumed that tracepoints already had appropriate jump label > magic. As far as I know, the jump label magic is for reducing the overhead when the tracepoint is OFF (because it can skip function parameter preparation), and this static call will be good when the tracepoint is ON (enabled) because of this can avoid retpoline performance degradation. Thank you, -- Masami Hiramatsu

[PATCH v2 12/12] selftests/ftrace: Add testcases for dynamic event

2018-11-05 Thread Masami Hiramatsu
Add common testcases for dynamic_events interface. - Add/remove kprobe events via dynamic_events - Add/remove synthetic events via dynamic_events - Selective clear events (clear events other interfaces) - Genelic clear events ("!LINE" syntax) Signed-off-by: Masami Hiramatsu ---

[PATCH v2 11/12] tracing: Add generic event-name based remove event method

2018-11-05 Thread Masami Hiramatsu
ork' > dynamic_events Or, # echo '!p:new_grp/new_event' > dynamic_events will remove new_grp/new_event event. Note that this doesn't check the event prefix (e.g. "p:") strictly, because the "group/event" name must be unique. Signed-off-by: Masami Hiramatsu --- Changes in v2: -

[PATCH v2 09/12] tracing: Remove unneeded synth_event_mutex

2018-11-05 Thread Masami Hiramatsu
. For safety, I added lockdep_assert_held(_mutex) for each function. Signed-off-by: Masami Hiramatsu --- kernel/trace/trace_events_hist.c | 30 +++--- 1 file changed, 7 insertions(+), 23 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace

[PATCH v2 10/12] tracing: Remove orphaned trace_add/remove_event_call functions

2018-11-05 Thread Masami Hiramatsu
Remove trace_add_event_call() and trace_remove_event_call() functions since those are not used anymore. Signed-off-by: Masami Hiramatsu --- include/linux/trace_events.h |2 -- kernel/trace/trace_events.c | 26 ++ 2 files changed, 2 insertions(+), 26 deletions

[PATCH v2 08/12] tracing: Use dyn_event framework for synthetic events

2018-11-05 Thread Masami Hiramatsu
tic/]EVENT_NAME TYPE ARG; [TYPE ARG;]... To remove events via tracing/dynamic_events, you can use "-:" prefix as same as other events. Signed-off-by: Masami Hiramatsu --- kernel/trace/Kconfig |1 kernel/trace/trace.c |8 + kernel/tr

[PATCH v2 07/12] tracing/uprobes: Use dyn_event framework for uprobe events

2018-11-05 Thread Masami Hiramatsu
Use dyn_event framework for uprobe events. This shows uprobe events on "dynamic_events" file. User can also define new uprobe events via dynamic_events. Signed-off-by: Masami Hiramatsu --- Changes in v2: - Use dyn_events_release_all() for clearing events. - Use nolock event_cal

[PATCH v2 06/12] tracing/kprobes: Use dyn_event framework for kprobe events

2018-11-05 Thread Masami Hiramatsu
Use dyn_event framework for kprobe events. This shows kprobe events on "tracing/dynamic_events" file. User can also define new events via tracing/dynamic_events. Signed-off-by: Masami Hiramatsu --- Changes in v2: - Use dyn_events_release_all() for clearing events. - Use nolock

[PATCH v2 05/12] tracing: Add unified dynamic event framework

2018-11-05 Thread Masami Hiramatsu
git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c new file mode 100644 index ..f17a887abb66 --- /dev/null +++ b/kernel/trace/trace_dynevent.c @@ -0,0 +1,210 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Generic dynamic event control interface + * + * Copyright (C) 2018 Masami

[PATCH v2 04/12] tracing: Integrate similar probe argument parsers

2018-11-05 Thread Masami Hiramatsu
Integrate similar argument parsers for kprobes and uprobes events into traceprobe_parse_probe_arg(). Signed-off-by: Masami Hiramatsu --- kernel/trace/trace_kprobe.c | 48 ++- kernel/trace/trace_probe.c | 47

[PATCH v2 02/12] tracing: Lock event_mutex before synth_event_mutex

2018-11-05 Thread Masami Hiramatsu
_mutex for solving lock dependency issue simpler. Signed-off-by: Masami Hiramatsu --- include/linux/trace_events.h |2 ++ kernel/trace/trace_events.c | 34 -- kernel/trace/trace_events_hist.c | 24 ++-- 3 files changed, 40 insertions(

[PATCH v2 03/12] tracing: Simplify creation and deletion of synthetic event

2018-11-05 Thread Masami Hiramatsu
it hits any error and returns the error code. It succeeds only if it has no error. Signed-off-by: Masami Hiramatsu --- kernel/trace/trace_events_hist.c | 53 +- 1 file changed, 18 insertions(+), 35 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b

[PATCH v2 01/12] tracing/uprobes: Add busy check when cleanup all uprobes

2018-11-05 Thread Masami Hiramatsu
. With this change, writing null to uprobe_events make sure all events are not enabled before removing events. So, it clears all events, or return an error (-EBUSY) with keeping all events. Signed-off-by: Masami Hiramatsu --- kernel/trace/trace_uprobe.c |7 +++ 1 file changed, 7 insertions

[PATCH v2 00/12] tracing: Unifying dynamic event interface

2018-11-05 Thread Masami Hiramatsu
this version are related to synthetic events. I need your review for those. (especially removing synth_event_mutex) You can try it from my git tree. https://github.com/mhiramat/linux/tree/unify-dynamic-events-v2 Thank you, --- Masami Hiramatsu (12): tracing/uprobes: Add busy chec

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 13:30:21 -0400 Steven Rostedt wrote: > On Sun, 4 Nov 2018 01:34:30 +0900 > Masami Hiramatsu wrote: > > > > > I was thinking of a bitmask that represents the handlers, and use that > > > to map which handler gets called for which shadow ent

Re: [RFC PATCH] tracing/kprobes: Avoid parsing symbol+offset when updating arguments

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 13:43:16 -0400 Steven Rostedt wrote: > On Sun, 4 Nov 2018 01:03:34 +0900 > Masami Hiramatsu wrote: > > > Introduce symbol_offset data structure for avoiding symbol+offset > > parsing when updating arguments. > > > > For kprobe even

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
ogether). > > > > > > Hmm, maybe I can introduce a struct like > > > > struct symbol_offset { > > long offset; > > char symbol[]; > > }; > > > > and use it instead of parsing the symbol+offset always. > > The parsing should be fine. The issue I had was that I couldn't trigger > it to happen more than once. That's why this passed testing. We didn't > do something that required it to be called more than once and that is > here the bug would trigger. Hmm, I hit it by kprobe_args_syntax.tc, so hit once is enough to kick this bug. Maybe some config option makes "+-" readonly, which previously didn't enabled. Thank you, -- Masami Hiramatsu

[RFC PATCH] tracing/kprobes: Avoid parsing symbol+offset when updating arguments

2018-11-03 Thread Masami Hiramatsu
he "symbol+offset" string and parse it repeatedly, but that is inefficient. This introduces symbol_offset data structure which can save the offset and symbol separated, so that we don't need to parse it anymore. Signed-off-by: Masami Hiramatsu --- kernel/trace/

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 09:54:24 -0400 Steven Rostedt wrote: > On Fri, 2 Nov 2018 16:14:59 +0900 > Masami Hiramatsu wrote: > > > On Thu, 1 Nov 2018 15:10:14 -0400 > > Steven Rostedt wrote: > > > > > On Thu, 1 Nov 2018 23:29:28 +0900 > > > Masami Hiram

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-02 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 15:10:14 -0400 Steven Rostedt wrote: > On Thu, 1 Nov 2018 23:29:28 +0900 > Masami Hiramatsu wrote: > > > Fix strpbrk()'s argument order, it must pass acceptable string > > in 2nd argument. Note that this can cause a kernel panic where > > i

Re: [PATCH AUTOSEL 4.14 17/19] selftests: ftrace: Add synthetic event syntax testcase

2018-11-01 Thread Masami Hiramatsu
On Tue, 30 Oct 2018 14:21:12 -0400 Sasha Levin wrote: > On Tue, Oct 30, 2018 at 10:58:15AM -0400, Steven Rostedt wrote: > >On Tue, 30 Oct 2018 09:28:22 -0400 > >Sasha Levin wrote: > > > >> From: Masami Hiramatsu > >> > >> [ Upstream

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 21:49:48 +1100 Aleksa Sarai wrote: > On 2018-11-01, Masami Hiramatsu wrote: > > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > > this issue for generic solution (e.g. for the arch which doesn't > > >

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-11-01 Thread Masami Hiramatsu
TMPL_END_IDX * sizeof(kprobe_opcode_t)); > > > > /* Adjust buffer according to instruction. */ > > > > The patch fixes the issue for kretprobes. It looks good to me. This looks good to me too. Thank you for finding and fixing it :) Acked-by: Masami Hiramatsu Thanks! > > Thanks, > > -Will -- Masami Hiramatsu

[BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-01 Thread Masami Hiramatsu
Fix strpbrk()'s argument order, it must pass acceptable string in 2nd argument. Note that this can cause a kernel panic where it recovers backup character to code->data. Fixes: a6682814f371 ("tracing/kprobes: Allow kprobe-events to record module symbol") Signed-off-by: Mas

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
try to have an RFC > > patch set ready by plumbers. > > Should I continue working on this patchset? Yes, until we finally introduce Steven's algorithm on all arch (yeah, we still have some archs which don't support graph-tracer but supports kprobes), I think your patch is the best fix for this issue. Thank you, -- Masami Hiramatsu

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Tue, 30 Oct 2018 14:19:53 +1100 Aleksa Sarai wrote: > On 2018-10-30, Masami Hiramatsu wrote: > > > Historically, kretprobe has always produced unusable stack traces > > > (kretprobe_trampoline is the only entry in most cases, because of the > > > funky stack

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-29 Thread Masami Hiramatsu
de > > @@ -2590,6 +2591,7 @@ static void __ftrace_trace_stack(struct ring_buffer > *buffer, > struct ring_buffer_event *event; > struct stack_entry *entry; > struct stack_trace trace; > + struct kretprobe_instance *ri = current_kretprobe_instance(); > int use_stack; > int size = FTRACE_STACK_ENTRIES; > > @@ -2626,7 +2628,9 @@ static void __ftrace_trace_stack(struct ring_buffer > *buffer, > trace.entries = this_cpu_ptr(ftrace_stack.calls); > trace.max_entries = FTRACE_STACK_MAX_ENTRIES; > > - if (regs) > + if (ri) > + kretprobe_save_stack_trace(ri, ); > + else if (regs) > save_stack_trace_regs(regs, ); > else > save_stack_trace(); > @@ -2653,7 +2657,10 @@ static void __ftrace_trace_stack(struct ring_buffer > *buffer, > else { > trace.max_entries = FTRACE_STACK_ENTRIES; > trace.entries = entry->caller; > - if (regs) > + > + if (ri) > + kretprobe_save_stack_trace(ri, ); > + else if (regs) > save_stack_trace_regs(regs, ); > else > save_stack_trace(); > -- > 2.19.1 > -- Masami Hiramatsu

Re: [PATCH v6 10/15] tracing: Add hist trigger snapshot() action test case

2018-10-23 Thread Masami Hiramatsu
stgit@devbox > + > +echo 0 > /sys/kernel/debug/tracing/events/sched/enable > + > +if ! grep -q "changed:" events/sched/sched_waking/hist; then > +fail "Failed to create onchange action inter-event histogram" > +fi > + > +if ! grep -q "comm=ping" snapshot; then > +fail "Failed to create snapshot action inter-event histogram" > +fi > + > +do_reset Also you don't need this. BTW, are there no "expected fail" tests? (e.g. passing wrong snapshot command to trigger) Thank you, > + > +exit 0 > -- > 2.14.1 > -- Masami Hiramatsu

Re: [PATCH v6 07/15] tracing: Move hist trigger key printing into a separate function

2018-10-23 Thread Masami Hiramatsu
void *key, > + struct tracing_map_elt *elt) > +{ > + const char *field_name; > + unsigned int i; > + > + hist_trigger_print_key(m, hist_data, key, elt); > > seq_printf(m, " hitcount: %10llu", > tracing_map_read_sum(elt, HITCOUNT_IDX)); > -- > 2.14.1 > -- Masami Hiramatsu

Re: [PATCH v6 01/15] tracing: Refactor hist trigger action code

2018-10-22 Thread Masami Hiramatsu
== onmax_save) > + else if (data->handler == HANDLER_ONMAX) > onmax_destroy(data); > else > kfree(data); > @@ -4260,16 +4326,14 @@ static int parse_actions(struct hist_trigger_data > *hist_data) > ret = PTR_ERR(data); > break; > } > - data->fn = action_trace; > } else if (strncmp(str, "onmax(", strlen("onmax(")) == 0) { > char *action_str = str + strlen("onmax("); > > - data = onmax_parse(action_str); > + data = onmax_parse(action_str, HANDLER_ONMAX); > if (IS_ERR(data)) { > ret = PTR_ERR(data); > break; > } > - data->fn = onmax_save; > } else { > ret = -EINVAL; > break; > @@ -4281,8 +4345,7 @@ static int parse_actions(struct hist_trigger_data > *hist_data) > return ret; > } > > -static int create_actions(struct hist_trigger_data *hist_data, > - struct trace_event_file *file) > +static int create_actions(struct hist_trigger_data *hist_data) > { > struct action_data *data; > unsigned int i; > @@ -4291,14 +4354,17 @@ static int create_actions(struct hist_trigger_data > *hist_data, > for (i = 0; i < hist_data->attrs->n_actions; i++) { > data = hist_data->actions[i]; > > - if (data->fn == action_trace) { > - ret = onmatch_create(hist_data, file, data); > + if (data->handler == HANDLER_ONMATCH) { > + ret = onmatch_create(hist_data, data); > if (ret) > return ret; > - } else if (data->fn == onmax_save) { > + } else if (data->handler == HANDLER_ONMAX) { > ret = onmax_create(hist_data, data); > if (ret) > return ret; > + } else { > + ret = -EINVAL; This is a bit odd (or just mixtured), return -EINVAL will be enough here. Or above "if (ret) return ret;" shoud be "if (ret) break;" since this function returns ret soon after this loop. > + break; > } > } > Thank you, -- Masami Hiramatsu

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-22 Thread Masami Hiramatsu
;) > Cc: sta...@vger.kernel.org > Signed-off-by: Kees Cook Good catch! This looks good to me. Acked-by: Masami Hiramatsu Thank you, > --- > arch/arm/probes/kprobes/opt-arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/probes/kpr

[tip:perf/core] kprobes/x86: Use preempt_enable() in optimized_callback()

2018-10-21 Thread tip-bot for Masami Hiramatsu
Commit-ID: 2e62024c265aa69315ed02835623740030435380 Gitweb: https://git.kernel.org/tip/2e62024c265aa69315ed02835623740030435380 Author: Masami Hiramatsu AuthorDate: Sat, 20 Oct 2018 18:47:53 +0900 Committer: Ingo Molnar CommitDate: Mon, 22 Oct 2018 03:31:01 +0200 kprobes/x86: Use

[PATCH 2/2] selftests/ftrace: Fix synthetic event test to delete event correctly

2018-10-21 Thread Masami Hiramatsu
t;>') instead of normal redirection ('>'). Fixes: f06eec4d0f2c ('selftests: ftrace: Add inter-event hist triggers testcases') Signed-off-by: Masami Hiramatsu Cc: sta...@vger.kernel.org Cc: Rajvi Jingar Cc: Tom Zanussi Cc: Shuah Khan Cc: Steven Rostedt (VMware) --- .../trigger-synthetic-ev

[PATCH 1/2] tracing: Return -ENOENT if there is no target synthetic event

2018-10-21 Thread Masami Hiramatsu
cing: Add support for 'synthetic' events') Signed-off-by: Masami Hiramatsu Cc: sta...@vger.kernel.org Cc: Tom Zanussi Cc: Steven Rostedt --- kernel/trace/trace_events_hist.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/ker

[PATCH 0/2] tracing: Fix synthetic event parser

2018-10-21 Thread Masami Hiramatsu
give this your ack? Thank you, --- Masami Hiramatsu (2): tracing: Return -ENOENT if there is no target synthetic event selftests/ftrace: Fix synthetic event test to delete event correctly kernel/trace/trace_events_hist.c |4 +++- .../trigger-synthetic-event

[PATCH -tip] kprobes/x86: Use preempt_enable() in optimized_callback()

2018-10-20 Thread Masami Hiramatsu
need to use _no_resched macro. Let's use preempt_enable() instead. Fixes: a19b2e3d7839 ("kprobes/x86: Remove IRQ disabling from ftrace-based/optimized kprobes”) Link: https://lkml.kernel.org/r/37cb98c2-af9b-475b-8b2d-7b414dc49...@vmware.com Reported-by: Nadav Amit Signed-off-by: Masami

Re: [RFC PATCH 1/5] x86: introduce preemption disable prefix

2018-10-19 Thread Masami Hiramatsu
_enable(regs);// => assume it enables IRQs > >> > >> ... > >> // resched irq can be delivered here. It will not caused rescheduling > >> // since preemption is disabled > >> > >> cond_local_irq_disable(regs);// => assume it disables IRQs > >> ist_exit(regs);// => preempt_enable_no_resched() > >> } > >> > >> At this point resched will not happen for unbounded length of time (unless > >> there is another point when exiting the trap handler that checks if > >> preemption should take place). > > > > I think it's only a bug in the cases where someone uses extable to fix > > up an int3 (which would be nuts) or that we oops. But I should still > > fix it. In the normal case where int3 was in user code, we'll miss > > the reschedule in do_trap(), but we'll reschedule in > > prepare_exit_to_usermode() -> exit_to_usermode_loop(). > > Thanks for your quick response, and sorry for bothering instead of dealing > with it. Note that do_debug() does something similar to do_int3(). > > And then there is optimized_callback() that also uses > preempt_enable_no_resched(). I think the original use was correct, but then > a19b2e3d7839 ("kprobes/x86: Remove IRQ disabling from ftrace-based/optimized > kprobes”) removed the IRQ disabling, while leaving > preempt_enable_no_resched() . No? Ah, good catch! Indeed, we don't need to stick on no_resched anymore. Thanks! -- Masami Hiramatsu

Re: [PATCH v2 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-18 Thread Masami Hiramatsu
along with the other changes. Shuah, just a note that this test case must fail unless these fixes are applied. Thank you, -- Masami Hiramatsu

[PATCH v2 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-18 Thread Masami Hiramatsu
Add a testcase to check the syntax and field types for synthetic_events interface. Signed-off-by: Masami Hiramatsu --- .../inter-event/trigger-synthetic-event-syntax.tc | 80 1 file changed, 80 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d

[PATCH v2 2/3] tracing: Fix synthetic event to allow semicolon at end

2018-10-18 Thread Masami Hiramatsu
;" > synthetic_events sh: write error: Invalid argument This behavior is difficult for users to understand. Let's allow the last independent semicolon too. Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu Cc: sta...@vger

[PATCH v2 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-18 Thread Masami Hiramatsu
synthetic_events # cat synthetic_events myeventunsigned long var Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu Cc: sta...@vger.kernel.org Cc: Tom Zanussi Cc: Steven Rostedt --- Changes in v2: - Fix a typo of st

[PATCH v2 0/3] tracing: Fix synthetic event parser

2018-10-18 Thread Masami Hiramatsu
last patch in this series adding a testcase for synthetic event parser. Thank you, --- Masami Hiramatsu (3): tracing: Fix synthetic event to accept unsigned modifier tracing: Fix synthetic event to allow semicolon at end selftests: ftrace: Add synthetic event syntax testcase ke

Re: [PATCH 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-18 Thread Masami Hiramatsu
On Thu, 18 Oct 2018 21:11:35 +0900 Masami Hiramatsu wrote: > Fix synthetic event to accept unsigned modifier for its field type > correctly. > > Currently, synthetic_events interface returns error for "unsigned" > modifiers as below; > > # echo "myevent un

[PATCH 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-18 Thread Masami Hiramatsu
Add a testcase to check the syntax and field types for synthetic_events interface. Signed-off-by: Masami Hiramatsu --- .../inter-event/trigger-synthetic-event-syntax.tc | 80 1 file changed, 80 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d

[PATCH 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-18 Thread Masami Hiramatsu
synthetic_events # cat synthetic_events myeventunsigned long var Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu Cc: Cc: Tom Zanussi Cc: Steven Rostedt --- kernel/trace/trace_events_hist.c | 30 +++

[PATCH 2/3] tracing: Fix synthetic event to allow semicolon at end

2018-10-18 Thread Masami Hiramatsu
;" > synthetic_events sh: write error: Invalid argument This behavior is difficult for users to understand. Let's allow the last independent semicolon too. Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu Cc: Cc: Tom Z

[PATCH 0/3] tracing: Fix synthetic event parser

2018-10-18 Thread Masami Hiramatsu
last patch in this series adding a testcase for synthetic event parser. Thank you, --- Masami Hiramatsu (3): tracing: Fix synthetic event to accept unsigned modifier tracing: Fix synthetic event to allow semicolon at end selftests: ftrace: Add synthetic event syntax testcase ke

Re: perf's handling of unfindable user symbols...

2018-10-18 Thread Masami Hiramatsu
On Wed, 17 Oct 2018 09:28:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 17, 2018 at 05:22:26PM +0900, Masami Hiramatsu escreveu: > > On Tue, 16 Oct 2018 15:45:06 -0300 > > Arnaldo Carvalho de Melo wrote: > > > So, I thought something had changed and in t

  1   2   3   4   5   6   7   8   9   10   >