[PATCH v2 2/2] staging: lustre: lprocfs: Use seq_puts instead of seq_printf

2017-05-18 Thread Mathias Rav
Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by: Mathias Rav <mathias...@gmail.com> --- .../staging/lustre/lustre/obdclass/lprocfs_status.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/stagi

[PATCH v2 2/2] staging: lustre: lprocfs: Use seq_puts instead of seq_printf

2017-05-18 Thread Mathias Rav
Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by: Mathias Rav --- .../staging/lustre/lustre/obdclass/lprocfs_status.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustr

[PATCH v2 0/2] staging: lustre: lprocfs: Fix coding style issues

2017-05-18 Thread Mathias Rav
This patchset fixes two style issues in lprocfs_status.c related to simple_strtoul and seq_printf (reported by checkpatch). v1->v2: - Patch 1/2 now completely removes lprocfs_{rd,wr}_uint - Patch 2/2 unchanged Mathias Rav (2): staging: lustre: Use kstrtouint_from_user in ldlm_rw_u

[PATCH v2 0/2] staging: lustre: lprocfs: Fix coding style issues

2017-05-18 Thread Mathias Rav
This patchset fixes two style issues in lprocfs_status.c related to simple_strtoul and seq_printf (reported by checkpatch). v1->v2: - Patch 1/2 now completely removes lprocfs_{rd,wr}_uint - Patch 2/2 unchanged Mathias Rav (2): staging: lustre: Use kstrtouint_from_user in ldlm_rw_u

[PATCH v2 1/2] staging: lustre: Use kstrtouint_from_user in ldlm_rw_uint

2017-05-18 Thread Mathias Rav
tox causes EINVAL when the written number is followed by other (garbage) characters, whereas previously the garbage would be ignored and such a write would succeed. Signed-off-by: Mathias Rav <mathias...@gmail.com> --- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 20 - .

[PATCH v2 1/2] staging: lustre: Use kstrtouint_from_user in ldlm_rw_uint

2017-05-18 Thread Mathias Rav
tox causes EINVAL when the written number is followed by other (garbage) characters, whereas previously the garbage would be ignored and such a write would succeed. Signed-off-by: Mathias Rav --- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 20 - .../lustre/lustre/obdclass/lprocf

Re: [PATCH 1/2] staging: lustre: lprocfs: Use kstrtouint_from_user

2017-05-18 Thread Mathias Rav
On Thu, 18 May 2017 14:48:25 + "Dilger, Andreas" <andreas.dil...@intel.com> wrote: > On May 18, 2017, at 15:53, Greg Kroah-Hartman <gre...@linuxfoundation.org> > wrote: > > > > On Thu, May 04, 2017 at 12:13:38PM -0400, Mathias Rav wrote: > >&

Re: [PATCH 1/2] staging: lustre: lprocfs: Use kstrtouint_from_user

2017-05-18 Thread Mathias Rav
On Thu, 18 May 2017 14:48:25 + "Dilger, Andreas" wrote: > On May 18, 2017, at 15:53, Greg Kroah-Hartman > wrote: > > > > On Thu, May 04, 2017 at 12:13:38PM -0400, Mathias Rav wrote: > >> Prefer kstrtouint_from_user to copy_from_user+simple_st

[PATCH 1/2] staging: lustre: lprocfs: Use kstrtouint_from_user

2017-05-04 Thread Mathias Rav
trtox only allows a trailing line break. The previous implementation allowed a write of zero bytes whereas kstrtox will return -EINVAL. Since this only affects a single debugfs endpoint, this should be a permissible slight change of semantics in exchange for 18 fewer lines of code. Signed-off-by: M

[PATCH 2/2] staging: lustre: lprocfs: Use seq_puts

2017-05-04 Thread Mathias Rav
Replace all occurrences of seq_printf with no formatting directives in lprocfs_status.c with seq_puts. Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by: Mathias Rav <mathias...@gmail.com> --- .../staging/lustre/lustre/obdclass/lprocf

[PATCH 1/2] staging: lustre: lprocfs: Use kstrtouint_from_user

2017-05-04 Thread Mathias Rav
trtox only allows a trailing line break. The previous implementation allowed a write of zero bytes whereas kstrtox will return -EINVAL. Since this only affects a single debugfs endpoint, this should be a permissible slight change of semantics in exchange for 18 fewer lines of code. Signed-off-by: M

[PATCH 2/2] staging: lustre: lprocfs: Use seq_puts

2017-05-04 Thread Mathias Rav
Replace all occurrences of seq_printf with no formatting directives in lprocfs_status.c with seq_puts. Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by: Mathias Rav --- .../staging/lustre/lustre/obdclass/lprocfs_status.c | 20 ++

[PATCH 0/2] staging: lustre: lprocfs: Fix coding style issues

2017-05-04 Thread Mathias Rav
the garbage would be ignored and such a write would succeed. Mathias Rav (2): staging: lustre: lprocfs: Use kstrtouint_from_user staging: lustre: lprocfs: Use seq_puts .../lustre/lustre/obdclass/lprocfs_status.c| 42 ++--- 1 file changed, 11 insertions(+), 31

[PATCH 0/2] staging: lustre: lprocfs: Fix coding style issues

2017-05-04 Thread Mathias Rav
the garbage would be ignored and such a write would succeed. Mathias Rav (2): staging: lustre: lprocfs: Use kstrtouint_from_user staging: lustre: lprocfs: Use seq_puts .../lustre/lustre/obdclass/lprocfs_status.c| 42 ++--- 1 file changed, 11 insertions(+), 31