RIP: 0010:g84_gr_tlb_flush+0x2eb/0x300 [nouveau]

2020-10-20 Thread Mathieu Malaterre
Hi there, Could someone please comment on the following hard-lock (*). Staring at the code, I see `nvkm_rd32` calls are enclosed in a timeout detection, except one. drivers/gpu/drm/nouveau/nvkm/engine/gr/g84.c#L171 ... nvkm_msec(device, 2000, if (!(nvkm_rd32(device, 0x100c80) & 0x0001))

Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

2020-08-25 Thread Mathieu Malaterre
ev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2307,7 +2307,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev, > > ret = radeon_kick_out_firmware_fb(pdev); > if (ret) > - return ret; > + goto err_release_fb; G

Re: Help: Regression in v4.19 : do_IRQ: 0.37 No irq handler for vector

2019-07-19 Thread Mathieu Malaterre
On Fri, Jul 19, 2019 at 1:32 PM Mathieu Malaterre wrote: > > [cc me please] > > Hi there, > > I recently upgraded my desktop to Debian/buster. Now when I start my > xfce session I can hear the system bell, and my dmesg is filled with > numerous: > > [ 920.72834

Help: Regression in v4.19 : do_IRQ: 0.37 No irq handler for vector

2019-07-19 Thread Mathieu Malaterre
[cc me please] Hi there, I recently upgraded my desktop to Debian/buster. Now when I start my xfce session I can hear the system bell, and my dmesg is filled with numerous: [ 920.728347] do_IRQ: 0.37 No irq handler for vector The symptoms seems to be gone using git/master:

Re: [RFC PATCH v1 11/13] powerpc/ptrace: create ppc_gethwdinfo()

2019-06-25 Thread Mathieu Malaterre
On Tue, Jun 25, 2019 at 1:22 PM Christophe Leroy wrote: > > Create ippc_gethwdinfo() to handle PPC_PTRACE_GETHWDBGINFO and s/ippc_gethwdinfo/ppc_gethwdinfo/ > reduce ifdef mess > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/ptrace/ptrace-adv.c | 15 +++ >

[PATCH v2] lib/mpi: fix build with clang

2019-06-21 Thread Mathieu Malaterre
Suggested-by: Joel Stanley Cc: Segher Boessenkool Signed-off-by: Mathieu Malaterre --- v2: Instead of passing compat flag to clang to behave as gcc, remove the superfluous cast lib/mpi/longlong.h | 105 +++-- 1 file changed, 35 insertions(+), 70 deletio

[PATCH] powerpc/lib/xor_vmx: Relax frame size for clang

2019-06-21 Thread Mathieu Malaterre
ot;) until a proper fix is implemented upstream in clang and relax requirement for clang. Link: https://github.com/ClangBuiltLinux/linux/issues/563 Cc: Joel Stanley Signed-off-by: Mathieu Malaterre --- arch/powerpc/lib/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/li

Re: [PATCH] crypto: Fix build for clang

2019-06-21 Thread Mathieu Malaterre
Joel, On Fri, Jun 21, 2019 at 9:30 AM Joel Stanley wrote: > > On Fri, 21 Jun 2019 at 07:13, Mathieu Malaterre wrote: > > > > The header file `longlong.h` makes uses of GNU extensions, this trigger > > an error when compiling this code with clang. Add a special flag to

[PATCH] crypto: Fix build for clang

2019-06-21 Thread Mathieu Malaterre
y Cc: Masahiro Yamada Signed-off-by: Mathieu Malaterre --- lib/mpi/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/mpi/Makefile b/lib/mpi/Makefile index d5874a7f5ff9..de4d96e988a3 100644 --- a/lib/mpi/Makefile +++ b/lib/mpi/Makefile @@ -5,6 +5,13 @@ obj-$(C

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-19 Thread Mathieu Malaterre
On Wed, Jun 19, 2019 at 4:18 PM Benjamin Herrenschmidt wrote: > > On Wed, 2019-06-19 at 22:32 +1000, Michael Ellerman wrote: > > Christoph Hellwig writes: > > > Any chance this could get picked up to fix the regression? > > > > Was hoping Ben would Ack it. He's still powermac maintainer :) > > >

[tip:timers/core] clocksource: Move inline keyword to the beginning of function declarations

2019-06-14 Thread tip-bot for Mathieu Malaterre
Commit-ID: 0f48b41f597e3b62b649abbf796e1e72901f9df3 Gitweb: https://git.kernel.org/tip/0f48b41f597e3b62b649abbf796e1e72901f9df3 Author: Mathieu Malaterre AuthorDate: Fri, 24 May 2019 12:33:39 +0200 Committer: Thomas Gleixner CommitDate: Fri, 14 Jun 2019 17:04:03 +0200 clocksource

[tip:x86/cleanups] x86/tsc: Move inline keyword to the beginning of function declarations

2019-06-14 Thread tip-bot for Mathieu Malaterre
Commit-ID: 83e837269e87436fda1cbf82214a5494fb6b35b1 Gitweb: https://git.kernel.org/tip/83e837269e87436fda1cbf82214a5494fb6b35b1 Author: Mathieu Malaterre AuthorDate: Fri, 24 May 2019 12:32:51 +0200 Committer: Thomas Gleixner CommitDate: Fri, 14 Jun 2019 17:02:09 +0200 x86/tsc: Move

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-14 Thread Mathieu Malaterre
On Thu, Jun 13, 2019 at 10:27 AM Christoph Hellwig wrote: > > With the strict dma mask checking introduced with the switch to > the generic DMA direct code common wifi chips on 32-bit powerbooks > stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds > to allow them to reliably

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-07 Thread Mathieu Malaterre
On Wed, Jun 5, 2019 at 1:32 PM Mathieu Malaterre wrote: > > On Mon, Jun 3, 2019 at 3:00 PM Christophe Leroy > wrote: > > > > When booting through OF, setup_disp_bat() does nothing because > > disp_BAT are not set. By change, it used to work because BOOTX > >

[PATCH] powerpc/32: Add .data..LASAN* sections explicitly

2019-06-05 Thread Mathieu Malaterre
-gnu-ld: warning: orphan section `.data..LASANLOC1' from `net/core/filter.o' being placed in section `.data..LASANLOC1' This commit remove those warnings produced at W=1. Reported-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/vmlinux.lds.S | 3 +++ 1 file changed

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-05 Thread Mathieu Malaterre
nel Userspace Access Protection (KUAP) because it is within user > address space. > > This patch fixes those issues by properly setting disp_BAT through > a call to btext_prepare_BAT(), allowing setup_disp_bat() to > properly setup BAT3 for early bootx screen buffer access. > > Reported

[PATCH] hfsplus: Replace strncpy with memcpy

2019-05-29 Thread Mathieu Malaterre
before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] Signed-off-by: Mathieu Malaterre --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index d5403b4004c9..bb0b27d88e50 100644

[PATCH] kbuild: Remove -Waggregate-return from scripts/Makefile.extrawarn

2019-05-29 Thread Mathieu Malaterre
from W=2 completely. Signed-off-by: Mathieu Malaterre --- scripts/Makefile.extrawarn | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 3ab8d1a303cd..98081ab300e5 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-28 Thread Mathieu Malaterre
On Tue, May 28, 2019 at 1:40 PM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > > Fix warnings treated as errors with W=1: > > > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > > [-Werror=unused-but-set-variable] >

[PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-24 Thread Mathieu Malaterre
prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning on powerpc. Also remove the duplicated prototypes since not required anymore. Cc: Christophe Leroy Signed-off-by: Mathieu Malaterre

[PATCH] clocksource: Move inline keyword to the beginning of function declarations

2019-05-24 Thread Mathieu Malaterre
' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Mathieu Malaterre --- kernel/time/clocksource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 3bcc19ceb073..fff5f64981c6 100644

[PATCH] x86/tsc: Move inline keyword to the beginning of function declarations

2019-05-24 Thread Mathieu Malaterre
' is not at beginning of declaration [-Wold-style-declaration] Cc: Peter Zijlstra Signed-off-by: Mathieu Malaterre --- arch/x86/kernel/tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 0b29e58f288e..75a41bddbc9d 100644 --- a/arch

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-23 Thread Mathieu Malaterre
ping ? On Tue, Mar 12, 2019 at 10:23 PM Mathieu Malaterre wrote: > > Fix warnings treated as errors with W=1: > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-o

[PATCH] powerpc/power: Expose pfn_is_nosave prototype

2019-05-23 Thread Mathieu Malaterre
prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning in powerpc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/suspend.c | 1 + include/linux/suspend.h | 1 + 2 files

[PATCH] powerpc: Remove variable ‘path’ since not used

2019-05-23 Thread Mathieu Malaterre
e original patch and simplify the code, by removing the variable ‘path’ completely. Fix line over 90 characters. Suggested-by: Michael Ellerman Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/prom_init.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ar

[PATCH] powerpc/32s: Include header file to fix a warning

2019-05-23 Thread Mathieu Malaterre
pes] Make sure to include to provide the following prototype: module_alloc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/mm/kasan/kasan_init_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c index 0d

[PATCH v2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
he warning. Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") Suggested-by: Christoph Hellwig Cc: Michael Neuling Signed-off-by: Mathieu Malaterre --- v2: do not hide warning using a hack arch/powerpc/kernel/hw_breakpoint.c | 7 ++- 1 file changed, 6 insertions(+),

Re: [PATCH] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
Hi Christoph, On Wed, May 15, 2019 at 3:14 PM Christoph Hellwig wrote: > > On Wed, May 15, 2019 at 02:09:42PM +0200, Mathieu Malaterre wrote: > > In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > > option") the following piece of code was added:

[PATCH] powerpc: Include header file to fix a warning

2019-05-15 Thread Mathieu Malaterre
move __find_linux_pte() out of hugetlbpage.c") Cc: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/mm/pgtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index db4a6253df92..2aa042193ace 100644 --- a/arch/powerpc/mm

[PATCH] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
dd force enable of DAWR on P9 option") Cc: Michael Neuling Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/hw_breakpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index f70fb8

Re: [PATCH 1/7] rtc: jz4740: set range

2019-04-26 Thread Mathieu Malaterre
On Thu, Apr 18, 2019 at 12:01 PM Alexandre Belloni wrote: > > RTC_SEC is a 32-bit seconds counter. For the entire series: Tested-by: Mathieu Malaterre Arch is MIPS Creator CI20 > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-jz4740.c | 12 ++-- >

Re: [PATCH 2/7] rtc: jz4740: switch to rtc_time64_to_tm/rtc_tm_to_time64

2019-04-26 Thread Mathieu Malaterre
On Thu, Apr 18, 2019 at 12:00 PM Alexandre Belloni wrote: > > Call the 64bit versions of rtc_tm time conversion now that the range is > enforced by the core. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-jz4740.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > >

Re: mmc: core: fix possible use after free of host

2019-04-26 Thread Mathieu Malaterre
On Wed, Apr 17, 2019 at 10:28 AM Pan Bian wrote: > > In the function mmc_alloc_host, the function put_device is called to > release allocated resources when mmc_gpio_alloc fails. Finally, the > function pointed by host->class_dev.class->dev_release (i.e., > mmc_host_classdev_release) is used to

[PATCH v3] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
the trailing statement onto the next line to pass checkpatch verification. Acked-by: "Gustavo A. R. Silva" Signed-off-by: Mathieu Malaterre --- v3: move break statements onto next line and please checkpatch v2: some cases were missed in v1, update missing ones lib/siph

Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld wrote: > > Conceptually this seems pretty reasonable. Though, style-wise, perhaps > you might want to put those breaks on the next line too, i.e. s/; > break;/;\n\t\tbreak;/? Good point. This needs some more love since checkpatch complains now

Re: [PATCH 1/2] firewire: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
On Wed, Mar 13, 2019 at 9:39 PM Gustavo A. R. Silva wrote: > > Mathieu, > > On 3/13/19 3:28 PM, Mathieu Malaterre wrote: > > ping ? > > > > I have sent the following patch to address all these warnings in > firewire: > > https://lore.kernel.org/patchwork/p

Re: [PATCH 1/2] firewire: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:42 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > In this particular case rewrote the comment to start with the string "fall > t

Re: [PATCH] signal: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > kernel/signal.c:795:13: warning: th

Re: [PATCH] blkcg: annotate implicit fall through

2019-03-13 Thread Mathieu Malaterre
ping ? On Mon, Jan 14, 2019 at 9:31 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > kernel/trace/blktrace.c:725:9: wa

[PATCH v2] lib/siphash.c: annotate implicit fall throughs

2019-03-13 Thread Mathieu Malaterre
-fallthrough=] lib/siphash.c:434:12: warning: this statement may fall through [-Wimplicit-fallthrough=] lib/siphash.c:462:12: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: "Gustavo A. R. Silva" Signed-off-by: Mathieu Malaterre --- v2: some cases were missed in

[PATCH] kbuild: deb-pkg: set executable bit for debian/rules

2019-03-13 Thread Mathieu Malaterre
This will remove the warning: dpkg-buildpackage: warning: debian/rules is not executable; fixing that Signed-off-by: Mathieu Malaterre --- scripts/package/mkdebian | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian index f030961c5165

[PATCH] kernel/workqueue: Use __printf markup to silence compiler in function 'alloc_workqueue'

2019-03-12 Thread Mathieu Malaterre
Silence warnings (triggered at W=1) by adding relevant __printf attributes. kernel/workqueue.c:4249:2: warning: function 'alloc_workqueue' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- kernel/workqueue.c | 1 + 1

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-02-15 Thread Mathieu Malaterre
On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada wrote: > > I often test all Kconfig commands for all architectures. To ease my > workflow, I want 'make defconfig' at least working without any cross > compiler. > > Currently, arch/powerpc/Makefile checks CROSS_COMPILE to decide the > default

Re: [PATCH] powerpc/ptrace: Add prototype for function pt_regs_check

2019-02-15 Thread Mathieu Malaterre
On Fri, Feb 15, 2019 at 9:21 AM Christophe Leroy wrote: > > > > Le 15/02/2019 à 09:11, Mathieu Malaterre a écrit : > > On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote: > >> > >> `pt_regs_check` is a dummy function, its purpose is to break the bui

Re: [PATCH] powerpc/ptrace: Add prototype for function pt_regs_check

2019-02-15 Thread Mathieu Malaterre
On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote: > > `pt_regs_check` is a dummy function, its purpose is to break the build > if struct pt_regs and struct user_pt_regs don't match. > > This function has no functionnal purpose, and will get eliminated at > link time or af

[PATCH] Move static keyword at beginning of declaration

2019-02-02 Thread Mathieu Malaterre
of declaration [-Werror=old-style-declaration] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/ps3/os-area.c| 4 ++-- arch/powerpc/platforms/ps3/system-bus.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/ps3/os-area.c b/arch/powerpc

[PATCH] powerpc: Remove trailing semicolon after curly brace

2019-02-02 Thread Mathieu Malaterre
There is not point in having a trailing semicolon after a closing curly brace. Remove it. Signed-off-by: Mathieu Malaterre --- arch/powerpc/sysdev/tsi108_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-31 Thread Mathieu Malaterre
Nick, On Fri, Jan 25, 2019 at 6:06 PM Kees Cook wrote: > > On Fri, Jan 25, 2019 at 9:18 PM Mathieu Malaterre wrote: > > > > On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre

Re: [PATCH v8 00/26] Ingenic TCU patchset v8

2019-01-25 Thread Mathieu Malaterre
Paul, On Thu, Jan 24, 2019 at 10:41 PM Paul Cercueil wrote: > > Hi Mathieu, > > Le jeu. 24 janv. 2019 à 18:26, Mathieu Malaterre a > écrit : > > Paul, > > > > On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil > > wrote: > >> > >> Hi, &g

Re: [PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-25 Thread Mathieu Malaterre
On Fri, Jan 25, 2019 at 5:26 AM Nick Desaulniers wrote: > > On Fri, Jan 18, 2019 at 11:32 AM Mathieu Malaterre wrote: > > > > In the past an attempt was made to remove a set of warnings triggered by > > gcc 8.x and W=1 by changing calls to strncpy() into strlcpy(). This

Re: [PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close

2019-01-25 Thread Mathieu Malaterre
On Thu, Jan 24, 2019 at 7:07 PM Mathieu Malaterre wrote: > > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > In this particular case put the fall through comment on a separate line so > as to match the

Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp

2019-01-25 Thread Mathieu Malaterre
> > net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall > > through [-Wimplicit-fallthrough=] > > > > Cc: Gustavo Padovan > > Signed-off-by: Mathieu Malaterre > > --- > > net/bluetooth/l2cap_core.c | 1 + > > 1 file changed, 1 inserti

Re: [PATCH v8 00/26] Ingenic TCU patchset v8

2019-01-24 Thread Mathieu Malaterre
Paul, On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil wrote: > > Hi, > > Here's the version 8 and hopefully final version of my patchset, which > adds support for the Timer/Counter Unit found in JZ47xx SoCs from > Ingenic. I can no longer boot my MIPS Creator CI20 with this series (merged

[PATCH v2] mac80211: Add attribute aligned(2) to struct 'action'

2019-01-24 Thread Mathieu Malaterre
following warning (W=1): net/mac80211/rx.c:234:2: warning: alignment 1 of 'struct ' is less than 2 [-Wpacked-not-aligned] Cc: Johannes Berg Suggested-by: Johannes Berg Signed-off-by: Mathieu Malaterre --- v2: It was suggested by Johannes that an arch actually need the pack attribute (alp

Re: [PATCH] mac80211: Remove attribute packed from struct 'action'

2019-01-24 Thread Mathieu Malaterre
On Thu, Jan 24, 2019 at 7:08 PM Johannes Berg wrote: > > On Thu, 2019-01-24 at 19:05 +0100, Mathieu Malaterre wrote: > > During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO > > follow-MAC mode") a new struct 'action' was declared with packed > &

[PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close

2019-01-24 Thread Mathieu Malaterre
/bluetooth/rfcomm/core.c:479:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: Peter Hurley Signed-off-by: Mathieu Malaterre --- net/bluetooth/rfcomm/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth

[PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp

2019-01-24 Thread Mathieu Malaterre
-off-by: Mathieu Malaterre --- net/bluetooth/l2cap_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 2a7fb517d460..a5b76e24940a 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4244,6 +4244,7 @@ static

[PATCH] regmap: Remove attribute packed from struct 'regcache_rbtree_node'

2019-01-24 Thread Mathieu Malaterre
node' is less than 4 [-Wpacked-not-aligned] Cc: Dimitris Papastamos Cc: David Woodhouse Signed-off-by: Mathieu Malaterre --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/reg

[PATCH] mac80211: Remove attribute packed from struct 'action'

2019-01-24 Thread Mathieu Malaterre
rning (W=1): net/mac80211/rx.c:234:2: warning: alignment 1 of 'struct ' is less than 2 [-Wpacked-not-aligned] Cc: Johannes Berg Signed-off-by: Mathieu Malaterre --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/

[PATCH] ext2: Annotate implicit fall through in __ext2_truncate_blocks

2019-01-24 Thread Mathieu Malaterre
: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/ext2/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index e4bb9386c045..e64029b1bd50 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1239,6 +1239,7

[PATCH] drivers: base: Use __printf markup to silence compiler

2019-01-23 Thread Mathieu Malaterre
Silence warnings (triggered at W=1) by adding relevant __printf attributes. drivers/base/cpu.c:432:2: warning: function '__cpu_device_create' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers/base/cpu.c | 1 + 1

[PATCH] ASoC: Use __printf markup to silence compiler

2019-01-23 Thread Mathieu Malaterre
Silence warnings (triggered at W=1) by adding relevant __printf attributes. sound/soc/soc-dapm.c:149:2: warning: function 'pop_dbg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- sound/soc/soc-dapm.c | 1 + 1 file

Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST

2019-01-23 Thread Mathieu Malaterre
On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil wrote: > > From: Maarten ter Huurne > > OST is the OS Timer, a 64-bit timer/counter with buffered reading. > > SoCs before the JZ4770 had (if any) a 32-bit OST; the JZ4770 and > JZ4780 have a 64-bit OST. > > This driver will register both a

Re: [PATCH] video/hdmi: Change strncpy() into memcpy() in hdmi_spd_infoframe_init

2019-01-18 Thread Mathieu Malaterre
On Fri, Jan 18, 2019 at 8:51 PM Joe Perches wrote: > > On Fri, 2019-01-18 at 20:32 +0100, Mathieu Malaterre wrote: > > Using strncpy() is less than perfect since the destination buffers do not > > need to be NUL terminated. Replace strncpy() with memcpy() to address a > >

[PATCH] writeback: tracing: Copy only up to 31 characters in strncpy() calls

2019-01-18 Thread Mathieu Malaterre
-by: Mathieu Malaterre --- include/trace/events/writeback.h | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index 32db72c7c055..7bc58980f84f 100644 --- a/include/trace/events

[PATCH] video/hdmi: Change strncpy() into memcpy() in hdmi_spd_infoframe_init

2019-01-18 Thread Mathieu Malaterre
: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation] drivers/video/hdmi.c:235:2: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation] Signed-off-by: Mathieu Malaterre --- drivers/video/hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2] drm: radeon: add a missing break in evergreen_cs_handle_reg

2019-01-17 Thread Mathieu Malaterre
drm/radeon/evergreen_cs.c:1301:11: warning: this statement may fall through [-Wimplicit-fallthrough=] Suggested-by: Alex Deucher Fixes: dd220a00e8bd ("drm/radeon/kms: add support for streamout v7") Signed-off-by: Mathieu Malaterre --- v2: Add missing break statement, instead of markin

[PATCH] mmc: Annotate implicit fall through in jz_mmc_irq_worker

2019-01-16 Thread Mathieu Malaterre
/jz4740_mmc.c:779:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/mmc/host/jz4740_mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index 33215d66afa2..a1df8bc0b964

[PATCH 1/2] mtd: Annotate implicit fall through in nand_command/nand_command_lp

2019-01-16 Thread Mathieu Malaterre
/nand_legacy.c:483:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/mtd/nand/raw/nand_legacy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/nand_legacy.c b/drivers/mtd/nand/raw

[PATCH 2/2] mtd: Annotate implicit fall through in nand_scan_tail

2019-01-16 Thread Mathieu Malaterre
/nand_base.c:5575:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/mtd/nand/raw/nand_base.c:5613:13: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/mtd/nand/raw/nand_base.c | 3 +++ 1 file changed, 3

[PATCH] davicom: Annotate implicit fall through in dm9000_set_io

2019-01-16 Thread Mathieu Malaterre
/dm9000.c:397:3: note: in expansion of macro 'dev_dbg' drivers/net/ethernet/davicom/dm9000.c:398:2: note: here Signed-off-by: Mathieu Malaterre --- drivers/net/ethernet/davicom/dm9000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet

[PATCH v2 2/2] bpf: Correctly annotate implicit fall through in bpf_base_func_proto

2019-01-16 Thread Mathieu Malaterre
warning: net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- v2: reword the patch subject, remove a typo net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b

[PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto

2019-01-16 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warnings (W=1). This commit remove the following warning: kernel/bpf/cgroup.c:719:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto

2019-01-16 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warnings (W=1). This commit remove the following warning: kernel/bpf/cgroup.c:719:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH] bpf: Make function btf_name_offset_valid static

2019-01-16 Thread Mathieu Malaterre
e function prototype was removed. Revert back to original implementation and make the function static. Remove warning triggered with W=1: kernel/bpf/btf.c:470:6: warning: no previous prototype for 'btf_name_offset_valid' [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- kernel/bpf/

Re: [PATCH] mount: Make function to_mnt_ns static

2019-01-16 Thread Mathieu Malaterre
ping ? On Fri, Dec 7, 2018 at 9:43 PM Mathieu Malaterre wrote: > > In commit 58be28256d98 ("make mntns ->get()/->put()/->install()/->inum() > work with _ns->ns"), a new function `to_mnt_ns` was introduced. > Since this function can be made static, make

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Mathieu Malaterre
On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > caused kernel panic on PowerPC if an external module is used with > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed > for the external module build. > >

[tip:irq/core] genirq: Correctly annotate implicit fall through

2019-01-15 Thread tip-bot for Mathieu Malaterre
Commit-ID: 01cdfa912f1004c463586f52f1dfcbec1274b1f2 Gitweb: https://git.kernel.org/tip/01cdfa912f1004c463586f52f1dfcbec1274b1f2 Author: Mathieu Malaterre AuthorDate: Mon, 14 Jan 2019 21:36:33 +0100 Committer: Thomas Gleixner CommitDate: Tue, 15 Jan 2019 10:40:53 +0100 genirq

[tip:irq/core] genirq: Annotate implicit fall through

2019-01-15 Thread tip-bot for Mathieu Malaterre
Commit-ID: 44133f7eaebec227d1381868d642e3c64023520f Gitweb: https://git.kernel.org/tip/44133f7eaebec227d1381868d642e3c64023520f Author: Mathieu Malaterre AuthorDate: Mon, 14 Jan 2019 21:31:54 +0100 Committer: Thomas Gleixner CommitDate: Tue, 15 Jan 2019 10:40:34 +0100 genirq: Annotate

[PATCH] nvram: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: drivers/char/generic_nvram.c:83:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu

[PATCH] firewire: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: drivers/firewire/core-topology.c:69:23: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu

[PATCH 1/2] firewire: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
following warning: drivers/firewire/core-iso.c:308:7: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/firewire/core-iso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/core-iso.c b/drivers/fir

[PATCH 2/2] firewire: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
'set_broadcast_channel': ../drivers/firewire/core-device.c:969:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (data & cpu_to_be32(1 << 31)) { Signed-off-by: Mathieu Malaterre --- drivers/firewire/core-device.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] mmc: core: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
tly to fit the max line length of 80 characters. This commit remove the following warning: drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 1/2] PCI: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
: drivers/pci/pci.c:861:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/pci/pci.c:2261:7: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/pci/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 2/2] PCI: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b0a413f3f7ca..9fabcef345ed 100644 --- a/drivers/pci

[PATCH] vt: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
:2237:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/tty/vt/vt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 41ec8e5010f3..e4f8caed26af 100644 --- a/drivers/tty/vt/vt.c +++ b

[PATCH] video: offb: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
/fbdev/offb.c:142:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/video/fbdev/offb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index 31f769d67195..e0f0c5351306

[PATCH 2/2] ext4: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
:6: warning: this statement may fall through [-Wimplicit-fallthrough=] fs/ext4/indirect.c:1432:6: warning: this statement may fall through [-Wimplicit-fallthrough=] fs/ext4/indirect.c:1440:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH 1/2] ext4: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/ext4/hash.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c index e22dcfab308b..46b24da33a28 100644 --- a/fs/ext4/hash.c +++ b/fs/ext4/hash.c @@ -231,6

[PATCH 3/3] fs/fcntl: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/fcntl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index 083185174c6d..3d40771e8e7c 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -769,7 +769,7 @@ static

[PATCH 2/3] fs: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/locks.c b/fs/locks.c index ff6af2c32601..d958c3863b4b 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -1471,7 +1471,7 @@ static void

[PATCH 1/3] fs: annotate implicit fall throughs

2019-01-14 Thread Mathieu Malaterre
: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs/libfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/libfs.c b/fs/libfs.c index 0fb590d79f30..9efb647917e0 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -146,9 +146,11 @@ loff_t

[PATCH] seq_file: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: fs/seq_file.c:319:10: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs

[PATCH] fs/signalfd: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: fs/signalfd.c:178:7: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- fs

[PATCH] irq: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- kernel/irq/handle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index 38554bc35375..6df5ddfdb0f8 100644 --- a/kernel/irq/handle.c +++ b/kernel

[PATCH] perf/core: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: kernel/events/core.c:8945:11: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH] ipc: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: ipc/sem.c:1683:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- ipc/sem.c

[PATCH] signal: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre

[PATCH] kernel/sys: annotate implicit fall through

2019-01-14 Thread Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit remove the following warning: kernel/sys.c:1748:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- kernel

  1   2   3   4   5   6   7   8   >