Re: [PATCH v7 0/3] vduse: add support for networking devices

Hello Michael, On 2/1/24 09:40, Michael S. Tsirkin wrote: On Thu, Feb 01, 2024 at 09:34:11AM +0100, Maxime Coquelin wrote: Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime I think it's good enough at this point. Will put

Re: [PATCH] vduse: implement DMA sync callbacks

Hello Christoph, On 2/20/24 10:01, Christoph Hellwig wrote: On Mon, Feb 19, 2024 at 06:06:06PM +0100, Maxime Coquelin wrote: Since commit 295525e29a5b ("virtio_net: merge dma operations when filling mergeable buffers"), VDUSE device require support for DMA's .sync_single_for_cpu()

[PATCH] vduse: implement DMA sync callbacks

ments both .sync_single_for_cpu() and .sync_single_for_device() callbacks, and also skip bounce buffer copies during DMA map and unmap operations if the DMA_ATTR_SKIP_CPU_SYNC attribute is set to avoid extra copies of the same buffer. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/iova_dom

Re: [PATCH v7 0/3] vduse: add support for networking devices

On 2/1/24 09:40, Michael S. Tsirkin wrote: On Thu, Feb 01, 2024 at 09:34:11AM +0100, Maxime Coquelin wrote: Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime I think it's good enough at this point. Will put it in linux

Re: [PATCH v7 0/3] vduse: add support for networking devices

Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime On 1/9/24 12:10, Maxime Coquelin wrote: This small series enables virtio-net device type in VDUSE. With it, basic operation have been tested, both with virtio-vdpa and vhost

[PATCH v7 3/3] vduse: enable Virtio-net device type

Reviewed-by: Eugenio Pérez Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 00f3f562ab5d..8924bbc55635 100644 --- a/drivers/vdpa

[PATCH v7 2/3] vduse: Temporarily fail if control queue feature requested

. Until it is completed, let's fail features check if control-queue feature is requested. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index

[PATCH v7 1/3] vduse: validate block features only with block devices

-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 0ddd4b8abecb..a5af6d4077b8 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b

[PATCH v7 0/3] vduse: add support for networking devices

for Net device type (Jason). - Rebased on latest master. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (3): vduse: validate block features

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

On 1/5/24 10:59, Eugenio Perez Martin wrote: On Fri, Jan 5, 2024 at 9:12 AM Maxime Coquelin wrote: On 1/5/24 03:45, Jason Wang wrote: On Thu, Jan 4, 2024 at 11:38 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

On 1/5/24 03:45, Jason Wang wrote: On Thu, Jan 4, 2024 at 11:38 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel thread

[PATCH v6 3/3] vduse: enable Virtio-net device type

This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. It also fails with -EPERM if the CAP_NET_ADMIN is missing. Signed-off-by: Maxime

[PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

. Until it is completed, let's fail features check if any control-queue related feature is requested. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa

[PATCH v6 1/3] vduse: validate block features only with block devices

This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v6 0/3] vduse: add support for networking devices

(Jason). - Rebased on latest master. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (3): vduse: validate block features only with block

Re: [PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

On 12/18/23 18:33, Stephen Smalley wrote: On Mon, Dec 18, 2023 at 12:21 PM Stephen Smalley wrote: On Tue, Dec 12, 2023 at 8:17 AM Maxime Coquelin wrote: This patch introduces a LSM hook for devices creation, destruction (ioctl()) and opening (open()) operations, checking the application

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

On 12/18/23 03:50, Jason Wang wrote: On Wed, Dec 13, 2023 at 7:23 PM Maxime Coquelin wrote: Hi Jason, On 12/13/23 05:52, Jason Wang wrote: On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

Hi Jason, On 12/13/23 05:52, Jason Wang wrote: On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel

[PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

This patch introduces a LSM hook for devices creation, destruction (ioctl()) and opening (open()) operations, checking the application is allowed to perform these operations for the Virtio device type. Signed-off-by: Maxime Coquelin --- MAINTAINERS | 1 + drivers/vdpa

[PATCH v5 2/4] vduse: Temporarily disable control queue features

. Until it is completed, let's disable control virtqueue and features that depend on it. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 37 ++ 1 file changed, 37 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa

[PATCH v5 3/4] vduse: enable Virtio-net device type

This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v5 1/4] vduse: validate block features only with block devices

This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v5 0/4] vduse: add support for networking devices

block device type, - net: Virtio networking device type. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (4): vduse: validate block features

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

On 12/8/23 13:26, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 01:23:00PM +0100, Maxime Coquelin wrote: On 12/8/23 12:05, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 12:01:15PM +0100, Maxime Coquelin wrote: Hello Paul, On 11/8/23 03:31, Paul Moore wrote: On Oct 20, 2023

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

On 12/8/23 12:05, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 12:01:15PM +0100, Maxime Coquelin wrote: Hello Paul, On 11/8/23 03:31, Paul Moore wrote: On Oct 20, 2023 "Michael S. Tsirkin" wrote: This patch introduces LSM hooks for devices creation, destruction a

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 12 +++ include/linux/lsm_hook_defs.h | 4 +++ include/linux/security.h| 15 security/security.c | 42 ++ security/selinux/hooks.c

Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq

398.943845] R13: 7ffd0948e6a0 R14: R15: [ 1398.951809] Modules linked in: vxlan ip6_udp_tunnel udp_tunnel ip_vs_sh ip_vs_wrr ip_vs_rr ip_vs xt_comment xt_mark nf_tables xt_nat vetht [ 1398.951847] ghash_clmulni_intel iTCO_vendor_support mlx5_core dcdbas rapl intel_cstate intel_uncore ipmi_ssif pcspkr mxm_wmi mlxfw virtii Tested-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] watchdog: Respect watchdog cpumask on CPU hotplug

/b99c5a25-a5fe-18dd-2f1d-bdd6834f0...@redhat.com/ That looks so. I had a trial with your patch, and I can confirm it fixes my issue: Tested-by: Maxime Coquelin Thanks, Maxime Thanks, tglx

[Regression]: NMI watchdog regression from v4.19 onwards

Hi Peter, Oleg, NMI watchdog fires systematically on my machine with recent Kernels, whereas the NMI watch is supposed to be disabled: # cat /proc/sys/kernel/watchdog 0 # cat /proc/sys/kernel/nmi_watchdog 0 # [ 53.765648] NMI watchdog: Watchdog detected hard LOCKUP on cpu 7 [ 53.765648]

Re: [PATCH] MAINTAINERS: update entries for ARM/STM32

index 3bdc260..802b984 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1999,8 +1999,10 @@ M: Maxime Coquelin <mcoquelin.st...@gmail.com> > M: Alexandre Torgue <alexandre.tor...@st.com> > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) >

Re: [PATCH] MAINTAINERS: update entries for ARM/STM32

RS > @@ -1999,8 +1999,10 @@ M: Maxime Coquelin > M: Alexandre Torgue > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > S: Maintained > -T: git git://git.kernel.org/pub/scm/linux/kernel/git/mcoquelin/stm32.git > +T: git git

Re: [PATCH v2] irqchip: stm32: Fix copyright

2017-11-30 9:45 GMT+01:00 Benjamin Gaignard <benjamin.gaign...@linaro.org>: > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@st.com> > Acked-by: Alexandre TORGUE <alexandre.tor...

Re: [PATCH v2] irqchip: stm32: Fix copyright

2017-11-30 9:45 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > Acked-by: Alexandre TORGUE > CC: Maxime Coquelin > --- > drivers/irqchip/irq-stm32-exti.c | 3 ++- > 1 file

Re: [PATCH v2] pinctrl: stm32: Fix copyright

2017-11-30 9:46 GMT+01:00 Benjamin Gaignard <benjamin.gaign...@linaro.org>: > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@st.com> > Acked-by: Alexandre TORGUE <alexandre.tor...

Re: [PATCH v2] pinctrl: stm32: Fix copyright

2017-11-30 9:46 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > Acked-by: Alexandre TORGUE > CC: Maxime Coquelin > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-

Re: [PATCH v4] arch: arm: mach-stm32: Fix copyright

2017-11-30 9:49 GMT+01:00 Benjamin Gaignard <benjamin.gaign...@linaro.org>: > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@st.com> > CC: Maxime Coquelin <mcoquelin.st...@gmail.com> &

Re: [PATCH v4] arch: arm: mach-stm32: Fix copyright

2017-11-30 9:49 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > CC: Maxime Coquelin > --- > arch/arm/mach-stm32/board-dt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH v6 2/4] drivers: irqchip: Add STM32 external interrupts support

ce, >> > > and triggers either on rising, falling or both edges. Each line can also >> > > be masked independently. >> > > >> > > Signed-off-by: Maxime Coquelin <mcoquelin.st...@gmail.com> >> > > Signed-off-by: Alexandre TORGUE <alexa

Re: [PATCH v6 2/4] drivers: irqchip: Add STM32 external interrupts support

ers either on rising, falling or both edges. Each line can also >> > > be masked independently. >> > > >> > > Signed-off-by: Maxime Coquelin >> > > Signed-off-by: Alexandre TORGUE >> > >> > That all looks very reasonable now. The o

Re: [PATCH v2 07/10] reset: stm32: add driver Kconfig option

2016-08-30 10:24 GMT+02:00 Philipp Zabel <p.za...@pengutronix.de>: > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Maxime Coquelin <mcoquelin.st...@gmail.com> > Cc: Gabriel Fernandez <gabriel.fernan...@st.com&g

Re: [PATCH v2 07/10] reset: stm32: add driver Kconfig option

2016-08-30 10:24 GMT+02:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Maxime Coquelin > Cc: Gabriel Fernandez > Reviewed-by: Masahiro Yamada > Signed-off-by: Philipp Zabel > --- >

[PATCH] MAINTAINERS: update STM32 maintainers list

I will have less time to work on STM32 platform, so I propose Alexandre as co-maintainer. Alex is working in the STMicroelectronics division in charge of STM32 family, so he will have access to all technical information and hardware. Signed-off-by: Maxime Coquelin <mcoquelin.st...@gmail.com&

[PATCH] MAINTAINERS: update STM32 maintainers list

I will have less time to work on STM32 platform, so I propose Alexandre as co-maintainer. Alex is working in the STMicroelectronics division in charge of STM32 family, so he will have access to all technical information and hardware. Signed-off-by: Maxime Coquelin Cc: Alexandre Torgue

[PATCH] MAINTAINERS: update STi maintainer list

Remove myself as STi maintainer as I will no longer have access to STi platforms, and remove Srini too, who now works on other platforms. Patrice will manage the pull requests. Signed-off-by: Maxime Coquelin <maxime.coque...@st.com> Cc: Patrice Chotard <patrice.chot...@st.com>

[PATCH] MAINTAINERS: update STi maintainer list

Remove myself as STi maintainer as I will no longer have access to STi platforms, and remove Srini too, who now works on other platforms. Patrice will manage the pull requests. Signed-off-by: Maxime Coquelin Cc: Patrice Chotard Cc: Srinivas Kandagatla Cc: Arnd Bergmann --- MAINTAINERS | 2

Re: [PATCH V2 12/63] clocksource/drivers/armv7m_systick: Convert init function to return error

case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > --- > drivers/clocksource/armv7m_systick.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Acked-by: Maxime Coquelin <mcoquelin.st...@gmail.com> Thanks! Maxime

Re: [PATCH V2 12/63] clocksource/drivers/armv7m_systick: Convert init function to return error

eturn back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/armv7m_systick.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 08/63] clocksource/drivers/st_lpc: Convert init function to return error

-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> --- drivers/clocksource/clksrc_st_lpc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) Acked-by: Maxime Coquelin <maxime.coque...@st.com> Thanks! Maxime

Re: [PATCH V2 08/63] clocksource/drivers/st_lpc: Convert init function to return error

-off-by: Daniel Lezcano --- drivers/clocksource/clksrc_st_lpc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert init function to return error

. Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> --- drivers/clocksource/arm_global_timer.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) Acked-by: Maxime Coquelin <maxime.coque...@st.com> Thanks! Maxime

Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert init function to return error

. Signed-off-by: Daniel Lezcano --- drivers/clocksource/arm_global_timer.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init function to return error

> by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > --- > drivers/clocksource/timer-stm32.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Acked-by: Maxime Coquelin <mcoquelin.st...@gmail.com> Thanks! Maxime

Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init function to return error

hange just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-stm32.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

[PATCH v4.7-rc] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

y Peter Griffin <peter.grif...@linaro.org> Signed-off-by: Maxime Coquelin <maxime.coque...@st.com> --- arch/arm/boot/dts/stih407-family.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index ad8ba1

[PATCH v4.7-rc] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

ime of this writing and b) it is not affected by the current default behaviour which is causing issues. Fixes: fe135c6 (ARM: dts: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory) Signed-off-by: Lee Jones Reviewed-by Peter Griffin Signed-off-by: Maxime Coquelin --- arch/

Re: [PATCH] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

/boot/dts/stih407-family.dtsi | 3 +++ 1 file changed, 3 insertions(+) That sounds reasonable: Acked-by: Maxime Coquelin <maxime.coque...@st.com> Arnd, Olof, can you pick this patch directly in -rc fixes, as it prevents STi boards to boot correctly? Thanks in advance, Maxime

Re: [PATCH] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

| 3 +++ 1 file changed, 3 insertions(+) That sounds reasonable: Acked-by: Maxime Coquelin Arnd, Olof, can you pick this patch directly in -rc fixes, as it prevents STi boards to boot correctly? Thanks in advance, Maxime

Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC

2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga : > Signed-off-by: Patrice Chotard > Signed-off-by: M'boumba Cedric Madianga > --- > arch/arm/boot/dts/stm32f429.dtsi | 24 > 1 file

Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC

2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga : > Signed-off-by: Patrice Chotard > Signed-off-by: M'boumba Cedric Madianga > --- > arch/arm/boot/dts/stm32f429.dtsi | 24 > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f429.dtsi >

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

Hi Cedric, 2016-06-02 17:35 GMT+02:00 M'boumba Cedric Madianga : > Hi, > >>> + >>> +/** >>> + * stm32f4_i2c_xfer() - Transfer combined I2C message >>> + * @i2c_adap: Adapter pointer to the controller >>> + * @msgs: Pointer to data to be written. >>> + * @num: Number of

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

Hi Cedric, 2016-06-02 17:35 GMT+02:00 M'boumba Cedric Madianga : > Hi, > >>> + >>> +/** >>> + * stm32f4_i2c_xfer() - Transfer combined I2C message >>> + * @i2c_adap: Adapter pointer to the controller >>> + * @msgs: Pointer to data to be written. >>> + * @num: Number of messages to be executed >>>

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

2016-06-01 16:01 GMT+02:00 M'boumba Cedric Madianga : > Hi Maxime, > +static void stm32f4_i2c_set_speed_mode(struct stm32f4_i2c_dev *i2c_dev) +{ + struct stm32f4_i2c_timings *t = _timings[i2c_dev->speed]; + u32 ccr, val, clk_rate; +

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

2016-06-01 16:01 GMT+02:00 M'boumba Cedric Madianga : > Hi Maxime, > +static void stm32f4_i2c_set_speed_mode(struct stm32f4_i2c_dev *i2c_dev) +{ + struct stm32f4_i2c_timings *t = _timings[i2c_dev->speed]; + u32 ccr, val, clk_rate; + + ccr =

[PATCH] hwrng: stm32: fix maybe uninitialized variable warning

her...@codethink.co.uk> Suggested-by: Arnd Bergmann <a...@arndb.de> Cc: Daniel Thompson <daniel.thomp...@linaro.org> Signed-off-by: Maxime Coquelin <mcoquelin.st...@gmail.com> --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) d

[PATCH] hwrng: stm32: fix maybe uninitialized variable warning

Bergmann Cc: Daniel Thompson Signed-off-by: Maxime Coquelin --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 92a810648bd0..63d84e6f1891 100644

Re: [PATCH v2] pinctrl: stm32: factorize stm32_pconf_input/output_get()

stm32.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) Acked-by: Maxime Coquelin <maxime.coque...@st.com> Thanks! Maxime

Re: [PATCH v2] pinctrl: stm32: factorize stm32_pconf_input/output_get()

deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 12:09 GMT+02:00 Daniel Thompson <daniel.thomp...@linaro.org>: > On 24/05/16 09:50, Maxime Coquelin wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> -

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 12:09 GMT+02:00 Daniel Thompson : > On 24/05/16 09:50, Maxime Coquelin wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_random/

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 10:58 GMT+02:00 Arnd Bergmann <a...@arndb.de>: > On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> -

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 10:58 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 10:32 GMT+02:00 Arnd Bergmann <a...@arndb.de>: > On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: >> 2016-05-23 22:35 GMT+02:00 Arnd Bergmann <a...@arndb.de>: >> > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> &g

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 10:32 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: >> 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : >> > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> >> diff --git a/drivers/char/hw_random/stm

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> We have been getting build warning about: >> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': >> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr'

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> We have been getting build warning about: >> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': >> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used >>

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-18 11:31 GMT+02:00 Arnd Bergmann <a...@arndb.de>: > On Wednesday 18 May 2016 09:48:53 Maxime Coquelin wrote: >> 2016-05-17 18:25 GMT+02:00 David Miller <da...@davemloft.net>: >> > From: Maxime Coquelin <mcoquelin.st...@gmail.com> >> > Date:

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-18 11:31 GMT+02:00 Arnd Bergmann : > On Wednesday 18 May 2016 09:48:53 Maxime Coquelin wrote: >> 2016-05-17 18:25 GMT+02:00 David Miller : >> > From: Maxime Coquelin >> > Date: Tue, 17 May 2016 11:20:16 +0200 >> > >> >> Hi David, >

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-17 18:25 GMT+02:00 David Miller <da...@davemloft.net>: > From: Maxime Coquelin <mcoquelin.st...@gmail.com> > Date: Tue, 17 May 2016 11:20:16 +0200 > >> Hi David, >> >> 2016-05-09 21:06 GMT+02:00 David Miller <da...@davemloft.net>: >>&

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-17 18:25 GMT+02:00 David Miller : > From: Maxime Coquelin > Date: Tue, 17 May 2016 11:20:16 +0200 > >> Hi David, >> >> 2016-05-09 21:06 GMT+02:00 David Miller : >>> From: Alexandre TORGUE >>> Date: Mon, 9 May 2016 12:31:33 +0200 >>&

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

Hi Cedric, 2016-05-11 17:36 GMT+02:00 M'boumba Cedric Madianga : > This patch adds support for the STM32F4 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + >

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

Hi Cedric, 2016-05-11 17:36 GMT+02:00 M'boumba Cedric Madianga : > This patch adds support for the STM32F4 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-stm32f4.c

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

Hi David, 2016-05-09 21:06 GMT+02:00 David Miller : > From: Alexandre TORGUE > Date: Mon, 9 May 2016 12:31:33 +0200 > >> STM32F429 Chip embeds a Synopsys 3.50a MAC IP. >> This series: >> -enhance current stmmac driver to control it (code already

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

Hi David, 2016-05-09 21:06 GMT+02:00 David Miller : > From: Alexandre TORGUE > Date: Mon, 9 May 2016 12:31:33 +0200 > >> STM32F429 Chip embeds a Synopsys 3.50a MAC IP. >> This series: >> -enhance current stmmac driver to control it (code already >> available) and adds basic glue for STM32F429

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-30 13:32 GMT+02:00 Linus Walleij <linus.wall...@linaro.org>: > On Fri, Apr 29, 2016 at 1:19 PM, Maxime Coquelin > <mcoquelin.st...@gmail.com> wrote: >> It looks like this: http://pastebin.com/raw/cs2WiNKZ >> You can directly check section 12.2.5 of the stm32

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-30 13:32 GMT+02:00 Linus Walleij : > On Fri, Apr 29, 2016 at 1:19 PM, Maxime Coquelin > wrote: >> It looks like this: http://pastebin.com/raw/cs2WiNKZ >> You can directly check section 12.2.5 of the stm32f429 reference manual: >> http://www2.st.com/resource/en/ref

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

On 04/28/2016 04:57 PM, Wolfram Sang wrote: The trick is to switch to SPI mode, 9 bits words and write a 0, so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. :) I didn't faced the problem myself, but it looks good with an

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

On 04/28/2016 04:57 PM, Wolfram Sang wrote: The trick is to switch to SPI mode, 9 bits words and write a 0, so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. :) I didn't faced the problem myself, but it looks good with an

Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue

2016-04-28 22:59 GMT+02:00 Rob Herring : > On Mon, Apr 25, 2016 at 01:53:58PM +0200, Alexandre TORGUE wrote: >> Signed-off-by: Alexandre TORGUE > > Acked-by: Rob Herring Thanks Rob! Arnd, I only have patches 4, 5 and 6 of this

Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue

2016-04-28 22:59 GMT+02:00 Rob Herring : > On Mon, Apr 25, 2016 at 01:53:58PM +0200, Alexandre TORGUE wrote: >> Signed-off-by: Alexandre TORGUE > > Acked-by: Rob Herring Thanks Rob! Arnd, I only have patches 4, 5 and 6 of this series for stm32 (2 DT, one defconfig) for v4.7. Should I send a

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-29 10:53 GMT+02:00 Linus Walleij <linus.wall...@linaro.org>: > On Tue, Apr 19, 2016 at 11:04 AM, Maxime Coquelin > <mcoquelin.st...@gmail.com> wrote: >> 2016-04-08 11:43 GMT+02:00 Linus Walleij <linus.wall...@linaro.org>: >>> On Thu, M

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-29 10:53 GMT+02:00 Linus Walleij : > On Tue, Apr 19, 2016 at 11:04 AM, Maxime Coquelin > wrote: >> 2016-04-08 11:43 GMT+02:00 Linus Walleij : >>> On Thu, Mar 31, 2016 at 5:09 PM, Maxime Coquelin >>> wrote: >>> >>>> +static int stm32_

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

Hi Wolfram, On 04/24/2016 11:10 PM, Wolfram Sang wrote: +/* + * i2c bus recovery routines + * get_scl and set_scl must be defined to avoid the recover_bus field of + * i2c_bus_recovery_info to be overriden with NULL during the + * i2c_add_adapter call + */ Oh, that shouldn't be like this. Can

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

Hi Wolfram, On 04/24/2016 11:10 PM, Wolfram Sang wrote: +/* + * i2c bus recovery routines + * get_scl and set_scl must be defined to avoid the recover_bus field of + * i2c_bus_recovery_info to be overriden with NULL during the + * i2c_add_adapter call + */ Oh, that shouldn't be like this. Can

Re: [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board

/dts/stm32429i-eval.dts Acked-by: Maxime Coquelin <mcoquelin.st...@gmail.com> Thanks! Maxime

Re: [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board

2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > Update new pinctrl phandle name and use new node name. > > Signed-off-by: Alexandre TORGUE > > diff --git a/arch/arm/boot/dts/stm32429i-eval.dts > b/arch/arm/boot/dts/stm32429i-eval.dts Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > This patch aligns clocks names and node reference according to new > stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle > (indeed there is no need to add 0 as Ethernet instance as there is only >

Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > This patch aligns clocks names and node reference according to new > stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle > (indeed there is no need to add 0 as Ethernet instance as there is only > one IP in SOC). > >

Re: [PATCH v6 4/6] ARM: STM32: Enable Ethernet in stm32_defconfig

Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE <alexandre.tor...@gmail.com>: > Enable basic Ethernet support (IPV4) for stm32 defconfig. > > Signed-off-by: Alexandre TORGUE <alexandre.tor...@gmail.com> Acked-by: Maxime Coquelin <mcoquelin.st...@gmail.com> Thanks! Maxime

Re: [PATCH v6 4/6] ARM: STM32: Enable Ethernet in stm32_defconfig

Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > Enable basic Ethernet support (IPV4) for stm32 defconfig. > > Signed-off-by: Alexandre TORGUE Acked-by: Maxime Coquelin Thanks! Maxime

Re: [[PATCH v2] 1/8] ARM: dts: STi: STiH407: Provide generic (safe) DVFS configuration

over-ride these generic values. Signed-off-by: Lee Jones <lee.jo...@linaro.org> Signed-off-by: Maxime Coquelin <maxime.coque...@st.com> --- arch/arm/boot/dts/stih407-family.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arc

  1   2   3   4   5   6   7   8   9   10   >