On Thu, Nov 19, 2020 at 9:53 PM Jakub Kicinski wrote:
>
> On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote:
> > > Fix to return a negative error code from the error handling
> > > case instead of 0, as done elsewhere in this function.
> > >
> > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethe
ted-by: Hulk Robot
> Signed-off-by: Zhang Changzhong
Reviewed-by: Michael Chan
Thanks.
smime.p7s
Description: S/MIME Cryptographic Signature
On Mon, Sep 14, 2020 at 2:31 PM Jakub Kicinski wrote:
>
> On Mon, 14 Sep 2020 13:28:29 +0200 Jiri Pirko wrote:
> > >> Instead, why don't you block in reload_up() until the reset is complete?
> > >
> > >Though user initiate "devlink dev reload" event on a single interface,
> > >all driver entities
On Fri, Jul 24, 2020 at 5:19 PM David Christensen
wrote:
> In the working case, tg3_init_hw() returns successfully, resulting in
> every instance of napi_disable() being followed by an instance of
> napi_enable().
>
> In the failing case, tg3_hw_init() returns an error. (This is not
> surprising
om/KSPP/linux/issues/79
> [2] https://github.com/KSPP/linux/issues/86
>
> Tested-by: kernel test robot
> Link:
> https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/tg3-20200718.md
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Michael Chan
ock.
>
> Add check for pcierr_recovery which skips code already executed for the
> "Frozen" state.
>
> Signed-off-by: David Christensen
Reviewed-by: Michael Chan
Thanks.
On Mon, Jun 15, 2020 at 3:21 PM David Christensen
wrote:
>
> On 6/15/20 1:45 PM, Michael Chan wrote:
> > On Mon, Jun 15, 2020 at 12:01 PM David Christensen
> > wrote:
> >>
> >> The driver function tg3_io_error_detected() calls napi_disable twice,
> >>
On Mon, Jun 15, 2020 at 12:01 PM David Christensen
wrote:
>
> The driver function tg3_io_error_detected() calls napi_disable twice,
> without an intervening napi_enable, when the number of EEH errors exceeds
> eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.
>
> The funct
covery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: Michael Chan
> Cc: Luis Chamberlain
> Acked-by: Rafael Aquini
> Signed-off-by: Vasundhara Volam
> Signed
On Fri, May 8, 2020 at 3:40 PM Colin King wrote:
>
> From: Colin Ian King
>
> The variable ret is being assigned with a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
Reviewed-by: Michael Chan
On Fri, May 8, 2020 at 7:31 PM Joe Perches wrote:
>
> On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote:
> > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote:
> > > > My preference would be for
> > > >
> > > > {
> > > > int i;
> > > > u32 off = 0;
> > > >
> > > > for (i = 0; i <
On Fri, May 8, 2020 at 3:53 PM Colin King wrote:
>
> From: Colin Ian King
>
> Currently the value for 'off' is computed using a multiplication and
> a couple of statements later off is being incremented by len and
> this value is never read. Clean up the code by removing the
> multiplication and
On Wed, Jul 31, 2019 at 7:22 PM Chuhong Yuan wrote:
>
> Michael Chan 于2019年8月1日周四 上午1:58写道：
> >
> > On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote:
> >
> > > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32
> &g
On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote:
> static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 val)
> @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct
> cnic_ulp_ops *ulp_ops)
> }
> read_unlock(&cnic_dev_lock);
>
> - atomic_
On Wed, Jul 31, 2019 at 9:06 AM Willem de Bruijn
wrote:
>
> On Wed, Jul 31, 2019 at 8:22 AM Chuhong Yuan wrote:
> >
> > refcount_t is better for reference counters since its
> > implementation can prevent overflows.
> > So convert atomic_t ref counters to refcount_t.
> >
> > Signed-off-by: Chuhon
The issue is this message means nothing to
> anyone except Broadcom. Remove the message to not confuse users as this
> message is really not very informative.
>
> Signed-off-by: Jonathan Toppins
> ---
>
> Notes:
> v2:
> include changes recommended by Michael Chan
>
Acked-by: Michael Chan
On Tue, Sep 11, 2018 at 1:14 PM, Ben Hutchings
wrote:
> On Thu, 2018-08-23 at 09:53 +0200, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch. If anyone has any objections, please let me know.
>>
>> --
>>
>> From: Vikas Gupta
>>
>> [ Upstream commit c58387ab1614f6d7fb9e244f214b
On Tue, Jul 24, 2018 at 9:01 AM, Vasundhara Volam
wrote:
> On Tue, Jul 24, 2018 at 1:01 PM, Michael Chan
> wrote:
>>
>> On Mon, Jul 23, 2018 at 10:24 PM, YueHaibing wrote:
>> > Based on the comments,req->l2addr must match the VF MAC address
>> > if fir
On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote:
> On 2018年05月03日 01:32, Michael Chan wrote:
>>
>> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote:
>>>
>>> On 2018年05月02日 13:12, Michael Chan wrote:
>>>>
>>>> On Tue, May 1, 2018 at
On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote:
> On 2018年05月02日 13:12, Michael Chan wrote:
>>
>> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote:
>>
>>> diff --git a/drivers/net/ethernet/broadcom/tg3.h
>>> b/drivers/net/ethernet/broadcom/tg3.h
>
On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.h
> b/drivers/net/ethernet/broadcom/tg3.h
> index 3b5e98e..c61d83c 100644
> --- a/drivers/net/ethernet/broadcom/tg3.h
> +++ b/drivers/net/ethernet/broadcom/tg3.h
> @@ -3102,6 +3102,7 @@ enum TG3_F
On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.h
> b/drivers/net/ethernet/broadcom/tg3.h
> index 3b5e98e..6727d93 100644
> --- a/drivers/net/ethernet/broadcom/tg3.h
> +++ b/drivers/net/ethernet/broadcom/tg3.h
> @@ -3352,6 +3352,7 @@ struct tg
line in the patch description is not needed anymore. Other than that,
Acked-by: Michael Chan
Thanks.
>
> Signed-off-by: Sinan Kaya
On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote:
> Code includes wmb() followed by writel(). writel() already has a barrier on
> some architectures like arm64.
>
> This ends up CPU observing two barriers back to back before executing the
> register write.
>
> Create a new wrapper function with r
if the udelay should be 20
> instead of 10, due to any timing changes introduced by the offending
> patch.
Thanks. 10 us is correct.
As a future improvement, we might want to see if we can release the
spinlock and go back to usleep_range(). The wait time is potentially
up to 20 msec which is quite long.
Acked-by: Michael Chan
upt
> moderation")
>
> Signed-off-by: Colin Ian King
Thanks.
Acked-by: Michael Chan
On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote:
> From: Colin Ian King
>
> In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the
> exit return path is via label next_rx_no_prod and cpr->rx_bytes
> is being updated by an uninitialized value from len. Fix this by
> initializing len to z
_workq_function+0x3c/0x90 [edac_core]
>[] process_one_work+0x19b/0x480
>[] worker_thread+0x6a/0x520
>[] kthread+0xe4/0x100
>[] ret_from_fork+0x22/0x40
>
> This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting
> in rx_pkts > 0. Fix this by on
On Thu, Dec 7, 2017 at 1:39 AM, Thomas Bogendoerfer
wrote:
> On Thu, 7 Dec 2017 01:24:43 -0800
> Michael Chan wrote:
>
>> On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer
>> wrote:
>> > well, it will print the forced rate, if there is one configured and -1
&g
On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer
wrote:
> On Wed, 6 Dec 2017 11:27:31 -0800
> Michael Chan wrote:
>
>> On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer
>> wrote:
>> > bnxt driver spams logfiles with
>> >
>> > [ 541.003
On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer
wrote:
> bnxt driver spams logfiles with
>
> [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported
>
> if a direct attached cable (DAC) is plugged into the bnxt card and is
> unplugged on the other side. This patch removes t
On Thu, Nov 30, 2017 at 11:36 AM, Scott Branden
wrote:
> Add ETH_RESET_AP support handling to reset the internal
> Application Processor(s) of the SmartNIC card.
>
> Signed-off-by: Scott Branden
Acked-by: Michael Chan
On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote:
> From: Christophe JAILLET
> Date: Tue, 21 Nov 2017 20:46:49 +0100
>
>> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a
>> few lines above when reading the A0 portion of the EEPROM.
>> The same should be done when readi
On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote:
> There is no reason to wrap the data structures inside the ifdef.
What's so bad about wrapping unused data structures inside #ifdef?
These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is
defined.
than Toppins
Acked-by: Michael Chan
cleanup. Use dev_consume_skb_any() for
> these 3 locations to be SKB drop monitor friendly.
>
> Signed-off-by: Florian Fainelli
Acked-by: Michael Chan
> ---
> Changes in v2:
>
> - also included tg3_tso_bug() as indicated by Michael
>
ned-off-by: Florian Fainelli
Acked-by: Michael Chan
Thanks.
On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote:
> The sriov_lock is used to serialize the sriov code with the vfr code.
> However, when SRIOV is disabled, the lock is not there at all, leading
> to a build error:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function
> 'bnxt_dl_eswi
Gaignard
> CC: Michael Chan
> CC: net...@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
Acked-by: Michael Chan
Thanks.
On Mon, May 15, 2017 at 3:28 PM, Gustavo A. R. Silva
wrote:
> Local variable _sh_ is assigned to a constant value and it is never updated
> again. Remove this variable and the dead code it guards.
>
> Addresses-Coverity-ID: 1350916
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/net/etherne
rg/show_bug.cgi?id=188661
>
> Signed-off-by: Pan Bian
Acked-by: Michael Chan
y created io-page table at probe stage.
>
> Suggested-by: Michael Chan
> Signed-off-by: Baoquan He
Acked-by: Michael Chan
On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote:
> On 11/11/16 at 09:46pm, Baoquan He wrote:
>> Hi bnx2 experts,
>>
>> In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
>> firmware requesting code was moved from open stage to probe stage.
>> The reason is in kdump kernel har
On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes
Looks good to me. Thanks.
Acked-by: Michael Chan
orted-by: coverity (CID 1339583)
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Signed-off-by: Florian Fainelli
Thanks Florian.
Acked-by: Michael Chan
On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote:
> From: Florian Fainelli
> Date: Fri, 15 Jul 2016 16:42:01 -0700
>
>> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp)
>> for (i = 0; i < bp->tx_nr_rings; i++) {
>> txr = &bp->tx_ring[i];
>> t
lin Ian King
Thanks.
Acked-by: Michael Chan
defined reference to
> `vxlan_get_rx_port'
>
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
>
> Signed-off-b
On Thu, 2015-07-16 at 12:18 -0700, Michael Chan wrote:
> On Thu, 2015-07-16 at 14:51 -0400, Nicholas Krause wrote:
> > This adds proper error handling for if the calls to the function
> > tg3_phy_lpbk_set fail by returning -EIO by assigning the return
> > value to the v
l done as no other work can be handled
> internally in the function tg3_test_loopback.
>
> Signed-off-by: Nicholas Krause
Acked-by: Michael Chan
> ---
> drivers/net/ethernet/broadcom/tg3.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff -
On Tue, 2015-01-13 at 07:47 -0500, Peter Hurley wrote:
> > tp->lock is held in this code path. If synchronize_irq() sleeps in
> > wait_event(desc->wait_for_threads, ...), we'll get the warning.
> >
> > The synchronize_irq() call is to wait for any tg3 irq handler to finish
> > so that it is guar
On Mon, 2015-01-12 at 19:59 -0500, Peter Hurley wrote:
> [ 17.203009] BUG: sleeping function called from invalid context at
> /home/peter/src/kernels/mainline/kernel/irq/manage.c:104
> [ 17.203067] in_atomic(): 1, irqs_disabled(): 0, pid: 1106, name: ip
> [ 17.203092] 2 locks held by ip/110
On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote:
> > It would be really good if SCSI_NETLINK depended on NET instead of selected
> > NET.
> > We shouldn't have kconfig symbols that use 'select' on entire subsystems.
>
> As a test, I was able to fix this by this approach : change SCSI_NETLIN
On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote:
> This is caused by c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
>
> So I'm not really sure what the fix for this is. CNIC will properly only
> support
> [m] or [n] when IPV6 is compiled as a module, but if you set SCSI_BNX2X_FC
On Thu, 2014-08-21 at 16:06 -0700, Benjamin Poirier wrote:
> On 2014/08/21 15:32, Michael Chan wrote:
> > On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote:
> > > On 2014/08/19 15:00, Michael Chan wrote:
> > > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin
On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote:
> On 2014/08/19 15:00, Michael Chan wrote:
> > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> > > diff --git a/drivers/net/ethernet/broadcom/tg3.c
> > > b/drivers/net/ethernet/broadcom/tg3.c
&
On Wed, 2014-08-20 at 18:23 -0700, Benjamin Poirier wrote:
> On 2014/08/19 16:10, Michael Chan wrote:
> > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> > > @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct
>
On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct
> tg3_napi *tnapi,
>struct netdev_queue *txq, struct sk_buff *skb)
> {
> struct sk_buff *segs, *nskb;
> - u32 frag_cnt_est = sk
On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.c
> b/drivers/net/ethernet/broadcom/tg3.c
> index 3ac5d23..b11c0fd 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -202,7 +202,8 @@ stati
..
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat
Acked-by: Michael Chan
> ---
> v2: Modified subject line from
> "rcu: Replace rcu_dereference() with rcu_access_pointer()"
> to
>
On Fri, 2014-01-31 at 14:29 +0100, Zoltan Kiss wrote:
> [ 5417.275472] WARNING: at net/sched/sch_generic.c:255
> dev_watchdog+0x156/0x1f0()
> [ 5417.275474] NETDEV WATCHDOG: eth1 (bnx2): transmit queue 2 timed out
The dump shows an internal IRQ pending on MSIX vector 2 which matches
the the que
On Thu, 2014-01-30 at 19:08 +, Zoltan Kiss wrote:
> I've experienced some queue timeout problems mentioned in the subject
> with igb and bnx2 cards.
Please provide the full tx timeout dmesg. bnx2 dumps some diagnostic
information during tx timeout that may be useful. Thanks.
--
To unsubsc
On Tue, 2013-12-10 at 22:23 -0500, David Miller wrote:
> Ok, that may be true, but I'd like to consider the much larger issue
> at hand.
>
> If the indirect mechanism is enabled, some of the offsets that may be
> in there might be value, but would be entirely undesirable to be read
> because the r
On Tue, 2013-12-10 at 13:43 -0500, David Miller wrote:
> What if the kernel is booted via kexec, and the driver in the kernel
> we are kexec'ing from left indirect access enabled in MISC_HOST_CTRL?
That should be ok. The driver will only use valid register offsets in
indirect mode during run tim
On Tue, 2013-12-10 at 07:01 -0800, Natarajan Gurumoorthy wrote:
> The only time I see crashes is after the tg3 driver has been
> loaded into the system. I our use case we are poking around
> /sys/devices/pci//config.
David, please apply this first patch.
Acked-by: Mic
On Mon, 2013-12-09 at 13:07 -0800, Michael Chan wrote:
> On Tue, 2013-12-10 at 00:18 +0300, Sergei Shtylyov wrote:
> > >We had crashes when the PCI config space got scanned via
> > > /sys/devices/pci/../config.
> >
> > > I agree that this f
On Tue, 2013-12-10 at 00:18 +0300, Sergei Shtylyov wrote:
> >We had crashes when the PCI config space got scanned via
> > /sys/devices/pci/../config.
>
> > I agree that this fix will not help if the scan happens before the tg3
> > driver gets loaded.
>
> Then perhaps a better
On Mon, 2013-12-09 at 10:43 -0800, Nat Gurumoorthy wrote:
> The new tg3 driver leaves REG_BASE_ADDR (PCI config offset 120)
> uninitialized. From power on reset this register may have garbage in it. The
> Register Base Address register defines the device local address of a
> register. The data poi
On Mon, 2013-12-02 at 13:48 -0500, David Miller wrote:
> From: "Michael Chan"
> Date: Sun, 1 Dec 2013 12:39:19 -0800
>
> > I'm not familiar with the DS1. Does the tg3 device get removed through
> > tg3_remove_one() in this case? What happens when you
On Sun, 2013-12-01 at 02:34 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Modify tg3_chip_reset() and tg3_close() to check if the PCI network
> adapter device is accessible at all in order to skip poking it or
> trying to handle a carrier loss in vain when that's not the case.
> I
On Wed, 2013-05-29 at 17:00 +0800, Yijing Wang wrote:
> Pci_enable_device() will set device pm state to D0, so
> it's no need to do it again in tg3_init_one().
>
> Signed-off-by: Yijing Wang
Acked-by: Michael Chan
> ---
> drivers/net/ethernet/broadcom/tg3.c | 20 +-
ev and tg3_chip_rev.
>
> These macros are not converted to static inline functions
> because gcc (tested with 4.7.2) is currently unable to
> optimize the object code it produces the same way and code
> is otherwise larger.
>
> Signed-off-by: Joe Perches
Acked-by: Michae
On Sat, 2013-02-16 at 13:20 -0800, Joe Perches wrote:
> It's the same value as tp->pci_chip_rev_id so use that
> instead. This makes all CHIPREV_ID_ tests the same.
>
> Signed-off-by: Joe Perches
Acked-by: Michael Chan
--
To unsubscribe from this list: send the lin
It was mistakenly defined to be 24 instead of the next higher number 25.
Reported-by: Alexander Shishkin
Cc: Stephen Hurd
Signed-off-by: Michael Chan
---
include/uapi/linux/serial_core.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/uapi/linux/serial_core.h
to track this. It continues to reload the THR as long
as the THRE and TSRE bits are set in the LSR up to a specified limit (1024
is used here).
Signed-off-by: Stephen Hurd
Signed-off-by: Michael Chan
---
drivers/tty/serial/8250/8250.c | 11 ++
drivers/tty/serial/8250/8250.h
On Thu, 2013-01-17 at 17:59 +0100, Marcin Miotk wrote:
> root@XX ~ # cat miitool_non_working_3.4.11
> Using SIOCGMIIPHY=0x8947
> eth1: 100 Mbit, full duplex, no link
> registers for MII PHY 1:
> 2100 7949 0020 6340 0041 0004 2001
> 3000
> 00
On Wed, 2013-01-09 at 08:03 +0100, Marcin Miotk wrote:
> 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5715
> Gigabit Ethernet (rev a3)
> 03:04.1 Ethernet controller: Broadcom Corporation NetXtreme BCM5715
> Gigabit Ethernet (rev a3)
I tested on 3.7 kernel and it seemed to work.
Please tell us what tg3 device you're using. You can provide lspci
output or tg3 probing dmesg output. Thanks.
On Wed, 2013-01-09 at 11:20 +0800, 王金浦 wrote:
> For this kind of driver related question, I suggest you send mail to
> tg3 driver developers, who I already cced.
>
>
> I think they s
On Tue, 2012-10-02 at 18:49 +0200, Ferenc Wagner wrote:
> Going into the opposite direction: I found that Linux 3.6 does not
> permanently break the SoL console on upping eth0! I'll try to find
> the
> commit which (sort of) fixed it.
These are the likely fixes:
>
commit cf9ecf4b631f649a964fa611
nt
>
> This patch moves the code that asserts the TSO_CAPABLE flag closer
> to
> where the TSO capabilities flags are set. There isn't a good
> enough
> reason for the code to be separated.
>
> Signed-off-by: Matt Carlson
> Reviewed-by: M
On Fri, 2012-09-28 at 22:45 +0200, Ferenc Wagner wrote:
> Hi,
>
> Upgrading the kernel on our HS20 blades resulted in their SoL (serial
> over LAN) connection being broken. The disconnection happens when eth0
> (the interface involved in SoL) is brought up during the boot sequence.
> If I later
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
> I see. I was confused by the name of bnx2_set_power_state() and
> I think the PHY is actually powered up by bnx2_reset_nic, right?
bnx2_init_phy() in bnx2_init_nic() will bring up the PHY if it is down.
>
>
--
To unsubscribe from th
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
> Also, I have another comment related to link state.
>
> Right now, the bnx2 driver powers up the device in bnx2_init_board(),
> regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just probes
t
before bnx2_open() is called. Can you please
elborate? Thanks.
> Regards,
>
> Jiang
>
> -
> Jiang Wang
> Member of Technical Staff
> Riverbed Technology
> Tel: (408) 522-5109
> Email: jiang.w...@riverbed.com
> www.riverbed.com
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
> The initialization state of bnx2 driver is wrong. It does not turn
> of the Linux network stack using netif_carrier_off. This may lead to
> inconsistent report from ethtool as the link is up but speed is
> unknown when the cable is not plugged
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote:
> Is there a more automatic method than going through the source for each
> configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the
> relevant firmwares? Is there any way to give the kernel the location of
> linux-firmware and h
On Wed, 2008-02-20 at 15:08 -0800, David Miller wrote:
> From: Tony Battersby <[EMAIL PROTECTED]>
> Date: Wed, 20 Feb 2008 18:04:09 -0500
>
> > The following patch fixes the problem for me. Do we want to accept this
> > patch and call it a day or continue investigating the source of the problem?
On Tue, 2008-02-19 at 17:14 -0500, Tony Battersby wrote:
>
> Update: when I revert Herbert's patch in addition to applying your
> patch, the iSCSI performance goes back up to 115 MB/s again in both
> directions. So it looks like turning off SG for TX didn't itself cause
> the performance drop, b
On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote:
> iSCSI
> performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx
> with light tx,
That's strange. The patch should only affect TX performance slightly
since we are just turning off SG for TX. Please take an ethereal trace
to
On Mon, 2008-02-18 at 16:35 -0800, David Miller wrote:
> One consequence of Herbert's change is that the chip will see a
> different datastream. The initial skb->data linear area will be
> smaller, and the transition to the fragmented area of pages will be
> quicker.
>
I see. Perhaps when we g
On Mon, 2008-02-18 at 17:41 -0500, Tony Battersby wrote:
> I am experiencing network data corruption with a 3Com 3C996B-T NIC
> (Broadcom NetXtreme BCM5701; driver tg3.ko). I have identified the
> following patch as the trigger:
Assuming this problem is unique to the 5701, I'm not sure how it is
SE bit for 1000Base-X twice instead
checking for both the 1000Base-X bit and the 10/100/1000Base-T bit.
The purpose of the logic is to tell the firmware that ASYM_PAUSE is
set on either the Serdes or Copper interface.
Problem was discovered by Roel Kluin <[EMAIL PROTECTED]>
Signed-off-by:
On Tue, 2007-11-27 at 01:35 -0800, [EMAIL PROTECTED] wrote:
>
> Issue:
>
> I (for unrelated reasons) run powertop, and it suggests I conserve power
> by doing 'ethtool -s eth0 wol d'. I look at it, and think that it's daft,
> because (a) the Dell factory default is WOL disabled and (b) if it wa
[EMAIL PROTECTED] wrote:
> (a) the Dell factory default is WOL disabled and (b)
> if it wasn't
> the default, I'd have *set* it to disabled, and (c) I even
> went back and
> rebooted and checked the BIOS setting - disabled. Nonetheless:
>
> # ethtool eth0 | grep Wake
> Supports Wake-on:
On Thu, 2007-11-15 at 13:17 -0600, Jon Nelson wrote:
> Is this what you mean? I pulled this from the quoted text:
>
> Nov 10 22:45:52 frank kernel: NETDEV WATCHDOG: eth0: transmit timed out
>
Right. This explains the reset at 22:45:52, but not the earlier reset
at 22:24:40. Link never came up
On Thu, 2007-11-15 at 10:47 +0100, Jarek Poplawski wrote:
> On 13-11-2007 19:57, Jon Nelson wrote:
> > The best info I've got is this:
It looks like the card is being reset periodically. Every time the card
gets reset, you'll see those PM messages in the version of the driver
you're using. Do yo
On Tue, 2007-11-13 at 18:04 -0800, Joe Perches wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
Thanks.
-
X2]: Fix VLAN on ASF
> >
> > Always set up the device to strip incoming VLAN tags when ASF is
> > enabled. ASF firmware will not parse packets correctly if VLAN tags
> > are not stripped.
> >
> > Signed-off-by: Michael Chan <[
PCI_DEVICE_ID_TIGON3_5714S,
> + quirk_msi_intx_disable_bug);
> +
Please add PCI_DEVICE_ID_TIGON3_5715 and
PCI_DEVICE_ID_TIGON3_5715S as well.
Other than that,
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscrib
ook and I'll try to do so as well
> tonight.
>
I've already reviewed the earlier versions of the patch and have made
some suggestions. This latest one looks ok to me and tested ok.
I'll follow up later with another patch to remove all the zeros in other
firmware sections, an
1 - 100 of 122 matches
Mail list logo
