Re: [PATCH 1/2] mm: add probe_user_read() and probe_user_address()

2018-12-04 Thread Michael Ellerman
Christophe Leroy writes: > In the powerpc, there are several places implementing safe ^ code ? > access to user data. This is sometimes implemented using > probe_kernel_address() with additional access_ok() verification, > sometimes with get_user() enclosed in a

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-26 Thread Michael Ellerman
| 6 +++--- > arch/ia64/sn/kernel/io_common.c | 3 ++- > arch/powerpc/include/asm/pci-bridge.h | 3 ++- > arch/powerpc/kernel/paca.c| 3 ++- > arch/powerpc/kernel/pci-common.c | 3 ++- > arch/powerpc/mm/numa.c

Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags

2018-11-20 Thread Michael Ellerman
Andrew Murray writes: > Update design.txt to reflect the presence of the exclude_host > and exclude_guest perf flags. > > Signed-off-by: Andrew Murray > --- > tools/perf/design.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/design.txt b/tools/perf/design.txt >

Re: Build regressions/improvements in v4.20-rc2

2018-11-14 Thread Michael Ellerman
Geert Uytterhoeven writes: > Below is the list of build error/warning regressions/improvements in > v4.20-rc2[1] compared to v4.19[2]. > > Summarized: > - build errors: +3/-0 > - build warnings: +123/-12803 > > JFYI, when comparing v4.20-rc2[1] to v4.20-rc1[3], the summaries are: > - build

Re: Git pull ack emails..

2018-11-07 Thread Michael Ellerman
Boris Brezillon writes: > Hello Michael, > > On Thu, 01 Nov 2018 21:18:28 +1100 > Michael Ellerman wrote: > >> Mark Brown writes: >> >> > On Fri, Oct 26, 2018 at 12:36:14PM -0500, Rob Herring wrote: >> >> On Thu, Oct

Re: [PATCH] of: Fix cpu node iterator to not ignore disabled cpu nodes

2018-11-01 Thread Michael Ellerman
xes: 651d44f9679c ("of: use for_each_of_cpu_node iterator") > Fixes: f1f207e43b8a ("of: Add cpu node iterator for_each_of_cpu_node()") > Reported-by: Michael Ellerman > Cc: Christian Zigotzky > Cc: Frank Rowand > Signed-off-by: Rob Herring > --- > drivers/of/b

Re: NXP P50XX/e5500 secondary CPUs not onlined with current mainline (was [PATCH 20/21] of: use for_each_of_cpu_node iterator)

2018-11-01 Thread Michael Ellerman
Rob Herring writes: > On Wed, Oct 31, 2018 at 7:46 AM Michael Ellerman wrote: >> Rob Herring writes: >> > Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This >> > has the side effect of defaulting to iterating using "cpu" node names

Re: Git pull ack emails..

2018-11-01 Thread Michael Ellerman
Mark Brown writes: > On Fri, Oct 26, 2018 at 12:36:14PM -0500, Rob Herring wrote: >> On Thu, Oct 25, 2018 at 9:14 AM Linus Torvalds >> wrote: > >> > Are there other situations where you might want to track something >> > _outside_ of a pull request? Maybe. I can't really think of a lot of >> >

NXP P50XX/e5500 secondary CPUs not onlined with current mainline (was [PATCH 20/21] of: use for_each_of_cpu_node iterator)

2018-10-31 Thread Michael Ellerman
Hi Rob, This change is breaking some powerpc machines, ... Rob Herring writes: > Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This > has the side effect of defaulting to iterating using "cpu" node names in > preference to the deprecated (for FDT) device_type == "cpu". > >

Re: [PATCH] reiserfs: remove workaround code for GCC 3.x

2018-10-30 Thread Michael Ellerman
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq > -# will work around it. If any other architecture displays this behavior, > -# add it here. > -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1) > - > TAGS: > etags *.c Oh wow that's gross. Thanks for cleaning it up. Acked-by: Michael Ellerman cheers

[PATCH v2 1/2] seq_buf: Make seq_buf_puts() null-terminate the buffer

2018-10-18 Thread Michael Ellerman
fer in a null-terminated state. The only downside is that this makes the buffer 1 character smaller for seq_buf_puts(), but that seems like a good trade off. Acked-by: Kees Cook Signed-off-by: Michael Ellerman --- lib/seq_buf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) v2: Fi

[PATCH v2 2/2] seq_buf: Use size_t for len in seq_buf_puts()

2018-10-18 Thread Michael Ellerman
-by: Michael Ellerman --- lib/seq_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2: New in v2. diff --git a/lib/seq_buf.c b/lib/seq_buf.c index 6aabb609dd87..bd807f545a9d 100644 --- a/lib/seq_buf.c +++ b/lib/seq_buf.c @@ -140,7 +140,7 @@ int seq_buf_bprintf(struct seq_buf *s, const

Re: [PATCH] seq_buf: Make seq_buf_puts() NULL terminate the buffer

2018-10-18 Thread Michael Ellerman
Jann Horn writes: > On Wed, Oct 17, 2018 at 2:10 PM Michael Ellerman wrote: >> Currently seq_buf_puts() will happily create a non NULL terminated >> string for you in the buffer. This is particularly dangerous if the >> buffer is on the stack. >> >> For exampl

[PATCH] seq_buf: Make seq_buf_puts() NULL terminate the buffer

2018-10-17 Thread Michael Ellerman
fer in a NULL terminated state. The only downside is that this makes the buffer 1 character smaller for seq_buf_puts(), but that seems like a good trade off. Signed-off-by: Michael Ellerman --- lib/seq_buf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) I recently merged a patch whi

Re: [PATCH] selftests/vm: Add a test for MAP_FIXED_NOREPLACE

2018-10-15 Thread Michael Ellerman
Michal Hocko writes: > On Sun 14-10-18 00:39:29, Michael Ellerman wrote: >> Add a test for MAP_FIXED_NOREPLACE, based on some code originally by >> Jann Horn. This would have caught the overlap bug reported by Daniel Micay. >> >> I originally suggest

Re: [PATCH] signal: Mark expected switch fall-throughs

2018-10-15 Thread Michael Ellerman
; 1 file changed, 6 insertions(+) These all look correct to me. Reviewed-by: Michael Ellerman > diff --git a/include/linux/signal.h b/include/linux/signal.h > index 200ed96..f428e86 100644 > --- a/include/linux/signal.h > +++ b/include/linux/signal.h > @@ -129,9 +129,11 @@ stati

[PATCH] selftests/vm: Add a test for MAP_FIXED_NOREPLACE

2018-10-13 Thread Michael Ellerman
be called MAP_FIXED_SAFE/NOCLOBBER/WEAK/NEW .. mea culpa. Signed-off-by: Michael Ellerman --- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + .../selftests/vm/map_fixed_noreplace.c| 206 ++ 3 files changed, 208

Re: [PATCH] mm: don't clobber partially overlapping VMA with MAP_FIXED_NOREPLACE

2018-10-12 Thread Michael Ellerman
Jann Horn writes: > On Wed, Oct 10, 2018 at 7:19 PM Michal Hocko wrote: >> On Wed 10-10-18 17:27:36, Jann Horn wrote: >> > Daniel Micay reports that attempting to use MAP_FIXED_NOREPLACE in an >> > application causes that application to randomly crash. The existing check >> > for handling

Re: powerpc: remove leftover code of old GCC version checks

2018-10-11 Thread Michael Ellerman
On Mon, 2018-10-01 at 06:10:24 UTC, Masahiro Yamada wrote: > Clean up the leftover of commit f2910f0e6835 ("powerpc: remove old > GCC version checks"). > > Signed-off-by: Masahiro Yamada > Acked-by: Nicholas Piggin Applied to powerpc next, thanks.

Re: [PATCH v6] selftests: add headers_install to lib.mk

2018-10-02 Thread Michael Ellerman
Shuah Khan writes: > On 09/27/2018 10:52 PM, Michael Ellerman wrote: >> [ + linuxppc-dev ] >> >> Anders Roxell writes: >>> If the kernel headers aren't installed we can't build all the tests. >>> Add a new make target rule 'khdr' in the file li

Re: linux-next: Tree for Sep 20

2018-09-23 Thread Michael Ellerman
Rob Herring writes: > On Thu, Sep 20, 2018 at 4:18 AM Stephen Rothwell > wrote: >> On Thu, 20 Sep 2018 21:10:08 +1000 Stephen Rothwell >> wrote: >> > On Thu, 20 Sep 2018 20:37:37 +1000 Michael Ellerman >> > wrote: >> > > Oodles of: >&g

Re: linux-next: build failure after merge of the vfs tree

2018-09-20 Thread Michael Ellerman
Stephen Rothwell writes: > Hi David, > > On Wed, 19 Sep 2018 07:01:00 +0100 David Howells wrote: >> >> Stephen Rothwell wrote: >> >> > > I think the problem is that I haven't allocated system call numbers for >> > > any arches other than x86 - even the x86 syscall numbers are provisional >> >

Re: linux-next: build failure after merge of the vfs tree

2018-09-20 Thread Michael Ellerman
David Howells writes: > Stephen Rothwell wrote: > >> > After merging the vfs tree, today's linux-next build (powerpc >> > allyesconfig) failed like this: >> > >> > samples/vfs/test-fsinfo.c: In function 'fsinfo': >> > samples/vfs/test-fsinfo.c:37:17: error: '__NR_fsinfo' undeclared (first >>

Re: linux-next: Tree for Sep 20

2018-09-20 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Changes since 20180919: > > Dropped trees: xarray, ida (temporarily) > > The input-current tree lost its build failure. > > I still disabled building some samples in the vfs tree. > > Non-merge commits (relative to Linus' tree): 4279 > 4792 files changed,

Re: ptrace compile failure with gcc-8.2 on 32-bit powerpc

2018-08-16 Thread Michael Ellerman
Meelis Roos writes: > After upgrading my distro compiler to gcc-8.2, Linux fails to compile on > 32-bit powerpc (tested with 4.17, 4.18 and v4.18-7873-gf91e654474d4). Yeah I noticed this just yesterday. > CC arch/powerpc/kernel/ptrace.o > In file included from

Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir

2018-08-15 Thread Michael Ellerman
Arnaldo Carvalho de Melo writes: > Em Wed, Aug 15, 2018 at 08:02:48PM +1000, Michael Ellerman escreveu: >> Jiri Olsa writes: >> > On Tue, Aug 14, 2018 at 03:06:44PM -0300, Arnaldo Carvalho de Melo wrote: >> >> Em Tue, Aug 14, 2018 at 09:27:26AM +0200, Jiri Olsa e

Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir

2018-08-15 Thread Michael Ellerman
Jiri Olsa writes: > On Tue, Aug 14, 2018 at 03:06:44PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Tue, Aug 14, 2018 at 09:27:26AM +0200, Jiri Olsa escreveu: >> > On Tue, Aug 14, 2018 at 11:47:39AM +1000, Michael Ellerman wrote: >> > > Jiri Olsa writes: >>

Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir

2018-08-13 Thread Michael Ellerman
Jiri Olsa writes: > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > index ea48aa6f8d19..9d466e853aec 100755 > --- a/tools/perf/check-headers.sh > +++ b/tools/perf/check-headers.sh > @@ -88,6 +88,8 @@ check () { > # differences. > test -d ../../include || exit 0 > >

Re: powerpc/mm: remove huge_pte_offset_and_shift() prototype

2018-08-13 Thread Michael Ellerman
On Wed, 2018-08-08 at 15:36:34 UTC, Christophe Leroy wrote: > huge_pte_offset_and_shift() has never existed > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/646dbe40fa2a54118975792fa9b98c cheers

Re: [PATCH 2/3] perf report: Add raw report support for s390 auxiliary trace

2018-08-09 Thread Michael Ellerman
Arnaldo Carvalho de Melo writes: > Em Thu, Aug 09, 2018 at 06:35:58AM +0200, Thomas-Mich Richter escreveu: >> On 08/08/2018 06:42 PM, Arnaldo Carvalho de Melo wrote: >> > So for those I applied this, seems to pass the ones that were failing, >> > restarting tests... > >> I just updated the

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-09 Thread Michael Ellerman
Andy Shevchenko writes: > On Thu, 2018-08-09 at 16:18 +1000, Michael Ellerman wrote: >> rashmica writes: >> > On 08/08/18 17:25, Michael Ellerman wrote: >> > > Christophe Leroy writes: >> > > > >> > mpe I sent a patch doing that awhile ago

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

2018-07-24 Thread Michael Ellerman
.hiXi.hi > + vpmsumd $Xh,$IN,$Hh # H.hi·Xi.hi >add$inp,$inp,r0 > > vpmsumd $t2,$Xl,$xC2# 1st phase Acked-by: Michael Ellerman (powerpc) cheers

Re: powerpc/mpic: Cleanup irq vector accounting

2018-07-23 Thread Michael Ellerman
On Fri, 2018-06-29 at 10:24:32 UTC, Bharat Bhushan wrote: > Available vector space accounts ipis and timer interrupts > while spurious vector was not accounted. Also later > mpic_setup_error_int() escape one more vector, seemingly it > assumes one spurious vector. > > Signed-off-by: Bharat

Re: linux-next: Tree for Jul 23

2018-07-23 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Changes since 20180720: > > Dropped trees: xarray, ida (complex conflicts) > > The drm-msm tree gained a conflict against the drm tree and a build > failure due to an interaction with the drm tree for which I added a > merge fix patch. > > The kvm-arm tree

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-18 Thread Michael Ellerman
Michael Ellerman writes: > Peter Zijlstra writes: ... > > I'll do some kernbench runs tomorrow and see if it shows up there. Finally got some numbers. The summary is it's in the noise, the average delta is +0.1s (total time is ~67s, so 0.17%) but the standard deviation is ~0.2s.

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-18 Thread Michael Ellerman
Linus Torvalds writes: > On Tue, Jul 17, 2018 at 7:45 AM Michael Ellerman wrote: >> >> >> Interesting. I don't see anything as high as 18%, it's more spread out: >> >> 7.81% context_switch [kernel.kallsyms] [k] cgroup_rstat_updated > > Oh, see th

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-17 Thread Michael Ellerman
Linus Torvalds writes: > On Mon, Jul 16, 2018 at 7:40 AM Michael Ellerman wrote: ... >> I guess arguably it's not a very macro benchmark, but we have a >> context_switch benchmark in the tree[1] which we often use to tune >> things, and it degrades badly. It just spins u

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-16 Thread Michael Ellerman
Peter Zijlstra writes: > On Fri, Jul 13, 2018 at 11:15:26PM +1000, Michael Ellerman wrote: ... >> >> >> So 18-32% slower, or 23-47 cycles. > > Very good info. Note that another option is to put the SYNC in lock() it > doesn't really matter which of the two primiti

Re: [PATCH v5 0/5] sparse_init rewrite

2018-07-16 Thread Michael Ellerman
ctions, now we do both in one place, but still > allow preallocation of memory to reduces fragmentation on all > platforms. However, I still wanted to see if someone could test on > real hardware. I booted it on a small VM and a 160 CPU 4 node machine, both booted fine. If you want: Tested-by: Michael Ellerman (powerpc) Thanks for fixing it up for us. cheers

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-13 Thread Michael Ellerman
Peter Zijlstra writes: > On Thu, Jul 12, 2018 at 11:10:58AM -0700, Linus Torvalds wrote: >> On Thu, Jul 12, 2018 at 11:05 AM Peter Zijlstra wrote: >> > >> > The locking pattern is fairly simple and shows where RCpc comes apart >> > from expectation real nice. >> >> So who does RCpc right now

Re: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-10 Thread Michael Ellerman
Mathieu Desnoyers writes: > - On Jul 8, 2018, at 5:03 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> In preparation to use __u64 for the rseq_cs pointer field, 32-bit >> architectures need to read this 64-bit value located in user-space >> addresses. >> >> __get_user is

Re: [PATCH 4.16 234/279] x86/pkeys/selftests: Adjust the self-test to fresh distros that export the pkeys ABI

2018-07-08 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Sun, Jul 08, 2018 at 08:33:37PM +1000, Michael Ellerman wrote: ... >> >> My comment was less about this actual patch and more about the new >> reality of patches being backported to stable based on Sasha's tooling, >> which seems t

Re: [PATCH 4.16 234/279] x86/pkeys/selftests: Adjust the self-test to fresh distros that export the pkeys ABI

2018-07-08 Thread Michael Ellerman
Ingo Molnar writes: > * Michael Ellerman wrote: >> Greg Kroah-Hartman writes: >> > On Tue, Jul 03, 2018 at 01:36:43PM +0200, Vlastimil Babka wrote: >> >> On 06/18/2018 10:13 AM, Greg Kroah-Hartman wrote: >> >> > 4.16-stable review patch.

Re: [PATCH 4.16 234/279] x86/pkeys/selftests: Adjust the self-test to fresh distros that export the pkeys ABI

2018-07-05 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Tue, Jul 03, 2018 at 01:36:43PM +0200, Vlastimil Babka wrote: >> On 06/18/2018 10:13 AM, Greg Kroah-Hartman wrote: >> > 4.16-stable review patch. If anyone has any objections, please let me >> > know. >> >> So I was wondering, why backport such a considerable

Re: [PATCH] cpuidle:powernv: Add the CPUIDLE_FLAG_POLLING for snooze

2018-07-05 Thread Michael Ellerman
Gautham R Shenoy writes: > On Tue, Jul 03, 2018 at 07:36:16PM +0530, Vaidyanathan Srinivasan wrote: >> * Gautham R Shenoy [2018-07-03 10:54:16]: >> >> > From: "Gautham R. Shenoy" >> > >> > In the situations where snooze is the only cpuidle state due to >> > firmware not exposing any platform

Re: Build regressions/improvements in v4.18-rc3

2018-07-03 Thread Michael Ellerman
Helge Deller writes: > On 03.07.2018 03:09, Michael Ellerman wrote: >> Helge Deller writes: >> >>> On 02.07.2018 16:09, Geert Uytterhoeven wrote: >>>> On Mon, Jul 2, 2018 at 4:01 PM Geert Uytterhoeven >>>> wrote: >>>>> J

Re: Build regressions/improvements in v4.18-rc3

2018-07-03 Thread Michael Ellerman
John David Anglin writes: > On 2018-07-02 9:09 PM, Michael Ellerman wrote: >> It's GCC 4.6.3. Are you saying that's not supported anymore? > See <https://gcc.gnu.org/> for supported releases. Thanks, but I mean "supported by the parisc Linux port". Allegedly th

Re: Build regressions/improvements in v4.18-rc3

2018-07-02 Thread Michael Ellerman
Helge Deller writes: > On 02.07.2018 16:09, Geert Uytterhoeven wrote: >> On Mon, Jul 2, 2018 at 4:01 PM Geert Uytterhoeven >> wrote: >>> JFYI, when comparing v4.18-rc3[1] to v4.18-rc2[3], the summaries are: >> ... > > Both of the following are simply happening because of old compiler which is

Re: [Update] Regression in 4.18 - 32-bit PowerPC crashes on boot - bisected to commit 1d40a5ea01d5

2018-07-01 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, Jun 29, 2018 at 1:42 PM Larry Finger > wrote: >> >> I have more information regarding this BUG. Line 700 of page-flags.h is the >> macro PAGE_TYPE_OPS(Table, table). For further debugging, I manually expanded >> the macro, and found that the bug line is

Re: [PATCHv4 1/3] scripts: Preprocess module-common.lds

2018-06-13 Thread Michael Ellerman
Laura Abbott writes: > On 06/11/2018 11:03 PM, Michael Ellerman wrote: >> kbuild test robot writes: ... >>> All errors (new ones prefixed by >>): >>> >>>>> ld: cannot open linker script file scripts/module-common.lds: No such >>>>

Re: [PATCHv4 0/3] Salted build ids via linker sections

2018-06-12 Thread Michael Ellerman
Laura Abbott (3): > scripts: Preprocess module-common.lds > kbuild: Introduce build-salt linker section and config option > x86: Add build salt to the vDSO and kernel linker scripts Hi Laura, Here's a patch to get it working on powerpc. Seems to work as expected. cheers >F

Re: [PATCHv4 1/3] scripts: Preprocess module-common.lds

2018-06-12 Thread Michael Ellerman
kbuild test robot writes: > Hi Laura, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17 next-20180608] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

Re: [PATCHv2 05/16] atomics: prepare for atomic64_fetch_add_unless()

2018-06-06 Thread Michael Ellerman
Mark Rutland writes: > On Tue, Jun 05, 2018 at 08:54:03PM +1000, Michael Ellerman wrote: >> Mark Rutland writes: >> > On Tue, Jun 05, 2018 at 11:26:37AM +0200, Peter Zijlstra wrote: >> >> On Tue, May 29, 2018 at 04:43:35PM +0100, Mark Rutland wrote: >> >&

Re: [PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-06-05 Thread Michael Ellerman
Frederic Weisbecker writes: > On Mon, May 28, 2018 at 09:31:07PM +1000, Michael Ellerman wrote: >> Frederic Weisbecker writes: >> >> > On Thu, May 24, 2018 at 12:01:52PM +1000, Michael Ellerman wrote: >> >> Frederic Weisbecker writes: >> &g

Re: [PATCHv2 05/16] atomics: prepare for atomic64_fetch_add_unless()

2018-06-05 Thread Michael Ellerman
Mark Rutland writes: > On Tue, Jun 05, 2018 at 11:26:37AM +0200, Peter Zijlstra wrote: >> On Tue, May 29, 2018 at 04:43:35PM +0100, Mark Rutland wrote: >> > /** >> > + * atomic64_add_unless - add unless the number is already a given value >> > + * @v: pointer of type atomic_t >> > + * @a: the

Re: powerpc/boot: remove unused variable in mpc8xx

2018-06-04 Thread Michael Ellerman
On Tue, 2018-04-17 at 12:36:45 UTC, Christophe Leroy wrote: > Variable div is set but never used. Remove it. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/169f438a7e369226a452e0ac4a54db cheers

Re: [1/6] powerpc/64s: Add barrier_nospec

2018-06-04 Thread Michael Ellerman
On Tue, 2018-04-24 at 04:15:54 UTC, Michael Ellerman wrote: > From: Michal Suchanek > > A no-op form of ori (or immediate of 0 into r31 and the result stored > in r31) has been re-tasked as a speculation barrier. The instruction > only acts as a barrier on newer machines w

Re: [v2, 1/2] selftests/powerpc: Add ptrace tests for Protection Key registers

2018-06-01 Thread Michael Ellerman
On Fri, 2018-05-25 at 02:11:44 UTC, Thiago Jung Bauermann wrote: > This test exercises read and write access to the AMR, IAMR and UAMOR. > > Signed-off-by: Thiago Jung Bauermann Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1f7256e7dddef49acf9f6c9fe3f935 cheers

Re: [PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-05-28 Thread Michael Ellerman
Frederic Weisbecker <frede...@kernel.org> writes: > On Thu, May 24, 2018 at 12:01:52PM +1000, Michael Ellerman wrote: >> Frederic Weisbecker <frede...@kernel.org> writes: >> >> > diff --git a/arch/powerpc/kernel/hw_breakpoint.c >> > b/arch/powe

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-28 Thread Michael Ellerman
Frederic Weisbecker <frede...@kernel.org> writes: > On Thu, May 24, 2018 at 11:56:01AM +1000, Michael Ellerman wrote: >> Frederic Weisbecker <frede...@kernel.org> writes: >> >> > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.

Re: [PATCH] powerpc/64s: Clear PCR on boot

2018-05-26 Thread Michael Ellerman
On 25 May 2018 11:33:08 pm AEST, Guenter Roeck wrote: >On Fri, May 18, 2018 at 11:37:42AM +1000, Michael Neuling wrote: >> Clear the PCR (Processor Compatibility Register) on boot to ensure we >> are not running in a compatibility mode. >> >> We've seen this cause problems

Re: [10/19] powerpc/chrp/time: Make some functions static, add missing header include

2018-05-25 Thread Michael Ellerman
On Thu, 2018-03-22 at 20:19:56 UTC, Mathieu Malaterre wrote: > Add a missing include . > > These functions can all be static, make it so. Fix warnings treated as > errors with W=1: > > arch/powerpc/platforms/chrp/time.c:41:13: error: no previous prototype for > ‘chrp_time_init’

Re: [v3, 05/19] powerpc/chrp/setup: Remove idu_size variable and make some functions static

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:09:11 UTC, Mathieu Malaterre wrote: > Remove variable declaration idu_size and associated code since not used. > > These functions can all be static, make it so. Fix warnings treated as > errors with W=1: > > arch/powerpc/platforms/chrp/setup.c:97:6: error: no previous

Re: [18/19] powerpc: Add a missing include header

2018-05-25 Thread Michael Ellerman
On Thu, 2018-03-22 at 20:20:04 UTC, Mathieu Malaterre wrote: > The header file was missing from the includes. Fix the > following warning, treated as error with W=1: > > arch/powerpc/kernel/vecemu.c:260:5: error: no previous prototype for > ‘emulate_altivec’ [-Werror=missing-prototypes] >

Re: [17/19] powerpc/32: Add a missing include header

2018-05-25 Thread Michael Ellerman
On Thu, 2018-03-22 at 20:20:03 UTC, Mathieu Malaterre wrote: > The header file was missing from the includes. Fix the > following warning, treated as error with W=1: > > arch/powerpc/kernel/pci_32.c:286:6: error: no previous prototype for > ‘sys_pciconfig_iobase’

Re: [06/19] powerpc: Make function btext_initialize static

2018-05-25 Thread Michael Ellerman
On Thu, 2018-03-22 at 20:19:52 UTC, Mathieu Malaterre wrote: > This function can be static, make it so, this fix a warning treated as > error with W=1: > > arch/powerpc/kernel/btext.c:173:5: error: no previous prototype for > ‘btext_initialize’ [-Werror=missing-prototypes] > >

Re: [v3,01/19] powerpc/powermac: Mark variable x as unused

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:07:46 UTC, Mathieu Malaterre wrote: > Since the value of x is never intended to be read, declare it with gcc > attribute as unused. Fix warning treated as error with W=1: > > arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable > ‘x’ set but not

Re: [v3,09/19] powerpc/chrp/pci: Make some functions static

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:15:03 UTC, Mathieu Malaterre wrote: > These functions can all be static, make it so. Fix warnings treated as > errors with W=1: > > arch/powerpc/platforms/chrp/pci.c:34:5: error: no previous prototype for > ‘gg2_read_config’ [-Werror=missing-prototypes] >

Re: [v3, 12/19] powerpc/powermac: Add missing prototype for note_bootable_part()

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:13:05 UTC, Mathieu Malaterre wrote: > Add a missing prototype for function `note_bootable_part` to silence a > warning treated as error with W=1: > > arch/powerpc/platforms/powermac/setup.c:361:12: error: no previous > prototype for ‘note_bootable_part’

Re: [v3] powerpc/altivec: Add missing prototypes for altivec

2018-05-25 Thread Michael Ellerman
On Wed, 2018-03-28 at 18:55:25 UTC, Mathieu Malaterre wrote: > Some functions prototypes were missing for the non-altivec code. Add the > missing prototypes in a new header file, fix warnings treated as errors > with W=1: > > arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype

Re: [v3, 11/19] powerpc/powermac: Move pmac_pfunc_base_install prototype to header file

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:13:55 UTC, Mathieu Malaterre wrote: > The pmac_pfunc_base_install prototype was declared in powermac/smp.c since > function was used there, move it to pmac_pfunc.h header to be visible in > pfunc_base.c. Fix a warning treated as error with W=1: > >

Re: [v3,15/19] powerpc: Add missing prototype

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:11:42 UTC, Mathieu Malaterre wrote: > Add one missing prototype for function rh_dump_blk. Fix warning treated as > error in W=1: > > arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for > ‘rh_dump_blk’ [-Werror=missing-prototypes] > > Suggested-by:

Re: [v3,13/19] powerpc/52xx: Add missing functions prototypes

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:12:30 UTC, Mathieu Malaterre wrote: > The function prototypes were declared within a `#ifdef CONFIG_PPC_LITE5200` > block which would prevent them from being visible when compiling > `mpc52xx_pm.c`. Move the prototypes outside of the `#ifdef` block to fix > the following

Re: [v2] powerpc/mm/radix: use do/while(0) trick for single statement block

2018-05-25 Thread Michael Ellerman
On Mon, 2018-04-23 at 19:36:38 UTC, Mathieu Malaterre wrote: > In commit 7a22d6321c3d ("powerpc/mm/radix: Update command line parsing for > disable_radix") an `if` statement was added for a possible empty body > (prom_debug). > > Fix the following warning, treated as error with W=1: > >

Re: powerpc: add __printf verification to prom_printf

2018-05-25 Thread Michael Ellerman
On Fri, 2018-04-06 at 20:12:19 UTC, Mathieu Malaterre wrote: > __printf is useful to verify format and arguments. Fix arg mismatch > reported by gcc, remove the following warnings (with W=1): > > arch/powerpc/kernel/prom_init.c:1467:31: error: format ‘%x’ expects > argument of type

Re: powerpc/wii: Make hlwd_pic_init function static

2018-05-25 Thread Michael Ellerman
On Mon, 2018-04-23 at 19:45:32 UTC, Mathieu Malaterre wrote: > The function hlwd_pic_init can be made static, so do it. Fix the following > warning treated as error (W=1): > > ../arch/powerpc/platforms/embedded6xx/hlwd-pic.c:158:20: error: no previous > prototype for ‘hlwd_pic_init’

[GIT PULL] Please pull powerpc/linux.git powerpc-4.17-7 tag

2018-05-25 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull one more powerpc fix for 4.17: The following changes since commit c1d2a31397ec51f0370f6bd17b19b39152c263cb: powerpc/powernv: Fix NVRAM sleep in invalid context when crashing (2018-05-18 00:23:07 +1000) are available in

Re: [2/3] hwmon: (ibmpowernv): Add support to read 64 bit sensors

2018-05-25 Thread Michael Ellerman
On Mon, 2018-05-07 at 10:25:37 UTC, Shilpasri G Bhat wrote: > The firmware has supported for reading sensor values of size u32. > This patch adds support to use newer firmware functions which allows > to read the sensors of size u64. > > Signed-off-by: Shilpasri G Bhat

Re: [1/3] powernv: opal-sensor: Add support to read 64bit sensor values

2018-05-25 Thread Michael Ellerman
On Mon, 2018-05-07 at 10:25:36 UTC, Shilpasri G Bhat wrote: > This patch adds support to read 64-bit sensor values. This method is > used to read energy sensors and counters which are of type u64. > > Signed-off-by: Shilpasri G Bhat Applied to powerpc next,

Re: [v9] powerpc/mm: Only read faulting instruction when necessary in do_page_fault()

2018-05-25 Thread Michael Ellerman
On Wed, 2018-05-23 at 08:53:22 UTC, Christophe Leroy wrote: > Commit a7a9dcd882a67 ("powerpc: Avoid taking a data miss on every > userspace instruction miss") has shown that limiting the read of > faulting instruction to likely cases improves performance. > > This patch goes further into this

Re: [v2] powerpc/xmon: Also setup debugger hooks when single-stepping

2018-05-25 Thread Michael Ellerman
On Wed, 2018-05-23 at 18:00:54 UTC, Michal Suchanek wrote: > When single-stepping kernel code from xmon without a debug hook enabled > the kernel crashes. This can happen when kernel starts with xmon on > crash disabled but xmon is entered using sysrq. > > Call force_enable_xmon when

Re: powerpc/8xx: fix invalid register expression in head_8xx.S

2018-05-25 Thread Michael Ellerman
On Thu, 2018-05-24 at 11:02:06 UTC, Christophe Leroy wrote: > New binutils generate the following warning > > AS arch/powerpc/kernel/head_8xx.o > arch/powerpc/kernel/head_8xx.S: Assembler messages: > arch/powerpc/kernel/head_8xx.S:916: Warning: invalid register expression > > This patch

Re: powerpc/mm: Use instruction symbolic names in store_updates_sp()

2018-05-25 Thread Michael Ellerman
On Wed, 2018-05-23 at 07:04:04 UTC, Christophe Leroy wrote: > Use symbolic names defined in asm/ppc-opcode.h > instead of hardcoded values. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks.

Re: [3/3] hwmon: (ibmpowernv) Add energy sensors

2018-05-25 Thread Michael Ellerman
On Mon, 2018-05-07 at 10:25:38 UTC, Shilpasri G Bhat wrote: > This patch exports the accumulated power numbers of each power > sensor maintained by OCC. > > Signed-off-by: Shilpasri G Bhat > Acked-by: Guenter Roeck Applied to powerpc next,

Re: [v2] powerpc/sparse: fix plain integer as NULL pointer warning

2018-05-25 Thread Michael Ellerman
On Fri, 2018-04-13 at 18:41:43 UTC, Mathieu Malaterre wrote: > Trivial fix to remove the following sparse warnings: > > arch/powerpc/kernel/module_32.c:112:74: warning: Using plain integer as > NULL pointer > arch/powerpc/kernel/module_32.c:117:74: warning: Using plain integer as > NULL

Re: [v2] xmon: Use __printf markup to silence compiler

2018-05-25 Thread Michael Ellerman
On Sun, 2018-03-25 at 09:06:47 UTC, Mathieu Malaterre wrote: > Update the other prototype declarations in asm/xmon.h. > > Silence warnings (triggered at W=1) by adding relevant __printf attribute. > Move #define at bottom of the file to prevent conflict with gcc attribute. > > Solve the original

Re: [08/19] powerpc/tau: Make some function static

2018-05-25 Thread Michael Ellerman
On Thu, 2018-03-22 at 20:19:54 UTC, Mathieu Malaterre wrote: > These functions can all be static, make it so. Fix warnings treated as > errors with W=1: > > arch/powerpc/kernel/tau_6xx.c:53:6: error: no previous prototype for > ‘set_thresholds’ [-Werror=missing-prototypes] >

Re: [v3,19/19] powerpc/tau: Synchronize function prototypes and body

2018-05-25 Thread Michael Ellerman
On Wed, 2018-04-04 at 20:10:28 UTC, Mathieu Malaterre wrote: > Some function prototypes and body for Thermal Assist Units were not in > sync. Update the function definition to match the existing function > declaration found in `setup-common.c`, changing an `int` return type to a > `u32` return

Re: [PATCH] cpuidle/powernv : init all present cpus for deep states

2018-05-25 Thread Michael Ellerman
Akshay Adiga writes: > Yes this needs to be sent to stable. > > Fixes: d405a98c ("powerpc/powernv: Move cpuidle related code from setup.c > to new file") Is that really the commit that introduced the bug? :) Seems like it's more likely this one: Fixes:

Re: [PATCH] cpuidle/powernv : init all present cpus for deep states

2018-05-25 Thread Michael Ellerman
Akshay Adiga writes: > Init all present cpus for deep states instead of "all possible" cpus. > Init fails if the possible cpu is gaurded. Resulting in making only > non-deep states available for cpuidle/hotplug. This is basically the opposite of what we just did

Re: [PATCH 2/2] i2c: opal: don't check number of messages in the driver

2018-05-25 Thread Michael Ellerman
Wolfram Sang writes: > Since commit 1eace8344c02 ("i2c: add param sanity check to > i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the > I2C core does this check now. We can remove it here. > > Signed-off-by: Wolfram Sang > --- > >

Re: [PATCH 1/2] selftests/powerpc: Add ptrace tests for Protection Key registers

2018-05-25 Thread Michael Ellerman
Thiago Jung Bauermann <bauer...@linux.ibm.com> writes: > Michael Ellerman <m...@ellerman.id.au> writes: >> Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: >>> tools/testing/selftests/powerpc/include/reg.h | 1 + >>> tools/testi

Re: [v2,04/19] powerpc/kvm: Prefer fault_in_pages_readable function

2018-05-24 Thread Michael Ellerman
On Wed, 2018-03-28 at 19:58:11 UTC, Mathieu Malaterre wrote: > Directly use fault_in_pages_readable instead of manual __get_user code. Fix > warning treated as error with W=1: > > arch/powerpc/kernel/kvm.c:675:6: error: variable ‘tmp’ set but not used > [-Werror=unused-but-set-variable] >

Re: [PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-05-23 Thread Michael Ellerman
gt; - ((bp->attr.bp_addr + bp->attr.bp_len - 1) >> 10)) > + if ((attr->bp_addr >> 10) != > + ((attr->bp_addr + attr->bp_len - 1) >> 10)) > return -EINVAL; This will conflict with my next branch, but it should be easy enough to resolve. > } > - if (info->len > > - (length_max - (info->address & HW_BREAKPOINT_ALIGN))) > + if (hw->len > > + (length_max - (hw->address & HW_BREAKPOINT_ALIGN))) > return -EINVAL; > return 0; > } Acked-by: Michael Ellerman <m...@ellerman.id.au> cheers

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-23 Thread Michael Ellerman
Frederic Weisbecker writes: > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > index 6e28d28..51320c2 100644 > --- a/kernel/events/hw_breakpoint.c > +++ b/kernel/events/hw_breakpoint.c > @@ -424,19 +443,22 @@ static int

Re: [PATCH 10/13] atomics/powerpc: define atomic64_fetch_add_unless()

2018-05-23 Thread Michael Ellerman
eter Zijlstra <pet...@infradead.org> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > --- > arch/powerpc/include/asm/a

Re: [PATCH 07/14] powerpc: Add support for restartable sequences

2018-05-23 Thread Michael Ellerman
Mathieu Desnoyers writes: > - On May 23, 2018, at 4:14 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: ... >> >> Hi Boqun, >> >> I tried your patch in a ppc64 le environment, and it does not survive boot >> with CONFIG_DEBUG_RSEQ=y. init gets

Re: powerpc: fix spelling mistake: "Discharching" -> "Discharging"

2018-05-21 Thread Michael Ellerman
On Fri, 2018-05-18 at 09:31:17 UTC, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in battery_charging array > > Signed-off-by: Colin Ian King Applied to powerpc next, thanks.

Re: [v2,1/2] powerpc: avoid an unnecessary test and branch in longjmp()

2018-05-21 Thread Michael Ellerman
On Tue, 2018-04-17 at 17:08:16 UTC, Christophe Leroy wrote: > Doing the test at exit of the function avoids an unnecessary > test and branch inside longjmp() > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks.

Re: powerpc: get rid of PMD_PAGE_SIZE() and _PMD_SIZE

2018-05-21 Thread Michael Ellerman
On Wed, 2018-05-16 at 06:58:57 UTC, Christophe Leroy wrote: > PMD_PAGE_SIZE() is nowhere used and _PMD_SIZE is only > used by PMD_PAGE_SIZE(). > > This patch removes them. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks.

  1   2   3   4   5   6   7   8   9   10   >