Re: [PATCH 1/2] [RFC] media: rcar-vin: send a V4L2 event to vdev if no frame captured after a timeout

2020-07-02 Thread Michael Rodin
Hi Niklas, On Wed, Jul 01, 2020 at 12:17:10AM +0200, Niklas Söderlund wrote: > Hi Michael, > > Thanks for your RFC. Thanks your your feedback! > On 2020-06-19 19:46:10 +0200, Michael Rodin wrote: > > Data flow from an upstream subdevice can stop permanently due to: > &

[PATCH 2/2] [RFC] media: rcar-vin: make timeout of the irq timer configurable via v4l2 control

2020-06-19 Thread Michael Rodin
to change the timeout before the start of streaming. Signed-off-by: Michael Rodin --- drivers/media/platform/rcar-vin/rcar-core.c | 17 - drivers/media/platform/rcar-vin/rcar-dma.c | 14 +- drivers/media/platform/rcar-vin/rcar-vin.h | 5 + include/uapi/linux/rcar

[PATCH 1/2] [RFC] media: rcar-vin: send a V4L2 event to vdev if no frame captured after a timeout

2020-06-19 Thread Michael Rodin
to monitor, that rvin_irq() is capturing at least one frame within a IRQ_TIMEOUT_MS period. Otherwise send a new private v4l2 event to userspace. This event is exported to userspace via a new uapi header. Signed-off-by: Michael Rodin --- drivers/media/platform/rcar-vin/rcar-dma.c | 21

Re: [PATCH] media: rcar-vin: Move media_device_register to async completion

2020-06-17 Thread Michael Rodin
Hi Niklas and Steve, On Wed, Jun 17, 2020 at 12:56:46PM +0200, Niklas Söderlund wrote: > Hi Michael and Steve, > > On 2020-06-16 19:31:36 +0200, Michael Rodin wrote: > > From: Steve Longerbeam > > > > The media_device is registered during driver probe, befo

Re: [PATCH v7 1/2] media: rcar-csi2: Correct the selection of hsfreqrange

2020-06-17 Thread Michael Rodin
Hi Suresh, thanks for your work! It looks like your PHTW patch is missing: "[PATCH] rcar-vin: rcar-csi2: Select the correct PHTW register" -- Best Regards, Michael

[PATCH] media: rcar-vin: Move media_device_register to async completion

2020-06-16 Thread Michael Rodin
bound (the rcar-csi2 subdevices and and video capture devices) before .link_notify can be called. Signed-off-by: Steve Longerbeam Signed-off-by: Michael Rodin --- drivers/media/platform/rcar-vin/rcar-core.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers

Re: [PATCH v6] media: rcar-csi2: Correct the selection of hsfreqrange

2020-06-12 Thread Michael Rodin
s) | > > > --- > > > | 197.125-244.125 | 220 | > > > --- > > > > > > Fixes: 769afd212b16 ("media: rcar-csi2: add Renesas R-Car MIPI CS

Re: [PATCH] rcar-vin: rcar-csi2: Correct the selection of hsfreqrange

2020-06-05 Thread Michael Rodin
ed, May 27, 2020 at 06:16:07PM +0200, Michael Rodin wrote: > From: Suresh Udipi > > hsfreqrange should be chosen based on the calculated mbps which > is closer to the default bit rate and within the range as per > table[1]. But current calculation always selects first value which &

[PATCH] [media] v4l2-subdev.rst: correct information about v4l2 events

2020-05-27 Thread Michael Rodin
Remove description of non-existing v4l2_subdev.nevents and replace the undefined flag V4L2_SUBDEV_USES_EVENTS by the correct flag V4L2_SUBDEV_FL_HAS_EVENTS, which is already documented in v4l2_subdev.flags Fixes: commit 02adb1cc765b ("[media] v4l: subdev: Events support") Signed-off-b

[PATCH] rcar-vin: rcar-csi2: Select the correct PHTW register

2020-05-27 Thread Michael Rodin
the default bit rate which is nearest to the calculated value. [1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.12] Fixes: ADIT v4.14 commit 9e568b895ee0 ("media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver") Signed-off-by: Suresh Udipi Signed-off-by: Mic

[PATCH] rcar-vin: rcar-csi2: Correct the selection of hsfreqrange

2020-05-27 Thread Michael Rodin
: add Renesas R-Car MIPI CSI-2 receiver driver") Signed-off-by: Suresh Udipi Signed-off-by: Michael Rodin --- drivers/media/platform/rcar-vin/rcar-csi2.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/dri

Re: [PATCH v5] media: rcar-csi2: Correct the selection of hsfreqrange

2020-05-27 Thread Michael Rodin
On Tue, May 12, 2020 at 11:30:45PM +0200, Niklas Söderlund wrote: > Hi Michael and Suresh, > > Thanks for your comments Michael. > > On 2020-05-04 17:01:22 +0200, Michael Rodin wrote: > > Hello Suresh, Niklas, > > > > I think that we should not cha

Re: [PATCH v5] media: rcar-csi2: Correct the selection of hsfreqrange

2020-05-04 Thread Michael Rodin
Hello Suresh, Niklas, I think that we should not change the structs for PHTW register configuration, because there are no "max" values in the table "PHTW Set Values" from the Renesas Hardware Manual. The patch looks just wrong. A major issue is also that the Hardware Manual does not provide any

[PATCH] arch/x86/entry/vsyscall/vsyscall_gtod.c: remove __read_mostly from vclocks_used

2018-06-04 Thread Michael Rodin
[2]. [1] perf stat --all-cpus --group --event="{mem:addr/4:rw:k,mem:addr/4:w:k}" [2] https://www.sra.uni-hannover.de/Research/CADOS/ Signed-off-by: Michael Rodin --- arch/x86/entry/vsyscall/vsyscall_gtod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/vs

[PATCH] arch/x86/entry/vsyscall/vsyscall_gtod.c: remove __read_mostly from vclocks_used

2018-06-04 Thread Michael Rodin
[2]. [1] perf stat --all-cpus --group --event="{mem:addr/4:rw:k,mem:addr/4:w:k}" [2] https://www.sra.uni-hannover.de/Research/CADOS/ Signed-off-by: Michael Rodin --- arch/x86/entry/vsyscall/vsyscall_gtod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/vs