Re: [PATCH] Unexport LANG env variable

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 14:40 Alexey Brodkin napsal(a): > In those cases when we parse output of standard utilities like readelf > etc we rely on a particular sentences. For example for ARC we extract > an entry-point from vmlinux like that: > -->8 > readelf -h vmlin

Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro

2017-06-14 Thread Michal Marek
ro name from Add cc-option-no-kbuild to cc-option-raw >>> - Added compiler as parameter to the macro >>> - Reworked cc-option to make use of cc-option-raw >>> - Updated commit message >>> >>> scripts/Kbuild.include | 9 +++-- >>> 1 file changed, 7

Re: [PATCH v2] Kbuild: tiny correction on `make help`

2017-06-14 Thread Michal Marek
Dne 14.6.2017 v 09:08 Cao jin napsal(a): > > > On 06/14/2017 09:15 AM, Masahiro Yamada wrote: >> 2017-06-13 18:52 GMT+09:00 Cao jin : >>> Yamada-san, >>> >>> I have a question on the current top level Makefile. There are >>> following lines, I have trouble to understand "firstword x$(MAKEFLAGS)

Re: [PATCH 1/3] kbuild: Add cc-option-no-kbuild macro

2017-06-13 Thread Michal Marek
On 2017-06-13 02:55, Matthias Kaehlcke wrote: > cc-option uses KBUILD_CFLAGS and KBUILD_CPPFLAGS when it determines > whether an option is supported or not. This is fine for options used to > build the kernel itself, however some components like the x86 boot code > use a different set of flags. >

Re: [PATCH] kbuild: simplify silent build (-s) detection

2017-05-19 Thread Michal Marek
On 2017-05-19 06:28, Masahiro Yamada wrote: > This allows to detect -s option without checking GNU Make version. > > As commit e36aaea28972 ("kbuild: Fix silent builds with make-4") > pointed out, GNU Make 4.x changed the way/order it presents the > command line options into MAKEFLAGS. > > In Mak

Re: [RFC] Increase Minimal GNU Make version for Linux Kernel from 3.80 to 3.81

2017-05-03 Thread Michal Marek
On 2017-05-03 08:46, Masahiro Yamada wrote: > Hello Linus and Kbuild developers. > > > Documentation/process/changes.rst says the minimal version > of GNU Make is 3.80, but actually building the kernel > with this version has been broken for a long time. > > Specifically, it got broken by commit

Re: [RFC-b PATCH] kbuild: redefine __FILE__ as relative path from $(srctree) if possible

2017-04-21 Thread Michal Marek
Dne 21.4.2017 v 21:36 Masahiro Yamada napsal(a): > Since Kbuild runs in the objtree, __FILE__ can be a very long path > depending of $(srctree). > > Commit 9da0763bdd82 ("kbuild: Use relative path when building in a > subdir of the source tree") made the situation better for cases > where objtree

Re: [PATCH 0/5] Fix dead URLs to ftp.kernel.org

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 07:47 SeongJae Park napsal(a): > URLs to `ftp.kernel.org` exist here and there though `ftp.kernel.org` is > already dead [0]. This patchset fixes those URLs to use `www.kernel.org` > instead. > > The change is splitted into multiple patches for independent review and merge > of ea

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-27 Thread Michal Marek
Dne 27.3.2017 v 09:58 Sebastian Andrzej Siewior napsal(a): > On 2017-03-24 13:35:40 [+0800], Chao Peng wrote: >> > kernel kernel sizetime in decompress_kernel > compressed (gzip)3.3M 53ms > uncompressed 14M3ms >> Exact

Re: [PATCH] x86/boot: Support uncompressed kernel

2017-03-24 Thread Michal Marek
On 2017-03-23 13:51, Chao Peng wrote: > Compressed kernel has its own drawback: uncompressing takes time. Even > though the time is short enough to ignore for most cases but for cases that > time is critical this is still a big number. In our on-going optimization > for kernel boot time, the measur

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path

2017-03-15 Thread Michal Marek
Dne 15.3.2017 v 15:51 Tom Rini napsal(a): > I found https://patchwork.kernel.org/patch/9442211/ today and I see that > it was brought up again just before I sent my patch. I just want to > point out that 9442211 doesn't address arm, arc, and sh and they will > still not have a functional rpm build

Re: Kbuild maintainership

2017-03-13 Thread Michal Marek
On 2017-03-11 06:45, Masahiro Yamada wrote: > Hi Michal, > > 2017-03-10 19:15 GMT+09:00 Michal Marek : >> On 2017-03-10 10:17, Stephen Rothwell wrote: >>> I assume that I will get a request to change the kbuild-current and >>> kbuilt trees in linux-next soon. In

Re: [PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 18:58 Will Deacon napsal(a): > Hi Michael, > > On Tue, Nov 22, 2016 at 10:34:29PM +0100, Michal Marek wrote: >> The KBUILD_IMAGE variable is used by the rpm and deb-pkg targets, which >> expect it to point to the image file in the build directory. The >

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
On 2017-03-10 10:17, Stephen Rothwell wrote: > I assume that I will get a request to change the kbuild-current and > kbuilt trees in linux-next soon. In the meantime, should I remove the > current ones? There is one genksyms fix in kbuild.git#kbuild which is not in mainline. Masahiro, can you ple

Re: Kbuild maintainership

2017-03-10 Thread Michal Marek
Dne 10.3.2017 v 03:07 Masahiro Yamada napsal(a): > Hello Kbuild contributors, > > > As you may notice, Michal has been busy since the beginning > of this year, and it has been getting difficult for him to > work on Kbuild on his regular basis. Yes, that's unfortunately the case. > Michal sent

[GIT PULL] kbuild fix for v4.10-rc3

2017-01-06 Thread Michal Marek
: Clear any CPP defines before declaring the functions (2017-01-05 12:57:42 +0100) Michal Marek (1): asm-prototypes: Clear any CPP defines before declaring the functions include/asm-generic/asm-prototypes.h | 6 ++ 1 file

Re: [PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-05 Thread Michal Marek
On 2017-01-05 10:33, Borislav Petkov wrote: > On Tue, Jan 03, 2017 at 03:14:54PM +0100, Michal Marek wrote: >> During real build, this manifests itself by genksyms segfaulting. >> >> Reported-by: Borislav Petkov > > ... -and-tested-by: ... > > For all three. &g

[PATCH 2/3] genksyms: Fix segfault with invalid declarations

2017-01-03 Thread Michal Marek
scripts/genksyms/genksyms The last one was a real-life bug with include/asm-generic/asm-prototypes.h on x86_64. Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.y | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/genksyms/parse.y b/scripts/genks

[PATCH 3/3] genksyms: Regenerate parser

2017-01-03 Thread Michal Marek
Regenerate the parser after 309d4cef4667 ("genksyms: Fix segfault with invalid declarations"). Reported-by: Reported-by: Borislav Petkov Signed-off-by: Michal Marek --- scripts/genksyms/parse.tab.c_shipped | 474 +-- 1 file changed, 234 insertio

[PATCH 1/3] asm-prototypes: Clear any CPP defines before declaring the functions

2017-01-03 Thread Michal Marek
); ^ ... During real build, this manifests itself by genksyms segfaulting. Reported-by: Borislav Petkov Cc: Adam Borowski Signed-off-by: Michal Marek --- include/asm-generic/asm-prototypes.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/asm

Re: default 0 if KASAN expression not working in kbuild

2016-12-19 Thread Michal Marek
On 2016-12-15 19:09, Nikolay Borisov wrote: > Hello, > > I was doing some kasan-related debugging and when I enabled it I started > getting warnings for large stackframes. So CONFIG_FRAME_WARN has : > > int "Warn for stack frames larger than (needs gcc 4.4)" > range 0 8192 > default 0 if

Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

2016-12-19 Thread Michal Marek
On 2016-12-18 13:35, Cheah Kok Cheong wrote: > If no duplicates found, inform user. > > Signed-off-by: Cheah Kok Cheong > --- > scripts/checkincludes.pl | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl > index 97b2c61..2

[GIT PULL] kconfig update for v4.10-rc1

2016-12-17 Thread Michal Marek
Hi Linus, please pull these kconfig bits for v4.10-rc1: - make xconfig gui fixes - make nconfig fix for options with long prompts - fix make nconfig warning when pkg-config forces -D_GNU_SOURCE Michal The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1 (

[GIT PULL] kbuild updates for v4.10-rc1

2016-12-17 Thread Michal Marek
): x86/kbuild: enable modversions for symbols exported from asm Ard Biesheuvel (1): scripts/kallsyms: remove last remnants of --page-offset option Michal Marek (1): genksyms: Regenerate parser Nicholas Piggin (7): kbuild: kallsyms allow 3-pass generation if symbols size has

[GIT PULL] kbuild misc updates for v4.10-rc1

2016-12-17 Thread Michal Marek
arm64 producing host-arch debs Andrew F. Davis (1): Coccinelle: Add misc/boolconv.cocci Anton Tikhomirov (1): kbuild/mkspec: avoid using brace expansion Michal Marek (1): Merge branch 'kbuild/rc-fixes' into kbuild/misc Vaishali Thakkar (3): Coccinelle: misc: Impr

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:15, Michal Marek wrote: > A minimal example would be > > t1.c: > struct s1; > struct s2 { > int i; > } > struct s3 { > struct s1 *ptr1; > struct s2 *ptr2; > } > void foo(struct s3*); > EXPORT_SYMBOL(foo); > > t2.c:

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 11:02, Dodji Seketeli wrote: > Michal Marek a écrit: > >>> Libabigail does a "whole binary" analysis of types. >>> >>> So, consider the point of use of the type 'struct s1*'. Even if 'struct >>> s' is

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:36, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> A minimal example would be >> >> t1.c: >> struct s1; >> struct s2 { >> int i; >> } >> struct s3 { >> struct s1 *ptr1; >>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 09:58, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> Does the abidiff tool handle the case when an exported symbol is moved >> between .c files? This is always a mess with genksyms, because the two >> .c files have different includ

Re: [PATCH v3 1/1] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 11.12.2016 v 02:09 Adam Borowski napsal(a): > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be

Re: [PATCH 2/2] kbuild: make modversion for exported asm symbols more convivial

2016-12-13 Thread Michal Marek
Dne 8.12.2016 v 05:24 Nicolas Pitre napsal(a): > Rather than having an asm-prototypes.h file where C prototypes for exported > asm symbols are centralized, let's have some macros that can be used > directly in the code where those symbols are exported for genksyms > consumption. Either the prototy

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 9.12.2016 v 23:46 Dodji Seketeli napsal(a): > Hello, > > Nicholas Piggin a écrit: > > [...] > >> That said, a dwarf based checker tool should be able to do as good a job >> (maybe a bit better because report is very informative and it may pick up >> compiler alignments or padding options).

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-12 Thread Michal Marek
Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a): > Michal Marek writes: >> Please use the KBUILD_OUTPUT variable and not O. > Well, I can't as far as I know. I tried, see below ... > > Explanation : > - if I add just below the line "j=${i/\.[cS]/\.o}" the

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check doesn't work, and >> COMP

Re: [PATCH] scripts/kallsyms: remove last remnants of --page-offset option

2016-12-11 Thread Michal Marek
On Fri, Nov 25, 2016 at 08:43:55AM +, Ard Biesheuvel wrote: > On 28 October 2016 at 18:09, Ard Biesheuvel wrote: > > The implementation of the --page-offset kallsyms command line option has > > been removed, so remove it from the usage string as well. > > > > Signed-off-by: Ard Biesheuvel > >

Re: [PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

2016-12-11 Thread Michal Marek
On Wed, Nov 23, 2016 at 02:12:58PM +0530, Vaishali Thakkar wrote: > Few changes to improve the results given by the irqf_oneshot.cocci: > > - Change in the matching rules to eliminate false postives in the > patch mode > - Change in the context mode to eliminate false postives in the > context

Re: [PATCH] kbuild: cmd_export_list: tighten the sed script

2016-12-11 Thread Michal Marek
On Wed, Nov 16, 2016 at 07:28:39PM -0500, Nicolas Pitre wrote: > > When LTO is used, some ___ksymtab_string sections are seen by this sed > script, creating lines containing a single ) such as: > > EXPORT(foo) > ) > ) > EXPORT(bar) > > Let's make it so the + character is also required for any li

Re: [PATCH] kbuild/mkspec: avoid using brace expansion

2016-12-11 Thread Michal Marek
On Tue, Oct 25, 2016 at 06:00:44PM +0900, Anton Tikhomirov wrote: > Brace expansion might not work properly if _buildshell RPM macro > points to a shell other than bash. Particularly, with _bulidshell > defined to /bin/dash it leads to broken build and source symlinks. > > Signed-off-by: Anton Tik

Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

2016-12-10 Thread Michal Marek
On Mon, Oct 17, 2016 at 11:52:24AM -0500, Andrew F. Davis wrote: > Add a script to check for unneeded conversions to bool. > > Signed-off-by: Andrew F. Davis > Acked-by: Julia Lawall Applied to kbuild.git#misc, thanks. Michal

Re: [PATCH v4] Fixes for compiling with clang

2016-12-02 Thread Michal Marek
On 2016-12-01 19:13, Peter Foley wrote: > On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek wrote: >> Dne 28.11.2016 v 07:44 Peter Foley napsal(a): >> This adds new -Wno-* options also for the gcc case, is there a reason >> for this? Also, the -Wno-missing-field-initi

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 14:58, Arnd Bergmann wrote: > On Tuesday, November 29, 2016 9:14:46 AM CET Linus Torvalds wrote: >> On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds >> wrote: >>> >>> So quite frankly, I don't want to make our kernel sources worse due to >>> broken shit tools getting something wrong t

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 05:13, Don Zickus wrote: > Sorry for chiming in late, but yes RHEL is a big user of MODVERSIONS for our > kabi protection work. Despite our best intentions we still have lots of > partners and customers that provide value-add out-of-tree drivers to their > customers. These module bu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 04:39, Nicholas Piggin wrote: > On Thu, 01 Dec 2016 02:35:54 + > Ben Hutchings wrote: >> As I understand it, genksyms incorporates the definitions of a >> function's parameter and return types - not just their names - and all >> the types they refer to, recursively. So a structu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > - ret

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it >> >> The actual logic

Re: [PATCH v4] Fixes for compiling with clang

2016-11-29 Thread Michal Marek
Dne 28.11.2016 v 07:44 Peter Foley napsal(a): > Fix reversed conditional checking if HOSTCC is clang. > Suppress warnings about unsupported optimization options. > Suppress warnings about unused functions, as they are generated for > every module and are therefore far too spammy. > Disable clang's

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-29 Thread Michal Marek
On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote: > [Dropped Yann.] > > On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote: > > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote: > > > The Makefile does not specify -D_GNU_SOURCE. Are you add

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri, 2016-11-25 at 10:01 -0800, Linu

Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning

2016-11-28 Thread Michal Marek
Dne 27.11.2016 v 17:28 Cheah Kok Cheong napsal(a): > Fix below warning when make nconfig is run initially > or after make clean. > > HOSTCC scripts/kconfig/nconf.o > scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined > #define _GNU_SOURCE > ^ > :0:0: note: this is the location of t

Re: [PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-25 Thread Michal Marek
Dne 25.11.2016 v 13:12 Riku Voipio napsal(a): > On 22 November 2016 at 23:34, Michal Marek wrote: >> The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so >> the workaround is no longer needed. >> >> Signed-off-by: Michal Marek >> --- > Thanks

Re: [PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-25 Thread Michal Marek
Dne 23.11.2016 v 20:40 Alexey Brodkin napsal(a): >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index 19cce226d1a8..44ef35d33956 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -123,9 +123,9 @@ libs-y += arch/arc/lib/ $(LIBGCC) >> boot:= arch/

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
Dne 24.11.2016 v 11:03 Nicholas Piggin napsal(a): > On Thu, 24 Nov 2016 10:32:12 +0100 > Michal Marek wrote: > >> On 2016-11-24 08:53, Nicholas Piggin wrote: >>> On Thu, 24 Nov 2016 08:36:39 +0100 >>> Greg Kroah-Hartman wrote: >>> >>>&

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
On 2016-11-24 08:53, Nicholas Piggin wrote: > On Thu, 24 Nov 2016 08:36:39 +0100 > Greg Kroah-Hartman wrote: > >> On Thu, Nov 24, 2016 at 06:20:26PM +1100, Nicholas Piggin wrote: >>> But still, modversions is pretty complicated for what it gives us. It sends >>> preprocessed C into a C parser tha

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-24 Thread Michal Marek
asm/asm-prototypes.h >> create mode 100644 include/asm-generic/asm-prototypes.h > > Michal, I'm quite unhappy about how the offending commit that broke > modversions > for essentially _everyone_ who does more complex modular builds on x86 ended > up > upstream: >

[PATCH 1/6] arm64: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
rinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm64/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 3635b8662724..80b6866bcacb 100644 --- a/arch/arm64/Mak

[PATCH 5/6] unicore32: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
uetao Signed-off-by: Michal Marek --- arch/unicore32/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/Makefile b/arch/unicore32/Makefile index b6f5c4c1eaf9..98a5ca43ae87 100644 --- a/arch/unicore32/Makefile +++ b/arch/unicore32/Makefile @@ -43,9 +43,9 @@

[PATCH 2/6] arm: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
King Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arm/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 6be9ee148b78..f3fa2cafca15 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Mak

[PATCH 4/6] sh: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Sato Cc: Rich Felker Cc: linux...@vger.kernel.org Signed-off-by: Michal Marek --- arch/sh/Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sh/Makefile b/arch/sh/Makefile index 336f33a419d9..280bbff12102 100644 --- a/arch/sh/Makefile +++ b/arch/sh/Mak

[PATCH 3/6] arc: Use full path in KBUILD_IMAGE definition

2016-11-22 Thread Michal Marek
Gupta Cc: linux-snps-...@lists.infradead.org Signed-off-by: Michal Marek --- arch/arc/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/Makefile b/arch/arc/Makefile index 19cce226d1a8..44ef35d33956 100644 --- a/arch/arc/Makefile +++ b/arch/arc/Makefile @@ -

[PATCH 6/6] deb-pkg: Remove the KBUILD_IMAGE workaround

2016-11-22 Thread Michal Marek
The arch Makefile are fixed to set KBUILD_IMAGE to the full patch, so the workaround is no longer needed. Signed-off-by: Michal Marek --- scripts/package/builddeb | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index

[GIT PULL] kbuild post v4.9-rc1 fixes

2016-11-18 Thread Michal Marek
Hi Linus, Here are some regression fixes for kbuild: - modversion support for exported asm symbols (Nick Piggin). The affected architectures need separate patches adding asm-prototypes.h. - fix rebuilds of lib-ksyms.o (Nick Piggin) - -fno-PIE builds (Sebastian Siewior and Borislav Petkov). This

Re: [PATCH -v1.1] kbuild: Steal gcc's pie from the very beginning

2016-11-15 Thread Michal Marek
our lowest supported gcc version is 3.2 right now. > > Signed-off-by: Borislav Petkov > Cc: sta...@vger.kernel.org > Cc: Ben Hutchings > Cc: Michal Marek > Cc: Sebastian Andrzej Siewior Thanks, applied to kbuild.git#rc-fixes. Michal

Re: Kbuild: CC= handling broken for tools/

2016-11-11 Thread Michal Marek
On 2016-11-11 12:23, Jiri Slaby wrote: > Hi, > > I am trying a new gcc with new warnings enabled: > > make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o > EXTRA_CFLAGS='-Wimplicit-fallthrough=3' Note that EXTRA_CFLAGS is a makefile variable read by both kbuild and tools/build apparently. > > But t

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-09 Thread Michal Marek
Dne 9.11.2016 v 07:10 Ingo Molnar napsal(a): > > * Michal Marek wrote: > >> On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: >>> Debian started to build the gcc with -fPIE by default so the kernel >>> build ends before it starts proper

Re: [PATCH 1/3] kbuild: add -fno-PIE

2016-11-08 Thread Michal Marek
On Fri, Nov 04, 2016 at 07:39:38PM +0100, Sebastian Andrzej Siewior wrote: > Debian started to build the gcc with -fPIE by default so the kernel > build ends before it starts properly with: > |kernel/bounds.c:1:0: error: code model kernel does not support PIC mode > > Also add to KBUILD_AFLAGS due

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-04 Thread Michal Marek
On 2016-11-03 20:48, SF Markus Elfring wrote: >> You could define an xprintf() macro that checks if the return value >> is < 0 and simply calls perror() and exit(1) in such case. > > Does such a macro belong to any general header file from the Linux > software library? No. Michal

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf e

Re: scripts/basic/bin2c: Complete error handling in main()

2016-11-03 Thread Michal Marek
Dne 2.11.2016 v 19:46 SF Markus Elfring napsal(a): >> I like the code as is. > > Do you really prefer to ignore important return values in the discussed > function? You could define an xprintf() macro that checks if the return value is < 0 and simply calls perror() and exit(1) in such case. Mic

Re: [PATCH] kbuild: add %/built-in.o target in top Makefile

2016-11-01 Thread Michal Marek
On 2016-10-24 14:45, Wei Yang wrote: > diff --git a/Makefile b/Makefile > index addb235..546998e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1627,6 +1627,8 @@ endif > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > %.symtypes: %.c prepare scripts FORCE > $(Q)$(MAKE) $

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-11-01 Thread Michal Marek
On 2016-10-18 03:34, Nicholas Piggin wrote: > Hi Adam, > > Thanks, this is looking good. powerpc will be able to use the generic > header. > > On Tue, 18 Oct 2016 02:16:26 +0200 > Adam Borowski wrote: > >> On Mon, Oct 17, 2016 at 02:22:34PM +0200, Mathieu OTHACEHE wrote: +#include +#

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Michal Marek
Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the 'extern' declarations out

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-10-19 Thread Michal Marek
Dne 18.10.2016 v 03:34 Nicholas Piggin napsal(a): > We should probably just bring all these arch patches through the > kbuild tree. > > I'm sorry for the breakage: I didn't realize it broke the build with > some configs, otherwise I would have given Michal a heads up before > his pull request, and

[GIT PULL] kbuild misc changes for 4.9-rc1

2016-10-14 Thread Michal Marek
Hi Linus, just a few patches on the kbuild.git#misc branch this time: - New Coccinelle patch by Nicholas Mc Guire - Existing patch fixes by Julia Lawall - Minor comment fix by Markus Elfring The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-0

[GIT PULL] kbuild changes for v4.9-rc1

2016-10-14 Thread Michal Marek
definitions sparc: move exports to definitions [sparc] unify 32bit and 64bit string.h sparc32: debride memcpy.S a bit ia64: move exports to definitions Alexey Dobriyan (1): fixdep: faster CONFIG_ search Michal Marek (2): kbuild: Regenerate genksyms lexer

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 11.10.2016 v 15:10 Michal Marek napsal(a): > Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): >> Hi all, >> >> On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot >> wrote: >>> >>> FYI, we noticed the following commit: >>> >>

Re: [lkp] [x86] 784d5699ed: kmsg.ip_tables:no_symbol_version_for_copy_from_user

2016-10-11 Thread Michal Marek
Dne 30.9.2016 v 01:26 Stephen Rothwell napsal(a): > Hi all, > > On Tue, 20 Sep 2016 10:55:32 +0800 kernel test robot > wrote: >> >> FYI, we noticed the following commit: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> commit 784d5699eddc55878627da20d3fe0c8542e

Re: [PATCH] Coccinelle: flag conditions with no effect

2016-10-11 Thread Michal Marek
On Sat, Oct 08, 2016 at 05:51:45PM +0200, Nicholas Mc Guire wrote: > Report code constructs where the if and else branch are functionally > identical. In cases where this is intended it really should be > documented - most reported cases probably are bugs. > > Signed-off-by: Nicholas Mc Guire A

Re: [PATCH] scripts/coccicheck: Update reference for the corresponding documentation

2016-10-11 Thread Michal Marek
On Fri, Oct 07, 2016 at 08:30:48PM +0200, Julia Lawall wrote: > > > On Fri, 7 Oct 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Fri, 7 Oct 2016 16:06:15 +0200 > > > > Use the current name (in a comment at the beginning of this script) for > > the file which was converted t

Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case

2016-10-01 Thread Michal Marek
Dne 21.9.2016 v 17:48 Julia Lawall napsal(a): > Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so > only allow this flag in the original code. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc. Thanks, Michal

Re: [PATCH] Coccinelle: pm_runtime: ensure relevance of pm_runtime reports

2016-10-01 Thread Michal Marek
Dne 22.9.2016 v 10:28 Julia Lawall napsal(a): > pm_runtime.cocci starts with one rule that searches for a variety of > functions calls, followed by various rules that report errors. Previously, > the only connection between the first rule and the rest was to check that > the first rule had matched

Re: [PATCH 0/2] Moving runnable code from Documentation (last 2 patches)

2016-10-01 Thread Michal Marek
an (2): >>> samples: move blackfin gptimers-example from Documentation >>> Doc: update 00-INDEX files to reflect the runnable code move >>> >> >> Hi Jon and Michal, >> >> Do these patches look good to you? I can get these into 4.9-rc1 >> with your Ack. > > Seems good to me. > > Acked-by: Jonathan Corbet Likewise, Acked-by: Michal Marek Michal

[PATCH] initramfs: Escape colons in depfile

2016-09-23 Thread Michal Marek
Special characters are problematic in depfiles, but we can fix colons easily. Reported-by: Florian Fainelli Signed-off-by: Michal Marek --- scripts/gen_initramfs_list.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/gen_initramfs_list.sh b/scripts

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-23 Thread Michal Marek
On 2016-09-19 22:00, Florian Fainelli wrote: > On 09/13/2016 12:24 AM, Michal Marek wrote: >> On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: >>> Hi, >>> >>> I have a root filesystem embedding filenames that look like these: >>> >&g

Re: linux-next: build failure after merge of the kbuild tree

2016-09-22 Thread Michal Marek
On 2016-09-15 08:08, Stephen Rothwell wrote: > Hi all, > > After merging the dax-misc tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages': > (___ksymtab+clear_pages+0x0): undefined reference to `clea

Re: Build failure in -next due to 'kbuild: allow archs to select link dead code/data elimination'

2016-09-22 Thread Michal Marek
On 2016-09-14 21:48, Guenter Roeck wrote: > On Wed, Sep 14, 2016 at 12:30:04PM +1000, Nicholas Piggin wrote: >> commit 0ae28be83b4d6cd03ef5b481487d042f2b91954e >> Author: Nicholas Piggin >> Date: Wed Sep 14 12:24:03 2016 +1000 >> >> kbuild: -ffunction-sections fix for archs with conflicting

Re: gen_initramfs_list.sh escaping problem or stale dependency file?

2016-09-13 Thread Michal Marek
On Mon, Sep 12, 2016 at 05:12:15PM -0700, Florian Fainelli wrote: > Hi, > > I have a root filesystem embedding filenames that look like these: > > /lib/data/: > > these are essentially files that can be matched against an USB > vendor/product id in an easy way. > > Now, the fun part is that thi

Re: linux-next: manual merge of the kbuild tree with Linus' tree

2016-09-12 Thread Michal Marek
On 2016-09-12 04:53, Nicholas Piggin wrote: > Question, what is the best way to merge dependent patches? Considering > they will need a good amount of architecture testing, I think they will > have to go via arch trees. But it also does not make sense to merge these > kbuild changes upstream first,

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-07 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for target

Re: [PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-04 Thread Michal Marek
Dne 3.9.2016 v 21:58 Borislav Petkov napsal(a): > From: Borislav Petkov > > When building a bindeb-pkg target into an object output dir, i.e., O=, I > get: > > find: `scripts/gcc-plugins': No such file or directory > /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for target

[GIT PULL] make deb-pkg fix

2016-09-04 Thread Michal Marek
Hi Linus, Please pull this fix from make deb-pkg. The bug got introduced in v4.8-rc1. Thanks, Michal The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/

Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs

2016-08-26 Thread Michal Marek
On 2016-06-13 15:04, Arnd Bergmann wrote: > The genksyms helper in the kernel cannot parse a type definition > like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS > helper, causing the following EXPORT_SYMBOL() statement to be ignored > when computing the crcs, and triggering a w

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-25 Thread Michal Marek
On 2016-08-25 09:43, Christoph Hellwig wrote: > The idea seems useful, but I reallt don't like the 'reverse-engineering' > approach. > > If we want to this properly from the ground up we should just split out > our CONFIG_ SYMBOLS into > > MODULE_* - builds exactly one module (tristate, or maybe

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-24 Thread Michal Marek
On 2016-08-23 23:32, Luis R. Rodriguez wrote: > On Fri, Aug 19, 2016 at 11:07:36AM +0200, Michal Marek wrote: >> On 2016-08-18 19:55, Luis R. Rodriguez wrote: >>> On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: >>> >>>> This patchset imple

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2016-08-19 Thread Michal Marek
On 2016-08-18 19:55, Luis R. Rodriguez wrote: > On Wed, Aug 17, 2016 at 09:26:58PM +0200, Cristina Moraru wrote: > >> This patchset implements dynamic pegging of kconfig symbol >> into driver modinfo section > > First a little bit of motivation here helps, so let me try to > help fill in some gap

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-19 Thread Michal Marek
On 2016-08-19 07:09, Stephen Rothwell wrote: > Hi Nick, > > On Fri, 19 Aug 2016 13:38:54 +1000 Stephen Rothwell > wrote: >> >> On Thu, 18 Aug 2016 11:09:48 +1000 Nicholas Piggin wrote: >>> >>> On Wed, 17 Aug 2016 14:59:59 +0200 >>> Michal Mar

Re: linux-next: build warnings after merge of the kbuild tree

2016-08-17 Thread Michal Marek
On 2016-08-17 03:44, Stephen Rothwell wrote: > Hi Michal, > > After merging the kbuild tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warnings: > > WARNING: 25 bad relocations > c0cf2570 R_PPC64_ADDR64__crc___arch_hweight16 [...] > Introduced by commit > >

Re: [PATCH] kbuild: do not add srctree to sysroot relative includes

2016-08-16 Thread Michal Marek
On 2016-08-16 13:40, Lars Persson wrote: > We need to filter out also -I=/path to allow sysroot relative > include paths in the makefiles of external modules. > > Signed-off-by: Lars Persson > --- > scripts/Kbuild.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH] builddeb: Skip gcc-plugins when not configured

2016-08-16 Thread Michal Marek
Dne 15.8.2016 v 19:36 Kees Cook napsal(a): > When attempting to build a Debian kernel package, the "scripts/gcc-plugins" > directory does not exist in the output tree unless CONFIG_GCC_PLUGINS=y. > To avoid errors when not defined, this wraps the failing "find" in a config > test. > > Reported-by:

Re: [RFC][PATCHSET v2] allowing exports in *.S

2016-08-15 Thread Michal Marek
Dne 16.8.2016 v 07:48 Michal Marek napsal(a): > Dne 2.8.2016 v 16:01 Michal Marek napsal(a): >> On 2016-02-03 22:19, Al Viro wrote: >>> Shortlog: >>> Al Viro (13): >>> [kbuild] handle exports in lib-y objects reliably >>> EXPORT_SYMBOL()

  1   2   3   4   5   6   7   8   9   10   >