Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-04-01 Thread Mika Westerberg
On Thu, Apr 01, 2021 at 09:22:02PM +0300, Andy Shevchenko wrote: > On Thu, Apr 01, 2021 at 09:06:17PM +0300, Mika Westerberg wrote: > > On Thu, Apr 01, 2021 at 06:43:11PM +0300, Andy Shevchenko wrote: > > > On Sat, Mar 13, 2021 at 10:45:57AM +0100, Henning Schild wrote: > >

Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-04-01 Thread Mika Westerberg
On Thu, Apr 01, 2021 at 06:43:11PM +0300, Andy Shevchenko wrote: > On Sat, Mar 13, 2021 at 10:45:57AM +0100, Henning Schild wrote: > > Am Mon, 8 Mar 2021 14:20:16 +0200 > > schrieb Andy Shevchenko : > > ... > > > > + * pci_p2sb_bar - Get Primary to Sideband bridge (P2SB) device BAR > > > + *

Re: [PATCH] resource: Prevent irqresource_disabled() from erasing flags

2021-03-30 Thread Mika Westerberg
Hi, On Tue, Mar 30, 2021 at 05:09:42PM +0200, Rafael J. Wysocki wrote: > On 3/29/2021 9:52 PM, Angela Czubak wrote: > > Do not overwrite flags as it leads to erasing triggering and polarity > > information which might be useful in case of hard-coded interrupts. > > This way the information can be

Re: [PATCH 1/2] thunderbolt: Fix a leak in tb_retimer_add()

2021-03-30 Thread Mika Westerberg
On Mon, Mar 29, 2021 at 09:07:18AM +0300, Dan Carpenter wrote: > After the device_register() succeeds, then the correct way to clean up > is to call device_unregister(). The unregister calls both device_del() > and device_put(). Since this code was only device_del() it results in > a memory

Re: [PATCH 1/2] thunderbolt: Fix a leak in tb_retimer_add()

2021-03-29 Thread Mika Westerberg
On Mon, Mar 29, 2021 at 11:54:05AM -0300, Jason Gunthorpe wrote: > On Mon, Mar 29, 2021 at 05:43:23PM +0300, Mika Westerberg wrote: > > > The nvm is a separate (physical Linux) device that gets added under this > > one. It cannot be added before AFAICT. > > Hum,

Re: [PATCH 1/2] thunderbolt: Fix a leak in tb_retimer_add()

2021-03-29 Thread Mika Westerberg
Hi, On Mon, Mar 29, 2021 at 10:02:20AM -0300, Jason Gunthorpe wrote: > On Mon, Mar 29, 2021 at 09:07:18AM +0300, Dan Carpenter wrote: > > After the device_register() succeeds, then the correct way to clean up > > is to call device_unregister(). The unregister calls both device_del() > > and

Re: Re: [PATCH] thunderbolt: Fix a double put in tb_cfg_read_raw

2021-03-23 Thread Mika Westerberg
On Tue, Mar 23, 2021 at 10:30:16PM +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > -原始邮件- > > 发件人: "Mika Westerberg" > > 发送时间: 2021-03-23 22:06:47 (星期二) > > 收件人: "Lv Yunlong" > > 抄送: andreas.noe...@gmail.com,

Re: [PATCH] thunderbolt: Fix a double put in tb_cfg_read_raw

2021-03-23 Thread Mika Westerberg
Hi, On Mon, Mar 22, 2021 at 08:15:12PM -0700, Lv Yunlong wrote: > In tb_cfg_read_raw, req is allocated by tb_cfg_request_alloc() > with an initial reference. Before calling tb_cfg_request_sync(), > there is no refcount inc operation. tb_cfg_request_sync() > calls tb_cfg_request(..,req,..) and if

Re: [PATCH] PCI: PM: Do not read power state in pci_enable_device_flags()

2021-03-17 Thread Mika Westerberg
l...@gmail.com/ > Reported-by: Maximilian Luz > Tested-by: Maximilian Luz > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg

Re: [PATCH v1 1/1] pinctrl: intel: Show the GPIO base calculation explicitly

2021-03-08 Thread Mika Westerberg
ko I think this needs stable tag too. Acked-by: Mika Westerberg

Re: [PATCH v1 1/1] pinctrl: intel: No need to disable IRQs in the handler

2021-03-04 Thread Mika Westerberg
isabling IRQ part in the handler. > > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg

Re: [PATCH v1 1/3] gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk

2021-03-02 Thread Mika Westerberg
On Tue, Mar 02, 2021 at 05:09:24PM +0200, Andy Shevchenko wrote: > On Tue, Mar 02, 2021 at 03:48:43PM +0100, Linus Walleij wrote: > > On Thu, Feb 25, 2021 at 5:33 PM Andy Shevchenko > > wrote: > > > > > On some systems the ACPI tables has wrong pin number and instead of > > > having a relative

Re: [PATCH v1] watchdog: wdat: add param. to start wdog on module insertion

2021-02-19 Thread Mika Westerberg
Hi, On Thu, Feb 18, 2021 at 05:32:00PM +0100, Flavio Suligoi wrote: > Add the parameter "start_enable" to start the watchdog > directly on module insertion. > > In an embedded system, for some applications, the watchdog > must be activated as soon as possible. > > In some embedded x86 boards

Re: [PATCH] watchdog: wdat_wdg: fix typo

2021-02-16 Thread Mika Westerberg
On Tue, Feb 16, 2021 at 03:17:27PM +0100, Flavio Suligoi wrote: > Fix the following typo: > > "recommeded" --> "recommended" > "firmare"--> "firmware" > > Signed-off-by: Flavio Suligoi Reviewed-by: Mika Westerberg

Re: [PATCH] ACPI: property: Fix fwnode string properties matching

2021-02-12 Thread Mika Westerberg
uot;device property: Move FW type specific functionality to > FW specific files") > Reported-by: Calvin Johnson > Cc: 4.13+ # 4.13+ > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg

Re: [v4] PCI: Avoid unsync of LTR mechanism configuration

2021-02-04 Thread Mika Westerberg
for hot-remove/hot-add >-before restoring device's DEVCTL2 register when restore device state > > Signed-off-by: Mingchuang Qiao Reviewed-by: Mika Westerberg

Re: [v3] PCI: Avoid unsync of LTR mechanism configuration

2021-02-03 Thread Mika Westerberg
On Wed, Feb 03, 2021 at 10:14:01AM +0800, Mingchuang Qiao wrote: > Hi, > > On Mon, 2021-02-01 at 13:32 +0200, Mika Westerberg wrote: > > Hi, > > > > On Fri, Jan 29, 2021 at 03:11:37PM +0800, mingchuang.q...@mediatek.com > > wrote: > > > From: Ming

Re: [v3] PCI: Avoid unsync of LTR mechanism configuration

2021-02-01 Thread Mika Westerberg
Hi, On Fri, Jan 29, 2021 at 03:11:37PM +0800, mingchuang.q...@mediatek.com wrote: > From: Mingchuang Qiao > > In bus scan flow, the "LTR Mechanism Enable" bit of DEVCTL2 register is > configured in pci_configure_ltr(). If device and bridge both support LTR > mechanism, the "LTR Mechanism

Re: [v2] PCI: Avoid unsync of LTR mechanism configuration

2021-01-28 Thread Mika Westerberg
Hi, On Thu, Jan 28, 2021 at 06:05:31PM +0800, mingchuang.q...@mediatek.com wrote: > From: Mingchuang Qiao > > In bus scan flow, the "LTR Mechanism Enable" bit of DEVCTL2 register is > configured in pci_configure_ltr(). If device and bridge both support LTR > mechanism, the "LTR Mechanism

Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt

2021-01-28 Thread Mika Westerberg
Hi Lee, On Wed, Jan 27, 2021 at 11:25:42AM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 1 small set required for Thunderbolt. Pretty good! > > Lee

Re: [PATCH V2 01/12] thunderbolt: dma_port: Check 'dma_port_flash_write_block()'s return value

2021-01-28 Thread Mika Westerberg
warning: variable ‘ret’ set but not > used [-Wunused-but-set-variable] > > Cc: Andreas Noever > Cc: Michael Jamet > Cc: Mika Westerberg > Cc: Yehezkel Bernat > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones Applied, thanks!

Re: [PATCH 05/12] thunderbolt: pa: Demote non-conformant kernel-doc headers

2021-01-28 Thread Mika Westerberg
On Thu, Jan 28, 2021 at 08:23:30AM +, Lee Jones wrote: > On Wed, 27 Jan 2021, Mika Westerberg wrote: > > > On Wed, Jan 27, 2021 at 04:13:20PM +, Lee Jones wrote: > > > On Wed, 27 Jan 2021, Andy Shevchenko wrote: > > > > > > > On Wed

Re: [PATCH 05/12] thunderbolt: pa: Demote non-conformant kernel-doc headers

2021-01-27 Thread Mika Westerberg
On Wed, Jan 27, 2021 at 04:13:20PM +, Lee Jones wrote: > On Wed, 27 Jan 2021, Andy Shevchenko wrote: > > > On Wednesday, January 27, 2021, Lee Jones wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/thunderbolt/path.c:476: warning: Function parameter or

Re: [PATCH 01/12] thunderbolt: dma_port: Remove unused variable 'ret'

2021-01-27 Thread Mika Westerberg
Hi, On Wed, Jan 27, 2021 at 04:19:16PM +, Lee Jones wrote: > On Wed, 27 Jan 2021, Andy Shevchenko wrote: > > > On Wednesday, January 27, 2021, Lee Jones wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/thunderbolt/dma_port.c: In function

Re: [RFC 3/3] thunderbolt: build kunit tests without structleak plugin

2021-01-27 Thread Mika Westerberg
Hi Arnd, On Mon, Jan 25, 2021 at 01:45:28PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The structleak plugin causes the stack frame size to grow immensely: > > drivers/thunderbolt/test.c:1529:1: error: the frame size of 1176 bytes is > larger than 1024 bytes

Re: [PATCH] ACPI / device_sysfs: Prefer "compatible" modalias

2021-01-22 Thread Mika Westerberg
are present, use the latter > one to ensure there's only one MODALIAS. > > Reference: https://github.com/systemd/systemd/pull/18163 > Cc: AceLan Kao > Cc: "Rafael J. Wysocki" > Cc: Greg Kroah-Hartman > Cc: Andy Shevchenko > Suggested-by: Mika Westerberg > Fixes: 8765c

Re: [PATCH v2] PCI: Re-enable downstream port LTR if it was previously enabled

2021-01-22 Thread Mika Westerberg
Jan 19, 2021 at 04:14:10PM +0300, Mika Westerberg wrote: > > > PCIe r5.0, sec 7.5.3.16 says that the downstream ports must reset the > > > LTR enable bit if the link goes down (port goes DL_Down status). Now, if > > > we had LTR previously enabled and the PCIe e

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-21 Thread Mika Westerberg
On Thu, Jan 21, 2021 at 02:22:43PM +0800, Kai-Heng Feng wrote: > On Tue, Jan 19, 2021 at 6:34 PM Greg Kroah-Hartman > wrote: > > > > On Tue, Jan 19, 2021 at 11:41:59AM +0200, Andy Shevchenko wrote: > > > On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > > > > On Tue, Jan 19, 2021

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Mika Westerberg
On Mon, Jan 18, 2021 at 03:26:28PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 18, 2021 at 04:12:38PM +0200, Mika Westerberg wrote: > > Hi, > > > > On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > > > CC Mika and Andy. > > > > &g

Re: Multiple MODALIAS= in uevent file confuses userspace

2021-01-18 Thread Mika Westerberg
Hi, On Mon, Jan 18, 2021 at 02:50:33PM +0100, Rafael J. Wysocki wrote: > CC Mika and Andy. > > On Mon, Jan 18, 2021 at 8:27 AM Kai-Heng Feng > wrote: > > > > On Sat, Jan 9, 2021 at 12:25 AM Kai-Heng Feng > > wrote: > > > > > > Commit 8765c5ba19490 ("ACPI / scan: Rework modalias creation when >

Re: [PATCH] thunderbolt: Constify static attribute_group structs

2021-01-11 Thread Mika Westerberg
On Sat, Jan 09, 2021 at 12:09:19AM +0100, Rikard Falkeborn wrote: > The only usage of these is to put their addresses in arrays of pointers > to const attribute_groups. Make them const to allow the compiler to put > them in read-only memory. > > Signed-off-by: Rikard Falkeborn Applied to

Re: [RFT][PATCH v1 0/3] ACPI: scan: Defer enumeration of devices with significant dependencies

2020-12-17 Thread Mika Westerberg
ndlers supplied by the drivers of other > devices. > > This allows the OpRegion suppliers to be probed and start working before the > devices depending on them are enumerated. For the whole series, Reviewed-by: Mika Westerberg

Re: [PATCH net-next] net: thunderbolt: convert comma to semicolon

2020-12-09 Thread Mika Westerberg
On Wed, Dec 09, 2020 at 09:38:52PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Acked-by: Mika Westerberg

Re: linux-next: manual merge of the drm tree with the pci tree

2020-12-08 Thread Mika Westerberg
Hi, On Tue, Dec 08, 2020 at 01:27:54PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/vga/vga_switcheroo.c > > between commit: > > 99efde6c9bb7 ("PCI/PM: Rename pci_wakeup_bus() to pci_resume_bus()") > > from the

Re: [PATCH 00/12] thunderbolt: USB4 NVM upgrade improvements & Maple Ridge support

2020-11-30 Thread Mika Westerberg
On Thu, Nov 19, 2020 at 06:55:11PM +0300, Mika Westerberg wrote: > Hi all, > > This series improves the USB4 router NVM upgrade functionality and adds > support for USB4 router operations proxy implemented by recent Intel > Thunderbolt firmware connection manager. The last pat

Re: [PATCH v1 2/2] PM: ACPI: Refresh wakeup device power configuration every time

2020-11-25 Thread Mika Westerberg
igned-off-by: Rafael J. Wysocki > Reported-by: Kai-Heng Feng > Tested-by: Kai-Heng Feng Reviewed-by: Mika Westerberg

Re: [PATCH v1 1/2] PM: ACPI: PCI: Drop acpi_pm_set_bridge_wakeup()

2020-11-25 Thread Mika Westerberg
o, use wakeup enable reference counting for > all devices, not just for bridges, so drop the last argument from > __acpi_device_wakeup_enable() and __acpi_pm_set_device_wakeup(), > which causes acpi_pm_set_device_wakeup() and > acpi_pm_set_bridge_wakeup() to become identical, so dr

Re: How to enable auto-suspend by default

2020-11-23 Thread Mika Westerberg
On Mon, Nov 23, 2020 at 02:54:19PM +0100, Hans de Goede wrote: > Hi, > > On 11/11/20 3:31 PM, Mika Westerberg wrote: > > On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/10/20 6:25 PM, Mika Westerberg wrote: >

Re: [PATCH v2] docs: ACPI: enumeration: add PCI hierarchy representation

2020-11-20 Thread Mika Westerberg
and also to analyze the PCI bus topology of the board. > > This patch, with a practical example, show how to do this. > > Signed-off-by: Flavio Suligoi Reviewed-by: Mika Westerberg

[PATCH 03/12] thunderbolt: Log adapter numbers in decimal in path activation/deactivation

2020-11-19 Thread Mika Westerberg
This makes it consistent with other debug logs that already are using decimal number for adapters (ports). Signed-off-by: Mika Westerberg --- drivers/thunderbolt/path.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt

[PATCH 04/12] thunderbolt: Keep the parent runtime resumed for a while on device disconnect

2020-11-19 Thread Mika Westerberg
-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c index beee6e6b8b6e..635b949fb1d6 100644 --- a/drivers/thunderbolt/icm.c +++ b/drivers/thunderbolt/icm.c @@ -870,7 +870,13

[PATCH 02/12] thunderbolt: Log which connection manager implementation is used

2020-11-19 Thread Mika Westerberg
This makes it easier to figure out whether the driver is using firmware or software based connection manager implementation. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 2 ++ drivers/thunderbolt/tb.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/thunderbolt

[PATCH 06/12] thunderbolt: Perform USB4 router NVM upgrade in two phases

2020-11-19 Thread Mika Westerberg
it to the userspace accordingly. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/switch.c | 20 -- drivers/thunderbolt/tb.h | 1 + drivers/thunderbolt/tb_regs.h | 1 + drivers/thunderbolt/usb4.c| 75 +++ 4 files changed, 77 insertions(+), 20 deletions

[PATCH 11/12] thunderbolt: Add USB4 router operation proxy for firmware connection manager

2020-11-19 Thread Mika Westerberg
in icm_usb4_switch_nvm_authenticate_status() if available. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 214 -- drivers/thunderbolt/tb_msgs.h | 28 + 2 files changed, 232 insertions(+), 10 deletions(-) diff --git a/drivers/thunderbolt/icm.c b

[PATCH 07/12] thunderbolt: Pass metadata directly to usb4_switch_op()

2020-11-19 Thread Mika Westerberg
We are going to make usb4_switch_op() to match better the corresponding firmware (ICM) USB4 router operation proxy interface, so that we can use either based on the connection manager implementation. For this reason pass metadata directly to usb4_switch_op(). Signed-off-by: Mika Westerberg

[PATCH 05/12] thunderbolt: Return -ENOTCONN when ERR_CONN is received

2020-11-19 Thread Mika Westerberg
This allows the calling code to distinguish if the error was due to ERR_CONN (adapter is disconneced or disabled) or something else. Will be needed in USB4 router NVM update in the following patch. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/ctl.c | 3 +++ 1 file changed, 3

[PATCH 08/12] thunderbolt: Pass TX and RX data directly to usb4_switch_op()

2020-11-19 Thread Mika Westerberg
interface. Then make usb4_switch_op() and usb4_switch_op_data() call it with correct set of parameters and update the callers accordingly. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/usb4.c | 85 +- 1 file changed, 48 insertions(+), 37 deletions

[PATCH 09/12] thunderbolt: Add connection manager specific hooks for USB4 router operations

2020-11-19 Thread Mika Westerberg
, if provided, get called instead of the native USB4 router operation. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/tb.h | 13 ++ drivers/thunderbolt/usb4.c | 50 +- 2 files changed, 57 insertions(+), 6 deletions(-) diff --git a/drivers/thunderbolt

[PATCH 10/12] thunderbolt: Move constants for USB4 router operations to tb_regs.h

2020-11-19 Thread Mika Westerberg
We are going to use these in subsequent patch so make them available outside of usb4.c. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/tb_regs.h | 13 + drivers/thunderbolt/usb4.c| 12 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 12/12] thunderbolt: Add support for Intel Maple Ridge

2020-11-19 Thread Mika Westerberg
Maple Ridge is first discrete USB4 host controller from Intel. It comes with firmware based connection manager and the flows are similar as used in Intel Titan Ridge. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 11 +++ drivers/thunderbolt/nhi.h | 1 + 2 files changed

[PATCH 01/12] thunderbolt: Move max_boot_acl field to correct place in struct icm

2020-11-19 Thread Mika Westerberg
This makes the kernel-doc to match the ordering and also this is better place for it, not between upstream_port and vnd_cap that are used together. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/icm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 00/12] thunderbolt: USB4 NVM upgrade improvements & Maple Ridge support

2020-11-19 Thread Mika Westerberg
from Intel. This also includes a couple of minor cleanups and improvements around debug logging. Mika Westerberg (12): thunderbolt: Move max_boot_acl field to correct place in struct icm thunderbolt: Log which connection manager implementation is used thunderbolt: Log adapter numbers

Re: [PATCH v3] Documentation: ACPI: explain how to use gpio-line-names

2020-11-12 Thread Mika Westerberg
; Signed-off-by: Flavio Suligoi > Reviewed-by: Andy Shevchenko Reviewed-by: Mika Westerberg

Re: [PATCH v2] pinctrl: intel: Fix Jasperlake HOSTSW_OWN offset

2020-11-12 Thread Mika Westerberg
t's > owned by ACPI. > > Fixes: e278dcb7048b1 ("pinctrl: intel: Add Intel Jasper Lake pin controller > support") > Cc: sta...@vger.kernel.org > Signed-off-by: Evan Green Acked-by: Mika Westerberg

Re: How to enable auto-suspend by default

2020-11-11 Thread Mika Westerberg
On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote: > Hi, > > On 11/10/20 6:25 PM, Mika Westerberg wrote: > > On Tue, Nov 10, 2020 at 04:02:33PM +, Limonciello, Mario wrote: > >>> > >>> On Tue, Nov 10, 2020 at 11:57:07AM

Re: How to enable auto-suspend by default

2020-11-10 Thread Mika Westerberg
rnel module. > > Given we're effectively ending up with the combination of runtime PM turned > on by udev rules, do we need something like this for that ID: > > https://github.com/torvalds/linux/commit/6a7c533d4a1854f54901a065d8c672e890400d8a > > @Mika Westerberg should 808

Re: [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support

2020-10-29 Thread Mika Westerberg
Hi, I think the $subject should say "Alder Lake-S" as this is for -S variant. On Mon, Oct 26, 2020 at 09:25:52PM +0200, Andy Shevchenko wrote: > This driver adds pinctrl/GPIO support for Intel Alder Lake SoC. The > GPIO controller is based on the next generation GPIO hardware but still >

Re: [PATCH v3] thunderbolt: Add the missed ida_simple_remove() in ring_request_msix()

2020-10-26 Thread Mika Westerberg
On Thu, Oct 15, 2020 at 04:40:53PM +0800, Jing Xiangfeng wrote: > ring_request_msix() misses to call ida_simple_remove() in an error path. > Add a label 'err_ida_remove' and jump to it. > > Fixes: 046bee1f9ab8 ("thunderbolt: Add MSI-X support") > Signed-off-by: Jing Xiangfeng Applied to

Re: [PATCH] thunderbolt: use kobj_to_dev()

2020-09-22 Thread Mika Westerberg
On Tue, Sep 22, 2020 at 08:18:13PM +0800, Wang Qing wrote: > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing Thanks but I have already queued a similar patch from Tian Tao:

Re: [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names()

2020-09-17 Thread Mika Westerberg
et_names(). Add an appropriate > check for this use-case. > > Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for > device properties") > Reported-by: Anders Roxell > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko > Te

Re: [PATCH v2 0/3] gpiolib: generalize GPIO line names property

2020-09-09 Thread Mika Westerberg
zewski (3): > device: property: add helpers to count items in string arrays > gpiolib: generalize devprop_gpiochip_set_names() for device properties > gpiolib: unexport devprop_gpiochip_set_names() The series looks good to me, Reviewed-by: Mika Westerberg

Re: [PATCH v2] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-25 Thread Mika Westerberg
he need to avoid unwanted interactions > between runtime PM and system-wide device suspend callbacks. > > Fixes: 1e2ef05bb8cf8 ("PM: Limit race conditions between runtime PM and > system sleep (v2)") > Reported-by: Mika Westerberg I guess the more correct here is Report

Re: [PATCH] ACPI: OSL: Prevent acpi_release_memory() from returning too early

2020-08-24 Thread Mika Westerberg
rning. > > Fixes: 1757659d022b ("ACPI: OSL: Implement deferred unmapping of ACPI memory") > Reported-by: Kenneth R. Crudup > Signed-off-by: Rafael J. Wysocki Reviewed-by: Mika Westerberg

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Mika Westerberg
On Mon, Aug 24, 2020 at 03:38:39PM +0200, Rafael J. Wysocki wrote: > BTW, does the patch make the issue at hand go away? I asked the folks who have this particular hardware to try it out as I don't have access to this one. Hopefully we get the results back soon and once we do, I'll let you know.

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-24 Thread Mika Westerberg
Hi, On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. > > As BIOS may not be able to program the config space for devices under > VMD domain, ASPM needs to be programmed manually

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-24 Thread Mika Westerberg
On Mon, Aug 24, 2020 at 11:31:40AM +0200, Arnd Bergmann wrote: > On Mon, Aug 24, 2020 at 11:15 AM Mika Westerberg > wrote: > > On Mon, Aug 24, 2020 at 11:08:33AM +0200, Arnd Bergmann wrote: > > > On Mon, Aug 24, 2020 at 10:22 AM Mika Westerberg > > > wrote: > &g

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-24 Thread Mika Westerberg
On Mon, Aug 24, 2020 at 11:08:33AM +0200, Arnd Bergmann wrote: > On Mon, Aug 24, 2020 at 10:22 AM Mika Westerberg > wrote: > > On Sat, Aug 22, 2020 at 06:06:03PM +0200, Arnd Bergmann wrote: > > > On Wed, Aug 19, 2020 at 11:11 AM Mika Westerberg > > > >

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Mika Westerberg
Hi, On Fri, Aug 21, 2020 at 03:34:42PM -0400, Alan Stern wrote: > This means that the code could be simplified to just: > > pm_runtime_barrier(dev); > > Will this fix the reported bug? It seems likely to me that the actual > problem with the failure scenario in the patch description was

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-24 Thread Mika Westerberg
On Sat, Aug 22, 2020 at 06:06:03PM +0200, Arnd Bergmann wrote: > On Wed, Aug 19, 2020 at 11:11 AM Mika Westerberg > wrote: > > On Wed, Aug 19, 2020 at 10:38:24AM +0200, Arnd Bergmann wrote: > > > On Wed, Aug 19, 2020 at 8:57 AM Mika Westerberg > > > wrote: >

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-19 Thread Mika Westerberg
On Wed, Aug 19, 2020 at 10:38:24AM +0200, Arnd Bergmann wrote: > On Wed, Aug 19, 2020 at 8:57 AM Mika Westerberg > wrote: > > > > On Tue, Aug 18, 2020 at 12:55:59PM -0300, Daniel Gutson wrote: > > > > If you care about other (malicious) code writing to the d

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-19 Thread Mika Westerberg
On Tue, Aug 18, 2020 at 12:55:59PM -0300, Daniel Gutson wrote: > > If you care about other (malicious) code writing to the driver, please > > explain > > what the specific attack scenario is that you are worried about, and > > why you think > > this is not sufficient. What code would be able to

Re: linux-next: build failure after merge of the thunderbolt tree

2020-08-10 Thread Mika Westerberg
Hi all, On Mon, Aug 10, 2020 at 09:10:53AM +1000, Stephen Rothwell wrote: > Hi Linus, > > On Sun, 9 Aug 2020 11:04:28 -0700 Linus Torvalds > wrote: > > > > On Sun, Aug 9, 2020 at 1:19 AM Stephen Rothwell > > wrote: > > > > > > I looks like the above report got lost along the way to you :-(

Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable

2020-08-04 Thread Mika Westerberg
es detected through the PCI driver > (intel-spi-pci) are not subject to this check since the configuration > takes place in intel-spi-pci which doesn't have an argument. > > This patch removes the code that attempts to turn the SPI chip writeable. > > Signed-off-by: Daniel Gutson Reviewed-by: Mika Westerberg

Re: [PATCH] Remove attempt by intel-spi-pci to turn the SPI flash chip writeable

2020-08-04 Thread Mika Westerberg
Hi, On Mon, Aug 03, 2020 at 10:44:49AM -0300, Daniel Gutson wrote: > Currently, the intel-spi-pci driver tries to unconditionally set > the SPI chip writeable. After discussing in the LKML, the original > author decided that it was better to remove the attempt. > > Context, the intel-spi has a

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-08-03 Thread Mika Westerberg
On Mon, Aug 03, 2020 at 09:58:23AM -0300, Daniel Gutson wrote: > On Mon, Aug 3, 2020 at 7:27 AM Mika Westerberg > wrote: > > > > On Mon, Aug 03, 2020 at 11:18:12AM +0100, Richard Hughes wrote: > > > On Mon, 3 Aug 2020 at 10:57, Mika Westerberg > > > wrote

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-08-03 Thread Mika Westerberg
On Mon, Aug 03, 2020 at 11:18:12AM +0100, Richard Hughes wrote: > On Mon, 3 Aug 2020 at 10:57, Mika Westerberg > wrote: > > I think instead of this we should simply make it so that the driver > > never tries to make the chip writable. > > I think this is a good

Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

2020-08-03 Thread Mika Westerberg
Hi, Sorry for the delay, I was on vacation. On Fri, Jul 24, 2020 at 06:28:53PM -0300, Daniel Gutson wrote: > Currently, intel-spi has a module argument that controls whether the driver > attempts to turn the SPI flash chip writeable. The default value > is FALSE (don't try to make it writeable).

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-24 Thread Mika Westerberg
On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote: > On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg > wrote: > > > > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > > > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > > > O

Re: [PATCH] mtd: spi-nor: intel-spi: Simulate WRDI command

2020-07-23 Thread Mika Westerberg
On Wed, Jul 22, 2020 at 03:18:50PM +, tudor.amba...@microchip.com wrote: > On 7/22/20 5:36 PM, Mika Westerberg wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi, > > > > On Wed, Jul 2

Re: [PATCH] mtd: spi-nor: intel-spi: Simulate WRDI command

2020-07-22 Thread Mika Westerberg
Hi, On Wed, Jul 22, 2020 at 02:28:30PM +, tudor.amba...@microchip.com wrote: > + Mika > > Hi, Mika, > > Would you please review the patch from below? Sure, there is minor comment below. > > Thanks! > > On 7/22/20 5:01 PM, Alexander Sverdlin wrote: > > EXTERNAL EMAIL: Do not click links

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-22 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > >> Sure thing. Also, feel free to let me know if you'd like access to one of > >> the &

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-22 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 02:24:19PM -0400, Lyude Paul wrote: > On Tue, 2020-07-21 at 12:00 -0400, Lyude Paul wrote: > > On Tue, 2020-07-21 at 18:27 +0300, Mika Westerberg wrote: > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > > > > Sure thing.

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-21 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > Sure thing. Also, feel free to let me know if you'd like access to one of the > systems we saw breaking with this patch - I'm fairly sure I've got one of them > locally at my apartment and don't mind setting up AMT/KVM/SSH Probably no

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-21 Thread Mika Westerberg
On Fri, Jul 17, 2020 at 09:52:09PM +0200, Lukas Wunner wrote: > On Fri, Jul 17, 2020 at 03:04:10PM -0400, Lyude Paul wrote: > > Isn't it possible to tell whether a PCI device is connected through > > thunderbolt or not? We could probably get away with just defaulting > > to 100ms for thunderbolt

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-21 Thread Mika Westerberg
Hi, [Sorry for the delay, I was on vacation] On Fri, Jul 17, 2020 at 01:32:10PM +0200, Karol Herbst wrote: > Filed at https://bugzilla.kernel.org/show_bug.cgi?id=208597 Thanks for reporting. I'll check your logs and try to figure if there is something we can do to make both nouveau and TBT

Re: [PATCH v3 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-07-01 Thread Mika Westerberg
On Tue, Jun 23, 2020 at 11:14:27AM -0500, Mario Limonciello wrote: > Currently updates to Thunderbolt and USB4 controllers are fully atomic > actions. When writing into the non-active NVM nothing gets flushed to > the hardware until authenticate is sent. > > There has been some desire to improve

Re: [PATCH][next] thunderbolt: ensure left shift of 512 does not overflow a 32 bit int

2020-07-01 Thread Mika Westerberg
On Tue, Jun 30, 2020 at 03:55:58PM +0100, Colin King wrote: > From: Colin Ian King > > The 32 bit int value 512 is being left shifted and then used in a context > that expects the expression to be a larger unsigned long. There may be > a potential integer overflow, so make 512 a UL before shift

Re: [PATCH] x86/resource: Do not exclude regions that are marked as MMIO in EFI memmap

2020-06-30 Thread Mika Westerberg
On Fri, Jun 26, 2020 at 05:43:44PM -0500, Bjorn Helgaas wrote: > On Mon, Mar 02, 2020 at 05:14:51PM +0300, Mika Westerberg wrote: > > Commit 4dc2287c1805 ("x86: avoid E820 regions when allocating address > > space") made the resource allocation code to avoid all regions t

Re: linux-next: build failure after merge of the thunderbolt tree

2020-06-30 Thread Mika Westerberg
On Tue, Jun 30, 2020 at 04:03:46PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the thunderbolt tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > > Caused by commit > > 54509f5005ca ("thunderbolt: Add KUnit tests for path walking") > > interacting

Re: [PATCH V2 1/2] PCI: Add ACPI StorageD3Enable _DSD support

2020-06-25 Thread Mika Westerberg
On Thu, Jun 25, 2020 at 01:30:53PM +0200, Rafael J. Wysocki wrote: > It is not necessary to call acpi_pci_find_companion() from > pci_acpi_storage_d3() as long as that function is required to be > called by the target device's driver probe or later. > > Ths acpi_pci_bridge_d3() case is different,

Re: [PATCH v2 2/2] thunderbolt: Add support for authenticate on disconnect

2020-06-23 Thread Mika Westerberg
d58a..dd565c378b40 100644 > --- a/Documentation/ABI/testing/sysfs-bus-thunderbolt > +++ b/Documentation/ABI/testing/sysfs-bus-thunderbolt > @@ -276,3 +276,16 @@ Date: Oct 2020 > KernelVersion: v5.9 > Contact: Mika Westerberg > Description: Retimer vendor identif

Re: [PATCH v2 1/2] thunderbolt: Add support for separating the flush to SPI and authenticate

2020-06-23 Thread Mika Westerberg
On Mon, Jun 22, 2020 at 01:57:57PM -0500, Mario Limonciello wrote: > This allows userspace to have a shorter period of time that the device > is unusable and to call it at a more convenient time. > > For example flushing the image may happen while the user is using the > machine and

Re: [PATCH 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-06-22 Thread Mika Westerberg
On Mon, Jun 22, 2020 at 04:41:35PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Mika Westerberg > > Sent: Monday, June 22, 2020 11:38 AM > > To: Limonciello, Mario > > Cc: Andreas Noever; Michael Jamet; Yehezkel Bernat;

Re: [PATCH 2/2] thunderbolt: Add support for authenticate on disconnect

2020-06-22 Thread Mika Westerberg
On Mon, Jun 22, 2020 at 09:30:35AM -0500, Mario Limonciello wrote: > Some external devices can support completing thunderbolt authentication > when they are unplugged. For this to work though, the link controller must > remain operational. > > The only device known to support this right now is

Re: [PATCH 1/2] thunderbolt: Add support for separating the flush to SPI and authenticate

2020-06-22 Thread Mika Westerberg
On Mon, Jun 22, 2020 at 09:30:34AM -0500, Mario Limonciello wrote: > This allows userspace to have a shorter period of time that the device > is unusable and to call it at a more convenient time. > > For example flushing the image may happen while the user is using the > machine and

Re: [PATCH 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-06-22 Thread Mika Westerberg
Hi Mario, On Mon, Jun 22, 2020 at 09:30:33AM -0500, Mario Limonciello wrote: > Currently updates to Thunderbolt and USB4 controllers are fully atomic > actions. When writing into the non-active NVM nothing gets flushed to > the hardware until authenticate is sent. > > There has been some desire

[PATCH RESEND] x86/resource: Do not exclude regions that are marked as MMIO in EFI memmap

2020-06-17 Thread Mika Westerberg
t is EFI_MEMORY_MAPPED_IO skip the clipping in that case. Reported-by: Benoit Grégoire Link: https://bugzilla.kernel.org/show_bug.cgi?id=206459 Signed-off-by: Mika Westerberg --- arch/x86/kernel/resource.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-)

Re: [PATCH 2/4] pci: set "untrusted" flag for truly external devices only

2020-06-16 Thread Mika Westerberg
On Mon, Jun 15, 2020 at 06:17:40PM -0700, Rajat Jain wrote: > The "ExternalFacing" devices (root ports) are still internal devices > that sit on the internal system fabric and thus trusted. Currently they > were being marked untrusted - likely as an unintended border case. It was actually

Re: [PATCH] thunderbolt: Improve USB4 config symbol help text

2020-06-15 Thread Mika Westerberg
On Tue, Jun 02, 2020 at 02:28:15PM +0200, Geert Uytterhoeven wrote: > Fix the spelling of "specification", and add a missing "the" article. > > Fixes: 690ac0d20d4022bb ("thunderbolt: Update Kconfig entries to USB4") > Signed-off-by: Geert Uytterhoeven Applied to thunderbolt.git/next, thanks!

Re: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout"

2020-06-11 Thread Mika Westerberg
read(from=1c0, len=40) > [ 23.784058] intel_spi_read(from=200, len=40) > [ 23.784058] intel_spi_read(from=200, len=40) > [ 25.625006] intel_spi_read(from=240, len=40) > [ 25.625006] intel_spi_read(from=240, len=40) > End MTD read > > Signed-off-by: Luis Alberto Herrera Acked-by: Mika Westerberg

  1   2   3   4   5   6   7   8   9   10   >