rc/os.cc#L158
Cc: Andrew Morton
Cc: Alexey Dobriyan
Cc: Andrey Konovalov
Cc: Alexander Potapenko
Cc: Vincenzo Frascino
Cc: Andrey Ryabinin
Cc: Catalin Marinas
Cc: Dmitry Vyukov
Cc: Marco Elver
Cc: Will Deacon
Cc: Eric W. Biederman
Cc: Song Bao Hua (Barry Song)
Cc: sta...@vger.kernel.org
On Thu, 2020-12-03 at 11:30 +, Catalin Marinas wrote:
> On Fri, Nov 27, 2020 at 01:07:38PM +0800, Miles Chen wrote:
> > Cc: Will Deacon
>
> That should be w...@kernel.org.
ok, I will fix it and submit v3
>
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.
On Thu, 2020-12-03 at 11:45 +, Vincenzo Frascino wrote:
> Hi Miles,
>
> On 11/27/20 5:07 AM, Miles Chen wrote:
> > When we try to visit the pagemap of a tagged userspace pointer, we find
> > that the start_vaddr is not correct because of the tag.
> > To fix it, w
os.cc#L158
Cc: Andrew Morton
Cc: Alexey Dobriyan
Cc: Andrey Konovalov
Cc: Alexander Potapenko
Cc: Vincenzo Frascino
Cc: Andrey Ryabinin
Cc: Catalin Marinas
Cc: Dmitry Vyukov
Cc: Marco Elver
Cc: Will Deacon
Cc: Eric W. Biederman
Cc: Song Bao Hua (Barry Song)
Cc: sta...@vger.kernel.org #
On Thu, 2020-11-26 at 11:10 +, Catalin Marinas wrote:
> Hi Miles,
>
> Could you please cc me and Andrey Konovalov on future versions of this
> patch (if any)?
>
> On Mon, 23 Nov 2020 at 08:47, Miles Chen wrote:
> > When we try to visit the pagemap of a tagged us
On Tue, 2020-11-24 at 12:32 -0600, Eric W. Biederman wrote:
> Miles Chen writes:
>
> > When we try to visit the pagemap of a tagged userspace pointer, we find
> > that the start_vaddr is not correct because of the tag.
> > To fix it, we should untag the usespace
On Thu, 2020-11-26 at 07:16 +, Song Bao Hua (Barry Song) wrote:
>
> > -Original Message-
> > From: Miles Chen [mailto:miles.c...@mediatek.com]
> > Sent: Monday, November 23, 2020 7:39 PM
> > To: Alexey Dobriyan ; Andrew Morton
> >
> > Cc: l
int len;
unsigned long end;
...
}
...
}
[1] https://github.com/stressapptest/stressapptest/blob/master/src/os.cc#L158
Signed-off-by: Miles Chen
---
fs/proc/task_mmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/proc/task_m
On Tue, 2020-10-27 at 09:11 +, Russell King - ARM Linux admin wrote:
> On Tue, Oct 27, 2020 at 03:45:12PM +0800, Miles Chen wrote:
> > On Fri, 2020-10-23 at 11:08 +0100, Russell King - ARM Linux admin wrote:
> > > On Fri, Oct 23, 2020 at 05:14:36PM +0800, Miles Chen w
On Fri, 2020-10-23 at 11:16 +0100, Russell King - ARM Linux admin wrote:
> On Fri, Oct 23, 2020 at 05:14:35PM +0800, Miles Chen wrote:
> > From: Minchan Kim
> >
> > To use bit 5 in page table as L_PTE_SPECIAL, we need a room for that.
> > It seems we don't need
On Fri, 2020-10-23 at 11:08 +0100, Russell King - ARM Linux admin wrote:
> On Fri, Oct 23, 2020 at 05:14:36PM +0800, Miles Chen wrote:
> > From: Minchan Kim
> >
> > This patch introduces L_PTE_SPECIAL and pte functions for supporting
> > get_user_pages_fast.
> &
On Fri, 2020-10-23 at 11:12 +0100, Russell King - ARM Linux admin wrote:
> On Fri, Oct 23, 2020 at 05:14:37PM +0800, Miles Chen wrote:
> > Since kernel no longer writes to the vector, try to replace
> > the vector mem type with read-only type and remove L_PTE_MT_VECTORS.
> &
to SHARED - Catalin
*
https://lkml.kernel.org/r/20180910165011.zcighyuabshsm...@armageddon.cambridge.arm.com
Miles Chen (2):
arm: mm: use strict p[gum]d types
arm: replace vector mem type with read-only type
Minchan Kim (2):
arm: mm: reordering memory type table
arm: mm: introduce
Horman
Cc: Minchan Kim
Cc: Suren Baghdasaryan
Signed-off-by: Minchan Kim
Signed-off-by: Miles Chen
---
arch/arm/include/asm/pgtable-2level.h | 21 +
arch/arm/mm/proc-macros.S | 4 ++--
2 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/arch/arm/
From: Minchan Kim
This patch introduces L_PTE_SPECIAL and pte functions for supporting
get_user_pages_fast.
Cc: Russell King
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Steve Capper
Cc: Minchan Kim
Cc: Suren Baghdasaryan
Signed-off-by: Minchan Kim
Signed-off-by: Miles Chen
---
arch/arm
]
mm/gup.c:2616:9: error: array initializer must be an initializer list
Fix some types errors in fixmap.h after using strict types.
Cc: Russell King
Cc: Catalin Marinas
Cc: Minchan Kim
Cc: Suren Baghdasaryan
Signed-off-by: Miles Chen
---
arch/arm/include/asm/fixmap.h | 6
ghdasaryan
Signed-off-by: Miles Chen
---
arch/arm/include/asm/pgtable-2level.h | 1 -
arch/arm/mm/mmu.c | 7 +++
arch/arm/mm/proc-macros.S | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm/include/asm/pgtable-2level.h
b/arch/arm/includ
When we try to visit the pagemap of a tagged userspace pointer, we find
that the start_vaddr is not correct because of the tag.
To fix it, we should untag the usespace pointers in pagemap_read().
Signed-off-by: Miles Chen
---
fs/proc/task_mmu.c | 4 ++--
1 file changed, 2 insertions(+), 2
: Christoph Hellwig
Cc: Rob Herring
Cc: Matthias Brugger
Cc: Joerg Roedel
Reviewed-by: Matthias Brugger
Signed-off-by: Miles Chen
---
Change since v4
- remove unnecessary data->enable_4GB = false, since it is kzalloc()ed.
Change since v3
- use lore.kernel.org links
- move "change since..
On Fri, 2020-09-04 at 11:42 +0200, Joerg Roedel wrote:
> On Mon, Aug 31, 2020 at 06:56:39PM +0800, Miles Chen wrote:
> > In previous discussion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> >
> > Check 4
: Christoph Hellwig
Cc: Rob Herring
Cc: Matthias Brugger
Signed-off-by: Miles Chen
---
Change since v4
- remove unnecessary data->enable_4GB = false, since it is kzalloc()ed.
Change since v3
- use lore.kernel.org links
- move "change since..." after "---"
Change since v2:
On Thu, 2020-08-27 at 20:27 +0100, Robin Murphy wrote:
> On 2020-08-27 06:31, Yong Wu wrote:
> > On Wed, 2020-08-26 at 16:56 +0800, Miles Chen wrote:
> >> In previous discussion [1] and [2], we found that it is risky to
> >> use max_pfn or totalram_pages to
: Christoph Hellwig
Cc: Rob Herring
Cc: Matthias Brugger
Signed-off-by: Miles Chen
---
Change since v3
- use lore.kernel.org links
- move "change since..." after "---"
Change since v2:
- determine compatible string by m4u_plat
- rebase to next-20200720
- add "---&qu
et: optimize the sockptr_t for unified kernel/user
address spaces") has been reverted, so I will not sent patch v2 for this
build error.
Miles
> url:
> https://github.com/0day-ci/linux/commits/Miles-Chen/net-untag-pointer-in-sockptr_is_kernel/20200811-18303
> base: https
On Tue, 2020-08-11 at 11:44 +, David Laight wrote:
> > On Tue, Aug 11, 2020 at 06:27:04PM +0800, Miles Chen wrote:
> > > From: Miles Chen
> > >
> > > sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell
> > > if the pointer is ker
From: Miles Chen
sockptr_is_kernel() uses (sockptr.kernel >= TASK_SIZE) to tell
if the pointer is kernel space or user space. When user space uses
the "top byte ignored" feature such as HWAsan, we must untag
the pointer before checking against TASK_SIZE.
sockptr_is_kernel() will
When we try to visit the pagemap of a tagged userspace pointer, we find
that the start_vaddr is not correct because of the tag.
To fix it, we should untag the usespace pointers in pagemap_read().
Signed-off-by: Miles Chen
---
fs/proc/task_mmu.c | 4 ++--
1 file changed, 2 insertions(+), 2
: Christoph Hellwig
Cc: Rob Herring
Cc: Matthias Brugger
Signed-off-by: Miles Chen
---
Change since v3
- use lore.kernel.org links
- move "change since..." after "---"
Change since v2:
- determine compatible string by m4u_plat
- rebase to next-20200720
- add "---&qu
On Wed, 2020-07-22 at 17:19 +0200, Matthias Brugger wrote:
>
> On 22/07/2020 16:19, Miles Chen wrote:
> > In previous discussion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> >
> > Check 4GB mode by rea
e_4GB only when has_4gb_mode
[1] https://lkml.org/lkml/2020/6/3/733
[2] https://lkml.org/lkml/2020/6/4/136
[3] https://lkml.org/lkml/2020/7/15/1147
Cc: Mike Rapoport
Cc: David Hildenbrand
Cc: Yong Wu
Cc: Yingjoe Chen
Cc: Christoph Hellwig
Cc: Rob Herring
Cc: Matthias Brugger
Signed-off-by:
On Wed, 2020-07-22 at 15:17 +0800, Miles Chen wrote:
> On Tue, 2020-07-21 at 23:19 +0200, Matthias Brugger wrote:
> >
> > On 21/07/2020 13:24, Yong Wu wrote:
> > > On Tue, 2020-07-21 at 11:40 +0200, Matthias Brugger wrote:
> > >>
> > >> On 21/07/2
On Tue, 2020-07-21 at 23:19 +0200, Matthias Brugger wrote:
>
> On 21/07/2020 13:24, Yong Wu wrote:
> > On Tue, 2020-07-21 at 11:40 +0200, Matthias Brugger wrote:
> >>
> >> On 21/07/2020 04:16, Miles Chen wrote:
> >>> In previous discussion [1] and [
On Tue, 2020-07-21 at 11:10 +0200, David Hildenbrand wrote:
> On 21.07.20 04:16, Miles Chen wrote:
> > In previous discussion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> >
> > Check 4GB mode by readin
] https://lkml.org/lkml/2020/7/15/1147
Cc: Mike Rapoport
Cc: David Hildenbrand
Cc: Yong Wu
Cc: Yingjoe Chen
Cc: Christoph Hellwig
Cc: Yong Wu
Cc: Chao Hao
Cc: Rob Herring
Cc: Matthias Brugger
Signed-off-by: Miles Chen
---
drivers/iommu/mtk_iommu.c | 26
On Wed, 2020-07-15 at 23:05 +0200, Matthias Brugger wrote:
>
> On 02/07/2020 11:37, Miles Chen wrote:
> > In previous disscusion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> >
> > Check 4GB mode by rea
On Wed, 2020-07-15 at 14:51 -0600, Rob Herring wrote:
> On Thu, Jul 02, 2020 at 05:37:17PM +0800, Miles Chen wrote:
> > Add a description for mediatek,infracfg. We can check if 4GB mode
> > is enable by reading it instead of checking the unexported
> > symbol "max_pfn
Add mediatek,infracfg to iommu node.
Signed-off-by: Miles Chen
---
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index db17d0a4ed57..0749b0f4834c 100644
/136
Cc: Mike Rapoport
Cc: David Hildenbrand
Cc: Yong Wu
Cc: Yingjoe Chen
Cc: Christoph Hellwig
Signed-off-by: Miles Chen
---
drivers/iommu/mtk_iommu.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu
Add a description for mediatek,infracfg. We can check if 4GB mode
is enable by reading it instead of checking the unexported
symbol "max_pfn".
This is a step towards building mtk_iommu as a kernel module.
Cc: Yong Wu
Signed-off-by: Miles Chen
---
Documentation/devicetree/bind
Add mediatek,infracfg to iommu node.
Signed-off-by: Miles Chen
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 70b1ffcab7f0..a6f14f68ef7e 100644
--- a/arch
n if we had to change LLVM. Just providing additional
> context for folks on the thread.
>
> This should also have a reported by tag from Miles, in v2.
>
> Reported-by: Miles Chen
>
> Miles mentioned to me that he tested it, but maybe Miles can confirm
> that publicly on-list
On Thu, 2020-06-04 at 10:25 +0200, David Hildenbrand wrote:
> On 04.06.20 10:01, Miles Chen wrote:
> > To build this driver as a kernel module, we cannot use
> > the unexported symbol "max_pfn" to setup enable_4GB.
> >
> > Use totalram_pages() instead to
To build this driver as a kernel module, we cannot use
the unexported symbol "max_pfn" to setup enable_4GB.
Use totalram_pages() instead to setup enable_4GB.
Suggested-by: Mike Rapoport
Signed-off-by: Miles Chen
Cc: David Hildenbrand
Cc: Yong Wu
Cc: Chao Hao
---
drivers/iommu/m
On Wed, 2020-06-03 at 18:16 +0200, David Hildenbrand wrote:
> On 03.06.20 18:11, Miles Chen wrote:
> > max_pfn is uesd to get the highest pfn in the system. Drivers like
> > drivers/iommu/mtk_iommu.c checks max_pfn to see if it should enable
> > its "4GB mode&quo
On Wed, 2020-06-03 at 20:06 +0300, Mike Rapoport wrote:
> On Thu, Jun 04, 2020 at 12:11:32AM +0800, Miles Chen wrote:
> > max_pfn is uesd to get the highest pfn in the system. Drivers like
> > drivers/iommu/mtk_iommu.c checks max_pfn to see if it should enable
&g
max_pfn is uesd to get the highest pfn in the system. Drivers like
drivers/iommu/mtk_iommu.c checks max_pfn to see if it should enable
its "4GB mode".
This patch exports the max_pfn symbol, so we can build the driver as
a kernel module.
Signed-off-by: Miles Chen
---
mm/memblock.c | 1
Replace strncpy() with strscpy() to guarantee a NULL-terminated
string.
Detected by Coverity.
Signed-off-by: Miles Chen
---
drivers/md/dm-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index ac83f5002ce5..4dc3658e3351
Replace DESTROY_BY_RCU with SLAB_TYPESAFE_BY_RCU because
SLAB_DESTROY_BY_RCU has been renamed to SLAB_TYPESAFE_BY_RCU by
commit 5f0d5a3ae7cf ("mm: Rename SLAB_DESTROY_BY_RCU to
SLAB_TYPESAFE_BY_RCU")
Signed-off-by: Miles Chen
---
mm/rmap.c | 7 ---
1 file changed, 4 insert
On Fri, 2019-10-04 at 09:57 +0200, Vlastimil Babka wrote:
> On 10/4/19 9:37 AM, Miles Chen wrote:
> > In __set_page_owner_handle(), we should loop over page
> > [0...(1 << order) - 1] and setup their page_owner structures.
> >
> > Currently, __set_page_owner_ha
0)
}
Cc: Andrew Morton
Cc: Vlastimil Babka
Cc: Michal Hocko
Signed-off-by: Miles Chen
Fixes: 7e2f2a0cd17c ("mm, page_owner: record page owner for each subpage")
---
mm/page_owner.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c
in
are useful
2. print the offset of the fault address
Cc: Christoph Lameter
Cc: Matthew Wilcox
Cc: David Rientjes
Signed-off-by: Miles Chen
---
mm/slub.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 42c1b3af3c98..21d26cd3e3bc 100644
--- a/mm/sl
On Sat, 2019-09-21 at 09:00 -0700, Matthew Wilcox wrote:
> On Sat, Sep 21, 2019 at 02:08:59AM -0700, David Rientjes wrote:
> > On Fri, 20 Sep 2019, Miles Chen wrote:
> >
> > > Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> &
On Sat, 2019-09-21 at 02:08 -0700, David Rientjes wrote:
> On Fri, 20 Sep 2019, Miles Chen wrote:
>
> > Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> > The use DUMP_PREFIX_OFFSET instead of DUMP_PREFIX_ADDRESS with
> > print_h
nux kernel.
$ git grep 'DUMP_PREFIX_ADDRESS' | cut -f1 -d"/" | sort | uniq -c
3 arch
140 drivers
12 fs
1 include
5 lib
2 mm
Signed-off-by: Miles Chen
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 8834563cdb4b..89d91c1eb33d 10
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4adcdcea717cb2d8436bef00dd689aa5bc76f11b
Gitweb:
https://git.kernel.org/tip/4adcdcea717cb2d8436bef00dd689aa5bc76f11b
Author:Miles Chen
AuthorDate:Thu, 12 Sep 2019 18:34:52 +08:00
Committer
9|123456789|123456789|1 (print 31 chars)
%sh: write error: Invalid argument
Signed-off-by: Miles Chen
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 6e52b67b420e..517e3719027e 100644
--- a/kernel/sched/ps
ange since v1:
discourage default n$
discourage default "[ynm]"
discourage default \!?EXPERT
Change since v2:
(Joe has provided the whole patch and I just post it)
test Kconfig in a single block
print precise message such as 'default "m"', not 'default "[ynm]"'
provide --fix
Commit-ID: ee050dc83bc326ad5ef8ee93bca344819371e7a5
Gitweb: https://git.kernel.org/tip/ee050dc83bc326ad5ef8ee93bca344819371e7a5
Author: Miles Chen
AuthorDate: Thu, 15 Aug 2019 19:32:46 +0800
Committer: Thomas Gleixner
CommitDate: Mon, 19 Aug 2019 12:57:28 +0200
lib/stackdepot: Fix
ype sgp,
gfp_t gfp, struct vm_area_struct *vma,
struct vm_fault *vmf, vm_fault_t *fault_type);
Signed-off-by: Miles Chen
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 2bed4761f279..fed9ebea316c 10
e_stack()
is removed in commit 56d8f079c51a ("lib/stackdepot: Remove
obsolete functions")
Cc: Thomas Gleixner
Cc: Alexander Potapenko
Cc: Josh Poimboeuf
Cc: Greg Kroah-Hartman
Cc: Kate Stewart
Signed-off-by: Miles Chen
---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 delet
On Fri, 2019-08-09 at 07:26 -0700, Matthew Wilcox wrote:
> On Fri, Aug 09, 2019 at 10:11:58PM +0800, Miles Chen wrote:
> > On Thu, 2019-08-08 at 19:46 -0700, Matthew Wilcox wrote:
> > > On Fri, Aug 09, 2019 at 09:08:37AM +0800, miles.c...@mediatek.com wrote:
> > > >
On Thu, 2019-08-08 at 19:46 -0700, Matthew Wilcox wrote:
> On Fri, Aug 09, 2019 at 09:08:37AM +0800, miles.c...@mediatek.com wrote:
> > Possible approaches are:
> > 1. stop printing kernel addresses
> > 2. print with %pK,
> > 3. print with %px.
>
> No. The point of obscuring kernel addresses is
On Thu, 2019-08-08 at 11:51 +0530, Anshuman Khandual wrote:
>
> On 08/08/2019 11:31 AM, Miles Chen wrote:
> > On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote:
> >>
> >> On 08/07/2019 06:03 AM, Miles Chen wrote:
> >>> This change prints th
ed the suggestion in v1
add reviewed-by tag from Anshuman in v2
Acked-by: Mark Rutland
Reviewed-by: Anshuman Khandual
Cc: Mark Rutland
Cc: Anshuman Khandual
Cc: James Morse
Signed-off-by: Miles Chen
---
arch/arm64/mm/fault.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote:
>
> On 08/07/2019 06:03 AM, Miles Chen wrote:
> > This change prints the hexadecimal EC value in mem_abort_decode(),
> > which makes it easier to lookup the corresponding EC in
> > the ARM Archi
T (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x0046
CM = 0, WnR = 1
Change since v1:
print "EC" instead of "Exception class"
print EC in fixwidth
Cc: Mark Rutland
Cc: Anshuman Khandual
Cc: James Morse
Signed-
On Tue, 2019-08-06 at 13:34 +0100, Mark Rutland wrote:
> On Tue, Aug 06, 2019 at 07:29:48PM +0800, Miles Chen wrote:
> > This change prints the hexadecimal EC value in mem_abort_decode(),
> > which makes it easier to lookup the corresponding EC in
> > the ARM Architec
eption class = DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
Data abort info:
ISV = 0, ISS = 0x0046
CM = 0, WnR = 1
Cc: Mark Rutland
Cc: Anshuman Khandual
Cc: James Morse
Signed-off-by: Miles Chen
---
arch/arm64/mm/fault.c | 4 ++--
1 file changed, 2 inser
On Thu, 2019-08-01 at 16:39 +1000, Stephen Rothwell wrote:
> Hi Miles,
>
> On Thu, 1 Aug 2019 14:30:03 +0800 Miles Chen wrote:
> >
> > It's the first time that I receive a build warning after the patch has
> > been merged to -mm tree. The build warning had been fixed
On Thu, 2019-08-01 at 08:15 +0200, Michal Hocko wrote:
> On Thu 01-08-19 15:51:30, Stephen Rothwell wrote:
> > Hi Miles,
> >
> > On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen
> > wrote:
> > >
> > > On Wed, 2019-07-31 at 16:11 +1000, Stephen R
o change
default EXPERT => no change
Change since v1:
discourage default n$
discourage default "[ynm]"
discourage default \!?EXPERT
Change since v2:
test Kconfig in a single block
print precise message such as 'default "m"', not 'default "[ynm]"'
provide --fix capa
On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the akpm-current tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> mm/memcontrol.c: In function 'invalidate_reclaim_iterators':
> mm/memcontrol.c:1160:11: warning: suggest
m iterator to simple css
refcounting")
Cc: Johannes Weiner
Cc: Michal Hocko
Signed-off-by: Miles Chen
---
mm/memcontrol.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index cdbb7a84cb6e..8a
On Mon, 2019-07-29 at 12:06 -0400, Johannes Weiner wrote:
> On Fri, Jul 26, 2019 at 10:12:47AM +0800, Miles Chen wrote:
> > This patch is sent to report an use after free in mem_cgroup_iter()
> > after merging commit: be2657752e9e "mm: memcg: fix use after free in
On Sat, 2019-07-27 at 07:47 +0800, Miles Chen wrote:
> On Fri, 2019-07-26 at 14:55 +0200, Michal Hocko wrote:
> > On Fri 26-07-19 14:49:33, Michal Hocko wrote:
> > > On Fri 26-07-19 10:12:47, Miles Chen wrote:
> > > > This patch is sent to report an use
since v1:
Add a comment to explain why we need to handle root_mem_cgroup separately.
Rename invalid_root to invalidate_root.
Change since v2:
add fix tag
Fixes: 5ac8fb31ad2e ("mm: memcontrol: convert reclaim iterator to simple css
refcounting")
Cc: Johannes Weiner
Cc: Michal H
On Fri, 2019-07-26 at 14:55 +0200, Michal Hocko wrote:
> On Fri 26-07-19 14:49:33, Michal Hocko wrote:
> > On Fri 26-07-19 10:12:47, Miles Chen wrote:
> > > This patch is sent to report an use after free in mem_cgroup_iter()
> > > after merging commit: be2657752e9e &qu
Hi Johannes,
I post patch v2 with proper comment you mentioned.
(I am not sure if I can copy your acked-by to patch v2 directly)
Miles
On Fri, 2019-07-26 at 10:12 +0800, Miles Chen wrote:
> This patch is sent to report an use after free in mem_cgroup_iter()
> after merging commit: be2657
since v1:
Add a comment to explain why we need to handle root_mem_cgroup separately.
Rename invalid_root to invalidate_root.
Cc: Johannes Weiner
Signed-off-by: Miles Chen
---
mm/memcontrol.c | 38 --
1 file changed, 28 insertions(+), 10 deletions(-)
diff --
On Fri, 2019-07-05 at 11:16 +0800, Miles Chen wrote:
> This change adds 3 Kconfig default value tests.
Hi Joe,
I was wondering if this patch looks good to you?
Miles
>
> 1. discourage default n cases:
> e.g.,
> default n
>
> 2. discourage default "[ynm]" cases:
ange since v1:
discourage default n$
discourage default "[ynm]"
discourage default \!?EXPERT
Change since v2:
(Joe has provided the whole patch and I just post it)
test Kconfig in a single block
print precise message such as 'default "m"', not 'default "[ynm]"'
prov
On Thu, 2019-07-04 at 11:49 -0700, Joe Perches wrote:
> On Thu, 2019-07-04 at 17:40 +0800, Miles Chen wrote:
> > This change adds 3 Kconfig default value tests:
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -300
ault "[ynm]"
+ default "y" if PPC_POWERNV
Change since v1:
discourage default n$
discourage default "[ynm]"
discourage default \!?EXPERT
Cc: Joe Perches
Cc: Yingjoe Chen
Signed-off-by: Miles Chen
---
scripts/checkpatch.pl | 21 +
1 file
On Wed, 2019-07-03 at 08:37 -0700, Joe Perches wrote:
> On Wed, 2019-07-03 at 17:03 +0800, Yingjoe Chen wrote:
> > On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote:
> > > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote:
> > > > This change reports a wa
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote:
> On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote:
> > This change reports a warning when "default n" is used.
> >
> > I have seen several "remove default n" patches, so I think
> > it
This change reports a warning when "default n" is used.
I have seen several "remove default n" patches, so I think
it might be helpful to add this test in checkpatch.
tested:
WARNING: 'default n' is the default value, no need to write it explicitly.
+ default n
Signe
redundant IS_ENABLED(CONFIG_ZONE_DMA32)
Cc: Robin Murphy
Signed-off-by: Miles Chen
---
arch/arm64/Kconfig | 3 ++-
arch/arm64/mm/init.c | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 76f6e4765f49..20c552b1302c 100644
On Tue, 2019-05-28 at 11:43 +0100, Robin Murphy wrote:
> On 27/05/2019 17:08, Miles Chen wrote:
> > This change makes CONFIG_ZONE_DMA32 defuly y and allows users
> > to overwrite it.
> >
> > For the SoCs that do not need CONFIG_ZONE_DMA32, this is the
> > first st
CONFIG_NUMA=y and
CONFIG_ZONE_DMA32=n.
arch/arm64/mm/init.c:195:17: error: use of undeclared identifier 'ZONE_DMA32'
max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys());
Signed-off-by: Miles Chen
---
arch/arm64/Kconfig | 3 ++-
arch/arm64/mm/init.c | 2 ++
2 files changed
ss
in __pa()/__virt_to_phys().
A simple solution is to use the original virt_to_page()
(the one with__pa()) if CONFIG_DEBUG_VIRTUAL=y.
Signed-off-by: Miles Chen
Cc: Ard Biesheuvel
---
arch/arm64/include/asm/memory.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/as
/0x1068
__alloc_pages_nodemask+0xd4/0xcb8
shmem_alloc_page+0x7c/0xa0
shmem_alloc_and_acct_page+0x124/0x1e8
shmem_getpage_gfp.isra.7+0x118/0x878
shmem_write_begin+0x38/0x68
Signed-off-by: Miles Chen
---
arch/arm64/mm/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/mm/init.c b/arch
On Tue, 2019-01-29 at 19:46 +, Christopher Lameter wrote:
> On Tue, 29 Jan 2019, Miles Chen wrote:
>
> > a) classic slub issue. e.g., use-after-free, redzone overwritten. It's
> > more efficient to report a issue as soon as slub detects it. (comparing
> > to monitor t
On Tue, 2019-01-29 at 05:46 +, Christopher Lameter wrote:
> On Mon, 28 Jan 2019, Andrew Morton wrote:
>
> > > When debugging slab errors in slub.c, sometimes we have to trigger
> > > a panic in order to get the coredump file. Add a debug option
> > > SLAB_WARN_ON_ERROR to toggle WARN_ON()
On Mon, 2019-01-28 at 17:41 -0800, David Rientjes wrote:
> On Thu, 24 Jan 2019, miles.c...@mediatek.com wrote:
>
> > From: Miles Chen
> >
> > When debugging slab errors in slub.c, sometimes we have to trigger
> > a panic in order to get the cor
On Mon, 2019-01-21 at 22:02 +, Christopher Lameter wrote:
> On Mon, 21 Jan 2019, miles.c...@mediatek.com wrote:
>
> > From: Miles Chen
> >
> > When debugging with slub.c, sometimes we have to trigger a panic in
> > order to get the coredump file. To do
On Tue, 2019-01-08 at 12:14 +, Mark Rutland wrote:
> On Tue, Jan 08, 2019 at 11:24:43AM +0800, Miles Chen wrote:
> > On Mon, 2019-01-07 at 15:00 +, Mark Rutland wrote:
> > > On Mon, Jan 07, 2019 at 07:21:20PM +0800, Miles Chen wrote:
> > > > Current __vir
On Mon, 2019-01-07 at 15:00 +, Mark Rutland wrote:
> On Mon, Jan 07, 2019 at 07:21:20PM +0800, Miles Chen wrote:
> > Current __virt_to_phys() only print warning messages for non-linear
> > addresses. It's hard to catch all warnings by those messages.
>
> Why? Are you
:
stack addresses: kernel BUG()
symbol addresses: kernel warning message
Maybe we should trap all non-linear address translations in the future.
Signed-off-by: Miles Chen
---
arch/arm64/mm/physaddr.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/mm/physaddr.c b/arch/arm64
The example in comment does not useable because the output
binary is named "page_owner_sort", not "sort".
Also add a reference to Documentation/vm/page_owner.rst
Signed-off-by: Miles Chen
---
tools/vm/page_owner_sort.c | 4 +++-
1 file changed, 3 insertions(+), 1 del
On Thu, 2018-12-13 at 19:15 +0100, Ard Biesheuvel wrote:
> On Thu, 13 Dec 2018 at 19:12, Will Deacon wrote:
> >
> > [+Ard because I'll basically go with his preference on this one]
> >
> > On Wed, Dec 12, 2018 at 06:56:49PM +0800, Miles Chen wrote:
> > > Wh
1 - 100 of 181 matches
Mail list logo
