"if (0)" is used to make this block of debug code not be executed. There
is a more elegant way to let compiler ignore this code, using
"#if 0 .. #endif" instead.
Although it may be optimised by some compilers with specified parameter,
just for readable.
Signed-off-by: Minfei
Ping.
Any comment is appreciate.
Thanks
Minfei
On 09/06/16 at 04:00P, Minfei Huang wrote:
> dm_resume will return sliently in retry loop's failure. Assign a correct
> return value in the failed loop.
>
> Remove a useless assignment as well.
>
> Signed-off-by: Minfei Hua
dm_resume will return sliently in retry loop's failure. Assign a correct
return value in the failed loop.
Remove a useless assignment as well.
Signed-off-by: Minfei Huang
---
drivers/md/dm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/md/dm.c b/drive
g, we should take care of allocation failure, and return
correct value to let caller know what happen.
Tested-by: Chao Fan
Signed-off-by: Minfei Huang
Signed-off-by: Minfei Huang
Reviewed-by: Cornelia Huck
Reviewed-by: Stefan Hajnoczi
---
drivers/block/virtio_blk.c | 26
Hi, Michael.
Since Stefan and Cornelia have review-acked this patch, could you mind
helping review this patch?
Thanks
Minfei
> On Jul 29, 2016, at 16:26, Stefan Hajnoczi wrote:
>
> On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang wrote:
>> From: Minfei Huang
>>
>
owing commit:
>
> https://github.com/0day-ci/linux
> Minfei-Huang/blk-core-Fix-the-bad-IO-during-checking-bio/20160728-182758
> commit ee5c4fef9f2ef03ee8f283a5b24192df00e17f0f ("blk-core: Fix the bad IO
> during checking bio")
>
> in testcase: boot
>
> on tes
We will handle IO as a bad IO, if its range exceeds the disk's capacity
in function bio_check_eod. Also we should catch the corner case if
inode->i_size is set to 0 during disabling disk.
Fix the coming IO as a bad IO as well, if inode->i_size is set to 0.
Signed-off-by: Minfei Huang
Ping, Any comment is appreciate.
Thanks
Minfei
> On Jul 19, 2016, at 20:22, Cornelia Huck wrote:
>
> On Tue, 19 Jul 2016 12:32:42 +0800
> Minfei Huang wrote:
>
>> From: Minfei Huang
>>
>> We do a lot of memory allocation in function init_vq, and don&#
From: Minfei Huang
We do a lot of memory allocation in function init_vq, and don't handle
the allocation failure properly. Then this function will return 0,
although initialization fails due to lacking memory. At that moment,
kernel will panic in guest machine, if virtio is used to drive
On 07/18/16 at 06:25P, Cornelia Huck wrote:
> On Tue, 19 Jul 2016 00:18:32 +0800
> Minfei Huang wrote:
>
> > On 07/18/16 at 05:21P, Cornelia Huck wrote:
> > > On Mon, 18 Jul 2016 22:01:29 +0800
> > > Minfei Huang wrote:
> > > > diff --git
On 07/18/16 at 05:21P, Cornelia Huck wrote:
> On Mon, 18 Jul 2016 22:01:29 +0800
> Minfei Huang wrote:
> > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> > index 42758b5..d920512 100644
> > --- a/drivers/block/virtio_blk.c
> > +++ b/drivers/bl
g, we should take care of allocation failure, and return
correct value to let caller know what happen.
Tested-by: Chao Fan
Signed-off-by: Minfei Huang
Signed-off-by: Minfei Huang
---
v1:
- Refactor the patch to make code more readable
---
drivers/block/virtio_blk.c
On 07/06/16 at 11:18P, Cornelia Huck wrote:
> On Mon, 27 Jun 2016 10:09:18 +0800
> Minfei Huang wrote:
>
> > The error number -ENOENT or 0 will be returned, if we can not allocate
> > more memory in function init_vq. If host can support multiple virtual
> > queue
On 07/06/16 at 09:31P, Mike Snitzer wrote:
> On Wed, Jul 06 2016 at 9:27am -0400,
> Minfei Huang wrote:
>
> > On 07/06/16 at 09:16P, Mike Snitzer wrote:
> > > On Mon, Jul 04 2016 at 11:25am -0400,
> > > Minfei Huang wrote:
> > >
> > > >
On 07/06/16 at 09:16P, Mike Snitzer wrote:
> On Mon, Jul 04 2016 at 11:25am -0400,
> Minfei Huang wrote:
>
> > kthread function is used to process kthread_work. And there is no return
> > value checking during create this thread. Add this checking to fix this
> > is
kthread function is used to process kthread_work. And there is no return
value checking during create this thread. Add this checking to fix this
issue.
Signed-off-by: Minfei Huang
---
drivers/md/dm.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm.c
value in init_vq.
Signed-off-by: Minfei Huang
Signed-off-by: Minfei Huang
---
drivers/block/virtio_blk.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 42758b5..40ecb2b 100644
--- a/drivers/block/virtio_blk.c
On 06/20/16 at 03:17P, Al Viro wrote:
> On Mon, Jun 20, 2016 at 10:05:45PM +0800, Minfei Huang wrote:
> > Ping. Any comment is appreciate.
> >
> > Thanks
> > Minfei
> >
> > On 06/13/16 at 12:33P, Minfei Huang wrote:
> > > The variable nr_
kthread function is used to process kthread_work. And there is no return
value checking during create this thread. Add this checking to fix this
issue.
Signed-off-by: Minfei Huang
Signed-off-by: Minfei Huang
---
drivers/md/dm.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions
Ping. Any comment is appreciate.
Thanks
Minfei
On 06/13/16 at 12:33P, Minfei Huang wrote:
> The variable nr_pages is always more than 1, because the size of
> structure aio_ring is bigger than 0. So remove unnecessary test for
> nr_page.
>
> Signed-off-by: Minfei Huang
> -
The variable nr_pages is always more than 1, because the size of
structure aio_ring is bigger than 0. So remove unnecessary test for
nr_page.
Signed-off-by: Minfei Huang
---
fs/aio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index fb8e45b..ec05137 100644
--- a/fs
On 06/09/16 at 01:28P, Borislav Petkov wrote:
> On Thu, Jun 09, 2016 at 01:21:18PM +0200, Paolo Bonzini wrote:
> > This is basically implementing a seqcount. It needs two barriers and,
>
> Why does it need the two barriers? More details please.
Hi, Borislav.
It's a seqcount-like. We should conf
On 06/09/16 at 01:23P, Paolo Bonzini wrote:
> The version field in struct pvclock_vcpu_time_info basically implements
> a seqcount. Wrap it with the usual read_begin and read_retry functions,
> and use these APIs instead of peppering the code with smp_rmb()s.
> While at it, change it to the more p
On 06/08/16 at 09:45P, Borislav Petkov wrote:
> On Wed, Jun 08, 2016 at 09:11:39PM +0300, Roman Kagan wrote:
> > Gradual removal of excessive barriers in pvclock reading functions
> > (commits 502dfeff239e8313bfbe906ca0a1a6827ac8481b,
> > a3eb97bd80134ba07864ca00747466c02118aca1) ended up removing
Ping. Any comment is appreciate.
Thanks
Minfei
On 05/17/16 at 03:58P, Minfei Huang wrote:
> It's more elegant to use MACRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MACRO.
>
> Signed-off-by: Minfei Huang
> --
ping. Any comment is appreciate.
Thanks
Minfei
On 05/28/16 at 08:27P, Minfei Huang wrote:
> There is a generic function __pvclock_read_cycles to be used to get both
> flags and cycles. For function pvclock_read_flags, it's useless to get
> cycles value. To make this function be
There is no error number returned if loop driver fails in function
alloc_disk to add new loop device. Add a correct error number to make
user notify in this case.
Signed-off-by: Minfei Huang
---
drivers/block/loop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/loop.c b
There is a generic function __pvclock_read_cycles to be used to get both
flags and cycles. For function pvclock_read_flags, it's useless to get
cycles value. To make this function be more effective, get this variable
flags directly in function.
Signed-off-by: Minfei Huang
---
v1:
- Get r
On 05/27/16 at 06:06P, Paolo Bonzini wrote:
>
>
> On 27/05/2016 17:40, Andy Lutomirski wrote:
> > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang wrote:
> >> There is a generic function __pvclock_read_cycles to be used to get both
> >> flags and cycles. For
them.
Add CPU barries after getting version value just like what function
vread_pvclock does, because all of callees in this function is inline.
Signed-off-by: Minfei Huang
---
arch/x86/include/asm/pvclock.h | 2 ++
arch/x86/kernel/pvclock.c | 4
2 files changed, 6 insertions(+)
diff --
There is a generic function __pvclock_read_cycles to be used to get both
flags and cycles. For function pvclock_read_flags, it's useless to get
cycles value. To make this function be more effective, add a new wrapper
function to only get variable flags.
Signed-off-by: Minfei Huang
---
arc
Function __pvclock_read_cycles is short enough, so there is no need to
have another function pvclock_get_nsec_offset to calculate tsc delta.
It's better to combine it into function __pvclock_read_cycles.
Remove useless variables in function __pvclock_read_cycles.
Signed-off-by: Minfei
e still belong to kexec component.
In order to get correct mail lists by using script get_maintainer.pl,
add these files to MAINTAINERS.
Signed-off-by: Minfei Huang
---
v1:
- use kexec* to match all of kexec related file
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On 05/25/16 at 05:54P, Joe Perches wrote:
> On Wed, 2016-05-25 at 20:49 +0800, Minfei Huang wrote:
> >
> > From below commits, kexec.c is split to kexec.c, kexec_file.c and
> > kexec_core.c.
> >
> > commit a43cac0d9dc2 ("kexec: split kexec_file syscall
e still belong to kexec component.
In order to get correct mail lists by using script get_maintainer.pl,
add these files to MAINTAINERS.
Signed-off-by: Minfei Huang
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3302006..5f33f71 100644
This is a cleanup patch to make kexec more clear to return error number
directly. The variable result is useless, because there is no other
function's return value assignes to it. So remove it.
Signed-off-by: Minfei Huang
---
kernel/kexec_core.c | 16 ++--
1 file chang
It's more elegant to use MACRO UINT_MAX to represent the max value of
type unsigned int. So replace the actual value by using this MACRO.
Signed-off-by: Minfei Huang
---
v1:
- fix typo
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On 05/11/16 at 04:24P, Paolo Bonzini wrote:
>
>
> On 30/04/2016 23:57, Andy Lutomirski wrote:
> >> > Should we kill __pvclock_read_cycles in favor of vread_pvclock? It looks
> >> > doable at a quick scan...
> >> >
> > The in-kernel version might have to be a bit different because it
> > needs to
On 05/02/16 at 10:39P, John Stultz wrote:
> On Mon, Apr 25, 2016 at 2:20 AM, Minfei Huang wrote:
> > It is unnecessary to continue looping the list, if we find there is an
> > entry that the value of rating is smaller than the new one. It is safe
> > to be out the loop, bec
Ping.
Any comment is appreciate.
Thanks
Minfei
On 04/25/16 at 05:20P, Minfei Huang wrote:
> It is unnecessary to continue looping the list, if we find there is an
> entry that the value of rating is smaller than the new one. It is safe
> to be out the loop, because all of entry are in
Ping.
Any comment is appreciate.
Thanks
Minfei
On 04/25/16 at 11:13P, Minfei Huang wrote:
> It's more elegant to use MICRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MICRO.
>
> Signed-off-by: Minfei Huang
> ---
ping.
Any comment is appreciate.
Thanks
Minfei
On 04/25/16 at 02:53P, Minfei Huang wrote:
> The value of cycles and flags can be assigned directly without
> intermediate variables.
>
> Remove the useless variables.
>
> Signed-off-by: Minfei Huang
> ---
> arch/x86/in
On 04/29/16 at 02:21P, Andrew Morton wrote:
> On Fri, 29 Apr 2016 13:47:04 +0800 Minfei Huang wrote:
>
> > It's more convenient to use existing function helper to convert string
> > "on/off" to boolean.
> >
> > ...
> >
> > --- a/l
On 04/28/16 at 03:44P, Josh Poimboeuf wrote:
> In preparation for being able to determine whether a given stack trace
> is reliable, allow the stacktrace_ops functions to propagate errors to
> dump_trace().
Hi, Josh.
Have you considered to make walk_stack function as non-return function,
since th
On 04/29/16 at 10:04P, Michal Hocko wrote:
> On Fri 29-04-16 13:47:04, Minfei Huang wrote:
> > It's more convenient to use existing function helper to convert string
> > "on/off" to boolean.
>
> But kstrtobool in linux-next only does "This routine retu
It's more convenient to use existing function helper to convert string
"on/off" to boolean.
Signed-off-by: Minfei Huang
---
lib/kstrtox.c| 2 +-
mm/page_alloc.c | 9 +
mm/page_poison.c | 8 +---
3 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/lib/
On 04/25/16 at 12:44P, Sagi Grimberg wrote:
>
> >It's more elegant to use MICRO UINT_MAX to represent the max value of
> >type unsigned int. So replace the actual value by using this MICRO.
>
> You mean macro right?
Yep. Sorry for the typo error.
Thanks
Minfei
It is unnecessary to continue looping the list, if we find there is an
entry that the value of rating is smaller than the new one. It is safe
to be out the loop, because all of entry are inserted in descending
order.
Signed-off-by: Minfei Huang
---
kernel/time/clocksource.c | 8 +---
1 file
The value of cycles and flags can be assigned directly without
intermediate variables.
Remove the useless variables.
Signed-off-by: Minfei Huang
---
arch/x86/include/asm/pvclock.h | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/arch/x86/include/asm
It's more elegant to use MICRO UINT_MAX to represent the max value of
type unsigned int. So replace the actual value by using this MICRO.
Signed-off-by: Minfei Huang
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/cor
The value delta is correct as well, although calc_load_idle[idx] is
equal to 0. Remove this useless test to improve performance, since this
function is called more frequently.
Signed-off-by: Minfei Huang
---
kernel/sched/loadavg.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
On 03/25/16 at 02:34P, Josh Poimboeuf wrote:
> +static int klp_check_stack(struct task_struct *task)
> +{
> + static unsigned long entries[MAX_STACK_ENTRIES];
> + struct stack_trace trace;
> + struct klp_object *obj;
> + struct klp_func *func;
> + int ret;
> +
> + trace.skip
On 03/30/16 at 08:30pm, Baoquan He wrote:
> Hi Xunlei,
>
> I have two questions.
>
> One is do we still need Minfei's patch if this patch is applied since
> you have completely delete crash_map/unmap_reserved_pages in
> kernel/kexec.c ?
I think it is necessary to apply my bug-fixing patch firstl
e is a suggestion from Vivek to wrap a new function do_kexec_load to
fix this issue, since there are a lot of logic handling in function
kexec_load. And this issue doesn't conflict with xlpang@'s patchset,
except for code confliction.
Thanks
Minfei
>
> Thanks
> Baoquan
>
&g
On 03/14/16 at 01:58pm, Dan Carpenter wrote:
> On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote:
> > I think we can modify the logic a bit to make code simple. Thus gcc will
> > not complain about any more, and the logic is earier.
>
> This is a Smatch warning, n
On 03/11/16 at 10:47am, walter harms wrote:
>
>
> Am 11.03.2016 10:19, schrieb Dan Carpenter:
> > On Fri, Mar 11, 2016 at 04:52:43PM +0800, Xunlei Pang wrote:
> >> Hi Dan,
> >>
> >> On 2016/03/11 at 16:07, Dan Carpenter wrote:
> >>> At the end of the function we check if "ret" has a negative erro
On 03/11/16 at 02:21pm, dyo...@redhat.com wrote:
> @@ -231,7 +231,8 @@ static ssize_t __read_vmcore(char *buffe
>
> list_for_each_entry(m, &vmcore_list, list) {
> if (*fpos < m->offset + m->size) {
> - tsz = min_t(size_t, m->offset + m->size - *fpos,
> buf
On 03/01/16 at 01:56pm, Andrew Morton wrote:
> On Tue, 1 Mar 2016 16:02:28 +0800 Minfei Huang wrote:
>
> > For some arch, kexec shall map the reserved pages, then use them, when
> > we try to start the kdump service.
>
> Which architectures are these, by the way?
Hi.
It is not elegant that prompt shell does not start from new line after
executing "cat /proc/$pid/wchan". Make prompt shell start from new line.
Signed-off-by: Minfei Huang
---
fs/proc/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/base.c b/fs/p
-off-by: Minfei Huang
---
kernel/kexec.c | 116 +++--
1 file changed, 63 insertions(+), 53 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 5cd60c4..48cf69c 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -103,6 +103,68
v1:
- Bisect the patch according to Andrew Morton's suggestion
Minfei Huang (2):
kexec: Make a pair of map/unmap reserved pages in error path
kexec: Do a cleanup for function kexec_load
kernel/kexec.c | 112 -
1 file change
.
Signed-off-by: Minfei Huang
---
kernel/kexec.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index ee70aef..5cd60c4 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -169,6 +169,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long
On 02/26/16 at 04:56pm, Andrew Morton wrote:
> On Thu, 25 Feb 2016 22:02:40 +0800 Minfei Huang wrote:
>
> > From: Minfei Huang
> >
> > For some arch, kexec shall map the reserved pages, then use them, when
> > we try to start the kdump service.
> >
&g
From: Minfei Huang
For some arch, kexec shall map the reserved pages, then use them, when
we try to start the kdump service.
kexec may return directly, without unmaping the reserved pages, if it
fails during starting service. To fix it, we make a pair of map/unmap
reserved pages both in generic
On 02/01/16 at 09:45pm, Andrew Morton wrote:
> On Thu, 28 Jan 2016 11:57:22 +0300 Dmitry Safonov
> wrote:
>
> > On 01/28/2016 09:29 AM, Minfei Huang wrote:
> > > On 01/27/16 at 02:48pm, Dmitry Safonov wrote:
> > >> For allocation of kimage failure or kexec_pr
On 01/27/16 at 02:48pm, Dmitry Safonov wrote:
> For allocation of kimage failure or kexec_prepare or load segments
> errors there is no need to keep crashkernel memory mapped.
> It will affect only s390 as map/unmap hook defined only for it.
> As on unmap s390 also changes os_info structure let's c
On 01/07/16 at 10:14am, Xunlei Pang wrote:
> >> +static int
> >> +kexec_mark_range(unsigned long start, unsigned long end, bool protect)
> >> +{
> >> + struct page *page;
> >> + unsigned int nr_pages;
> >> +
> >> + /* For physical range: [start, end] */
> >> + if (!start || !end || start > end)
On 01/06/16 at 05:50pm, Xunlei Pang wrote:
> diff --git a/arch/x86/kernel/machine_kexec_64.c
> b/arch/x86/kernel/machine_kexec_64.c
> index 819ab3f..cda867d 100644
> --- a/arch/x86/kernel/machine_kexec_64.c
> +++ b/arch/x86/kernel/machine_kexec_64.c
> @@ -536,3 +536,44 @@ overflow:
> return
On 12/28/15 at 08:14pm, Minfei Huang wrote:
> On 12/28/15 at 02:32pm, Xunlei Pang wrote:
> > On 12/24/2015 at 02:44 PM, Xunlei Pang wrote:
> > >>>>> +static void kexec_mark_crashkres(bool protect)
> > >>>>> +{
> > >>>>> +
On 12/28/15 at 02:32pm, Xunlei Pang wrote:
> On 12/24/2015 at 02:44 PM, Xunlei Pang wrote:
> > +static void kexec_mark_crashkres(bool protect)
> > +{
> > + unsigned long control;
> > +
> > + kexec_mark_range(crashk_low_res.start, crashk_low_res.end,
> > protect)
On 12/26/15 at 05:31pm, Toshi Kani wrote:
> + cc: kexec list
>
> On 12/26/2015 3:38 AM, Borislav Petkov wrote:
> >On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote:
> >>Change to call walk_iomem_res_desc() for searching resource entries
> >>with the following names:
> >> "ACPI Tables"
>
Ccing kexec maillist.
On 12/25/15 at 03:09pm, Toshi Kani wrote:
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index c245085..e2bd737 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char
> *buffer, unsig
On 12/23/15 at 07:12pm, Xunlei Pang wrote:
> Implement the protection method for the crash kernel memory
> reservation for the 64-bit x86 kdump.
>
> Signed-off-by: Xunlei Pang
> ---
> Only provided x86_64 implementation, as I've only tested on x86_64 so far.
>
> arch/x86/kernel/machine_kexec_64
On 12/22/15 at 07:40pm, Xunlei Pang wrote:
> On 12/22/2015 at 06:47 PM, Minfei Huang wrote:
> > On 12/21/15 at 02:09pm, Xunlei Pang wrote:
> >> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> > Hi, Xunlei.
> >
> > Following functions will be used
On 12/21/15 at 02:09pm, Xunlei Pang wrote:
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 7b68d27..2cc643c 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -109,11 +109,7 @@ struct compat_kexec_segment {
> };
> #endif
>
> -struct kexec_sha_region {
>
The variant pagep will still get the invalid page point, although ceph
fails in function ceph_update_writeable_page.
To fix this issue, Assigne the page to pagep until there is no failure
in function ceph_update_writeable_page.
Signed-off-by: Minfei Huang
---
fs/ceph/addr.c | 1 -
1 file
It is more lucky that kernel crash does not happen, since we test the
bi_pool in function __bio_clone_fast.
The idx will be still equal to BIO_POOL_NONE, if there is no bvec to be
allocated.
Fix the bug_on condition to make the test correct.
Signed-off-by: Minfei Huang
---
block/bio.c | 3
On 12/18/15 at 11:02P, Minfei Huang wrote:
> It is more lucky that kernel crash does not happen, since we test the
> bi_pool in function __bio_clone_fast. Now bi_flags is used to flag the
> idx, so it is incorrect to test the bi_pool.
>
> For now, the bio in function __bio_clone_fa
Sorry to bother you, since I have missed the nr_iovecs in
bio_clone_fast.
Nacked this patch.
Thanks
Minfei
On 12/18/15 at 11:02P, Minfei Huang wrote:
> This is a memory leaking during splitting the bio by the caller
> bio_clone_fast.
>
> Clone bio may allocate its own bvec, if de
the test to fix this issue.
Signed-off-by: Minfei Huang
---
block/bio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 4f184d9..70d9814 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -573,8 +573,6 @@ EXPORT_SYMBOL(bio_phys_segments);
*/
void
ction __bio_clone_fast.
To fix it, freeing the own bvec firstly before assigning the source
bio's bvec.
Signed-off-by: Minfei Huang
---
block/bio.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/bio.c b/block/bio.c
index 70d9814..b24fd6e 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -581
Ping, Jens.
Could you have any idea about this cleanup patch?
Thanks
Minfei
On 11/27/15 at 09:26pm, Minfei Huang wrote:
> If null block is a lightnvm device, it wouldn't need to allocate the
> variant disk. So it is fine to separate the code for lightnvm and normal
> device
On 12/11/15 at 09:22P, Steven Rostedt wrote:
> On Fri, 11 Dec 2015 18:52:42 +0800
> Minfei Huang wrote:
>
> > Hi, Steven.
> >
> > There is a confusion which blocks my step to go further for ftrace.
> >
> > Does ftrace guarantee that the replaced f
ftrace
Reply-To:
Hi, Steven.
There is a confusion which blocks my step to go further for ftrace.
Does ftrace guarantee that the replaced function is finished while
ftrace is replacing the functions? In the other word, is there a
possible that new function starts to run, while old function is al
On 11/30/15 at 11:21P, Jessica Yu wrote:
> + klp_for_each_reloc_sec(obj, reloc_sec) {
> + relindex = reloc_sec->index;
> + num_relas = pmod->sechdrs[relindex].sh_size / sizeof(Elf_Rela);
> + rela = (Elf_Rela *) pmod->sechdrs[relindex].sh_addr;
> +
> +
Ping.
Any comment is appreciate.
Thanks
Minfei
On 11/27/15 at 09:26pm, Minfei Huang wrote:
> To make consistent of null block list, we should remove enqueued null
> block from the list before freeing it.
>
> Signed-off-by: Minfei Huang
> ---
> drivers/block/null_blk.c |
On 12/08/15 at 01:48pm, Jens Axboe wrote:
> On 12/08/2015 05:35 AM, Minfei Huang wrote:
> >Ping.
> >
> >Any comment is appreciate.
>
> Applied, it is indeed pretty broken after the lightnvm update.
> I killed the use_lightnvm check before kmem_cache_destroy, that&#x
Ping.
Any comment is appreciate.
Thanks
Minfei
On 11/26/15 at 09:48P, Minfei Huang wrote:
> From: Minfei Huang
>
> Module couldn't release resource properly during the initialization. To
> fix this issue, we will clean up the proper resource before returning.
>
> Sign
Ping.
Any comment is appreciate.
Thanks
Minfei
On 11/27/15 at 04:37pm, Minfei Huang wrote:
> From: Minfei Huang
>
> It might be more reasonable to cleanup all of the allocations in same
> function, if there is a fatal. Thus we can make function more
> independency to export it
Hi.
IMHO, this sort of defect shouldn't be fixed like this. It should be
fixed with other bugs, if necessary.
Once this patch is applied, it will break up the 'git blame'.
Thanks
Minfei
On 11/25/15 at 08:45pm, Geliang Tang wrote:
> Change 4-characters indentations to 8-characters.
>
> Signed-o
If null block is a lightnvm device, it wouldn't need to allocate the
variant disk. So it is fine to separate the code for lightnvm and normal
device to use if/else.
Thus we don't never need the flag out_cleanup_lightnvm.
Signed-off-by: Minfei Huang
---
drivers/block/null_
To make consistent of null block list, we should remove enqueued null
block from the list before freeing it.
Signed-off-by: Minfei Huang
---
drivers/block/null_blk.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
From: Minfei Huang
It might be more reasonable to cleanup all of the allocations in same
function, if there is a fatal. Thus we can make function more
independency to export it.
For this patch, variant tag will be allocated in blk_mq_init_tags, and
it will be freed in same function, if there is
From: Minfei Huang
Module couldn't release resource properly during the initialization. To
fix this issue, we will clean up the proper resource before returning.
Signed-off-by: Minfei Huang
---
drivers/block/null_blk.c | 24 +---
1 file changed, 17 insertions(
On 11/10/15 at 08:07am, Josh Poimboeuf wrote:
> On Fri, Nov 06, 2015 at 02:25:00PM +0800, Zhou Chengming wrote:
> > When enable KASLR, livepatch will adjust old_addr of changed
> > function accordingly. So do the same thing for reloc.
> >
> > +
> > +#if defined(CONFIG_RANDOMIZE_BASE)
> > +
On 11/09/15 at 11:45pm, Jessica Yu wrote:
> In livepatch modules, preserve section, symbol, string information from
> the load_info struct in the module loader. This information is used to
> patch modules that are not loaded in memory yet; specifically it is used
> to resolve remaining symbols and
On 10/15/15 at 10:25pm, Steven Rostedt wrote:
> On Thu, 17 Sep 2015 00:19:42 +0800
> Minfei Huang wrote:
>
> > Now, ftrace only calculate the dyn_ftrace number in the adding
> > breakpoint loop, not in adding update and finish update loop.
> >
> > Calculate th
Commit-ID: e9c40d257fdd58c5cc97d3fe3aa141dd23ee5e9d
Gitweb: http://git.kernel.org/tip/e9c40d257fdd58c5cc97d3fe3aa141dd23ee5e9d
Author: Minfei Huang
AuthorDate: Tue, 6 Oct 2015 02:35:55 +0800
Committer: Ingo Molnar
CommitDate: Mon, 12 Oct 2015 09:43:11 +0200
x86/kexec: Remove obsolete
>
> - if (evictee)
> - __brelse(evictee);
> + if (old)
> + __brelse(old);
> }
>
> /*
>
>
> more simple to understand and have better performance .
> am i understanding correctly ?
>
> > On Sep 28, 2015, at
From: Minfei Huang
Previously, UV NMI used 'in_crash_kexec' flag to be sure that we are in
kdump kernel or not in commit 5edd19af18a36a4e22c570b1b969179e0ca1fe4c
("x86, UV: Make kdump avoid stack dumps"). But this flags is removed in
commit 9c48f1c629ecfa114850c03f875c669
1 - 100 of 228 matches
Mail list logo
