Re: [Xen-devel] [V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-15 Thread Mukesh Rathor
On Fri, 12 Sep 2014 16:42:58 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Sep 10, 2014 at 04:36:06PM -0700, Mukesh Rathor wrote: sorry, i didn't realize you had more comments... didn't scroll down :).. > > cpumask_var_t xen_cpu_initialized_map; > > > > @@ -99,10 +

Re: [Xen-devel] [V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-15 Thread Mukesh Rathor
On Fri, 12 Sep 2014 16:42:58 -0400 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Sep 10, 2014 at 04:36:06PM -0700, Mukesh Rathor wrote: sorry, i didn't realize you had more comments... didn't scroll down :).. cpumask_var_t xen_cpu_initialized_map; @@ -99,10 +100,14

Re: [Xen-devel] [V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-12 Thread Mukesh Rathor
On Fri, 12 Sep 2014 16:42:58 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Sep 10, 2014 at 04:36:06PM -0700, Mukesh Rathor wrote: > > This fixes two bugs in PVH guests: > > > > - Not setting EFER.NX means the NX bit in page table entries is > > ignored on

Re: [Xen-devel] [V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-12 Thread Mukesh Rathor
On Fri, 12 Sep 2014 16:42:58 -0400 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Sep 10, 2014 at 04:36:06PM -0700, Mukesh Rathor wrote: This fixes two bugs in PVH guests: - Not setting EFER.NX means the NX bit in page table entries is ignored on Intel processors

[V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-10 Thread Mukesh Rathor
re jumping to cpu_bringup_and_idle(). Signed-off-by: Mukesh Rathor Signed-off-by: David Vrabel --- arch/x86/xen/enlighten.c | 6 ++ arch/x86/xen/smp.c | 29 ++--- arch/x86/xen/smp.h | 8 arch/x86/xen/xen-head.S | 33 + 4 files c

[V5 PATCH 0/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-10 Thread Mukesh Rathor
Hi, Attached V5 patch for fixing the EFER bugs on PVH. Changes in v5 (Mukesh): - Jan reminded us that vcpu 0 could go offline/online. So, add flag back instead of using cpuid to return from xen_pvh_early_cpu_init. - Boris comments: o Rename to xen_pvh_early_cpu_init o Add

[V5 PATCH 0/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-10 Thread Mukesh Rathor
Hi, Attached V5 patch for fixing the EFER bugs on PVH. Changes in v5 (Mukesh): - Jan reminded us that vcpu 0 could go offline/online. So, add flag back instead of using cpuid to return from xen_pvh_early_cpu_init. - Boris comments: o Rename to xen_pvh_early_cpu_init o Add

[V5 PATCH 1/1] x86/xen: Set EFER.NX and EFER.SCE in PVH guests

2014-09-10 Thread Mukesh Rathor
to cpu_bringup_and_idle(). Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com Signed-off-by: David Vrabel david.vra...@citrix.com --- arch/x86/xen/enlighten.c | 6 ++ arch/x86/xen/smp.c | 29 ++--- arch/x86/xen/smp.h | 8 arch/x86/xen/xen-head.S | 33

Re: [Xen-devel] [V2 PATCH 1/1] PVH: set EFER.NX and EFER.SCE

2014-09-03 Thread Mukesh Rathor
On Wed, 3 Sep 2014 14:58:04 +0100 David Vrabel wrote: > On 03/09/14 02:19, Mukesh Rathor wrote: > > This patch addresses two things for a pvh boot vcpu: > > > > - NX bug on intel: It was recenlty discovered that NX is not being > > honored in PVH on intel sin

Re: [Xen-devel] [V2 PATCH 1/1] PVH: set EFER.NX and EFER.SCE

2014-09-03 Thread Mukesh Rathor
On Wed, 3 Sep 2014 14:58:04 +0100 David Vrabel david.vra...@citrix.com wrote: On 03/09/14 02:19, Mukesh Rathor wrote: This patch addresses two things for a pvh boot vcpu: - NX bug on intel: It was recenlty discovered that NX is not being honored in PVH on intel since EFER.NX

[V2 PATCH 1/1] PVH: set EFER.NX and EFER.SCE

2014-09-02 Thread Mukesh Rathor
they come up on kernel page tables that have pte.NX bits set. As such, before anything is touched in DS/SS, EFER.NX must be set. Signed-off-by: Mukesh Rathor --- arch/x86/xen/enlighten.c | 3 +++ arch/x86/xen/smp.c | 28 arch/x86/xen/smp.h | 1 + arch

[V2 PATCH 0/1] PVH: set EFER bits

2014-09-02 Thread Mukesh Rathor
Changes from V1: - Unify the patches into one - Unify the code to set the EFER bits. thanks, Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[V2 PATCH 0/1] PVH: set EFER bits

2014-09-02 Thread Mukesh Rathor
Changes from V1: - Unify the patches into one - Unify the code to set the EFER bits. thanks, Mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[V2 PATCH 1/1] PVH: set EFER.NX and EFER.SCE

2014-09-02 Thread Mukesh Rathor
they come up on kernel page tables that have pte.NX bits set. As such, before anything is touched in DS/SS, EFER.NX must be set. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c | 3 +++ arch/x86/xen/smp.c | 28 arch/x86/xen

Re: [Xen-devel] [V1 PATCH 1/2] PVH: set EFER.NX and EFER.SCE for boot vcpu

2014-08-28 Thread Mukesh Rathor
On Thu, 28 Aug 2014 15:18:26 +0100 David Vrabel wrote: > On 27/08/14 23:33, Mukesh Rathor wrote: > > This patch addresses three things for a pvh boot vcpu: > > > > - NX bug on intel: It was recenlty discovered that NX is not being > > honored in PVH on intel sin

Re: [Xen-devel] [V1 PATCH 1/2] PVH: set EFER.NX and EFER.SCE for boot vcpu

2014-08-28 Thread Mukesh Rathor
On Thu, 28 Aug 2014 15:18:26 +0100 David Vrabel david.vra...@citrix.com wrote: On 27/08/14 23:33, Mukesh Rathor wrote: This patch addresses three things for a pvh boot vcpu: - NX bug on intel: It was recenlty discovered that NX is not being honored in PVH on intel since EFER.NX

[V1 PATCH 1/2] PVH: set EFER.NX and EFER.SCE for boot vcpu

2014-08-27 Thread Mukesh Rathor
. Signed-off-by: Mukesh Rathor --- arch/x86/xen/enlighten.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index c0cb11f..4af512d 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1499,6 +1499,17 @@ void

[V1 PATCH 0/2] Linux PVH: set EFER bits..

2014-08-27 Thread Mukesh Rathor
Resending with comments fixed up. Please note, these are no longer AMD only, but address existing broken boot and broken NX on intel. thanks mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

[V1 PATCH 2/2] PVH: set EFER.NX and EFER.SCE for secondary vcpus

2014-08-27 Thread Mukesh Rathor
is added. Please note: We create a new glue assembly entry point because the secondary vcpus come up on kernel page tables that have pte.NX bits set. While on Intel these are ignored if EFER.NX is not set, on AMD a RSVD bit fault is generated. Signed-off-by: Mukesh Rathor --- arch/x86/xen/smp.c

[V1 PATCH 2/2] PVH: set EFER.NX and EFER.SCE for secondary vcpus

2014-08-27 Thread Mukesh Rathor
is added. Please note: We create a new glue assembly entry point because the secondary vcpus come up on kernel page tables that have pte.NX bits set. While on Intel these are ignored if EFER.NX is not set, on AMD a RSVD bit fault is generated. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com

[V1 PATCH 0/2] Linux PVH: set EFER bits..

2014-08-27 Thread Mukesh Rathor
Resending with comments fixed up. Please note, these are no longer AMD only, but address existing broken boot and broken NX on intel. thanks mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

[V1 PATCH 1/2] PVH: set EFER.NX and EFER.SCE for boot vcpu

2014-08-27 Thread Mukesh Rathor
. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index c0cb11f..4af512d 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 12:09:27 -0700 Mukesh Rathor wrote: > On Fri, 22 Aug 2014 06:41:40 +0200 > Borislav Petkov wrote: > > > On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: > > > Intel doesn't have EFER.NX bit. > > > > Of course it does.

Re: [V0 PATCH 0/2] AMD PVH domU support

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 14:52:41 +0100 David Vrabel wrote: > On 21/08/14 03:16, Mukesh Rathor wrote: > > Hi, > > > > Here's first stab at AMD PVH domU support. Pretty much the only > > thing needed is EFER bits set. Please review. > > I'm not going to ac

Re: [V0 PATCH 0/2] AMD PVH domU support

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 14:55:21 +0100 David Vrabel wrote: > On 22/08/14 14:52, David Vrabel wrote: > > On 21/08/14 03:16, Mukesh Rathor wrote: > >> Hi, > >> > >> Here's first stab at AMD PVH domU support. Pretty much the only > >> thing needed is EFER bi

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 06:41:40 +0200 Borislav Petkov wrote: > On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: > > Intel doesn't have EFER.NX bit. > > Of course it does. > Right, it does. Some code/comment is misleading... Anyways, reading intel SDM

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 12:09:27 -0700 Mukesh Rathor mukesh.rat...@oracle.com wrote: On Fri, 22 Aug 2014 06:41:40 +0200 Borislav Petkov b...@alien8.de wrote: On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: Intel doesn't have EFER.NX bit. Of course it does. Right

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 06:41:40 +0200 Borislav Petkov b...@alien8.de wrote: On Thu, Aug 21, 2014 at 07:46:56PM -0700, Mukesh Rathor wrote: Intel doesn't have EFER.NX bit. Of course it does. Right, it does. Some code/comment is misleading... Anyways, reading intel SDMs, if I understand

Re: [V0 PATCH 0/2] AMD PVH domU support

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 14:55:21 +0100 David Vrabel david.vra...@citrix.com wrote: On 22/08/14 14:52, David Vrabel wrote: On 21/08/14 03:16, Mukesh Rathor wrote: Hi, Here's first stab at AMD PVH domU support. Pretty much the only thing needed is EFER bits set. Please review. I'm

Re: [V0 PATCH 0/2] AMD PVH domU support

2014-08-22 Thread Mukesh Rathor
On Fri, 22 Aug 2014 14:52:41 +0100 David Vrabel david.vra...@citrix.com wrote: On 21/08/14 03:16, Mukesh Rathor wrote: Hi, Here's first stab at AMD PVH domU support. Pretty much the only thing needed is EFER bits set. Please review. I'm not going to accept this until there is some

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-21 Thread Mukesh Rathor
On Thu, 21 Aug 2014 21:39:04 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Aug 20, 2014 at 07:16:39PM -0700, Mukesh Rathor wrote: > > On AMD, NX feature must be enabled in the efer for NX to be honored > > in the pte entries, otherwise protection fault. We also set SC for &

Re: [Xen-devel] [V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-21 Thread Mukesh Rathor
On Thu, 21 Aug 2014 21:39:04 -0400 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Aug 20, 2014 at 07:16:39PM -0700, Mukesh Rathor wrote: On AMD, NX feature must be enabled in the efer for NX to be honored in the pte entries, otherwise protection fault. We also set SC

[V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-20 Thread Mukesh Rathor
On AMD, NX feature must be enabled in the efer for NX to be honored in the pte entries, otherwise protection fault. We also set SC for system calls to be enabled. Signed-off-by: Mukesh Rathor --- arch/x86/xen/enlighten.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86

[V0 PATCH 0/2] AMD PVH domU support

2014-08-20 Thread Mukesh Rathor
Hi, Here's first stab at AMD PVH domU support. Pretty much the only thing needed is EFER bits set. Please review. thanks, Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[V0 PATCH 2/2] AMD-PVH: set EFER.NX and EFER.SCE for secondary vcpus

2014-08-20 Thread Mukesh Rathor
The secondary vcpus come on kernel page tables which have the NX bit set in pte entries for DS/SS. On AMD, EFER.NX must be set to avoid protection fault. Signed-off-by: Mukesh Rathor --- arch/x86/xen/smp.c | 28 arch/x86/xen/smp.h | 1 + arch/x86/xen/xen

[V0 PATCH 0/2] AMD PVH domU support

2014-08-20 Thread Mukesh Rathor
Hi, Here's first stab at AMD PVH domU support. Pretty much the only thing needed is EFER bits set. Please review. thanks, Mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[V0 PATCH 2/2] AMD-PVH: set EFER.NX and EFER.SCE for secondary vcpus

2014-08-20 Thread Mukesh Rathor
The secondary vcpus come on kernel page tables which have the NX bit set in pte entries for DS/SS. On AMD, EFER.NX must be set to avoid protection fault. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/smp.c | 28 arch/x86/xen/smp.h

[V0 PATCH 1/2] AMD-PVH: set EFER.NX and EFER.SCE for the boot vcpu

2014-08-20 Thread Mukesh Rathor
On AMD, NX feature must be enabled in the efer for NX to be honored in the pte entries, otherwise protection fault. We also set SC for system calls to be enabled. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c | 12 1 file changed, 12 insertions

Re: [Xen-devel] [V1 PATCH] dom0 pvh: map foreign pfns in our p2m for toolstack

2014-05-27 Thread Mukesh Rathor
On Tue, 27 May 2014 11:59:26 +0100 David Vrabel wrote: > On 27/05/14 11:43, Roger Pau Monné wrote: > > On 24/05/14 03:33, Mukesh Rathor wrote: > >> When running as dom0 in pvh mode, foreign pfns that are accessed > >> must be added to our p2m which is manag

Re: [Xen-devel] [V1 PATCH] dom0 pvh: map foreign pfns in our p2m for toolstack

2014-05-27 Thread Mukesh Rathor
On Tue, 27 May 2014 11:59:26 +0100 David Vrabel david.vra...@citrix.com wrote: On 27/05/14 11:43, Roger Pau Monné wrote: On 24/05/14 03:33, Mukesh Rathor wrote: When running as dom0 in pvh mode, foreign pfns that are accessed must be added to our p2m which is managed by xen. This is done

[V1 PATCH] dom0 pvh linux support

2014-05-23 Thread Mukesh Rathor
Hi, Attached please find patch for linux to support toolstack on pvh dom0. thanks, Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[V1 PATCH] dom0 pvh: map foreign pfns in our p2m for toolstack

2014-05-23 Thread Mukesh Rathor
When running as dom0 in pvh mode, foreign pfns that are accessed must be added to our p2m which is managed by xen. This is done via XENMEM_add_to_physmap_range hypercall. This is needed for toolstack building guests and mapping guest memory, xentrace mapping xen pages, etc.. Signed-off-by: Mukesh

[V1 PATCH] dom0 pvh linux support

2014-05-23 Thread Mukesh Rathor
Hi, Attached please find patch for linux to support toolstack on pvh dom0. thanks, Mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[V1 PATCH] dom0 pvh: map foreign pfns in our p2m for toolstack

2014-05-23 Thread Mukesh Rathor
When running as dom0 in pvh mode, foreign pfns that are accessed must be added to our p2m which is managed by xen. This is done via XENMEM_add_to_physmap_range hypercall. This is needed for toolstack building guests and mapping guest memory, xentrace mapping xen pages, etc.. Signed-off-by: Mukesh

Re: [PATCH] pvh: set cr4 flags for APs

2014-02-03 Thread Mukesh Rathor
On Mon, 3 Feb 2014 15:43:46 -0500 Konrad Rzeszutek Wilk wrote: > On Mon, Feb 03, 2014 at 02:52:40PM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Feb 03, 2014 at 11:30:01AM -0800, Mukesh Rathor wrote: > > > On Mon, 3 Feb 2014 06:49:14 -0500 > > > K

Re: [PATCH] pvh: set cr4 flags for APs

2014-02-03 Thread Mukesh Rathor
On Mon, 3 Feb 2014 06:49:14 -0500 Konrad Rzeszutek Wilk wrote: > On Wed, Jan 29, 2014 at 04:15:18PM -0800, Mukesh Rathor wrote: > > We need to set cr4 flags for APs that are already set for BSP. > > The title is missing the 'xen' part. The patch is for linux, not xen. >

Re: [PATCH] pvh: set cr4 flags for APs

2014-02-03 Thread Mukesh Rathor
On Mon, 3 Feb 2014 06:49:14 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Jan 29, 2014 at 04:15:18PM -0800, Mukesh Rathor wrote: We need to set cr4 flags for APs that are already set for BSP. The title is missing the 'xen' part. The patch is for linux, not xen. I

Re: [PATCH] pvh: set cr4 flags for APs

2014-02-03 Thread Mukesh Rathor
On Mon, 3 Feb 2014 15:43:46 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Mon, Feb 03, 2014 at 02:52:40PM -0500, Konrad Rzeszutek Wilk wrote: On Mon, Feb 03, 2014 at 11:30:01AM -0800, Mukesh Rathor wrote: On Mon, 3 Feb 2014 06:49:14 -0500 Konrad Rzeszutek Wilk konrad.w

Re: [PATCH V0] linux PVH: Set CR4 flags

2014-01-30 Thread Mukesh Rathor
On Thu, 30 Jan 2014 11:40:44 + Roger Pau Monné wrote: > On 30/01/14 00:15, Mukesh Rathor wrote: > > Konrad, > > > > The CR4 settings were dropped from my earlier patch because you > > didn't wanna enable them. But since you do now, we need to set them > &g

Re: [PATCH V0] linux PVH: Set CR4 flags

2014-01-30 Thread Mukesh Rathor
On Thu, 30 Jan 2014 11:40:44 + Roger Pau Monné roger@citrix.com wrote: On 30/01/14 00:15, Mukesh Rathor wrote: Konrad, The CR4 settings were dropped from my earlier patch because you didn't wanna enable them. But since you do now, we need to set them in the APs also. If you

[PATCH] pvh: set cr4 flags for APs

2014-01-29 Thread Mukesh Rathor
We need to set cr4 flags for APs that are already set for BSP. Signed-off-by: Mukesh Rathor --- arch/x86/xen/enlighten.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index a4d7b64..201d09a 100644

[PATCH V0] linux PVH: Set CR4 flags

2014-01-29 Thread Mukesh Rathor
Konrad, The CR4 settings were dropped from my earlier patch because you didn't wanna enable them. But since you do now, we need to set them in the APs also. If you decide not too again, please apply my prev patch "pvh: disable pse feature for now". thanks Mukesh -- To unsubscribe from this

[PATCH] pvh: set cr4 flags for APs

2014-01-29 Thread Mukesh Rathor
We need to set cr4 flags for APs that are already set for BSP. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/enlighten.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index a4d7b64

[PATCH V0] linux PVH: Set CR4 flags

2014-01-29 Thread Mukesh Rathor
Konrad, The CR4 settings were dropped from my earlier patch because you didn't wanna enable them. But since you do now, we need to set them in the APs also. If you decide not too again, please apply my prev patch pvh: disable pse feature for now. thanks Mukesh -- To unsubscribe from this list:

Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now

2014-01-28 Thread Mukesh Rathor
On Tue, 28 Jan 2014 10:39:23 + "Jan Beulich" wrote: > >>> On 28.01.14 at 03:18, Mukesh Rathor > >>> wrote: > > Until now, xen did not expose PSE to pvh guest, but a patch was > > submitted to xen list to enable bunch of features for a pvh guest

Re: [V0 PATCH] pvh: Disable PSE feature for now

2014-01-28 Thread Mukesh Rathor
On Mon, 27 Jan 2014 22:46:34 -0500 Konrad Rzeszutek Wilk wrote: > On Mon, Jan 27, 2014 at 06:18:39PM -0800, Mukesh Rathor wrote: > > Until now, xen did not expose PSE to pvh guest, but a patch was > > submitted to xen list to enable bunch of features for a pvh guest. >

Re: [V0 PATCH] pvh: Disable PSE feature for now

2014-01-28 Thread Mukesh Rathor
On Mon, 27 Jan 2014 22:46:34 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Mon, Jan 27, 2014 at 06:18:39PM -0800, Mukesh Rathor wrote: Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has

Re: [Xen-devel] [V0 PATCH] pvh: Disable PSE feature for now

2014-01-28 Thread Mukesh Rathor
On Tue, 28 Jan 2014 10:39:23 + Jan Beulich jbeul...@suse.com wrote: On 28.01.14 at 03:18, Mukesh Rathor mukesh.rat...@oracle.com wrote: Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has not been

[V0 PATCH] pvh: Disable PSE feature for now

2014-01-27 Thread Mukesh Rathor
Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has not been looked into for PVH, so until we can do that and test it to make sure it works, disable the feature to avoid flood of bugs. Signed-off-by: Mukesh

pvh: disable pse feature for now

2014-01-27 Thread Mukesh Rathor
Konrad, Following will turn off PSE in linux until we can get to it. It's better to turn it off here than in xen, so if BSD gets there sooner, they are not dependent on us. thanks Mukesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[V0 PATCH] pvh: Disable PSE feature for now

2014-01-27 Thread Mukesh Rathor
Until now, xen did not expose PSE to pvh guest, but a patch was submitted to xen list to enable bunch of features for a pvh guest. PSE has not been looked into for PVH, so until we can do that and test it to make sure it works, disable the feature to avoid flood of bugs. Signed-off-by: Mukesh

pvh: disable pse feature for now

2014-01-27 Thread Mukesh Rathor
Konrad, Following will turn off PSE in linux until we can get to it. It's better to turn it off here than in xen, so if BSD gets there sooner, they are not dependent on us. thanks Mukesh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-22 Thread Mukesh Rathor
On Mon, 20 Jan 2014 10:09:30 -0500 Konrad Rzeszutek Wilk wrote: > On Fri, Jan 17, 2014 at 06:24:55PM -0800, Mukesh Rathor wrote: > > pvh was designed to start with pv flags, but a commit in xen tree > > Thank you for posting this! > > > 51e2cac257ec8b4080d89f0855c49

Re: [V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-22 Thread Mukesh Rathor
On Mon, 20 Jan 2014 10:09:30 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri, Jan 17, 2014 at 06:24:55PM -0800, Mukesh Rathor wrote: pvh was designed to start with pv flags, but a commit in xen tree Thank you for posting this! 51e2cac257ec8b4080d89f0855c498cbbd76a5e5

[V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-17 Thread Mukesh Rathor
Konrad, The following patch sets the bits in CR0 and CR4. Please note, I'm working on patch for the xen side. The CR4 features are not currently exported to a PVH guest. Roger, I added your SOB line, please lmk if I need to add anything else. This patch was build on top of

[V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-17 Thread Mukesh Rathor
pvh was designed to start with pv flags, but a commit in xen tree 51e2cac257ec8b4080d89f0855c498cbbd76a5e5 removed some of the flags as they are not necessary. As a result, these CR flags must be set in the guest. Signed-off-by: Roger Pau Monne Signed-off-by: Mukesh Rathor --- arch/x86/xen

[V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-17 Thread Mukesh Rathor
pvh was designed to start with pv flags, but a commit in xen tree 51e2cac257ec8b4080d89f0855c498cbbd76a5e5 removed some of the flags as they are not necessary. As a result, these CR flags must be set in the guest. Signed-off-by: Roger Pau Monne roger@citrix.com Signed-off-by: Mukesh Rathor

[V0 PATCH] xen/pvh: set some cr flags upon vcpu start

2014-01-17 Thread Mukesh Rathor
Konrad, The following patch sets the bits in CR0 and CR4. Please note, I'm working on patch for the xen side. The CR4 features are not currently exported to a PVH guest. Roger, I added your SOB line, please lmk if I need to add anything else. This patch was build on top of

Re: [PATCH v12 10/18] xen/pvh: Update E820 to work with PVH (v2)

2014-01-03 Thread Mukesh Rathor
On Thu, 2 Jan 2014 13:41:34 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 02, 2014 at 04:14:32PM +, David Vrabel wrote: > > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > In xen_add_extra_mem() we can skip updat

Re: [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 12:35:55 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 02, 2014 at 05:34:38PM -0800, Mukesh Rathor wrote: > > On Thu, 2 Jan 2014 13:32:21 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > On Thu, Jan 02, 2014 at 03:32:33PM +, David Vrabel

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Wed, 18 Dec 2013 16:17:39 -0500 Konrad Rzeszutek Wilk wrote: > On Wed, Dec 18, 2013 at 06:31:43PM +, Stefano Stabellini wrote: > > On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > PVH is a PV guest wit

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 15:04:27 + Stefano Stabellini wrote: > On Tue, 31 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > > --- a/drivers/xen/xenbus/xenbus_client.c > > > > +++ b/drivers/xen/xenbus/xenbus_client.c > > > > @@ -45,6 +45,7 @@ > > > > #include > > > > #include > > > > #include > >

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 15:04:27 + Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 31 Dec 2013, Konrad Rzeszutek Wilk wrote: --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -45,6 +45,7 @@ #include xen/grant_table.h

Re: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.

2014-01-03 Thread Mukesh Rathor
On Wed, 18 Dec 2013 16:17:39 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Dec 18, 2013 at 06:31:43PM +, Stefano Stabellini wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com PVH is a PV guest with a twist

Re: [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

2014-01-03 Thread Mukesh Rathor
On Fri, 3 Jan 2014 12:35:55 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Thu, Jan 02, 2014 at 05:34:38PM -0800, Mukesh Rathor wrote: On Thu, 2 Jan 2014 13:32:21 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Thu, Jan 02, 2014 at 03:32:33PM +, David

Re: [PATCH v12 10/18] xen/pvh: Update E820 to work with PVH (v2)

2014-01-03 Thread Mukesh Rathor
On Thu, 2 Jan 2014 13:41:34 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Thu, Jan 02, 2014 at 04:14:32PM +, David Vrabel wrote: On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com In xen_add_extra_mem() we can skip updating

Re: [PATCH v12 06/18] xen/pvh: MMU changes for PVH (v2)

2014-01-02 Thread Mukesh Rathor
On Thu, 2 Jan 2014 11:24:50 + David Vrabel wrote: > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > From: Mukesh Rathor > > > > .. which are surprinsingly small compared to the amount for PV code. > > > > PVH uses mostly native mmu o

Re: [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

2014-01-02 Thread Mukesh Rathor
On Thu, 2 Jan 2014 13:32:21 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 02, 2014 at 03:32:33PM +, David Vrabel wrote: > > On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: > > > From: Mukesh Rathor > > > > > > In the bootup code for PVH we can trap c

Re: [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

2014-01-02 Thread Mukesh Rathor
On Thu, 2 Jan 2014 13:32:21 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Thu, Jan 02, 2014 at 03:32:33PM +, David Vrabel wrote: On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com In the bootup code for PVH we can trap

Re: [PATCH v12 06/18] xen/pvh: MMU changes for PVH (v2)

2014-01-02 Thread Mukesh Rathor
On Thu, 2 Jan 2014 11:24:50 + David Vrabel david.vra...@citrix.com wrote: On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com .. which are surprinsingly small compared to the amount for PV code. PVH uses mostly native mmu ops, we leave

Re: [Xen-devel] [PATCH v11 05/12] xen/pvh: Update E820 to work with PVH

2013-12-18 Thread Mukesh Rathor
On Wed, 18 Dec 2013 18:25:15 + Stefano Stabellini wrote: > On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > > From: Mukesh Rathor > > > > In xen_add_extra_mem() we can skip updating P2M as it's managed > > by Xen. PVH maps the entire IO spa

Re: [Xen-devel] [PATCH v11 05/12] xen/pvh: Update E820 to work with PVH

2013-12-18 Thread Mukesh Rathor
On Wed, 18 Dec 2013 18:25:15 + Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: From: Mukesh Rathor mukesh.rat...@oracle.com In xen_add_extra_mem() we can skip updating P2M as it's managed by Xen. PVH maps the entire IO

[PATCH V1]PVH: vcpu info placement, load CS selector, and remove debug printk.

2013-06-05 Thread Mukesh Rathor
This patch addresses 3 things: - Resolve vcpu info placement fixme. - Load CS selector for PVH after switching to new gdt. - Remove printk in case of failure to map pnfs in p2m. This because qemu has lot of expected failures when mapping HVM pages. Signed-off-by: Mukesh Rathor

Re: [Xen-devel] [PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-05 Thread Mukesh Rathor
On Wed, 05 Jun 2013 08:03:12 +0100 "Jan Beulich" wrote: > >>> On 04.06.13 at 23:53, Mukesh Rathor > >>> wrote: > > Following OK? : > > > > if (xen_feature(XENFEAT_auto_translated_physmap)) { > > s

Re: [Xen-devel] [PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-05 Thread Mukesh Rathor
On Wed, 05 Jun 2013 08:03:12 +0100 Jan Beulich jbeul...@suse.com wrote: On 04.06.13 at 23:53, Mukesh Rathor mukesh.rat...@oracle.com wrote: Following OK? : if (xen_feature(XENFEAT_auto_translated_physmap)) { switch_to_new_gdt(0); asm

[PATCH V1]PVH: vcpu info placement, load CS selector, and remove debug printk.

2013-06-05 Thread Mukesh Rathor
This patch addresses 3 things: - Resolve vcpu info placement fixme. - Load CS selector for PVH after switching to new gdt. - Remove printk in case of failure to map pnfs in p2m. This because qemu has lot of expected failures when mapping HVM pages. Signed-off-by: Mukesh Rathor

Re: [Xen-devel] [PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-04 Thread Mukesh Rathor
On Tue, 04 Jun 2013 09:27:03 +0100 "Jan Beulich" wrote: > >>> On 04.06.13 at 02:43, Mukesh Rathor > >>> wrote: > > @@ -1327,6 +1329,18 @@ static void __init > > xen_setup_stackprotector(void) /* PVH TBD/FIXME: investigate > &g

Re: [Xen-devel] [PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-04 Thread Mukesh Rathor
On Tue, 04 Jun 2013 09:27:03 +0100 Jan Beulich jbeul...@suse.com wrote: On 04.06.13 at 02:43, Mukesh Rathor mukesh.rat...@oracle.com wrote: @@ -1327,6 +1329,18 @@ static void __init xen_setup_stackprotector(void) /* PVH TBD/FIXME: investigate setup_stack_canary_segment

[PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-03 Thread Mukesh Rathor
This patch addresses 3 things: - Resolve vcpu info placement fixme. - Load DS/SS/CS selectors for PVH after switching to new gdt. - Remove printk in case of failure to map pnfs in p2m. This because qemu has lot of benign failures when mapping HVM pages. Signed-off-by: Mukesh Rathor

[PATCH] PVH: vcpu info placement, load selectors, and remove debug printk.

2013-06-03 Thread Mukesh Rathor
This patch addresses 3 things: - Resolve vcpu info placement fixme. - Load DS/SS/CS selectors for PVH after switching to new gdt. - Remove printk in case of failure to map pnfs in p2m. This because qemu has lot of benign failures when mapping HVM pages. Signed-off-by: Mukesh Rathor

[PATCH]: PVH linux: don't print warning in case of failed mapping

2013-02-15 Thread Mukesh Rathor
Remove the printing of warning in case of failed mappings. Sometimes they are expected as in case of Qemu mapping pages during HVM guest creation. Signed-off-by: Mukesh Rathor --- arch/x86/xen/mmu.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/mmu.c b

[PATCH]: PVH linux: don't print warning in case of failed mapping

2013-02-15 Thread Mukesh Rathor
Remove the printing of warning in case of failed mappings. Sometimes they are expected as in case of Qemu mapping pages during HVM guest creation. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com --- arch/x86/xen/mmu.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff

Re: [PATCH] PVH: remove code to map iomem from guest

2013-02-06 Thread Mukesh Rathor
On Wed, 6 Feb 2013 10:39:13 -0500 Konrad Rzeszutek Wilk wrote: > On Wed, Jan 30, 2013 at 02:55:29PM -0800, Mukesh Rathor wrote: > > It was decided during xen patch review that xen map the iomem > > transparently, so remove xen_set_clr_mmio_pvh_pte() and the sub > > hypercal

Re: [PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-06 Thread Mukesh Rathor
On Wed, 6 Feb 2013 10:49:13 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Jan 31, 2013 at 06:30:15PM -0800, Mukesh Rathor wrote: > > This patch fixes a fixme in Linux to use alloc_xenballooned_pages() > > to allocate pfns for grant table pages instead of kmalloc. This also >

Re: [PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-06 Thread Mukesh Rathor
On Wed, 6 Feb 2013 10:49:13 -0500 Konrad Rzeszutek Wilk kon...@darnok.org wrote: On Thu, Jan 31, 2013 at 06:30:15PM -0800, Mukesh Rathor wrote: This patch fixes a fixme in Linux to use alloc_xenballooned_pages() to allocate pfns for grant table pages instead of kmalloc. This also

Re: [PATCH] PVH: remove code to map iomem from guest

2013-02-06 Thread Mukesh Rathor
On Wed, 6 Feb 2013 10:39:13 -0500 Konrad Rzeszutek Wilk kon...@darnok.org wrote: On Wed, Jan 30, 2013 at 02:55:29PM -0800, Mukesh Rathor wrote: It was decided during xen patch review that xen map the iomem transparently, so remove xen_set_clr_mmio_pvh_pte() and the sub hypercall

[PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-05 Thread Mukesh Rathor
This patch fixes a fixme in Linux to use alloc_xenballooned_pages() to allocate pfns for grant table pages instead of kmalloc. This also simplifies add to physmap on the xen side a bit. Signed-off-by: Mukesh Rathor diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 9c0019d

[PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-05 Thread Mukesh Rathor
This patch fixes a fixme in Linux to use alloc_xenballooned_pages() to allocate pfns for grant table pages instead of kmalloc. This also simplifies add to physmap on the xen side a bit. Signed-off-by: Mukesh Rathor mukesh.rat...@oracle.com diff --git a/drivers/xen/grant-table.c b/drivers/xen

Re: [Xen-devel] [PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-01 Thread Mukesh Rathor
On Fri, 1 Feb 2013 14:00:58 -0800 Mukesh Rathor wrote: > On Thu, 31 Jan 2013 18:44:46 -0800 > Mukesh Rathor wrote: > > > On Thu, 31 Jan 2013 18:30:15 -0800 > > Mukesh Rathor wrote: > > > > > This patch fixes a fixme in Linux to use > > > alloc_xe

Re: [Xen-devel] [PATCH] PVH linux: Use ballooning to allocate grant table pages

2013-02-01 Thread Mukesh Rathor
On Thu, 31 Jan 2013 18:44:46 -0800 Mukesh Rathor wrote: > On Thu, 31 Jan 2013 18:30:15 -0800 > Mukesh Rathor wrote: > > > This patch fixes a fixme in Linux to use alloc_xenballooned_pages() > > to allocate pfns for grant table pages instead of kmalloc. This also > >

  1   2   >